Re: [OS-BUILD PATCH] Fix dist-get-buildreqs breakage around perl(ExtUtils::Embed)
From: Tales Aparecida on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2924#note_1759038051 That's true! Can't use quotes here :see_no_evil: -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Fix dist-get-buildreqs breakage around perl(ExtUtils::Embed)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2924#note_1759026096 @tales-aparecida - hmm I did the double quote : sudo dnf install "$missing" and dnf complained it couldn't find the package named: "\". So it treats the list as a single package which doesn't work. :-/ -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Fix dist-get-buildreqs breakage around perl(ExtUtils::Embed)
From: Scott Weaver on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2924#note_1759024385 You're right. This is safe because of the variable expansion. Thanks! -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Fix dist-get-buildreqs breakage around perl(ExtUtils::Embed)
From: Tales Aparecida on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2924#note_1759022786 I can't reproduce this error using a variable locally so I believe it would be safe, however we tend to follow shellcheck recommendation to [double quote to prevent globbing and word splitting](https://www.shellcheck.net/wiki/SC2086)... So I'd approve if you sent it :grin: -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Fix dist-get-buildreqs breakage around perl(ExtUtils::Embed)
From: Scott Weaver on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2924#note_1758981394 @tales-aparecida does the gitlab ci environment take care such things and so we shouldn't expect to see this kind of syntax error? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Fix dist-get-buildreqs breakage around perl(ExtUtils::Embed)
From: Scott Weaver on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2924#note_1758970310
This does fix the parsing error but I believe the `perl(ExtUtils::Embed)`
package will need to be enclosed in quotes or it will result in a shell error.
```
$ sudo dnf install perl(ExtUtils::Embed)
bash: syntax error near unexpected token `('
```
--
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Fix dist-get-buildreqs breakage around perl(ExtUtils::Embed)
From: Don Zickus Fix dist-get-buildreqs breakage around perl(ExtUtils::Embed) CKI fails with $ export missing=$(make dist-get-buildreqs | grep "Missing dependencies:" | cut -d":" -f2) $ if [ "$missing" == "" ]; then echo "Missing dependencies should not be null but are empty. Review test log." && exit 1; fi; $ dnf -y install $missing Last metadata expiration check: 0:00:29 ago on Sat Feb 3 23:44:30 2024. No match for argument: perl(ExtUtils Error: Unable to find a match: perl(ExtUtils This is because it was trying to "cut -d':' -f2" this line: Missing dependencies: perl(ExtUtils::Embed) And it grabbed the content between the ':', leaving out ::Embed. Easy fix, convert cut's parameter '-f2' to '-f2-' to included everything after the first ':'. Running the command locally resolves the issue. Signed-off-by: Don Zickus diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index blahblah..blahblah 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -461,10 +461,10 @@ test_makefile: - git config user.name "Fedora Kernel Team" - git config user.email "kernel-t...@fedoraproject.org" script: -- export missing=$(make dist-get-buildreqs | grep "Missing dependencies:" | cut -d":" -f2) +- export missing=$(make dist-get-buildreqs | grep "Missing dependencies:" | cut -d":" -f2-) - if [ "$missing" == "" ]; then echo "Missing dependencies should not be null but are empty. Review test log." && exit 1; fi; - dnf -y install $missing -- export missingafter=$(make dist-get-buildreqs | grep "Missing dependencies:" | cut -d":" -f2) +- export missingafter=$(make dist-get-buildreqs | grep "Missing dependencies:" | cut -d":" -f2-) - if [ "$missingafter" != "" ]; then echo "Missing dependencies should be null but are $missingafter. Review test log." && exit 1; fi; rules: - *only-os-build-mr -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2924 -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
