Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_1065198628 Closing in favor of https://gitlab.com/cki-project/kernel- ark/-/merge_requests/1900 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_1022391710 @dzickusrh where does this stand? If nothing else it needs to be rebased... ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Ondrej Mosnáček on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_952625567 This feels like it should be deduped somehow... maybe by putting it into its own `check_deps.sh` script, which would get PKGLIST via argv? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Ondrej Mosnáček on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_952625563 This needs to include also `glibc-static`, which is known to affect config processing. Also possibly `gcc-c++` (for getting compiler capabilities during config generation) and `xz` (for compressing the tarball) might bee needed, too. I guess also `bash` and `coreutils`, but without those you wouldn't even get to the check, so not sure if it makes sense to add them :smile: ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951732268 Oh and @omos filed this https://gitlab.com/cki-project/kernel- ark/-/merge_requests/1781 because he got hit with my buildreqs change from last week. That MR kinda undoes the check and defeats the spirit of it. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951720936 @hertonrk-rh @prarit @jmflinuxtx To answer a variety of questions. Yes srpm processes the configs. It kinda has to otherwise what is rpmbuild going to use to build the kernel? :-) Why is this an issue now? It popped up with my MR last week actually fixing how this works (otherwise the dep was only rpmbuild). Some folks do not want to install the full list of buildreqs just to generate a srpm and upload it. Especially for users on Fedora trying to build a RHEL-X srpm and don't want to have to install obsoleted or missing RHEL-X buildreqs (system-sb-certs, llvm- tools, etc). As for 'dnf builddep kernel' that could work too in some cases. One quirk with that approach is it needs to match the kernel in development, so a RHEL kernel on a Fedora distro may not work. But we can advertise this too if we want. I am also looking at the docs here: https://cki-project.gitlab.io/kernel- ark/#cloning-the-repository should either be auto-generated or told to use 'dnf builddep kernel'. I am working with COPR and they didn't have an easy way to install the packages necessary to build the srpm other than guessing. I am trying to improve the user experience git clone make dist-srpmbuildreqs-check | sudo dnf install (??) make dist-srpm koji build or something like that. IOW there is a gap here that I am trying to address with a consistent story. Something that isn't complicated (yeah, this MR leans toward complicated). Thoughts? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951641657 @hertonrk-rh @jmflinuxtx : I think we just all asked the same question of @dzickusrh, but in slightly different ways :smile: ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951633741 srpm generation does process configs. While you may not need full deps for a proper config check, there are some which are required. That was what I meant about this being a new list we will have to maintain. Which buildreq's are critical? I am somewhat curious as to what the driver is for this though. Is it the space required, or just having to manually install all of the deps? If it is the later, 'sudo dnf builddep kernel' makes it pretty easy. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951631511 However, what about the case srpm builds correctly, but configs fail on build, due an extra buildrequires that is now present? In that case, I believe SPECSRPMBUILDREQS needs some packages added, like glibc-static. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951629181 or change the dist-config-check dependencies to add dist-buildreq-check, I supposed it can work. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951627747 I believe you need to add a new dist-configs-prep-rpm and dist-configs-prep- srpm: srpm generation does not process configs right? But other targets that may process it will need full build requires because some package missing can change the config generation. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check
From: Don Zickus on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786 Developers want to build a srpm locally and submit it to a build server like Koji. The current process checks the BuildRequires in the kernel.spec file to ensure all the right packages are there. However, that list includes too many packages. Reduce the list to the bare minimum. In addition cleanup the Makefile and utilize the original buildreqs-check target better. Signed-off-by: Don Zickus --- redhat/Makefile | 33 - redhat/genspec.sh | 1 + redhat/kernel.spec.template | 7 --- 3 files changed, 29 insertions(+), 12 deletions(-) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
