Re: [OS-BUILD PATCH 3/3] [redhat] Add dist-buildreq-check for binary rpm builds

[Don Zickus (via Email Bridge)]

From: Don Zickus on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951723323

Sure, but it doesn't describe why some rpmbuild commands get it, while others
do not.  Hence the -binary part.  If you are building binaries you needed the
extra suffix.  This makes it clear for future targets.  While the rule is the
same for your name, it doesn't appear to be as clear to me.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Re: [OS-BUILD PATCH 3/3] [redhat] Add dist-buildreq-check for binary rpm builds

[Prarit Bhargava (via Email Bridge)]

From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951632878



I understand why you've named this 'do-rpmbuild-binary' but I think that
will be confusing to a casual reader.  At first glance I thought it
implied that do-rpmbuild is for generating SRPMs only.  Perhaps a better
name here would be 'do-rpmbuild-buildreq-check'?  I realize that is an
annoyingly long name but it does describe what the target actually does.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[OS-BUILD PATCH 3/3] [redhat] Add dist-buildreq-check for binary rpm builds

[Don Zickus (via Email Bridge)]

From: Don Zickus 

[redhat] Add dist-buildreq-check for binary rpm builds

By simplifying the package check to srpm only, we neglect to check
the packaging for local binary rpm building.  Add that Makefile
dependency for those cases.

Signed-off-by: Don Zickus 

diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -573,8 +573,10 @@ dist-test-patch: generate-testpatch-tmp
 do-rpmbuild: dist-sources
$(RPMBUILD) --define "_sourcedir $(SOURCES)" --define "_builddir 
$(RPM)/BUILD" --define "_srcrpmdir $(RPM)/SRPMS" --define "_rpmdir $(RPM)/RPMS" 
--define "_specdir $(RPM)/SPECS" --define "dist $(DIST)" $(RPMBUILDOPTS) 
$(RPM)/SOURCES/$(PACKAGE_NAME).spec
 
+do-rpmbuild-binary: dist-buildreq-check do-rpmbuild
+
 dist-all-rpms: RPMBUILDOPTS=--target $(MACH) -ba
-dist-all-rpms: do-rpmbuild
+dist-all-rpms: do-rpmbuild-binary
 
 dist-srpm: RPMBUILDOPTS=--nodeps -bs
 dist-srpm: do-rpmbuild
@@ -584,19 +586,19 @@ dist-srpm-gcov: BUILDOPTS+=+gcov
 dist-srpm-gcov: dist-srpm
 
 dist-rpms: RPMBUILDOPTS=--target $(MACH) -bb
-dist-rpms: do-rpmbuild
+dist-rpms: do-rpmbuild-binary
 
 dist-kernel-%:
-   RPMBUILDOPTS="--target $(MACH) --with $* -bb" make do-rpmbuild
+   RPMBUILDOPTS="--target $(MACH) --with $* -bb" make do-rpmbuild-binary
 
 dist-prep: RPMBUILDOPTS=--nodeps --target noarch -bp
 dist-prep: do-rpmbuild
 
 dist-perf: RPMBUILDOPTS=--without up --without smp --without zfcpdump 
--without debug --without doc --without headers --without  --without doc 
--without debuginfo --target $(MACH) -bb
-dist-perf: do-rpmbuild
+dist-perf: do-rpmbuild-binary
 
 dist-rpm-baseonly: RPMBUILDOPTS=--target $(MACH) --without debug --without 
debuginfo --without vdso_install --without bpftool --without perf --without 
tools -bb
-dist-rpm-baseonly: do-rpmbuild
+dist-rpm-baseonly: do-rpmbuild-binary
 
 # unless you know what you're doing, you don't want to use the next four ones
 dist-release-finish: setup-source

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure