Re: [OS-BUILD PATCH] Make RHJOBS container friendly
From: Michael Hofmann on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2375#note_1321311286 iiuc, nproc is coreutils -> gnulib -> https://github.com/coreutils/gnulib/blob/master/lib/nproc.c, which doesn't seem to know anything about these newfangled things like cgroups v1/v2 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Make RHJOBS container friendly
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2375#note_1321278887 Hmm, as an end user it seems odd to have to know what cgroup version and other quirks are on the system to make correctly calculations. I would think that would be part of nproc's calculation which would hide things from the end user. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Make RHJOBS container friendly
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2375#note_1321270325 Yeah, I've known about the cgroups problem but never really had time to address it. I think that this change at least makes things no less better or worse that what we currently have so it's safe to do. IMO, we should look into a better value of RHJOBS taking into account your code above. But that can be done in another MR. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Make RHJOBS container friendly
From: Michael Hofmann on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2375#note_1321162650 just to be clear, that will still not take cgroup limits into account, so any Docker/Kubernetes deployment that just applies "Limits" will still see all cpus on the host machine. For comparison, this is what CKI needs to do to keep parallel jobs from exploding on 96 core k8s nodes: https://gitlab.com/cki- project/pipeline-definition/-/blob/main/pipeline/functions/general.yml#L113 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
