[Kernel-packages] [Bug 2039325] Re: mmc: sdhci-of-dwcmshc: Intermittent data error under stress test

2023-11-06 Thread Meriton Tuli
** Tags removed: verification-needed-jammy-linux-bluefield
** Tags added: verification-done-jammy-linux-bluefield

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2039325

Title:
  mmc: sdhci-of-dwcmshc: Intermittent data error under stress test

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  sdhci-dwcmshc MLNXBF30:00: __mmc_blk_ioctl_cmd: data error -110

  SRU Justification:

  [Impact]
  This change is needed to avoid intermittent "sdhci-dwcmshc MLNXBF30:00: 
__mmc_blk_ioctl_cmd: data error -110" error under stress test

  [Fix]
  The fix added a quirk for the BF3 sdhci driver to avoid such data error.

  [Test Case]
  1. Same functionality and testing as on BlueField-1/2.
  2. Install OS on NVME, and run the FIO test on EMMC.
  fio --name=mmcblk0_randrw_stress_round_1 \
--ioengine=libaio --direct=1  --time_based=1 \
--end_fsync=1 --ramp_time=5 --norandommap=1 \
--randrepeat=0 --group_reporting=1 --numjobs=8 \
--iodepth=128 --rw=randrw --overwrite=1 \
--runtime=3600 --bs=4K --filename=/dev/mmcblk0 &

  
  [Regression Potential]
  Same behavior from user perspective.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2039325/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2017600] Re: Move CONFIG_NF_CONNTRACK to build in

2023-06-13 Thread Meriton Tuli
** Tags added: verification-done-f

** Tags removed: verification-done-f
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2017600

Title:
  Move CONFIG_NF_CONNTRACK to build in

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  SRU Justifications:

  The bpf helper bpf_ct_lookup_tcp is defined under #if
  IS_BUILTIN(CONFIG_NF_CONNTRACK). To work with BPF, this is needed.

  How to test:

  Test XDP BPF

  What could be break:

  N/A

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2017600/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2012743] Re: Support Nvidia BlueField-3 GPIO driver and pin controller

2023-05-16 Thread Meriton Tuli
** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2012743

Title:
  Support Nvidia BlueField-3 GPIO driver and pin controller

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  Support the BlueField-3 SoC GPIO driver for handling interrupts and providing 
the option to change the direction and value of a GPIO.
  Support the BlueField-3 SoC pin controller driver for allowing a select 
number of GPIO pins to be manipulated from userspace or the kernel.

  All these changes have been accepted for upstream but most of them are
  not yet in the tree/branches.

  PLEASE NOTE: This change is dependent on changes done in the ACPI
  tables. So the UEFI image needs to be updated accordingly.

  [Fix]

  * Add support for the BlueField-3 SoC GPIO driver.
  This driver configures and handles GPIO interrupts. It also enables a user to 
manipulate certain GPIO pins via libgpiod tools or other kernel drivers.
  The usable pins are defined via the "gpio-reserved-ranges" property.

  * NVIDIA BlueField-3 SoC has a few pins that can be used as GPIOs or
  take the default hardware functionality. Add a driver for the pin
  muxing.

  * The following gpiolib commits are bug fixes and are required for the gpio 
driver to work:
  443a0a0f0cf4f432c7af6654b7f2f920d411d379

  Although the following have been accepted by maintainers, they are not 
present in any tree/branch yet so
  these will be pushed as SAUCE for now:
  [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio_init()
  [PATCH v1] gpio: mmio: fix calculation of bgpio_bits

  [Test Case]

  * Check if the gpio-mlxbf3 driver is loaded
  * Check if the pinctrl-mlxbf3 driver is loaded
  * check if the mlxbf-gige driver is loaded
  * check if the pwr-mlxbf driver is loaded
  * Check that the oob_net0 interface is up and operational
  * Do reset and powercycle and check the oob_net0 interface again
  * Test power GPIO interrupt on BF3.

  [Regression Potential]

  * The Mellanox drivers could fail to be loaded.
  * The mlxbf-gige PHY interrupt or pwr-mlxbf interrupt could fail.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2012743/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2012649] Re: mlxbf_gige: need to replace SAUCE patches with upstream commits

2023-05-16 Thread Meriton Tuli
** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2012649

Title:
  mlxbf_gige: need to replace SAUCE patches with upstream commits

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  The GIGE driver ("mlxbf_gige") in the Jammy repo contains SAUCE
  patches that enable BlueField-3 support.  This same functionality
  is contained in upstream commits and Jammy repo should utilize them.

  [Fix]
  The BlueField-3 support will be provided in the form of a set
  of upstream patches, to be sent in as a pull request.

  [Test Case]
  Should test on both BlueField-2 & BlueField-3: 
 Boot platform and bring up "oob_net0" interface properly
 Test that network traffic works properly

  [Regression Potential]
  The upstream commits have been reviewed and tested well,
  so there should be low risk of regression.

  [Other]
  n/a

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2012649/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2013383] Re: mlxbf-bootctl: support SMC call for setting ARM boot state

2023-05-16 Thread Meriton Tuli
Using 5.15.0-1015-bluefield, the following file exists:
# ll /sys/devices/platform/MLNXBF04\:00/driver/os_up
--w--- 1 root root 4096 May 11 21:02 
/sys/devices/platform/MLNXBF04:00/driver/os_up

** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2013383

Title:
  mlxbf-bootctl: support SMC call for setting ARM boot state

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Focal:
  In Progress
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  Add a new SMC call which allows setting the ARM boot progress state to
  "OS is up".

  [Fix]

  * Add a new SMC call in mlxbf-bootctl which allows setting the ARM
  boot progress state to "OS is up".

  [Test Case]

  * Check that /sys/devices/platform/MLNXBF04:00/driver/os_up exists

  [Regression Potential]

  * No known regression because it is just adding a sysfs entry. It is
  backward compatible with older TAF images. If the SMC call is not
  supported by ATF, it is ignored.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2013383/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2015292] Re: Missing ACPI device info in mlxbf_pka module

2023-04-17 Thread Meriton Tuli
Using kernel 5.15.0-1015.17, BlueField ATF version:
v2.2(release):4.0.2-12-gdc90016, BlueField UEFI version:
4.0.2-6-ge89d91b, BlueField BSP version: 4.0.2.12660 this issue has been
fixed

** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2015292

Title:
  Missing ACPI device info in mlxbf_pka module

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  SRU Justification

  [Impact]
  Bluefield 3 ACPI/Window RAM configuration and related code is missing. This 
affects BF3 functionality w/ PKA Ring character devices being created correctly.

  [Fix]
  * Added ACPI config and code to detect BF3 hardware and provision the Ring 
devices correctly.

  [Test Case]
  * Tested on BF3 with mlxbf-pka module load and check the /dev/pka/ Ring 
char devices are created with correct number of entries.
  * Tested with "openssl speed -engine pka -async_jobs 8 rsa" and verified the 
performance number show the PKA acceleration in place.

  [Potential Regression]
  * This fix has been tested with varieties of BF3: MB and HB cards.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2015292/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2008136] Re: netfilter: flowtable: add counter support in HW offload

2023-04-12 Thread Meriton Tuli
** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2008136

Title:
  netfilter: flowtable: add counter support in HW offload

Status in linux-bluefield package in Ubuntu:
  New
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  * Explain the bug(s)

  While conntrack tuples are offloaded to hardware and conntrack packet
  accounting is enabled, offloaded packets aren't counted.

  * Brief explanation of fixes

  Cherry-pick. No adaptation. First commit for SW, second commit of HW 
offloaded rules.
  ef803b3cf96a netfilter: flowtable: add counter support in HW offload
  9312eabab4a6 netfilter: conntrack: add nf_ct_acct_add()

  note: need to change a little due to cherry-pick conflict with
  24384e28586c netfilter: flowtable: Set offload timeouts according to proto 
values

  * How to test
  Create OVS bridge with 2 devices mlx5 rep devices.
  Enable HW offload and configure regular connection tracking OpenFlow rules:

  e.g:
  ovs-ofctl del-flows br-ovs
  ovs-ofctl add-flow br-ovs arp,actions=normal
  ovs-ofctl add-flow br-ovs "table=0, ip,ct_state=-trk actions=ct(table=1)"
  ovs-ofctl add-flow br-ovs "table=1, ip,ct_state=+trk+new 
actions=ct(commit),normal"
  ovs-ofctl add-flow br-ovs "table=1, ip,ct_state=+trk+est, actions=normal"

  Run a TCP connection, e.g:
  on mlx5 VF1 iperf -s
  on mlx5 VF2 iperf -c  -t 10

  Optional: In different terminal, while traffic is running, check for offload:
  tcpdump -nnepi  tcp

  and see no iperf tcp packets.
  Dump conntrack with relevant ip:
  echo "1" > /proc/sys/net/netfilter/nf_conntrack_acct
  cat /proc/net/nf_conntrack | grep -i 

  See counters (packets=.*) advancing while tuples were offloaded:
  ipv4 2 tcp  6 src=1.1.1.2 dst=1.1.1.3 sport=56394 dport=5001 
packets=2 bytes=112 src=1.1.1.3 dst=1.1.1.2 sport=5001 dport=56394 packets=1777 
bytes=665340 [HW_OFFLOAD] mark=0 zone=0 use=3

  * What it could break.

  Nothing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2008136/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2007581] Re: gpio: Restrict usage of GPIO chip irq members before initialization

2023-04-12 Thread Meriton Tuli
** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2007581

Title:
   gpio: Restrict usage of GPIO chip irq members before initialization

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  GPIO chip irq members are exposed before they could be completely
  initialized and this leads to race conditions.

  One such issue was observed for the gc->irq.domain variable which
  was accessed through the pwr-mlxbf.c driver in gpiochip_to_irq() before
  it could be initialized by gpiochip_add_irqchip(). This resulted in
  Kernel NULL pointer dereference. This is a well known issue in the linux 
community
  and was fixed via 2 commits:
  5467801f1fcbdc46bc7298a84dbf3ca1ff2a7320
  and
  06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 (since the previous commit caused a 
regression)

  This race condition is intermittent and hard to reproduce.

  [Fix]

  * Cherry pick: 5467801f1fcbdc46bc7298a84dbf3ca1ff2a7320 to fix the bug at 
stake
  * cherry-pick: 06fb4ecfeac7e00d6704fa5ed19299f2fefb3cc9 to fix a regression 
introduced by the previous commit

  [Test Case]

  * Check that the gpio-mlxbf2.c driver is loaded with no kernel panic
  * check that all drivers dependent on gpio-mlxbf2.c driver are loaded 
(mlxbf-gige and pwr-mlxbf)
  * do 5000 reboots to make sure this race condition no longer happens

  [Regression Potential]

  This could cause some regression with the use of gpio interrupts so it is 
important to test the dependent
  drivers mlxbf-gige and pwr-mlxbf. Trigger power reset interrupt to test 
pwr-mlxbf and bring down/up the 
  oob_net0 interface to test mlxbf-gige.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2007581/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2008833] Re: mlxbf-gige: Fix intermittent no ip issue

2023-03-23 Thread Meriton Tuli
** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2008833

Title:
  mlxbf-gige: Fix intermittent no ip issue

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  Although the link is up, and the PHY interrupt is cleared, there is no
  ip assigned. Nothing is being transmitted, and nothing is received.
  The RX error count keeps on increasing (check ifconfig oob_net0).
  After several minutes, the RX error count stagnates and the oob
  finally gets an ip and is pingable.

  [Fix]

  The issue is in the mlxbf_gige_rx_init function. As soon as the RX DMA is 
enabled,
  the RX CI reaches the max 128, it becomes equal to RX PI. And RX CI doesn't 
decrease
  since the code hasn't ran phy_start yet. The solution is to move the rx init 
after phy_start.
  This fix applies to both 5.4 and 5.15.

  [Test Case]

  * Check if the gige driver is loaded
  * Check that the oob_net0 interface is up and pingable from an external host
  * Do at ~1000 resets and powercycles and check the oon_net0 interface again

  [Regression Potential]

  * No known regressions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2008833/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2002361] Re: allow per-net notifier to follow netdev into namespace

2023-03-01 Thread Meriton Tuli
** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2002361

Title:
  allow per-net notifier to follow netdev into namespace

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  
  * Explain the bug(s)
  There is possible deadlock during reload mlxsw into initial netns made 
possible by commit:
  328fbe747ad4 ("net: Close race between {un, }register_netdevice_notifier() 
and setup_net()/cleanup_net()").

  * Brief explanation of fixes
  Introduce dev_net variant that is basically per-net notifier with an
  extension that re-registers the per-net notifier upon netdev namespace
  change. Basically the per-net notifier follows the netdev into
  namespace.

  
  * How to test 
  # chroot /host nsenter -t 1 -n devlink dev reload ${port} netns ${NS}
   
  * What it could break
  none

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2002361/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1995296] Re: mlx-bootctl: support icm carveout eeprom region read/write

2023-02-17 Thread Meriton Tuli
** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1995296

Title:
  mlx-bootctl: support icm carveout eeprom region read/write

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  The BlueField-3 ICM carveout feature will enable NIC FW to bypass the SMMU 
block to access DRAM memory.
  The amount of memory accessible by FW will be controlled by ARM. This patch 
enables setting the size of the large ICM carveout from userspace. The max size 
is 1TB, has a granularity of 128MB and will be passed
  and printed in hex. The size unit is MB.

  [Fix]

  * Support SMC calls to control the large ICM carveout size.

  [Test Case]

  * Only valid testing on BlueField-3 real hardware.
  * set the region size from sysfs and NIC FW will test that it has access to 
the entire region requested.

  [Regression Potential]

  * This code doesn't really have a negative impact on the functionality of the 
mlxbf-bootctl driver itself but could be a risk for the overall boot if not 
used/tested properly.
  * memory region requested is too large, adn linux cannot boot as a result. 
The memory allocated for the ICM carveout cannot be accessed by linux.
  * the icmc size is not passed properly to NIC FW

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1995296/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1994897] Re: Support BlueField-3 GPIO driver

2023-02-17 Thread Meriton Tuli
# dmesg | grep gpio
[5.166183] gpio_mlxbf3: loading out-of-tree module taints kernel.
[5.195583] mlxbf3_gpio MLNXBF33:01: IRQ index 0 not found
# lsmod | grep gpio
gpio_mlxbf320480  2

** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1994897

Title:
  Support BlueField-3 GPIO driver

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  * Support GPIO driver for BlueField-3 SoCs.

  [Fix]

  * Support GPIO driver for BlueField-3 SoCs.
  * Allows user to alter GPIO value when direction is set to output
  * Support configuring GPIOs as interrupts for dependent drivers such as 
pwr-mlxbf and mlxbf-gige

  [Test Case]

  * At the moment, this driver can only be tested internally on palladium and 
via the ARM simulator.
  * This driver only loaded on BF3 platforms so has no impact on older 
platforms such as BF2 and BF1.

  [Regression Potential]

  * Code will need to be tested once real HW is ready (bringup)

  [Other]
  * This driver is in the process of being upstreamed. This code is likely to 
change depending on feedback we receive from maintainers. But the upstreaming 
process is long and we need to have this code to be available before 
BlueField-3 bringup.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1994897/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1991112] Re: mlxbf_gige: compute MDIO period based on i1clk

2023-02-17 Thread Meriton Tuli
** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1991112

Title:
  mlxbf_gige: compute MDIO period based on i1clk

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  The following upstream patch should be cherry picked to jammy kernel:

  3a1a274e933f mlxbf_gige: compute MDIO period based on i1clk

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1991112/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1991113] Re: "source" PKA driver Kconfig in mellanox/Kconfig

2023-02-17 Thread Meriton Tuli
# grep MLXBF_PKA  /boot/config-5.15*-bluefield
CONFIG_MLXBF_PKA=m

** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1991113

Title:
  "source" PKA driver Kconfig in mellanox/Kconfig

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  PKA driver Kconfig needs to be "sourced" in mellanox/Kconfig. This
  makes MLXBF_PKA config option visible by the kernel configuration
  system and is needed to actually build PKA driver.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1991113/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1999309] Re: mmc: sdhci-of-dwcmshc: Enable host V4 support for BlueField-3 SoC

2023-02-17 Thread Meriton Tuli
** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1999309

Title:
  mmc: sdhci-of-dwcmshc: Enable host V4 support for BlueField-3 SoC

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Jammy:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]
  This change is needed to for eMMC host setting on BlueField-3 SoC to be 
consistent with UEFI setting and also for stability reason.

  [Fix]
  The fix calls sdhci_enable_v4_mode() for BlueField-3 SoC.

  [Test Case]
  Same functionality as on BlueField-1/2.

  [Regression Potential]
  Can be considered minimum since similar functionality was already included in 
the focal branch for BlueField-1/2. The driver is different, but functionality 
and eMMC device files will be the same.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1999309/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1942932] Re: oob_net0 up but stops processing Rx packets

2021-10-15 Thread Meriton Tuli
Using 5.4.0-1020-bluefield, this Issue as been fixed:

# ifconfig oob_net0
oob_net0: flags=4163 mtu 1500
inet xxx.xxx.xxx.xxx netmask 255.255.255.0 broadcast 192.168.200.255
inet6  prefixlen 64 scopeid 0x20
ether XX:XX:XX:XX:XX:XX txqueuelen 1000 (Ethernet)
RX packets 136 bytes 11177 (11.1 KB)
RX errors 0 dropped 3 overruns 0 frame 0
TX packets 64 bytes 6526 (6.5 KB)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0


root@localhost:~# ifconfig oob_net0 down
root@localhost:~# ifconfig oob_net0 up

# ifconfig oob_net0
oob_net0: flags=4163 mtu 1500
inet xxx.xxx.xxx.xxx netmask 255.255.255.0 broadcast 192.168.200.255
inet6  prefixlen 64 scopeid 0x20
ether XX:XX:XX:XX:XX:XX txqueuelen 1000 (Ethernet)
RX packets 145 bytes 12281 (12.2 KB)
RX errors 0 dropped 3 overruns 0 frame 0
TX packets 75 bytes 8438 (8.4 KB)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0

** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1942932

Title:
  oob_net0 up but stops processing Rx packets

Status in linux-bluefield package in Ubuntu:
  New
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]
  * The oob_net0 interface, managed by the mlxbf_gige driver, will be
up and enabled but can stop processing received packets if three
specific conditions occur:
1) driver has received more than (N * RxRingSize) packets but less
   than (N+1 * RxRingSize) packets where N is an odd number.
   Note: the command "ethtool -g oob_net0" will display the current
   receive ring size, which currently defaults to 128.
2) the driver's interface was disabled via "ifconfig oob_net0 down"
   during the window described in #1.
3) the driver's interface is re-enabled via "ifconfig oob_net0 up"

Without this fix, the driver needs to be unloaded and re-loaded
to correct this condition.

  [Fix]
  * The fix is to ensure that the driver's "valid_polarity" field
is cleared during the open() method so that it always matches
the receive polarity used by hardware.

  [Test Case]
  * To test this fix, need to send in a specific number of packets to
the "oob_net0" interface, then issue "ifconfig oob_net0 down" to
disable the interface.  A subsequent "ifconfig oob_net0 up" command
will succesfully bring up the "oob_net0" interface and start the
processing of received packets.

  [Regression Potential]
  * There is low risk of this fix causing any problems.

  [Other]
  * The mlxbf_gige driver will display v1.25 in modinfo after these changes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1942932/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1942931] Re: "ethtool -S oob_net0" does not report interrupt counts

2021-10-15 Thread Meriton Tuli
Using 5.4.0-1020-bluefield, this Issue has been fixed:
# ethtool -S oob_net0
NIC statistics:
 hw_access_errors: 0
 tx_invalid_checksums: 0
 tx_small_frames: 3
 tx_index_errors: 0
 sw_config_errors: 0
 sw_access_errors: 0
 rx_truncate_errors: 0
 rx_mac_errors: 0
 rx_din_dropped_pkts: 0
 tx_fifo_full: 0
 rx_filter_passed_pkts: 729
 rx_filter_discard_pkts: 13
 mac_intr_count: 3
 rx_intr_count: 725
 llu_plu_intr_count: 0

** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1942931

Title:
  "ethtool -S oob_net0" does not report interrupt counts

Status in linux-bluefield package in Ubuntu:
  New
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]
  * The command "ethtool -S oob_net0" displays a set of statistics
related to mlxbf_gige driver.  This set of statistics does not
include the driver's interrupt counts.

  [Fix]
  * The fix is to extend the statistics list supported by "ethtool -S"
so that it includes MAC, receive packet, and LLU/PLU interrupt counts.

  [Test Case]
  * The command "ethtool -S oob_net0" should be executed before and 
after this fix to verify that three new fields are displayed:
  mac_intr_count
  rx_intr_count
  llu_plu_intr_count

  [Regression Potential]
  * There is low risk of this fix causing any problems.

  [Other]
  * n/a

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1942931/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1943065] Re: mlxbf_gige: update driver version to 1.25

2021-10-15 Thread Meriton Tuli
Using 5.4.0-1020-bluefield, this Issue has been fixed:
# modinfo mlxbf_gige
filename:   
/lib/modules/5.4.0-1020-bluefield/kernel/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige.ko
version:1.25 

** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1943065

Title:
  mlxbf_gige: update driver version to 1.25

Status in linux-bluefield package in Ubuntu:
  New
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]
  * The mlxbf_gige driver needs a version increase to identify
a driver containing recent important bug fixes.

  [Fix]
  * The driver version implemented by the DRV_VERSION define and
MODULE_VERSION macro will be incremented from 1.24 to 1.25

  [Test Case]
  * To test this fix, need to check the driver version shown in
the output of "modinfo mlxbf_gige" command.

  [Regression Potential]
  * There is low risk of this fix causing any problems.

  [Other]
  * The mlxbf_gige driver will display v1.25 in modinfo after these changes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1943065/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1943065] Re: mlxbf_gige: update driver version to 1.25

2021-10-05 Thread Meriton Tuli
Hello Luke,

Do you know when this Issue will be merged?

Thank you,
Meriton

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1943065

Title:
  mlxbf_gige: update driver version to 1.25

Status in linux-bluefield package in Ubuntu:
  New
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]
  * The mlxbf_gige driver needs a version increase to identify
a driver containing recent important bug fixes.

  [Fix]
  * The driver version implemented by the DRV_VERSION define and
MODULE_VERSION macro will be incremented from 1.24 to 1.25

  [Test Case]
  * To test this fix, need to check the driver version shown in
the output of "modinfo mlxbf_gige" command.

  [Regression Potential]
  * There is low risk of this fix causing any problems.

  [Other]
  * The mlxbf_gige driver will display v1.25 in modinfo after these changes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1943065/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1934923] Re: Sync up mlxbf-gige driver with upstreamed version

2021-10-05 Thread Meriton Tuli
Using Kernel 5.4.0-1019-bluefield, BlueField ATF version:
v2.2(release):3.7.1-5-gac4b614, and BlueField UEFI version:
3.7.1-13-g743f036 this Issue has been fixed!

** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1934923

Title:
  Sync up mlxbf-gige driver with upstreamed version

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  The mlxbf-gige driver has just been upstreamed so linux-bluefield needs to be 
synced up with what we have upstreamed.
  IMPORTANT: during testing, make sure the latest UEFI (bootloader) is loaded 
on top of these changes, otherwise both the gpio driver and mlxbf-gige driver 
will fail to load.

  [Fix]

  * reverted 20 commits related to the mlxbf-gige driver and 1 commit related 
to gpio-mlxbf2 driver since there are dependencies between them.
  * Cherry-picked f92e1869d74e1acc6551256eb084a1c14a054e19 from net-next 
branch. The upstreamed version of the GPIO driver removed the dependency 
between the mlxbf-gige driver and gpio-mlxbf2 driver.
  * added code that was left out of the upstreamed version. and added code that 
got reverted in gpio-mlxbf2.c
  * updated the UEFI ACPI table to reflect the above changes (so the bootloader 
and the linux drivers need to be in sync)

  [Test Case]

  * oob_net0 coming up after several SW_RESET or reboot
  * oob_net0 coming up after several powercycles
  * oob_net0 coming up after pushing a new Ubuntu/CentOS/Yocto
  * rmmod/modprove mlxbf_gige several times
  * OOB PXE boot multiple times from UEFI menu
  * automate OOB PXE boot and do reboot
  * automate OOB PXE boot and do powercycle
  * Test that GPIO7 reset still works on BlueSphere like boards

  [Regression Potential]

  Any of the test cases above could be impacted due to these changes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1934923/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1934923] Re: Sync up mlxbf-gige driver with upstreamed version

2021-09-22 Thread Meriton Tuli
Hello Kelsey,

Using 5.4.0-1018-bluefield these changes were not pushed yet. We'll wait
for 5.4.0-1019 and let you know whether we're able to Verify these
Changes.

Thank you,
Meriton

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1934923

Title:
  Sync up mlxbf-gige driver with upstreamed version

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  The mlxbf-gige driver has just been upstreamed so linux-bluefield needs to be 
synced up with what we have upstreamed.
  IMPORTANT: during testing, make sure the latest UEFI (bootloader) is loaded 
on top of these changes, otherwise both the gpio driver and mlxbf-gige driver 
will fail to load.

  [Fix]

  * reverted 20 commits related to the mlxbf-gige driver and 1 commit related 
to gpio-mlxbf2 driver since there are dependencies between them.
  * Cherry-picked f92e1869d74e1acc6551256eb084a1c14a054e19 from net-next 
branch. The upstreamed version of the GPIO driver removed the dependency 
between the mlxbf-gige driver and gpio-mlxbf2 driver.
  * added code that was left out of the upstreamed version. and added code that 
got reverted in gpio-mlxbf2.c
  * updated the UEFI ACPI table to reflect the above changes (so the bootloader 
and the linux drivers need to be in sync)

  [Test Case]

  * oob_net0 coming up after several SW_RESET or reboot
  * oob_net0 coming up after several powercycles
  * oob_net0 coming up after pushing a new Ubuntu/CentOS/Yocto
  * rmmod/modprove mlxbf_gige several times
  * OOB PXE boot multiple times from UEFI menu
  * automate OOB PXE boot and do reboot
  * automate OOB PXE boot and do powercycle
  * Test that GPIO7 reset still works on BlueSphere like boards

  [Regression Potential]

  Any of the test cases above could be impacted due to these changes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1934923/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1934304] Re: i2c-mlxbf.c: prevent stack overflow in mlxbf_i2c_smbus_start_transaction

2021-07-30 Thread Meriton Tuli
** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1934304

Title:
  i2c-mlxbf.c: prevent stack overflow in
  mlxbf_i2c_smbus_start_transaction

Status in linux-bluefield package in Ubuntu:
  Invalid
Status in linux-bluefield source package in Focal:
  Fix Committed

Bug description:
  SRU Justification:

  [Impact]

  There could be stack overflow in mlxbf_i2c_smbus_start_transaction().
  memcpy() is called in a loop while 'operation->length' upper bound is not
  checked and 'data_idx' also increments.

  More details:
  The operation length is verified by the caller functions so it cannot exceed 
I2C_SMBUS_BLOCK_MAX bytes (32 bytes) for each operation that is a part of the 
write. Data_desc array is 128 bytes in size. So potentially a request which 
consists of 4 writes, 32 bytes each can trigger an off-by-one or off-by-two 
overflow, because the first byte of data_desc is used by addr, effectively 
decreasing the available data_desc buffer size by one. Functions like 
mlx_smbus_i2c_block_func() that prepare the request also set the length of the 
first write operation to one and store the command id there, so the target 
buffer size again decreases data_desc by one, making it two bytes less than 
expected.

  [Fix]

  * Add a check for "operation->length" and data_idx and return error if
  reached upper bound.

  [Test Case]

  * Test the i2c-mlxbf.c driver using IPMB functionality.

  [Regression Potential]

  This fix returns a negative value to indicate that a transaction has
  failed. So it will catch more transactions failures.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1934304/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp