[Kernel-packages] [Bug 1788222] Re: Bugfix for handling of shadow doorbell buffer

2018-10-11 Thread Michal Wnukowski
I was able to verify that the fix in Xenial 4.4.0-138.164 works. The
procedure was the same as in comment #4 [1], but with less run time.

[1] https://bugs.launchpad.net/ubuntu/+source/linux-
gcp/+bug/1788222/comments/4

** Tags removed: verification-needed-xenial
** Tags added: verification-done-xenial

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-gcp in Ubuntu.
https://bugs.launchpad.net/bugs/1788222

Title:
  Bugfix for handling of shadow doorbell buffer

Status in linux package in Ubuntu:
  Fix Committed
Status in linux-gcp package in Ubuntu:
  Fix Released
Status in linux source package in Xenial:
  Fix Committed
Status in linux source package in Bionic:
  Fix Released
Status in linux source package in Cosmic:
  Fix Committed

Bug description:
  This request is to pull in the following patch for NVMe bug from
  https://lore.kernel.org/patchwork/patch/974880/ in the linux-gcp
  kernel:

  ===
  This patch adds full memory barrier into nvme_dbbuf_update_and_check_event
  function to ensure that the shadow doorbell is written before reading
  EventIdx from memory. This is a critical bugfix for initial patch that
  added support for shadow doorbell into NVMe driver[...].

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1788222/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 1788222] Re: Bugfix for handling of shadow doorbell buffer

2018-08-30 Thread Michal Wnukowski
Applied the patch from -proposed:
root@Ubuntu1804:~# echo "deb http://archive.ubuntu.com/ubuntu/ bionic-proposed 
restricted main multiverse universe" | tee -a /etc/apt/sources.list
root@Ubuntu1804:~# apt-get update
root@Ubuntu1804:~# apt-get dist-upgrade
root@Ubuntu1804:~# shutdown -r 0

Verified that the -proposed contains fix:
root@Ubuntu1804:~# objdump -d /lib/modules/$(uname 
-r)/kernel/drivers/nvme/host/nvme.ko | grep -A 50 __nvme_submit_cmd\>: | grep 
fence
adf:0f ae f8sfence 
ae6:0f ae f0mfence

(second mfence is the one added by patch)

Verified that the patch solves the issue:

./orion -run advanced -num_large 0 -size_small 8 -type rand -simulate
concat -write 40 -duration 120 -matrix row -testname gcp_test

(no hang after 36 hours)

I assume that the same patch will be added to Xenial and Cosmic.

** Tags removed: verification-needed-bionic
** Tags added: verification-done-bionic

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1788222

Title:
  Bugfix for handling of shadow doorbell buffer

Status in linux package in Ubuntu:
  In Progress
Status in linux-gcp package in Ubuntu:
  New
Status in linux source package in Xenial:
  In Progress
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Cosmic:
  In Progress

Bug description:
  This request is to pull in the following patch for NVMe bug from
  https://lore.kernel.org/patchwork/patch/974880/ in the linux-gcp
  kernel:

  ===
  This patch adds full memory barrier into nvme_dbbuf_update_and_check_event
  function to ensure that the shadow doorbell is written before reading
  EventIdx from memory. This is a critical bugfix for initial patch that
  added support for shadow doorbell into NVMe driver[...].

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1788222/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp