[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2024-01-29 Thread Launchpad Bug Tracker
This bug was fixed in the package zfs-linux - 2.2.0-0ubuntu1~23.10.1

---
zfs-linux (2.2.0-0ubuntu1~23.10.1) mantic; urgency=medium

  * d/p/u/zed-fix-typo-ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT.patch:
fix typo in configuration option in zed.rc (LP: #2046082)

 -- Mauricio Faria de Oliveira   Sat, 09 Dec 2023
16:10:21 -0300

** Changed in: zfs-linux (Ubuntu Mantic)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Fix Released
Status in zfs-linux source package in Mantic:
  Fix Released
Status in zfs-linux source package in Noble:
  Fix Released

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2024-01-26 Thread Dimitri John Ledkov
removing block, as that condition no longer applied due to reject.

** Tags removed: block-proposed-mantic

** Tags added: verification-done

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Fix Released
Status in zfs-linux source package in Mantic:
  Fix Committed
Status in zfs-linux source package in Noble:
  Fix Released

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2024-01-08 Thread Mauricio Faria de Oliveira
Verification done for mantic-proposed.
All matches of the string are correct.

$ lxc launch ubuntu:mantic mantic-zed
$ lxc shell mantic-zed

# add-apt-repository -y -p proposed
# apt install -t mantic-proposed -y zfs-zed

# dpkg -s zfs-zed | grep Version:
Version: 2.2.0-0ubuntu1~23.10.1

# grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
#ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

# dpkg -L zfs-zed | xargs grep ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT 
2>/dev/null | sort
/etc/zfs/zed.d/zed.rc:#ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1
/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:#   2: 
ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT disabled
/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:# 
ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT is set in zed.rc, and the disk gets
/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:if [ 
"${ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT}" != "1" ] ; then

# dpkg -L zfs-zed | xargs grep ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT 
2>/dev/null | sort
#

** Tags added: verification-done-mantic

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Fix Released
Status in zfs-linux source package in Mantic:
  Fix Committed
Status in zfs-linux source package in Noble:
  Fix Released

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2024-01-05 Thread Steve Langasek
Normally, changing a conffile in an SRU is iffy because this may result
in conffile prompts for the user on upgrade, and will cause unattended-
upgrades to hold the package back.

In this case we're fixing a regression in a conffile that was introduced
already in -updates.  So, ok.

** Changed in: zfs-linux (Ubuntu Mantic)
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Fix Released
Status in zfs-linux source package in Mantic:
  Fix Committed
Status in zfs-linux source package in Noble:
  Fix Released

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2023-12-13 Thread Mauricio Faria de Oliveira
I will stage this to mantic with an upload + block-proposed-mantic tag.

The mantic unapproved queue already has zfs-linux 2.2.2-0ubuntu1~23.10,
but it seems it is not going to be accepted per bug 2044657 comment 46.

If that bug gets cherry-pick fixes as requested, that should be simple
to combine with the staged upload. Or if the full upstream backport to
2.2.2 (from 2.2.0) is accepted there, I am happy to re-upload with it.

Attaching the debdiff for reference.

** Patch added: "lp2046082_zfs-linux_mantic_2.2.0.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+attachment/5728907/+files/lp2046082_zfs-linux_mantic_2.2.0.debdiff

** Tags added: block-proposed-mantic

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Fix Released
Status in zfs-linux source package in Mantic:
  Confirmed
Status in zfs-linux source package in Noble:
  Fix Released

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2023-12-13 Thread Mauricio Faria de Oliveira
Testing for Mantic:

mantic-updates:

$ rmadison -a source zfs-linux -s mantic-updates
 zfs-linux | 2.2.0-0ubuntu1~23.10 | mantic-updates | source

$ dpkg -s zfs-zed | grep Version:
Version: 2.2.0-0ubuntu1~23.10

$ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
#ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

$ dpkg -L zfs-zed | xargs grep ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT 
2>/dev/null | sort
/etc/zfs/zed.d/zed.rc:#ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1
/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:#   2: 
ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT disabled
/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:# 
ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT is set in zed.rc, and the disk gets
/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:if [ 
"${ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT}" != "1" ] ; then

test package:

$ dpkg-deb -x zfs-zed_2.2.0-0ubuntu1~23.10.1_amd64.deb deb

$ grep ZED_POWER_OFF_ENCLO deb/etc/zfs/zed.d/zed.rc
#ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

- wrong name (no matches anymore):

$ find deb | xargs grep ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT 
2>/dev/null
$

- right name (all matches fixed):

$ find deb | xargs grep ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT 
2>/dev/null | sort
deb/etc/zfs/zed.d/zed.rc:#ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1
deb/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:#   2: 
ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT disabled
deb/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:# 
ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT is set in zed.rc, and the disk gets
deb/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:if [ 
"${ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT}" != "1" ] ; then

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Fix Released
Status in zfs-linux source package in Mantic:
  Confirmed
Status in zfs-linux source package in Noble:
  Fix Released

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2023-12-13 Thread Launchpad Bug Tracker
This bug was fixed in the package zfs-linux - 2.2.2-0ubuntu2

---
zfs-linux (2.2.2-0ubuntu2) noble; urgency=medium

  * d/p/u/zed-fix-typo-ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT.patch:
fix typo in configuration option in zed.rc (LP: #2046082)

 -- Mauricio Faria de Oliveira   Sat, 09 Dec 2023
16:10:21 -0300

** Changed in: zfs-linux (Ubuntu Noble)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Fix Released
Status in zfs-linux source package in Mantic:
  Confirmed
Status in zfs-linux source package in Noble:
  Fix Released

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2023-12-13 Thread Sebastien Bacher
Thanks Mauricio, I've uploaded your change to noble now

** Changed in: zfs-linux (Ubuntu Noble)
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Fix Committed
Status in zfs-linux source package in Mantic:
  Confirmed
Status in zfs-linux source package in Noble:
  Fix Committed

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2023-12-10 Thread Mauricio Faria de Oliveira
noble:

$ dpkg -s zfs-zed | grep Version:
Version: 2.2.2-0ubuntu1

$ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
#ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

test package:

$ dpkg-deb -x zfs-zed_2.2.2-0ubuntu2_amd64.deb deb

$ grep ZED_POWER_OFF_ENCLO deb/etc/zfs/zed.d/zed.rc
#ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1


** Patch added: "lp2046082_zfs-linux_noble.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+attachment/5728045/+files/lp2046082_zfs-linux_noble.debdiff

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Confirmed
Status in zfs-linux source package in Mantic:
  Confirmed
Status in zfs-linux source package in Noble:
  Confirmed

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2023-12-10 Thread Mauricio Faria de Oliveira
Subscribing ~ubuntu-sponsors for review/sponsoring to Noble.
(I can handle the upload to mantic later.)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Confirmed
Status in zfs-linux source package in Mantic:
  Confirmed
Status in zfs-linux source package in Noble:
  Confirmed

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp


[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2023-12-10 Thread Mauricio Faria de Oliveira
Ubuntu:

$ rmadison -a source zfs-linux
...
 zfs-linux | 0.8.3-1ubuntu12| focal   | source
 zfs-linux | 0.8.3-1ubuntu12.16 | focal-security  | source
 zfs-linux | 0.8.3-1ubuntu12.16 | focal-updates   | source
 zfs-linux | 2.1.2-1ubuntu3 | jammy   | source
 zfs-linux | 2.1.5-1ubuntu6~22.04.2 | jammy-security  | source
 zfs-linux | 2.1.5-1ubuntu6~22.04.2 | jammy-updates   | source
 zfs-linux | 2.1.9-2ubuntu1 | lunar   | source
 zfs-linux | 2.1.9-2ubuntu1.2   | lunar-security  | source
 zfs-linux | 2.1.9-2ubuntu1.2   | lunar-updates   | source
 zfs-linux | 2.2.0~rc3-0ubuntu4 | mantic  | source
 zfs-linux | 2.2.0-0ubuntu1~23.10   | mantic-proposed | source
 zfs-linux | 2.2.0-0ubuntu1~23.10   | mantic-updates  | source
 zfs-linux | 2.2.2-0ubuntu1 | noble   | source

$ git show pkg/ubuntu/focal-devel:./cmd/zed/zed.d/zed.rc | grep 
ZED_POWER_OFF_ENCLO
$ git show pkg/ubuntu/jammy-devel:./cmd/zed/zed.d/zed.rc | grep 
ZED_POWER_OFF_ENCLO
$ git show pkg/ubuntu/lunar-devel:./cmd/zed/zed.d/zed.rc | grep 
ZED_POWER_OFF_ENCLO

$ git show pkg/ubuntu/mantic-devel:./cmd/zed/zed.d/zed.rc | grep 
ZED_POWER_OFF_ENCLO
#ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

$ git show pkg/ubuntu/noble-devel:./cmd/zed/zed.d/zed.rc | grep 
ZED_POWER_OFF_ENCLO
#ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1


** Description changed:

  [Impact]
  
-  * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
-ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
-in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.
+  * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
+    ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
+    in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.
  
-  * This could be fixed in Ubuntu before users start adopting it.
+  * This could be fixed in Ubuntu before users start adopting it.
  
  [Test Plan]
  
-  * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.
+  * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.
  
-  * Actual:
-$ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
-#ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1
+  * Actual:
+    $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
+    #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1
  
-  * Expected:
-$ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
-#ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1
+  * Expected:
+    $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
+    #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1
  
  [Regression Potential]
  
-  * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
-(published to mantic-updates on 2023-12-08) _and_ enabled the
-option (with typo) would have such functionality disabled.
+  * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
+    (published to mantic-updates on 2023-12-08) _and_ enabled the
+    option (with typo) would have such functionality disabled.
  
  [Other Info]
  
-  * This option (with typo) was introduced in commit d19304ffeec5
-("zed: Add zedlet to power off slot when drive is faulted"),
-and is present in:
-- ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
-- ZFS 2.1: zfs-2.1.13
+  * This option (with typo) was introduced in commit d19304ffeec5
+    ("zed: Add zedlet to power off slot when drive is faulted"),
+    and is present in:
+    - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
+    - ZFS 2.1: zfs-2.1.13
  
-  * It affects Ubuntu Noble and Mantic, but not Lunar or older.
+  * It affects Ubuntu Noble and Mantic, but not Lunar or older.
+ 
+  * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
+variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Confirmed
Status in zfs-linux source package in Mantic:
  Confirmed
Status in zfs-linux source package in Noble:
  Confirmed

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * 

[Kernel-packages] [Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

2023-12-10 Thread Mauricio Faria de Oliveira
Upstream:

$ git log --oneline origin/zfs-2.2-release -- cmd/zed/zed.d/zed.rc | grep 'zed: 
Add zedlet to power off slot when drive is faulted'
d19304ffeec5 zed: Add zedlet to power off slot when drive is faulted
$ git describe --contains d19304ffeec5
zfs-2.2.0-rc4~14

$ git log --oneline origin/zfs-2.1-release -- cmd/zed/zed.d/zed.rc | grep 'zed: 
Add zedlet to power off slot when drive is faulted'
a4f82db53d6d zed: Add zedlet to power off slot when drive is faulted
$ git describe --contains a4f82db53d6d
zfs-2.1.13~6

$ git log --oneline origin/zfs-2.0-release -- cmd/zed/zed.d/zed.rc | grep 'zed: 
Add zedlet to power off slot when drive is faulted'
$

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Confirmed
Status in zfs-linux source package in Mantic:
  Confirmed
Status in zfs-linux source package in Noble:
  Confirmed

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
 variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp