Re: [PATCH v2] docs: Fix typo in comment
On Mon, Jul 25, 2022 at 06:52:15AM -0700, Joe Perches wrote:
> On Fri, 2022-07-22 at 07:45 +0800, Baoquan He wrote:
> > On 07/21/22 at 11:40am, Randy Dunlap wrote:
> > > On 7/21/22 11:36, Jonathan Corbet wrote:
> > > > "Slark Xiao" writes:
> > > > > May I know the maintainer of one subsystem could merge the changes
> > > > > contains lots of subsystem? I also know this could be filtered by
> > > > > grep and sed command, but that patch would have dozens of maintainers
> > > > > and reviewers.
> > > >
> > > > Certainly I don't think I can merge a patch touching 166 files across
> > > > the tree. This will need to be broken down by subsystem, and you may
> > > > well find that there are some maintainers who don't want to deal with
> > > > this type of minor fix.
> > >
> > > We have also seen cases where "the the" should be replaced by "then the"
> > > or some other pair of words, so some of these changes could fall into
> > > that category.
> >
> > It's possible. I searched in Documentation and went through each place,
> > seems no typo of "then the". Below patch should clean up all the 'the the'
> > typo under Documentation.
> []
> > The fix is done with below command:
> > sed -i "s/the the /the /g" `git grep -l "the the " Documentation`
>
> This command misses entries at EOL:
>
> Documentation/trace/histogram.rst: Here's an example where we use a compound
> key composed of the the
>
> Perhaps a better conversion would be 's/\bthe the\b/the/g'
It would be good to check for instances that cross newlines as well;
i.e. "the" at the end of a line followed by "the" at the start of the
next line. However, this would require some thought to properly account
for comment blocks ("*") and other similar prefixes that should be
ignored.
William Breathitt Gray
signature.asc
Description: PGP signature
___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH v2] docs: Fix typo in comment
On 07/21/22 at 09:56am, Slark Xiao wrote: > Fix typo in the comment When searching the typo 'the the' in kernel, I found it exists in so many places. We can sweep them away at one time, lest patches posted to fix them again and again. >From 8185cce9e9afac63b760280aca12c0fca0e6f9fe Mon Sep 17 00:00:00 2001 From: Baoquan He Date: Thu, 21 Jul 2022 23:16:42 +0800 Subject: [PATCH] Fix all occurences of the 'the the' typo Content-type: text/plain The fix is done with below command. sed -i "s/the the /the /g" `git grep -l "the the "` Signed-off-by: Baoquan He --- Documentation/ABI/stable/sysfs-module | 2 +- Documentation/ABI/testing/sysfs-class-rtrs-client | 2 +- Documentation/ABI/testing/sysfs-class-rtrs-server | 2 +- .../ABI/testing/sysfs-devices-platform-ACPI-TAD| 2 +- Documentation/ABI/testing/sysfs-devices-power | 2 +- Documentation/admin-guide/kdump/vmcoreinfo.rst | 2 +- Documentation/bpf/map_cgroup_storage.rst | 4 ++-- Documentation/core-api/cpu_hotplug.rst | 2 +- .../devicetree/bindings/arm/msm/qcom,saw2.txt | 2 +- .../devicetree/bindings/clock/ti/davinci/pll.txt | 2 +- Documentation/devicetree/bindings/fpga/fpga-region.txt | 2 +- Documentation/devicetree/bindings/gpio/gpio-pisosr.txt | 2 +- Documentation/devicetree/bindings/net/qcom-emac.txt| 2 +- .../phy/amlogic,meson-axg-mipi-pcie-analog.yaml| 2 +- .../bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +- .../bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +- .../bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +- .../bindings/power/amlogic,meson-ee-pwrc.yaml | 2 +- Documentation/devicetree/bindings/powerpc/fsl/cpus.txt | 2 +- .../devicetree/bindings/powerpc/opal/power-mgt.txt | 2 +- .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 2 +- .../devicetree/bindings/sound/tlv320adcx140.yaml | 4 ++-- .../bindings/thermal/brcm,avs-ro-thermal.yaml | 2 +- .../bindings/thermal/nvidia,tegra124-soctherm.txt | 2 +- .../devicetree/bindings/thermal/rcar-thermal.yaml | 2 +- Documentation/driver-api/isa.rst | 2 +- Documentation/filesystems/caching/backend-api.rst | 2 +- Documentation/locking/seqlock.rst | 2 +- Documentation/sphinx/cdomain.py| 2 +- arch/arm/Kconfig | 4 ++-- arch/arm/include/asm/unwind.h | 2 +- arch/arm/mach-pxa/hx4700-pcmcia.c | 2 +- arch/arm64/crypto/aes-neon.S | 2 +- arch/m68k/coldfire/intc-2.c| 2 +- arch/microblaze/kernel/entry.S | 2 +- arch/mips/alchemy/devboards/pm.c | 2 +- arch/s390/kernel/perf_cpum_sf.c| 2 +- arch/s390/kernel/sthyi.c | 2 +- arch/sparc/kernel/pci.c| 2 +- drivers/char/apm-emulation.c | 2 +- drivers/crypto/nx/nx-common-powernv.c | 2 +- drivers/crypto/ux500/hash/hash_core.c | 2 +- drivers/dma/mediatek/mtk-hsdma.c | 2 +- drivers/extcon/extcon.c| 2 +- drivers/firmware/qcom_scm.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drivers/gpu/drm/amd/include/atombios.h | 4 ++-- drivers/gpu/drm/display/drm_dp_helper.c| 4 ++-- drivers/gpu/drm/drm_ioctl.c| 2 +- drivers/gpu/drm/drm_panel_orientation_quirks.c | 2 +- drivers/gpu/drm/drm_prime.c| 2 +- drivers/gpu/drm/i915/i915_irq.c| 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c | 2 +- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 8 drivers/gpu/drm/pl111/pl111_display.c | 2 +- drivers/gpu/drm/vc4/vc4_regs.h | 2 +- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 2 +- drivers/iio/magnetometer/hmc5843_core.c| 2 +- drivers/infiniband/core/roce_gid_mgmt.c| 2 +- drivers/infiniband/hw/qib/qib.h| 2 +- drivers/infiniband/ulp/ipoib/ipoib_ib.c| 2 +- drivers/input/mouse/gpio_mouse.c | 2 +- drivers/isdn/hardware/mISDN/hfcsusb.c | 2 +- drivers/mailbox/Kconfig| 2 +- drivers/md/dm-raid.c | 2 +- drivers/media/dvb-frontends/tda1002x.h | 2 +- drivers/media/dvb-frontends/tda10048.c | 2 +- drivers/media/i2c/mt9v111.c| 2
Re: [PATCH v2] docs: Fix typo in comment
On 07/26/22 at 09:04am, Slark Xiao wrote: > At 2022-07-25 21:32:04, "Baoquan He" wrote: > >On 07/25/22 at 11:55am, David Howells wrote: > >> Baoquan He wrote: > >> > >> > sed -i "s/the the /the /g" `git grep -l "the the "` > >> > >> You might want to clarify the first "the" with a preceding boundary marker. > >> There are some English words ending in "the" that can be used as verbs, > >> though > >> I'm not sure you'd find any of them here - clothe for example. > > > >Right. I plan to split this big one into patches corresponding to > >different component as Jonathan suggested, and will consider how to mark > >the first 'the' as you suggested, and wrap Slark's pathces which > >includes typo fix of "then the". > > > >Thanks > >Baoquan > > Actually I have committed all changes which were listed in your previous list. > I committed it one by one and checked if any other typo is included. > If possible, you can try other double typo issue like "and and " or "or or" > or something else. That's good, I take leave this week to be babysitter, please go ahead to handle all of them you found out. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re:Re: [PATCH v2] docs: Fix typo in comment
At 2022-07-25 21:32:04, "Baoquan He" wrote: >On 07/25/22 at 11:55am, David Howells wrote: >> Baoquan He wrote: >> >> > sed -i "s/the the /the /g" `git grep -l "the the "` >> >> You might want to clarify the first "the" with a preceding boundary marker. >> There are some English words ending in "the" that can be used as verbs, >> though >> I'm not sure you'd find any of them here - clothe for example. > >Right. I plan to split this big one into patches corresponding to >different component as Jonathan suggested, and will consider how to mark >the first 'the' as you suggested, and wrap Slark's pathces which >includes typo fix of "then the". > >Thanks >Baoquan Actually I have committed all changes which were listed in your previous list. I committed it one by one and checked if any other typo is included. If possible, you can try other double typo issue like "and and " or "or or" or something else. Thanks ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH v2] docs: Fix typo in comment
On Mon, 2022-07-25 at 09:57 -0400, William Breathitt Gray wrote:
> On Mon, Jul 25, 2022 at 06:52:15AM -0700, Joe Perches wrote:
> > On Fri, 2022-07-22 at 07:45 +0800, Baoquan He wrote:
> > > The fix is done with below command:
> > > sed -i "s/the the /the /g" `git grep -l "the the " Documentation`
> >
> > This command misses entries at EOL:
> >
> > Documentation/trace/histogram.rst: Here's an example where we use a
> > compound key composed of the the
> >
> > Perhaps a better conversion would be 's/\bthe the\b/the/g'
>
> It would be good to check for instances that cross newlines as well;
> i.e. "the" at the end of a line followed by "the" at the start of the
> next line. However, this would require some thought to properly account
> for comment blocks ("*") and other similar prefixes that should be
> ignored.
checkpatch already attempts that duplicated word across a newline test.
___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH v2] docs: Fix typo in comment
On 7/25/22 06:57, William Breathitt Gray wrote:
> On Mon, Jul 25, 2022 at 06:52:15AM -0700, Joe Perches wrote:
>> On Fri, 2022-07-22 at 07:45 +0800, Baoquan He wrote:
>>> On 07/21/22 at 11:40am, Randy Dunlap wrote:
On 7/21/22 11:36, Jonathan Corbet wrote:
> "Slark Xiao" writes:
>> May I know the maintainer of one subsystem could merge the changes
>> contains lots of subsystem? I also know this could be filtered by
>> grep and sed command, but that patch would have dozens of maintainers
>> and reviewers.
>
> Certainly I don't think I can merge a patch touching 166 files across
> the tree. This will need to be broken down by subsystem, and you may
> well find that there are some maintainers who don't want to deal with
> this type of minor fix.
We have also seen cases where "the the" should be replaced by "then the"
or some other pair of words, so some of these changes could fall into
that category.
>>>
>>> It's possible. I searched in Documentation and went through each place,
>>> seems no typo of "then the". Below patch should clean up all the 'the the'
>>> typo under Documentation.
>> []
>>> The fix is done with below command:
>>> sed -i "s/the the /the /g" `git grep -l "the the " Documentation`
>>
>> This command misses entries at EOL:
>>
>> Documentation/trace/histogram.rst: Here's an example where we use a
>> compound key composed of the the
>>
>> Perhaps a better conversion would be 's/\bthe the\b/the/g'
>
> It would be good to check for instances that cross newlines as well;
> i.e. "the" at the end of a line followed by "the" at the start of the
> next line. However, this would require some thought to properly account
> for comment blocks ("*") and other similar prefixes that should be
> ignored.
Yeah, the script that I posted last year (?) does that, but it's noisy --
results need to be hand-checked.
It's not clear how people are finding these repeated words, other than
something like
$ grep "the the" *
--
~Randy
___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH v2] docs: Fix typo in comment
On Fri, 2022-07-22 at 07:45 +0800, Baoquan He wrote: > On 07/21/22 at 11:40am, Randy Dunlap wrote: > > On 7/21/22 11:36, Jonathan Corbet wrote: > > > "Slark Xiao" writes: > > > > May I know the maintainer of one subsystem could merge the changes > > > > contains lots of subsystem? I also know this could be filtered by > > > > grep and sed command, but that patch would have dozens of maintainers > > > > and reviewers. > > > > > > Certainly I don't think I can merge a patch touching 166 files across > > > the tree. This will need to be broken down by subsystem, and you may > > > well find that there are some maintainers who don't want to deal with > > > this type of minor fix. > > > > We have also seen cases where "the the" should be replaced by "then the" > > or some other pair of words, so some of these changes could fall into > > that category. > > It's possible. I searched in Documentation and went through each place, > seems no typo of "then the". Below patch should clean up all the 'the the' > typo under Documentation. [] > The fix is done with below command: > sed -i "s/the the /the /g" `git grep -l "the the " Documentation` This command misses entries at EOL: Documentation/trace/histogram.rst: Here's an example where we use a compound key composed of the the Perhaps a better conversion would be 's/\bthe the\b/the/g' ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH v2] docs: Fix typo in comment
On 07/25/22 at 11:55am, David Howells wrote: > Baoquan He wrote: > > > sed -i "s/the the /the /g" `git grep -l "the the "` > > You might want to clarify the first "the" with a preceding boundary marker. > There are some English words ending in "the" that can be used as verbs, though > I'm not sure you'd find any of them here - clothe for example. Right. I plan to split this big one into patches corresponding to different component as Jonathan suggested, and will consider how to mark the first 'the' as you suggested, and wrap Slark's pathces which includes typo fix of "then the". Thanks Baoquan ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH v2] docs: Fix typo in comment
Baoquan He wrote: > sed -i "s/the the /the /g" `git grep -l "the the "` You might want to clarify the first "the" with a preceding boundary marker. There are some English words ending in "the" that can be used as verbs, though I'm not sure you'd find any of them here - clothe for example. David ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH v2] docs: Fix typo in comment
On Thu, Jul 21, 2022 at 8:52 PM Randy Dunlap wrote:
> On 7/21/22 11:36, Jonathan Corbet wrote:
> > "Slark Xiao" writes:
> >
> >> May I know the maintainer of one subsystem could merge the changes
> >> contains lots of subsystem? I also know this could be filtered by
> >> grep and sed command, but that patch would have dozens of maintainers
> >> and reviewers.
> >
> > Certainly I don't think I can merge a patch touching 166 files across
> > the tree. This will need to be broken down by subsystem, and you may
> > well find that there are some maintainers who don't want to deal with
> > this type of minor fix.
>
> We have also seen cases where "the the" should be replaced by "then the"
> or some other pair of words, so some of these changes could fall into
> that category.
Yes we have:
--- a/arch/m68k/coldfire/intc-2.c
+++ b/arch/m68k/coldfire/intc-2.c
@@ -7,7 +7,7 @@
* family, the 5270, 5271, 5274, 5275, and the 528x family which
have two such
* controllers, and the 547x and 548x families which have only one of them.
*
- * The external 7 fixed interrupts are part the the Edge Port unit of these
+ * The external 7 fixed interrupts are part the Edge Port unit of these
* ColdFire parts. They can be configured as level or edge triggered.
*
* (C) Copyright 2009-2011, Greg Ungerer
And that's already been fixed
https://lore.kernel.org/lkml/6fe2468a-9664-30f7-7f17-9093289eb...@linux-m68k.org
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH v2] docs: Fix typo in comment
On 07/21/22 at 11:40am, Randy Dunlap wrote: > > > On 7/21/22 11:36, Jonathan Corbet wrote: > > "Slark Xiao" writes: > > > >> May I know the maintainer of one subsystem could merge the changes > >> contains lots of subsystem? I also know this could be filtered by > >> grep and sed command, but that patch would have dozens of maintainers > >> and reviewers. > > > > Certainly I don't think I can merge a patch touching 166 files across > > the tree. This will need to be broken down by subsystem, and you may > > well find that there are some maintainers who don't want to deal with > > this type of minor fix. > > We have also seen cases where "the the" should be replaced by "then the" > or some other pair of words, so some of these changes could fall into > that category. It's possible. I searched in Documentation and went through each place, seems no typo of "then the". Below patch should clean up all the 'the the' typo under Documentation. >From 60cacd213ab24981d16c292667283cf7e74f86b1 Mon Sep 17 00:00:00 2001 From: Baoquan He Date: Fri, 22 Jul 2022 07:26:48 +0800 Subject: [PATCH] Documentation: Fix all occurences of the 'the the' typo Content-type: text/plain The fix is done with below command: sed -i "s/the the /the /g" `git grep -l "the the " Documentation` Signed-off-by: Baoquan He --- Documentation/ABI/stable/sysfs-module | 2 +- Documentation/ABI/testing/sysfs-class-rtrs-client | 2 +- Documentation/ABI/testing/sysfs-class-rtrs-server | 2 +- Documentation/ABI/testing/sysfs-devices-platform-ACPI-TAD | 2 +- Documentation/ABI/testing/sysfs-devices-power | 2 +- Documentation/admin-guide/kdump/vmcoreinfo.rst| 2 +- Documentation/bpf/map_cgroup_storage.rst | 4 ++-- Documentation/core-api/cpu_hotplug.rst| 2 +- Documentation/devicetree/bindings/arm/msm/qcom,saw2.txt | 2 +- Documentation/devicetree/bindings/clock/ti/davinci/pll.txt| 2 +- Documentation/devicetree/bindings/fpga/fpga-region.txt| 2 +- Documentation/devicetree/bindings/gpio/gpio-pisosr.txt| 2 +- Documentation/devicetree/bindings/net/qcom-emac.txt | 2 +- .../bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml | 2 +- .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +- .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +- .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +- .../devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml | 2 +- Documentation/devicetree/bindings/powerpc/fsl/cpus.txt| 2 +- Documentation/devicetree/bindings/powerpc/opal/power-mgt.txt | 2 +- Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt| 2 +- Documentation/devicetree/bindings/sound/tlv320adcx140.yaml| 4 ++-- .../devicetree/bindings/thermal/brcm,avs-ro-thermal.yaml | 2 +- .../devicetree/bindings/thermal/nvidia,tegra124-soctherm.txt | 2 +- Documentation/devicetree/bindings/thermal/rcar-thermal.yaml | 2 +- Documentation/driver-api/isa.rst | 2 +- Documentation/filesystems/caching/backend-api.rst | 2 +- Documentation/locking/seqlock.rst | 2 +- Documentation/sphinx/cdomain.py | 2 +- 29 files changed, 31 insertions(+), 31 deletions(-) diff --git a/Documentation/ABI/stable/sysfs-module b/Documentation/ABI/stable/sysfs-module index 560b4a3278df..41b1f16e8795 100644 --- a/Documentation/ABI/stable/sysfs-module +++ b/Documentation/ABI/stable/sysfs-module @@ -38,7 +38,7 @@ What: /sys/module//srcversion Date: Jun 2005 Description: If the module source has MODULE_VERSION, this file will contain - the checksum of the the source code. + the checksum of the source code. What: /sys/module//version Date: Jun 2005 diff --git a/Documentation/ABI/testing/sysfs-class-rtrs-client b/Documentation/ABI/testing/sysfs-class-rtrs-client index 49a4157c7bf1..fecc59d1b96f 100644 --- a/Documentation/ABI/testing/sysfs-class-rtrs-client +++ b/Documentation/ABI/testing/sysfs-class-rtrs-client @@ -78,7 +78,7 @@ What: /sys/class/rtrs-client//paths//hca_name Date: Feb 2020 KernelVersion: 5.7 Contact: Jack Wang Danil Kipnis -Description: RO, Contains the the name of HCA the connection established on. +Description: RO, Contains the name of HCA the connection established on. What: /sys/class/rtrs-client//paths//hca_port Date: Feb 2020 diff --git a/Documentation/ABI/testing/sysfs-class-rtrs-server b/Documentation/ABI/testing/sysfs-class-rtrs-server index 3b6d5b067df0..b08601d80409 100644 --- a/Documentation/ABI/testing/sysfs-class-rtrs-server +++ b/Documentation/ABI/testing/sysfs-class-rtrs-server @@ -24,7 +24,7 @@ What: /sys/class/rtrs-server//paths//hca_name Date: Feb
Re: [PATCH v2] docs: Fix typo in comment
On 7/21/22 11:36, Jonathan Corbet wrote: > "Slark Xiao" writes: > >> May I know the maintainer of one subsystem could merge the changes >> contains lots of subsystem? I also know this could be filtered by >> grep and sed command, but that patch would have dozens of maintainers >> and reviewers. > > Certainly I don't think I can merge a patch touching 166 files across > the tree. This will need to be broken down by subsystem, and you may > well find that there are some maintainers who don't want to deal with > this type of minor fix. We have also seen cases where "the the" should be replaced by "then the" or some other pair of words, so some of these changes could fall into that category. -- ~Randy ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re: [PATCH v2] docs: Fix typo in comment
"Slark Xiao" writes: > May I know the maintainer of one subsystem could merge the changes > contains lots of subsystem? I also know this could be filtered by > grep and sed command, but that patch would have dozens of maintainers > and reviewers. Certainly I don't think I can merge a patch touching 166 files across the tree. This will need to be broken down by subsystem, and you may well find that there are some maintainers who don't want to deal with this type of minor fix. Thanks, jon ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
Re:Re: [PATCH v2] docs: Fix typo in comment
At 2022-07-21 10:49:40, "Baoquan He" wrote: >On 07/21/22 at 09:56am, Slark Xiao wrote: >> Fix typo in the comment > >Better tell what's fixed to save reviewers' time: > >Fix typo 'the the' in several places of document. > >Other then this nitpick, looks good to me. > >Reviewed-by: Baoquan He > Thanks for your advice. I will update it to other commits later. >> >> Signed-off-by: Slark Xiao >> --- >> v2: Add all .rst changes in Documents into 1 single patch >> --- >> Documentation/admin-guide/kdump/vmcoreinfo.rst| 2 +- >> Documentation/bpf/map_cgroup_storage.rst | 4 ++-- >> Documentation/core-api/cpu_hotplug.rst| 2 +- >> Documentation/driver-api/isa.rst | 2 +- >> Documentation/filesystems/caching/backend-api.rst | 2 +- >> Documentation/locking/seqlock.rst | 2 +- >> Documentation/sphinx/cdomain.py | 2 +- >> 7 files changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> index 8419019b6a88..6726f439958c 100644 >> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> @@ -200,7 +200,7 @@ prb >> >> A pointer to the printk ringbuffer (struct printk_ringbuffer). This >> may be pointing to the static boot ringbuffer or the dynamically >> -allocated ringbuffer, depending on when the the core dump occurred. >> +allocated ringbuffer, depending on when the core dump occurred. >> Used by user-space tools to read the active kernel log buffer. >> >> printk_rb_static >> diff --git a/Documentation/bpf/map_cgroup_storage.rst >> b/Documentation/bpf/map_cgroup_storage.rst >> index cab9543017bf..8e5fe532c07e 100644 >> --- a/Documentation/bpf/map_cgroup_storage.rst >> +++ b/Documentation/bpf/map_cgroup_storage.rst >> @@ -31,7 +31,7 @@ The map uses key of type of either ``__u64 >> cgroup_inode_id`` or >> }; >> >> ``cgroup_inode_id`` is the inode id of the cgroup directory. >> -``attach_type`` is the the program's attach type. >> +``attach_type`` is the program's attach type. >> >> Linux 5.9 added support for type ``__u64 cgroup_inode_id`` as the key type. >> When this key type is used, then all attach types of the particular cgroup >> and >> @@ -155,7 +155,7 @@ However, the BPF program can still only associate with >> one map of each type >> ``BPF_MAP_TYPE_CGROUP_STORAGE`` or more than one >> ``BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE``. >> >> -In all versions, userspace may use the the attach parameters of cgroup and >> +In all versions, userspace may use the attach parameters of cgroup and >> attach type pair in ``struct bpf_cgroup_storage_key`` as the key to the BPF >> map >> APIs to read or update the storage for a given attachment. For Linux 5.9 >> attach type shared storages, only the first value in the struct, cgroup >> inode >> diff --git a/Documentation/core-api/cpu_hotplug.rst >> b/Documentation/core-api/cpu_hotplug.rst >> index c6f4ba2fb32d..f75778d37488 100644 >> --- a/Documentation/core-api/cpu_hotplug.rst >> +++ b/Documentation/core-api/cpu_hotplug.rst >> @@ -560,7 +560,7 @@ available: >>* cpuhp_state_remove_instance(state, node) >>* cpuhp_state_remove_instance_nocalls(state, node) >> >> -The arguments are the same as for the the cpuhp_state_add_instance*() >> +The arguments are the same as for the cpuhp_state_add_instance*() >> variants above. >> >> The functions differ in the way how the installed callbacks are treated: >> diff --git a/Documentation/driver-api/isa.rst >> b/Documentation/driver-api/isa.rst >> index def4a7b690b5..3df1b1696524 100644 >> --- a/Documentation/driver-api/isa.rst >> +++ b/Documentation/driver-api/isa.rst >> @@ -100,7 +100,7 @@ I believe platform_data is available for this, but if >> rather not, moving >> the isa_driver pointer to the private struct isa_dev is ofcourse fine as >> well. >> >> -Then, if the the driver did not provide a .match, it matches. If it did, >> +Then, if the driver did not provide a .match, it matches. If it did, >> the driver match() method is called to determine a match. >> >> If it did **not** match, dev->platform_data is reset to indicate this to >> diff --git a/Documentation/filesystems/caching/backend-api.rst >> b/Documentation/filesystems/caching/backend-api.rst >> index d7507becf674..3a199fc50828 100644 >> --- a/Documentation/filesystems/caching/backend-api.rst >> +++ b/Documentation/filesystems/caching/backend-api.rst >> @@ -122,7 +122,7 @@ volumes, calling:: >> to tell fscache that a volume has been withdrawn. This waits for all >> outstanding accesses on the volume to complete before returning. >> >> -When the the cache is completely withdrawn, fscache should be notified by >> +When the cache is completely withdrawn, fscache should be notified by >> calling:: >> >> void fscache_relinquish_cache(struct fscache_cache *cache); >> diff
Re: [PATCH v2] docs: Fix typo in comment
On 07/21/22 at 09:56am, Slark Xiao wrote: > Fix typo in the comment Better tell what's fixed to save reviewers' time: Fix typo 'the the' in several places of document. Other then this nitpick, looks good to me. Reviewed-by: Baoquan He > > Signed-off-by: Slark Xiao > --- > v2: Add all .rst changes in Documents into 1 single patch > --- > Documentation/admin-guide/kdump/vmcoreinfo.rst| 2 +- > Documentation/bpf/map_cgroup_storage.rst | 4 ++-- > Documentation/core-api/cpu_hotplug.rst| 2 +- > Documentation/driver-api/isa.rst | 2 +- > Documentation/filesystems/caching/backend-api.rst | 2 +- > Documentation/locking/seqlock.rst | 2 +- > Documentation/sphinx/cdomain.py | 2 +- > 7 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst > b/Documentation/admin-guide/kdump/vmcoreinfo.rst > index 8419019b6a88..6726f439958c 100644 > --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst > +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst > @@ -200,7 +200,7 @@ prb > > A pointer to the printk ringbuffer (struct printk_ringbuffer). This > may be pointing to the static boot ringbuffer or the dynamically > -allocated ringbuffer, depending on when the the core dump occurred. > +allocated ringbuffer, depending on when the core dump occurred. > Used by user-space tools to read the active kernel log buffer. > > printk_rb_static > diff --git a/Documentation/bpf/map_cgroup_storage.rst > b/Documentation/bpf/map_cgroup_storage.rst > index cab9543017bf..8e5fe532c07e 100644 > --- a/Documentation/bpf/map_cgroup_storage.rst > +++ b/Documentation/bpf/map_cgroup_storage.rst > @@ -31,7 +31,7 @@ The map uses key of type of either ``__u64 > cgroup_inode_id`` or > }; > > ``cgroup_inode_id`` is the inode id of the cgroup directory. > -``attach_type`` is the the program's attach type. > +``attach_type`` is the program's attach type. > > Linux 5.9 added support for type ``__u64 cgroup_inode_id`` as the key type. > When this key type is used, then all attach types of the particular cgroup > and > @@ -155,7 +155,7 @@ However, the BPF program can still only associate with > one map of each type > ``BPF_MAP_TYPE_CGROUP_STORAGE`` or more than one > ``BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE``. > > -In all versions, userspace may use the the attach parameters of cgroup and > +In all versions, userspace may use the attach parameters of cgroup and > attach type pair in ``struct bpf_cgroup_storage_key`` as the key to the BPF > map > APIs to read or update the storage for a given attachment. For Linux 5.9 > attach type shared storages, only the first value in the struct, cgroup inode > diff --git a/Documentation/core-api/cpu_hotplug.rst > b/Documentation/core-api/cpu_hotplug.rst > index c6f4ba2fb32d..f75778d37488 100644 > --- a/Documentation/core-api/cpu_hotplug.rst > +++ b/Documentation/core-api/cpu_hotplug.rst > @@ -560,7 +560,7 @@ available: >* cpuhp_state_remove_instance(state, node) >* cpuhp_state_remove_instance_nocalls(state, node) > > -The arguments are the same as for the the cpuhp_state_add_instance*() > +The arguments are the same as for the cpuhp_state_add_instance*() > variants above. > > The functions differ in the way how the installed callbacks are treated: > diff --git a/Documentation/driver-api/isa.rst > b/Documentation/driver-api/isa.rst > index def4a7b690b5..3df1b1696524 100644 > --- a/Documentation/driver-api/isa.rst > +++ b/Documentation/driver-api/isa.rst > @@ -100,7 +100,7 @@ I believe platform_data is available for this, but if > rather not, moving > the isa_driver pointer to the private struct isa_dev is ofcourse fine as > well. > > -Then, if the the driver did not provide a .match, it matches. If it did, > +Then, if the driver did not provide a .match, it matches. If it did, > the driver match() method is called to determine a match. > > If it did **not** match, dev->platform_data is reset to indicate this to > diff --git a/Documentation/filesystems/caching/backend-api.rst > b/Documentation/filesystems/caching/backend-api.rst > index d7507becf674..3a199fc50828 100644 > --- a/Documentation/filesystems/caching/backend-api.rst > +++ b/Documentation/filesystems/caching/backend-api.rst > @@ -122,7 +122,7 @@ volumes, calling:: > to tell fscache that a volume has been withdrawn. This waits for all > outstanding accesses on the volume to complete before returning. > > -When the the cache is completely withdrawn, fscache should be notified by > +When the cache is completely withdrawn, fscache should be notified by > calling:: > > void fscache_relinquish_cache(struct fscache_cache *cache); > diff --git a/Documentation/locking/seqlock.rst > b/Documentation/locking/seqlock.rst > index 64405e5da63e..bfda1a5fecad 100644 > --- a/Documentation/locking/seqlock.rst > +++ b/Documentation/locking/seqlock.rst > @@ -39,7 +39,7 @@ as the
[PATCH v2] docs: Fix typo in comment
Fix typo in the comment Signed-off-by: Slark Xiao --- v2: Add all .rst changes in Documents into 1 single patch --- Documentation/admin-guide/kdump/vmcoreinfo.rst| 2 +- Documentation/bpf/map_cgroup_storage.rst | 4 ++-- Documentation/core-api/cpu_hotplug.rst| 2 +- Documentation/driver-api/isa.rst | 2 +- Documentation/filesystems/caching/backend-api.rst | 2 +- Documentation/locking/seqlock.rst | 2 +- Documentation/sphinx/cdomain.py | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst index 8419019b6a88..6726f439958c 100644 --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst @@ -200,7 +200,7 @@ prb A pointer to the printk ringbuffer (struct printk_ringbuffer). This may be pointing to the static boot ringbuffer or the dynamically -allocated ringbuffer, depending on when the the core dump occurred. +allocated ringbuffer, depending on when the core dump occurred. Used by user-space tools to read the active kernel log buffer. printk_rb_static diff --git a/Documentation/bpf/map_cgroup_storage.rst b/Documentation/bpf/map_cgroup_storage.rst index cab9543017bf..8e5fe532c07e 100644 --- a/Documentation/bpf/map_cgroup_storage.rst +++ b/Documentation/bpf/map_cgroup_storage.rst @@ -31,7 +31,7 @@ The map uses key of type of either ``__u64 cgroup_inode_id`` or }; ``cgroup_inode_id`` is the inode id of the cgroup directory. -``attach_type`` is the the program's attach type. +``attach_type`` is the program's attach type. Linux 5.9 added support for type ``__u64 cgroup_inode_id`` as the key type. When this key type is used, then all attach types of the particular cgroup and @@ -155,7 +155,7 @@ However, the BPF program can still only associate with one map of each type ``BPF_MAP_TYPE_CGROUP_STORAGE`` or more than one ``BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE``. -In all versions, userspace may use the the attach parameters of cgroup and +In all versions, userspace may use the attach parameters of cgroup and attach type pair in ``struct bpf_cgroup_storage_key`` as the key to the BPF map APIs to read or update the storage for a given attachment. For Linux 5.9 attach type shared storages, only the first value in the struct, cgroup inode diff --git a/Documentation/core-api/cpu_hotplug.rst b/Documentation/core-api/cpu_hotplug.rst index c6f4ba2fb32d..f75778d37488 100644 --- a/Documentation/core-api/cpu_hotplug.rst +++ b/Documentation/core-api/cpu_hotplug.rst @@ -560,7 +560,7 @@ available: * cpuhp_state_remove_instance(state, node) * cpuhp_state_remove_instance_nocalls(state, node) -The arguments are the same as for the the cpuhp_state_add_instance*() +The arguments are the same as for the cpuhp_state_add_instance*() variants above. The functions differ in the way how the installed callbacks are treated: diff --git a/Documentation/driver-api/isa.rst b/Documentation/driver-api/isa.rst index def4a7b690b5..3df1b1696524 100644 --- a/Documentation/driver-api/isa.rst +++ b/Documentation/driver-api/isa.rst @@ -100,7 +100,7 @@ I believe platform_data is available for this, but if rather not, moving the isa_driver pointer to the private struct isa_dev is ofcourse fine as well. -Then, if the the driver did not provide a .match, it matches. If it did, +Then, if the driver did not provide a .match, it matches. If it did, the driver match() method is called to determine a match. If it did **not** match, dev->platform_data is reset to indicate this to diff --git a/Documentation/filesystems/caching/backend-api.rst b/Documentation/filesystems/caching/backend-api.rst index d7507becf674..3a199fc50828 100644 --- a/Documentation/filesystems/caching/backend-api.rst +++ b/Documentation/filesystems/caching/backend-api.rst @@ -122,7 +122,7 @@ volumes, calling:: to tell fscache that a volume has been withdrawn. This waits for all outstanding accesses on the volume to complete before returning. -When the the cache is completely withdrawn, fscache should be notified by +When the cache is completely withdrawn, fscache should be notified by calling:: void fscache_relinquish_cache(struct fscache_cache *cache); diff --git a/Documentation/locking/seqlock.rst b/Documentation/locking/seqlock.rst index 64405e5da63e..bfda1a5fecad 100644 --- a/Documentation/locking/seqlock.rst +++ b/Documentation/locking/seqlock.rst @@ -39,7 +39,7 @@ as the writer can invalidate a pointer that the reader is following. Sequence counters (``seqcount_t``) == -This is the the raw counting mechanism, which does not protect against +This is the raw counting mechanism, which does not protect against multiple writers. Write side critical sections must thus be serialized by an external lock. diff --git a/Documentation/sphinx/cdomain.py
