Re: [Kgdb-bugreport] [PATCH v1] kgdb: Drop malformed kernel doc comment

2020-05-11 Thread Daniel Thompson
On Wed, May 06, 2020 at 06:17:27PM +0300, Andy Shevchenko wrote:
> Kernel doc does not understand POD variables to be referred to.
> 
> .../debug_core.c:73: warning: cannot understand function prototype:
> 'int kgdb_connected; '
> 
> Convert kernel doc to pure comment.
> 
> Fixes: dc7d55270521 ("kgdb: core")
> Cc: Jason Wessel 
> Signed-off-by: Andy Shevchenko 

Applied, thanks!

> ---
>  kernel/debug/debug_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
> index 01bc3eea3d4db..cd28a17b49a03 100644
> --- a/kernel/debug/debug_core.c
> +++ b/kernel/debug/debug_core.c
> @@ -67,9 +67,7 @@ static int kgdb_break_asap;
>  
>  struct debuggerinfo_struct kgdb_info[NR_CPUS];
>  
> -/**
> - * kgdb_connected - Is a host GDB connected to us?
> - */
> +/* kgdb_connected - Is a host GDB connected to us? */
>  int  kgdb_connected;
>  EXPORT_SYMBOL_GPL(kgdb_connected);
>  
> -- 
> 2.26.2
> 


___
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport


Re: [Kgdb-bugreport] [PATCH v1] kgdb: Drop malformed kernel doc comment

2020-05-06 Thread Doug Anderson
Hi,

On Wed, May 6, 2020 at 8:17 AM Andy Shevchenko
 wrote:
>
> Kernel doc does not understand POD variables to be referred to.
>
> .../debug_core.c:73: warning: cannot understand function prototype:
> 'int kgdb_connected; '
>
> Convert kernel doc to pure comment.
>
> Fixes: dc7d55270521 ("kgdb: core")
> Cc: Jason Wessel 
> Signed-off-by: Andy Shevchenko 
> ---
>  kernel/debug/debug_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Seems fine to me.

Reviewed-by: Douglas Anderson 


___
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport