Re: [Kicad-developers] [PATCH] Fix for bug/1754049

[Maciej Suminski]

Hi Jean-Pierre,

>>> -Not so minor issues:
>>> Multilayers items (blind/buried vias, keepout zones) are incorrectly 
>>> handled:
>>> * In GAL mode, removed Multilayers items are still visible after deletion.
>>
>> This should be fixed.  Even if it's something as crude as checking to
>> make sure the layer actually exists in the board before drawing an
>> object in gal.
> 
> I am certainly not a GAL specialist, but it is just a cache rebuild issue.
> 
> However, apart GAL issue, Multilayers items are not correctly handled, 
> because they are deleted
> regardless they are still existing on not deleted layers.

I have just done the following:
- set number of copper layers to 8
- placed a few buried vias between In2.Cu (3rd layer from the top) and
In5.Cu (3rd layer from the bottom)

Now when I decrease the number of Cu layers to 4, the vias remain but
have the target layer undefined as In5.Cu does not exist anymore. Once I
reduce the number of Cu layers to 2, they disappear. Restoring the
original number of layers brings them back.

Is that what you see as well? As far as I understand, the items are not
deleted as they are restored once the required layers are available. How
to trigger the issues you describe?

Regards,
Orson

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

[jp charras]

Le 26/03/2018 à 18:40, Wayne Stambaugh a écrit :
> On 3/26/2018 7:19 AM, jp charras wrote:
>> Le 26/03/2018 à 01:31, Wayne Stambaugh a écrit :
>>> Now that a fix for the lost data has been merged, we should defer the fix 
>>> for how to handle deleting
>>> objects from removed layers until v6.  In the mean time, we should clearly 
>>> define the behavior
>>> before we write any code to prevent any wasted developer time.
>>>
>>> Cheers,
>>>
>>> Wayne
>>
>> Hi Wayne,
>>
>> Before waiting for V6, there are a few things that must be fixed.
>>
>> - Minor issues:
>> * I am thinking the layers now used in DRC should be not removable (edge 
>> cut, courtyards and in the
>> future margin layer)
>> I have a basic fix for that.
> 
> I'm fine with this but we should define which layers are "mandatory" and
> which layers are not and make the UI behave accordingly.

I am thinking edge cut is mandatory.
I do not have a strong opinion about margin layer, not yet in use.

Because courtyards are used in V5 libs and DRC, I am inclined to think they are 
mandatory.

My fix makes the UI behave accordingly.

> 
>> * non copper layers used in footprints can be removed  (without fortunately 
>> destroying the
>> footprint) without warning: I have a fix to warn the user then removed non 
>> copper layers are in use
>> in a footprint.
> 
> This seem reasonable.

OK.
I can commit this small change.

> 
>>
>> -Not so minor issues:
>> Multilayers items (blind/buried vias, keepout zones) are incorrectly handled:
>> * In GAL mode, removed Multilayers items are still visible after deletion.
> 
> This should be fixed.  Even if it's something as crude as checking to
> make sure the layer actually exists in the board before drawing an
> object in gal.

I am certainly not a GAL specialist, but it is just a cache rebuild issue.

However, apart GAL issue, Multilayers items are not correctly handled, because 
they are deleted
regardless they are still existing on not deleted layers.

> 
>> * In all modes: because undo is not handled, if a removed item (for instance 
>> a track) was previously
>> modified (and therefore in the undo list), and if a undo command is made, 
>> Pcbnew crashes.
>> At least the undo/redo list should be cleared.
> 
> I'm guessing users are not going to like having their undo/redo historyt
> wiped out after a long editing session.  Would it be possible to just
> remove the objects/actions on the removed layers from the undo/redo
> buffer rather than clearing the entire buffer?

Sure, but I am not sure this is a small change.

A stub exists: see in pcbnew/undo_redo.cpp: TestForExistingItem( BOARD* aPcb, 
BOARD_ITEM* aItem ),
but I am not sure it can be done for rc2.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.0 RC2 release

[Adam Wolf]

The Mac stuff needs at least another week, and then some testing. Sorry folks.

We definitely could use help on the Mac stuff.  Please see
https://github.com/wayneandlayne/kicad-mac-builder and the issues
list, but you should be able to start up and use the build.sh script
to get things going.

The "stable" builds will be done on 10.11, but right now there is a
lot of replication and verification work.  i.e. get it building and
packaging on your system, and verify that footprints/symbols/every
type of script/templates/demos are going in the right directory.

There are a bunch of issues on the github repo, feel free to email me
if you want pointers at something you can do.

Adam

On Mon, Mar 26, 2018 at 11:25 AM, Wayne Stambaugh  wrote:
> How much work needs to be done on the packaging scripts for windows and
> macos?  I can always push rc2 back if necessary.
>
> On 3/26/2018 4:55 AM, Nick Østergaard wrote:
>> I mainly didn't push for announce rc1 because the new macos packaging
>> scripts are not done, and there are some refactoring needed in the
>> windows installer which has not been completed yet.
>>
>> 2018-03-25 18:32 GMT+02:00 Wayne Stambaugh > >:
>>
>> On 03/25/2018 11:16 AM, Jon Evans wrote:
>>
>> It seems like we are pretty close.
>>
>> Which of these are critical to get done for RC2 / which could be
>> delayed?
>> https://launchpad.net/kicad/+milestone/5.0.0-rc2
>> 
>>
>>
>> I think we are pretty close to rc2.  I have a few action items which
>> I should be able to knock out this week.  We should shoot for next
>> weekend unless something unexpected comes up.
>>
>>
>> Are there things that need to be done that aren't on the
>> milestone yet?
>>
>>
>> I'm not aware of anything.  If anyone else has anything to do,
>> please tag it for rc2.  rc2 will be a string freeze release so our
>> translators have time be v5 stable is released so please make any ui
>> string changes before then.
>>
>>
>> Should we publicize this release a bit more than RC1 when it is
>> ready?
>>
>>
>> If by publicize you mean add to the kicad website blog, then yes we
>> should do that.  I meant to make an rc1 announcement but I just
>> dropped the ball on that one.
>>
>> Wayne
>>
>>
>>
>> -Jon
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> 
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> 
>> More help   : https://help.launchpad.net/ListHelp
>> 
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> 
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> 
>> More help   : https://help.launchpad.net/ListHelp
>> 
>>
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

[Wayne Stambaugh]

On 3/26/2018 7:19 AM, jp charras wrote:
> Le 26/03/2018 à 01:31, Wayne Stambaugh a écrit :
>> Now that a fix for the lost data has been merged, we should defer the fix 
>> for how to handle deleting
>> objects from removed layers until v6.  In the mean time, we should clearly 
>> define the behavior
>> before we write any code to prevent any wasted developer time.
>>
>> Cheers,
>>
>> Wayne
> 
> Hi Wayne,
> 
> Before waiting for V6, there are a few things that must be fixed.
> 
> - Minor issues:
> * I am thinking the layers now used in DRC should be not removable (edge cut, 
> courtyards and in the
> future margin layer)
> I have a basic fix for that.

I'm fine with this but we should define which layers are "mandatory" and
which layers are not and make the UI behave accordingly.

> * non copper layers used in footprints can be removed  (without fortunately 
> destroying the
> footprint) without warning: I have a fix to warn the user then removed non 
> copper layers are in use
> in a footprint.

This seem reasonable.

> 
> -Not so minor issues:
> Multilayers items (blind/buried vias, keepout zones) are incorrectly handled:
> * In GAL mode, removed Multilayers items are still visible after deletion.

This should be fixed.  Even if it's something as crude as checking to
make sure the layer actually exists in the board before drawing an
object in gal.

> * In all modes: because undo is not handled, if a removed item (for instance 
> a track) was previously
> modified (and therefore in the undo list), and if a undo command is made, 
> Pcbnew crashes.
> At least the undo/redo list should be cleared.

I'm guessing users are not going to like having their undo/redo historyt
wiped out after a long editing session.  Would it be possible to just
remove the objects/actions on the removed layers from the undo/redo
buffer rather than clearing the entire buffer?

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.0 RC2 release

[Wayne Stambaugh]

How much work needs to be done on the packaging scripts for windows and
macos?  I can always push rc2 back if necessary.

On 3/26/2018 4:55 AM, Nick Østergaard wrote:
> I mainly didn't push for announce rc1 because the new macos packaging
> scripts are not done, and there are some refactoring needed in the
> windows installer which has not been completed yet.
> 
> 2018-03-25 18:32 GMT+02:00 Wayne Stambaugh  >:
> 
> On 03/25/2018 11:16 AM, Jon Evans wrote:
> 
> It seems like we are pretty close.
> 
> Which of these are critical to get done for RC2 / which could be
> delayed?
> https://launchpad.net/kicad/+milestone/5.0.0-rc2
> 
> 
> 
> I think we are pretty close to rc2.  I have a few action items which
> I should be able to knock out this week.  We should shoot for next
> weekend unless something unexpected comes up.
> 
> 
> Are there things that need to be done that aren't on the
> milestone yet?
> 
> 
> I'm not aware of anything.  If anyone else has anything to do,
> please tag it for rc2.  rc2 will be a string freeze release so our
> translators have time be v5 stable is released so please make any ui
> string changes before then.
> 
> 
> Should we publicize this release a bit more than RC1 when it is
> ready?
> 
> 
> If by publicize you mean add to the kicad website blog, then yes we
> should do that.  I meant to make an rc1 announcement but I just
> dropped the ball on that one.
> 
> Wayne
> 
> 
> 
> -Jon
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.0 RC2 release

[Nick Østergaard]

Yes.

The macos packing is https://github.com/wayneandlayne/kicad-mac-builder


2018-03-26 17:33 GMT+02:00 Jon Evans :

> Could the people working on the MacOS and Windows packaging stuff use more
> help?
> I can help with testing for sure, and could also take on some tasks if
> there is a list of things to do.
>
> -Jon
>
> On Mon, Mar 26, 2018 at 4:55 AM, Nick Østergaard 
> wrote:
>
>> I mainly didn't push for announce rc1 because the new macos packaging
>> scripts are not done, and there are some refactoring needed in the windows
>> installer which has not been completed yet.
>>
>> 2018-03-25 18:32 GMT+02:00 Wayne Stambaugh :
>>
>>> On 03/25/2018 11:16 AM, Jon Evans wrote:
>>>
 It seems like we are pretty close.

 Which of these are critical to get done for RC2 / which could be
 delayed?
 https://launchpad.net/kicad/+milestone/5.0.0-rc2

>>>
>>> I think we are pretty close to rc2.  I have a few action items which I
>>> should be able to knock out this week.  We should shoot for next weekend
>>> unless something unexpected comes up.
>>>
>>>
 Are there things that need to be done that aren't on the milestone yet?

>>>
>>> I'm not aware of anything.  If anyone else has anything to do, please
>>> tag it for rc2.  rc2 will be a string freeze release so our translators
>>> have time be v5 stable is released so please make any ui string changes
>>> before then.
>>>
>>>
 Should we publicize this release a bit more than RC1 when it is ready?

>>>
>>> If by publicize you mean add to the kicad website blog, then yes we
>>> should do that.  I meant to make an rc1 announcement but I just dropped the
>>> ball on that one.
>>>
>>> Wayne
>>>
>>>
>>>
 -Jon


 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp


>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.0 RC2 release

[Jon Evans]

Could the people working on the MacOS and Windows packaging stuff use more
help?
I can help with testing for sure, and could also take on some tasks if
there is a list of things to do.

-Jon

On Mon, Mar 26, 2018 at 4:55 AM, Nick Østergaard  wrote:

> I mainly didn't push for announce rc1 because the new macos packaging
> scripts are not done, and there are some refactoring needed in the windows
> installer which has not been completed yet.
>
> 2018-03-25 18:32 GMT+02:00 Wayne Stambaugh :
>
>> On 03/25/2018 11:16 AM, Jon Evans wrote:
>>
>>> It seems like we are pretty close.
>>>
>>> Which of these are critical to get done for RC2 / which could be delayed?
>>> https://launchpad.net/kicad/+milestone/5.0.0-rc2
>>>
>>
>> I think we are pretty close to rc2.  I have a few action items which I
>> should be able to knock out this week.  We should shoot for next weekend
>> unless something unexpected comes up.
>>
>>
>>> Are there things that need to be done that aren't on the milestone yet?
>>>
>>
>> I'm not aware of anything.  If anyone else has anything to do, please tag
>> it for rc2.  rc2 will be a string freeze release so our translators have
>> time be v5 stable is released so please make any ui string changes before
>> then.
>>
>>
>>> Should we publicize this release a bit more than RC1 when it is ready?
>>>
>>
>> If by publicize you mean add to the kicad website blog, then yes we
>> should do that.  I meant to make an rc1 announcement but I just dropped the
>> ball on that one.
>>
>> Wayne
>>
>>
>>
>>> -Jon
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Zone keepouts within modules

[Ladislav Laska]

Hi!

> Regarding thread merged, I am seeing this on
> 'https://lists.launchpad.net/kicad-developers/'. Maybe has to do with
> launchpad itself.

Yes. The first message you sent seems to reference the messages from the
previous thread "3D search paths and environment variables". This usually
happens whe you hit "reply" on some message and change the subject, delete the
body of the emaila and think it's fine. However, the email client usually
appends some metadata into the headers, which can be used to reconstruct
threads without relying on same subjects (which sometimes change due to Re:
Fwd: or many threads can have a same, but nonrelated subject).

In this case the metadata can be seen in header "In-Reply-To" and "References".

TL;DR: Post to the list by creating new message, not replying to another one
and deleting the content/subject.

Hope this clears it up and thanks for the work you're doing for kicad!

Cheers,
Ladislav

> 
> 
> Regards,
> 
> Simon
> 
> 
> On 25/03/2018 1:14, Jon Evans wrote:
> > Hi Simon,
> > 
> > I haven't had a chance to review and test your updated patch yet, and I
> > suspect the other devs are also busy trying to get 5.0 out the door.
> > But there are still a lot of code style issues that need to be fixed
> > (indentation needs to be spaces and you use tabs for one example, and
> > there are some other formatting issues)
> > I know this might seem annoying but it's important that we keep the
> > whole KiCad codebase styled the same way.
> > 
> > I suggest you keep your work in a Git branch that you can rebase on top
> > of KiCad master, since we won't be able to consider merging your code
> > into master until after the 5.0 release.
> > 
> > I'm not sure what you mean about the thread, maybe this is a thing about
> > your mail client?  I don't see those threads merged.
> > 
> > Best,
> > Jon
> > 
> > On Fri, Mar 23, 2018 at 4:36 AM, Simon Santesteban  > > wrote:
> > 
> > I am looking into adding zone keepout edition in inner layers, in
> > the module editor, but first I would like to confirm that my
> > previous work is ok.
> > 
> > Do you know how a patch is validated? Do I need to do anything else?
> > 
> > 
> > Also, I noticed that this thread ('Zone keepouts within modules')
> > has been incorporated to thread '3D search paths and environment
> > variables', but I don't see the similarity...
> > 
> > 
> > Thanks,
> > 
> > 
> > Simon
> > 
> > 
> > On 20/03/2018 1:55, Simon Santesteban wrote:
> > > 
> > > Hi Jon,
> > > 
> > > Oh yes I missed some of the code style policy...
> > > 
> > > I have attached an updated patch.
> > > 
> > > 
> > > Regards,
> > > 
> > > 
> > > Simon
> > > 
> > > 
> > > El 19/03/2018 a las 21:07, Jon Evans escribió:
> > > > Hi Simon,
> > > > 
> > > > Thanks for the updated patch, I was able to give it a quick try
> > > > and it so far I haven't found any issues (I edited a footprint
> > > > to create a keepout, and then saw that it correctly caused DRC
> > > > warnings)
> > > > 
> > > > I noticed a number of coding style policy issues with your patch
> > > > though; these would have to be fixed before it is merged.
> > > > (some issues with spacing around parentheses, use of tabs
> > > > instead of spaces, etc)
> > > > See here for details:
> > > > 
> > > > https://kicad-source-mirror.readthedocs.io/en/stable/Documentation/development/coding-style-policy/
> > > > 
> > > > 
> > > > 
> > > > Best,
> > > > Jon
> > > > 
> > > > On Mon, Mar 19, 2018 at 2:11 PM, Simon Santesteban
> > > > > wrote:
> > > > 
> > > > I think I have it updated correctly now. There was a
> > > > conflict in pcbnew/menubar_footprint_editor.cpp
> > > > 
> > > > See patch attached.
> > > > 
> > > > Simon
> > > > 
> > > > 
> > > > El 19/03/2018 a las 15:28, Jon Evans escribió:
> > > > > Hi Simon,
> > > > > 
> > > > > Thanks for sharing your work! This sounds like a neat
> > > > > feature and I'd like to test it and give feedback.
> > > > > Unfortunately your patch does not apply against current
> > > > > master, and it looks like it is based on an old enough
> > > > > point that I couldn't fix the merge issues manually.
> > > > > Could you please rebase your patch against the latest
> > > > > master and re-send it?
> > > > > 
> > > > > Please note in case you haven't been following the
> > > > > developer list, we are in feature freeze for the 5.0
> > > > > release and so we would only be able to merge new features
> > > > > like this once 6.0 development starts, so you'll likely
> > > > > need to rebase it once more before it 

Re: [Kicad-developers] Spice simulation on macOS

[Maciej Sumiński]

This is fine, thank you for quick response Jeff! I am looking at a bug
report describing problems with ngspice initialization on macOS [1], but
then it must be occurring only in KiCad installed from a package.

Cheers,
Orson

1. https://bugs.launchpad.net/kicad/+bug/1630675

On 03/26/2018 01:37 PM, Jeff Young wrote:
> Testing on my build gives a warning, but not an “unknown model” one:
> 
> Circuit: KiCad schematic
> Reducing trtol to 1 for xspice 'A' devices
> Doing analysis at TEMP = 27.00 and TNOM = 27.00
> Warning: vv1: has no value, DC 0 assumed
>  Reference value :  1.0e+00
> 
> No. of Data Rows : 61
> 
> I get nice plots when adding a signal.
> 
> Cheers,
> Jeff.
> 
> 
>> On 26 Mar 2018, at 12:30, Maciej Sumiński  wrote:
>>
>> Would someone running nightlies on macOS test the Spice simulator? In
>> particular, please simulate demos/simulation/sallen_key from our bundled
>> demos and see if you get warnings "Unknown model type spice2poly -
>> ignored". Testing both a self-built nightly and our official package [1]
>> would be greatly appreciated.
>>
>> Regards,
>> Orson
>>
>> 1. http://downloads.kicad-pcb.org/osx/nightly/
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

[jp charras]

Le 26/03/2018 à 13:24, Jeff Young a écrit :
> Could we allow deletion/disabling of the courtyard layer if we also disabled 
> the two courtyard-related checkboxes in DRC?  (Then again, that might be more 
> work than it deserves.)

No.
* These checkboxes are in the DRC dialog because the control of courtyard is a 
recent feature, and
many or all old boards/old footprints do not use courtyard, thus creating a lot 
of errors if they
are checked.
* This option is not directly related to the Layers setup dialog.
* All V5 footprints use a courtyard.

(These layers can be hidden for users that do not use yet these layers)

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Spice simulation on macOS

[Jeff Young]

Testing on my build gives a warning, but not an “unknown model” one:

Circuit: KiCad schematic
Reducing trtol to 1 for xspice 'A' devices
Doing analysis at TEMP = 27.00 and TNOM = 27.00
Warning: vv1: has no value, DC 0 assumed
 Reference value :  1.0e+00

No. of Data Rows : 61

I get nice plots when adding a signal.

Cheers,
Jeff.


> On 26 Mar 2018, at 12:30, Maciej Sumiński  wrote:
> 
> Would someone running nightlies on macOS test the Spice simulator? In
> particular, please simulate demos/simulation/sallen_key from our bundled
> demos and see if you get warnings "Unknown model type spice2poly -
> ignored". Testing both a self-built nightly and our official package [1]
> would be greatly appreciated.
> 
> Regards,
> Orson
> 
> 1. http://downloads.kicad-pcb.org/osx/nightly/
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

[jp charras]

Le 26/03/2018 à 01:31, Wayne Stambaugh a écrit :
> Now that a fix for the lost data has been merged, we should defer the fix for 
> how to handle deleting
> objects from removed layers until v6.  In the mean time, we should clearly 
> define the behavior
> before we write any code to prevent any wasted developer time.
> 
> Cheers,
> 
> Wayne

Hi Wayne,

Before waiting for V6, there are a few things that must be fixed.

- Minor issues:
* I am thinking the layers now used in DRC should be not removable (edge cut, 
courtyards and in the
future margin layer)
I have a basic fix for that.
* non copper layers used in footprints can be removed  (without fortunately 
destroying the
footprint) without warning: I have a fix to warn the user then removed non 
copper layers are in use
in a footprint.

-Not so minor issues:
Multilayers items (blind/buried vias, keepout zones) are incorrectly handled:
* In GAL mode, removed Multilayers items are still visible after deletion.
* In all modes: because undo is not handled, if a removed item (for instance a 
track) was previously
modified (and therefore in the undo list), and if a undo command is made, 
Pcbnew crashes.
At least the undo/redo list should be cleared.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Spice simulation on macOS

[Maciej Sumiński]

Would someone running nightlies on macOS test the Spice simulator? In
particular, please simulate demos/simulation/sallen_key from our bundled
demos and see if you get warnings "Unknown model type spice2poly -
ignored". Testing both a self-built nightly and our official package [1]
would be greatly appreciated.

Regards,
Orson

1. http://downloads.kicad-pcb.org/osx/nightly/



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

[Jeff Young]

Could we allow deletion/disabling of the courtyard layer if we also disabled 
the two courtyard-related checkboxes in DRC?  (Then again, that might be more 
work than it deserves.)



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Don't create an extra segment at the end of closed SHAPE_LINE_CHAIN

[Maciej Sumiński]

Hi Jon,

If we decide to handle this special case, then we need to account for
the point count as well. Otherwise it may lead to situations when the
number of points is higher than the number of segments.

Please see the attached patch (particularly 0002). I think these changes
might be committed after a short test period. If we want to go the safe,
but not so elegant way, then perhaps a simple condition could be added
to POLYGON_GEOM_MANAGER::IsSelfIntersecting().

Cheers,
Orson

On 03/25/2018 04:07 AM, Jon Evans wrote:
> Hi all (but especially Orson),
> 
> I wanted to fix the issue Bernhard raised here:
> https://bugs.launchpad.net/kicad/+bug/1751654/comments/7
> 
> I dug in to it a bit and found out
> that SHAPE_LINE_CHAIN::SelfIntersecting() doesn't work right when polygons
> are actually closed (i.e. the last point is the same as the first) and when
> m_closed is set to true.
> 
> The attached patch fixes this by only generating a closing segment when the
> last point isn't the same as the first point.  It fixes the issue with the
> self-intersection warning showing up even when you aren't yet intersecting
> (i.e. when the last point is the same as the first), and I didn't notice
> any obvious other issues, but maybe you can double-check that changing the
> behavior of SegmentCount() won't have any strange side-effects.
> 
> Thanks,
> -Jon
> 

From c90eefc472ff31999a2273d87b4967b3a9518e2e Mon Sep 17 00:00:00 2001
From: Maciej Suminski 
Date: Mon, 26 Mar 2018 11:23:43 +0200
Subject: [PATCH 1/2] Code formatting

---
 common/geometry/shape_line_chain.cpp | 12 
 include/geometry/shape_line_chain.h  |  1 +
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/common/geometry/shape_line_chain.cpp b/common/geometry/shape_line_chain.cpp
index 5f11b376c..2e0e12f10 100644
--- a/common/geometry/shape_line_chain.cpp
+++ b/common/geometry/shape_line_chain.cpp
@@ -397,7 +397,7 @@ const OPT SHAPE_LINE_CHAIN::SelfIntersecting() c
  // for closed polylines, the ending point of the
  // last segment == starting point of the first segment
  // this is a normal case, not self intersecting case
- !( IsClosed() && s1 == 0 && s2 == SegmentCount()-1 ) )
+ !( IsClosed() && s1 == 0 && s2 == SegmentCount() - 1 ) )
 {
 INTERSECTION is;
 is.our = CSegment( s1 );
@@ -547,18 +547,21 @@ const std::string SHAPE_LINE_CHAIN::Format() const
 }
 
 
-bool SHAPE_LINE_CHAIN::CompareGeometry ( const SHAPE_LINE_CHAIN & aOther ) const
+bool SHAPE_LINE_CHAIN::CompareGeometry( const SHAPE_LINE_CHAIN& aOther ) const
 {
-SHAPE_LINE_CHAIN a(*this), b( aOther );
+SHAPE_LINE_CHAIN a( *this ), b( aOther );
 a.Simplify();
 b.Simplify();
 
 if( a.m_points.size() != b.m_points.size() )
 return false;
 
-for( int i = 0; i < a.PointCount(); i++)
+for( int i = 0; i < a.PointCount(); i++ )
+{
 if( a.CPoint( i ) != b.CPoint( i ) )
 return false;
+}
+
 return true;
 }
 
@@ -624,6 +627,7 @@ const VECTOR2I SHAPE_LINE_CHAIN::PointAlong( int aPathLength ) const
 return CPoint( -1 );
 }
 
+
 double SHAPE_LINE_CHAIN::Area() const
 {
 // see https://www.mathopenref.com/coordpolygonarea2.html
diff --git a/include/geometry/shape_line_chain.h b/include/geometry/shape_line_chain.h
index 135ea8b18..fad136fce 100644
--- a/include/geometry/shape_line_chain.h
+++ b/include/geometry/shape_line_chain.h
@@ -171,6 +171,7 @@ public:
 int SegmentCount() const
 {
 int c = m_points.size() - 1;
+
 if( m_closed && ( m_points[0] != m_points[c] ) )
 c++;
 
-- 
2.16.2

From 31903b03e22a831f3878bc32f61de19241133845 Mon Sep 17 00:00:00 2001
From: Maciej Suminski 
Date: Mon, 26 Mar 2018 12:49:16 +0200
Subject: [PATCH 2/2] Handle correctly closed SHAPE_LINE_CHAINs with equal
 first and last points

SHAPE_LINE_CHAIN by default do not repeat the first point in the point
list, even when it is set to 'closed'. In case the first point is
duplicated as the last point, the returned number of points/segments
needs to be adjusted to match the default behavior (ignore the duplicated
point).
---
 common/geometry/shape_line_chain.cpp |  6 +++---
 include/geometry/shape_line_chain.h  | 19 ---
 2 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/common/geometry/shape_line_chain.cpp b/common/geometry/shape_line_chain.cpp
index 2e0e12f10..5e3a6fea1 100644
--- a/common/geometry/shape_line_chain.cpp
+++ b/common/geometry/shape_line_chain.cpp
@@ -538,7 +538,7 @@ const std::string SHAPE_LINE_CHAIN::Format() const
 {
 std::stringstream ss;
 
-ss << m_points.size() << " " << ( m_closed ? 1 : 0 ) << " ";
+ss << PointCount() << " " << ( m_closed ? 1 : 0 ) << " ";
 
 for( int i = 0; i < PointCount(); i++ )
 ss << m_points[i].x << " " << 

Re: [Kicad-developers] 5.0 RC2 release

[Nick Østergaard]

I mainly didn't push for announce rc1 because the new macos packaging
scripts are not done, and there are some refactoring needed in the windows
installer which has not been completed yet.

2018-03-25 18:32 GMT+02:00 Wayne Stambaugh :

> On 03/25/2018 11:16 AM, Jon Evans wrote:
>
>> It seems like we are pretty close.
>>
>> Which of these are critical to get done for RC2 / which could be delayed?
>> https://launchpad.net/kicad/+milestone/5.0.0-rc2
>>
>
> I think we are pretty close to rc2.  I have a few action items which I
> should be able to knock out this week.  We should shoot for next weekend
> unless something unexpected comes up.
>
>
>> Are there things that need to be done that aren't on the milestone yet?
>>
>
> I'm not aware of anything.  If anyone else has anything to do, please tag
> it for rc2.  rc2 will be a string freeze release so our translators have
> time be v5 stable is released so please make any ui string changes before
> then.
>
>
>> Should we publicize this release a bit more than RC1 when it is ready?
>>
>
> If by publicize you mean add to the kicad website blog, then yes we should
> do that.  I meant to make an rc1 announcement but I just dropped the ball
> on that one.
>
> Wayne
>
>
>
>> -Jon
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Zone keepouts within modules

[Simon Santesteban]

Ok, thank you. I hope 5.0 is released soon.

Regarding thread merged, I am seeing this on 
'https://lists.launchpad.net/kicad-developers/'. Maybe has to do with 
launchpad itself.



Regards,

Simon


On 25/03/2018 1:14, Jon Evans wrote:

Hi Simon,

I haven't had a chance to review and test your updated patch yet, and 
I suspect the other devs are also busy trying to get 5.0 out the door.
But there are still a lot of code style issues that need to be fixed 
(indentation needs to be spaces and you use tabs for one example, and 
there are some other formatting issues)
I know this might seem annoying but it's important that we keep the 
whole KiCad codebase styled the same way.


I suggest you keep your work in a Git branch that you can rebase on 
top of KiCad master, since we won't be able to consider merging your 
code into master until after the 5.0 release.


I'm not sure what you mean about the thread, maybe this is a thing 
about your mail client?  I don't see those threads merged.


Best,
Jon

On Fri, Mar 23, 2018 at 4:36 AM, Simon Santesteban > wrote:


I am looking into adding zone keepout edition in inner layers, in
the module editor, but first I would like to confirm that my
previous work is ok.

Do you know how a patch is validated? Do I need to do anything else?


Also, I noticed that this thread ('Zone keepouts within modules')
has been incorporated to thread '3D search paths and environment
variables', but I don't see the similarity...


Thanks,


Simon


On 20/03/2018 1:55, Simon Santesteban wrote:


Hi Jon,

Oh yes I missed some of the code style policy...

I have attached an updated patch.


Regards,


Simon


El 19/03/2018 a las 21:07, Jon Evans escribió:

Hi Simon,

Thanks for the updated patch, I was able to give it a quick try
and it so far I haven't found any issues (I edited a footprint
to create a keepout, and then saw that it correctly caused DRC
warnings)

I noticed a number of coding style policy issues with your patch
though; these would have to be fixed before it is merged.
(some issues with spacing around parentheses, use of tabs
instead of spaces, etc)
See here for details:

https://kicad-source-mirror.readthedocs.io/en/stable/Documentation/development/coding-style-policy/



Best,
Jon

On Mon, Mar 19, 2018 at 2:11 PM, Simon Santesteban
> wrote:

I think I have it updated correctly now. There was a
conflict in pcbnew/menubar_footprint_editor.cpp

See patch attached.

Simon


El 19/03/2018 a las 15:28, Jon Evans escribió:

Hi Simon,

Thanks for sharing your work! This sounds like a neat
feature and I'd like to test it and give feedback.
Unfortunately your patch does not apply against current
master, and it looks like it is based on an old enough
point that I couldn't fix the merge issues manually.
Could you please rebase your patch against the latest
master and re-send it?

Please note in case you haven't been following the
developer list, we are in feature freeze for the 5.0
release and so we would only be able to merge new features
like this once 6.0 development starts, so you'll likely
need to rebase it once more before it can be merged at that
point.

Thanks,
Jon

On Mon, Mar 19, 2018 at 8:02 AM, Simon Santesteban
> wrote:

Hi everyone,

I am a new developer in kicad community. I have been
working on adding zones to modules, so I would like to
share this work.
Find attached a patch to have this functionality.

Regards,

Simon

___
Mailing list: https://launchpad.net/~kicad-developers

Post to     : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers

More help   : https://help.launchpad.net/ListHelp






___
Mailing list: https://launchpad.net/~kicad-developers

Post to     : kicad-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~kicad-developers