date:20180717

Re: [Kicad-developers] 5.1 UI feedback

2018-07-17 Thread Jeff Young

Hi Wayne,

I merged a bunch of spacing changes (only in master for now).

When you have a chance could you screen-shot those same 4 dialogs again?

Thanks,
Jeff.


> On 17 Jul 2018, at 20:48, Wayne Stambaugh  wrote:
> 
> Hey Jeff,
> 
> The text size is better but there is now dead space above the button
> sizer.  It's different but I'm not sure that is better.  For CvPcb, our
> standard message panel might be a good option so that it separates the
> message information from the button sizer space.  I'm not sure what the
> answer is for a typical dialog.
> 
> Wayne
> 
> On 7/17/2018 3:34 PM, Jeff Young wrote:
>> Hi Wayne,
>> 
>> Can you send a screenshot of CvPCB with status text at the bottom?  I used a 
>> different strategy for setting the text size there which hopefully works 
>> better on Windows.
>> 
>> Thanks,
>> Jeff.
>> 
>> 
>>> On 17 Jul 2018, at 19:32, Wayne Stambaugh  wrote:
>>> 
>>> See attached image for windows.
>>> 
>>> There is something very odd going on with some of the dialogs where it
>>> looks like a control is constantly being refreshed as though it is in
>>> some kind of event loop.  Did you make any changes to DIALOG_SHIM that
>>> could cause this?  It is the most noticeable in the schematic plot
>>> dialog page size selection drop down control.
>>> 
>>> All dialogs that have text in the dialog button sizer look terrible on
>>> windows.  The text is way too big and messes up the button sizer.  I try
>>> to avoid using anything but the standard text size in controls.  They
>>> never seem to be consistent between platforms.  I would prefer if you
>>> find a better place for this text.  Maybe a static text control at the
>>> top of dialog or possible the title bar.  See fp-props-dialog.png.
>>> 
>>> There are quite a few dialogs that have incorrect padding in the
>>> standard button sizer.  I'm sure I fixed most (all) of these before we
>>> branched stable 5.  See change-fp-dialog.png.
>>> 
>>> 
>>> On 7/17/2018 2:04 PM, Jeff Young wrote:
 As long as they’re coming in in onesies and twosies email is fine.  If
 they start coming in thicker and faster bug reports are probably better.
 
 Can you send me a screenshot of the Edit Spice Model… button?  I assume
 it looks different than on OSX:
 
 
 Cheers,
 Jeff.
 
> On 17 Jul 2018, at 18:52, Wayne Stambaugh  > wrote:
> 
> On 7/17/2018 1:08 PM, jp charras wrote:
>> Le 17/07/2018 à 18:22, Jeff Young a écrit :
>>> Hi JP,
>>> 
>>> I merged another version of the Netclass Membership editor.  Let me
>>> know what you think.
>>> 
>>> Cheers,
>>> Jeff.
>>> 
>> 
>> It is must better now.
>> Thanks.
>> 
> 
> Do you want bugs reported against these changes or are you just looking
> for general feedback?  I found a size and alignment issue with the "Edit
> Spice Model.." button in the symbol editor dialog.  I can file a bug
> report against it if you prefer.
> 
> Wayne
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
 
>>> 
>> 
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 UI feedback

2018-07-17 Thread Wayne Stambaugh

Hey Jeff,

The text size is better but there is now dead space above the button
sizer.  It's different but I'm not sure that is better.  For CvPcb, our
standard message panel might be a good option so that it separates the
message information from the button sizer space.  I'm not sure what the
answer is for a typical dialog.

Wayne

On 7/17/2018 3:34 PM, Jeff Young wrote:
> Hi Wayne,
> 
> Can you send a screenshot of CvPCB with status text at the bottom?  I used a 
> different strategy for setting the text size there which hopefully works 
> better on Windows.
> 
> Thanks,
> Jeff.
> 
> 
>> On 17 Jul 2018, at 19:32, Wayne Stambaugh  wrote:
>>
>> See attached image for windows.
>>
>> There is something very odd going on with some of the dialogs where it
>> looks like a control is constantly being refreshed as though it is in
>> some kind of event loop.  Did you make any changes to DIALOG_SHIM that
>> could cause this?  It is the most noticeable in the schematic plot
>> dialog page size selection drop down control.
>>
>> All dialogs that have text in the dialog button sizer look terrible on
>> windows.  The text is way too big and messes up the button sizer.  I try
>> to avoid using anything but the standard text size in controls.  They
>> never seem to be consistent between platforms.  I would prefer if you
>> find a better place for this text.  Maybe a static text control at the
>> top of dialog or possible the title bar.  See fp-props-dialog.png.
>>
>> There are quite a few dialogs that have incorrect padding in the
>> standard button sizer.  I'm sure I fixed most (all) of these before we
>> branched stable 5.  See change-fp-dialog.png.
>>
>>
>> On 7/17/2018 2:04 PM, Jeff Young wrote:
>>> As long as they’re coming in in onesies and twosies email is fine.  If
>>> they start coming in thicker and faster bug reports are probably better.
>>>
>>> Can you send me a screenshot of the Edit Spice Model… button?  I assume
>>> it looks different than on OSX:
>>>
>>>
>>> Cheers,
>>> Jeff.
>>>
 On 17 Jul 2018, at 18:52, Wayne Stambaugh >>> > wrote:

 On 7/17/2018 1:08 PM, jp charras wrote:
> Le 17/07/2018 à 18:22, Jeff Young a écrit :
>> Hi JP,
>>
>> I merged another version of the Netclass Membership editor.  Let me
>> know what you think.
>>
>> Cheers,
>> Jeff.
>>
>
> It is must better now.
> Thanks.
>

 Do you want bugs reported against these changes or are you just looking
 for general feedback?  I found a size and alignment issue with the "Edit
 Spice Model.." button in the symbol editor dialog.  I can file a bug
 report against it if you prefer.

 Wayne

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 
 Post to : kicad-developers@lists.launchpad.net
 
 Unsubscribe : https://launchpad.net/~kicad-developers
 
 More help   : https://help.launchpad.net/ListHelp
>>>
>> 
> 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 UI feedback

2018-07-17 Thread Jeff Young

Hi Wayne,

Can you send a screenshot of CvPCB with status text at the bottom?  I used a 
different strategy for setting the text size there which hopefully works better 
on Windows.

Thanks,
Jeff.


> On 17 Jul 2018, at 19:32, Wayne Stambaugh  wrote:
> 
> See attached image for windows.
> 
> There is something very odd going on with some of the dialogs where it
> looks like a control is constantly being refreshed as though it is in
> some kind of event loop.  Did you make any changes to DIALOG_SHIM that
> could cause this?  It is the most noticeable in the schematic plot
> dialog page size selection drop down control.
> 
> All dialogs that have text in the dialog button sizer look terrible on
> windows.  The text is way too big and messes up the button sizer.  I try
> to avoid using anything but the standard text size in controls.  They
> never seem to be consistent between platforms.  I would prefer if you
> find a better place for this text.  Maybe a static text control at the
> top of dialog or possible the title bar.  See fp-props-dialog.png.
> 
> There are quite a few dialogs that have incorrect padding in the
> standard button sizer.  I'm sure I fixed most (all) of these before we
> branched stable 5.  See change-fp-dialog.png.
> 
> 
> On 7/17/2018 2:04 PM, Jeff Young wrote:
>> As long as they’re coming in in onesies and twosies email is fine.  If
>> they start coming in thicker and faster bug reports are probably better.
>> 
>> Can you send me a screenshot of the Edit Spice Model… button?  I assume
>> it looks different than on OSX:
>> 
>> 
>> Cheers,
>> Jeff.
>> 
>>> On 17 Jul 2018, at 18:52, Wayne Stambaugh >> > wrote:
>>> 
>>> On 7/17/2018 1:08 PM, jp charras wrote:
 Le 17/07/2018 à 18:22, Jeff Young a écrit :
> Hi JP,
> 
> I merged another version of the Netclass Membership editor.  Let me
> know what you think.
> 
> Cheers,
> Jeff.
> 
 
 It is must better now.
 Thanks.
 
>>> 
>>> Do you want bugs reported against these changes or are you just looking
>>> for general feedback?  I found a size and alignment issue with the "Edit
>>> Spice Model.." button in the symbol editor dialog.  I can file a bug
>>> report against it if you prefer.
>>> 
>>> Wayne
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> 
>>> Post to : kicad-developers@lists.launchpad.net
>>> 
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> 
>>> More help   : https://help.launchpad.net/ListHelp
>> 
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-17 Thread mdoesbur

Hello Seth,

I don't know how to use eagle myself, but will ask a colleague to create
a small sample project. He's on vacation right now but will be back
next week.

regards,

Mark.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 UI feedback

2018-07-17 Thread Wayne Stambaugh

See attached image for windows.

There is something very odd going on with some of the dialogs where it
looks like a control is constantly being refreshed as though it is in
some kind of event loop.  Did you make any changes to DIALOG_SHIM that
could cause this?  It is the most noticeable in the schematic plot
dialog page size selection drop down control.

All dialogs that have text in the dialog button sizer look terrible on
windows.  The text is way too big and messes up the button sizer.  I try
to avoid using anything but the standard text size in controls.  They
never seem to be consistent between platforms.  I would prefer if you
find a better place for this text.  Maybe a static text control at the
top of dialog or possible the title bar.  See fp-props-dialog.png.

There are quite a few dialogs that have incorrect padding in the
standard button sizer.  I'm sure I fixed most (all) of these before we
branched stable 5.  See change-fp-dialog.png.

On 7/17/2018 2:04 PM, Jeff Young wrote:
> As long as they’re coming in in onesies and twosies email is fine.  If
> they start coming in thicker and faster bug reports are probably better.
> 
> Can you send me a screenshot of the Edit Spice Model… button?  I assume
> it looks different than on OSX:
> 
> 
> Cheers,
> Jeff.
> 
>> On 17 Jul 2018, at 18:52, Wayne Stambaugh > > wrote:
>>
>> On 7/17/2018 1:08 PM, jp charras wrote:
>>> Le 17/07/2018 à 18:22, Jeff Young a écrit :
 Hi JP,

 I merged another version of the Netclass Membership editor.  Let me
 know what you think.

 Cheers,
 Jeff.

>>>
>>> It is must better now.
>>> Thanks.
>>>
>>
>> Do you want bugs reported against these changes or are you just looking
>> for general feedback?  I found a size and alignment issue with the "Edit
>> Spice Model.." button in the symbol editor dialog.  I can file a bug
>> report against it if you prefer.
>>
>> Wayne
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> 
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> 
>> More help   : https://help.launchpad.net/ListHelp
> 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 UI feedback

2018-07-17 Thread Jeff Young

As long as they’re coming in in onesies and twosies email is fine.  If they 
start coming in thicker and faster bug reports are probably better.

Can you send me a screenshot of the Edit Spice Model… button?  I assume it 
looks different than on OSX:



Cheers,
Jeff.

> On 17 Jul 2018, at 18:52, Wayne Stambaugh  wrote:
> 
> On 7/17/2018 1:08 PM, jp charras wrote:
>> Le 17/07/2018 à 18:22, Jeff Young a écrit :
>>> Hi JP,
>>> 
>>> I merged another version of the Netclass Membership editor.  Let me know 
>>> what you think.
>>> 
>>> Cheers,
>>> Jeff.
>>> 
>> 
>> It is must better now.
>> Thanks.
>> 
> 
> Do you want bugs reported against these changes or are you just looking
> for general feedback?  I found a size and alignment issue with the "Edit
> Spice Model.." button in the symbol editor dialog.  I can file a bug
> report against it if you prefer.
> 
> Wayne
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 UI feedback

2018-07-17 Thread jp charras

Le 17/07/2018 à 19:08, jp charras a écrit :
> Le 17/07/2018 à 18:22, Jeff Young a écrit :
>> Hi JP,
>>
>> I merged another version of the Netclass Membership editor.  Let me know 
>> what you think.
>>
>> Cheers,
>> Jeff.
>>
> 
> It is must better now.
much!
> Thanks.
> 


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 UI feedback

2018-07-17 Thread Wayne Stambaugh

On 7/17/2018 1:08 PM, jp charras wrote:
> Le 17/07/2018 à 18:22, Jeff Young a écrit :
>> Hi JP,
>>
>> I merged another version of the Netclass Membership editor.  Let me know 
>> what you think.
>>
>> Cheers,
>> Jeff.
>>
> 
> It is must better now.
> Thanks.
> 

Do you want bugs reported against these changes or are you just looking
for general feedback?  I found a size and alignment issue with the "Edit
Spice Model.." button in the symbol editor dialog.  I can file a bug
report against it if you prefer.

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Janitor commits missing

2018-07-17 Thread Seth Hillbrand

Hi Orson-

I'm seeing Jeff's cherry-picked commits being processed by Janitor but they
seem to be missing the reference to the commit that previous Janitor log
messages had.

Is this intentional in how Janitor handles cherry-picks?

-S
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 UI feedback

2018-07-17 Thread jp charras

Le 17/07/2018 à 18:22, Jeff Young a écrit :
> Hi JP,
> 
> I merged another version of the Netclass Membership editor.  Let me know what 
> you think.
> 
> Cheers,
> Jeff.
> 

It is must better now.
Thanks.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Reminder

2018-07-17 Thread Wayne Stambaugh

On 7/17/2018 12:12 PM, Seth Hillbrand wrote:
> Hi Wayne-
> 
> Just so I'm clear on how you'd like this to work:
> 
> We have a commit that affects 5.0.x, 5.1 and 6.  We could do
> 1) git checkout master
> 2) git commit (get  back)
> 3) git checkout 5.1
> 4) git cherry-pick 
> 5) compile/test
> 6) git checkout 5.0
> 7) git cherry-pick 
> 8) compile/test
> 9) git push
> 
> This will get 3 separate SHA (one for each branch).  Or would you prefer
> us to use git merge to keep the original SHA with an additional merge
> commit?  I can see arguments for each but wanted to check which is
> preferred.

I really don't have a preference other than to make sure we don't push
commits to the wrong branch.  I used git cherry-pick for the 4.0 branch
maintenance so if using it is easiest for you, then that's what you
should use.

> 
> -Seth
> 
> 
> Am Di., 17. Juli 2018 um 06:32 Uhr schrieb Wayne Stambaugh
> mailto:stambau...@gmail.com>>:
> 
> Just a quick reminder to the lead developers, if you push a bug fix into
> the development branch that effects the 5.0 and 5.1 branches, please
> don't forget to push the fix to the 5.0 and 5.1 branches.
> 
> Thanks,
> 
> Wayne
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-17 Thread Seth Hillbrand

Hi Mark-

Thank you for your contribution.  It would be helpful to evaluating the
patch if you could provide an example Eagle project that uses the variants
feature.

Best-
Seth

Am Mo., 16. Juli 2018 um 23:49 Uhr schrieb :

> From: Mark van Doesburg 
>
> Here is a patch that copies all attributes from an original eagle
> schematic. This is necessary for me to keep the BOM the same.
>
> Since kicad does not yet support variants, it creates additional fields
> for values that differ for variants. It prefixes them with "VARIANT_"
>
>
> ---
>  common/eagle_parser.cpp   | 31 
>  eeschema/sch_eagle_plugin.cpp | 39 +++
>  include/eagle_parser.h|  2 ++
>  3 files changed, 68 insertions(+), 4 deletions(-)
>
> diff --git a/common/eagle_parser.cpp b/common/eagle_parser.cpp
> index 60aa52612..6d8aa3fe5 100644
> --- a/common/eagle_parser.cpp
> +++ b/common/eagle_parser.cpp
> @@ -884,8 +884,39 @@ EPART::EPART( wxXmlNode* aPart )
>  library = parseRequiredAttribute( aPart, "library" );
>  deviceset = parseRequiredAttribute( aPart, "deviceset" );
>  device = parseRequiredAttribute( aPart, "device" );
> +
>  technology = parseOptionalAttribute( aPart, "technology" );
>  value = parseOptionalAttribute( aPart, "value" );
> +
> +for( auto child = aPart->GetChildren(  ); child; child =
> child->GetNext(  ) )
> +{
> +   if( child->GetName(  ) == "attribute" )
> +   {
> +   std::string aname, avalue;
> +   for( auto x = child->GetAttributes(  ); x; x = x->GetNext(  ) )
> +   {
> +   if( x->GetName(  ) == "name" )
> +   aname = x->GetValue(  );
> +   else if( x->GetName(  ) == "value" )
> +   avalue = x->GetValue(  );
> +   }
> +   if( aname.size(  ) && avalue.size(  ) )
> +   attribute[aname] = avalue;
> +   }
> +   else if( child->GetName(  ) == "variant" )
> +   {
> +   std::string aname, avalue;
> +   for( auto x = child->GetAttributes(  ); x; x = x->GetNext(  ) )
> +   {
> +   if( x->GetName(  ) == "name" )
> +   aname = x->GetValue(  );
> +   else if( x->GetName(  ) == "value" )
> +   avalue = x->GetValue(  );
> +   }
> +   if( aname.size(  ) && avalue.size(  ) )
> +   variant[aname] = avalue;
> +   }
> +}
>  }
>
>
> diff --git a/eeschema/sch_eagle_plugin.cpp b/eeschema/sch_eagle_plugin.cpp
> index 0b36e1f25..c7a999c5b 100644
> --- a/eeschema/sch_eagle_plugin.cpp
> +++ b/eeschema/sch_eagle_plugin.cpp
> @@ -1142,6 +1142,22 @@ void SCH_EAGLE_PLUGIN::loadInstance( wxXmlNode*
> aInstanceNode )
>  component->GetField( REFERENCE )->SetVisible( part->GetField(
> REFERENCE )->IsVisible() );
>  component->GetField( VALUE )->SetVisible( part->GetField( VALUE
> )->IsVisible() );
>
> +for( auto a:epart->attribute )
> +{
> +   auto field = component->AddField( SCH_FIELD( *component->GetField(
> VALUE ) ) );
> +   field->SetName( a.first );
> +   field->SetText( a.second );
> +   field->SetVisible( false );
> +}
> +
> +for( auto a:epart->variant )
> +{
> +   auto field = component->AddField( SCH_FIELD( *component->GetField(
> VALUE ) ) );
> +   field->SetName( "VARIANT_" + a.first );
> +   field->SetText( a.second );
> +   field->SetVisible( false );
> +}
> +
>  bool valueAttributeFound = false;
>  bool nameAttributeFound  = false;
>
> @@ -1157,18 +1173,20 @@ void SCH_EAGLE_PLUGIN::loadInstance( wxXmlNode*
> aInstanceNode )
>
>  SCH_FIELD* field;
>
> -if( attr.name.Lower() == "name" || attr.name.Lower() ==
> "value" )
> +if( attr.name.Lower() == "name" || attr.name.Lower() ==
> "value" || (field = component->FindField( attr.name )))
>  {
>  if( attr.name.Lower() == "name" )
>  {
>  field = component->GetField( REFERENCE );
>  nameAttributeFound = true;
>  }
> -else
> +else if( attr.name.Lower() == "value" )
>  {
>  field = component->GetField( VALUE );
>  valueAttributeFound = true;
> -}
> +} else {
> +field->SetVisible( false );
> +   }
>
>  field->SetPosition( wxPoint( attr.x->ToSchUnits(),
> -attr.y->ToSchUnits() ) );
>  int align = attr.align ? *attr.align : ETEXT::BOTTOM_LEFT;
> @@ -1189,7 +1207,20 @@ void SCH_EAGLE_PLUGIN::loadInstance( wxXmlNode*
> aInstanceNode )
>
>  eagleToKicadAlignment( (EDA_TEXT*) field, align,
> reldegrees, mirror, spin,
>  absdegrees );
> -}
> +}
> +}
> +else if( attributeNode->GetName() == "variant" )
>

Re: [Kicad-developers] Reminder

2018-07-17 Thread Simon Richter

Hi,

> This will get 3 separate SHA (one for each branch).  Or would you prefer
> us to use git merge to keep the original SHA with an additional merge
> commit?  I can see arguments for each but wanted to check which is
> preferred.

To make merge commits work, they'd have to be based on the common base:

git checkout -b fix-xy `git merge-base master 5.0 5.1`
# hack hack hack
git commit
git checkout master
git merge fix-xy
git checkout 5.0
git merge fix-xy
git checkout 5.1
git merge fix-xy

This would work, but there's a lot of potential for errors here, and
looking at the commit history would show all bugfix branches sprout off
at the same place.

   Simon

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Reminder

2018-07-17 Thread Seth Hillbrand

Hi Wayne-

Just so I'm clear on how you'd like this to work:

We have a commit that affects 5.0.x, 5.1 and 6.  We could do
1) git checkout master
2) git commit (get  back)
3) git checkout 5.1
4) git cherry-pick 
5) compile/test
6) git checkout 5.0
7) git cherry-pick 
8) compile/test
9) git push

This will get 3 separate SHA (one for each branch).  Or would you prefer us
to use git merge to keep the original SHA with an additional merge commit?
I can see arguments for each but wanted to check which is preferred.

-Seth


Am Di., 17. Juli 2018 um 06:32 Uhr schrieb Wayne Stambaugh <
stambau...@gmail.com>:

> Just a quick reminder to the lead developers, if you push a bug fix into
> the development branch that effects the 5.0 and 5.1 branches, please
> don't forget to push the fix to the 5.0 and 5.1 branches.
>
> Thanks,
>
> Wayne
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Questions on 6.0 eeschema file format

2018-07-17 Thread Simon Richter

Hi,

On 07/16/2018 04:24 PM, Tomasz Wlostowski wrote:

> Why do we need any inheritance at all? My only guess is to make Kicad
> even more hackerish and difficult to understand.

It would allow getting rid of the really annoying redundancies in the
library:

 - all transistor symbols exist in six variants (BCE, BEC, CBE, CEB,
EBC, ECB) that only differ in pin numbers, but have the same symbol.
 - multi-unit components exist in single, double, quad, ... variants.

This means that during schematic entry, you need to specify some
properties of the component by selecting the appropriate symbol, but
other decisions might still be delayed until component selection.

The way I'd like it to be is to have a generic transistor symbol, which
you can use for schematic entry, and cvpcb would ask to refine the
selection, towards a discrete component (which would specify the pin
order), or towards a multi-unit part. We can easily offer a list of
choices here, because we know what inherits from "generic transistor".

This could also be used to collect component values, e.g. the "generic
resistor" would have "resistance", "tolerance" and "power rating" as
abstract properties, define their mapping to SPICE and filtering rules
for component selection (near match for resistance, larger for power
rating).

The workflow for a resistor would be:

1. In the schematic editor, place a generic resistor, "R".

2. Edit its value(s). The value dialog presents three fields,
"resistance" with unit "Ohms", "tolerance", and "power rating" with unit
"Watts", the latter being optional.

3. During component selection, cvpcb asks to select a resistor from the
library of known resistors with the same value, or define a new one.

4. Defining a new unit would create up to four derived components:
   - inherit, and define fixed values
   - inherit from that, and define a footprint
   - inherit from that, and define a vendor order code
   - inherit from that, and define a distributor order code.

This would happen in a wizard, and the last two steps would be optional.
When another generic resistor with the same values turns up, the newly
generated components would be offered for selection, which would allow
the user to specify everything including order codes with a single
selection.

When changing a resistor value, the selected resistor would be replaced
by a generic one again, deleting the footprint and order codes as these
would no longer be valid. Because all resistors inherit from the same
generic graphics, this replacement has no impact on connectivity.

   Simon

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 branch

2018-07-17 Thread Tomasz Wlostowski

On 16/07/18 17:54, Wayne Stambaugh wrote:
> I was really hoping just to fix the wxDC issues with GTK3 rather than
> implement GAL unless Tom implemented a wxDC GAL and that is all we
> expose for 5.1.  The primary goal here is to fix the GTK3 rendering
> issues so we can enable wxPython support again.  We need to limit our
> risk exposure for 5.1.
> 
Hi Wayne,

The sooner we drop wxDC, the better for Kicad. I wouldn't do it because
of the GTK3/Python issues (since it's a neverending Linux problem of
changing APIs and libraries), but for performance reasons - on OSX for
instance, eeschema is sometimes barely usable because of slow drawing.

I hope I'll be able to devote some time to cleaning up the eeschema-gal
code in the coming weeks. So far, the main canvas and the library editor
are implemented, with the symbol preview widgets & library browser
remaining.


> I'm assuming the printing is a v6 goal.

Orson made quite a lot of progress with Cairo printing. IIRC it can make
it to the 5.1.

Cheers,
Tom

> 
> On 7/16/2018 11:15 AM, Maciej Sumiński wrote:
>> Tom has already prepared a proof-of-concept eeschema with GAL rendering,
>> which still uses the legacy tools. I have some promising results
>> switching the printing system to Cairo GAL. Obviously we will face some
>> unexpected obstacles, but I have high hopes.
>>
>> Cheers,
>> Orson
>>
>> On 07/16/2018 03:40 PM, Wayne Stambaugh wrote:
>>> Yes, assuming we can get that to work without dragging in Phoenix.
>>>
>>> On 7/16/2018 9:27 AM, Jeff Young wrote:
 5.1 is also for the GTK3 fixes, right?

> On 16 Jul 2018, at 14:23, Wayne Stambaugh  wrote:
>
> On 7/16/2018 9:19 AM, Simon Richter wrote:
>> Hi,
>>
>> On 15.07.2018 13:39, Jeff Young wrote:
>>
>>> I renamed my 6.0 branch to 5.1, since most of what it contains goes 
>>> there.
>>
>> What is the difference between 5.1 and 6.0? What goes into which branch?
>>
>>   Simon
>>
>
> 5.1 is only for the UI refactoring Jeff is working on along with any bug
> fixes that get merged into the 5.0 branch.  Any new features such as the
> new schematic file formats or GALification of eeschema are v6 only.
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Reminder

2018-07-17 Thread Wayne Stambaugh

Just a quick reminder to the lead developers, if you push a bug fix into
the development branch that effects the 5.0 and 5.1 branches, please
don't forget to push the fix to the 5.0 and 5.1 branches.

Thanks,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 branch

2018-07-17 Thread Maciej Sumiński

On 07/16/2018 05:54 PM, Wayne Stambaugh wrote:
> I was really hoping just to fix the wxDC issues with GTK3 rather than
> implement GAL unless Tom implemented a wxDC GAL and that is all we
> expose for 5.1.  The primary goal here is to fix the GTK3 rendering
> issues so we can enable wxPython support again.  We need to limit our
> risk exposure for 5.1.

There is no new wxDC GAL backend implemented, which IMHO reduces the
risk as Cairo backend has been already tested a bit. Staying with two
rendering engines also reduces the amount of code to maintain.

I have already spent some time trying to fix GTK3 problems, both in
eeschema and in pcbnew. GTK3 fixes in eeschema resulted in a slight
performance drop, whereas for pcbnew I was unable to come up with a
solution.

> I'm assuming the printing is a v6 goal.

Broken legacy canvas in pcbnew means layout printing is also broken. A
simple workaround is to remove printing completely and request users to
use PDF plotting.

Cheers,
Orson

> On 7/16/2018 11:15 AM, Maciej Sumiński wrote:
>> Tom has already prepared a proof-of-concept eeschema with GAL rendering,
>> which still uses the legacy tools. I have some promising results
>> switching the printing system to Cairo GAL. Obviously we will face some
>> unexpected obstacles, but I have high hopes.
>>
>> Cheers,
>> Orson
>>
>> On 07/16/2018 03:40 PM, Wayne Stambaugh wrote:
>>> Yes, assuming we can get that to work without dragging in Phoenix.
>>>
>>> On 7/16/2018 9:27 AM, Jeff Young wrote:
 5.1 is also for the GTK3 fixes, right?

> On 16 Jul 2018, at 14:23, Wayne Stambaugh  wrote:
>
> On 7/16/2018 9:19 AM, Simon Richter wrote:
>> Hi,
>>
>> On 15.07.2018 13:39, Jeff Young wrote:
>>
>>> I renamed my 6.0 branch to 5.1, since most of what it contains goes 
>>> there.
>>
>> What is the difference between 5.1 and 6.0? What goes into which branch?
>>
>>   Simon
>>
>
> 5.1 is only for the UI refactoring Jeff is working on along with any bug
> fixes that get merged into the 5.0 branch.  Any new features such as the
> new schematic file formats or GALification of eeschema are v6 only.
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] How sophisticated is the bug closure script?

2018-07-17 Thread Maciej Sumiński

On 07/15/2018 11:20 PM, Jeff Young wrote:
> Hi Orson,
> 
> I was asking about the Fix Committed -> Fix Released script (assuming it is a 
> script), rather than the *** -> Fix Committed script.

Frankly, I could not recall how we have updated the bug statuses after
the previous release. This time we used a script, and it should not be
very hard to modify it to filter bugs targeted at a particular release.
It will require some discipline in setting appropriate targets in bug
reports though.

> Although your answer does bring up the question, do we want to setup the 
> Janitor script to handle the 5.1 branch as well, or just do them by hand?

I guess 5.1 will become the master branch soon, so KiCad Janitor will
cope with updating bug statuses when it happens. As far as I understand
we will only have 5.0 and master (aka 5.1) branches in the near future.

Cheers,
Orson

> Cheers,
> Jeff.
> 
>> On 15 Jul 2018, at 22:11, Maciej Suminski  wrote:
>>
>> Hi Jeff,
>>
>> KiCad Janitor follows only the master branch and does not take tags or
>> target milestones into account. The rules are very simple: whenever
>> there is a "fixes" line, change the correlated bug status to "Fixed".
>> Have a look at the script [1], I will be happy to improve it.
>>
>> Cheers,
>> Orson
>>
>> 1. https://git.launchpad.net/kicad-git-hook/tree/hook.py
>>
>> On 07/15/2018 05:43 PM, Jeff Young wrote:
>>> In particular, can I go ahead and make commits that have “fixes” lines (as 
>>> long as the bugs are tagged 5.1), or do I need to wait till be auto-close 
>>> the 5.0 bugs?
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 






signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-17 Thread mdoesbur

From: Mark van Doesburg 

Here is a patch that copies all attributes from an original eagle
schematic. This is necessary for me to keep the BOM the same.

Since kicad does not yet support variants, it creates additional fields
for values that differ for variants. It prefixes them with "VARIANT_"


---
 common/eagle_parser.cpp   | 31 
 eeschema/sch_eagle_plugin.cpp | 39 +++
 include/eagle_parser.h|  2 ++
 3 files changed, 68 insertions(+), 4 deletions(-)

diff --git a/common/eagle_parser.cpp b/common/eagle_parser.cpp
index 60aa52612..6d8aa3fe5 100644
--- a/common/eagle_parser.cpp
+++ b/common/eagle_parser.cpp
@@ -884,8 +884,39 @@ EPART::EPART( wxXmlNode* aPart )
 library = parseRequiredAttribute( aPart, "library" );
 deviceset = parseRequiredAttribute( aPart, "deviceset" );
 device = parseRequiredAttribute( aPart, "device" );
+
 technology = parseOptionalAttribute( aPart, "technology" );
 value = parseOptionalAttribute( aPart, "value" );
+
+for( auto child = aPart->GetChildren(  ); child; child = child->GetNext(  
) )
+{
+   if( child->GetName(  ) == "attribute" )
+   {
+   std::string aname, avalue;
+   for( auto x = child->GetAttributes(  ); x; x = x->GetNext(  ) )
+   {
+   if( x->GetName(  ) == "name" )
+   aname = x->GetValue(  );
+   else if( x->GetName(  ) == "value" )
+   avalue = x->GetValue(  );
+   }
+   if( aname.size(  ) && avalue.size(  ) )
+   attribute[aname] = avalue;
+   }
+   else if( child->GetName(  ) == "variant" )
+   {
+   std::string aname, avalue;
+   for( auto x = child->GetAttributes(  ); x; x = x->GetNext(  ) )
+   {
+   if( x->GetName(  ) == "name" )
+   aname = x->GetValue(  );
+   else if( x->GetName(  ) == "value" )
+   avalue = x->GetValue(  );
+   }
+   if( aname.size(  ) && avalue.size(  ) )
+   variant[aname] = avalue;
+   }
+}
 }
 
 
diff --git a/eeschema/sch_eagle_plugin.cpp b/eeschema/sch_eagle_plugin.cpp
index 0b36e1f25..c7a999c5b 100644
--- a/eeschema/sch_eagle_plugin.cpp
+++ b/eeschema/sch_eagle_plugin.cpp
@@ -1142,6 +1142,22 @@ void SCH_EAGLE_PLUGIN::loadInstance( wxXmlNode* 
aInstanceNode )
 component->GetField( REFERENCE )->SetVisible( part->GetField( REFERENCE 
)->IsVisible() );
 component->GetField( VALUE )->SetVisible( part->GetField( VALUE 
)->IsVisible() );
 
+for( auto a:epart->attribute )
+{
+   auto field = component->AddField( SCH_FIELD( *component->GetField( 
VALUE ) ) );
+   field->SetName( a.first );
+   field->SetText( a.second );
+   field->SetVisible( false );
+}
+
+for( auto a:epart->variant )
+{
+   auto field = component->AddField( SCH_FIELD( *component->GetField( 
VALUE ) ) );
+   field->SetName( "VARIANT_" + a.first );
+   field->SetText( a.second );
+   field->SetVisible( false );
+}
+
 bool valueAttributeFound = false;
 bool nameAttributeFound  = false;
 
@@ -1157,18 +1173,20 @@ void SCH_EAGLE_PLUGIN::loadInstance( wxXmlNode* 
aInstanceNode )
 
 SCH_FIELD* field;
 
-if( attr.name.Lower() == "name" || attr.name.Lower() == "value" )
+if( attr.name.Lower() == "name" || attr.name.Lower() == "value" || 
(field = component->FindField( attr.name )))
 {
 if( attr.name.Lower() == "name" )
 {
 field = component->GetField( REFERENCE );
 nameAttributeFound = true;
 }
-else
+else if( attr.name.Lower() == "value" )
 {
 field = component->GetField( VALUE );
 valueAttributeFound = true;
-}
+} else {
+field->SetVisible( false );
+   }
 
 field->SetPosition( wxPoint( attr.x->ToSchUnits(), 
-attr.y->ToSchUnits() ) );
 int align = attr.align ? *attr.align : ETEXT::BOTTOM_LEFT;
@@ -1189,7 +1207,20 @@ void SCH_EAGLE_PLUGIN::loadInstance( wxXmlNode* 
aInstanceNode )
 
 eagleToKicadAlignment( (EDA_TEXT*) field, align, reldegrees, 
mirror, spin,
 absdegrees );
-}
+} 
+} 
+else if( attributeNode->GetName() == "variant" ) 
+{
+   wxString variant, value;
+
+   if( attributeNode->GetAttribute( "name",  )
+   && attributeNode->GetAttribute( "value",  ) )
+   {
+   auto field = component->AddField( SCH_FIELD( 
*component->GetField( VALUE ) ) );
+   field->SetName( "VARIANT_" + variant );
+   field->SetText( value );
+   field->SetVisible( false );
+   }
 }

Re: [Kicad-developers] 5.1 UI feedback

Re: [Kicad-developers] 5.1 UI feedback

Re: [Kicad-developers] 5.1 UI feedback

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

Re: [Kicad-developers] 5.1 UI feedback

Re: [Kicad-developers] 5.1 UI feedback

Re: [Kicad-developers] 5.1 UI feedback

Re: [Kicad-developers] 5.1 UI feedback

[Kicad-developers] Janitor commits missing

Re: [Kicad-developers] 5.1 UI feedback

Re: [Kicad-developers] Reminder

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

Re: [Kicad-developers] Reminder

Re: [Kicad-developers] Reminder

Re: [Kicad-developers] Questions on 6.0 eeschema file format

Re: [Kicad-developers] 5.1 branch

[Kicad-developers] Reminder

Re: [Kicad-developers] 5.1 branch

[Kicad-developers] How sophisticated is the bug closure script?

[Kicad-developers] [PATCH] Import attributes and variants from eagle.

20 matches

Site Navigation

Mail list logo

Footer information