date:20180721

Re: [Kicad-developers] Could someone run a test on GTK for me?

2018-07-21 Thread Jeff Young

Well, that 0 certainly isn’t good.  The only thing I can think of is that 
setting the column widths is failing on GTK because the parent isn’t yet sized.

I’ve put some debug code in.  If anyone gets a chance to run it (with a 
breakpoint only in ZONE_SETTINGS::SetupLayersList()) and report the before and 
after column sizes that would be great.

Cheers,
Jeff.


> On 21 Jul 2018, at 21:51, Seth Hillbrand  wrote:
> 
> Hi Jeff-
> 
> minWidth = 30
> layersWidth = 0
> 
> Breakpoints set on the last line of each routine.
> 
> Best-
> Seth
> 
> Am Sa., 21. Juli 2018 um 09:56 Uhr schrieb Jeff Young  >:
> Set two breakpoints:
> one near the end of ZONE_SETTINGS::SetupLayersList()
> and one near the end of DIALOG_COPPER_ZONE::DIALOG_COPPER_ZONE()
> Run PcbNew and edit the properties of a zone.
> 
> When the breakpoints hit, I need to know the value of minWidth from 
> ZONE_SETTINGS::SetupLayersList() and layersWidth from 
> DIALOG_COPPER_ZONE::DIALOG_COPPER_ZONE().
> 
> (I’m not sure whether the calculations are failing, or if the layout is 
> failing with a correctly set minWidths.)
> 
> Thanks,
> Jeff.
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Could someone run a test on GTK for me?

2018-07-21 Thread Seth Hillbrand

Hi Jeff-

minWidth = 30
layersWidth = 0

Breakpoints set on the last line of each routine.

Best-
Seth

Am Sa., 21. Juli 2018 um 09:56 Uhr schrieb Jeff Young :

> Set two breakpoints:
>
>- one near the end of ZONE_SETTINGS::SetupLayersList()
>- and one near the end of DIALOG_COPPER_ZONE::DIALOG_COPPER_ZONE()
>
> Run PcbNew and edit the properties of a zone.
>
> When the breakpoints hit, I need to know the value of minWidth from
> ZONE_SETTINGS::SetupLayersList() and layersWidth from
> DIALOG_COPPER_ZONE::DIALOG_COPPER_ZONE().
>
> (I’m not sure whether the calculations are failing, or if the layout is
> failing with a correctly set minWidths.)
>
> Thanks,
> Jeff.
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] SHAPE_LINE_CHAIN in swig?

2018-07-21 Thread Andrew Lutsenko

Hello Kicad team,

I'm writing a pcbnew action plugin that needs to read footprint pad
coordinates and shape.
I had no trouble figuring out all shapes except for custom one. It is
represented by SHAPE_POLY_SET which has a corresponding python type but to
get actual vertex coordinates you have to either call one of Iterate()
variants or get polygon outlines with Outline(). They both return objects
(ITERATOR and SHAPE_LINE_CHAIN) that are pointers and have no useful
attributes. As far as I understand they just don't have corresponding swig
bindings so they are not exposed properly in python.

Am I missing some obvious way to read custom pad polygon data in python?

If not, what would it take to add that?

I don't understand much about how swig configuration works but cursory
glance at Kicad source suggests that there needs to be an import for
shape_line_chain.h in common/swig/kicad.i, similar to shape_poly_set import.

If you are curious about what the plugin does, here are some of it's
results, generated from Kicad demos:
http://plugindemo.bitballoon.com/1/
http://plugindemo.bitballoon.com/2/
http://plugindemo.bitballoon.com/3/

#2 above has a solder bridge with custom shape pads that are not rendered.
Links are short lived.

Regards,
Andrew
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Could someone run a test on GTK for me?

2018-07-21 Thread Jeff Young

Set two breakpoints:
one near the end of ZONE_SETTINGS::SetupLayersList()
and one near the end of DIALOG_COPPER_ZONE::DIALOG_COPPER_ZONE()
Run PcbNew and edit the properties of a zone.

When the breakpoints hit, I need to know the value of minWidth from 
ZONE_SETTINGS::SetupLayersList() and layersWidth from 
DIALOG_COPPER_ZONE::DIALOG_COPPER_ZONE().

(I’m not sure whether the calculations are failing, or if the layout is failing 
with a correctly set minWidths.)

Thanks,
Jeff.___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] test regression on macos package

2018-07-21 Thread Wayne Stambaugh

Adam,

Don't sweat it.  These things always seem to happen at release time. 
Better to fix it now than to find out after it's already released.  Keep 
me posted.

Thanks,

Wayne

On 07/21/2018 10:09 AM, Adam Wolf wrote:
I must add that I have had literal nightmares about holding up the V5 
release.  This is a little bit like actually going to school naked or 
having all of your teeth fall out.

On Sat, Jul 21, 2018, 8:52 AM Adam Wolf > wrote:

The tests that are not passing are some Python ones.  They have to do
with how Python is embedded in the package.

This one passes:
Open up KiCad.app, and open up the Python scripting console. Type
import pcbnew and press enter. It shouldn't show an error. Verify that
the build date of Pytohn is the same as the build date of the package.

But these three do not.

==

Open up pcbnew.app, and open up the Python scripting console. Type
import pcbnew and press enter. It shouldn't show an error. Verify that
the build date of Python is the same as the build date of the package.

Open up the terminal, and run
kicad.app/Contents/Frameworks/Python.framework/Versions/Current/bin/python.
It shouldn't show an error. Verify that the build date of Python is
the same as the build date of the package.

Open up the terminal, and run cd
kicad.app/Contents/Frameworks/python/site-packages/;
../../Python.framework/Versions/Current/bin/python -m pcbnew. It
shouldn't show an error.

==

These tests have worked for months!  Embedding python in a more
correct way is the whole basis of why I redid the packaging for V5
*sigh* :)  I checked them when I built 5.0.0-rc3, and I double checked
them now.  5.0.0-rc3 worked fine.

I am currently suspecting changes in the build scripts since July
5th--even though they all look innocuous.  I am now doing some
differential builds to see what's causing the problem.

Adam

On Sat, Jul 21, 2018 at 5:07 AM Maciej Suminski
mailto:maciej.sumin...@cern.ch>> wrote:
 >
 > Hi Adam,
 >
 > What is the regression? Perhaps we can help debugging.
 >
 > Cheers,
 > Orson
 >
 > On 07/21/2018 08:23 AM, Adam Wolf wrote:
 > > Hi folks!
 > >
 > > While trying to create the 5.0.0 package for macos tonight, I
ran into
 > > a test regression that I do not see on RC3. I am debugging, but
it is
 > > very late in my local timezone and I must sleep.
 > >
 > > I have an obligation in the morning tomorrow but I will continue
 > > debugging this. I do not expect this to take more than a day.
 > >
 > > (Kinda glad I have a test doc, now...  would have been a real shame
 > > had I released a version with a Python issue after all my hard work
 > > getting it working!)
 > >
 > > Adam
 > >
 > > ___
 > > Mailing list: https://launchpad.net/~kicad-developers

 > > Post to     : kicad-developers@lists.launchpad.net

 > > Unsubscribe : https://launchpad.net/~kicad-developers

 > > More help   : https://help.launchpad.net/ListHelp
 > >
 >
 > ___
 > Mailing list: https://launchpad.net/~kicad-developers

 > Post to     : kicad-developers@lists.launchpad.net

 > Unsubscribe : https://launchpad.net/~kicad-developers

 > More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Fix CMakeLists.txt

2018-07-21 Thread Aimylios


Hi!

While trying to build KiCad for Fedora 28 I discovered some minor 
problems in the main CMakeLists.txt file. Patches attached.


Best regards,
Marcus
>From cbb85acdd95a6b4f91a8369f405a5ff841a424cf Mon Sep 17 00:00:00 2001
From: Marcus A 
Date: Sat, 21 Jul 2018 08:10:24 +0200
Subject: [PATCH 1/3] Update description of build options

Commit 93683d0021c4f592f929e9785abeda9d169ba03b changed the default build
options but did not update their description.
---
 CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f2ea761f9..54f235a72 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -60,7 +60,7 @@ option( USE_WX_OVERLAY
 "Use wxOverlay: Always ON for MAC (default OFF).  Warning, this is experimental" )
 
 option( KICAD_SCRIPTING
-"Build the Python scripting support inside KiCad binaries (default OFF)."
+"Build the Python scripting support inside KiCad binaries (default ON)."
 ON )
 
 option( KICAD_SCRIPTING_MODULES
@@ -68,7 +68,7 @@ option( KICAD_SCRIPTING_MODULES
 ON )
 
 option( KICAD_SCRIPTING_WXPYTHON
-"Build wxPython implementation for wx interface building in Python and py.shell (default OFF)."
+"Build wxPython implementation for wx interface building in Python and py.shell (default ON)."
 ON )
 
 option( KICAD_SCRIPTING_ACTION_MENU
-- 
2.17.1

>From 14a749c7a2e2832416a5a5008b992c3f6568393a Mon Sep 17 00:00:00 2001
From: Marcus A 
Date: Sat, 21 Jul 2018 10:53:07 +0200
Subject: [PATCH 2/3] Fix some typos in CMakeLists.txt

---
 CMakeLists.txt | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 54f235a72..b8cee3cdb 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -72,7 +72,7 @@ option( KICAD_SCRIPTING_WXPYTHON
 ON )
 
 option( KICAD_SCRIPTING_ACTION_MENU
-"Build a tools menu with registred python plugins: actions plugins (default OFF)."
+"Build a tools menu with registered python plugins: actions plugins (default OFF)."
 )
 
 option( KICAD_USE_OCE
@@ -84,14 +84,14 @@ option( KICAD_USE_OCC
 OFF )
 
 option( KICAD_INSTALL_DEMOS
-"Install kicad demos and examples (default ON)"
+"Install KiCad demos and examples (default ON)"
 ON )
 
 # when option KICAD_SCRIPTING OR KICAD_SCRIPTING_MODULES is enabled:
 # PYTHON_EXECUTABLE can be defined when invoking cmake
 # ( use -DPYTHON_EXECUTABLE=/python.exe or python2 )
 # when not defined by user, the default is python.exe under Windows and python2 for others
-# python binary file should be is exec path.
+# python binary file should be in exec path.
 
 # KICAD_SCRIPTING_MODULES requires KICAD_SCRIPTING enable it here if KICAD_SCRIPTING_MODULES is ON
 if ( KICAD_SCRIPTING_MODULES AND NOT KICAD_SCRIPTING )
@@ -107,7 +107,7 @@ endif()
 
 option( BUILD_GITHUB_PLUGIN "Build the GITHUB_PLUGIN for pcbnew." ON )
 
-option( KICAD_SPICE "Build Kicad with internal Spice simulator." ON )
+option( KICAD_SPICE "Build KiCad with internal Spice simulator." ON )
 
 # Global setting: exports are explicit
 set( CMAKE_CXX_VISIBILITY_PRESET "hidden" )
@@ -163,7 +163,7 @@ if( NOT DEFAULT_INSTALL_PATH )
  "Location of KiCad data files." )
 endif()
 
-message( STATUS "Kicad install dir: <${DEFAULT_INSTALL_PATH}>" )
+message( STATUS "KiCad install dir: <${DEFAULT_INSTALL_PATH}>" )
 
 # Generate build system specific header file.
 include( PerformFeatureChecks )
@@ -204,7 +204,7 @@ endif()
 # Unfortunately, the swig autogenerated files have a lot of shadowed variables
 # and -Wno-shadow does not exist.
 # Adding -Wshadow can be made only for .cpp files
-#and will be added later in CMakeLists.txt
+# and will be added later in CMakeLists.txt
 if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" )
 include(CheckCXXCompilerFlag)
 
@@ -281,7 +281,7 @@ if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" )
 set( CMAKE_EXE_LINKER_FLAGS_RELEASE "-s" )
 
 # _UNICODE definition seems needed under mingw/gcc 4.8
-# (Kicad uses unicode, and on Windows, wxWidgets >= 2.9.4 is mandatory
+# (KiCad uses unicode, and on Windows, wxWidgets >= 2.9.4 is mandatory
 # and uses unicode)
 if( GCC_VERSION VERSION_EQUAL 4.8.0 OR GCC_VERSION VERSION_GREATER 4.8.0 )
 add_definitions(-D_UNICODE)
-- 
2.17.1

>From 74db48d6c46f6469bf8d52f9bd77c7dfafe13d44 Mon Sep 17 00:00:00 2001
From: Marcus A 
Date: Sat, 21 Jul 2018 11:12:46 +0200
Subject: [PATCH 3/3] Fix detection of wxWidgets toolkit

wxWidgets_CONFIG_OPTIONS can be utilised to explicitly select GTK2 or GTK3. It
must be evaluated when querying the toolkit to avoid a mismatch between the
version actually used and the version KiCad assumes to be used.
---
 CMakeLists.txt | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index b8cee3cdb..a41740b49 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -555,7

Re: [Kicad-developers] test regression on macos package

2018-07-21 Thread Adam Wolf

I must add that I have had literal nightmares about holding up the V5
release.  This is a little bit like actually going to school naked or
having all of your teeth fall out.

On Sat, Jul 21, 2018, 8:52 AM Adam Wolf 
wrote:

> The tests that are not passing are some Python ones.  They have to do
> with how Python is embedded in the package.
>
> This one passes:
> Open up KiCad.app, and open up the Python scripting console. Type
> import pcbnew and press enter. It shouldn't show an error. Verify that
> the build date of Pytohn is the same as the build date of the package.
>
> But these three do not.
>
> ==
>
> Open up pcbnew.app, and open up the Python scripting console. Type
> import pcbnew and press enter. It shouldn't show an error. Verify that
> the build date of Python is the same as the build date of the package.
>
> Open up the terminal, and run
> kicad.app/Contents/Frameworks/Python.framework/Versions/Current/bin/python.
> It shouldn't show an error. Verify that the build date of Python is
> the same as the build date of the package.
>
> Open up the terminal, and run cd
> kicad.app/Contents/Frameworks/python/site-packages/;
> ../../Python.framework/Versions/Current/bin/python -m pcbnew. It
> shouldn't show an error.
>
> ==
>
> These tests have worked for months!  Embedding python in a more
> correct way is the whole basis of why I redid the packaging for V5
> *sigh* :)  I checked them when I built 5.0.0-rc3, and I double checked
> them now.  5.0.0-rc3 worked fine.
>
> I am currently suspecting changes in the build scripts since July
> 5th--even though they all look innocuous.  I am now doing some
> differential builds to see what's causing the problem.
>
> Adam
>
>
>
> On Sat, Jul 21, 2018 at 5:07 AM Maciej Suminski 
> wrote:
> >
> > Hi Adam,
> >
> > What is the regression? Perhaps we can help debugging.
> >
> > Cheers,
> > Orson
> >
> > On 07/21/2018 08:23 AM, Adam Wolf wrote:
> > > Hi folks!
> > >
> > > While trying to create the 5.0.0 package for macos tonight, I ran into
> > > a test regression that I do not see on RC3. I am debugging, but it is
> > > very late in my local timezone and I must sleep.
> > >
> > > I have an obligation in the morning tomorrow but I will continue
> > > debugging this. I do not expect this to take more than a day.
> > >
> > > (Kinda glad I have a test doc, now...  would have been a real shame
> > > had I released a version with a Python issue after all my hard work
> > > getting it working!)
> > >
> > > Adam
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > > Post to : kicad-developers@lists.launchpad.net
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > More help   : https://help.launchpad.net/ListHelp
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] test regression on macos package

2018-07-21 Thread Adam Wolf

The tests that are not passing are some Python ones.  They have to do
with how Python is embedded in the package.

This one passes:
Open up KiCad.app, and open up the Python scripting console. Type
import pcbnew and press enter. It shouldn't show an error. Verify that
the build date of Pytohn is the same as the build date of the package.

But these three do not.

==

Open up pcbnew.app, and open up the Python scripting console. Type
import pcbnew and press enter. It shouldn't show an error. Verify that
the build date of Python is the same as the build date of the package.

Open up the terminal, and run
kicad.app/Contents/Frameworks/Python.framework/Versions/Current/bin/python.
It shouldn't show an error. Verify that the build date of Python is
the same as the build date of the package.

Open up the terminal, and run cd
kicad.app/Contents/Frameworks/python/site-packages/;
../../Python.framework/Versions/Current/bin/python -m pcbnew. It
shouldn't show an error.

==

These tests have worked for months!  Embedding python in a more
correct way is the whole basis of why I redid the packaging for V5
*sigh* :)  I checked them when I built 5.0.0-rc3, and I double checked
them now.  5.0.0-rc3 worked fine.

I am currently suspecting changes in the build scripts since July
5th--even though they all look innocuous.  I am now doing some
differential builds to see what's causing the problem.

Adam

On Sat, Jul 21, 2018 at 5:07 AM Maciej Suminski  wrote:
>
> Hi Adam,
>
> What is the regression? Perhaps we can help debugging.
>
> Cheers,
> Orson
>
> On 07/21/2018 08:23 AM, Adam Wolf wrote:
> > Hi folks!
> >
> > While trying to create the 5.0.0 package for macos tonight, I ran into
> > a test regression that I do not see on RC3. I am debugging, but it is
> > very late in my local timezone and I must sleep.
> >
> > I have an obligation in the morning tomorrow but I will continue
> > debugging this. I do not expect this to take more than a day.
> >
> > (Kinda glad I have a test doc, now...  would have been a real shame
> > had I released a version with a Python issue after all my hard work
> > getting it working!)
> >
> > Adam
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] test regression on macos package

2018-07-21 Thread Maciej Suminski

Hi Adam,

What is the regression? Perhaps we can help debugging.

Cheers,
Orson

On 07/21/2018 08:23 AM, Adam Wolf wrote:
> Hi folks!
> 
> While trying to create the 5.0.0 package for macos tonight, I ran into
> a test regression that I do not see on RC3. I am debugging, but it is
> very late in my local timezone and I must sleep.
> 
> I have an obligation in the morning tomorrow but I will continue
> debugging this. I do not expect this to take more than a day.
> 
> (Kinda glad I have a test doc, now...  would have been a real shame
> had I released a version with a Python issue after all my hard work
> getting it working!)
> 
> Adam
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Could someone run a test on GTK for me?

Re: [Kicad-developers] Could someone run a test on GTK for me?

[Kicad-developers] SHAPE_LINE_CHAIN in swig?

[Kicad-developers] Could someone run a test on GTK for me?

Re: [Kicad-developers] test regression on macos package

[Kicad-developers] Fix CMakeLists.txt

Re: [Kicad-developers] test regression on macos package

Re: [Kicad-developers] test regression on macos package

Re: [Kicad-developers] test regression on macos package

9 matches

Site Navigation

Mail list logo

Footer information