Re: [Kicad-developers] GAL canvas strategy - testers needed!

[Dan Green]

> -Click+dragging on a symbol starts a selection rectangle instead of moving 
> the symbol

Scratch this one. It's the same behavoir as in the current nightly. 


> On Sep 7, 2018, at 5:36 PM, dann  wrote:
> 
> Nice!
> 
> Here’s a few things I found on OSX 10.13.6, Retina iMac:
> 
> -Click+dragging on a symbol starts a selection rectangle instead of moving 
> the symbol
> 
> -With the schematic and PCB windows open at the same time, clicking a 
> footprint on the PCB makes the schematic jump and zoom, but it doesn’t always 
> put the selected component in view. Often the entire schematic is zoomed out 
> and/or panned off-screen. It seems to be inconsistent, that is, it doesn’t 
> always pan and zoom to the same place when clicking on the same component.
> 
> -Likewise, I have to double-click a symbol in eeschema to have it highlight 
> in the PCB window. This opens up the Symbol Properties dialog box as well. 
> Single clicking seems to have no effect.
> 
> -When changing the anti-aliasing mode, immediately after closing the 
> Preferences window, the schematic pane goes solid blue for a moment. The 
> toolbars stay normal, just the center pane turns blue.
> 
> -Toggling the “Use touchpad to Pan” setting has no effect until Eeschema is 
> closed and re-opened.
> 
> -Junctions are drawn underneath components. Not sure if this is good or bad, 
> just different from the non-GAL version.
> 
> -I get this Debug Alert when I use the wire tool. It happens whenever I end a 
> wire segment by double-clicking:
> 
> /Users/design/src/kicad-mac-builder/build/kicad/src/kicad/common/dlist.cpp(104):
>  assert "item->GetList() == &aList" failed in append().
> Call stack:
> [00] SCH_SCREEN::Append(DLIST&) sch_screen.h:16
> [01] SCH_BASE_FRAME::AddToScreen(DLIST&)sch_base_frame.cpp:57
> [02] SCH_EDIT_FRAME::EndSegment() bus-wire-junction.cpp:32
> [03] SCH_EDIT_FRAME::OnLeftDClick(wxDC*, wxPoint const&)  
> onleftclick.cpp:45
> [04] SCH_DRAW_PANEL::OnMouseEvent(wxMouseEvent&)  sch_draw_panel.cpp:30
> [05] wxEvtHandler::SearchDynamicEventTable(wxEvent&) 
> [06] wxEvtHandler::ProcessEventLocally(wxEvent&) 
> [07] wxEvtHandler::ProcessEvent(wxEvent&)
> [08] wxEvtHandler::ProcessPendingEvents()
> [09] wxAppConsoleBase::ProcessPendingEvents() 
> [10] wxCFEventLoop::OSXCommonModeObserverCallBack(__CFRunLoopObserver*, int, 
> void*) 
> [11] __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ 
> [12] __CFRunLoopDoObservers  
> [13] __CFRunLoopRun  
> [14] CFRunLoopRunSpecific
> [15] RunCurrentEventLoopInMode   
> [16] ReceiveNextEventCommon  
> [17] _BlockUntilNextEventMatchingListInModeWithFilter 
> [18] _DPSNextEvent   
> [19] -[NSApplication(NSEvent) 
> _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 
> [20] -[NSApplication run]
> Do you want to stop the program?
> You can also choose [Cancel] to suppress further warnings.
> 
> Hope that helps! Really happy to see this come along
> 
> Cheers,
> Dan
> 
> 
>> On Sep 6, 2018, at 8:57 AM, Tomasz Wlostowski  
>> wrote:
>> 
>> On 06/09/18 17:37, Jeff Young wrote:
>>> Hi Tom,
>>> 
>>> I have committed the completion of the block rotate and mirror fixes 
>>> (including for LibEdit).
>> 
>> Hi Jeff,
>> 
>> Thanks, I played with eeschema for a short while and I really appreciate
>> all the work you have done!
>> 
>> Dear devs (non-devs too ;-) - whoever is interested in testing this
>> branch, please compile this and send the feedback here:
>> 
>> https://git.launchpad.net/~jeyjey/kicad/log/?h=tom-eeschema-gal-aug27
>> 
>> Cheers,
>> Tom
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL canvas strategy - testers needed!

[dann]

Nice!

Here’s a few things I found on OSX 10.13.6, Retina iMac:

-Click+dragging on a symbol starts a selection rectangle instead of moving the 
symbol

-With the schematic and PCB windows open at the same time, clicking a footprint 
on the PCB makes the schematic jump and zoom, but it doesn’t always put the 
selected component in view. Often the entire schematic is zoomed out and/or 
panned off-screen. It seems to be inconsistent, that is, it doesn’t always pan 
and zoom to the same place when clicking on the same component.

-Likewise, I have to double-click a symbol in eeschema to have it highlight in 
the PCB window. This opens up the Symbol Properties dialog box as well. Single 
clicking seems to have no effect.

-When changing the anti-aliasing mode, immediately after closing the 
Preferences window, the schematic pane goes solid blue for a moment. The 
toolbars stay normal, just the center pane turns blue.

-Toggling the “Use touchpad to Pan” setting has no effect until Eeschema is 
closed and re-opened.

-Junctions are drawn underneath components. Not sure if this is good or bad, 
just different from the non-GAL version.

-I get this Debug Alert when I use the wire tool. It happens whenever I end a 
wire segment by double-clicking:

/Users/design/src/kicad-mac-builder/build/kicad/src/kicad/common/dlist.cpp(104):
 assert "item->GetList() == &aList" failed in append().
Call stack:
[00] SCH_SCREEN::Append(DLIST&)   sch_screen.h:16
[01] SCH_BASE_FRAME::AddToScreen(DLIST&)  sch_base_frame.cpp:57
[02] SCH_EDIT_FRAME::EndSegment()   bus-wire-junction.cpp:32
[03] SCH_EDIT_FRAME::OnLeftDClick(wxDC*, wxPoint const&)
onleftclick.cpp:45
[04] SCH_DRAW_PANEL::OnMouseEvent(wxMouseEvent&)sch_draw_panel.cpp:30
[05] wxEvtHandler::SearchDynamicEventTable(wxEvent&) 
[06] wxEvtHandler::ProcessEventLocally(wxEvent&) 
[07] wxEvtHandler::ProcessEvent(wxEvent&)
[08] wxEvtHandler::ProcessPendingEvents()
[09] wxAppConsoleBase::ProcessPendingEvents() 
[10] wxCFEventLoop::OSXCommonModeObserverCallBack(__CFRunLoopObserver*, int, 
void*) 
[11] __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ 
[12] __CFRunLoopDoObservers  
[13] __CFRunLoopRun  
[14] CFRunLoopRunSpecific
[15] RunCurrentEventLoopInMode   
[16] ReceiveNextEventCommon  
[17] _BlockUntilNextEventMatchingListInModeWithFilter 
[18] _DPSNextEvent   
[19] -[NSApplication(NSEvent) 
_nextEventMatchingEventMask:untilDate:inMode:dequeue:] 
[20] -[NSApplication run]
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.

Hope that helps! Really happy to see this come along

Cheers,
Dan


> On Sep 6, 2018, at 8:57 AM, Tomasz Wlostowski  
> wrote:
> 
> On 06/09/18 17:37, Jeff Young wrote:
>> Hi Tom,
>> 
>> I have committed the completion of the block rotate and mirror fixes 
>> (including for LibEdit).
> 
> Hi Jeff,
> 
> Thanks, I played with eeschema for a short while and I really appreciate
> all the work you have done!
> 
> Dear devs (non-devs too ;-) - whoever is interested in testing this
> branch, please compile this and send the feedback here:
> 
> https://git.launchpad.net/~jeyjey/kicad/log/?h=tom-eeschema-gal-aug27
> 
> Cheers,
> Tom
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL canvas strategy - testers needed!

[Jeff Young]

I pushed a few more bug fixes, an implementation of line styles (dashed, 
dotted, etc.) and a fix for the dragging-object (‘G’ hotkey) bug.

Cheers,
Jeff.


> On 7 Sep 2018, at 16:20, Wayne Stambaugh  wrote:
> 
> Some feedback from what I've seen so far which can be observed in the
> attached screen capture.
> 
> The wire line thickness changes when zooming which makes for a rather
> interesting visual effect.
> 
> When dragging an object ('G' hotkey), the object is displaced off the
> display.
> 
> The scrollbars do not appear to work at all.
> 
> This was built with wxWidgets using gtk2.  I also tested a build with
> gtk3 and didn't see much of a difference.  I am using Debian testing
> with the nvidia graphics drivers.  I will continue testing and keep you
> posted if I find any other issues.
> 
> Cheers,
> 
> Wayne
> 
> On 09/06/2018 12:18 PM, jp charras wrote:
>> Le 06/09/2018 à 17:57, Tomasz Wlostowski a écrit :
>>> On 06/09/18 17:37, Jeff Young wrote:
 Hi Tom,
 
 I have committed the completion of the block rotate and mirror fixes 
 (including for LibEdit).
>>> 
>>> Hi Jeff,
>>> 
>>> Thanks, I played with eeschema for a short while and I really appreciate
>>> all the work you have done!
>>> 
>>> Dear devs (non-devs too ;-) - whoever is interested in testing this
>>> branch, please compile this and send the feedback here:
>>> 
>>> https://git.launchpad.net/~jeyjey/kicad/log/?h=tom-eeschema-gal-aug27
>>> 
>>> Cheers,
>>> Tom
>> 
>> Hi Jeff,
>> 
>> Attached, a small patch that fixes a few minor compil warnings, and
>> re-enable calls to draw symbols items in wxDC canvas for printing
>> purpose, making printing working again.
>> 
>> Thanks to you, Jeff and Tomasz, for all your hard work on GAL for Eeschema.
>> 
>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
>> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL design question

[Jeff Young]

Hi Jon,

That certainly looks like it.  I’ll set some breakpoints once my tree builds 
again and see how I get on….

Thanks,
Jeff.


> On 7 Sep 2018, at 16:28, Jon Evans  wrote:
> 
> VIEW::Update() -> VIEW::invalidateItem() -> VIEW::updateBbox() ?  Is that 
> what you're looking for?
> 
> On Fri, Sep 7, 2018 at 11:19 AM Jeff Young  > wrote:
> When I move a view item, what is supposed to remove it and re-add it to the 
> R-tree?
> 
> Right now this isn’t happening so the moved objects get clipped when their 
> original space goes out of the view.
> 
> Thanks,
> Jeff.
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL design question

[Jon Evans]

VIEW::Update() -> VIEW::invalidateItem() -> VIEW::updateBbox() ?  Is that
what you're looking for?

On Fri, Sep 7, 2018 at 11:19 AM Jeff Young  wrote:

> When I move a view item, what is supposed to remove it and re-add it to
> the R-tree?
>
> Right now this isn’t happening so the moved objects get clipped when their
> original space goes out of the view.
>
> Thanks,
> Jeff.
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL canvas strategy - testers needed!

[Wayne Stambaugh]

Some feedback from what I've seen so far which can be observed in the
attached screen capture.

The wire line thickness changes when zooming which makes for a rather
interesting visual effect.

When dragging an object ('G' hotkey), the object is displaced off the
display.

The scrollbars do not appear to work at all.

This was built with wxWidgets using gtk2.  I also tested a build with
gtk3 and didn't see much of a difference.  I am using Debian testing
with the nvidia graphics drivers.  I will continue testing and keep you
posted if I find any other issues.

Cheers,

Wayne

On 09/06/2018 12:18 PM, jp charras wrote:
> Le 06/09/2018 à 17:57, Tomasz Wlostowski a écrit :
>> On 06/09/18 17:37, Jeff Young wrote:
>>> Hi Tom,
>>>
>>> I have committed the completion of the block rotate and mirror fixes 
>>> (including for LibEdit).
>>
>> Hi Jeff,
>>
>> Thanks, I played with eeschema for a short while and I really appreciate
>> all the work you have done!
>>
>> Dear devs (non-devs too ;-) - whoever is interested in testing this
>> branch, please compile this and send the feedback here:
>>
>> https://git.launchpad.net/~jeyjey/kicad/log/?h=tom-eeschema-gal-aug27
>>
>> Cheers,
>> Tom
> 
> Hi Jeff,
> 
> Attached, a small patch that fixes a few minor compil warnings, and
> re-enable calls to draw symbols items in wxDC canvas for printing
> purpose, making printing working again.
> 
> Thanks to you, Jeff and Tomasz, for all your hard work on GAL for Eeschema.
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] GAL design question

[Jeff Young]

When I move a view item, what is supposed to remove it and re-add it to the 
R-tree?

Right now this isn’t happening so the moved objects get clipped when their 
original space goes out of the view.

Thanks,
Jeff.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL canvas strategy - testers needed!

[Jeff Young]

Hi all,

An update on a few of the issues Marcus reported:

1) Hooked up the “Always show cursor” preference so it isn’t shown when no tool 
is active.

2) Fixed the outline issue.  We *were* drawing the outline centred, it’s just 
that we were filling it *after* stroking so that the fill covered up half of 
the outline.

Note that the second fix will *also* change the rectangle stroke/fill behaviour 
for Pcbnew.  However, I’m not sure we use separate colour stroke/fills there so 
it might not matter (and the fix brings rectangles in line with other shapes 
which were already don’t correctly).

Both fixes pushed (along with JP’s most recent patch).

Cheers,
Jeff.


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL canvas strategy - testers needed!

[Vesa Solonen]

Aimylios kirjoitti 07.09.2018 klo 09:37:

> "Supersampling (2x)" is useable at higher zoom levels. At lower zoom
> levels, the thickness of lines is not displayed uniformly, which I find
> somewhat irritating. But I guess I'll just have to get used to that.

You don't have to. Someone(tm) just have to implement pixel grid fitting
to push the scaling error to the gaps instead of line widths... I
wouldn't be worried too much this early. I believe Intel integrated GPU
is to blame for the performance issues with SS. WxDC is usually very
fast on these GPUs though.

-Vesa

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL canvas strategy - testers needed!

[jp charras]

Le 07/09/2018 à 00:31, Jeff Young a écrit :
>>
<...>

Hi Jeff,

Attached a small patch that fixes some cosmetic issues (incorrect color
of some items).


-- 
Jean-Pierre CHARRAS
From d493d9d463f7ac1f3ad22488d3fd5428778f2a3d Mon Sep 17 00:00:00 2001
From: jean-pierre charras 
Date: Fri, 7 Sep 2018 09:15:22 +0200
Subject: [PATCH] sch_painter.cpp: fix a few incorrect color selections Fix
 also dangling symbol thickness of bus entries

---
 eeschema/sch_painter.cpp | 16 ++--
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/eeschema/sch_painter.cpp b/eeschema/sch_painter.cpp
index 070e26bf0..853cc689d 100644
--- a/eeschema/sch_painter.cpp
+++ b/eeschema/sch_painter.cpp
@@ -171,7 +171,7 @@ bool SCH_PAINTER::Draw( const VIEW_ITEM *aItem, int aLayer )
 
 m_gal->StrokeText( wxT("Test"), VECTOR2D(0, 0), 0.0 );
 */
-   switch(item->Type())
+   switch( item->Type() )
{
HANDLE_ITEM(LIB_ALIAS_T, LIB_ALIAS);
HANDLE_ITEM(LIB_PART_T, LIB_PART);
@@ -920,9 +920,10 @@ void SCH_PAINTER::draw( SCH_TEXT *aText, int aLayer )
 
 switch( aText->Type() )
 {
-case SCH_HIERARCHICAL_LABEL_T: color = m_schSettings.GetLayerColor( 
LAYER_SHEETLABEL ); break;
-case SCH_GLOBAL_LABEL_T:   color = m_schSettings.GetLayerColor( 
LAYER_GLOBLABEL );  break;
-default:   color = m_schSettings.GetLayerColor( 
LAYER_NOTES );  break;
+case SCH_HIERARCHICAL_LABEL_T:  color = m_schSettings.GetLayerColor( 
LAYER_SHEETLABEL ); break;
+case SCH_GLOBAL_LABEL_T:color = m_schSettings.GetLayerColor( 
LAYER_GLOBLABEL );  break;
+case SCH_LABEL_T:   color = m_schSettings.GetLayerColor( 
LAYER_LOCLABEL );   break;
+default:color = m_schSettings.GetLayerColor( 
LAYER_NOTES );  break;
 }
 
 if( !aText->IsVisible() )
@@ -1240,7 +1241,9 @@ void SCH_PAINTER::draw( SCH_NO_CONNECT *aNC, int aLayer )
 
 void SCH_PAINTER::draw( SCH_BUS_ENTRY_BASE *aEntry, int aLayer )
 {
-COLOR4D color = m_schSettings.GetLayerColor( LAYER_BUS );
+COLOR4D color = aEntry->Type() == SCH_BUS_BUS_ENTRY_T ?
+m_schSettings.GetLayerColor( LAYER_BUS )
+: m_schSettings.GetLayerColor( LAYER_WIRE 
);
 
 if( aEntry->IsMoving() )
 color = selectedBrightening( color );
@@ -1255,7 +1258,8 @@ void SCH_PAINTER::draw( SCH_BUS_ENTRY_BASE *aEntry, int 
aLayer )
 
 m_gal->DrawLine( pos, endPos );
 
-m_gal->SetStrokeColor( m_schSettings.GetLayerColor( LAYER_BUS ) );
+// Draw dangling symbols:
+m_gal->SetLineWidth ( 1.0 );
 
 if( aEntry->IsDanglingStart() )
 m_gal->DrawCircle( pos, TARGET_BUSENTRY_RADIUS );
-- 
2.17.0.windows.1

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp