Re: [Kicad-developers] IPO_PROPERTIES in Via placement?
Hi Simon, I can’t imagine why Via placement would set that flag. Maybe it used to bring up a dialog to select the destination layer or something? There were two different architectures fighting in that code. So if clearing the flag breaks something else then I think we need to smoke out what that might be, and then fix that problem some other way than setting the flag. Using some side-effect of that flag (if indeed we turn out to be doing that somewhere) will never be sustainable. Cheers, Jeff. > On 6 Oct 2018, at 06:55, Simon Richter wrote: > > Hi, > > My net ties code no longer gives me a preview item once I select the > tool, which I find annoying. I've traced this to commit c655bffac1, > where placement with IPO_PROPERTIES no longer gives a preview item, > because the first click would open a properties dialog. > > Via placement has set this flag since before then, but I don't see why > it would. Should it be cleared, or does that break something else? As it > is now, this is annoying because only every second click places a Via > when the Via tool is selected. > > Simon > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Cairo printing
On 07/10/18 22:05, Wayne Stambaugh wrote: > This makes me nervous. The gdiplus library brings wxGraphicsContext > into play on windows. Hi Wayne, IIRC this has nothing to do with wxGraphicsContext. It's cairo that uses gdiplus under windows as the printing backend. The only change needed is to include gdiplus in TARGET_LINK_LIBRARIES on Windows systems. Cheers, Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Cairo printing
On 10/07/2018 02:45 PM, jp charras wrote: > Le 07/10/2018 à 19:25, Tomasz Wlostowski a écrit : >>> When building Kicad (on W7 32 bits), I have this link error: >>> > <...> >> >> Hi JP, >> >> I saw a similar problem, it can be fixed by adding gdiplus library to >> Windows link libraries in CMakeLists.txt >> >> Tom >> > > Yes, it works. > Thanks. > This makes me nervous. The gdiplus library brings wxGraphicsContext into play on windows. Something from wxGraphicsContext is being pulled into the kicad build which can be enabled by configuring builds with -DUSE_WX_GRAPHICS_CONTEXT=ON. I would have thought with cairo being both the display and print context that gdiplus would not be required for linking kicad. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Cairo printing
Le 07/10/2018 à 19:25, Tomasz Wlostowski a écrit : >> When building Kicad (on W7 32 bits), I have this link error: >> <...> > > Hi JP, > > I saw a similar problem, it can be fixed by adding gdiplus library to > Windows link libraries in CMakeLists.txt > > Tom > Yes, it works. Thanks. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Cairo printing
On 07/10/18 18:21, jp charras wrote: > Le 07/10/2018 à 13:53, Maciej Sumiński a écrit : >> I have finished printing code refactor to take advantage of GAL in >> pcbnew and gerbview [1]. This branch together with GALified >> eeschema should cure GTK3-related headaches and lead us straight to 5.1. >> In the meantime I will also try to port eeschema to the >> new printing system for the sake of completeness, though it is not >> critical for 5.1. >> >> I have tested the code on Linux x86_64, Windows 7 x86_64 and macOS >> 10.13.4, but additional testing is welcome. >> >> Cheers, >> Orson >> >> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/cairo_printing > > Hi Orson, > > When building Kicad (on W7 32 bits), I have this link error: > > ../common/libgal.a(cairo_print.cpp.obj): In function > `ZN7Gdiplus8Graphics6GetHDCEv': > C:/msys32_mywx/mingw32/i686-w64-mingw32/include/gdiplus/gdiplusgraphics.h:1070: > undefined reference to `GdipGetDC@8' > ../common/libgal.a(cairo_print.cpp.obj): In function > `ZN7Gdiplus8Graphics10ReleaseHDCEP5HDC__': > C:/msys32_mywx/mingw32/i686-w64-mingw32/include/gdiplus/gdiplusgraphics.h:1354: > undefined reference to `GdipReleaseDC@8' Hi JP, I saw a similar problem, it can be fixed by adding gdiplus library to Windows link libraries in CMakeLists.txt Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Cairo printing
Le 07/10/2018 à 13:53, Maciej Sumiński a écrit : > I have finished printing code refactor to take advantage of GAL in > pcbnew and gerbview [1]. This branch together with GALified > eeschema should cure GTK3-related headaches and lead us straight to 5.1. > In the meantime I will also try to port eeschema to the > new printing system for the sake of completeness, though it is not > critical for 5.1. > > I have tested the code on Linux x86_64, Windows 7 x86_64 and macOS > 10.13.4, but additional testing is welcome. > > Cheers, > Orson > > 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/cairo_printing Hi Orson, When building Kicad (on W7 32 bits), I have this link error: ../common/libgal.a(cairo_print.cpp.obj): In function `ZN7Gdiplus8Graphics6GetHDCEv': C:/msys32_mywx/mingw32/i686-w64-mingw32/include/gdiplus/gdiplusgraphics.h:1070: undefined reference to `GdipGetDC@8' ../common/libgal.a(cairo_print.cpp.obj): In function `ZN7Gdiplus8Graphics10ReleaseHDCEP5HDC__': C:/msys32_mywx/mingw32/i686-w64-mingw32/include/gdiplus/gdiplusgraphics.h:1354: undefined reference to `GdipReleaseDC@8' collect2.exe: error: ld returned 1 exit status gerbview/CMakeFiles/gerbview_kiface.dir/build.make:1612: recipe for target 'gerbview/_gerbview.kiface' failed make[3]: *** [gerbview/_gerbview.kiface] Error 1 CMakeFiles/Makefile2:1219: recipe for target 'gerbview/CMakeFiles/gerbview_kiface.dir/all' failed make[2]: *** [gerbview/CMakeFiles/gerbview_kiface.dir/all] Error 2 CMakeFiles/Makefile2:1191: recipe for target 'gerbview/CMakeFiles/gerbview.dir/rule' failed make[1]: *** [gerbview/CMakeFiles/gerbview.dir/rule] Error 2 Makefile:474: recipe for target 'gerbview' failed make: *** [gerbview] Error 2 -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Cairo printing
I have finished printing code refactor to take advantage of GAL in pcbnew and gerbview [1]. This branch together with GALified eeschema should cure GTK3-related headaches and lead us straight to 5.1. In the meantime I will also try to port eeschema to the new printing system for the sake of completeness, though it is not critical for 5.1. I have tested the code on Linux x86_64, Windows 7 x86_64 and macOS 10.13.4, but additional testing is welcome. Cheers, Orson 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/cairo_printing ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
