Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Andrew Lutsenko
I'm not sure if this was reported earlier but I noticed 2 things:

1. Change cursor shape (alternatively View->Full Window Crosshair) does not
work. I tried with various anti aliasing settings.

2. Antialiasing settings behave differently. Without antialiasing some
lines are 2 pixels wide and some are 1 pixel:
[image: Screenshot from 2018-10-09 16-42-44.png]

With subpixel antialiasing lines vary in thickness depending on their
closeness to a junction dot or anything else really.

Oversampling looks ok-ish except nothing is sharp so I constantly try to
clean my glasses.

On wxDC no antialiasing was the best option visually.

Regards,
Andrew

On Tue, Oct 9, 2018 at 5:13 AM Wayne Stambaugh  wrote:

> Let the bug reports begin!  Maybe we should give some sort of prize to
> the first person who complains that they like the old wxDC canvas better.
> ;)
>
> On 10/9/2018 8:08 AM, Jeff Young wrote:
> > The Eeschema GAL branch has been pushed to master.
> >
> > Cheers,
> > Jeff.
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] IPO_PROPERTIES in Via placement?

2018-10-09 Thread Jeff Young
Hi Simon,

I’ve fixed the properties flag for vias (and a crash bug when you cancel out of 
placement tools which actually do have a properties dialog.

Can you say more about the net ties code?  Does it have a properties dialog?

Cheers,
Jeff.


> On 7 Oct 2018, at 21:58, Jeff Young  wrote:
> 
> Hi Simon,
> 
> I can’t imagine why Via placement would set that flag.  Maybe it used to 
> bring up a dialog to select the destination layer or something?
> 
> There were two different architectures fighting in that code.  So if clearing 
> the flag breaks something else then I think we need to smoke out what that 
> might be, and then fix that problem some other way than setting the flag.  
> Using some side-effect of that flag (if indeed we turn out to be doing that 
> somewhere) will never be sustainable.
> 
> Cheers,
> Jeff.
> 
> 
>> On 6 Oct 2018, at 06:55, Simon Richter  wrote:
>> 
>> Hi,
>> 
>> My net ties code no longer gives me a preview item once I select the
>> tool, which I find annoying. I've traced this to commit c655bffac1,
>> where placement with IPO_PROPERTIES no longer gives a preview item,
>> because the first click would open a properties dialog.
>> 
>> Via placement has set this flag since before then, but I don't see why
>> it would. Should it be cleared, or does that break something else? As it
>> is now, this is annoying because only every second click places a Via
>> when the Via tool is selected.
>> 
>>  Simon
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] GAL branch

2018-10-09 Thread Eeli Kaikkonen
to 4. lokak. 2018 klo 19.06 Seth Hillbrand (s...@hillbrand.org) kirjoitti:
@Eeli- I cannot recreate either issue in the current build although I did
see them previously.  Is there any chance you have stale files in your
build?

> Am So., 30. Sep. 2018 um 03:54 Uhr schrieb Eeli Kaikkonen <
> eeli.kaikko...@gmail.com>:
>
>>
>> 1. Components disappear when I zoom in.
>>
>
Here's another screencast about the issue, reduced as much as possible to
one symbol consisting of one rectangle. I ran "clean" and "uninstall"
targets, then rebuilt and installed the latest master.
https://drive.google.com/file/d/1fb1qHBP-uKUr7etPCbjDZ-FNA2SXmoB2/view?usp=sharing

This doesn't happen with every component in every situation. It requires
something, but I don't know what.

I have Kubuntu 17.10, NVidia GT 1030, proprietary driver v. 384.130.

Application: kicad
Version: (6.0.0-rc1-dev-844-g808a7d948), debug build
Libraries:
wxWidgets 3.0.3
Platform: Linux 4.13.0-46-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
Boost: 1.62.0
Compiler: GCC 7.2.0 with C++ ABI 1011

Build settings:
USE_WX_GRAPHICS_CONTEXT=OFF
USE_WX_OVERLAY=OFF
KICAD_SCRIPTING=ON
KICAD_SCRIPTING_MODULES=ON
KICAD_SCRIPTING_WXPYTHON=ON
KICAD_SCRIPTING_ACTION_MENU=ON
BUILD_GITHUB_PLUGIN=OFF
KICAD_USE_OCE=OFF
KICAD_USE_OCC=OFF
KICAD_SPICE=OFF
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Net selector

2018-10-09 Thread Jeff Young
Cool.  Thanks for the reports!

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Net selector

2018-10-09 Thread Eeli Kaikkonen
ti 9. lokak. 2018 klo 17.05 Jeff Young (j...@rokeby.ie) kirjoitti:

> I think you had the latest; the GAL branch should have been up-to-date as
> well.
>
> I’ve found a likely cause of the single-character-filter issue and pushed
> a “fix”.
>

It works with the latest master (808a7d94833f1a). The remaining issues are
focus and selection related. I think accepting the selected net from the
list is more important because when the user uses filtering (s)he already
uses the keyboard. Selecting and opening the combobox with keyboard is
probably rare, I don't know if anyone wants to use KiCad's dialogs (other
than text and numbers) with keyboard. After all ECAD must be used with a
pointer device anyways.

Eeli Kaikkonen
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Janitor cleanup

2018-10-09 Thread Seth Hillbrand
Hi Orson-

Do you have the janitor script that you used to bulk-mark the fixed bugs
for 5.0?  If so, would it be possible to re-run that for 5.0.1?

Thanks-
Seth
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Andy Peters


> On Oct 9, 2018, at 5:59 AM, Tomasz Wlostowski  
> wrote:
> 
> On 09/10/18 14:34, Jeff Young wrote:
>> One of the model-railroad forums I’m on still has a max attachment 
>> resolution of 640 x 480.  My phone can do better than that. ;)
>> 
> 
> 
> Look at this Jeff:
> https://lists.launchpad.net/kicad-developers/msg20860.html
> 
> Next dev goal: make it work on 384x240 2 inch LCD display :)

Piffle! I want it to run on my iPad Pro! :)

-a


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Cairo printing

2018-10-09 Thread jp charras
Le 09/10/2018 à 12:46, Maciej Sumiński a écrit :
> Hi Jean-Pierre,
> 
> On 10/9/18 12:04 PM, jp charras wrote:
> [snip]
>> Hi Orson,
>>
>> The transparency issue (specific to Cairo render) is a minor issue (see
>> attached picture, especially the oval pad) on screen, but could be more
>> annoying on printed documents.
> 
> Agreed, colors in printouts need to be opaque. I think the problem of
> different colors in overlapping areas could be solved, but Cairo
> documentation [1] says translucent colors are not supported on
> PostScript surfaces and will result in rasterized images. It is bizarre
> that I am not seeing this problem on Linux.

On Windows, I am guessing the pdf printer (like CutePDF) uses a
postscript based driver.
On Windows, postscript drivers + wxWidgets printing have a problem: the
lines like tracks (and oval pads) are draw as very thin lines, and
CutePDF has this problem.

On Linux, the pdf printer output is not rasterized.
If the PS printer output is rasterized, this is hard to see, because (at
least on my install) the zoom level does not really allow to see
pixelization on the screen.

By the way, with the Cairo printing, the PS output (and the PDF output)
does not exhibit any longer this problem and is fine (as long there are
no transparency).

> 
> I have already patched my branch to use opaque colors for printouts.
> 
>> I forgot an other issue: bitmaps (added with the page layout editor) are
>> incorrectly scaled (something like 10 times smaller) in the print preview.
> 
> Thank you for the report, I will check it.
> 
> Cheers,
> Orson
> 
> 1. https://www.cairographics.org/documentation/using_the_postscript_surface/
> 


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Kevin Cozens

On 2018-10-09 08:11 AM, Wayne Stambaugh wrote:

Let the bug reports begin!  Maybe we should give some sort of prize to
the first person who complains that they like the old wxDC canvas better. ;)


The first comment I have about the change is that my preference settings 
were affected. When I opened a schematic for the first time after building 
git master this morning I had the schematic using lines for the grid instead 
of dots that I have been using since I started using KiCad.


I will have to see if there are any other noticeable changes.

--
Cheers!

Kevin.

http://www.ve3syb.ca/   | "Nerds make the shiny things that
https://www.patreon.com/KevinCozens | distract the mouth-breathers, and
| that's why we're powerful"
Owner of Elecraft K2 #2172  |
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-09 Thread John Beard
Hi Wayne,

No problems, I get it!

It's not needed for the fuzzing stuff, it's actually a pre-cursor for
a patch set to do with the dialog_page_settings dialog, but that is
now probably on hold for a bit due to being unable to now include
"class_drawpanel.h" from any common lib cpp.

However, it's also needed to be able to use unit testing for many
libcommon classes (TITLE_BLOCK is not the only one that ends up
sucking in tons of dependencies), so if anyone has any ideas about
what else is needed to get this to build, I'd appreciate pointers!

Cheers,

John
On Tue, Oct 9, 2018 at 3:04 PM Wayne Stambaugh  wrote:
>
> Hey John,
>
> I would like to help you out with this but I'm slammed at work and I'm
> not going to be able to help out.  Is this a patch a prerequisite for
> your fuzzing patch?
>
> Cheers,
>
> Wayne
>
> On 10/8/2018 1:11 PM, John Beard wrote:
> > Hi Wayne,
> >
> > I have no ideas why that would be, but the QA stuff does have a funny
> > way of exposing strange link behaviours. In this case, we have:
> >
> > target_link_libraries( qa_common
> > common
> > polygon
> > bitmaps
> > ${Boost_UNIT_TEST_FRAMEWORK_LIBRARY}
> > ${wxWidgets_LIBRARIES} # doesn't this provide wxcolourbase??
> > )
> >
> > I have no explanation for why wxColourBase::FromString doesn't link
> > here. Perhaps it's a similar reason for whatever prompted this being
> > necessary for pcb_test_window:
> >
> > target_link_libraries( test_window
> > polygon
> > pnsrouter
> > common
> > pcbcommon
> > bitmaps
> > polygon
> > pnsrouter
> > common
> > pcbcommon
> > bitmaps
> > polygon
> > pnsrouter
> > common
> > pcbcommon
> > bitmaps
> > polygon
> > pnsrouter
> > common
> > pcbcommon
> > 3d-viewer
> > bitmaps
> > gal
> > pcad2kicadpcb
> > common
> > pcbcommon
> > ${GITHUB_PLUGIN_LIBRARIES}
> > common
> > pcbcommon
> > ${Boost_FILESYSTEM_LIBRARY}
> > ${Boost_SYSTEM_LIBRARY}
> > ${Boost_UNIT_TEST_FRAMEWORK_LIBRARY}
> > ${wxWidgets_LIBRARIES}
> > )
> >
> > Cheers,
> >
> > John
> > On Mon, Oct 8, 2018 at 5:39 PM Wayne Stambaugh  wrote:
> >>
> >> Hi John,
> >>
> >> I am getting the following build error on windows with this patch:
> >>
> >> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
> >> ../../common/libgal.a(color4d.cpp.obj):color4d.cpp:(.text+0x1c9):
> >> undefined reference to `wxColourBase::FromString(wxString const&)'
> >> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
> >> ../../common/libgal.a(color4d.cpp.obj):color4d.cpp:(.text+0x32e):
> >> undefined reference to `wxColourBase::GetAsString(long) const'
> >> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
> >> ../../common/libgal.a(color4d.cpp.obj):color4d.cpp:(.text+0x80c):
> >> undefined reference to `wxColourBase::GetAsString(long) const'
> >> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
> >> ../../common/libgal.a(gal_display_options.cpp.obj):gal_display_options.cpp:(.text+0x22b):
> >> undefined reference to `wxConfigBase::Read(wxString const&, long*, long)
> >> const'
> >> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
> >> ../../common/libgal.a(gal_display_options.cpp.obj):gal_display_options.cpp:(.text+0x2b8):
> >> undefined reference to `wxConfigBase::Read(wxString const&, long*, long)
> >> const'
> >> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
> >> ../../common/libgal.a(gal_display_options.cpp.obj):gal_display_options.cpp:(.text+0x347):
> >> undefined reference to `wxConfigBase::Read(wxString const&, double*,
> >> double) const'
> >> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
> >> ../../common/libgal.a(gal_display_options.cpp.obj):gal_display_options.cpp:(.text+0x398):
> >> undefined reference to `wxConfigBase::Read(wxString const&, double*,
> >> double) const'
> >> collect2.exe: error: ld returned 1 exit status
> >> make[2]: *** [qa/common/CMakeFiles/qa_common.dir/build.make:217:
> >> qa/common/qa_common.exe] Error 1
> >> make[1]: *** [CMakeFiles/Makefile2:3111:
> >> qa/common/CMakeFiles/qa_common.dir/all]
> >>
> >>
> >>
> >> On 10/6/2018 3:48 PM, John Beard wrote:
> >>> Hi Wayne,
> >>>
> >>> On Sat, Oct 6, 2018 at 5:29 PM Wayne Stambaugh  
> >>> wrote:
>  No problem.  I will test your patch once you post it.
> >>>
> >>> Patch attached. Indeed, it was a missing include in the header that
> >>> probably worked until now due to serendipitous include ordering in the
> >>> existing CPPs.
> >>>
> >>> This actually illustrates one nice thing about having unit tests CPPs
> >>> that include only a single KiCad header - they make sure that header
> >>> and any transitive 

Re: [Kicad-developers] Net selector

2018-10-09 Thread Jeff Young
I think you had the latest; the GAL branch should have been up-to-date as well.

I’ve found a likely cause of the single-character-filter issue and pushed a 
“fix”.

Cheers,
Jeff.


> On 9 Oct 2018, at 07:49, Eeli Kaikkonen  wrote:
> 
> Oops, did I have the gal branch installed? I takes a while to compile and 
> install the master.
> 
> Eeli Kaikkonen
> 
> 
> ti 9. lokak. 2018 klo 9.47 Eeli Kaikkonen (eeli.kaikko...@gmail.com 
> ) kirjoitti:
> 
> 
> ma 8. lokak. 2018 klo 15.29 Jeff Young (j...@rokeby.ie 
> ) kirjoitti:
> How’s that Net Selector working these days?  Is all good, or are people just 
> tired of reporting issues with it? ;)
> 
> 
> Filter doesn't work as expected, it replaces the previous typed character 
> with the next one, there's always only one character in the Filter field. It 
> filters according to that last typed character.
> 
> Eeli Kaikkonen
> 
> Application: kicad
> Version: (6.0.0-rc1-dev-714-g3024ded91), debug build
> Libraries:
> wxWidgets 3.0.3
> Platform: Linux 4.13.0-46-generic x86_64, 64 bit, Little endian, wxGTK
> Build Info:
> wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
> Boost: 1.62.0
> Compiler: GCC 7.2.0 with C++ ABI 1011
> 
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=OFF
> KICAD_USE_OCE=OFF
> KICAD_USE_OCC=OFF
> KICAD_SPICE=OFF
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests

2018-10-09 Thread Wayne Stambaugh
Hey John,

I would like to help you out with this but I'm slammed at work and I'm
not going to be able to help out.  Is this a patch a prerequisite for
your fuzzing patch?

Cheers,

Wayne

On 10/8/2018 1:11 PM, John Beard wrote:
> Hi Wayne,
> 
> I have no ideas why that would be, but the QA stuff does have a funny
> way of exposing strange link behaviours. In this case, we have:
> 
> target_link_libraries( qa_common
> common
> polygon
> bitmaps
> ${Boost_UNIT_TEST_FRAMEWORK_LIBRARY}
> ${wxWidgets_LIBRARIES} # doesn't this provide wxcolourbase??
> )
> 
> I have no explanation for why wxColourBase::FromString doesn't link
> here. Perhaps it's a similar reason for whatever prompted this being
> necessary for pcb_test_window:
> 
> target_link_libraries( test_window
> polygon
> pnsrouter
> common
> pcbcommon
> bitmaps
> polygon
> pnsrouter
> common
> pcbcommon
> bitmaps
> polygon
> pnsrouter
> common
> pcbcommon
> bitmaps
> polygon
> pnsrouter
> common
> pcbcommon
> 3d-viewer
> bitmaps
> gal
> pcad2kicadpcb
> common
> pcbcommon
> ${GITHUB_PLUGIN_LIBRARIES}
> common
> pcbcommon
> ${Boost_FILESYSTEM_LIBRARY}
> ${Boost_SYSTEM_LIBRARY}
> ${Boost_UNIT_TEST_FRAMEWORK_LIBRARY}
> ${wxWidgets_LIBRARIES}
> )
> 
> Cheers,
> 
> John
> On Mon, Oct 8, 2018 at 5:39 PM Wayne Stambaugh  wrote:
>>
>> Hi John,
>>
>> I am getting the following build error on windows with this patch:
>>
>> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
>> ../../common/libgal.a(color4d.cpp.obj):color4d.cpp:(.text+0x1c9):
>> undefined reference to `wxColourBase::FromString(wxString const&)'
>> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
>> ../../common/libgal.a(color4d.cpp.obj):color4d.cpp:(.text+0x32e):
>> undefined reference to `wxColourBase::GetAsString(long) const'
>> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
>> ../../common/libgal.a(color4d.cpp.obj):color4d.cpp:(.text+0x80c):
>> undefined reference to `wxColourBase::GetAsString(long) const'
>> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
>> ../../common/libgal.a(gal_display_options.cpp.obj):gal_display_options.cpp:(.text+0x22b):
>> undefined reference to `wxConfigBase::Read(wxString const&, long*, long)
>> const'
>> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
>> ../../common/libgal.a(gal_display_options.cpp.obj):gal_display_options.cpp:(.text+0x2b8):
>> undefined reference to `wxConfigBase::Read(wxString const&, long*, long)
>> const'
>> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
>> ../../common/libgal.a(gal_display_options.cpp.obj):gal_display_options.cpp:(.text+0x347):
>> undefined reference to `wxConfigBase::Read(wxString const&, double*,
>> double) const'
>> C:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/7.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
>> ../../common/libgal.a(gal_display_options.cpp.obj):gal_display_options.cpp:(.text+0x398):
>> undefined reference to `wxConfigBase::Read(wxString const&, double*,
>> double) const'
>> collect2.exe: error: ld returned 1 exit status
>> make[2]: *** [qa/common/CMakeFiles/qa_common.dir/build.make:217:
>> qa/common/qa_common.exe] Error 1
>> make[1]: *** [CMakeFiles/Makefile2:3111:
>> qa/common/CMakeFiles/qa_common.dir/all]
>>
>>
>>
>> On 10/6/2018 3:48 PM, John Beard wrote:
>>> Hi Wayne,
>>>
>>> On Sat, Oct 6, 2018 at 5:29 PM Wayne Stambaugh  wrote:
 No problem.  I will test your patch once you post it.
>>>
>>> Patch attached. Indeed, it was a missing include in the header that
>>> probably worked until now due to serendipitous include ordering in the
>>> existing CPPs.
>>>
>>> This actually illustrates one nice thing about having unit tests CPPs
>>> that include only a single KiCad header - they make sure that header
>>> and any transitive includes are compilable even when the test CPP only
>>> includes that one header (i.e. as recommended by the code guidelines:
>>> 6.2 Headers Without Unsatisfied Dependencies [1]).
>>>
>>> Another way this can improved is when you have a .cpp/.h pair for a
>>> self-contained class, the .cpp should include the corresponding .h
>>> first before any other include. This ensures the header is compilable
>>> by itself, and has no implicit inclusion criteria for use. This is
>>> sometimes, but not always true in KiCad. (In this case, there is no
>>> .cpp anyway, so the unit test was the first CPP to attempt to include
>>> by itself).
>>>
 The problem is all of the inline functions defined in convert_to_biu.h.
 Until they are replaced with per application equivalents, we will
 continue to have to compile every common source file multiple times 

Re: [Kicad-developers] [PATCH] Fuzzable PCB parsing test harness

2018-10-09 Thread John Beard
Hi,

Here is an update patch that rebases over the commenting out of
pcb_test_window, polygon_triangulation and polygon_generator and fixes
a link error to do with base_screen.cpp.

Cheers,

John
On Mon, Oct 8, 2018 at 5:27 PM John Beard  wrote:
>
> Sorry,
>
> I wrote "ms", I meant "us" - the times are in the handful-of-millsecond range.
>
> Cheers,
>
> John
> On Mon, Oct 8, 2018 at 5:24 PM John Beard  wrote:
> >
> > Hi,
> >
> > This is a patch to add a test program that allows to parse a Pcbnew
> > file from command line params or stdin. This means you can use it for
> > fuzz testing.
> >
> > I have done a little bit of fuzz testing so far (8 million execs,
> > about 70% of a cycle), and have not found any crashes, but I can make
> > it hang in a few ways. These all seem to be in streams which contain
> > nul's. This is actually not reachable from the UI due to reading files
> > into wxStrings first (nut quite sure why), whereas this program uses
> > the parser directly. Thus, the bug is probably not very critical.
> > Example hanging input attached (note there's a nul in it, so your
> > editor may or may not like that).
> >
> > This program can also be fed a number of files, which means it could
> > be used for automated testing that all files in a batch can be parsed
> > successfully, and also provides a handy way to put GDB on a program
> > when debugging the parser against specific input.
> >
> > There is timing on the parsing too, mostly for interest (use the -v
> > flag). It takes about 150-3000ms per FP on my machine for the FPs in
> > Connector_PinSocket_2.54mm.pretty.
> >
> > There's also some centralisation of some QA-related utils into a
> > qa_utils library.
> >
> > Cheers,
> >
> > John
From 3ff4ee626860c81e48896a1b15ecc967d74e5e39 Mon Sep 17 00:00:00 2001
From: John Beard 
Date: Sat, 6 Oct 2018 15:35:17 +0100
Subject: [PATCH] QA: PCB file input parse test program (fuzzable)

This adds a test program which can be used to test the
parsing of a given KiCad PCB file. This interface is
useful for both manual or automated debugging of given
files, as well as providing an interface suitable for
fuzz-testing tools.

Also adds to the testing docs to detail how fuzzing can
be used.

Also moves some useful re-usable code from io-benchmark
to a new library qa_utils, which can contain code that
isn't need in the actual KiCad libs.
---
 Documentation/development/testing.md  |  47 +-
 qa/CMakeLists.txt |   4 +
 qa/pcb_parse_input/CMakeLists.txt |  66 
 qa/pcb_parse_input/main.cpp   | 158 ++
 qa/qa_utils/CMakeLists.txt|  40 +
 qa/qa_utils/scoped_timer.h|  62 +++
 .../qa_utils}/stdstream_line_reader.cpp   |   8 +-
 .../qa_utils}/stdstream_line_reader.h |   8 +-
 tools/io_benchmark/CMakeLists.txt |   2 +-
 9 files changed, 386 insertions(+), 9 deletions(-)
 create mode 100644 qa/pcb_parse_input/CMakeLists.txt
 create mode 100644 qa/pcb_parse_input/main.cpp
 create mode 100644 qa/qa_utils/CMakeLists.txt
 create mode 100644 qa/qa_utils/scoped_timer.h
 rename {tools/io_benchmark => qa/qa_utils}/stdstream_line_reader.cpp (91%)
 rename {tools/io_benchmark => qa/qa_utils}/stdstream_line_reader.h (92%)

diff --git a/Documentation/development/testing.md b/Documentation/development/testing.md
index 4726ca536..cf0d4c129 100644
--- a/Documentation/development/testing.md
+++ b/Documentation/development/testing.md
@@ -103,6 +103,51 @@ You can run the tests in GDB to trace this:
 If the test segfaults, you will get a familiar backtrace, just like
 if you were running pcbnew under GDB.
 
+## Fuzz testing ##
+
+It is possible to run fuzz testing on some parts of KiCad. To do this for a
+generic function, you need to be able to pass some kind of input from the fuzz
+testing tool to the function under test.
+
+For example, to use the [AFL fuzzing tool][], you will need:
+
+* A test executable that can:
+** Receive input from `stdin` to be run by `afl-fuzz`.
+** Optional: process input from a filename to allow `afl-tmin` to minimise the
+   input files.
+* To compile this executable with an AFL compiler, to enable the instrumentation
+  that allows the fuzzer to detect the fuzzing state.
+
+For example, the `qa_pcb_parse_input` executable can be compiled like this:
+
+mkdir build
+cd build
+cmake -DCMAKE_CXX_COMPILER=/usr/bin/afl-clang-fast++ -DCMAKE_C_COMPILER=/usr/bin/afl-clang-fast ../kicad_src
+make qa_pcb_parse_input
+
+You may need to disable core dumps and CPU frequency scaling on your system (AFL
+will warn you if you should do this). For example, as root:
+
+# echo core >/proc/sys/kernel/core_pattern
+# echo performance | tee cpu*/cpufreq/scaling_governor
+
+To fuzz:
+
+afl-fuzz -i fuzzin -o fuzzout -m500 qa/pcb_parse_input/qa_pcb_parse_input
+
+where:
+
+* `-i` is a directory of files to use as fuzz input "seeds"
+* `-o` is a 

Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Tomasz Wlostowski
On 09/10/18 14:34, Jeff Young wrote:
> One of the model-railroad forums I’m on still has a max attachment resolution 
> of 640 x 480.  My phone can do better than that. ;)
> 


Look at this Jeff:
https://lists.launchpad.net/kicad-developers/msg20860.html

Next dev goal: make it work on 384x240 2 inch LCD display :)

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Tomasz Wlostowski
On 09/10/18 14:31, Jeff Young wrote:
> The old wxDC canvas is better on Retina displays, but I think someone pointed 
> us in the right direction to fix it.  Something about how you set the 
> parameters which control position-accuracy vs. anti-aliasing?
> 
Hi Jeff,

I have an incomplete patch for the GL pixel shader that ensures correct
single-pixel alignment. Give me a couple of days to clean it up.

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Jeff Young
One of the model-railroad forums I’m on still has a max attachment resolution 
of 640 x 480.  My phone can do better than that. ;)

> On 9 Oct 2018, at 13:29, Tomasz Wlostowski  wrote:
> 
> On 09/10/18 14:11, Wayne Stambaugh wrote:
>> Let the bug reports begin!  Maybe we should give some sort of prize to
>> the first person who complains that they like the old wxDC canvas better. ;)
> 
> I bet it will be a hardcore Linux user filing a bug titled "eeschema
> doesn't work anymore on an X-terminal working on a 2400 bps modem line!"
> 
> Cheers,
> T.
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Jeff Young
The old wxDC canvas is better on Retina displays, but I think someone pointed 
us in the right direction to fix it.  Something about how you set the 
parameters which control position-accuracy vs. anti-aliasing?

(The issue is that when zoomed out all the lines are two pixels wide because 
they don’t align *exactly* to any given pixel.)



> On 9 Oct 2018, at 13:11, Wayne Stambaugh  wrote:
> 
> Let the bug reports begin!  Maybe we should give some sort of prize to
> the first person who complains that they like the old wxDC canvas better. ;)
> 
> On 10/9/2018 8:08 AM, Jeff Young wrote:
>> The Eeschema GAL branch has been pushed to master.
>> 
>> Cheers,
>> Jeff.
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Tomasz Wlostowski
On 09/10/18 14:11, Wayne Stambaugh wrote:
> Let the bug reports begin!  Maybe we should give some sort of prize to
> the first person who complains that they like the old wxDC canvas better. ;)

I bet it will be a hardcore Linux user filing a bug titled "eeschema
doesn't work anymore on an X-terminal working on a 2400 bps modem line!"

Cheers,
T.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Tomasz Wlostowski
On 09/10/18 14:08, Jeff Young wrote:
> The Eeschema GAL branch has been pushed to master.
> 

Yay, that's great news :) Thanks Jeff for all your hard work!

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Wayne Stambaugh
Let the bug reports begin!  Maybe we should give some sort of prize to
the first person who complains that they like the old wxDC canvas better. ;)

On 10/9/2018 8:08 AM, Jeff Young wrote:
> The Eeschema GAL branch has been pushed to master.
> 
> Cheers,
> Jeff.
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Notice: GAL branch pushed to master

2018-10-09 Thread Jeff Young
The Eeschema GAL branch has been pushed to master.

Cheers,
Jeff.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Cairo printing

2018-10-09 Thread Maciej Sumiński
Hi Jean-Pierre,

On 10/9/18 12:04 PM, jp charras wrote:
[snip]
> Hi Orson,
> 
> The transparency issue (specific to Cairo render) is a minor issue (see
> attached picture, especially the oval pad) on screen, but could be more
> annoying on printed documents.

Agreed, colors in printouts need to be opaque. I think the problem of
different colors in overlapping areas could be solved, but Cairo
documentation [1] says translucent colors are not supported on
PostScript surfaces and will result in rasterized images. It is bizarre
that I am not seeing this problem on Linux.

I have already patched my branch to use opaque colors for printouts.

> I forgot an other issue: bitmaps (added with the page layout editor) are
> incorrectly scaled (something like 10 times smaller) in the print preview.

Thank you for the report, I will check it.

Cheers,
Orson

1. https://www.cairographics.org/documentation/using_the_postscript_surface/



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Cairo printing

2018-10-09 Thread jp charras
Le 08/10/2018 à 15:56, Maciej Sumiński a écrit :
> Hi Jean-Pierre,
> 
> On 10/8/18 3:08 PM, jp charras wrote:
> [snip]
>> Hi Orson,
>> Very good job.
>>
>> I tested the Cairo printing both on Windows and Linux.
>>
>> No problem on Linux.
>> On Windows, I have strange artifacts (see attached picture) in print
>> preview.
>> (more strange, if a zone outline includes the full board items, there
>> are no, or very few, artifacts)
> 
> I will check it, but I am afraid it might be beyond my control. Do you
> see it in actual printouts/PDFs as well?
> 
>> It happens only when the opacity of any printed item is not set to 1.0
>>
>> Moreover, when the opacity of any printed item is not set to 1.0, the
>> resulting printed picture is a bitmap (tested both using Cutepdf and a
>> printer using a postscript driver), not really usable.
>> (When all objects use a 1.0 opacity, the drawings are vectored, as expected)
>>
>> Due to the fact transparency is not working very well on Cairo, and
>> useless when printing a board with one sheet by layer, I suggest to
>> force the opacity to 1.0 in any case.
> 
> That is surprising, I will need a closer look then. I would like to
> preserve transparency, but I agree that getting bitmaps instead of
> vector graphics is not acceptable.
> 
> Regards,
> Orson
> 

Hi Orson,

The transparency issue (specific to Cairo render) is a minor issue (see
attached picture, especially the oval pad) on screen, but could be more
annoying on printed documents.

I forgot an other issue: bitmaps (added with the page layout editor) are
incorrectly scaled (something like 10 times smaller) in the print preview.

-- 
Jean-Pierre CHARRAS
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Net selector

2018-10-09 Thread Eeli Kaikkonen
Oops, did I have the gal branch installed? I takes a while to compile and
install the master.

Eeli Kaikkonen


ti 9. lokak. 2018 klo 9.47 Eeli Kaikkonen (eeli.kaikko...@gmail.com)
kirjoitti:

>
>
> ma 8. lokak. 2018 klo 15.29 Jeff Young (j...@rokeby.ie) kirjoitti:
>
>> How’s that Net Selector working these days?  Is all good, or are people
>> just tired of reporting issues with it? ;)
>>
>>
> Filter doesn't work as expected, it replaces the previous typed character
> with the next one, there's always only one character in the Filter field.
> It filters according to that last typed character.
>
> Eeli Kaikkonen
>
> Application: kicad
> Version: (6.0.0-rc1-dev-714-g3024ded91), debug build
> Libraries:
> wxWidgets 3.0.3
> Platform: Linux 4.13.0-46-generic x86_64, 64 bit, Little endian, wxGTK
> Build Info:
> wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
> Boost: 1.62.0
> Compiler: GCC 7.2.0 with C++ ABI 1011
>
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=OFF
> KICAD_USE_OCE=OFF
> KICAD_USE_OCC=OFF
> KICAD_SPICE=OFF
>
>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Net selector

2018-10-09 Thread Eeli Kaikkonen
ma 8. lokak. 2018 klo 15.29 Jeff Young (j...@rokeby.ie) kirjoitti:

> How’s that Net Selector working these days?  Is all good, or are people
> just tired of reporting issues with it? ;)
>
>
Filter doesn't work as expected, it replaces the previous typed character
with the next one, there's always only one character in the Filter field.
It filters according to that last typed character.

Eeli Kaikkonen

Application: kicad
Version: (6.0.0-rc1-dev-714-g3024ded91), debug build
Libraries:
wxWidgets 3.0.3
Platform: Linux 4.13.0-46-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
Boost: 1.62.0
Compiler: GCC 7.2.0 with C++ ABI 1011

Build settings:
USE_WX_GRAPHICS_CONTEXT=OFF
USE_WX_OVERLAY=OFF
KICAD_SCRIPTING=ON
KICAD_SCRIPTING_MODULES=ON
KICAD_SCRIPTING_WXPYTHON=ON
KICAD_SCRIPTING_ACTION_MENU=ON
BUILD_GITHUB_PLUGIN=OFF
KICAD_USE_OCE=OFF
KICAD_USE_OCC=OFF
KICAD_SPICE=OFF
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp