Re: [Kicad-developers] [PATCH] Print stacktrace when SIGSEGV or SIGABRT appears
On 25/09/2018 19:53, Thomas Pointhuber wrote: > Hi Wayne, > > thanks for reminder. I implemented a simple compile time switch to allow > maintainers to enable/disable crash reporting. Hi Thomas, I had a look at your branch and I think it's ready to merge with one exception - the default wx crash report dialog [1] is just, say, "sub-optimal" in terms of user experience. It doesn't even tell the user the program has just crashed, it doesn't provide any information what to do with the crash report (i.e. where to send it) nor even says we're sorry for the likely loss of unsaved data. I made a variant of the dialog that (hopefully) is easier to understand. This raises another question: do we have any means of reporting bugs without forcing the users to register on launchpad, for example a public Kicad bug email (e.g. b...@kicad-pcb.org?). @Wayne, what do you think about such solution? Cheers, Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 5.1
Hi Wayne, On 10/25/18 5:17 PM, Wayne Stambaugh wrote: [snip] > I looked at this and it only works for linux. Although it may be highly > unlikely, given that wxpython and wxwidgets can be build against gtk on > windows and msys2 provides gtk2, gtk3, and as of a few days ago gtk4 > packages, there is always the possibility that this could happen on > windows. Since msys2 builds use wx-config, this shouldn't be a > difficult change. wxWidgets linked against GTK on Windows sounds so unlikely that I have not even considered this as a possibility. That being said, GTK is available on Windows so indeed it may happen one day. I have fixed that part to prevent potential complaints. >>> Hi Orson- >>> >>> It looks like this overwrites the user's preference for GTK toolkit. >>> I'd like to keep the ability to specify which toolkit I compile against >>> if possible. >>> >>> Best- >>> Seth >> >> I will add such option, but keep in mind that pcbnew will be broken if >> wxWidgets and wxPython use different toolkits. Note that the toolkit >> version is enforced only on Linux and when KICAD_SCRIPTING_WXPYTHON is >> enabled. > > You should always respect the devs preference even though it may be > incorrect. A simple check to see if wxWidgets_CONFIG_OPTIONS has > already been defined should suffice. If you are really feeling > motivated, a warning to the uninformed developer would be useful. Sure I am motivated! The current version adds --toolkit parameter only when the builder has not specified it. There is also a warning displayed when the requested toolkit does not match the one used by wxPython, but nothing stops you from completing the build and experiencing the issues on your own skin. Cheers, Orson signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 5.1
On 10/25/2018 2:37 AM, Maciej Sumiński wrote: > On 10/25/18 2:23 AM, Seth Hillbrand wrote: >> Am 2018-10-24 17:20, schrieb Maciej Suminski: >>> Actually I was pretty sure that my approach is bullet-proof, but perhaps >>> I do not get where the trap is hidden. As far as I understand, Seth >>> experienced problems when pcbnew (wxWidgets/gtk2) loaded wxPython shared >>> libraries (wxWidgets/gtk3), which end up in symbol conflicts. >>> >>> This issue is eliminated in my branch by ensuring KiCad requests the >>> same wxWidgets flavor as is used by wxPython. I might be lacking >>> explanation skills, but code is unambiguous - have a look at [1], lines >>> 746 and 775. I looked at this and it only works for linux. Although it may be highly unlikely, given that wxpython and wxwidgets can be build against gtk on windows and msys2 provides gtk2, gtk3, and as of a few days ago gtk4 packages, there is always the possibility that this could happen on windows. Since msys2 builds use wx-config, this shouldn't be a difficult change. >> >> Hi Orson- >> >> It looks like this overwrites the user's preference for GTK toolkit. >> I'd like to keep the ability to specify which toolkit I compile against >> if possible. >> >> Best- >> Seth > > I will add such option, but keep in mind that pcbnew will be broken if > wxWidgets and wxPython use different toolkits. Note that the toolkit > version is enforced only on Linux and when KICAD_SCRIPTING_WXPYTHON is > enabled. You should always respect the devs preference even though it may be incorrect. A simple check to see if wxWidgets_CONFIG_OPTIONS has already been defined should suffice. If you are really feeling motivated, a warning to the uninformed developer would be useful. > > Cheers, > Orson > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 5.1
On 10/25/18 2:23 AM, Seth Hillbrand wrote: > Am 2018-10-24 17:20, schrieb Maciej Suminski: >> Actually I was pretty sure that my approach is bullet-proof, but perhaps >> I do not get where the trap is hidden. As far as I understand, Seth >> experienced problems when pcbnew (wxWidgets/gtk2) loaded wxPython shared >> libraries (wxWidgets/gtk3), which end up in symbol conflicts. >> >> This issue is eliminated in my branch by ensuring KiCad requests the >> same wxWidgets flavor as is used by wxPython. I might be lacking >> explanation skills, but code is unambiguous - have a look at [1], lines >> 746 and 775. > > Hi Orson- > > It looks like this overwrites the user's preference for GTK toolkit. > I'd like to keep the ability to specify which toolkit I compile against > if possible. > > Best- > Seth I will add such option, but keep in mind that pcbnew will be broken if wxWidgets and wxPython use different toolkits. Note that the toolkit version is enforced only on Linux and when KICAD_SCRIPTING_WXPYTHON is enabled. Cheers, Orson signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
