Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

[Adam Wolf]

I did not test it, but reading over it, it looks great.  Thanks!

Adam

On Tue, Jun 11, 2019 at 1:41 PM Adam Wolf  wrote:
>
> I will review today.
>
> Thanks for your help, Seppe!
>
> On Tue, Jun 11, 2019, 10:11 AM Wayne Stambaugh  wrote:
>>
>> Seppe,
>>
>> Your patch looks good to me.  Any MacOS devs care to comment?
>>
>> Cheers,
>>
>> Wayne
>>
>> On 6/11/19 10:46 AM, Seppe Stas wrote:
>> > Hey Wayne
>> >
>> > I attached my patch (generated with `git format-patch --attach
>> > origin/master`) to my last email as
>> > per http://www.kicad-pcb.org/contribute/developers/#_submitting_patches.
>> > I have a feeling Gmail might not like the mail headers in the patch.
>> >
>> > I created a new patch without the --attach option and added it to this
>> > email (I am more used to this patch format and I believe it worked in
>> > the past).
>> >
>> > Greetings
>> > Seppe
>> >
>> > On Tue, Jun 11, 2019 at 4:27 PM Wayne Stambaugh > > > wrote:
>> >
>> > Seppe,
>> >
>> > I don't understand why your emails keep ending up on the moderated list
>> > but something strange is going on.  I had to moderate this one as well.
>> >  Please attach your patch (created using `git format-patch`) so it can
>> > be reviewed and commented on.
>> >
>> > Cheers,
>> >
>> > Wayne
>> >
>> > On 6/11/19 10:17 AM, Seppe Stas wrote:
>> > > Hey
>> > >
>> > > I closed the merge request on Launchpad and re-attached the patch and
>> > > before and after screenshots (the after being built from a dirty
>> > master
>> > > branch) to this mail:
>> > >
>> > > Before:
>> > > [image: Screenshot 2019-06-05 at 22.46.43.png]
>> > > After:
>> > > [image: Screenshot 2019-06-05 at 22.46.54.png]
>> > >
>> > > As you can see, having this version information displayed in 
>> > Spotlight
>> > > makes choosing the correct KiCad version a lot easier. It works
>> > for the
>> > > other apps (EEschema, PCBNew, ...) as well.
>> > >
>> > > Greetings
>> > > Seppe
>> > >
>> > > On Tue, Jun 11, 2019 at 2:50 PM Seth Hillbrand > > > wrote:
>> > >
>> > >> Hi Seppe-
>> > >>
>> > >> I see this e-mail.  Perhaps it was a launchpad hiccup.
>> > >>
>> > >> I've added Adam to the code review at [1].  Would you mind 
>> > re-sending
>> > >> the images to the list?
>> > >>
>> > >> Thanks-
>> > >> Seth
>> > >>
>> > >> [1]
>> > https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644
>> > >>
>> > >> On 2019-06-11 05:23, Seppe Stas wrote:
>> > >>> Hey
>> > >>>
>> > >>> I'm not sure if this email got ignored or if it got rejected by 
>> > some
>> > >>> mailing system, but it does not seem to show up in the mailing list
>> > >>> archive
>> > >>> .
>> > >>>
>> > >>> Maybe now it works?
>> > >>>
>> > >>> Seppe
>> > >>>
>> > >>> On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas > > > wrote:
>> > >>>
>> >  Hey guys and girls (probably mostly Adam in particular)
>> > 
>> >  Attached is a patch that sets the version in all MacOS apps to the
>> >  value
>> >  of KICAD_VERSION, i.e the value of git describe. See commit 
>> > message
>> >  for
>> >  more technical details. This version show up when e.g launching 
>> > the
>> >  app
>> >  using spotlight, and during the migration period from KiCad 4
>> > to KiCad
>> >  5
>> >  (that is still going on) I really miss(ed) this feature, since
>> > I have
>> >  3
>> >  different versions of KiCad on my system (4, 5 and master).
>> > 
>> >  See attached screenshots:
>> >  [image: Screenshot 2019-06-05 at 22.46.54.png]
>> >  [image: Screenshot 2019-06-05 at 22.46.43.png]
>> > 
>> >  I tested this patch on both the latest master (6f8a0a4ee) and
>> > the 5.1
>> >  branch (cd6da987c). I hope you consider adding it to a KiCad 5
>> > release
>> >  so I
>> >  can use it when KiCad 6 comes out. (I hope I finished migrating to
>> >  KiCad 5
>> >  by then).
>> > 
>> >  Note that in order to update this value, CMake has to be
>> > re-run, but I
>> >  would not expect this to be a big problem since I assume the
>> > releases
>> >  are
>> >  always built from scratch.
>> > 
>> >  Greeting
>> >  Seppe Stas
>> > 
>> > >>>
>> > >>> ___
>> > >>> Mailing list: https://launchpad.net/~kicad-developers
>> > >>> Post to : kicad-developers@lists.launchpad.net
>> > 
>> > >>> Unsubscribe : 

Re: [Kicad-developers] CMake KICAD_SCRIPTING Options Hierarchy

[Anton Lazarev]

Just want to chime in with my own report, as I ran into this earlier
today as well.

I was trying to run a quick build for the first time, and in the
interest of decreasing compile time and avoiding installing too many
libraries, I figured disabling a few features would help - since I
didn't already have SWIG installed, I immediately looked to disable
KICAD_SCRIPTING. It was surprising to me that the build still didn't
work, especially since the warning that KICAD_SCRIPTING is turned back
on is far away from the actual Cmake error.

Once I found this, I disabled KICAD_SCRIPTING_MODULES. Cmake failed once
more, then I disabled KICAD_SCRIPTING_ACTION_MENU and was able to begin
a build - which failed at 68% with the following error:

/home/antonok/code/kicad/pcbnew/pcbnew.cpp: In member function ‘virtual void 
PCB::IFACE::OnKifaceEnd()’:
/home/antonok/code/kicad/pcbnew/pcbnew.cpp:372:9: error: 
‘pcbnewFinishPythonScripting’ was not declared in this scope
 pcbnewFinishPythonScripting();
 ^~~

At that point I had to dive into the source code to figure out to also
disable KICAD_SCRIPTING_WXPYTHON as well.

I definitely wouldn't consider that process challenging, but I can
imagine some users might encounter some variation of the same issue and
get discouraged from helping further.

- Anton

On Tue, Jun 11, 2019 at 04:28:17PM +0100, Ian McInerney wrote:
> Wayne,
> 
> Thanks for the clarification. It just seemed somewhat odd to me to have
> them override scripting to on when all were on by default. Also, thanks for
> updating the dev docs to represent the changes.
> 
> On a similar note, it appears that none of the other scripting defines have
> their dependency on KICAD_SCRIPTING in the cmake file, so you could
> potentially compile with wxpython on and scripting off and get a build
> error. I doubt that anyone will try this, but it might be nice to at least
> make those behave similarly to the action menu/module scripting defines (so
> they automatically turn on KICAD_SCRIPTING when they are enabled). I will
> put a patch for that together once I finish up some other work.
> 
> -Ian
> 
> On Thu, Jun 6, 2019 at 5:07 PM Wayne Stambaugh  wrote:
> 
> > Hey Ian
> >
> > On 6/5/19 1:03 PM, Ian McInerney wrote:
> > > I was just noticing based on a post on the kicad forums that the CMake
> > > script will forcefully enable KICAD_SCRIPTING if either
> > > KICAD_SCRIPTING_ACTION_MENUS or KICAD_SCRIPTING_MODULES is turned on.
> > > This means to really disable scripting the user has to explicitly force
> > > all 3 to off (since they are all on by default). Is there are reason for
> > > making those two options take priority over the overall scripting
> > > support option instead of having KICAD_SCRIPTING take priority and
> > > disable those two when it is disabled? It seems more intuitive if
> > > KICAD_SCRIPTING has overall control of the scripting environment, and
> > > the others are dependent upon it.
> >
> > KICAD_SCRIPTIN_MODULES and KICAD_SCRIPTING_ACTION_MENUS depend on
> > KICAD_SCRIPTING being built so it has to be enabled.  However,
> > KICAD_SCRIPTING does not depend on the other two so it can be enabled by
> > itself.
> >
> > >
> > > This hierarchy is not actually mentioned in any of the build docs
> > > here
> > http://docs.kicad-pcb.org/doxygen/md_Documentation_development_compiling.html
> >  (and
> > > the docs seem to be slightly out of date also, since they say
> > > KICAD_SCRIPTING_ACTION_MENU defaults to off when it is actually on by
> > > default), so if nothing else it would be good to mention it in the build
> > > docs so people who really don't want scripting know to disable all 3.
> >
> > I will update the compiling doc to reflect this.
> >
> > Wayne
> >
> > >
> > > -Ian
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > > Post to : kicad-developers@lists.launchpad.net
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > More help   : https://help.launchpad.net/ListHelp
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >

> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Debuggers, boost and std::deque

[Jeff Young]

I also found a new experimental feature in CLion: Enable natvis renderers for 
LLDB.

Doesn’t seem to help though.  I wonder if I need to load natvis files somewhere?


> On 11 Jun 2019, at 21:16, Bernhard Stegmaier  wrote:
> 
> I wouldn’t try this.
> macOS switched to libc++ long time ago.
> I don’t know how it is today but I had a really hard time with unpredictable 
> results/crashes/linking errors back when I started with KiCad and (due to not 
> knowing anything about it) had libraries compiled with libstdc++ and libc++ 
> mixed. Some stuff like strings were not compatible causing a lot of fun.
> 
> 
> Regards,
> Bernhard
> 
> 
>> On 11. Jun 2019, at 21:53, Jeff Young > > wrote:
>> 
>> I found this in a CLion blog:
>> 
>> This feature works in GCC, and in the case of Clang it works for libstdc++ 
>> only. This requires the following setting to be added to CMakeLists.txt:
>> 
>> set(CMAKE_CXX_FLAGS “${CMAKE_CXX_FLAGS} -stdlib=libstdc++”)
>> I’m not sure what the alternative to libstdc++ is.  Anyone know what we use?
>> 
>>> On 11 Jun 2019, at 19:21, Seth Hillbrand >> > wrote:
>>> 
>>> On 2019-06-11 13:23, Jeff Young wrote:
 Do other folks debuggers have a hard time with these?  Mine won’t show
 me the contents of an OPT item, and it consistently lies about the
 size() of a std::deque.
 Cheers,
 Jeff.
>>> 
>>> Hi Jeff-
>>> 
>>> I use this [1] in gdb for STL containers.  Also, check out [2] for working 
>>> with BOOST if your gdb is >7.0
>>> 
>>> Best-
>>> Seth
>>> 
>>> 
>>> [1] http://sourceware.org/ml/gdb/2008-02/msg00064.html 
>>> 
>>> [2] https://github.com/ruediger/Boost-Pretty-Printer 
>>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

[Nick Østergaard]

Yes, that was the same commit I tested as mentioned earlier. Although
somehow added a "not" in the original message :)

On Tue, 11 Jun 2019 at 00:52, Wayne Stambaugh  wrote:
>
> Did you test the latest commit 2745a95b6b02c3864d6594503cc21619691cdd94?
>
> On 6/10/19 6:02 PM, Nick Østergaard wrote:
> > It didn't seem to work for the use case I described on windows last week.
> >
> > On Mon, 10 Jun 2019 at 23:51, Wayne Stambaugh  wrote:
> >>
> >> Hey Tom,
> >>
> >> On 6/4/2019 12:31 PM, Tomasz Wlostowski wrote:
> >>> On 04/06/2019 17:11, Tomasz Wlostowski wrote:
> >>>
>  Hi Wayne,
> 
>  It looks like I screwed up the exception handler under KiCad windows
>  shell. Will fix soon.
> >>>
> >>> Fixed in my github branch.
> >>>
> >>> T.
> >>>
> >>
> >> I just finished testing this on windows (32 and 64 bit) and it appears
> >> to work fine when launched from KiCad and stand alone mode.  I only
> >> tested it using your provided force crash menu entry so I don't know if
> >> it will work with a crash other than that.  Too bad the gcc windows
> >> build crash report doesn't have a stack trace.  Maybe MSVC builds would
> >> have more debug info.  It looks like it's ready to be merged for further
> >> testing.
> >>
> >> Cheers,
> >>
> >> Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Debuggers, boost and std::deque

[Bernhard Stegmaier]

I wouldn’t try this.
macOS switched to libc++ long time ago.
I don’t know how it is today but I had a really hard time with unpredictable 
results/crashes/linking errors back when I started with KiCad and (due to not 
knowing anything about it) had libraries compiled with libstdc++ and libc++ 
mixed. Some stuff like strings were not compatible causing a lot of fun.


Regards,
Bernhard


> On 11. Jun 2019, at 21:53, Jeff Young  wrote:
> 
> I found this in a CLion blog:
> 
> This feature works in GCC, and in the case of Clang it works for libstdc++ 
> only. This requires the following setting to be added to CMakeLists.txt:
> 
> set(CMAKE_CXX_FLAGS “${CMAKE_CXX_FLAGS} -stdlib=libstdc++”)
> I’m not sure what the alternative to libstdc++ is.  Anyone know what we use?
> 
>> On 11 Jun 2019, at 19:21, Seth Hillbrand > > wrote:
>> 
>> On 2019-06-11 13:23, Jeff Young wrote:
>>> Do other folks debuggers have a hard time with these?  Mine won’t show
>>> me the contents of an OPT item, and it consistently lies about the
>>> size() of a std::deque.
>>> Cheers,
>>> Jeff.
>> 
>> Hi Jeff-
>> 
>> I use this [1] in gdb for STL containers.  Also, check out [2] for working 
>> with BOOST if your gdb is >7.0
>> 
>> Best-
>> Seth
>> 
>> 
>> [1] http://sourceware.org/ml/gdb/2008-02/msg00064.html 
>> 
>> [2] https://github.com/ruediger/Boost-Pretty-Printer 
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] PATCH pcbnew half-rotate actions and shortcuts

[Jon Evans]

Just wanted to hop in and say that the features you describe for layer
selections is something I'm already working on for V6 (natively, not via
Python script), but that doesn't preclude making it possible to do similar
things via scripting too!

-Jon

On Tue, Jun 11, 2019 at 3:34 PM John Beard  wrote:

> On 10/06/2019 23:35, Andrew Lutsenko wrote:
>
> > If adding 2 new default shortcuts is not ideal maybe there is a way to
> > have these as actions with no shortcuts and let the user choose if they
> > want to use them and assign any shortcut they want.Is that technically
> > supported with current hotkey framework?
>
> This is supported by the framework, but there will need to be additional
> UI for the "alt-step rotate" command to set the angle. Unless we just
> use half the the normal angle (so 45 by default).
>
> However, I'm not really sure throwing in hundreds of useful-to-some
> actions across the program is really a great policy.
>
> I'd like to be able to bind hotkeys to Python scripts [1]. For maximum
> usefulness, parameters to the script are needed. So you don't need a
> "rotate 45" and a "rotate -45" script, for example, you just need a
> "rotate" script.
>
> I can especially see this being useful for layer selections: there are
> very many (we already have 10 in the layer context menu) of potentially
> useful layer sets. E.g. a user might want to quickly
> (enable|disable|toggle|set opacity) on some subset of layers at once,
> and making an action for each one is doomed to fail. And which layers
> are important is very dependent on the user and the PCB in question.
>
> In this case, it's not reasonable for KiCad to ship an action for every
> possible layer option. But if a script can apply any combination, and
> also set the opacity and whatever, that's a very very powerful UI.
>
> KiCad IMO should ship an excellent set of actions for "normal" users,
> and advanced users should be allowed to extend the action palette with
> their own customised actions [2].
>
> Cheers,
>
> John
>
> [1]: Actually I'd "like" a "KiScript" hooked in over a message bus, so I
> can send a command "select from U* where pin_count > 20; rotate 45;
> zoom_fit selection; show_layer *.Cu; hide_layer *.SilkS;" from anywhere.
> But that's a whole language, and probably not a good idea at all! Also
> needs a concurrent access data model.
>
> [2]: E.g. "place a inverting amp here using a 741 and 10k R1 and unity
> gain" and it generates and plonks a pre-drawn schematic right there with
> all the right parts. Or a resistor array just how you like it.
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Debuggers, boost and std::deque

[Jeff Young]

I found this in a CLion blog:

This feature works in GCC, and in the case of Clang it works for libstdc++ 
only. This requires the following setting to be added to CMakeLists.txt:

set(CMAKE_CXX_FLAGS “${CMAKE_CXX_FLAGS} -stdlib=libstdc++”)
I’m not sure what the alternative to libstdc++ is.  Anyone know what we use?

> On 11 Jun 2019, at 19:21, Seth Hillbrand  wrote:
> 
> On 2019-06-11 13:23, Jeff Young wrote:
>> Do other folks debuggers have a hard time with these?  Mine won’t show
>> me the contents of an OPT item, and it consistently lies about the
>> size() of a std::deque.
>> Cheers,
>> Jeff.
> 
> Hi Jeff-
> 
> I use this [1] in gdb for STL containers.  Also, check out [2] for working 
> with BOOST if your gdb is >7.0
> 
> Best-
> Seth
> 
> 
> [1] http://sourceware.org/ml/gdb/2008-02/msg00064.html
> [2] https://github.com/ruediger/Boost-Pretty-Printer

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 Hotkey problems

[Ian McInerney]

Seth,

I am not sure about if they would cause usability issues on other platforms
(it could be that they don't, since there have been no reports about it),
but I do see a downside/idiosyncrasy with having them duplicated.
Currently, the 5.1 hotkey configuration tools have no idea which tool is
enabled/disabled when other tools are active. This means that its duplicate
key detection (that is currently included in 5.1.2) flags any actions with
the same key code as a duplicate when the user enters the code. Therefore,
a user is prevented from entering two items with the same key, so they
would not be able to enter the key combinations currently in the defaults.
That to me seems like an odd way to ship things, since the defaults are not
achievable just through the user entering keys (aside from the reset to
defaults button). On a side note, it also means that the patch I just sent
will always flag it as invalid since I just used the existing check
duplicate function, meaning the user will see it as an error if that patch
is included.

Perhaps in 6.0 the duplicate detection can be made smarter by including
knowledge about which actions are disabled when others are active. Then it
could only check for duplicates in the actions that could be activated.

-Ian

On Tue, Jun 11, 2019 at 7:40 PM Seth Hillbrand  wrote:

> Hi Ian-
>
> On 2019-06-11 12:56, Ian McInerney wrote:
> > Somewhat in relation to the patch I just sent, 5.1 currently has some
> > hotkey issues with the default hotkeys that are being shipped with it,
> > namely with pcbnew where:
> > Paste is a duplicate hotkey of Add Microvia (both have Ctrl-V)
> > Add a similar zone has an invalid hotkey (it is currently ctrl+shift+.
> > )
> > Routing options has an invalid hotkey (it is currently ctrl+shift+, )
> >
> > The invalid hotkeys I think can be modified to simply be the upper
> > symbol of those keys, so:
> > Add a similar zone: ctrl+>
> > Routing options: ctrl+<
>
> These make sense to me.  I suspect that the greater-than/less-than
> symbol is fairly accessible on most keyboards.
>
> > As for the duplicate, what hotkey should add microvia be moved to?
>
> I think that the microvia hotkey is OK here as it is only enabled when
> paste is disabled, specifically when we are routing.  I don't think
> that's a duplicate.  Both actions seem to work appropriately for me when
> using pcbnew.  Do they cause issues on non-Linux platforms?
>
> -Seth
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] PATCH pcbnew half-rotate actions and shortcuts

[John Beard]

On 10/06/2019 23:35, Andrew Lutsenko wrote:

If adding 2 new default shortcuts is not ideal maybe there is a way to 
have these as actions with no shortcuts and let the user choose if they 
want to use them and assign any shortcut they want.Is that technically 
supported with current hotkey framework?


This is supported by the framework, but there will need to be additional 
UI for the "alt-step rotate" command to set the angle. Unless we just 
use half the the normal angle (so 45 by default).


However, I'm not really sure throwing in hundreds of useful-to-some 
actions across the program is really a great policy.


I'd like to be able to bind hotkeys to Python scripts [1]. For maximum 
usefulness, parameters to the script are needed. So you don't need a 
"rotate 45" and a "rotate -45" script, for example, you just need a 
"rotate" script.


I can especially see this being useful for layer selections: there are 
very many (we already have 10 in the layer context menu) of potentially 
useful layer sets. E.g. a user might want to quickly 
(enable|disable|toggle|set opacity) on some subset of layers at once, 
and making an action for each one is doomed to fail. And which layers 
are important is very dependent on the user and the PCB in question.


In this case, it's not reasonable for KiCad to ship an action for every 
possible layer option. But if a script can apply any combination, and 
also set the opacity and whatever, that's a very very powerful UI.


KiCad IMO should ship an excellent set of actions for "normal" users, 
and advanced users should be allowed to extend the action palette with 
their own customised actions [2].


Cheers,

John

[1]: Actually I'd "like" a "KiScript" hooked in over a message bus, so I 
can send a command "select from U* where pin_count > 20; rotate 45; 
zoom_fit selection; show_layer *.Cu; hide_layer *.SilkS;" from anywhere. 
But that's a whole language, and probably not a good idea at all! Also 
needs a concurrent access data model.


[2]: E.g. "place a inverting amp here using a 741 and 10k R1 and unity 
gain" and it generates and plonks a pre-drawn schematic right there with 
all the right parts. Or a resistor array just how you like it.


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1 Hotkey problems

[Seth Hillbrand]

Hi Ian-

On 2019-06-11 12:56, Ian McInerney wrote:

Somewhat in relation to the patch I just sent, 5.1 currently has some
hotkey issues with the default hotkeys that are being shipped with it,
namely with pcbnew where:
Paste is a duplicate hotkey of Add Microvia (both have Ctrl-V)
Add a similar zone has an invalid hotkey (it is currently ctrl+shift+.
)
Routing options has an invalid hotkey (it is currently ctrl+shift+, )

The invalid hotkeys I think can be modified to simply be the upper
symbol of those keys, so:
Add a similar zone: ctrl+>
Routing options: ctrl+<


These make sense to me.  I suspect that the greater-than/less-than 
symbol is fairly accessible on most keyboards.



As for the duplicate, what hotkey should add microvia be moved to?


I think that the microvia hotkey is OK here as it is only enabled when 
paste is disabled, specifically when we are routing.  I don't think 
that's a duplicate.  Both actions seem to work appropriately for me when 
using pcbnew.  Do they cause issues on non-Linux platforms?


-Seth

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

[Adam Wolf]

I will review today.

Thanks for your help, Seppe!

On Tue, Jun 11, 2019, 10:11 AM Wayne Stambaugh  wrote:

> Seppe,
>
> Your patch looks good to me.  Any MacOS devs care to comment?
>
> Cheers,
>
> Wayne
>
> On 6/11/19 10:46 AM, Seppe Stas wrote:
> > Hey Wayne
> >
> > I attached my patch (generated with `git format-patch --attach
> > origin/master`) to my last email as
> > per http://www.kicad-pcb.org/contribute/developers/#_submitting_patches.
> > I have a feeling Gmail might not like the mail headers in the patch.
> >
> > I created a new patch without the --attach option and added it to this
> > email (I am more used to this patch format and I believe it worked in
> > the past).
> >
> > Greetings
> > Seppe
> >
> > On Tue, Jun 11, 2019 at 4:27 PM Wayne Stambaugh  > > wrote:
> >
> > Seppe,
> >
> > I don't understand why your emails keep ending up on the moderated
> list
> > but something strange is going on.  I had to moderate this one as
> well.
> >  Please attach your patch (created using `git format-patch`) so it
> can
> > be reviewed and commented on.
> >
> > Cheers,
> >
> > Wayne
> >
> > On 6/11/19 10:17 AM, Seppe Stas wrote:
> > > Hey
> > >
> > > I closed the merge request on Launchpad and re-attached the patch
> and
> > > before and after screenshots (the after being built from a dirty
> > master
> > > branch) to this mail:
> > >
> > > Before:
> > > [image: Screenshot 2019-06-05 at 22.46.43.png]
> > > After:
> > > [image: Screenshot 2019-06-05 at 22.46.54.png]
> > >
> > > As you can see, having this version information displayed in
> Spotlight
> > > makes choosing the correct KiCad version a lot easier. It works
> > for the
> > > other apps (EEschema, PCBNew, ...) as well.
> > >
> > > Greetings
> > > Seppe
> > >
> > > On Tue, Jun 11, 2019 at 2:50 PM Seth Hillbrand  > > wrote:
> > >
> > >> Hi Seppe-
> > >>
> > >> I see this e-mail.  Perhaps it was a launchpad hiccup.
> > >>
> > >> I've added Adam to the code review at [1].  Would you mind
> re-sending
> > >> the images to the list?
> > >>
> > >> Thanks-
> > >> Seth
> > >>
> > >> [1]
> > https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644
> > >>
> > >> On 2019-06-11 05:23, Seppe Stas wrote:
> > >>> Hey
> > >>>
> > >>> I'm not sure if this email got ignored or if it got rejected by
> some
> > >>> mailing system, but it does not seem to show up in the mailing
> list
> > >>> archive
> > >>> .
> > >>>
> > >>> Maybe now it works?
> > >>>
> > >>> Seppe
> > >>>
> > >>> On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas  > > wrote:
> > >>>
> >  Hey guys and girls (probably mostly Adam in particular)
> > 
> >  Attached is a patch that sets the version in all MacOS apps to
> the
> >  value
> >  of KICAD_VERSION, i.e the value of git describe. See commit
> message
> >  for
> >  more technical details. This version show up when e.g launching
> the
> >  app
> >  using spotlight, and during the migration period from KiCad 4
> > to KiCad
> >  5
> >  (that is still going on) I really miss(ed) this feature, since
> > I have
> >  3
> >  different versions of KiCad on my system (4, 5 and master).
> > 
> >  See attached screenshots:
> >  [image: Screenshot 2019-06-05 at 22.46.54.png]
> >  [image: Screenshot 2019-06-05 at 22.46.43.png]
> > 
> >  I tested this patch on both the latest master (6f8a0a4ee) and
> > the 5.1
> >  branch (cd6da987c). I hope you consider adding it to a KiCad 5
> > release
> >  so I
> >  can use it when KiCad 6 comes out. (I hope I finished migrating
> to
> >  KiCad 5
> >  by then).
> > 
> >  Note that in order to update this value, CMake has to be
> > re-run, but I
> >  would not expect this to be a big problem since I assume the
> > releases
> >  are
> >  always built from scratch.
> > 
> >  Greeting
> >  Seppe Stas
> > 
> > >>>
> > >>> ___
> > >>> Mailing list: https://launchpad.net/~kicad-developers
> > >>> Post to : kicad-developers@lists.launchpad.net
> > 
> > >>> Unsubscribe : https://launchpad.net/~kicad-developers
> > >>> More help   : https://help.launchpad.net/ListHelp
> > >>
> > >
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > > Post to : 

Re: [Kicad-developers] PATCH pcbnew half-rotate actions and shortcuts

[John Beard]

Hi Mark,

On 11/06/2019 19:20, Mark Roszko wrote:
Idea: quick tap of R just does 90. Long press R and it pops open a tiny 
dialog with focus to enter a rotation number and then you can hit enter 
and it just sets the rotation angle directly on the footprint 
properties.


Ctrl+M will already do this (x, y = 0, theta = 45), and, moreover the 
last transform is retained, so the second time, it's is just "Ctrl+M, 
enter".


Setting rotation directly on the item will be possible with the Object 
Inspector.


However I don't know if KiCad's hotkey system can tolerate timing based 
shortcuts.


Not as far as I know. It would be pretty steep in terms of 
discoverability, I think, and long pressing gets frustrating quickly (I 
find on my phone).


Better IMO, if we're really short on hotkey real estate, would be 
"modal" or "chained" hotkeys, so Ctrl+R,H for half rotate.


Cheers,

John

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Debuggers, boost and std::deque

[Seth Hillbrand]

On 2019-06-11 13:23, Jeff Young wrote:

Do other folks debuggers have a hard time with these?  Mine won’t show
me the contents of an OPT item, and it consistently lies about the
size() of a std::deque.

Cheers,
Jeff.


Hi Jeff-

I use this [1] in gdb for STL containers.  Also, check out [2] for 
working with BOOST if your gdb is >7.0


Best-
Seth


[1] http://sourceware.org/ml/gdb/2008-02/msg00064.html
[2] https://github.com/ruediger/Boost-Pretty-Printer

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] PATCH pcbnew half-rotate actions and shortcuts

[Mark Roszko]

Idea: quick tap of R just does 90. Long press R and it pops open a tiny
dialog with focus to enter a rotation number and then you can hit enter and
it just sets the rotation angle directly on the footprint properties. This
significantly reduces clicking and leaves it flexible for those that don't
want to just half rotate. Who knows, maybe someone has a board where all
the parts need to be rotated by 15 degrees.

However I don't know if KiCad's hotkey system can tolerate timing based
shortcuts.

On Mon, Jun 10, 2019 at 7:19 PM Andrew Lutsenko 
wrote:

> In Pcbnew that is already the case, shift+R rotates the other way around.
> Eeschema doesn't have that shortcut.
>
> On Mon, Jun 10, 2019 at 4:15 PM Kevin Cozens  wrote:
>
>> On 2019-06-10 6:35 p.m., Andrew Lutsenko wrote:
>> > I like to keep rotation angle set to 90 because that covers 98% of
>> cases and
>> > is it's faster to press R two or three times instead of 4 or 6 times (I
>> > frequently go the wrong way around since unfortunately R in pcbnew
>> rotates
>> > ccw and R in eeschema rotates cw, that is something that should be made
>> > consistent).
>>
>> Hm... I can't say I had really noticed that the rotation directions are
>> opposite between the two. After a quick test I noticed that you can
>> rotate
>> something in the default direction but if you go too far you have to hit
>> R
>> more times to "back up".
>>
>> It would be useful to have R to do rotations in one direction and either
>> Ctrl+R or Shift+R to do rotations in the other.
>>
>> --
>> Cheers!
>>
>> Kevin.
>>
>> http://www.ve3syb.ca/   | "Nerds make the shiny things that
>> https://www.patreon.com/KevinCozens | distract the mouth-breathers, and
>>  | that's why we're powerful"
>> Owner of Elecraft K2 #2172  |
>> #include  | --Chris Hardwick
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


-- 
Mark
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Arc drawing: code vs comment

[Seth Hillbrand]

On 2019-06-11 14:00, Simon Richter wrote:

Hi,

I just stumbled across

/* Please NOTE the different sign due to Y-axis flip */
start.x = centre.x + KiROUND( cosdecideg( radius, -StAngle ) );
start.y = centre.y + KiROUND( sindecideg( radius, -StAngle ) );

at common/plotters/plotter.cpp:164.

Is that comment obsolete, or is there a bug here?


Neither.  It is referring to the -stAngle.  This flips the sin result 
sign but not the cos result.  Perhaps it would be more clear if we used 
positive angle and flipped the sign in front of KiROUND but the outcome 
is the same.


-S

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Arc drawing: code vs comment

[Simon Richter]

Hi,

I just stumbled across

/* Please NOTE the different sign due to Y-axis flip */
start.x = centre.x + KiROUND( cosdecideg( radius, -StAngle ) );
start.y = centre.y + KiROUND( sindecideg( radius, -StAngle ) );

at common/plotters/plotter.cpp:164.

Is that comment obsolete, or is there a bug here?

   Simon

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Debuggers, boost and std::deque

[Wayne Stambaugh]

Jeff,

I wonder if your debugger isn't getting confused by the context
switching?  I see some pretty strange looking back traces after a
context switch in gdb that can make debugging difficult.

Wayne

On 6/11/19 1:23 PM, Jeff Young wrote:
> Do other folks debuggers have a hard time with these?  Mine won’t show me the 
> contents of an OPT item, and it consistently lies about the size() of a 
> std::deque.
> 
> Cheers,
> Jeff.
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Debuggers, boost and std::deque

[Jeff Young]

Do other folks debuggers have a hard time with these?  Mine won’t show me the 
contents of an OPT item, and it consistently lies about the size() of a 
std::deque.

Cheers,
Jeff.
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

[Jeff Young]

CMake is black magic to me.  I wouldn’t know if this were the best thing since 
sliced bread or the return of the plague. ;)

Cheers,
Jeff.


> On 11 Jun 2019, at 16:11, Wayne Stambaugh  wrote:
> 
> Seppe,
> 
> Your patch looks good to me.  Any MacOS devs care to comment?
> 
> Cheers,
> 
> Wayne
> 
> On 6/11/19 10:46 AM, Seppe Stas wrote:
>> Hey Wayne
>> 
>> I attached my patch (generated with `git format-patch --attach
>> origin/master`) to my last email as
>> per http://www.kicad-pcb.org/contribute/developers/#_submitting_patches.
>> I have a feeling Gmail might not like the mail headers in the patch.
>> 
>> I created a new patch without the --attach option and added it to this
>> email (I am more used to this patch format and I believe it worked in
>> the past).
>> 
>> Greetings
>> Seppe
>> 
>> On Tue, Jun 11, 2019 at 4:27 PM Wayne Stambaugh > >> wrote:
>> 
>>Seppe,
>> 
>>I don't understand why your emails keep ending up on the moderated list
>>but something strange is going on.  I had to moderate this one as well.
>> Please attach your patch (created using `git format-patch`) so it can
>>be reviewed and commented on.
>> 
>>Cheers,
>> 
>>Wayne
>> 
>>On 6/11/19 10:17 AM, Seppe Stas wrote:
>>> Hey
>>> 
>>> I closed the merge request on Launchpad and re-attached the patch and
>>> before and after screenshots (the after being built from a dirty
>>master
>>> branch) to this mail:
>>> 
>>> Before:
>>> [image: Screenshot 2019-06-05 at 22.46.43.png]
>>> After:
>>> [image: Screenshot 2019-06-05 at 22.46.54.png]
>>> 
>>> As you can see, having this version information displayed in Spotlight
>>> makes choosing the correct KiCad version a lot easier. It works
>>for the
>>> other apps (EEschema, PCBNew, ...) as well.
>>> 
>>> Greetings
>>> Seppe
>>> 
>>> On Tue, Jun 11, 2019 at 2:50 PM Seth Hillbrand >> 
>>>> wrote:
>>> 
 Hi Seppe-
 
 I see this e-mail.  Perhaps it was a launchpad hiccup.
 
 I've added Adam to the code review at [1].  Would you mind re-sending
 the images to the list?
 
 Thanks-
 Seth
 
 [1]
>>https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644 
>> 
 
 On 2019-06-11 05:23, Seppe Stas wrote:
> Hey
> 
> I'm not sure if this email got ignored or if it got rejected by some
> mailing system, but it does not seem to show up in the mailing list
> archive
>  >.
> 
> Maybe now it works?
> 
> Seppe
> 
> On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas  
>>>> wrote:
> 
>> Hey guys and girls (probably mostly Adam in particular)
>> 
>> Attached is a patch that sets the version in all MacOS apps to the
>> value
>> of KICAD_VERSION, i.e the value of git describe. See commit message
>> for
>> more technical details. This version show up when e.g launching the
>> app
>> using spotlight, and during the migration period from KiCad 4
>>to KiCad
>> 5
>> (that is still going on) I really miss(ed) this feature, since
>>I have
>> 3
>> different versions of KiCad on my system (4, 5 and master).
>> 
>> See attached screenshots:
>> [image: Screenshot 2019-06-05 at 22.46.54.png]
>> [image: Screenshot 2019-06-05 at 22.46.43.png]
>> 
>> I tested this patch on both the latest master (6f8a0a4ee) and
>>the 5.1
>> branch (cd6da987c). I hope you consider adding it to a KiCad 5
>>release
>> so I
>> can use it when KiCad 6 comes out. (I hope I finished migrating to
>> KiCad 5
>> by then).
>> 
>> Note that in order to update this value, CMake has to be
>>re-run, but I
>> would not expect this to be a big problem since I assume the
>>releases
>> are
>> always built from scratch.
>> 
>> Greeting
>> Seppe Stas
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
>>> >
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
 
>>> 
>>> 
>>> ___
>>> Mailing list: 

[Kicad-developers] 5.1 Hotkey problems

[Ian McInerney]

Somewhat in relation to the patch I just sent, 5.1 currently has some
hotkey issues with the default hotkeys that are being shipped with it,
namely with pcbnew where:
Paste is a duplicate hotkey of Add Microvia (both have Ctrl-V)
Add a similar zone has an invalid hotkey (it is currently ctrl+shift+. )
Routing options has an invalid hotkey (it is currently ctrl+shift+, )

The invalid hotkeys I think can be modified to simply be the upper symbol
of those keys, so:
Add a similar zone: ctrl+>
Routing options: ctrl+<

As for the duplicate, what hotkey should add microvia be moved to?

-Ian
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [Patch] Hotkey validation/checking for 5.1

[Ian McInerney]

Attached is a patch that adds in hotkey validation/checking to the 5.1
branch. This will display error messages with the hotkeys when the user
edits the hotkeys, and notifies the user that there are invalid hotkeys
when viewing the list. It also checks imported files for their validity,
and warns the user when errors are found.

Currently, it does not check on startup of the program. It will only check
when a user is already editing/viewing the hotkeys. The only time this
actively prevents the user from doing something is when they enter an
invalid hotkey when changing a hotkey, other than that it is a notification
system.

I have been on the fence about adding a startup check of the hotkeys that
will then direct the user to the preferences menu to fix them, but in 5.1
that would be so scattered it would be somewhat painful to do it nicely.

This does not apply to the master branch currently, since Jeff just pushed
the start of the hotkey infrastructure rework to it. Eventually I do want
to add this to master, but I need to analyze his changes first and figure
out the best way of implementing it on the new framework.

-Ian
From 560176efe371ba20721ef21c361bc8cb4e6ad44e Mon Sep 17 00:00:00 2001
From: Ian McInerney 
Date: Tue, 11 Jun 2019 17:38:00 +0100
Subject: [PATCH] Added hotkey validity checking to the preferences menu

---
 common/dialogs/panel_hotkeys_editor.cpp |  90 --
 common/hotkey_store.cpp | 108 -
 common/widgets/widget_hotkey_list.cpp   | 119 +---
 include/hotkey_store.h  |  91 +-
 include/panel_hotkeys_editor.h  |  20 
 include/widgets/widget_hotkey_list.h|  25 -
 6 files changed, 421 insertions(+), 32 deletions(-)

diff --git a/common/dialogs/panel_hotkeys_editor.cpp b/common/dialogs/panel_hotkeys_editor.cpp
index 21e0082b9..26d7796dd 100644
--- a/common/dialogs/panel_hotkeys_editor.cpp
+++ b/common/dialogs/panel_hotkeys_editor.cpp
@@ -21,13 +21,16 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include 
+#include 
+#include 
 #include 
+#include 
 
-#include 
-#include 
 #include 
+#include 
 #include 
+#include 
+#include 
 
 #include 
 #include 
@@ -70,7 +73,33 @@ PANEL_HOTKEYS_EDITOR::PANEL_HOTKEYS_EDITOR( EDA_BASE_FRAME* aFrame, wxWindow* aW
 m_hotkeyStore( aShowHotkeys )
 {
 const auto margin = KIUI::GetStdMargin();
-auto mainSizer = new wxBoxSizer( wxVERTICAL );
+
+m_mainSizer = new wxBoxSizer( wxVERTICAL );
+m_errorMessageSizer = new wxBoxSizer( wxVERTICAL );
+
+// Setup the sub-sizer to contain the bitmap and header text
+wxBoxSizer* errImgHeadSizer = new wxBoxSizer( wxHORIZONTAL );
+
+wxStaticBitmap* valid_img = new wxStaticBitmap(
+this, wxID_ANY, KiBitmap( cancel_xpm ), wxDefaultPosition, wxDefaultSize, 0 );
+wxStaticText* err_head = new wxStaticText( this, wxID_ANY, _( "Hotkey errors detected" ),
+wxDefaultPosition, wxDefaultSize, wxALIGN_LEFT );
+errImgHeadSizer->Add( valid_img, 0, wxALL, 5 );
+errImgHeadSizer->Add( err_head, 0, wxALL | wxALIGN_CENTER_VERTICAL, 5 );
+m_errorMessageSizer->Add( errImgHeadSizer, 0, wxTOP | wxLEFT | wxRIGHT, margin );
+
+// Setup the error message to give the user information about any problems with the hotkeys,
+// but only do this if they can actually change them
+if( !m_readOnly )
+{
+m_errorMessage = new wxStaticText(
+this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, wxALIGN_LEFT );
+m_errorMessageSizer->Add( m_errorMessage, 0, wxALL, 5 );
+}
+m_errorMessageSizer->Add( new wxStaticLine( this ), 0, wxALL | wxEXPAND, 2 );
+
+// Add the validity text to the main sizer and hide the entire sizer
+m_mainSizer->Add( m_errorMessageSizer, 0, wxTOP | wxLEFT | wxRIGHT | wxEXPAND, margin );
 
 // Sub-sizer for setting a wider side margin
 // TODO: Can this be set by the parent widget- doesn't seem to be
@@ -87,9 +116,9 @@ PANEL_HOTKEYS_EDITOR::PANEL_HOTKEYS_EDITOR( EDA_BASE_FRAME* aFrame, wxWindow* aW
 if( !m_readOnly )
 installButtons( bMargins );
 
-mainSizer->Add( bMargins, 1, wxEXPAND | wxRIGHT | wxLEFT, side_margins );
+m_mainSizer->Add( bMargins, 1, wxEXPAND | wxRIGHT | wxLEFT, side_margins );
 
-this->SetSizer( mainSizer );
+this->SetSizer( m_mainSizer );
 this->Layout();
 
 // Connect Events
@@ -125,7 +154,7 @@ void PANEL_HOTKEYS_EDITOR::installButtons( wxSizer* aSizer )
 _( "Import..." ),
 _( "Import hotkey definitions from an external file, replacing the current values" ),
 [this]( wxCommandEvent& ){
-m_frame->ImportHotkeyConfigFromFile( m_hotkeys, m_nickname );
+onImportHotkeyConfigFromFile();
 }
 },
 {
@@ -144,6 +173,22 @@ void PANEL_HOTKEYS_EDITOR::installButtons( wxSizer* aSizer )
 }
 
 
+void 

Re: [Kicad-developers] Latest info on copper zones using solid polygons without outline thickness.

[Tomasz Wlostowski]

On 09/06/2019 20:51, jp charras wrote:
> First, thanks Tom for your test.
> 
> But are the drawing issues (calculation time and memory overflow) fixed
> by this change?
> They were the main reason of this change.

Yes, the VBO out-of-memory issue is gone now. I haven't measured yet how
much memory we saved but it's ~50% at least (given 6 vertices per
outline segment). Also, the connectivity calculation time got ~30%
better (31 seconds for the old, 20 s for the new one). Great job JP!.

> * Unless bugs, plot functions are updated and are compatible with both
> zone filling algos.

OK, didn't check it.
> 
> * The file format keep trace of the zone filling algo that filled the
> zone (of course, because do not know how the zone was filled can create
> serious issues):
> the flag " (filled_areas_thickness no)" is added in the zone section
> when the fill algo is "do not use thick outline".
> It also ensure a "old" Pcbnew version cannot create broken Gerber files.

OK.
> 
> * The accessor to know the fill algo used to fill the zone is:
>  bool GetFilledPolysUseThickness() const
> that returns false for the new algo.

> 
> * I was not aware of the connectivity issue. Please, fix it.
> Thanks.
> 
Fixed, thanks for the hint. I'll push my changes later in the evening.

> * About the zone setup dialog:
> For me, the choice is temporary, until we are confident with the new algo.
> Usually, when a new option is added, the default choice is: keep the old
> behavior.
> It avoid many bug reports.
> However make the new algo the default could be the best way to test it...
> I am not thrilled by messages like "Use legacy ..." because only core
> developpers know the difference between "legacy" and "current" or "new"
> about algorithms.

OK, in this case I wouldn't use the term 'higher quality', it might be
misleading to many users and make them think the new algorithm is
somewhat inferior to the old one.

Tom


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] CMake KICAD_SCRIPTING Options Hierarchy

[Ian McInerney]

Wayne,

Thanks for the clarification. It just seemed somewhat odd to me to have
them override scripting to on when all were on by default. Also, thanks for
updating the dev docs to represent the changes.

On a similar note, it appears that none of the other scripting defines have
their dependency on KICAD_SCRIPTING in the cmake file, so you could
potentially compile with wxpython on and scripting off and get a build
error. I doubt that anyone will try this, but it might be nice to at least
make those behave similarly to the action menu/module scripting defines (so
they automatically turn on KICAD_SCRIPTING when they are enabled). I will
put a patch for that together once I finish up some other work.

-Ian

On Thu, Jun 6, 2019 at 5:07 PM Wayne Stambaugh  wrote:

> Hey Ian
>
> On 6/5/19 1:03 PM, Ian McInerney wrote:
> > I was just noticing based on a post on the kicad forums that the CMake
> > script will forcefully enable KICAD_SCRIPTING if either
> > KICAD_SCRIPTING_ACTION_MENUS or KICAD_SCRIPTING_MODULES is turned on.
> > This means to really disable scripting the user has to explicitly force
> > all 3 to off (since they are all on by default). Is there are reason for
> > making those two options take priority over the overall scripting
> > support option instead of having KICAD_SCRIPTING take priority and
> > disable those two when it is disabled? It seems more intuitive if
> > KICAD_SCRIPTING has overall control of the scripting environment, and
> > the others are dependent upon it.
>
> KICAD_SCRIPTIN_MODULES and KICAD_SCRIPTING_ACTION_MENUS depend on
> KICAD_SCRIPTING being built so it has to be enabled.  However,
> KICAD_SCRIPTING does not depend on the other two so it can be enabled by
> itself.
>
> >
> > This hierarchy is not actually mentioned in any of the build docs
> > here
> http://docs.kicad-pcb.org/doxygen/md_Documentation_development_compiling.html
>  (and
> > the docs seem to be slightly out of date also, since they say
> > KICAD_SCRIPTING_ACTION_MENU defaults to off when it is actually on by
> > default), so if nothing else it would be good to mention it in the build
> > docs so people who really don't want scripting know to disable all 3.
>
> I will update the compiling doc to reflect this.
>
> Wayne
>
> >
> > -Ian
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

[Wayne Stambaugh]

Seppe,

Your patch looks good to me.  Any MacOS devs care to comment?

Cheers,

Wayne

On 6/11/19 10:46 AM, Seppe Stas wrote:
> Hey Wayne
> 
> I attached my patch (generated with `git format-patch --attach
> origin/master`) to my last email as
> per http://www.kicad-pcb.org/contribute/developers/#_submitting_patches.
> I have a feeling Gmail might not like the mail headers in the patch.
> 
> I created a new patch without the --attach option and added it to this
> email (I am more used to this patch format and I believe it worked in
> the past).
> 
> Greetings
> Seppe
> 
> On Tue, Jun 11, 2019 at 4:27 PM Wayne Stambaugh  > wrote:
> 
> Seppe,
> 
> I don't understand why your emails keep ending up on the moderated list
> but something strange is going on.  I had to moderate this one as well.
>  Please attach your patch (created using `git format-patch`) so it can
> be reviewed and commented on.
> 
> Cheers,
> 
> Wayne
> 
> On 6/11/19 10:17 AM, Seppe Stas wrote:
> > Hey
> >
> > I closed the merge request on Launchpad and re-attached the patch and
> > before and after screenshots (the after being built from a dirty
> master
> > branch) to this mail:
> >
> > Before:
> > [image: Screenshot 2019-06-05 at 22.46.43.png]
> > After:
> > [image: Screenshot 2019-06-05 at 22.46.54.png]
> >
> > As you can see, having this version information displayed in Spotlight
> > makes choosing the correct KiCad version a lot easier. It works
> for the
> > other apps (EEschema, PCBNew, ...) as well.
> >
> > Greetings
> > Seppe
> >
> > On Tue, Jun 11, 2019 at 2:50 PM Seth Hillbrand  > wrote:
> >
> >> Hi Seppe-
> >>
> >> I see this e-mail.  Perhaps it was a launchpad hiccup.
> >>
> >> I've added Adam to the code review at [1].  Would you mind re-sending
> >> the images to the list?
> >>
> >> Thanks-
> >> Seth
> >>
> >> [1]
> https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644
> >>
> >> On 2019-06-11 05:23, Seppe Stas wrote:
> >>> Hey
> >>>
> >>> I'm not sure if this email got ignored or if it got rejected by some
> >>> mailing system, but it does not seem to show up in the mailing list
> >>> archive
> >>> .
> >>>
> >>> Maybe now it works?
> >>>
> >>> Seppe
> >>>
> >>> On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas  > wrote:
> >>>
>  Hey guys and girls (probably mostly Adam in particular)
> 
>  Attached is a patch that sets the version in all MacOS apps to the
>  value
>  of KICAD_VERSION, i.e the value of git describe. See commit message
>  for
>  more technical details. This version show up when e.g launching the
>  app
>  using spotlight, and during the migration period from KiCad 4
> to KiCad
>  5
>  (that is still going on) I really miss(ed) this feature, since
> I have
>  3
>  different versions of KiCad on my system (4, 5 and master).
> 
>  See attached screenshots:
>  [image: Screenshot 2019-06-05 at 22.46.54.png]
>  [image: Screenshot 2019-06-05 at 22.46.43.png]
> 
>  I tested this patch on both the latest master (6f8a0a4ee) and
> the 5.1
>  branch (cd6da987c). I hope you consider adding it to a KiCad 5
> release
>  so I
>  can use it when KiCad 6 comes out. (I hope I finished migrating to
>  KiCad 5
>  by then).
> 
>  Note that in order to update this value, CMake has to be
> re-run, but I
>  would not expect this to be a big problem since I assume the
> releases
>  are
>  always built from scratch.
> 
>  Greeting
>  Seppe Stas
> 
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : kicad-developers@lists.launchpad.net
> 
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@lists.launchpad.net
> 

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

[Seppe Stas]

Hey Wayne

I attached my patch (generated with `git format-patch --attach
origin/master`) to my last email as per
http://www.kicad-pcb.org/contribute/developers/#_submitting_patches. I have
a feeling Gmail might not like the mail headers in the patch.

I created a new patch without the --attach option and added it to this
email (I am more used to this patch format and I believe it worked in the
past).

Greetings
Seppe

On Tue, Jun 11, 2019 at 4:27 PM Wayne Stambaugh 
wrote:

> Seppe,
>
> I don't understand why your emails keep ending up on the moderated list
> but something strange is going on.  I had to moderate this one as well.
>  Please attach your patch (created using `git format-patch`) so it can
> be reviewed and commented on.
>
> Cheers,
>
> Wayne
>
> On 6/11/19 10:17 AM, Seppe Stas wrote:
> > Hey
> >
> > I closed the merge request on Launchpad and re-attached the patch and
> > before and after screenshots (the after being built from a dirty master
> > branch) to this mail:
> >
> > Before:
> > [image: Screenshot 2019-06-05 at 22.46.43.png]
> > After:
> > [image: Screenshot 2019-06-05 at 22.46.54.png]
> >
> > As you can see, having this version information displayed in Spotlight
> > makes choosing the correct KiCad version a lot easier. It works for the
> > other apps (EEschema, PCBNew, ...) as well.
> >
> > Greetings
> > Seppe
> >
> > On Tue, Jun 11, 2019 at 2:50 PM Seth Hillbrand 
> wrote:
> >
> >> Hi Seppe-
> >>
> >> I see this e-mail.  Perhaps it was a launchpad hiccup.
> >>
> >> I've added Adam to the code review at [1].  Would you mind re-sending
> >> the images to the list?
> >>
> >> Thanks-
> >> Seth
> >>
> >> [1]
> https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644
> >>
> >> On 2019-06-11 05:23, Seppe Stas wrote:
> >>> Hey
> >>>
> >>> I'm not sure if this email got ignored or if it got rejected by some
> >>> mailing system, but it does not seem to show up in the mailing list
> >>> archive
> >>> .
> >>>
> >>> Maybe now it works?
> >>>
> >>> Seppe
> >>>
> >>> On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas 
> wrote:
> >>>
>  Hey guys and girls (probably mostly Adam in particular)
> 
>  Attached is a patch that sets the version in all MacOS apps to the
>  value
>  of KICAD_VERSION, i.e the value of git describe. See commit message
>  for
>  more technical details. This version show up when e.g launching the
>  app
>  using spotlight, and during the migration period from KiCad 4 to KiCad
>  5
>  (that is still going on) I really miss(ed) this feature, since I have
>  3
>  different versions of KiCad on my system (4, 5 and master).
> 
>  See attached screenshots:
>  [image: Screenshot 2019-06-05 at 22.46.54.png]
>  [image: Screenshot 2019-06-05 at 22.46.43.png]
> 
>  I tested this patch on both the latest master (6f8a0a4ee) and the 5.1
>  branch (cd6da987c). I hope you consider adding it to a KiCad 5 release
>  so I
>  can use it when KiCad 6 comes out. (I hope I finished migrating to
>  KiCad 5
>  by then).
> 
>  Note that in order to update this value, CMake has to be re-run, but I
>  would not expect this to be a big problem since I assume the releases
>  are
>  always built from scratch.
> 
>  Greeting
>  Seppe Stas
> 
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


0001-Set-KiCad-version-in-MacOS-apps.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

[Wayne Stambaugh]

Seppe,

I don't understand why your emails keep ending up on the moderated list
but something strange is going on.  I had to moderate this one as well.
 Please attach your patch (created using `git format-patch`) so it can
be reviewed and commented on.

Cheers,

Wayne

On 6/11/19 10:17 AM, Seppe Stas wrote:
> Hey
> 
> I closed the merge request on Launchpad and re-attached the patch and
> before and after screenshots (the after being built from a dirty master
> branch) to this mail:
> 
> Before:
> [image: Screenshot 2019-06-05 at 22.46.43.png]
> After:
> [image: Screenshot 2019-06-05 at 22.46.54.png]
> 
> As you can see, having this version information displayed in Spotlight
> makes choosing the correct KiCad version a lot easier. It works for the
> other apps (EEschema, PCBNew, ...) as well.
> 
> Greetings
> Seppe
> 
> On Tue, Jun 11, 2019 at 2:50 PM Seth Hillbrand  wrote:
> 
>> Hi Seppe-
>>
>> I see this e-mail.  Perhaps it was a launchpad hiccup.
>>
>> I've added Adam to the code review at [1].  Would you mind re-sending
>> the images to the list?
>>
>> Thanks-
>> Seth
>>
>> [1] https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644
>>
>> On 2019-06-11 05:23, Seppe Stas wrote:
>>> Hey
>>>
>>> I'm not sure if this email got ignored or if it got rejected by some
>>> mailing system, but it does not seem to show up in the mailing list
>>> archive
>>> .
>>>
>>> Maybe now it works?
>>>
>>> Seppe
>>>
>>> On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas  wrote:
>>>
 Hey guys and girls (probably mostly Adam in particular)

 Attached is a patch that sets the version in all MacOS apps to the
 value
 of KICAD_VERSION, i.e the value of git describe. See commit message
 for
 more technical details. This version show up when e.g launching the
 app
 using spotlight, and during the migration period from KiCad 4 to KiCad
 5
 (that is still going on) I really miss(ed) this feature, since I have
 3
 different versions of KiCad on my system (4, 5 and master).

 See attached screenshots:
 [image: Screenshot 2019-06-05 at 22.46.54.png]
 [image: Screenshot 2019-06-05 at 22.46.43.png]

 I tested this patch on both the latest master (6f8a0a4ee) and the 5.1
 branch (cd6da987c). I hope you consider adding it to a KiCad 5 release
 so I
 can use it when KiCad 6 comes out. (I hope I finished migrating to
 KiCad 5
 by then).

 Note that in order to update this value, CMake has to be re-run, but I
 would not expect this to be a big problem since I assume the releases
 are
 always built from scratch.

 Greeting
 Seppe Stas

>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

[Seppe Stas]

Hey

I closed the merge request on Launchpad and re-attached the patch and
before and after screenshots (the after being built from a dirty master
branch) to this mail:

Before:
[image: Screenshot 2019-06-05 at 22.46.43.png]
After:
[image: Screenshot 2019-06-05 at 22.46.54.png]

As you can see, having this version information displayed in Spotlight
makes choosing the correct KiCad version a lot easier. It works for the
other apps (EEschema, PCBNew, ...) as well.

Greetings
Seppe

On Tue, Jun 11, 2019 at 2:50 PM Seth Hillbrand  wrote:

> Hi Seppe-
>
> I see this e-mail.  Perhaps it was a launchpad hiccup.
>
> I've added Adam to the code review at [1].  Would you mind re-sending
> the images to the list?
>
> Thanks-
> Seth
>
> [1] https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644
>
> On 2019-06-11 05:23, Seppe Stas wrote:
> > Hey
> >
> > I'm not sure if this email got ignored or if it got rejected by some
> > mailing system, but it does not seem to show up in the mailing list
> > archive
> > .
> >
> > Maybe now it works?
> >
> > Seppe
> >
> > On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas  wrote:
> >
> >> Hey guys and girls (probably mostly Adam in particular)
> >>
> >> Attached is a patch that sets the version in all MacOS apps to the
> >> value
> >> of KICAD_VERSION, i.e the value of git describe. See commit message
> >> for
> >> more technical details. This version show up when e.g launching the
> >> app
> >> using spotlight, and during the migration period from KiCad 4 to KiCad
> >> 5
> >> (that is still going on) I really miss(ed) this feature, since I have
> >> 3
> >> different versions of KiCad on my system (4, 5 and master).
> >>
> >> See attached screenshots:
> >> [image: Screenshot 2019-06-05 at 22.46.54.png]
> >> [image: Screenshot 2019-06-05 at 22.46.43.png]
> >>
> >> I tested this patch on both the latest master (6f8a0a4ee) and the 5.1
> >> branch (cd6da987c). I hope you consider adding it to a KiCad 5 release
> >> so I
> >> can use it when KiCad 6 comes out. (I hope I finished migrating to
> >> KiCad 5
> >> by then).
> >>
> >> Note that in order to update this value, CMake has to be re-run, but I
> >> would not expect this to be a big problem since I assume the releases
> >> are
> >> always built from scratch.
> >>
> >> Greeting
> >> Seppe Stas
> >>
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Build errors

[John Beard]

Hi Wayne,

On 11/06/2019 14:15, Wayne Stambaugh wrote:

As of the commit b9e07f2a706b719a5f86b6372c5a7cda2f6a7c55 I am getting
the following build errors on linux using clang:


I just fixed these in 1e4abac57 as they were blocking me.

The first one, I bisected down to c13ef839c, though I do not see why 
that would cause it but it's probably another manifestation of the 
longstanding gal<->common circular dependencies [1] that were exposed 
somehow. The fix I put in is a pretty poor one, but it Works for Me (TM) 
and Jenkins went off OK too [2]. Better suggestions welcome, but as 
usual, the real fix probably requires fixing libcommon's units.


The other two seem fairly vanilla build breakages from some kind of 
platform differences in string conversions and include paths respectively.


Friendly reminder: this page should be solid green:
https://jenkins.simonrichter.eu/view/KiCad%20Status/

Cheers,

John

[1]: https://bugs.launchpad.net/kicad/+bug/1832229
[2]: https://jenkins.simonrichter.eu/job/linux-kicad-head/3129/

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Build errors

[Wayne Stambaugh]

As of the commit b9e07f2a706b719a5f86b6372c5a7cda2f6a7c55 I am getting
the following build errors on linux using clang:

/usr/bin/ld: ../common/libgal.a(view_overlay.cpp.o): in function
`COMMAND_POLY_POLYGON':
/home/wayne/src/kicad-trunk/common/view/view_overlay.cpp:177: undefined
reference to `SHAPE_POLY_SET::SHAPE_POLY_SET(SHAPE_POLY_SET const&, bool)'
/usr/bin/ld: ../common/libgal.a(view_overlay.cpp.o): in function
`~COMMAND_POLY_POLYGON':
/home/wayne/src/kicad-trunk/common/view/view_overlay.cpp:174: undefined
reference to `SHAPE_POLY_SET::~SHAPE_POLY_SET()'
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
make[2]: *** [kicad/CMakeFiles/kicad.dir/build.make:262: kicad/kicad]
Error 1
make[1]: *** [CMakeFiles/Makefile2:2666: kicad/CMakeFiles/kicad.dir/all]
Error 2
make[1]: *** Waiting for unfinished jobs


/home/wayne/src/kicad-trunk/pcbnew/exporters/export_vrml.cpp:50:10:
fatal error:
  'kicad/kicad_manager_frame.h' file not found
#include "kicad/kicad_manager_frame.h"
 ^
1 error generated.
make[2]: ***
[pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/build.make:1804:
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/exporters/export_vrml.cpp.o]
Error 1
make[2]: *** Waiting for unfinished jobs


/home/wayne/src/kicad-trunk/pcbnew/router/length_tuner_tool.cpp:52:20:
error:
  no matching constructor for initialization of 'TOOL_ACTION'
static TOOL_ACTION ACT_EndTuning( "pcbnew.LengthTuner.EndTuning",
   ^  ~~~
/home/wayne/src/kicad-trunk/include/tool/tool_action.h:49:5: note: candidate
  constructor not viable: no known conversion from 'const wxString' to
  'const std::string' (aka 'const basic_string') for 4th argument
TOOL_ACTION( const std::string& aName, TOOL_ACTION_SCOPE aScope = AS...
^
/home/wayne/src/kicad-trunk/include/tool/tool_action.h:46:7: note: candidate
  constructor (the implicit copy constructor) not viable: requires 1
  argument, but 5 were provided
class TOOL_ACTION
  ^

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

[Seth Hillbrand]

Hi Seppe-

I see this e-mail.  Perhaps it was a launchpad hiccup.

I've added Adam to the code review at [1].  Would you mind re-sending 
the images to the list?


Thanks-
Seth

[1] https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644

On 2019-06-11 05:23, Seppe Stas wrote:

Hey

I'm not sure if this email got ignored or if it got rejected by some
mailing system, but it does not seem to show up in the mailing list 
archive

.

Maybe now it works?

Seppe

On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas  wrote:


Hey guys and girls (probably mostly Adam in particular)

Attached is a patch that sets the version in all MacOS apps to the 
value
of KICAD_VERSION, i.e the value of git describe. See commit message 
for
more technical details. This version show up when e.g launching the 
app
using spotlight, and during the migration period from KiCad 4 to KiCad 
5
(that is still going on) I really miss(ed) this feature, since I have 
3

different versions of KiCad on my system (4, 5 and master).

See attached screenshots:
[image: Screenshot 2019-06-05 at 22.46.54.png]
[image: Screenshot 2019-06-05 at 22.46.43.png]

I tested this patch on both the latest master (6f8a0a4ee) and the 5.1
branch (cd6da987c). I hope you consider adding it to a KiCad 5 release 
so I
can use it when KiCad 6 comes out. (I hope I finished migrating to 
KiCad 5

by then).

Note that in order to update this value, CMake has to be re-run, but I
would not expect this to be a big problem since I assume the releases 
are

always built from scratch.

Greeting
Seppe Stas



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

[Seppe Stas]

Hey

I'm not sure if this email got ignored or if it got rejected by some
mailing system, but it does not seem to show up in the mailing list archive
.

Maybe now it works?

Seppe

On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas  wrote:

> Hey guys and girls (probably mostly Adam in particular)
>
> Attached is a patch that sets the version in all MacOS apps to the value
> of KICAD_VERSION, i.e the value of git describe. See commit message for
> more technical details. This version show up when e.g launching the app
> using spotlight, and during the migration period from KiCad 4 to KiCad 5
> (that is still going on) I really miss(ed) this feature, since I have 3
> different versions of KiCad on my system (4, 5 and master).
>
> See attached screenshots:
> [image: Screenshot 2019-06-05 at 22.46.54.png]
> [image: Screenshot 2019-06-05 at 22.46.43.png]
>
> I tested this patch on both the latest master (6f8a0a4ee) and the 5.1
> branch (cd6da987c). I hope you consider adding it to a KiCad 5 release so I
> can use it when KiCad 6 comes out. (I hope I finished migrating to KiCad 5
> by then).
>
> Note that in order to update this value, CMake has to be re-run, but I
> would not expect this to be a big problem since I assume the releases are
> always built from scratch.
>
> Greeting
> Seppe Stas
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp