Re: [Kicad-developers] 5.1.5 RC?
I did nothing with kicad mac builder, but good news I guess! :) Adam On Fri, Aug 30, 2019, 9:41 PM Jonatan Liljedahl wrote: > On Fri, Aug 30, 2019 at 7:57 PM Nick Østergaard wrote: > > > > Att. Wayne and Adam > > > > According to Jonatans testing in > > https://bugs.launchpad.net/kicad/+bug/1841752/comments/9 > > > > It looks like ngspice-30 do work for him on the latest nightlies... > > > > Next step, checking if the 5.1 branch testing builds are ok with > ngspice-30. > > > > If that works it may be because of some kicad-mac-builder changes that > > fixed something. (I didn't try to correlate this) > > Seems something was fixed! Because > kicad-5.1-unified-20190830-121212-c1f9abc98-10_14.dmg works fine here, > and it's running libngspice-30. > > Cheers > -- > /Jonatan > http://kymatica.com > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 5.1.5 RC?
On Fri, Aug 30, 2019 at 7:57 PM Nick Østergaard wrote: > > Att. Wayne and Adam > > According to Jonatans testing in > https://bugs.launchpad.net/kicad/+bug/1841752/comments/9 > > It looks like ngspice-30 do work for him on the latest nightlies... > > Next step, checking if the 5.1 branch testing builds are ok with ngspice-30. > > If that works it may be because of some kicad-mac-builder changes that > fixed something. (I didn't try to correlate this) Seems something was fixed! Because kicad-5.1-unified-20190830-121212-c1f9abc98-10_14.dmg works fine here, and it's running libngspice-30. Cheers -- /Jonatan http://kymatica.com ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Multiple delete in dialog_spice_model.cpp
Yeah, the guys that wrote the standard template library could have won awards
in obfuscation.
> On 30 Aug 2019, at 21:17, Seth Hillbrand wrote:
>
> On 2019-08-30 15:49, Sylwester Kocjan wrote:
>
>>m_schfields->erase( std::remove_if(
>> m_schfields->begin(), m_schfields->end(),
>>[&]( const SCH_FIELD& f ) { return f.GetName()
>> == spiceField; } ), m_schfields->end() );
>
>
>> My question is, why deletion is repeated: at first there is called
>> remove_if(), and later erase(), which will delete
>> all the fields behind the removed one. From my point of view it looks
>> like remove_if() only should be enough.
>
>
> remove_if() re-orders the container and returns the iterator that points to
> the first matching element. erase() removes all elements from this iterator
> through the end of the container.
>
> See https://en.wikipedia.org/wiki/Erase%E2%80%93remove_idiom
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Multiple delete in dialog_spice_model.cpp
On 2019-08-30 15:49, Sylwester Kocjan wrote:
m_schfields->erase( std::remove_if(
m_schfields->begin(), m_schfields->end(),
[&]( const SCH_FIELD& f ) { return f.GetName()
== spiceField; } ), m_schfields->end() );
My question is, why deletion is repeated: at first there is called
remove_if(), and later erase(), which will delete
all the fields behind the removed one. From my point of view it looks
like remove_if() only should be enough.
remove_if() re-orders the container and returns the iterator that points
to the first matching element. erase() removes all elements from this
iterator through the end of the container.
See https://en.wikipedia.org/wiki/Erase%E2%80%93remove_idiom
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Multiple delete in dialog_spice_model.cpp
Hi KiCad-devs & Seth,
I was looking at the code for handling spice fields and I noticed
something that I either don't understand or is unnecessary. In this
commit:
https://github.com/KiCad/kicad-source-mirror/commit/170ff66cbbd4f17ebf6fddf24efa7b4d227c15a1
there was a change added in dialog_spice_model.cpp:241-246, which is
present in current master branch. This is how it looks right now:
// Apply the settings
for( int i = 0; i < SF_END; ++i )
{
if( m_fieldsTmp.count( (SPICE_FIELD) i ) > 0 && !m_fieldsTmp.at( i
).IsEmpty() )
{
if( m_useSchFields )
getSchField( i ).SetText( m_fieldsTmp[i] );
else
getLibField( i ).SetText( m_fieldsTmp[i] );
}
else
{
// Erase empty fields (having empty fields causes a warning in the
properties dialog)
const wxString& spiceField =
NETLIST_EXPORTER_PSPICE::GetSpiceFieldName( (SPICE_FIELD) i );
if( m_useSchFields )
m_schfields->erase( std::remove_if( m_schfields->begin(),
m_schfields->end(),
[&]( const SCH_FIELD& f ) { return f.GetName() ==
spiceField; } ), m_schfields->end() );
else
m_libfields->erase( std::remove_if( m_libfields->begin(),
m_libfields->end(),
[&]( const LIB_FIELD& f ) { return f.GetName() ==
spiceField; } ), m_libfields->end() );
}
}
In this loop we iterate over all available SPICE fields while m_fieldsTmp
contain new values to be stored.
If m_fieldsTmp is non-empty, we add a new value to the field. If it's empty, we
will delete this field.
My question is, why deletion is repeated: at first there is called remove_if(),
and later erase(), which will delete
all the fields behind the removed one. From my point of view it looks like
remove_if() only should be enough.
Best regards,
Sylwester
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 5.1.5 RC?
Att. Wayne and Adam According to Jonatans testing in https://bugs.launchpad.net/kicad/+bug/1841752/comments/9 It looks like ngspice-30 do work for him on the latest nightlies... Next step, checking if the 5.1 branch testing builds are ok with ngspice-30. If that works it may be because of some kicad-mac-builder changes that fixed something. (I didn't try to correlate this) On Thu, 29 Aug 2019 at 18:12, Wayne Stambaugh wrote: > > If ngspice-30 is completely broken on macos, we may have no choice but > to fall back to ngspice-26. The brings the bugs that have been fixed > since ngspice-26 back into play which is less than ideal but I don't see > a solution unless there is a new release of ngspice that resolves the > issues. We should try to work with Holger to try to resolve the issues > so we can provide a solution as soon as it's available. > > Cheers, > > Wayne > > On 8/28/19 10:26 PM, Adam Wolf wrote: > > Jonathan, I hear you. I rolled back to ngspice-26 for the 5.1.4 > > release, and I think it probably makes sense to roll back to > > ngspice-26 for 5.1.5 as well. > > > > I am not really comfortable with the state of this situation. We're > > running nightlies with 30, and release with 26, but how long until > > there's a bug caused by rolling back for stable releases that we never > > see since all the nightlies are on ngspice-30? > > > > Do I simply need to make another set of builds with ngspice-30 and a > > set with ngspice-26? Is this fine? Maybe? Am I overthinking this? > > > > Wayne, dev team, packagers, everyone--what do you think? I don't have > > any skin in the game here. > > > > Adam > > > > On Wed, Aug 28, 2019 at 1:21 PM Jonatan Liljedahl > > wrote: > >> > >> It would be great if you could roll back to ngspice-26 in 5.1.5, at > >> least for macOS, since it seems completely broken (can't simulate > >> op-amps, etc). > >> > >> Cheers > >> /Jonatan > >> > >> On Wed, Aug 28, 2019 at 1:58 PM Wayne Stambaugh > >> wrote: > >>> > >>> On 8/27/19 3:56 PM, Seth Hillbrand wrote: > Hi All- > > I know 5.1.4 is still in its infancy but I am hoping that we can plan > for a 5.1.5 during September (fixing at least 2 critical bugs). We've > been a bit rocky with the point updates, so I'd like to propose a > sequence: > > 1) Sometime around September 15: Tag 5.1.5-rc1 and announce string > freeze to give give translations a chance to update and tag 5.1.5 > 2) At this point, we don't push anything to 5.1 unless it is fix for a > critical bug. No other fixes until after 5.1.5. > 3) If there is a fix for a critical bug, we tag 5.1.5-rc2 after. > 4) 7 days after the last rc2 is tagged, we tag 5.1.5 > > What do folks think about this scheme? Maybe a way to avoid the 5.1.3 > (and 5.1.1 and 5.0.1 before it) situation? > > -Seth > >>> > >>> Absolutely. I was planning on this after the last debacle. Hopefully > >>> the 5.1.5 release will go a bit more smoothly. > >>> > >>> Cheers, > >>> > >>> Wayne > >>> > >>> ___ > >>> Mailing list: https://launchpad.net/~kicad-developers > >>> Post to : kicad-developers@lists.launchpad.net > >>> Unsubscribe : https://launchpad.net/~kicad-developers > >>> More help : https://help.launchpad.net/ListHelp > >> > >> > >> > >> -- > >> /Jonatan > >> http://kymatica.com > >> > >> ___ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 5.1.5 RC?
Le 30/08/2019 à 16:35, Nick Østergaard a écrit : > What was the command that could be added the the schematic to make > ngspice print the version info about itself in the output text shown > in the bottom of the simulator window? > Hi Nick, You can try: .control version .endc It works for me with ngspice-30 -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 5.1.5 RC?
What was the command that could be added the the schematic to make ngspice print the version info about itself in the output text shown in the bottom of the simulator window? On Fri, 30 Aug 2019 at 12:45, Jonatan Liljedahl wrote: > > Thanks. I've updated with a comment on my launchpad report: > https://bugs.launchpad.net/kicad/+bug/1841752 > > Cheers > > On Thu, Aug 29, 2019 at 6:12 PM Wayne Stambaugh wrote: > > > > If ngspice-30 is completely broken on macos, we may have no choice but > > to fall back to ngspice-26. The brings the bugs that have been fixed > > since ngspice-26 back into play which is less than ideal but I don't see > > a solution unless there is a new release of ngspice that resolves the > > issues. We should try to work with Holger to try to resolve the issues > > so we can provide a solution as soon as it's available. > > > > Cheers, > > > > Wayne > > > > On 8/28/19 10:26 PM, Adam Wolf wrote: > > > Jonathan, I hear you. I rolled back to ngspice-26 for the 5.1.4 > > > release, and I think it probably makes sense to roll back to > > > ngspice-26 for 5.1.5 as well. > > > > > > I am not really comfortable with the state of this situation. We're > > > running nightlies with 30, and release with 26, but how long until > > > there's a bug caused by rolling back for stable releases that we never > > > see since all the nightlies are on ngspice-30? > > > > > > Do I simply need to make another set of builds with ngspice-30 and a > > > set with ngspice-26? Is this fine? Maybe? Am I overthinking this? > > > > > > Wayne, dev team, packagers, everyone--what do you think? I don't have > > > any skin in the game here. > > > > > > Adam > > > > > > On Wed, Aug 28, 2019 at 1:21 PM Jonatan Liljedahl > > > wrote: > > >> > > >> It would be great if you could roll back to ngspice-26 in 5.1.5, at > > >> least for macOS, since it seems completely broken (can't simulate > > >> op-amps, etc). > > >> > > >> Cheers > > >> /Jonatan > > >> > > >> On Wed, Aug 28, 2019 at 1:58 PM Wayne Stambaugh > > >> wrote: > > >>> > > >>> On 8/27/19 3:56 PM, Seth Hillbrand wrote: > > Hi All- > > > > I know 5.1.4 is still in its infancy but I am hoping that we can plan > > for a 5.1.5 during September (fixing at least 2 critical bugs). We've > > been a bit rocky with the point updates, so I'd like to propose a > > sequence: > > > > 1) Sometime around September 15: Tag 5.1.5-rc1 and announce string > > freeze to give give translations a chance to update and tag 5.1.5 > > 2) At this point, we don't push anything to 5.1 unless it is fix for a > > critical bug. No other fixes until after 5.1.5. > > 3) If there is a fix for a critical bug, we tag 5.1.5-rc2 after. > > 4) 7 days after the last rc2 is tagged, we tag 5.1.5 > > > > What do folks think about this scheme? Maybe a way to avoid the 5.1.3 > > (and 5.1.1 and 5.0.1 before it) situation? > > > > -Seth > > >>> > > >>> Absolutely. I was planning on this after the last debacle. Hopefully > > >>> the 5.1.5 release will go a bit more smoothly. > > >>> > > >>> Cheers, > > >>> > > >>> Wayne > > >>> > > >>> ___ > > >>> Mailing list: https://launchpad.net/~kicad-developers > > >>> Post to : kicad-developers@lists.launchpad.net > > >>> Unsubscribe : https://launchpad.net/~kicad-developers > > >>> More help : https://help.launchpad.net/ListHelp > > >> > > >> > > >> > > >> -- > > >> /Jonatan > > >> http://kymatica.com > > >> > > >> ___ > > >> Mailing list: https://launchpad.net/~kicad-developers > > >> Post to : kicad-developers@lists.launchpad.net > > >> Unsubscribe : https://launchpad.net/~kicad-developers > > >> More help : https://help.launchpad.net/ListHelp > > > > > > ___ > > > Mailing list: https://launchpad.net/~kicad-developers > > > Post to : kicad-developers@lists.launchpad.net > > > Unsubscribe : https://launchpad.net/~kicad-developers > > > More help : https://help.launchpad.net/ListHelp > > > > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > -- > /Jonatan > http://kymatica.com > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] 5.1.5 RC?
Thanks. I've updated with a comment on my launchpad report: https://bugs.launchpad.net/kicad/+bug/1841752 Cheers On Thu, Aug 29, 2019 at 6:12 PM Wayne Stambaugh wrote: > > If ngspice-30 is completely broken on macos, we may have no choice but > to fall back to ngspice-26. The brings the bugs that have been fixed > since ngspice-26 back into play which is less than ideal but I don't see > a solution unless there is a new release of ngspice that resolves the > issues. We should try to work with Holger to try to resolve the issues > so we can provide a solution as soon as it's available. > > Cheers, > > Wayne > > On 8/28/19 10:26 PM, Adam Wolf wrote: > > Jonathan, I hear you. I rolled back to ngspice-26 for the 5.1.4 > > release, and I think it probably makes sense to roll back to > > ngspice-26 for 5.1.5 as well. > > > > I am not really comfortable with the state of this situation. We're > > running nightlies with 30, and release with 26, but how long until > > there's a bug caused by rolling back for stable releases that we never > > see since all the nightlies are on ngspice-30? > > > > Do I simply need to make another set of builds with ngspice-30 and a > > set with ngspice-26? Is this fine? Maybe? Am I overthinking this? > > > > Wayne, dev team, packagers, everyone--what do you think? I don't have > > any skin in the game here. > > > > Adam > > > > On Wed, Aug 28, 2019 at 1:21 PM Jonatan Liljedahl > > wrote: > >> > >> It would be great if you could roll back to ngspice-26 in 5.1.5, at > >> least for macOS, since it seems completely broken (can't simulate > >> op-amps, etc). > >> > >> Cheers > >> /Jonatan > >> > >> On Wed, Aug 28, 2019 at 1:58 PM Wayne Stambaugh > >> wrote: > >>> > >>> On 8/27/19 3:56 PM, Seth Hillbrand wrote: > Hi All- > > I know 5.1.4 is still in its infancy but I am hoping that we can plan > for a 5.1.5 during September (fixing at least 2 critical bugs). We've > been a bit rocky with the point updates, so I'd like to propose a > sequence: > > 1) Sometime around September 15: Tag 5.1.5-rc1 and announce string > freeze to give give translations a chance to update and tag 5.1.5 > 2) At this point, we don't push anything to 5.1 unless it is fix for a > critical bug. No other fixes until after 5.1.5. > 3) If there is a fix for a critical bug, we tag 5.1.5-rc2 after. > 4) 7 days after the last rc2 is tagged, we tag 5.1.5 > > What do folks think about this scheme? Maybe a way to avoid the 5.1.3 > (and 5.1.1 and 5.0.1 before it) situation? > > -Seth > >>> > >>> Absolutely. I was planning on this after the last debacle. Hopefully > >>> the 5.1.5 release will go a bit more smoothly. > >>> > >>> Cheers, > >>> > >>> Wayne > >>> > >>> ___ > >>> Mailing list: https://launchpad.net/~kicad-developers > >>> Post to : kicad-developers@lists.launchpad.net > >>> Unsubscribe : https://launchpad.net/~kicad-developers > >>> More help : https://help.launchpad.net/ListHelp > >> > >> > >> > >> -- > >> /Jonatan > >> http://kymatica.com > >> > >> ___ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > > > > ___ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp -- /Jonatan http://kymatica.com ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Kicad support for Linux on PPC
On Thu, Aug 29, 2019 at 04:30:17PM +0200, Simon Richter wrote: > Hi, > > On Thu, Aug 29, 2019 at 04:27:56PM +0200, Gianluca Renzi wrote: > > > Cool! But my platform is ppc64be! :-( > > What hardware is that? I want one. Perhaps this? https://www.powerpc-notebook.org/en/ -- Marco Ciampa I know a joke about UDP, but you might not get it. GNU/Linux User #78271 FSFE fellow #364 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
