Re: [Kicad-developers] Cryptic characters in source

[Kevin Cozens]

On 2020-02-08 4:32 p.m., ja...@veith.net wrote:
My editor shows non ascii cryptic characters in master cpp source what I 
cannot see in the browser. Here it is underscore M

[snip]

Can anybody confirm this ?


Yes, I can confirm them. They are carriage return (ctrl-M) characters in the 
file.


--
Cheers!

Kevin.

http://www.ve3syb.ca/   | "Nerds make the shiny things that
https://www.patreon.com/KevinCozens | distract the mouth-breathers, and
| that's why we're powerful"
Owner of Elecraft K2 #2172  |
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Cryptic characters in source

[Christoph Moench-Tegeder]

## Brian Piccioni (br...@documenteddesigns.com):

> Perhaps I misunderstand but I don't see anything (screen grab from
> notepad++ on Windows 10)

Windows Line Endings, aka CR-LF. Unix-like systems use LF (line feed)
only, while Windows uses carriage return+line feed.
The usual representation on Linux terminals (vt100 heritage, I think)
is Ctrl-J for line feed and Ctrl-M for carriage return - thus some
"M-like" character (sometimes also shown as ^M or the like).
Git usually hides that (see setting core.autocrls), but AFAIK does
not fix it once you've got mixed endings in one file.

Regards,
Christoph

-- 
Spare Space

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Cryptic characters in source

[ja...@veith.net]

On 08.02.20 22:39, Brian Piccioni wrote:
Perhaps I misunderstand but I don't see anything (screen grab from 
notepad++ on Windows 10)


Sorry - did not recognize that its always EOL -
somebody simply opened in a Windows editor ...



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Cryptic characters in source

[Brian Piccioni]

Perhaps I misunderstand but I don't see anything (screen grab from 
notepad++ on Windows 10)


On 2020-02-08 4:32 p.m., ja...@veith.net wrote:
My editor shows non ascii cryptic characters in master cpp source what 
I cannot see in the browser. Here it is underscore M and I tried using 
Emacs what shows escape M sequences. Compare attached screendump. Much 
more of that stuff lives in _FRAME::TW_Init. Although for line 39 it 
is between = and EOL the GCC parser does not complain about.

Can anybody confirm this ?


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GCC 7.4 crash somehow related to backannotate

[Alexander Shuklin]

Hi Jon,
That's my code. Unfortunately I almost sleep. I don't see big
difference between using value_type and std::make_pair. I just tried
to be smart and used decltype to show that is the map pair. But it
doesn't change much.
Only thing I see now, that according documentation value type is
pair, but I don't think that const
qualifier will change much there.
If somebody knows better about that, please let me know, because I don't know :(

On Sat, 8 Feb 2020 at 19:33, Jon Evans  wrote:
>
> Hi all,
>
> I am running into a weird problem on GCC 7.4 / Ubuntu 18.04.1
>
> Master compiles just fine.  However, after rebasing onto latest master,
> my branch in MR90 causes an internal compiler segfault on
> eeschema/tools/backannotate.cpp:185
>
> I traced the offending line to 180.
> For some reason, this compiles OK without my extra commit, but with it, boom.
>
> I tried changing the line to a different method:
>
> m_pcbModules.insert( nearestItem,
> std::make_pair( path, std::make_shared( 
> data ) ) );
>
> And now the compiler crash is gone and everything seems ok.
>
> 1) Anyone know what is going on here?
>
> 2) Any concerns with me changing that line accordingly?  I think the version 
> with
> std::make_pair is more clear anyway.
>
> -Jon
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] GCC 7.4 crash somehow related to backannotate

[Jon Evans]

Hi all,

I am running into a weird problem on GCC 7.4 / Ubuntu 18.04.1

Master compiles just fine.  However, after rebasing onto latest master,
my branch in MR90 
causes an internal compiler segfault on
eeschema/tools/backannotate.cpp:185

I traced the offending line to 180.
For some reason, this compiles OK without my extra commit, but with it,
boom.

I tried changing the line to a different method:

m_pcbModules.insert( nearestItem,
std::make_pair( path,
std::make_shared( data ) ) );

And now the compiler crash is gone and everything seems ok.

1) Anyone know what is going on here?

2) Any concerns with me changing that line accordingly?  I think the
version with
std::make_pair is more clear anyway.

-Jon
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp