[Kicad-developers] Granularity of DRC error code
Hi all, A DRC error code is something like "Via inside keepout area", or in the code, DRCE_VIA_INSIDE_KEEPOUT. It describes a "type" of DRC error. This type is used for organizing the errors in the DRC report, and more recently, for letting you set a severity (error/warning/ignore) for each code. Currently we have a lot of DRC violation types, probably because the violation types match up to the underlying code that is doing the checking. So, we also have a DRCE_MICROVIA_INSIDE_KEEPOUT and DRCE_BBVIA_INSIDE_KEEPOUT, because a lot of KiCad code has separate paths for those three types of vias. Do people find this useful? I think it is too specific: I would rather see a single code DRCE_VIA_INSIDE_KEEPOUT to include all types of vias. I could even see having a single code for any object inside a keepout that isn't supposed to be there. I can't imagine a situation where I would want to have a via inside a keepout be an error, but a microvia inside a keepout be a warning or an ignore (having the separate error codes means you can have seperate severity settings). If I wanted to know if a particular DRC error referred to a via or a microvia, I can do that from the linked item information -- I don't need a category to tell me that. What do you think? Does having a lot of very specific error codes help your workflow? Would you miss these categories if some of them got consolidated like the example I gave? If so, are there other changes we could make (or features we could add) that would make it easier to deal with having less specific error codes? Thanks, Jon ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Sizes for bitmaps in cpp-other
Ok, I was able to extract the sizing information for these bitmaps from the existing cpp representations, however it appears that we do not have source SVGs for the tune_diff_pair_skew_legend and tune_single_track_length_legend bitmaps, we only have PNGs. Does anyone know where those two came from? -Ian On Wed, Jun 10, 2020 at 1:03 PM Ian McInerney wrote: > Does anyone know what the sizes for the bitmaps in the cpp-other folder > are? The bitmaps are: > stroke_dash > stroke_dashdot > stroke_dot > stroke_solid > tune_diff_pair_length_legend > tune_diff_pair_skew_legend > tune_single_track_length_legend > > I noticed that they are not being regenerated with the rest of the > bitmaps, we don't appear to have sizes for them defined in the bitmap cmake > file, and they are not a standard size (hence why they are in other). > > -Ian > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Symbol library work
I'm getting ready make some changes to make the new embedded library symbols easier to use and I wanted to check to make sure no one else is working on anything. Here is the list of improvements that I will be working on over the next few weeks. 1) Library symbol update/replace dialog similar to the footprint update/replace dialog in Pcbnew. 2) Modify the symbol library editor to edit library symbols in place like the footprint library editor. 3) Implement optional background symbol library change detection to highlight symbols that have library symbols that have changed from the embedded symbol. Please let me know if you are working on any that might conflict with this. Cheers, Wayne ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Exclude symbol from board feature
> On Jun 10, 2020, at 10:30 AM, Wayne Stambaugh wrote: > > I just pushed a new feature to exclude schematic symbols from being > pushed to the board on update into the master branch. I did a write up > about it on the user forum[1] if you are interested. HRAY! -a ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Exclude symbol from board feature
I just pushed a new feature to exclude schematic symbols from being pushed to the board on update into the master branch. I did a write up about it on the user forum[1] if you are interested. Cheers, Wayne [1]: https://forum.kicad.info/t/schematic-symbol-exclude-from-board/23324 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Build error
All good here. Thanks.
On 6/10/20 8:52 AM, Jeff Young wrote:
> I’ve merged an attempted fix. (Of course the previous one compiled fine on
> CLang too, so I’m not 100% confident in it -- but it seem to fit the error
> GCC was generating.)
>
>> On 10 Jun 2020, at 12:59, Wayne Stambaugh wrote:
>>
>> I forgot to mention, lead devs please do not commit any new code until
>> this gets fixed.
>>
>> On 6/10/20 7:14 AM, Wayne Stambaugh wrote:
>>> As of commit 4138c8554 I'm getting the following build error on linux.
>>>
>>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
>>> constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
>>> const wxString&)’:
>>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
>>> invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
>>> ‘_IO_FILE*’} [-fpermissive]
>>> 36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
>>> | ^~~
>>> In file included from /usr/include/wx-3.0/wx/memory.h:15,
>>> from /usr/include/wx-3.0/wx/object.h:19,
>>> from /usr/include/wx-3.0/wx/wx.h:15,
>>> from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
>>> from
>>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
>>> /usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
>>> ‘wxString::operator const void*() const’
>>> 1629 | operator const void*() const { return c_str(); }
>>> | ^~~~
>>> /usr/include/wx-3.0/wx/string.h:1629:5: note: no known conversion from
>>> ‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
>>> In file included from
>>> /home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
>>> from
>>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
>>> /home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
>>> note: initializing argument 1 of
>>> ‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
>>> 108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
>>> | ~~^
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Build error: Now compiles for me.
On Wed, Jun 10, 2020 at 3:18 PM Dino Ghilardi wrote: > > No more build error on my machine (gcc 6.3.0) > > > Cheers, > Dino. > I've been able to build master ( d7d877241 ) ok with GCC 9.3.0: Application: Pcbnew Version: (5.99.0-1936-gd7d877241), debug build Libraries: wxWidgets 3.0.4 libcurl/7.68.0 GnuTLS/3.6.13 zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh/0.9.3/openssl/zlib nghttp2/1.40.0 librtmp/2.3 Platform: Linux 5.7.0+ x86_64, 64 bit, Little endian, wxGTK Build Info: Build date: Jun 10 2020 15:35:24 wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24 Boost: 1.71.0 OCE: 6.9.1 Curl: 7.68.0 Compiler: GCC 9.3.0 with C++ ABI 1013 Build settings: KICAD_SCRIPTING=ON KICAD_SCRIPTING_MODULES=ON KICAD_SCRIPTING_PYTHON3=OFF KICAD_SCRIPTING_WXPYTHON=ON KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF KICAD_SCRIPTING_ACTION_MENU=ON BUILD_GITHUB_PLUGIN=ON KICAD_USE_OCE=ON KICAD_SPICE=ON KICAD_STDLIB_DEBUG=OFF KICAD_STDLIB_LIGHT_DEBUG=OFF KICAD_SANITIZE=OFF -drew ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Build error: Now compiles for me.
Thanks, Dino!
> On 10 Jun 2020, at 14:18, Dino Ghilardi wrote:
>
> No more build error on my machine (gcc 6.3.0)
>
>
> Cheers,
> Dino.
>
> On 10/06/20 14:52, Jeff Young wrote:
>> I’ve merged an attempted fix. (Of course the previous one compiled fine on
>> CLang too, so I’m not 100% confident in it -- but it seem to fit the error
>> GCC was generating.)
>>> On 10 Jun 2020, at 12:59, Wayne Stambaugh wrote:
>>>
>>> I forgot to mention, lead devs please do not commit any new code until
>>> this gets fixed.
>>>
>>> On 6/10/20 7:14 AM, Wayne Stambaugh wrote:
As of commit 4138c8554 I'm getting the following build error on linux.
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
const wxString&)’:
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
‘_IO_FILE*’} [-fpermissive]
36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
| ^~~
In file included from /usr/include/wx-3.0/wx/memory.h:15,
from /usr/include/wx-3.0/wx/object.h:19,
from /usr/include/wx-3.0/wx/wx.h:15,
from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
/usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
‘wxString::operator const void*() const’
1629 | operator const void*() const { return c_str(); }
| ^~~~
/usr/include/wx-3.0/wx/string.h:1629:5: note: no known conversion from
‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
In file included from
/home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
/home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
note: initializing argument 1 of
‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
| ~~^
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help : https://help.launchpad.net/ListHelp
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Build error: Now compiles for me.
No more build error on my machine (gcc 6.3.0)
Cheers,
Dino.
On 10/06/20 14:52, Jeff Young wrote:
I’ve merged an attempted fix. (Of course the previous one compiled fine on
CLang too, so I’m not 100% confident in it -- but it seem to fit the error GCC
was generating.)
On 10 Jun 2020, at 12:59, Wayne Stambaugh wrote:
I forgot to mention, lead devs please do not commit any new code until
this gets fixed.
On 6/10/20 7:14 AM, Wayne Stambaugh wrote:
As of commit 4138c8554 I'm getting the following build error on linux.
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
const wxString&)’:
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
‘_IO_FILE*’} [-fpermissive]
36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
| ^~~
In file included from /usr/include/wx-3.0/wx/memory.h:15,
from /usr/include/wx-3.0/wx/object.h:19,
from /usr/include/wx-3.0/wx/wx.h:15,
from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
/usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
‘wxString::operator const void*() const’
1629 | operator const void*() const { return c_str(); }
| ^~~~
/usr/include/wx-3.0/wx/string.h:1629:5: note: no known conversion from
‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
In file included from
/home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
/home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
note: initializing argument 1 of
‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
| ~~^
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Build error
I’ve merged an attempted fix. (Of course the previous one compiled fine on
CLang too, so I’m not 100% confident in it -- but it seem to fit the error GCC
was generating.)
> On 10 Jun 2020, at 12:59, Wayne Stambaugh wrote:
>
> I forgot to mention, lead devs please do not commit any new code until
> this gets fixed.
>
> On 6/10/20 7:14 AM, Wayne Stambaugh wrote:
>> As of commit 4138c8554 I'm getting the following build error on linux.
>>
>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
>> constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
>> const wxString&)’:
>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
>> invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
>> ‘_IO_FILE*’} [-fpermissive]
>> 36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
>> | ^~~
>> In file included from /usr/include/wx-3.0/wx/memory.h:15,
>> from /usr/include/wx-3.0/wx/object.h:19,
>> from /usr/include/wx-3.0/wx/wx.h:15,
>> from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
>> from
>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
>> /usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
>> ‘wxString::operator const void*() const’
>> 1629 | operator const void*() const { return c_str(); }
>> | ^~~~
>> /usr/include/wx-3.0/wx/string.h:1629:5: note: no known conversion from
>> ‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
>> In file included from
>> /home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
>> from
>> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
>> /home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
>> note: initializing argument 1 of
>> ‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
>> 108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
>> | ~~^
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Sizes for bitmaps in cpp-other
Does anyone know what the sizes for the bitmaps in the cpp-other folder are? The bitmaps are: stroke_dash stroke_dashdot stroke_dot stroke_solid tune_diff_pair_length_legend tune_diff_pair_skew_legend tune_single_track_length_legend I noticed that they are not being regenerated with the rest of the bitmaps, we don't appear to have sizes for them defined in the bitmap cmake file, and they are not a standard size (hence why they are in other). -Ian ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Build error
I forgot to mention, lead devs please do not commit any new code until
this gets fixed.
On 6/10/20 7:14 AM, Wayne Stambaugh wrote:
> As of commit 4138c8554 I'm getting the following build error on linux.
>
> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
> constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
> const wxString&)’:
> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
> invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
> ‘_IO_FILE*’} [-fpermissive]
>36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
> | ^~~
> In file included from /usr/include/wx-3.0/wx/memory.h:15,
> from /usr/include/wx-3.0/wx/object.h:19,
> from /usr/include/wx-3.0/wx/wx.h:15,
> from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
> from
> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
> /usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
> ‘wxString::operator const void*() const’
> 1629 | operator const void*() const { return c_str(); }
> | ^~~~
> /usr/include/wx-3.0/wx/string.h:1629:5: note: no known conversion from
> ‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
> In file included from
> /home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
> from
> /home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
> /home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
> note: initializing argument 1 of
> ‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
> 108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
> | ~~^
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Build error
As of commit 4138c8554 I'm getting the following build error on linux.
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp: In
constructor ‘DRC_RULES_PARSER::DRC_RULES_PARSER(BOARD*, const wxString&,
const wxString&)’:
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:36:26: error:
invalid user-defined conversion from ‘const wxString’ to ‘FILE*’ {aka
‘_IO_FILE*’} [-fpermissive]
36 | DRC_RULES_LEXER( aSource, aSourceDescr ),
| ^~~
In file included from /usr/include/wx-3.0/wx/memory.h:15,
from /usr/include/wx-3.0/wx/object.h:19,
from /usr/include/wx-3.0/wx/wx.h:15,
from /home/wayne/src/kicad-trunk/include/fctsys.h:28,
from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:25:
/usr/include/wx-3.0/wx/string.h:1629:5: note: candidate is:
‘wxString::operator const void*() const’
1629 | operator const void*() const { return c_str(); }
| ^~~~
/usr/include/wx-3.0/wx/string.h:1629:5: note: no known conversion from
‘const void*’ to ‘FILE*’ {aka ‘_IO_FILE*’}
In file included from
/home/wayne/src/kicad-trunk/pcbnew/./drc/drc_rule_parser.h:31,
from
/home/wayne/src/kicad-trunk/pcbnew/drc/drc_rule_parser.cpp:26:
/home/wayne/build/kicad/trunk-debug-gtk3-python/common/drc_rules_lexer.h:108:28:
note: initializing argument 1 of
‘DRC_RULES_LEXER::DRC_RULES_LEXER(FILE*, const wxString&)’
108 | DRC_RULES_LEXER( FILE* aFile, const wxString& aFilename ) :
| ~~^
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
