Re: [Kicad-developers] New dependency in docker image - tigervnc

2020-08-22 Thread Ian McInerney
Are you wanting to add new QA tests that need a window to the main unit
test suite? If so, we should not use a VNC server to run them we should use
xvfb to emulate an X server interface.

-Ian

On Sat, Aug 22, 2020 at 11:31 PM Sylwester Kocjan  wrote:

> Hello,
>
> Can I ask for updating docker images with additional dependency,
> according to attached patch?
>
> I was trying with running wx frames in qa test application and this
> change will be helpful for me.
>
> Best regards,
> Sylwester
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] New dependency in docker image - tigervnc

2020-08-22 Thread Seth Hillbrand
Could you explain further why you would need this in the official docker?
Can you not specify your own docker for your tests?

-Seth

On Sat, Aug 22, 2020 at 3:31 PM Sylwester Kocjan  wrote:

> Hello,
>
> Can I ask for updating docker images with additional dependency,
> according to attached patch?
>
> I was trying with running wx frames in qa test application and this
> change will be helpful for me.
>
> Best regards,
> Sylwester
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


-- 
[image: KiCad Services Corporation Logo]
Seth Hillbrand
*Lead Developer*
+1-530-302-5483‬ <+12126039372>
Davis, CA
www.kipro-pcb.comi...@kipro-pcb.com
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] New dependency in docker image - tigervnc

2020-08-22 Thread Sylwester Kocjan

Hello,

Can I ask for updating docker images with additional dependency, 
according to attached patch?


I was trying with running wx frames in qa test application and this 
change will be helpful for me.


Best regards,
Sylwester

From fd9d5e7589fa69d3b6c2d6215cba50d386d395af Mon Sep 17 00:00:00 2001
From: Sylwester Kocjan 
Date: Sun, 23 Aug 2020 00:26:02 +0200
Subject: [PATCH] Add tigervnc to docker image

---
 README.md   | 7 ++-
 scripts/install-dependencies.sh | 2 ++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 6dd49b9..5ea4ea1 100644
--- a/README.md
+++ b/README.md
@@ -1,3 +1,8 @@
 # source_containers
 
-Container images for the source code CI
\ No newline at end of file
+Container images for the source code CI
+
+# Cheat sheet
+
+docker build -f dockerfiles/Dockerfile-ubuntu18.04 -t kicad-u:18.04 .
+docker run -it --mount 'type=bind,src=[absolute path to source 
code],dst=/home/kicad' --expose 5900 kicad-u:18.04 /bin/bash
diff --git a/scripts/install-dependencies.sh b/scripts/install-dependencies.sh
index 3288d26..0f30639 100755
--- a/scripts/install-dependencies.sh
+++ b/scripts/install-dependencies.sh
@@ -158,6 +158,7 @@ then
 clang-libs \
 clang-tools-extra \
 git-clang-format \
+tigervnc-server \
 libasan \
 doxygen \
 graphviz"
@@ -275,6 +276,7 @@ then
 
 # These are the core dependencies
 PACKAGES="$PACKAGES \
+tigervnc-standalone-server \
 mesa-common-dev \
 libcairo2-dev \
 libglu1-mesa-dev \
-- 
2.26.2

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp