Re: [Kicad-developers] Problem building on Fedora Rawhide

2021-07-30 Thread Steven A. Falco

I decided to file a bug on Fedora [1].

I also saw a similar issue on the wxWidgets site and added a comment [2].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1988466
[2] https://github.com/wxWidgets/Phoenix/issues/1963

Steve

On 7/30/21 10:58 AM, Steven A. Falco wrote:

I just updated my rawhide VM, and you are quite correct:

rawhide$ python -c "import wx;print(wx.version())"
Traceback (most recent call last):
   File "", line 1, in 
   File "/usr/lib64/python3.10/site-packages/wx/__init__.py", line 17, in 

     from wx.core import *
   File "/usr/lib64/python3.10/site-packages/wx/core.py", line 12, in 
     from ._core import *
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc3 in position 261: 
invalid continuation byte
free(): invalid size
Aborted (core dumped)

I'll post on the Fedora mailing list and see where they want the bug filed.

 Steve


On 7/30/21 10:48 AM, Ian McInerney wrote:

Steve,

I saw that failure last night also, and I think it may be a wxPython problem 
with Python 3.10. I don't hav ea Rawhide VM available at the moment, but what 
we should do is try the following:

1) Install Python 3.10 and python-wxpython4 in a Rawhide install
2) Run python -c "import wx;print(wx.version())"
3) See if it errors

My guess is there will be an error in step 2, in which case we need to push it 
upstream to wxPython and the Fedora Python maintainers.

-Ian

On Fri, Jul 30, 2021 at 3:26 PM Steven A. Falco mailto:stevenfa...@gmail.com>> wrote:

    The nightly build failed with an error when building KiCAD for Fedora 
Rawhide, when discovering the python interpreter.  I haven't tracked down the 
root cause yet, but below are the error messages in case anyone has an idea on 
what can cause this.  Fedora has recently upgraded the python version, so 
perhaps that is the cause.

         Steve

    -- Found PythonInterp: /usr/bin/python3 (found version "3.10")
    -- Found PythonLibs: /usr/lib64/libpython3.10.so 
    -- Performing Test HAS_FLTO
    -- Performing Test HAS_FLTO - Success
    -- Found PythonInterp: /usr/bin/python3 (found suitable version "3.10", minimum 
required is "3.6")
    -- Check for installed Python Interpreter -- found
    :1: DeprecationWarning: The distutils package is deprecated and 
slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential 
alternatives
    :1: DeprecationWarning: The distutils.sysconfig module is 
deprecated, use sysconfig instead
    -- Python module install path: lib/python3.10/site-packages
    -- Found PythonLibs: /usr/lib64/libpython3.10.so  (found suitable 
version "3.10.0b4", minimum required is "3.6")
    Traceback (most recent call last):
    File "", line 1, in 
    File "/usr/lib64/python3.10/site-packages/wx/__init__.py", line 17, in 

      from wx.core import *
    File "/usr/lib64/python3.10/site-packages/wx/core.py", line 12, in 

      from ._core import *
    UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc3 in position 261: 
invalid continuation byte
    free(): invalid size
    CMake Error at CMakeModules/FindwxPython.cmake:66 (message):
    Unknown wxPython/Phoenix version string:
    Call Stack (most recent call first):
    CMakeLists.txt:835 (find_package)
    -- Configuring incomplete, errors occurred!
    See also 
"/builddir/build/BUILD/kicad-baf67986957afc3b4c47ed6f3def0ba3af76d2e9/redhat-linux-build/CMakeFiles/CMakeOutput.log".
    See also 
"/builddir/build/BUILD/kicad-baf67986957afc3b4c47ed6f3def0ba3af76d2e9/redhat-linux-build/CMakeFiles/CMakeError.log".
    error: Bad exit status from /var/tmp/rpm-tmp.R634pK (%build)
    RPM build errors:
      line 57: It's not recommended to use '>' in Obsoletes: Obsoletes:      
kicad >= 100:r1-1
      Bad exit status from /var/tmp/rpm-tmp.R634pK (%build)
    Child return code was: 1
    EXCEPTION: [Error()]
    Traceback (most recent call last):
    File "/usr/lib/python3.9/site-packages/mockbuild/trace_decorator.py", 
line 93, in trace
      result = func(*args, **kw)
    File "/usr/lib/python3.9/site-packages/mockbuild/util.py", line 600, in 
do_with_status
      raise exception.Error("Command failed: \n # %s\n%s" % (command, 
output), child.returncode)
    mockbuild.exception.Error: Command failed:
   # /usr/bin/systemd-nspawn -q -M c4a5491b70ab476abdc4b76cbef74bac -D 
/var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild --capability=cap_ipc_lock 
--bind=/tmp/mock-resolv.3h0kphr8:/etc/resolv.conf --bind=/dev/btrfs-control --bind=/dev/loop-control 
--bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 
--bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 
--bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash 
--setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin 

Re: [Kicad-developers] Problem building on Fedora Rawhide

2021-07-30 Thread Steven A. Falco

I just updated my rawhide VM, and you are quite correct:

rawhide$ python -c "import wx;print(wx.version())"
Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/lib64/python3.10/site-packages/wx/__init__.py", line 17, in 

from wx.core import *
  File "/usr/lib64/python3.10/site-packages/wx/core.py", line 12, in 
from ._core import *
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc3 in position 261: 
invalid continuation byte
free(): invalid size
Aborted (core dumped)

I'll post on the Fedora mailing list and see where they want the bug filed.

Steve


On 7/30/21 10:48 AM, Ian McInerney wrote:

Steve,

I saw that failure last night also, and I think it may be a wxPython problem 
with Python 3.10. I don't hav ea Rawhide VM available at the moment, but what 
we should do is try the following:

1) Install Python 3.10 and python-wxpython4 in a Rawhide install
2) Run python -c "import wx;print(wx.version())"
3) See if it errors

My guess is there will be an error in step 2, in which case we need to push it 
upstream to wxPython and the Fedora Python maintainers.

-Ian

On Fri, Jul 30, 2021 at 3:26 PM Steven A. Falco mailto:stevenfa...@gmail.com>> wrote:

The nightly build failed with an error when building KiCAD for Fedora 
Rawhide, when discovering the python interpreter.  I haven't tracked down the 
root cause yet, but below are the error messages in case anyone has an idea on 
what can cause this.  Fedora has recently upgraded the python version, so 
perhaps that is the cause.

         Steve

-- Found PythonInterp: /usr/bin/python3 (found version "3.10")
-- Found PythonLibs: /usr/lib64/libpython3.10.so 
-- Performing Test HAS_FLTO
-- Performing Test HAS_FLTO - Success
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.10", minimum 
required is "3.6")
-- Check for installed Python Interpreter -- found
:1: DeprecationWarning: The distutils package is deprecated and 
slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential 
alternatives
:1: DeprecationWarning: The distutils.sysconfig module is 
deprecated, use sysconfig instead
-- Python module install path: lib/python3.10/site-packages
-- Found PythonLibs: /usr/lib64/libpython3.10.so  (found suitable 
version "3.10.0b4", minimum required is "3.6")
Traceback (most recent call last):
    File "", line 1, in 
    File "/usr/lib64/python3.10/site-packages/wx/__init__.py", line 17, in 

      from wx.core import *
    File "/usr/lib64/python3.10/site-packages/wx/core.py", line 12, in 

      from ._core import *
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc3 in position 261: 
invalid continuation byte
free(): invalid size
CMake Error at CMakeModules/FindwxPython.cmake:66 (message):
    Unknown wxPython/Phoenix version string:
Call Stack (most recent call first):
    CMakeLists.txt:835 (find_package)
-- Configuring incomplete, errors occurred!
See also 
"/builddir/build/BUILD/kicad-baf67986957afc3b4c47ed6f3def0ba3af76d2e9/redhat-linux-build/CMakeFiles/CMakeOutput.log".
See also 
"/builddir/build/BUILD/kicad-baf67986957afc3b4c47ed6f3def0ba3af76d2e9/redhat-linux-build/CMakeFiles/CMakeError.log".
error: Bad exit status from /var/tmp/rpm-tmp.R634pK (%build)
RPM build errors:
      line 57: It's not recommended to use '>' in Obsoletes: Obsoletes:      
kicad >= 100:r1-1
      Bad exit status from /var/tmp/rpm-tmp.R634pK (%build)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
    File "/usr/lib/python3.9/site-packages/mockbuild/trace_decorator.py", 
line 93, in trace
      result = func(*args, **kw)
    File "/usr/lib/python3.9/site-packages/mockbuild/util.py", line 600, in 
do_with_status
      raise exception.Error("Command failed: \n # %s\n%s" % (command, 
output), child.returncode)
mockbuild.exception.Error: Command failed:
   # /usr/bin/systemd-nspawn -q -M c4a5491b70ab476abdc4b76cbef74bac -D 
/var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild --capability=cap_ipc_lock 
--bind=/tmp/mock-resolv.3h0kphr8:/etc/resolv.conf --bind=/dev/btrfs-control --bind=/dev/loop-control 
--bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 
--bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 
--bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash 
--setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin 
--setenv=PROMPT_COMMAND=printf "\033]0;\007" 
--setenv=PS1= \s-\v\$  --setenv=LANG=C.UTF-8 --resolv-conf=off bash --login -c 
/usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/kicad-nightly.spec

___
Mailing list: 

Re: [Kicad-developers] Problem building on Fedora Rawhide

2021-07-30 Thread Ian McInerney
Steve,

I saw that failure last night also, and I think it may be a wxPython
problem with Python 3.10. I don't hav ea Rawhide VM available at the
moment, but what we should do is try the following:

1) Install Python 3.10 and python-wxpython4 in a Rawhide install
2) Run python -c "import wx;print(wx.version())"
3) See if it errors

My guess is there will be an error in step 2, in which case we need to push
it upstream to wxPython and the Fedora Python maintainers.

-Ian

On Fri, Jul 30, 2021 at 3:26 PM Steven A. Falco 
wrote:

> The nightly build failed with an error when building KiCAD for Fedora
> Rawhide, when discovering the python interpreter.  I haven't tracked down
> the root cause yet, but below are the error messages in case anyone has an
> idea on what can cause this.  Fedora has recently upgraded the python
> version, so perhaps that is the cause.
>
> Steve
>
> -- Found PythonInterp: /usr/bin/python3 (found version "3.10")
> -- Found PythonLibs: /usr/lib64/libpython3.10.so
> -- Performing Test HAS_FLTO
> -- Performing Test HAS_FLTO - Success
> -- Found PythonInterp: /usr/bin/python3 (found suitable version "3.10",
> minimum required is "3.6")
> -- Check for installed Python Interpreter -- found
> :1: DeprecationWarning: The distutils package is deprecated and
> slated for removal in Python 3.12. Use setuptools or check PEP 632 for
> potential alternatives
> :1: DeprecationWarning: The distutils.sysconfig module is
> deprecated, use sysconfig instead
> -- Python module install path: lib/python3.10/site-packages
> -- Found PythonLibs: /usr/lib64/libpython3.10.so (found suitable version
> "3.10.0b4", minimum required is "3.6")
> Traceback (most recent call last):
>File "", line 1, in 
>File "/usr/lib64/python3.10/site-packages/wx/__init__.py", line 17, in
> 
>  from wx.core import *
>File "/usr/lib64/python3.10/site-packages/wx/core.py", line 12, in
> 
>  from ._core import *
> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc3 in position 261:
> invalid continuation byte
> free(): invalid size
> CMake Error at CMakeModules/FindwxPython.cmake:66 (message):
>Unknown wxPython/Phoenix version string:
> Call Stack (most recent call first):
>CMakeLists.txt:835 (find_package)
> -- Configuring incomplete, errors occurred!
> See also
> "/builddir/build/BUILD/kicad-baf67986957afc3b4c47ed6f3def0ba3af76d2e9/redhat-linux-build/CMakeFiles/CMakeOutput.log".
> See also
> "/builddir/build/BUILD/kicad-baf67986957afc3b4c47ed6f3def0ba3af76d2e9/redhat-linux-build/CMakeFiles/CMakeError.log".
> error: Bad exit status from /var/tmp/rpm-tmp.R634pK (%build)
> RPM build errors:
>  line 57: It's not recommended to use '>' in Obsoletes: Obsoletes:
>   kicad >= 100:r1-1
>  Bad exit status from /var/tmp/rpm-tmp.R634pK (%build)
> Child return code was: 1
> EXCEPTION: [Error()]
> Traceback (most recent call last):
>File "/usr/lib/python3.9/site-packages/mockbuild/trace_decorator.py",
> line 93, in trace
>  result = func(*args, **kw)
>File "/usr/lib/python3.9/site-packages/mockbuild/util.py", line 600, in
> do_with_status
>  raise exception.Error("Command failed: \n # %s\n%s" % (command,
> output), child.returncode)
> mockbuild.exception.Error: Command failed:
>   # /usr/bin/systemd-nspawn -q -M c4a5491b70ab476abdc4b76cbef74bac -D
> /var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild
> --capability=cap_ipc_lock --bind=/tmp/mock-resolv.3h0kphr8:/etc/resolv.conf
> --bind=/dev/btrfs-control --bind=/dev/loop-control --bind=/dev/loop0
> --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4
> --bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8
> --bind=/dev/loop9 --bind=/dev/loop10 --bind=/dev/loop11 --console=pipe
> --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir
> --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin
> --setenv=PROMPT_COMMAND=printf "\033]0;\007"
> --setenv=PS1= \s-\v\$  --setenv=LANG=C.UTF-8 --resolv-conf=off
> bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps
> /builddir/build/SPECS/kicad-nightly.spec
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] Problem building on Fedora Rawhide

2021-07-30 Thread Heiko Rosemann
Steven,

On 7/30/21 4:24 PM, Steven A. Falco wrote:
[...]
> -- Found PythonLibs: /usr/lib64/libpython3.10.so (found suitable version
> "3.10.0b4", minimum required is "3.6")
> Traceback (most recent call last):
>   File "", line 1, in 
>   File "/usr/lib64/python3.10/site-packages/wx/__init__.py", line 17, in
> 
>     from wx.core import *
>   File "/usr/lib64/python3.10/site-packages/wx/core.py", line 12, in
> 
>     from ._core import *
> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc3 in position
> 261: invalid continuation byte

I seem to remember this error from when wxPython / Phoenix hasn't been
rebuilt after a Python upgrade.

> EXCEPTION: [Error()]
> Traceback (most recent call last):
>   File "/usr/lib/python3.9/site-packages/mockbuild/trace_decorator.py",
> line 93, in trace
>     result = func(*args, **kw)
>   File "/usr/lib/python3.9/site-packages/mockbuild/util.py", line 600,
> in do_with_status
>     raise exception.Error("Command failed: \n # %s\n%s" % (command,
> output), child.returncode)

This also points to something (mockbuild? Whatever that is...) still
being built for Python 3.9.

Hope this helps,
Heiko

-- 
eMails verschlüsseln mit PGP - privacy is your right!
Mein PGP-Key zur Verifizierung: http://pgp.mit.edu




OpenPGP_signature
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] libngspice versioning by libtool

2021-07-30 Thread Carsten Schoenert
Am 30.07.21 um 14:53 schrieb Holger Vogt:
[snip]
> Ah, and what is the versioning now? The API has not changed, it was 
> however not described correctly in sharedspice.h, which now (ngspice-35) 
> will be fixed.

So you have changed the internal behavior of one or more symbols?

This is of course a modification of the API. From the commit message
that I wrote for ngspice:

>  Existing symbols behave now different or existing symbols were removed.
> 
>  --> Increase 'current' by 1, set 'revision' to 0, set 'age' to 0 
> (c+1,r=0,a=0)
>  !!!Note!!!
>  The ABI version is also affected by this (needs a bump too, the library
>  isn't backward compatible any more.

So libngspice normally would need to get a bump of the current version.
Existing source projects aren't able to get built against the new
library version without the modifications to the source and would fail
already at configure time because the API version of the new library
isn't matching.
Now the fun begins because also the header files would need to go into a
new different folder than the old ones in most of the cases.

You can try to avoid such hassle by introducing a wrapper function that
is basically the old symbol call that is internally redirecting to the
new symbol.
By this you "only" introduce a new symbol and from an outside view the
library is behaving the same as before.

That's what other libraries always try to do because introducing a new
API version has a lot of necessary required following steps, especially
outside the library. If ever possible this is to get avoided.

-- 
Regards
Carsten

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


[Kicad-developers] Problem building on Fedora Rawhide

2021-07-30 Thread Steven A. Falco

The nightly build failed with an error when building KiCAD for Fedora Rawhide, 
when discovering the python interpreter.  I haven't tracked down the root cause 
yet, but below are the error messages in case anyone has an idea on what can 
cause this.  Fedora has recently upgraded the python version, so perhaps that 
is the cause.

Steve

-- Found PythonInterp: /usr/bin/python3 (found version "3.10")
-- Found PythonLibs: /usr/lib64/libpython3.10.so
-- Performing Test HAS_FLTO
-- Performing Test HAS_FLTO - Success
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.10", minimum required 
is "3.6")
-- Check for installed Python Interpreter -- found
:1: DeprecationWarning: The distutils package is deprecated and slated 
for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
:1: DeprecationWarning: The distutils.sysconfig module is deprecated, 
use sysconfig instead
-- Python module install path: lib/python3.10/site-packages
-- Found PythonLibs: /usr/lib64/libpython3.10.so (found suitable version "3.10.0b4", 
minimum required is "3.6")
Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/lib64/python3.10/site-packages/wx/__init__.py", line 17, in 

from wx.core import *
  File "/usr/lib64/python3.10/site-packages/wx/core.py", line 12, in 
from ._core import *
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc3 in position 261: 
invalid continuation byte
free(): invalid size
CMake Error at CMakeModules/FindwxPython.cmake:66 (message):
  Unknown wxPython/Phoenix version string:
Call Stack (most recent call first):
  CMakeLists.txt:835 (find_package)
-- Configuring incomplete, errors occurred!
See also 
"/builddir/build/BUILD/kicad-baf67986957afc3b4c47ed6f3def0ba3af76d2e9/redhat-linux-build/CMakeFiles/CMakeOutput.log".
See also 
"/builddir/build/BUILD/kicad-baf67986957afc3b4c47ed6f3def0ba3af76d2e9/redhat-linux-build/CMakeFiles/CMakeError.log".
error: Bad exit status from /var/tmp/rpm-tmp.R634pK (%build)
RPM build errors:
line 57: It's not recommended to use '>' in Obsoletes: Obsoletes:  kicad 
>= 100:r1-1
Bad exit status from /var/tmp/rpm-tmp.R634pK (%build)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/mockbuild/trace_decorator.py", line 
93, in trace
result = func(*args, **kw)
  File "/usr/lib/python3.9/site-packages/mockbuild/util.py", line 600, in 
do_with_status
raise exception.Error("Command failed: \n # %s\n%s" % (command, output), 
child.returncode)
mockbuild.exception.Error: Command failed:
 # /usr/bin/systemd-nspawn -q -M c4a5491b70ab476abdc4b76cbef74bac -D 
/var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild --capability=cap_ipc_lock 
--bind=/tmp/mock-resolv.3h0kphr8:/etc/resolv.conf --bind=/dev/btrfs-control --bind=/dev/loop-control 
--bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 
--bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 
--bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash 
--setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin 
--setenv=PROMPT_COMMAND=printf "\033]0;\007" 
--setenv=PS1= \s-\v\$  --setenv=LANG=C.UTF-8 --resolv-conf=off bash --login -c 
/usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/kicad-nightly.spec

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Re: [Kicad-developers] libngspice versioning by libtool

2021-07-30 Thread Holger Vogt




The current HEAD in branch 5.1. is getting configured successful but is
failing while compiling with this error message with then updated
packages of libngspice0 and libngspice0-dev:


[ 87%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/dialogs/dialog_pns_length_tuning_settings.cpp.o
[ 87%] Building CXX object 
eeschema/CMakeFiles/eeschema_kiface.dir/sim/netlist_exporter_pspice_sim.cpp.o
[ 87%] Building CXX object 
eeschema/CMakeFiles/eeschema_kiface.dir/sim/ngspice.cpp.o
[ 87%] Building CXX object 
pcbnew/CMakeFiles/pcbnew_kiface_objects.dir/dialogs/dialog_pns_length_tuning_settings_base.cpp.o
/home/carsten/gitprojects/kicad-upstream/kicad/eeschema/sim/ngspice.cpp:341:47: 
error: cannot initialize a parameter of type 'ControlledExit *' (aka 'int 
(*)(int, int, int, int, void *)') with an rvalue of type 'int (*)(int, bool, 
bool, int, void *)': type mismatch at 2nd parameter ('NG_BOOL' (aka 'int') vs 
'bool')
 m_ngSpice_Init( , , , NULL, NULL, 
, this );
   ^
1 error generated.
make[2]: *** [eeschema/CMakeFiles/eeschema_kiface.dir/build.make:2588: 
eeschema/CMakeFiles/eeschema_kiface.dir/sim/ngspice.cpp.o] Fehler 1
make[2]: *** Es wird auf noch nicht beendete Prozesse gewartet


Looks currently to me if something needs to get cherry picked from
master into 5.1. At least I can remembering that some fixing around this
was already happen in the past.



Boolean data have always been of type 'int' in spice3f5 and ngspice. 
Unfortunately their type internally was coined 'bool' and then typedefed 
to int.


When I started shared ngspice, I inadvertently have named the boolean 
values as 'bool' in sharedspice.h as well, even if they were of type 
'int'. In a C++ environment this may be of evil because bool is a 
(fixed) type in C++, taking one byte, whereas 'int' takes four bytes.


So I have made a correction in sharedspice.h, calling the boolean type 
NG_BOOL instead of 'bool' and typedefed it to 'int'.


This has to be reflected in the calling program as well.

Ah, and what is the versioning now? The API has not changed, it was 
however not described correctly in sharedspice.h, which now (ngspice-35) 
will be fixed.


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp