Re: [Kicad-developers] [PATCH] Fix -Wparentheses warning in track_cleaner.cpp

[Maciej Sumiński]

Hi John,

Thank you for the patch, I have just pushed it to the master branch.

Cheers,
Orson

On 06/12/2018 12:16 PM, John Beard wrote:
> Hi,
> 
> This is a very simple patch to address a -Wparentheses warning in
> pcbnew/track_cleaner.cpp.
> 
> It was "wxBusyCursor( dummy );", it is now "wxBusyCursor dummy;"
> 
> Cheers,
> 
> John
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] Fix -Wparentheses warning in track_cleaner.cpp

[John Beard]

Hi,

This is a very simple patch to address a -Wparentheses warning in
pcbnew/track_cleaner.cpp.

It was "wxBusyCursor( dummy );", it is now "wxBusyCursor dummy;"

Cheers,

John
From 60b4e54c733934f42f1911c8c8a08d7c2ecf011a Mon Sep 17 00:00:00 2001
From: John Beard 
Date: Tue, 12 Jun 2018 10:49:08 +0100
Subject: [PATCH] Fix -Wparentheses in track_cleaner.cpp
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Changes "wxBusyCursor( dummy );" to just "wxBusyCursor dummy;"

Fixes warning: ../pcbnew/tracks_cleaner.cpp:155:17:
warning: unnecessary parentheses in declaration of ‘dummy’ [-Wparentheses]
 wxBusyCursor( dummy )
---
 pcbnew/tracks_cleaner.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pcbnew/tracks_cleaner.cpp b/pcbnew/tracks_cleaner.cpp
index a291c1533..b853e02cc 100644
--- a/pcbnew/tracks_cleaner.cpp
+++ b/pcbnew/tracks_cleaner.cpp
@@ -152,7 +152,7 @@ void PCB_EDIT_FRAME::Clean_Pcb()
 // Old model has to be refreshed, GAL normally does not keep updating it
 Compile_Ratsnest( NULL, false );
 
-wxBusyCursor( dummy );
+wxBusyCursor dummy;
 BOARD_COMMIT commit( this );
 TRACKS_CLEANER cleaner( GetBoard(), commit );
 
-- 
2.17.0

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp