Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Vesa Solonen]

Chris Pavlina kirjoitti 16/01/18 klo 01:04:
> I like our font. It looks professional, like it belongs in an
> engineering drawing - waaay better than a certain other package that
> defaults to some serif font (Times New Roman maybe? blehhh). Would be
> nice to be able to change fonts though.
> 
> On Mon, Jan 15, 2018 at 11:00:22PM +, Jeff Young wrote:
>> I agree that it’s not the best, but I’d rather have a better schematic fonts 
>> than sharper icons. ;)

My guess is that better fonts was mostly related to rendering. Pixel
grid fitting, hinting and antialiasing. Gschem sets quite an example
compared to Kicad rough scaling.

-Vesa


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

On Tue, Jan 16, 2018 at 09:49:51AM +, Fabrizio Tappero wrote:
> Hi Thomas,
> thanks for the pics. All icons seem out of focus to me. I however
> understand that if you need bigger icons you need bigger incons
> 
>  It might make sense to chose a 200% magnification only. In this case
> sharpness is preserved.

I can assure you there is no visible difference in sharpness between
175% and 200% on my monitor.

> 
> I shall also say that if your monitor has a higher enough DPI sharpness due
> to icon magnification should not be visible.
> 
> Cheers
> Fabrizio
> 
> On Mon, Jan 15, 2018 at 4:51 PM, Thomas Figueroa <tom_figue...@hotmail.com>
> wrote:
> 
> > I’ve attached scaling at 150%, 225%, and 250% (W10, 4k screen with DPI
> > around 280 like Chris). The icons all look fine at all of these scalings.
> > Before Chris’s patch, I manually created bitmaps from the SVGs at higher
> > resolution (2.25x) and they not only scaled very well, they looked very
> > nice. So based on these two experiences, the icons are very capable of
> > scaling appropriately.
> >
> >
> >
> >
> > --
> > *From:* Kicad-developers <kicad-developers-bounces+tom_figueroa=
> > hotmail@lists.launchpad.net> on behalf of Fabrizio Tappero <
> > fabrizio.tapp...@gmail.com>
> > *Sent:* Monday, January 15, 2018 3:52:32 AM
> > *To:* Chris Pavlina
> > *Cc:* KiCad Developers
> > *Subject:* Re: [Kicad-developers] [PATCH] Implement primitive icon
> > scaling for high DPI
> >
> > Hi,
> > Can anybody with a high DPI monitor post some pics at different scaling
> > setting please.
> >
> > An enormous effort was put in making this icons look good in they actual
> > fixed resolution. I am curious how a >250DPI monitor can display icons well
> > regardless of this effort.
> >
> > Cheers
> > Fabrizio
> >
> >
> > On Thu, Jan 11, 2018 at 6:06 PM, Chris Pavlina <pavlina.ch...@gmail.com>
> > wrote:
> >
> >> Yup. For reference my own display is around 280 DPI.
> >>
> >> On Thu, Jan 11, 2018 at 10:35:15AM +, Jeff Young wrote:
> >> > 2560x1440 @ 24” is only 122 DPI.
> >> >
> >> > Apple’s Retina displays are 220 or 227, and the Surface Book in the
> >> original bug report is 267 DPI.
> >> >
> >> > > On 11 Jan 2018, at 09:54, kristoffer Ödmark <
> >> kristofferodmar...@gmail.com> wrote:
> >> > >
> >> > > I have 2560x1440, 24" screens, I think those qualifies as high DPI?
> >> > >
> >> > > The slider value is at 100, and the diag value is at 23. The icons
> >> are ish 5mm large.
> >> > >
> >> > > But i guess that is uneccesary since It seems the scaling works as
> >> intended, I was just doing it wrong, so no errors, sorry :)
> >> > >
> >> > > The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11,
> >> measured with a tape measure, so variance in size is expected.
> >> > >
> >> > >
> >> > > Application: kicad
> >> > > Version: (2018-01-11 revision a5b3d8e57)-master, debug build
> >> > > Libraries:
> >> > > wxWidgets 3.0.3
> >> > > libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4
> >> libpsl/0.19.1 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
> >> > > Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
> >> > > Build Info:
> >> > > wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+
> >> 2.24
> >> > > Boost: 1.65.1
> >> > > Curl: 7.57.0
> >> > > Compiler: GCC 7.2.1 with C++ ABI 1011
> >> > >
> >> > > Build settings:
> >> > > USE_WX_GRAPHICS_CONTEXT=OFF
> >> > > USE_WX_OVERLAY=OFF
> >> > > KICAD_SCRIPTING=ON
> >> > > KICAD_SCRIPTING_MODULES=ON
> >> > > KICAD_SCRIPTING_WXPYTHON=ON
> >> > > KICAD_SCRIPTING_ACTION_MENU=OFF
> >> > > BUILD_GITHUB_PLUGIN=ON
> >> > > KICAD_USE_OCE=ON
> >> > > KICAD_SPICE=ON
> >> > >
> >> > >
> >> > > On 2018-01-11 01:13, Chris Pavlina wrote:
> >> > >> If your system DPI is already within a certain range it won't do
> >> > >> anything. Are you using a high DPI display? If it's not scaled
> >> > 

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Fabrizio Tappero]

Hi Thomas,
thanks for the pics. All icons seem out of focus to me. I however
understand that if you need bigger icons you need bigger incons

 It might make sense to chose a 200% magnification only. In this case
sharpness is preserved.

I shall also say that if your monitor has a higher enough DPI sharpness due
to icon magnification should not be visible.

Cheers
Fabrizio

On Mon, Jan 15, 2018 at 4:51 PM, Thomas Figueroa <tom_figue...@hotmail.com>
wrote:

> I’ve attached scaling at 150%, 225%, and 250% (W10, 4k screen with DPI
> around 280 like Chris). The icons all look fine at all of these scalings.
> Before Chris’s patch, I manually created bitmaps from the SVGs at higher
> resolution (2.25x) and they not only scaled very well, they looked very
> nice. So based on these two experiences, the icons are very capable of
> scaling appropriately.
>
>
>
>
> --
> *From:* Kicad-developers <kicad-developers-bounces+tom_figueroa=
> hotmail@lists.launchpad.net> on behalf of Fabrizio Tappero <
> fabrizio.tapp...@gmail.com>
> *Sent:* Monday, January 15, 2018 3:52:32 AM
> *To:* Chris Pavlina
> *Cc:* KiCad Developers
> *Subject:* Re: [Kicad-developers] [PATCH] Implement primitive icon
> scaling for high DPI
>
> Hi,
> Can anybody with a high DPI monitor post some pics at different scaling
> setting please.
>
> An enormous effort was put in making this icons look good in they actual
> fixed resolution. I am curious how a >250DPI monitor can display icons well
> regardless of this effort.
>
> Cheers
> Fabrizio
>
>
> On Thu, Jan 11, 2018 at 6:06 PM, Chris Pavlina <pavlina.ch...@gmail.com>
> wrote:
>
>> Yup. For reference my own display is around 280 DPI.
>>
>> On Thu, Jan 11, 2018 at 10:35:15AM +, Jeff Young wrote:
>> > 2560x1440 @ 24” is only 122 DPI.
>> >
>> > Apple’s Retina displays are 220 or 227, and the Surface Book in the
>> original bug report is 267 DPI.
>> >
>> > > On 11 Jan 2018, at 09:54, kristoffer Ödmark <
>> kristofferodmar...@gmail.com> wrote:
>> > >
>> > > I have 2560x1440, 24" screens, I think those qualifies as high DPI?
>> > >
>> > > The slider value is at 100, and the diag value is at 23. The icons
>> are ish 5mm large.
>> > >
>> > > But i guess that is uneccesary since It seems the scaling works as
>> intended, I was just doing it wrong, so no errors, sorry :)
>> > >
>> > > The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11,
>> measured with a tape measure, so variance in size is expected.
>> > >
>> > >
>> > > Application: kicad
>> > > Version: (2018-01-11 revision a5b3d8e57)-master, debug build
>> > > Libraries:
>> > > wxWidgets 3.0.3
>> > > libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4
>> libpsl/0.19.1 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
>> > > Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
>> > > Build Info:
>> > > wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+
>> 2.24
>> > > Boost: 1.65.1
>> > > Curl: 7.57.0
>> > > Compiler: GCC 7.2.1 with C++ ABI 1011
>> > >
>> > > Build settings:
>> > > USE_WX_GRAPHICS_CONTEXT=OFF
>> > > USE_WX_OVERLAY=OFF
>> > > KICAD_SCRIPTING=ON
>> > > KICAD_SCRIPTING_MODULES=ON
>> > > KICAD_SCRIPTING_WXPYTHON=ON
>> > > KICAD_SCRIPTING_ACTION_MENU=OFF
>> > > BUILD_GITHUB_PLUGIN=ON
>> > > KICAD_USE_OCE=ON
>> > > KICAD_SPICE=ON
>> > >
>> > >
>> > > On 2018-01-11 01:13, Chris Pavlina wrote:
>> > >> If your system DPI is already within a certain range it won't do
>> > >> anything. Are you using a high DPI display? If it's not scaled
>> > >> correctly, would you please share with me the diagnostic number
>> reported
>> > >> by the scale slider in eeschema prefs as well as a rough indication
>> of
>> > >> the icons' physical size? Thanks.
>> > >>
>> > >> On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:
>> > >>> Tried the patch, didnt really notice anything different though, I
>> guess you
>> > >>> need to add some custom scaling for this to take effect?
>> > >>>
>> > >>>
>> > >>> On 2018-01-10 22:23, Chris Pavlina wrote:
>&

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

I like our font. It looks professional, like it belongs in an
engineering drawing - waaay better than a certain other package that
defaults to some serif font (Times New Roman maybe? blehhh). Would be
nice to be able to change fonts though.

On Mon, Jan 15, 2018 at 11:00:22PM +, Jeff Young wrote:
> I agree that it’s not the best, but I’d rather have a better schematic fonts 
> than sharper icons. ;)
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Jeff Young]

I agree that it’s not the best, but I’d rather have a better schematic fonts 
than sharper icons. ;)


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

I tried taking an actual photo of my screen, since I figured screenshots
weren't very useful unless you can view them on a display of the
relevant DPI, but apparently taking a good photo of an LCD under these
lighting conditions with this potato^Wcamera is harder than it sounds.
Anyway, here's a crappy photo, ~280DPI/3840x2160 with 175% scale. The
relative quality of the icons vs text/schematic is pretty accurate to
what I see IRL in my opinion.

https://misc.c4757p.com/eeschema-hidpi.jpg


On Mon, Jan 15, 2018 at 03:51:26PM +, Thomas Figueroa wrote:
> I’ve attached scaling at 150%, 225%, and 250% (W10, 4k screen with DPI around 
> 280 like Chris). The icons all look fine at all of these scalings. Before 
> Chris’s patch, I manually created bitmaps from the SVGs at higher resolution 
> (2.25x) and they not only scaled very well, they looked very nice. So based 
> on these two experiences, the icons are very capable of scaling appropriately.
> 
> 
> 
> From: Kicad-developers 
> <kicad-developers-bounces+tom_figueroa=hotmail@lists.launchpad.net> on 
> behalf of Fabrizio Tappero <fabrizio.tapp...@gmail.com>
> Sent: Monday, January 15, 2018 3:52:32 AM
> To: Chris Pavlina
> Cc: KiCad Developers
> Subject: Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for 
> high DPI
> 
> Hi,
> Can anybody with a high DPI monitor post some pics at different scaling 
> setting please.
> 
> An enormous effort was put in making this icons look good in they actual 
> fixed resolution. I am curious how a >250DPI monitor can display icons well 
> regardless of this effort.
> 
> Cheers
> Fabrizio
> 
> 
> On Thu, Jan 11, 2018 at 6:06 PM, Chris Pavlina 
> <pavlina.ch...@gmail.com<mailto:pavlina.ch...@gmail.com>> wrote:
> Yup. For reference my own display is around 280 DPI.
> 
> On Thu, Jan 11, 2018 at 10:35:15AM +, Jeff Young wrote:
> > 2560x1440 @ 24” is only 122 DPI.
> >
> > Apple’s Retina displays are 220 or 227, and the Surface Book in the 
> > original bug report is 267 DPI.
> >
> > > On 11 Jan 2018, at 09:54, kristoffer Ödmark 
> > > <kristofferodmar...@gmail.com<mailto:kristofferodmar...@gmail.com>> wrote:
> > >
> > > I have 2560x1440, 24" screens, I think those qualifies as high DPI?
> > >
> > > The slider value is at 100, and the diag value is at 23. The icons are 
> > > ish 5mm large.
> > >
> > > But i guess that is uneccesary since It seems the scaling works as 
> > > intended, I was just doing it wrong, so no errors, sorry :)
> > >
> > > The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11, 
> > > measured with a tape measure, so variance in size is expected.
> > >
> > >
> > > Application: kicad
> > > Version: (2018-01-11 revision a5b3d8e57)-master, debug build
> > > Libraries:
> > > wxWidgets 3.0.3
> > > libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 
> > > (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
> > > Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
> > > Build Info:
> > > wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
> > > Boost: 1.65.1
> > > Curl: 7.57.0
> > > Compiler: GCC 7.2.1 with C++ ABI 1011
> > >
> > > Build settings:
> > > USE_WX_GRAPHICS_CONTEXT=OFF
> > > USE_WX_OVERLAY=OFF
> > > KICAD_SCRIPTING=ON
> > > KICAD_SCRIPTING_MODULES=ON
> > > KICAD_SCRIPTING_WXPYTHON=ON
> > > KICAD_SCRIPTING_ACTION_MENU=OFF
> > > BUILD_GITHUB_PLUGIN=ON
> > > KICAD_USE_OCE=ON
> > > KICAD_SPICE=ON
> > >
> > >
> > > On 2018-01-11 01:13, Chris Pavlina wrote:
> > >> If your system DPI is already within a certain range it won't do
> > >> anything. Are you using a high DPI display? If it's not scaled
> > >> correctly, would you please share with me the diagnostic number reported
> > >> by the scale slider in eeschema prefs as well as a rough indication of
> > >> the icons' physical size? Thanks.
> > >>
> > >> On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:
> > >>> Tried the patch, didnt really notice anything different though, I guess 
> > >>> you
> > >>> need to add some custom scaling for this to take effect?
> > >>>
> > >>>
> > >>> On 2018-01-10 22:23, Chris Pavlina wrote:
> > >>&g

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

I'm somewhere in between you two. It's very true that the icons were
carefully designed to look right at one resolution, which is why this is
only a stopgap for 5.0. They don't look _that_ good scaled to me, but
they're tons better scaled than completely illegible because they're too
small. Eventually I'd like to be able to properly switch to a completely
different set of icons at high resolutions so we don't have to
bitmap-scale them.

On Mon, Jan 15, 2018 at 03:51:26PM +, Thomas Figueroa wrote:
> I’ve attached scaling at 150%, 225%, and 250% (W10, 4k screen with DPI around 
> 280 like Chris). The icons all look fine at all of these scalings. Before 
> Chris’s patch, I manually created bitmaps from the SVGs at higher resolution 
> (2.25x) and they not only scaled very well, they looked very nice. So based 
> on these two experiences, the icons are very capable of scaling appropriately.
> 
> 
> 
> From: Kicad-developers 
> <kicad-developers-bounces+tom_figueroa=hotmail@lists.launchpad.net> on 
> behalf of Fabrizio Tappero <fabrizio.tapp...@gmail.com>
> Sent: Monday, January 15, 2018 3:52:32 AM
> To: Chris Pavlina
> Cc: KiCad Developers
> Subject: Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for 
> high DPI
> 
> Hi,
> Can anybody with a high DPI monitor post some pics at different scaling 
> setting please.
> 
> An enormous effort was put in making this icons look good in they actual 
> fixed resolution. I am curious how a >250DPI monitor can display icons well 
> regardless of this effort.
> 
> Cheers
> Fabrizio
> 
> 
> On Thu, Jan 11, 2018 at 6:06 PM, Chris Pavlina 
> <pavlina.ch...@gmail.com<mailto:pavlina.ch...@gmail.com>> wrote:
> Yup. For reference my own display is around 280 DPI.
> 
> On Thu, Jan 11, 2018 at 10:35:15AM +, Jeff Young wrote:
> > 2560x1440 @ 24” is only 122 DPI.
> >
> > Apple’s Retina displays are 220 or 227, and the Surface Book in the 
> > original bug report is 267 DPI.
> >
> > > On 11 Jan 2018, at 09:54, kristoffer Ödmark 
> > > <kristofferodmar...@gmail.com<mailto:kristofferodmar...@gmail.com>> wrote:
> > >
> > > I have 2560x1440, 24" screens, I think those qualifies as high DPI?
> > >
> > > The slider value is at 100, and the diag value is at 23. The icons are 
> > > ish 5mm large.
> > >
> > > But i guess that is uneccesary since It seems the scaling works as 
> > > intended, I was just doing it wrong, so no errors, sorry :)
> > >
> > > The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11, 
> > > measured with a tape measure, so variance in size is expected.
> > >
> > >
> > > Application: kicad
> > > Version: (2018-01-11 revision a5b3d8e57)-master, debug build
> > > Libraries:
> > > wxWidgets 3.0.3
> > > libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 
> > > (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
> > > Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
> > > Build Info:
> > > wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
> > > Boost: 1.65.1
> > > Curl: 7.57.0
> > > Compiler: GCC 7.2.1 with C++ ABI 1011
> > >
> > > Build settings:
> > > USE_WX_GRAPHICS_CONTEXT=OFF
> > > USE_WX_OVERLAY=OFF
> > > KICAD_SCRIPTING=ON
> > > KICAD_SCRIPTING_MODULES=ON
> > > KICAD_SCRIPTING_WXPYTHON=ON
> > > KICAD_SCRIPTING_ACTION_MENU=OFF
> > > BUILD_GITHUB_PLUGIN=ON
> > > KICAD_USE_OCE=ON
> > > KICAD_SPICE=ON
> > >
> > >
> > > On 2018-01-11 01:13, Chris Pavlina wrote:
> > >> If your system DPI is already within a certain range it won't do
> > >> anything. Are you using a high DPI display? If it's not scaled
> > >> correctly, would you please share with me the diagnostic number reported
> > >> by the scale slider in eeschema prefs as well as a rough indication of
> > >> the icons' physical size? Thanks.
> > >>
> > >> On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:
> > >>> Tried the patch, didnt really notice anything different though, I guess 
> > >>> you
> > >>> need to add some custom scaling for this to take effect?
> > >>>
> > >>>
> > >>> On 2018-01-10 22:23, Chris Pavlina wrote:
> > >>>> Sure, assign me to it. I should have time to work on it tonight

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Fabrizio Tappero]

Hi,
Can anybody with a high DPI monitor post some pics at different scaling
setting please.

An enormous effort was put in making this icons look good in they actual
fixed resolution. I am curious how a >250DPI monitor can display icons well
regardless of this effort.

Cheers
Fabrizio


On Thu, Jan 11, 2018 at 6:06 PM, Chris Pavlina 
wrote:

> Yup. For reference my own display is around 280 DPI.
>
> On Thu, Jan 11, 2018 at 10:35:15AM +, Jeff Young wrote:
> > 2560x1440 @ 24” is only 122 DPI.
> >
> > Apple’s Retina displays are 220 or 227, and the Surface Book in the
> original bug report is 267 DPI.
> >
> > > On 11 Jan 2018, at 09:54, kristoffer Ödmark <
> kristofferodmar...@gmail.com> wrote:
> > >
> > > I have 2560x1440, 24" screens, I think those qualifies as high DPI?
> > >
> > > The slider value is at 100, and the diag value is at 23. The icons are
> ish 5mm large.
> > >
> > > But i guess that is uneccesary since It seems the scaling works as
> intended, I was just doing it wrong, so no errors, sorry :)
> > >
> > > The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11,
> measured with a tape measure, so variance in size is expected.
> > >
> > >
> > > Application: kicad
> > > Version: (2018-01-11 revision a5b3d8e57)-master, debug build
> > > Libraries:
> > > wxWidgets 3.0.3
> > > libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4
> libpsl/0.19.1 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
> > > Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
> > > Build Info:
> > > wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+
> 2.24
> > > Boost: 1.65.1
> > > Curl: 7.57.0
> > > Compiler: GCC 7.2.1 with C++ ABI 1011
> > >
> > > Build settings:
> > > USE_WX_GRAPHICS_CONTEXT=OFF
> > > USE_WX_OVERLAY=OFF
> > > KICAD_SCRIPTING=ON
> > > KICAD_SCRIPTING_MODULES=ON
> > > KICAD_SCRIPTING_WXPYTHON=ON
> > > KICAD_SCRIPTING_ACTION_MENU=OFF
> > > BUILD_GITHUB_PLUGIN=ON
> > > KICAD_USE_OCE=ON
> > > KICAD_SPICE=ON
> > >
> > >
> > > On 2018-01-11 01:13, Chris Pavlina wrote:
> > >> If your system DPI is already within a certain range it won't do
> > >> anything. Are you using a high DPI display? If it's not scaled
> > >> correctly, would you please share with me the diagnostic number
> reported
> > >> by the scale slider in eeschema prefs as well as a rough indication of
> > >> the icons' physical size? Thanks.
> > >>
> > >> On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:
> > >>> Tried the patch, didnt really notice anything different though, I
> guess you
> > >>> need to add some custom scaling for this to take effect?
> > >>>
> > >>>
> > >>> On 2018-01-10 22:23, Chris Pavlina wrote:
> >  Sure, assign me to it. I should have time to work on it tonight or
> >  tomorrow.
> > 
> >  On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:
> > > FYI, the edit footprint dialog in Pcbnew is not sized properly (at
> least
> > > on windows) which I'm pretty sure is related to your recent HiDPI
> work.
> > > Do you want me to file a bug report for it?
> > >
> > > On 1/10/2018 2:01 PM, Chris Pavlina wrote:
> > >> By the way, I'm going to go ahead and push this tonight-ish if
> nobody
> > >> objects. I know it's on the big side, but due to my limited
> number of
> > >> machines to test on I really want time for user feedback. I'll be
> around
> > >> to put out any fires.
> > >>
> > >> On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
> > >>> Rebased patch attached.
> > >>>
> > >>> On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:
> >  Hi Chris,
> > 
> >  The patch does not apply cleanly on the current master, would
> you rebase
> >  it? Thanks in advance.
> > 
> >  Cheers,
> >  Orson
> > 
> >  On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> > > Hi,
> > >
> > > As discussed with Wayne earlier, I've attached a patch which
> adds simple
> > > toolbar icon scaling so the toolbars are readable on high-DPI
> systems.
> > >
> > > This is meant as a stopgap for 5.0, with plans to add proper
> scaled
> > > icons in the 6.0 cycle. A function KiScaledBitmap() is added,
> which
> > > works like KiBitmap() except it scales the bitmap according to
> the
> > > calling window's font size. Controls have been added to all
> the main
> > > applications to let the user select scaling manually (these
> were omitted
> > > from smaller apps that didn't already have a place to put
> them).
> > >
> > > In addition, in eeschema only, the pixel height of the system
> font is
> > > shown in the options dialog for diagnostics. This is only for
> collecting
> > > feedback before 5.0 release from users with different 

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

Yup. For reference my own display is around 280 DPI.

On Thu, Jan 11, 2018 at 10:35:15AM +, Jeff Young wrote:
> 2560x1440 @ 24” is only 122 DPI. 
> 
> Apple’s Retina displays are 220 or 227, and the Surface Book in the original 
> bug report is 267 DPI.
> 
> > On 11 Jan 2018, at 09:54, kristoffer Ödmark  
> > wrote:
> > 
> > I have 2560x1440, 24" screens, I think those qualifies as high DPI?
> > 
> > The slider value is at 100, and the diag value is at 23. The icons are ish 
> > 5mm large.
> > 
> > But i guess that is uneccesary since It seems the scaling works as 
> > intended, I was just doing it wrong, so no errors, sorry :)
> > 
> > The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11, measured 
> > with a tape measure, so variance in size is expected.
> > 
> > 
> > Application: kicad
> > Version: (2018-01-11 revision a5b3d8e57)-master, debug build
> > Libraries:
> > wxWidgets 3.0.3
> > libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 
> > (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
> > Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
> > Build Info:
> > wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
> > Boost: 1.65.1
> > Curl: 7.57.0
> > Compiler: GCC 7.2.1 with C++ ABI 1011
> > 
> > Build settings:
> > USE_WX_GRAPHICS_CONTEXT=OFF
> > USE_WX_OVERLAY=OFF
> > KICAD_SCRIPTING=ON
> > KICAD_SCRIPTING_MODULES=ON
> > KICAD_SCRIPTING_WXPYTHON=ON
> > KICAD_SCRIPTING_ACTION_MENU=OFF
> > BUILD_GITHUB_PLUGIN=ON
> > KICAD_USE_OCE=ON
> > KICAD_SPICE=ON
> > 
> > 
> > On 2018-01-11 01:13, Chris Pavlina wrote:
> >> If your system DPI is already within a certain range it won't do
> >> anything. Are you using a high DPI display? If it's not scaled
> >> correctly, would you please share with me the diagnostic number reported
> >> by the scale slider in eeschema prefs as well as a rough indication of
> >> the icons' physical size? Thanks.
> >> 
> >> On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:
> >>> Tried the patch, didnt really notice anything different though, I guess 
> >>> you
> >>> need to add some custom scaling for this to take effect?
> >>> 
> >>> 
> >>> On 2018-01-10 22:23, Chris Pavlina wrote:
>  Sure, assign me to it. I should have time to work on it tonight or
>  tomorrow.
>  
>  On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:
> > FYI, the edit footprint dialog in Pcbnew is not sized properly (at least
> > on windows) which I'm pretty sure is related to your recent HiDPI work.
> > Do you want me to file a bug report for it?
> > 
> > On 1/10/2018 2:01 PM, Chris Pavlina wrote:
> >> By the way, I'm going to go ahead and push this tonight-ish if nobody
> >> objects. I know it's on the big side, but due to my limited number of
> >> machines to test on I really want time for user feedback. I'll be 
> >> around
> >> to put out any fires.
> >> 
> >> On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
> >>> Rebased patch attached.
> >>> 
> >>> On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:
>  Hi Chris,
>  
>  The patch does not apply cleanly on the current master, would you 
>  rebase
>  it? Thanks in advance.
>  
>  Cheers,
>  Orson
>  
>  On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> > Hi,
> > 
> > As discussed with Wayne earlier, I've attached a patch which adds 
> > simple
> > toolbar icon scaling so the toolbars are readable on high-DPI 
> > systems.
> > 
> > This is meant as a stopgap for 5.0, with plans to add proper scaled
> > icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
> > works like KiBitmap() except it scales the bitmap according to the
> > calling window's font size. Controls have been added to all the main
> > applications to let the user select scaling manually (these were 
> > omitted
> > from smaller apps that didn't already have a place to put them).
> > 
> > In addition, in eeschema only, the pixel height of the system font 
> > is
> > shown in the options dialog for diagnostics. This is only for 
> > collecting
> > feedback before 5.0 release from users with different displays and 
> > will
> > be removed.
> > 
> > I would like to push this fairly soon, as I want to get as much user
> > feedback as possible before release. I have a limited number of 
> > systems
> > to test this on myself.
> > 
> > 
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to  

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

You're right on the threshold I chose (somewhat arbitrarily). 5mm
sounds decent. I made an intentional choice not to start scaling until
it's quite necessary, because it's just simple bitmap scaling and on
displays that are lower in DPI they _look_ scaled.

On Thu, Jan 11, 2018 at 09:53:52AM +, kristoffer Ödmark wrote:
> I have 2560x1440, 24" screens, I think those qualifies as high DPI?
> 
> The slider value is at 100, and the diag value is at 23. The icons are ish
> 5mm large.
> 
> But i guess that is uneccesary since It seems the scaling works as intended,
> I was just doing it wrong, so no errors, sorry :)
> 
> The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11, measured
> with a tape measure, so variance in size is expected.
> 
> 
> Application: kicad
> Version: (2018-01-11 revision a5b3d8e57)-master, debug build
> Libraries:
>     wxWidgets 3.0.3
>     libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1
> (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
> Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
> Build Info:
>     wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
>     Boost: 1.65.1
>     Curl: 7.57.0
>     Compiler: GCC 7.2.1 with C++ ABI 1011
> 
> Build settings:
>     USE_WX_GRAPHICS_CONTEXT=OFF
>     USE_WX_OVERLAY=OFF
>     KICAD_SCRIPTING=ON
>     KICAD_SCRIPTING_MODULES=ON
>     KICAD_SCRIPTING_WXPYTHON=ON
>     KICAD_SCRIPTING_ACTION_MENU=OFF
>     BUILD_GITHUB_PLUGIN=ON
>     KICAD_USE_OCE=ON
>     KICAD_SPICE=ON
> 
> 
> On 2018-01-11 01:13, Chris Pavlina wrote:
> > If your system DPI is already within a certain range it won't do
> > anything. Are you using a high DPI display? If it's not scaled
> > correctly, would you please share with me the diagnostic number reported
> > by the scale slider in eeschema prefs as well as a rough indication of
> > the icons' physical size? Thanks.
> > 
> > On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:
> > > Tried the patch, didnt really notice anything different though, I guess 
> > > you
> > > need to add some custom scaling for this to take effect?
> > > 
> > > 
> > > On 2018-01-10 22:23, Chris Pavlina wrote:
> > > > Sure, assign me to it. I should have time to work on it tonight or
> > > > tomorrow.
> > > > 
> > > > On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:
> > > > > FYI, the edit footprint dialog in Pcbnew is not sized properly (at 
> > > > > least
> > > > > on windows) which I'm pretty sure is related to your recent HiDPI 
> > > > > work.
> > > > > Do you want me to file a bug report for it?
> > > > > 
> > > > > On 1/10/2018 2:01 PM, Chris Pavlina wrote:
> > > > > > By the way, I'm going to go ahead and push this tonight-ish if 
> > > > > > nobody
> > > > > > objects. I know it's on the big side, but due to my limited number 
> > > > > > of
> > > > > > machines to test on I really want time for user feedback. I'll be 
> > > > > > around
> > > > > > to put out any fires.
> > > > > > 
> > > > > > On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
> > > > > > > Rebased patch attached.
> > > > > > > 
> > > > > > > On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:
> > > > > > > > Hi Chris,
> > > > > > > > 
> > > > > > > > The patch does not apply cleanly on the current master, would 
> > > > > > > > you rebase
> > > > > > > > it? Thanks in advance.
> > > > > > > > 
> > > > > > > > Cheers,
> > > > > > > > Orson
> > > > > > > > 
> > > > > > > > On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> > > > > > > > > Hi,
> > > > > > > > > 
> > > > > > > > > As discussed with Wayne earlier, I've attached a patch which 
> > > > > > > > > adds simple
> > > > > > > > > toolbar icon scaling so the toolbars are readable on high-DPI 
> > > > > > > > > systems.
> > > > > > > > > 
> > > > > > > > > This is meant as a stopgap for 5.0, with plans to add proper 
> > > > > > > > > scaled
> > > > > > > > > icons in the 6.0 cycle. A function KiScaledBitmap() is added, 
> > > > > > > > > which
> > > > > > > > > works like KiBitmap() except it scales the bitmap according 
> > > > > > > > > to the
> > > > > > > > > calling window's font size. Controls have been added to all 
> > > > > > > > > the main
> > > > > > > > > applications to let the user select scaling manually (these 
> > > > > > > > > were omitted
> > > > > > > > > from smaller apps that didn't already have a place to put 
> > > > > > > > > them).
> > > > > > > > > 
> > > > > > > > > In addition, in eeschema only, the pixel height of the system 
> > > > > > > > > font is
> > > > > > > > > shown in the options dialog for diagnostics. This is only for 
> > > > > > > > > collecting
> > > > > > > > > feedback before 5.0 release from users with different 
> > > > > > > > > displays and will
> > > > > > > > > be removed.
> > > > > > > > > 
> > > > > > > > > I would like to push this fairly soon, as I want to get as 
> > > > > > > > > much user
> > > > > > > > > feedback as 

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Wayne Stambaugh]

Chris,

I submitted the bug report[1] for this issue.  Thanks for looking into it.

Cheers,

Wayne

[1]: https://bugs.launchpad.net/kicad/+bug/1742701

On 1/10/2018 4:23 PM, Chris Pavlina wrote:
> Sure, assign me to it. I should have time to work on it tonight or
> tomorrow.
> 
> On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:
>> FYI, the edit footprint dialog in Pcbnew is not sized properly (at least
>> on windows) which I'm pretty sure is related to your recent HiDPI work.
>> Do you want me to file a bug report for it?
>>
>> On 1/10/2018 2:01 PM, Chris Pavlina wrote:
>>> By the way, I'm going to go ahead and push this tonight-ish if nobody
>>> objects. I know it's on the big side, but due to my limited number of
>>> machines to test on I really want time for user feedback. I'll be around
>>> to put out any fires.
>>>
>>> On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
 Rebased patch attached.

 On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:
> Hi Chris,
>
> The patch does not apply cleanly on the current master, would you rebase
> it? Thanks in advance.
>
> Cheers,
> Orson
>
> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
>> Hi,
>>
>> As discussed with Wayne earlier, I've attached a patch which adds simple
>> toolbar icon scaling so the toolbars are readable on high-DPI systems.
>>
>> This is meant as a stopgap for 5.0, with plans to add proper scaled
>> icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
>> works like KiBitmap() except it scales the bitmap according to the
>> calling window's font size. Controls have been added to all the main
>> applications to let the user select scaling manually (these were omitted
>> from smaller apps that didn't already have a place to put them).
>>
>> In addition, in eeschema only, the pixel height of the system font is
>> shown in the options dialog for diagnostics. This is only for collecting
>> feedback before 5.0 release from users with different displays and will
>> be removed.
>>
>> I would like to push this fairly soon, as I want to get as much user
>> feedback as possible before release. I have a limited number of systems
>> to test this on myself.
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>



>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Jeff Young]

2560x1440 @ 24” is only 122 DPI. 

Apple’s Retina displays are 220 or 227, and the Surface Book in the original 
bug report is 267 DPI.

> On 11 Jan 2018, at 09:54, kristoffer Ödmark  
> wrote:
> 
> I have 2560x1440, 24" screens, I think those qualifies as high DPI?
> 
> The slider value is at 100, and the diag value is at 23. The icons are ish 
> 5mm large.
> 
> But i guess that is uneccesary since It seems the scaling works as intended, 
> I was just doing it wrong, so no errors, sorry :)
> 
> The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11, measured 
> with a tape measure, so variance in size is expected.
> 
> 
> Application: kicad
> Version: (2018-01-11 revision a5b3d8e57)-master, debug build
> Libraries:
> wxWidgets 3.0.3
> libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 
> (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0
> Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
> Build Info:
> wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
> Boost: 1.65.1
> Curl: 7.57.0
> Compiler: GCC 7.2.1 with C++ ABI 1011
> 
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_ACTION_MENU=OFF
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_SPICE=ON
> 
> 
> On 2018-01-11 01:13, Chris Pavlina wrote:
>> If your system DPI is already within a certain range it won't do
>> anything. Are you using a high DPI display? If it's not scaled
>> correctly, would you please share with me the diagnostic number reported
>> by the scale slider in eeschema prefs as well as a rough indication of
>> the icons' physical size? Thanks.
>> 
>> On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:
>>> Tried the patch, didnt really notice anything different though, I guess you
>>> need to add some custom scaling for this to take effect?
>>> 
>>> 
>>> On 2018-01-10 22:23, Chris Pavlina wrote:
 Sure, assign me to it. I should have time to work on it tonight or
 tomorrow.
 
 On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:
> FYI, the edit footprint dialog in Pcbnew is not sized properly (at least
> on windows) which I'm pretty sure is related to your recent HiDPI work.
> Do you want me to file a bug report for it?
> 
> On 1/10/2018 2:01 PM, Chris Pavlina wrote:
>> By the way, I'm going to go ahead and push this tonight-ish if nobody
>> objects. I know it's on the big side, but due to my limited number of
>> machines to test on I really want time for user feedback. I'll be around
>> to put out any fires.
>> 
>> On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
>>> Rebased patch attached.
>>> 
>>> On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:
 Hi Chris,
 
 The patch does not apply cleanly on the current master, would you 
 rebase
 it? Thanks in advance.
 
 Cheers,
 Orson
 
 On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> Hi,
> 
> As discussed with Wayne earlier, I've attached a patch which adds 
> simple
> toolbar icon scaling so the toolbars are readable on high-DPI systems.
> 
> This is meant as a stopgap for 5.0, with plans to add proper scaled
> icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
> works like KiBitmap() except it scales the bitmap according to the
> calling window's font size. Controls have been added to all the main
> applications to let the user select scaling manually (these were 
> omitted
> from smaller apps that didn't already have a place to put them).
> 
> In addition, in eeschema only, the pixel height of the system font is
> shown in the options dialog for diagnostics. This is only for 
> collecting
> feedback before 5.0 release from users with different displays and 
> will
> be removed.
> 
> I would like to push this fairly soon, as I want to get as much user
> feedback as possible before release. I have a limited number of 
> systems
> to test this on myself.
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
>>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : 

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[kristoffer Ödmark]

I have 2560x1440, 24" screens, I think those qualifies as high DPI?

The slider value is at 100, and the diag value is at 23. The icons are 
ish 5mm large.


But i guess that is uneccesary since It seems the scaling works as 
intended, I was just doing it wrong, so no errors, sorry :)


The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11, 
measured with a tape measure, so variance in size is expected.



Application: kicad
Version: (2018-01-11 revision a5b3d8e57)-master, debug build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 
libpsl/0.19.1 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0

Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.65.1
    Curl: 7.57.0
    Compiler: GCC 7.2.1 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON


On 2018-01-11 01:13, Chris Pavlina wrote:

If your system DPI is already within a certain range it won't do
anything. Are you using a high DPI display? If it's not scaled
correctly, would you please share with me the diagnostic number reported
by the scale slider in eeschema prefs as well as a rough indication of
the icons' physical size? Thanks.

On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:

Tried the patch, didnt really notice anything different though, I guess you
need to add some custom scaling for this to take effect?


On 2018-01-10 22:23, Chris Pavlina wrote:

Sure, assign me to it. I should have time to work on it tonight or
tomorrow.

On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:

FYI, the edit footprint dialog in Pcbnew is not sized properly (at least
on windows) which I'm pretty sure is related to your recent HiDPI work.
Do you want me to file a bug report for it?

On 1/10/2018 2:01 PM, Chris Pavlina wrote:

By the way, I'm going to go ahead and push this tonight-ish if nobody
objects. I know it's on the big side, but due to my limited number of
machines to test on I really want time for user feedback. I'll be around
to put out any fires.

On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:

Rebased patch attached.

On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:

Hi Chris,

The patch does not apply cleanly on the current master, would you rebase
it? Thanks in advance.

Cheers,
Orson

On 01/09/2018 03:43 AM, Chris Pavlina wrote:

Hi,

As discussed with Wayne earlier, I've attached a patch which adds simple
toolbar icon scaling so the toolbars are readable on high-DPI systems.

This is meant as a stopgap for 5.0, with plans to add proper scaled
icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
works like KiBitmap() except it scales the bitmap according to the
calling window's font size. Controls have been added to all the main
applications to let the user select scaling manually (these were omitted
from smaller apps that didn't already have a place to put them).

In addition, in eeschema only, the pixel height of the system font is
shown in the options dialog for diagnostics. This is only for collecting
feedback before 5.0 release from users with different displays and will
be removed.

I would like to push this fairly soon, as I want to get as much user
feedback as possible before release. I have a limited number of systems
to test this on myself.



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing 

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[kristoffer Ödmark]

I have 2560x1440, 24" screens, I think those qualifies as high DPI?

The slider value is at 100, and the diag value is at 23. The icons are 
ish 5mm large.


But i guess that is uneccesary since It seems the scaling works as 
intended, I was just doing it wrong, so no errors, sorry :)


The scaling seems correct as well, 100 = 5mm, 150 = 7.5, 200 = 11, 
measured with a tape measure, so variance in size is expected.



Application: kicad
Version: (2018-01-11 revision a5b3d8e57)-master, debug build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.57.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 
libpsl/0.19.1 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.29.0

Platform: Linux 4.9.74-2-MANJARO x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.65.1
    Curl: 7.57.0
    Compiler: GCC 7.2.1 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON


On 2018-01-11 01:13, Chris Pavlina wrote:

If your system DPI is already within a certain range it won't do
anything. Are you using a high DPI display? If it's not scaled
correctly, would you please share with me the diagnostic number reported
by the scale slider in eeschema prefs as well as a rough indication of
the icons' physical size? Thanks.

On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:

Tried the patch, didnt really notice anything different though, I guess you
need to add some custom scaling for this to take effect?


On 2018-01-10 22:23, Chris Pavlina wrote:

Sure, assign me to it. I should have time to work on it tonight or
tomorrow.

On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:

FYI, the edit footprint dialog in Pcbnew is not sized properly (at least
on windows) which I'm pretty sure is related to your recent HiDPI work.
Do you want me to file a bug report for it?

On 1/10/2018 2:01 PM, Chris Pavlina wrote:

By the way, I'm going to go ahead and push this tonight-ish if nobody
objects. I know it's on the big side, but due to my limited number of
machines to test on I really want time for user feedback. I'll be around
to put out any fires.

On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:

Rebased patch attached.

On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:

Hi Chris,

The patch does not apply cleanly on the current master, would you rebase
it? Thanks in advance.

Cheers,
Orson

On 01/09/2018 03:43 AM, Chris Pavlina wrote:

Hi,

As discussed with Wayne earlier, I've attached a patch which adds simple
toolbar icon scaling so the toolbars are readable on high-DPI systems.

This is meant as a stopgap for 5.0, with plans to add proper scaled
icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
works like KiBitmap() except it scales the bitmap according to the
calling window's font size. Controls have been added to all the main
applications to let the user select scaling manually (these were omitted
from smaller apps that didn't already have a place to put them).

In addition, in eeschema only, the pixel height of the system font is
shown in the options dialog for diagnostics. This is only for collecting
feedback before 5.0 release from users with different displays and will
be removed.

I would like to push this fairly soon, as I want to get as much user
feedback as possible before release. I have a limited number of systems
to test this on myself.



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing 

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

If your system DPI is already within a certain range it won't do
anything. Are you using a high DPI display? If it's not scaled
correctly, would you please share with me the diagnostic number reported
by the scale slider in eeschema prefs as well as a rough indication of
the icons' physical size? Thanks.

On Wed, Jan 10, 2018 at 11:16:46PM +, kristoffer Ödmark wrote:
> Tried the patch, didnt really notice anything different though, I guess you
> need to add some custom scaling for this to take effect?
> 
> 
> On 2018-01-10 22:23, Chris Pavlina wrote:
> > Sure, assign me to it. I should have time to work on it tonight or
> > tomorrow.
> > 
> > On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:
> > > FYI, the edit footprint dialog in Pcbnew is not sized properly (at least
> > > on windows) which I'm pretty sure is related to your recent HiDPI work.
> > > Do you want me to file a bug report for it?
> > > 
> > > On 1/10/2018 2:01 PM, Chris Pavlina wrote:
> > > > By the way, I'm going to go ahead and push this tonight-ish if nobody
> > > > objects. I know it's on the big side, but due to my limited number of
> > > > machines to test on I really want time for user feedback. I'll be around
> > > > to put out any fires.
> > > > 
> > > > On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
> > > > > Rebased patch attached.
> > > > > 
> > > > > On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:
> > > > > > Hi Chris,
> > > > > > 
> > > > > > The patch does not apply cleanly on the current master, would you 
> > > > > > rebase
> > > > > > it? Thanks in advance.
> > > > > > 
> > > > > > Cheers,
> > > > > > Orson
> > > > > > 
> > > > > > On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > As discussed with Wayne earlier, I've attached a patch which adds 
> > > > > > > simple
> > > > > > > toolbar icon scaling so the toolbars are readable on high-DPI 
> > > > > > > systems.
> > > > > > > 
> > > > > > > This is meant as a stopgap for 5.0, with plans to add proper 
> > > > > > > scaled
> > > > > > > icons in the 6.0 cycle. A function KiScaledBitmap() is added, 
> > > > > > > which
> > > > > > > works like KiBitmap() except it scales the bitmap according to the
> > > > > > > calling window's font size. Controls have been added to all the 
> > > > > > > main
> > > > > > > applications to let the user select scaling manually (these were 
> > > > > > > omitted
> > > > > > > from smaller apps that didn't already have a place to put them).
> > > > > > > 
> > > > > > > In addition, in eeschema only, the pixel height of the system 
> > > > > > > font is
> > > > > > > shown in the options dialog for diagnostics. This is only for 
> > > > > > > collecting
> > > > > > > feedback before 5.0 release from users with different displays 
> > > > > > > and will
> > > > > > > be removed.
> > > > > > > 
> > > > > > > I would like to push this fairly soon, as I want to get as much 
> > > > > > > user
> > > > > > > feedback as possible before release. I have a limited number of 
> > > > > > > systems
> > > > > > > to test this on myself.
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > ___
> > > > > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > > > > Post to : kicad-developers@lists.launchpad.net
> > > > > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > > > > More help   : https://help.launchpad.net/ListHelp
> > > > > > > 
> > > > > > 
> > > > > 
> > > > > 
> > > > 
> > > > ___
> > > > Mailing list: https://launchpad.net/~kicad-developers
> > > > Post to : kicad-developers@lists.launchpad.net
> > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > > More help   : https://help.launchpad.net/ListHelp
> > > > 
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > > Post to : kicad-developers@lists.launchpad.net
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > More help   : https://help.launchpad.net/ListHelp
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

Sure, assign me to it. I should have time to work on it tonight or
tomorrow.

On Wed, Jan 10, 2018 at 04:20:21PM -0500, Wayne Stambaugh wrote:
> FYI, the edit footprint dialog in Pcbnew is not sized properly (at least
> on windows) which I'm pretty sure is related to your recent HiDPI work.
> Do you want me to file a bug report for it?
> 
> On 1/10/2018 2:01 PM, Chris Pavlina wrote:
> > By the way, I'm going to go ahead and push this tonight-ish if nobody
> > objects. I know it's on the big side, but due to my limited number of
> > machines to test on I really want time for user feedback. I'll be around
> > to put out any fires.
> > 
> > On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
> >> Rebased patch attached.
> >>
> >> On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:
> >>> Hi Chris,
> >>>
> >>> The patch does not apply cleanly on the current master, would you rebase
> >>> it? Thanks in advance.
> >>>
> >>> Cheers,
> >>> Orson
> >>>
> >>> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
>  Hi,
> 
>  As discussed with Wayne earlier, I've attached a patch which adds simple
>  toolbar icon scaling so the toolbars are readable on high-DPI systems.
> 
>  This is meant as a stopgap for 5.0, with plans to add proper scaled
>  icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
>  works like KiBitmap() except it scales the bitmap according to the
>  calling window's font size. Controls have been added to all the main
>  applications to let the user select scaling manually (these were omitted
>  from smaller apps that didn't already have a place to put them).
> 
>  In addition, in eeschema only, the pixel height of the system font is
>  shown in the options dialog for diagnostics. This is only for collecting
>  feedback before 5.0 release from users with different displays and will
>  be removed.
> 
>  I would like to push this fairly soon, as I want to get as much user
>  feedback as possible before release. I have a limited number of systems
>  to test this on myself.
> 
> 
> 
>  ___
>  Mailing list: https://launchpad.net/~kicad-developers
>  Post to : kicad-developers@lists.launchpad.net
>  Unsubscribe : https://launchpad.net/~kicad-developers
>  More help   : https://help.launchpad.net/ListHelp
> 
> >>>
> >>>
> >>
> >>
> >>
> > 
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Wayne Stambaugh]

FYI, the edit footprint dialog in Pcbnew is not sized properly (at least
on windows) which I'm pretty sure is related to your recent HiDPI work.
Do you want me to file a bug report for it?

On 1/10/2018 2:01 PM, Chris Pavlina wrote:
> By the way, I'm going to go ahead and push this tonight-ish if nobody
> objects. I know it's on the big side, but due to my limited number of
> machines to test on I really want time for user feedback. I'll be around
> to put out any fires.
> 
> On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
>> Rebased patch attached.
>>
>> On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:
>>> Hi Chris,
>>>
>>> The patch does not apply cleanly on the current master, would you rebase
>>> it? Thanks in advance.
>>>
>>> Cheers,
>>> Orson
>>>
>>> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
 Hi,

 As discussed with Wayne earlier, I've attached a patch which adds simple
 toolbar icon scaling so the toolbars are readable on high-DPI systems.

 This is meant as a stopgap for 5.0, with plans to add proper scaled
 icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
 works like KiBitmap() except it scales the bitmap according to the
 calling window's font size. Controls have been added to all the main
 applications to let the user select scaling manually (these were omitted
 from smaller apps that didn't already have a place to put them).

 In addition, in eeschema only, the pixel height of the system font is
 shown in the options dialog for diagnostics. This is only for collecting
 feedback before 5.0 release from users with different displays and will
 be removed.

 I would like to push this fairly soon, as I want to get as much user
 feedback as possible before release. I have a limited number of systems
 to test this on myself.



 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>>
>>>
>>
>>
>>
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

By the way, I'm going to go ahead and push this tonight-ish if nobody
objects. I know it's on the big side, but due to my limited number of
machines to test on I really want time for user feedback. I'll be around
to put out any fires.

On Wed, Jan 10, 2018 at 11:07:49AM -0700, Chris Pavlina wrote:
> Rebased patch attached.
> 
> On Tue, Jan 09, 2018 at 01:27:16PM +, Maciej Sumiński wrote:
> > Hi Chris,
> > 
> > The patch does not apply cleanly on the current master, would you rebase
> > it? Thanks in advance.
> > 
> > Cheers,
> > Orson
> > 
> > On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> > > Hi,
> > > 
> > > As discussed with Wayne earlier, I've attached a patch which adds simple
> > > toolbar icon scaling so the toolbars are readable on high-DPI systems.
> > > 
> > > This is meant as a stopgap for 5.0, with plans to add proper scaled
> > > icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
> > > works like KiBitmap() except it scales the bitmap according to the
> > > calling window's font size. Controls have been added to all the main
> > > applications to let the user select scaling manually (these were omitted
> > > from smaller apps that didn't already have a place to put them).
> > > 
> > > In addition, in eeschema only, the pixel height of the system font is
> > > shown in the options dialog for diagnostics. This is only for collecting
> > > feedback before 5.0 release from users with different displays and will
> > > be removed.
> > > 
> > > I would like to push this fairly soon, as I want to get as much user
> > > feedback as possible before release. I have a limited number of systems
> > > to test this on myself.
> > > 
> > > 
> > > 
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > > Post to : kicad-developers@lists.launchpad.net
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > More help   : https://help.launchpad.net/ListHelp
> > > 
> > 
> > 
> 
> 
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Bernhard Stegmaier]

I know… I just wanted to check that it is still OK after your patch.
Jeff already did, so everything fine.

> On 9. Jan 2018, at 18:28, Chris Pavlina  wrote:
> 
> OSX/macOS has built-in scaling for those, other operating systems don't.
> 
> On Tue, Jan 09, 2018 at 02:40:20PM +0100, Bernhard Stegmaier wrote:
>> Hi Chris,
>> 
>> can you show a screenshot what this patch fixes?
>> I have a Retina MacBook and for my taste the toolbar icons are pretty OK 
>> without any patch…
>> 
>> 
>> Regards,
>> Bernhard
>> 
>>> On 9. Jan 2018, at 14:27, Maciej Sumiński  wrote:
>>> 
>>> Hi Chris,
>>> 
>>> The patch does not apply cleanly on the current master, would you rebase
>>> it? Thanks in advance.
>>> 
>>> Cheers,
>>> Orson
>>> 
>>> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
 Hi,
 
 As discussed with Wayne earlier, I've attached a patch which adds simple
 toolbar icon scaling so the toolbars are readable on high-DPI systems.
 
 This is meant as a stopgap for 5.0, with plans to add proper scaled
 icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
 works like KiBitmap() except it scales the bitmap according to the
 calling window's font size. Controls have been added to all the main
 applications to let the user select scaling manually (these were omitted
 from smaller apps that didn't already have a place to put them).
 
 In addition, in eeschema only, the pixel height of the system font is
 shown in the options dialog for diagnostics. This is only for collecting
 feedback before 5.0 release from users with different displays and will
 be removed.
 
 I would like to push this fairly soon, as I want to get as much user
 feedback as possible before release. I have a limited number of systems
 to test this on myself.
 
 
 
 ___
 Mailing list: https://launchpad.net/~kicad-developers 
  
 >
 Post to : kicad-developers@lists.launchpad.net 
  
 >
 Unsubscribe : https://launchpad.net/~kicad-developers 
  
 >
 More help   : https://help.launchpad.net/ListHelp 
  >
 
>>> 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers 
>>>  
>>> >> >
>>> Post to : kicad-developers@lists.launchpad.net 
>>>  
>>> >> >
>>> Unsubscribe : https://launchpad.net/~kicad-developers 
>>>  
>>> >> >
>>> More help   : https://help.launchpad.net/ListHelp 
>>>  >> >

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

It applies cleanly on 87cc3ea44 if you want to test, I won't have a
chance to rebase it until tomorrow most likely. Looks like a lot of
changes.

On Tue, Jan 09, 2018 at 02:27:16PM +0100, Maciej Sumiński wrote:
> Hi Chris,
> 
> The patch does not apply cleanly on the current master, would you rebase
> it? Thanks in advance.
> 
> Cheers,
> Orson
> 
> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> > Hi,
> > 
> > As discussed with Wayne earlier, I've attached a patch which adds simple
> > toolbar icon scaling so the toolbars are readable on high-DPI systems.
> > 
> > This is meant as a stopgap for 5.0, with plans to add proper scaled
> > icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
> > works like KiBitmap() except it scales the bitmap according to the
> > calling window's font size. Controls have been added to all the main
> > applications to let the user select scaling manually (these were omitted
> > from smaller apps that didn't already have a place to put them).
> > 
> > In addition, in eeschema only, the pixel height of the system font is
> > shown in the options dialog for diagnostics. This is only for collecting
> > feedback before 5.0 release from users with different displays and will
> > be removed.
> > 
> > I would like to push this fairly soon, as I want to get as much user
> > feedback as possible before release. I have a limited number of systems
> > to test this on myself.
> > 
> > 
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> 




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Chris Pavlina]

OSX/macOS has built-in scaling for those, other operating systems don't.

On Tue, Jan 09, 2018 at 02:40:20PM +0100, Bernhard Stegmaier wrote:
> Hi Chris,
> 
> can you show a screenshot what this patch fixes?
> I have a Retina MacBook and for my taste the toolbar icons are pretty OK 
> without any patch…
> 
> 
> Regards,
> Bernhard
> 
> > On 9. Jan 2018, at 14:27, Maciej Sumiński  wrote:
> > 
> > Hi Chris,
> > 
> > The patch does not apply cleanly on the current master, would you rebase
> > it? Thanks in advance.
> > 
> > Cheers,
> > Orson
> > 
> > On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> >> Hi,
> >> 
> >> As discussed with Wayne earlier, I've attached a patch which adds simple
> >> toolbar icon scaling so the toolbars are readable on high-DPI systems.
> >> 
> >> This is meant as a stopgap for 5.0, with plans to add proper scaled
> >> icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
> >> works like KiBitmap() except it scales the bitmap according to the
> >> calling window's font size. Controls have been added to all the main
> >> applications to let the user select scaling manually (these were omitted
> >> from smaller apps that didn't already have a place to put them).
> >> 
> >> In addition, in eeschema only, the pixel height of the system font is
> >> shown in the options dialog for diagnostics. This is only for collecting
> >> feedback before 5.0 release from users with different displays and will
> >> be removed.
> >> 
> >> I would like to push this fairly soon, as I want to get as much user
> >> feedback as possible before release. I have a limited number of systems
> >> to test this on myself.
> >> 
> >> 
> >> 
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers 
> >> 
> >> Post to : kicad-developers@lists.launchpad.net 
> >> 
> >> Unsubscribe : https://launchpad.net/~kicad-developers 
> >> 
> >> More help   : https://help.launchpad.net/ListHelp 
> >> 
> >> 
> > 
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers 
> > 
> > Post to : kicad-developers@lists.launchpad.net 
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers 
> > 
> > More help   : https://help.launchpad.net/ListHelp 
> > 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Jeff Young]

Hi Chris,

Patch looks OK on normal-res Retina MacBook Pro (ie: it didn’t break anything).

Cheers,
Jeff.


> On 9 Jan 2018, at 13:44, Nick Østergaard  wrote:
> 
> I suspect it looks something similar to what is presented in 
> 
> https://bugs.launchpad.net/kicad/+bug/1519581 
> 
> 
> 2018-01-09 14:40 GMT+01:00 Bernhard Stegmaier  >:
> Hi Chris,
> 
> can you show a screenshot what this patch fixes?
> I have a Retina MacBook and for my taste the toolbar icons are pretty OK 
> without any patch…
> 
> 
> Regards,
> Bernhard
> 
> 
>> On 9. Jan 2018, at 14:27, Maciej Sumiński > > wrote:
>> 
>> Hi Chris,
>> 
>> The patch does not apply cleanly on the current master, would you rebase
>> it? Thanks in advance.
>> 
>> Cheers,
>> Orson
>> 
>> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
>>> Hi,
>>> 
>>> As discussed with Wayne earlier, I've attached a patch which adds simple
>>> toolbar icon scaling so the toolbars are readable on high-DPI systems.
>>> 
>>> This is meant as a stopgap for 5.0, with plans to add proper scaled
>>> icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
>>> works like KiBitmap() except it scales the bitmap according to the
>>> calling window's font size. Controls have been added to all the main
>>> applications to let the user select scaling manually (these were omitted
>>> from smaller apps that didn't already have a place to put them).
>>> 
>>> In addition, in eeschema only, the pixel height of the system font is
>>> shown in the options dialog for diagnostics. This is only for collecting
>>> feedback before 5.0 release from users with different displays and will
>>> be removed.
>>> 
>>> I would like to push this fairly soon, as I want to get as much user
>>> feedback as possible before release. I have a limited number of systems
>>> to test this on myself.
>>> 
>>> 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers 
>>> 
>>> Post to : kicad-developers@lists.launchpad.net 
>>> 
>>> Unsubscribe : https://launchpad.net/~kicad-developers 
>>> 
>>> More help   : https://help.launchpad.net/ListHelp 
>>> 
>>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Nick Østergaard]

I suspect it looks something similar to what is presented in

https://bugs.launchpad.net/kicad/+bug/1519581

2018-01-09 14:40 GMT+01:00 Bernhard Stegmaier :

> Hi Chris,
>
> can you show a screenshot what this patch fixes?
> I have a Retina MacBook and for my taste the toolbar icons are pretty OK
> without any patch…
>
>
> Regards,
> Bernhard
>
>
> On 9. Jan 2018, at 14:27, Maciej Sumiński  wrote:
>
> Hi Chris,
>
> The patch does not apply cleanly on the current master, would you rebase
> it? Thanks in advance.
>
> Cheers,
> Orson
>
> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
>
> Hi,
>
> As discussed with Wayne earlier, I've attached a patch which adds simple
> toolbar icon scaling so the toolbars are readable on high-DPI systems.
>
> This is meant as a stopgap for 5.0, with plans to add proper scaled
> icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
> works like KiBitmap() except it scales the bitmap according to the
> calling window's font size. Controls have been added to all the main
> applications to let the user select scaling manually (these were omitted
> from smaller apps that didn't already have a place to put them).
>
> In addition, in eeschema only, the pixel height of the system font is
> shown in the options dialog for diagnostics. This is only for collecting
> feedback before 5.0 release from users with different displays and will
> be removed.
>
> I would like to push this fairly soon, as I want to get as much user
> feedback as possible before release. I have a limited number of systems
> to test this on myself.
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Bernhard Stegmaier]

Hi Chris,

can you show a screenshot what this patch fixes?
I have a Retina MacBook and for my taste the toolbar icons are pretty OK 
without any patch…


Regards,
Bernhard

> On 9. Jan 2018, at 14:27, Maciej Sumiński  wrote:
> 
> Hi Chris,
> 
> The patch does not apply cleanly on the current master, would you rebase
> it? Thanks in advance.
> 
> Cheers,
> Orson
> 
> On 01/09/2018 03:43 AM, Chris Pavlina wrote:
>> Hi,
>> 
>> As discussed with Wayne earlier, I've attached a patch which adds simple
>> toolbar icon scaling so the toolbars are readable on high-DPI systems.
>> 
>> This is meant as a stopgap for 5.0, with plans to add proper scaled
>> icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
>> works like KiBitmap() except it scales the bitmap according to the
>> calling window's font size. Controls have been added to all the main
>> applications to let the user select scaling manually (these were omitted
>> from smaller apps that didn't already have a place to put them).
>> 
>> In addition, in eeschema only, the pixel height of the system font is
>> shown in the options dialog for diagnostics. This is only for collecting
>> feedback before 5.0 release from users with different displays and will
>> be removed.
>> 
>> I would like to push this fairly soon, as I want to get as much user
>> feedback as possible before release. I have a limited number of systems
>> to test this on myself.
>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
>> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

[Maciej Sumiński]

Hi Chris,

The patch does not apply cleanly on the current master, would you rebase
it? Thanks in advance.

Cheers,
Orson

On 01/09/2018 03:43 AM, Chris Pavlina wrote:
> Hi,
> 
> As discussed with Wayne earlier, I've attached a patch which adds simple
> toolbar icon scaling so the toolbars are readable on high-DPI systems.
> 
> This is meant as a stopgap for 5.0, with plans to add proper scaled
> icons in the 6.0 cycle. A function KiScaledBitmap() is added, which
> works like KiBitmap() except it scales the bitmap according to the
> calling window's font size. Controls have been added to all the main
> applications to let the user select scaling manually (these were omitted
> from smaller apps that didn't already have a place to put them).
> 
> In addition, in eeschema only, the pixel height of the system font is
> shown in the options dialog for diagnostics. This is only for collecting
> feedback before 5.0 release from users with different displays and will
> be removed.
> 
> I would like to push this fairly soon, as I want to get as much user
> feedback as possible before release. I have a limited number of systems
> to test this on myself.
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp