Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Diego Herranz]

>> Maybe a better option would be to have footprint variations similar to
>> aliases.
>> Something with a new name, new 3d model path and new description but the
>> same land pattern.

This would be great and ease the libraries development quite a lot.

Diego


On Mon, Mar 25, 2019 at 8:50 PM Rene Pöschl  wrote:

> Maybe a better option would be to have footprint variations similar to
> aliases.
> Something with a new name, new 3d model path and new description but the
> same land pattern.
>
> This could be useful not only for having specialized 3d models but also
> when the manufacturer uses a very strange part naming scheme where it
> gets hard to define a footprint name well such that it tells the user
> which parts it exactly fits. (Example is if the part number code has for
> example a place that is either a,b.e for fp1 but c,d for fp2. right now
> we would need at least 3 possibly 5 footprints to properly do this.)
>
> The individual visibility stuff could also be useful for usecases that
> do not fit the one handled by my suggestion. One example would be a
> battery holder where you have the battery as a separate model. You might
> be interested in seeiing how it looks without a battery. Maybe even have
> a model where the battery is in the process of being inserted to see the
> space required for that task.
>
> Or a shield that covers some other parts. Might be useful to just hide
> this alone.
>
> On 25/03/19 19:46, Jeff Young wrote:
> > Multiple models is an existing feature (for building up parts).  There’s
> just no individual control over visibility.
> >
> > Cheers,
> > Jeff.
> >
> >> On 25 Mar 2019, at 18:38, Wayne Stambaugh  wrote:
> >>
> >> Sorry it took so long to get back to this but I've been really busy.
> >> The the capacitor example makes sense although I'm not sure this is a
> >> significant enough feature to warrant a file format change.  I'm not
> >> terribly opposed to this idea either.  I do have a few questions.  Can
> >> multiple models be visible at the same time?  If so, have the STEP and
> >> VRML exporters been tested to work under this case?
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >> On 3/14/2019 10:26 AM, Jeff Young wrote:
> >>> Hi Wayne,
> >>>
> >>> No, it would need to be saved in the file.  Think of it as Units for 3D
> >>> models: for instance you might have 30mm, 35mm and 40mm tall capacitors
> >>> all assigned to the single 20mm diameter 7.5mm pitch footprint.
> >>>
> >>> Cheers,
> >>> Jeff.
> >>>
> >>>
>  On 14 Mar 2019, at 13:38, Wayne Stambaugh   > wrote:
> 
>  Jeff,
> 
>  I haven't looked at Oliver's patch so I'm flying blind here.  My
>  question is why does this require a board change.  Is this a state we
>  really need to save in the board file or could it be some 3D viewer
>  visibility state option saved in a config file?  I would prefer the
>  latter if possible.  I guess I don't understand the purpose of this.
> 
>  Cheers,
> 
>  Wayne
> 
>  On 3/14/2019 6:44 AM, Jeff Young wrote:
> > @Wayne, this builds on top of my m_Preview addition so I’m happy to
> > review it and merge it after Oliver re-bases.  But where do we stand
> on
> > PCBNew file format changes for 6.0?  (There are also some hold-overs
> I
> > have from 5.1; namely storing defined diff pair dimensions and the
> > courtyard DRC settings in the files.
> >
> >> On 14 Mar 2019, at 08:30, Oliver Walters
> >>  oliver.henry.walt...@gmail.com>
> >> > wrote:
> >>
> >> This has gone unresolved for a while now - if I put in some effort
> to
> >> rebase this, is there any likelihood it will be accepted?
> >>
> >> This patchset does involve a file format change to the PCB file but
> it
> >> is backwards compatible and introduces a useful new feature.
> >>
> >> On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters
> >>  oliver.henry.walt...@gmail.com>
> >> > wrote:
> >>
> >> The attached patchset expands on the "Preview" checkbox in the
> 3D
> >> model tab in the footprint editor.
> >>
> >> This "Preview" option currently only applies to the preview
> >> window. However if the user wishes to disable display of a given
> >> 3D model in the PCB renderer they must delete the 3D model from
> >> the footprint entirely.
> >>
> >> The new patchset does the following:
> >>
> >> 1) The state of the m_Preview parameter for each 3D model is
> >> observed in the various 3D renderers and exporters
> >>
> >> 2) The m_Preview parameter is saved to file (both .kicad_mod and
> >> .kicad_pcb)
> >>
> >> With regard to file saving, if the 3D model is "enabled"
> (default
> >> state) then the file is unchanged making this change largely
> >> backwards 

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Wayne Stambaugh]

I reviewed the original patch set and I would be willing to merge it but
I would prefer to use the existing file token "hide" rather than add a
new token "disabled".  Also, the file format version will have to be
revised because JP's chamfered corners code has already been merged.

On 3/25/2019 4:55 PM, Jon Evans wrote:
> This is a good idea.  I do this relatively frequently in Altium for
> cases like you described (battery holder + battery, shields, heatsinks, etc)
> 
> On Mon, Mar 25, 2019 at 4:51 PM Rene Pöschl  > wrote:
> 
> Maybe a better option would be to have footprint variations similar to
> aliases.
> Something with a new name, new 3d model path and new description but
> the
> same land pattern.
> 
> This could be useful not only for having specialized 3d models but also
> when the manufacturer uses a very strange part naming scheme where it
> gets hard to define a footprint name well such that it tells the user
> which parts it exactly fits. (Example is if the part number code has
> for
> example a place that is either a,b.e for fp1 but c,d for fp2. right now
> we would need at least 3 possibly 5 footprints to properly do this.)
> 
> The individual visibility stuff could also be useful for usecases that
> do not fit the one handled by my suggestion. One example would be a
> battery holder where you have the battery as a separate model. You
> might
> be interested in seeiing how it looks without a battery. Maybe even
> have
> a model where the battery is in the process of being inserted to see
> the
> space required for that task.
> 
> Or a shield that covers some other parts. Might be useful to just hide
> this alone.
> 
> On 25/03/19 19:46, Jeff Young wrote:
> > Multiple models is an existing feature (for building up parts). 
> There’s just no individual control over visibility.
> >
> > Cheers,
> > Jeff.
> >
> >> On 25 Mar 2019, at 18:38, Wayne Stambaugh  > wrote:
> >>
> >> Sorry it took so long to get back to this but I've been really busy.
> >> The the capacitor example makes sense although I'm not sure this is a
> >> significant enough feature to warrant a file format change.  I'm not
> >> terribly opposed to this idea either.  I do have a few
> questions.  Can
> >> multiple models be visible at the same time?  If so, have the
> STEP and
> >> VRML exporters been tested to work under this case?
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >> On 3/14/2019 10:26 AM, Jeff Young wrote:
> >>> Hi Wayne,
> >>>
> >>> No, it would need to be saved in the file.  Think of it as Units
> for 3D
> >>> models: for instance you might have 30mm, 35mm and 40mm tall
> capacitors
> >>> all assigned to the single 20mm diameter 7.5mm pitch footprint.
> >>>
> >>> Cheers,
> >>> Jeff.
> >>>
> >>>
>  On 14 Mar 2019, at 13:38, Wayne Stambaugh  
>  >> wrote:
> 
>  Jeff,
> 
>  I haven't looked at Oliver's patch so I'm flying blind here.  My
>  question is why does this require a board change.  Is this a
> state we
>  really need to save in the board file or could it be some 3D viewer
>  visibility state option saved in a config file?  I would prefer the
>  latter if possible.  I guess I don't understand the purpose of
> this.
> 
>  Cheers,
> 
>  Wayne
> 
>  On 3/14/2019 6:44 AM, Jeff Young wrote:
> > @Wayne, this builds on top of my m_Preview addition so I’m
> happy to
> > review it and merge it after Oliver re-bases.  But where do we
> stand on
> > PCBNew file format changes for 6.0?  (There are also some
> hold-overs I
> > have from 5.1; namely storing defined diff pair dimensions and the
> > courtyard DRC settings in the files.
> >
> >> On 14 Mar 2019, at 08:30, Oliver Walters
> >>  
>  >
> >>  >> wrote:
> >>
> >> This has gone unresolved for a while now - if I put in some
> effort to
> >> rebase this, is there any likelihood it will be accepted?
> >>
> >> This patchset does involve a file format change to the PCB
> file but it
> >> is backwards compatible and introduces a useful new feature.
> >>
> >> On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters
> >>  
> 

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Jon Evans]

This is a good idea.  I do this relatively frequently in Altium for cases
like you described (battery holder + battery, shields, heatsinks, etc)

On Mon, Mar 25, 2019 at 4:51 PM Rene Pöschl  wrote:

> Maybe a better option would be to have footprint variations similar to
> aliases.
> Something with a new name, new 3d model path and new description but the
> same land pattern.
>
> This could be useful not only for having specialized 3d models but also
> when the manufacturer uses a very strange part naming scheme where it
> gets hard to define a footprint name well such that it tells the user
> which parts it exactly fits. (Example is if the part number code has for
> example a place that is either a,b.e for fp1 but c,d for fp2. right now
> we would need at least 3 possibly 5 footprints to properly do this.)
>
> The individual visibility stuff could also be useful for usecases that
> do not fit the one handled by my suggestion. One example would be a
> battery holder where you have the battery as a separate model. You might
> be interested in seeiing how it looks without a battery. Maybe even have
> a model where the battery is in the process of being inserted to see the
> space required for that task.
>
> Or a shield that covers some other parts. Might be useful to just hide
> this alone.
>
> On 25/03/19 19:46, Jeff Young wrote:
> > Multiple models is an existing feature (for building up parts).  There’s
> just no individual control over visibility.
> >
> > Cheers,
> > Jeff.
> >
> >> On 25 Mar 2019, at 18:38, Wayne Stambaugh  wrote:
> >>
> >> Sorry it took so long to get back to this but I've been really busy.
> >> The the capacitor example makes sense although I'm not sure this is a
> >> significant enough feature to warrant a file format change.  I'm not
> >> terribly opposed to this idea either.  I do have a few questions.  Can
> >> multiple models be visible at the same time?  If so, have the STEP and
> >> VRML exporters been tested to work under this case?
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >> On 3/14/2019 10:26 AM, Jeff Young wrote:
> >>> Hi Wayne,
> >>>
> >>> No, it would need to be saved in the file.  Think of it as Units for 3D
> >>> models: for instance you might have 30mm, 35mm and 40mm tall capacitors
> >>> all assigned to the single 20mm diameter 7.5mm pitch footprint.
> >>>
> >>> Cheers,
> >>> Jeff.
> >>>
> >>>
>  On 14 Mar 2019, at 13:38, Wayne Stambaugh   > wrote:
> 
>  Jeff,
> 
>  I haven't looked at Oliver's patch so I'm flying blind here.  My
>  question is why does this require a board change.  Is this a state we
>  really need to save in the board file or could it be some 3D viewer
>  visibility state option saved in a config file?  I would prefer the
>  latter if possible.  I guess I don't understand the purpose of this.
> 
>  Cheers,
> 
>  Wayne
> 
>  On 3/14/2019 6:44 AM, Jeff Young wrote:
> > @Wayne, this builds on top of my m_Preview addition so I’m happy to
> > review it and merge it after Oliver re-bases.  But where do we stand
> on
> > PCBNew file format changes for 6.0?  (There are also some hold-overs
> I
> > have from 5.1; namely storing defined diff pair dimensions and the
> > courtyard DRC settings in the files.
> >
> >> On 14 Mar 2019, at 08:30, Oliver Walters
> >>  oliver.henry.walt...@gmail.com>
> >> > wrote:
> >>
> >> This has gone unresolved for a while now - if I put in some effort
> to
> >> rebase this, is there any likelihood it will be accepted?
> >>
> >> This patchset does involve a file format change to the PCB file but
> it
> >> is backwards compatible and introduces a useful new feature.
> >>
> >> On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters
> >>  oliver.henry.walt...@gmail.com>
> >> > wrote:
> >>
> >> The attached patchset expands on the "Preview" checkbox in the
> 3D
> >> model tab in the footprint editor.
> >>
> >> This "Preview" option currently only applies to the preview
> >> window. However if the user wishes to disable display of a given
> >> 3D model in the PCB renderer they must delete the 3D model from
> >> the footprint entirely.
> >>
> >> The new patchset does the following:
> >>
> >> 1) The state of the m_Preview parameter for each 3D model is
> >> observed in the various 3D renderers and exporters
> >>
> >> 2) The m_Preview parameter is saved to file (both .kicad_mod and
> >> .kicad_pcb)
> >>
> >> With regard to file saving, if the 3D model is "enabled"
> (default
> >> state) then the file is unchanged making this change largely
> >> backwards compatible. If the 3D model is disabled, then the
> >> keyword "(disabled)" is added to the file.
> >>
> 

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Rene Pöschl]

Maybe a better option would be to have footprint variations similar to 
aliases.
Something with a new name, new 3d model path and new description but the 
same land pattern.


This could be useful not only for having specialized 3d models but also 
when the manufacturer uses a very strange part naming scheme where it 
gets hard to define a footprint name well such that it tells the user 
which parts it exactly fits. (Example is if the part number code has for 
example a place that is either a,b.e for fp1 but c,d for fp2. right now 
we would need at least 3 possibly 5 footprints to properly do this.)


The individual visibility stuff could also be useful for usecases that 
do not fit the one handled by my suggestion. One example would be a 
battery holder where you have the battery as a separate model. You might 
be interested in seeiing how it looks without a battery. Maybe even have 
a model where the battery is in the process of being inserted to see the 
space required for that task.


Or a shield that covers some other parts. Might be useful to just hide 
this alone.


On 25/03/19 19:46, Jeff Young wrote:

Multiple models is an existing feature (for building up parts).  There’s just 
no individual control over visibility.

Cheers,
Jeff.


On 25 Mar 2019, at 18:38, Wayne Stambaugh  wrote:

Sorry it took so long to get back to this but I've been really busy.
The the capacitor example makes sense although I'm not sure this is a
significant enough feature to warrant a file format change.  I'm not
terribly opposed to this idea either.  I do have a few questions.  Can
multiple models be visible at the same time?  If so, have the STEP and
VRML exporters been tested to work under this case?

Cheers,

Wayne

On 3/14/2019 10:26 AM, Jeff Young wrote:

Hi Wayne,

No, it would need to be saved in the file.  Think of it as Units for 3D
models: for instance you might have 30mm, 35mm and 40mm tall capacitors
all assigned to the single 20mm diameter 7.5mm pitch footprint.

Cheers,
Jeff.



On 14 Mar 2019, at 13:38, Wayne Stambaugh mailto:stambau...@gmail.com>> wrote:

Jeff,

I haven't looked at Oliver's patch so I'm flying blind here.  My
question is why does this require a board change.  Is this a state we
really need to save in the board file or could it be some 3D viewer
visibility state option saved in a config file?  I would prefer the
latter if possible.  I guess I don't understand the purpose of this.

Cheers,

Wayne

On 3/14/2019 6:44 AM, Jeff Young wrote:

@Wayne, this builds on top of my m_Preview addition so I’m happy to
review it and merge it after Oliver re-bases.  But where do we stand on
PCBNew file format changes for 6.0?  (There are also some hold-overs I
have from 5.1; namely storing defined diff pair dimensions and the
courtyard DRC settings in the files.


On 14 Mar 2019, at 08:30, Oliver Walters
mailto:oliver.henry.walt...@gmail.com>
> wrote:

This has gone unresolved for a while now - if I put in some effort to
rebase this, is there any likelihood it will be accepted?

This patchset does involve a file format change to the PCB file but it
is backwards compatible and introduces a useful new feature.

On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters
mailto:oliver.henry.walt...@gmail.com>
> wrote:

The attached patchset expands on the "Preview" checkbox in the 3D
model tab in the footprint editor.

This "Preview" option currently only applies to the preview
window. However if the user wishes to disable display of a given
3D model in the PCB renderer they must delete the 3D model from
the footprint entirely.

The new patchset does the following:

1) The state of the m_Preview parameter for each 3D model is
observed in the various 3D renderers and exporters

2) The m_Preview parameter is saved to file (both .kicad_mod and
.kicad_pcb)

With regard to file saving, if the 3D model is "enabled" (default
state) then the file is unchanged making this change largely
backwards compatible. If the 3D model is disabled, then the
keyword "(disabled)" is added to the file.

You can now quickly toggle 3D models on/off on an individual basis
and this is statefully saved between sessions.

Patch-set is rebased and compiled
from b445b0fab28f7dd41273801d06d7705215c57c0f

Regards,

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net


Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net

Unsubscribe : 

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Jeff Young]

Multiple models is an existing feature (for building up parts).  There’s just 
no individual control over visibility.

Cheers,
Jeff.

> On 25 Mar 2019, at 18:38, Wayne Stambaugh  wrote:
> 
> Sorry it took so long to get back to this but I've been really busy.
> The the capacitor example makes sense although I'm not sure this is a
> significant enough feature to warrant a file format change.  I'm not
> terribly opposed to this idea either.  I do have a few questions.  Can
> multiple models be visible at the same time?  If so, have the STEP and
> VRML exporters been tested to work under this case?
> 
> Cheers,
> 
> Wayne
> 
> On 3/14/2019 10:26 AM, Jeff Young wrote:
>> Hi Wayne,
>> 
>> No, it would need to be saved in the file.  Think of it as Units for 3D
>> models: for instance you might have 30mm, 35mm and 40mm tall capacitors
>> all assigned to the single 20mm diameter 7.5mm pitch footprint.
>> 
>> Cheers,
>> Jeff.
>> 
>> 
>>> On 14 Mar 2019, at 13:38, Wayne Stambaugh >> > wrote:
>>> 
>>> Jeff,
>>> 
>>> I haven't looked at Oliver's patch so I'm flying blind here.  My
>>> question is why does this require a board change.  Is this a state we
>>> really need to save in the board file or could it be some 3D viewer
>>> visibility state option saved in a config file?  I would prefer the
>>> latter if possible.  I guess I don't understand the purpose of this.
>>> 
>>> Cheers,
>>> 
>>> Wayne
>>> 
>>> On 3/14/2019 6:44 AM, Jeff Young wrote:
 @Wayne, this builds on top of my m_Preview addition so I’m happy to
 review it and merge it after Oliver re-bases.  But where do we stand on
 PCBNew file format changes for 6.0?  (There are also some hold-overs I
 have from 5.1; namely storing defined diff pair dimensions and the
 courtyard DRC settings in the files.
 
> On 14 Mar 2019, at 08:30, Oliver Walters
> mailto:oliver.henry.walt...@gmail.com>
> > wrote:
> 
> This has gone unresolved for a while now - if I put in some effort to
> rebase this, is there any likelihood it will be accepted? 
> 
> This patchset does involve a file format change to the PCB file but it
> is backwards compatible and introduces a useful new feature.
> 
> On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters
> mailto:oliver.henry.walt...@gmail.com>
> > wrote:
> 
>The attached patchset expands on the "Preview" checkbox in the 3D
>model tab in the footprint editor. 
> 
>This "Preview" option currently only applies to the preview
>window. However if the user wishes to disable display of a given
>3D model in the PCB renderer they must delete the 3D model from
>the footprint entirely.
> 
>The new patchset does the following:
> 
>1) The state of the m_Preview parameter for each 3D model is
>observed in the various 3D renderers and exporters
> 
>2) The m_Preview parameter is saved to file (both .kicad_mod and
>.kicad_pcb)
> 
>With regard to file saving, if the 3D model is "enabled" (default
>state) then the file is unchanged making this change largely
>backwards compatible. If the 3D model is disabled, then the
>keyword "(disabled)" is added to the file.
> 
>You can now quickly toggle 3D models on/off on an individual basis
>and this is statefully saved between sessions.
> 
>Patch-set is rebased and compiled
>from b445b0fab28f7dd41273801d06d7705215c57c0f
> 
>Regards,
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
 
 
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> 
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Wayne Stambaugh]

Sorry it took so long to get back to this but I've been really busy.
The the capacitor example makes sense although I'm not sure this is a
significant enough feature to warrant a file format change.  I'm not
terribly opposed to this idea either.  I do have a few questions.  Can
multiple models be visible at the same time?  If so, have the STEP and
VRML exporters been tested to work under this case?

Cheers,

Wayne

On 3/14/2019 10:26 AM, Jeff Young wrote:
> Hi Wayne,
> 
> No, it would need to be saved in the file.  Think of it as Units for 3D
> models: for instance you might have 30mm, 35mm and 40mm tall capacitors
> all assigned to the single 20mm diameter 7.5mm pitch footprint.
> 
> Cheers,
> Jeff.
> 
> 
>> On 14 Mar 2019, at 13:38, Wayne Stambaugh > > wrote:
>>
>> Jeff,
>>
>> I haven't looked at Oliver's patch so I'm flying blind here.  My
>> question is why does this require a board change.  Is this a state we
>> really need to save in the board file or could it be some 3D viewer
>> visibility state option saved in a config file?  I would prefer the
>> latter if possible.  I guess I don't understand the purpose of this.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 3/14/2019 6:44 AM, Jeff Young wrote:
>>> @Wayne, this builds on top of my m_Preview addition so I’m happy to
>>> review it and merge it after Oliver re-bases.  But where do we stand on
>>> PCBNew file format changes for 6.0?  (There are also some hold-overs I
>>> have from 5.1; namely storing defined diff pair dimensions and the
>>> courtyard DRC settings in the files.
>>>
 On 14 Mar 2019, at 08:30, Oliver Walters
 mailto:oliver.henry.walt...@gmail.com>
 > wrote:

 This has gone unresolved for a while now - if I put in some effort to
 rebase this, is there any likelihood it will be accepted? 

 This patchset does involve a file format change to the PCB file but it
 is backwards compatible and introduces a useful new feature.

 On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters
 mailto:oliver.henry.walt...@gmail.com>
 > wrote:

    The attached patchset expands on the "Preview" checkbox in the 3D
    model tab in the footprint editor. 

    This "Preview" option currently only applies to the preview
    window. However if the user wishes to disable display of a given
    3D model in the PCB renderer they must delete the 3D model from
    the footprint entirely.

    The new patchset does the following:

    1) The state of the m_Preview parameter for each 3D model is
    observed in the various 3D renderers and exporters

    2) The m_Preview parameter is saved to file (both .kicad_mod and
    .kicad_pcb)

    With regard to file saving, if the 3D model is "enabled" (default
    state) then the file is unchanged making this change largely
    backwards compatible. If the 3D model is disabled, then the
    keyword "(disabled)" is added to the file.

    You can now quickly toggle 3D models on/off on an individual basis
    and this is statefully saved between sessions.

    Patch-set is rebased and compiled
    from b445b0fab28f7dd41273801d06d7705215c57c0f

    Regards,

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 
 
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> 
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Frank Severinsen]

Relateret bug report is here:bugs.launchpad.net/kicad/+bug/1766323The model preview does not remove it from the 3d view. Only in the footprint editor ___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Kevin Cozens]

On 2019-03-14 4:30 a.m., Oliver Walters wrote:
This has gone unresolved for a while now - if I put in some effort to rebase 
this, is there any likelihood it will be accepted?Â


This patchset does involve a file format change to the PCB file but it is 
backwards compatible and introduces a useful new feature.


What feature is being added? AFAIK, you can control the display of 3D models 
in the dialog that lets you select a model and you can disable the display 
of 3D part models in the 3D viewer.


--
Cheers!

Kevin.

http://www.ve3syb.ca/   | "Nerds make the shiny things that
https://www.patreon.com/KevinCozens | distract the mouth-breathers, and
| that's why we're powerful"
Owner of Elecraft K2 #2172  |
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Mitja Nemec]

Or you have a multi project PCB stack and you are working on a middle board and 
would like to have an option to hide top/bottom board to get better view in 3D 
viewer. It would make the component placement faster as there would be no need 
for syncing between FreeCad and KiCad.
Mitja Nemec




  From: Marco Ciampa 
 To: kicad-developers@lists.launchpad.net 
 Sent: Thursday, 14 March 2019, 16:15
 Subject: Re: [Kicad-developers] [PATCH] Option to not render 3D models for 
footprints
   
On Thu, Mar 14, 2019 at 02:26:53PM +, Jeff Young wrote:
> Hi Wayne,
> 
> No, it would need to be saved in the file.  Think of it as Units for 3D
> models: for instance you might have 30mm, 35mm and 40mm tall capacitors
> all assigned to the single 20mm diameter 7.5mm pitch footprint.

... or the colors of LEDs? Cool!!!


--


Marco Ciampa

I know a joke about UDP, but you might not get it.



 GNU/Linux User #78271
 FSFE fellow #364




___
Mailing list: https://launchpad.net/~kicad-developers
Post to    : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help  : https://help.launchpad.net/ListHelp


   ___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Marco Ciampa]

On Thu, Mar 14, 2019 at 02:26:53PM +, Jeff Young wrote:
> Hi Wayne,
> 
> No, it would need to be saved in the file.  Think of it as Units for 3D
> models: for instance you might have 30mm, 35mm and 40mm tall capacitors
> all assigned to the single 20mm diameter 7.5mm pitch footprint.

... or the colors of LEDs? Cool!!!


--


Marco Ciampa

I know a joke about UDP, but you might not get it.



 GNU/Linux User #78271
 FSFE fellow #364




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Jeff Young]

Hi Wayne,

No, it would need to be saved in the file.  Think of it as Units for 3D models: 
for instance you might have 30mm, 35mm and 40mm tall capacitors all assigned to 
the single 20mm diameter 7.5mm pitch footprint.

Cheers,
Jeff.


> On 14 Mar 2019, at 13:38, Wayne Stambaugh  wrote:
> 
> Jeff,
> 
> I haven't looked at Oliver's patch so I'm flying blind here.  My
> question is why does this require a board change.  Is this a state we
> really need to save in the board file or could it be some 3D viewer
> visibility state option saved in a config file?  I would prefer the
> latter if possible.  I guess I don't understand the purpose of this.
> 
> Cheers,
> 
> Wayne
> 
> On 3/14/2019 6:44 AM, Jeff Young wrote:
>> @Wayne, this builds on top of my m_Preview addition so I’m happy to
>> review it and merge it after Oliver re-bases.  But where do we stand on
>> PCBNew file format changes for 6.0?  (There are also some hold-overs I
>> have from 5.1; namely storing defined diff pair dimensions and the
>> courtyard DRC settings in the files.
>> 
>>> On 14 Mar 2019, at 08:30, Oliver Walters
>>> mailto:oliver.henry.walt...@gmail.com>
>>> >> >> wrote:
>>> 
>>> This has gone unresolved for a while now - if I put in some effort to
>>> rebase this, is there any likelihood it will be accepted? 
>>> 
>>> This patchset does involve a file format change to the PCB file but it
>>> is backwards compatible and introduces a useful new feature.
>>> 
>>> On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters
>>> mailto:oliver.henry.walt...@gmail.com>
>>> >> >> wrote:
>>> 
>>>The attached patchset expands on the "Preview" checkbox in the 3D
>>>model tab in the footprint editor. 
>>> 
>>>This "Preview" option currently only applies to the preview
>>>window. However if the user wishes to disable display of a given
>>>3D model in the PCB renderer they must delete the 3D model from
>>>the footprint entirely.
>>> 
>>>The new patchset does the following:
>>> 
>>>1) The state of the m_Preview parameter for each 3D model is
>>>observed in the various 3D renderers and exporters
>>> 
>>>2) The m_Preview parameter is saved to file (both .kicad_mod and
>>>.kicad_pcb)
>>> 
>>>With regard to file saving, if the 3D model is "enabled" (default
>>>state) then the file is unchanged making this change largely
>>>backwards compatible. If the 3D model is disabled, then the
>>>keyword "(disabled)" is added to the file.
>>> 
>>>You can now quickly toggle 3D models on/off on an individual basis
>>>and this is statefully saved between sessions.
>>> 
>>>Patch-set is rebased and compiled
>>>from b445b0fab28f7dd41273801d06d7705215c57c0f
>>> 
>>>Regards,
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers 
>>> 
>>> Post to : kicad-developers@lists.launchpad.net 
>>> 
>>> >> >
>>> Unsubscribe : https://launchpad.net/~kicad-developers 
>>> 
>>> More help   : https://help.launchpad.net/ListHelp 
>>> 
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Wayne Stambaugh]

Jeff,

I haven't looked at Oliver's patch so I'm flying blind here.  My
question is why does this require a board change.  Is this a state we
really need to save in the board file or could it be some 3D viewer
visibility state option saved in a config file?  I would prefer the
latter if possible.  I guess I don't understand the purpose of this.

Cheers,

Wayne

On 3/14/2019 6:44 AM, Jeff Young wrote:
> @Wayne, this builds on top of my m_Preview addition so I’m happy to
> review it and merge it after Oliver re-bases.  But where do we stand on
> PCBNew file format changes for 6.0?  (There are also some hold-overs I
> have from 5.1; namely storing defined diff pair dimensions and the
> courtyard DRC settings in the files.
> 
>> On 14 Mar 2019, at 08:30, Oliver Walters
>> > > wrote:
>>
>> This has gone unresolved for a while now - if I put in some effort to
>> rebase this, is there any likelihood it will be accepted? 
>>
>> This patchset does involve a file format change to the PCB file but it
>> is backwards compatible and introduces a useful new feature.
>>
>> On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters
>> > > wrote:
>>
>> The attached patchset expands on the "Preview" checkbox in the 3D
>> model tab in the footprint editor. 
>>
>> This "Preview" option currently only applies to the preview
>> window. However if the user wishes to disable display of a given
>> 3D model in the PCB renderer they must delete the 3D model from
>> the footprint entirely.
>>
>> The new patchset does the following:
>>
>> 1) The state of the m_Preview parameter for each 3D model is
>> observed in the various 3D renderers and exporters
>>
>> 2) The m_Preview parameter is saved to file (both .kicad_mod and
>> .kicad_pcb)
>>
>> With regard to file saving, if the 3D model is "enabled" (default
>> state) then the file is unchanged making this change largely
>> backwards compatible. If the 3D model is disabled, then the
>> keyword "(disabled)" is added to the file.
>>
>> You can now quickly toggle 3D models on/off on an individual basis
>> and this is statefully saved between sessions.
>>
>> Patch-set is rebased and compiled
>> from b445b0fab28f7dd41273801d06d7705215c57c0f
>>
>> Regards,
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Jeff Young]

@Wayne, this builds on top of my m_Preview addition so I’m happy to review it 
and merge it after Oliver re-bases.  But where do we stand on PCBNew file 
format changes for 6.0?  (There are also some hold-overs I have from 5.1; 
namely storing defined diff pair dimensions and the courtyard DRC settings in 
the files.

> On 14 Mar 2019, at 08:30, Oliver Walters  
> wrote:
> 
> This has gone unresolved for a while now - if I put in some effort to rebase 
> this, is there any likelihood it will be accepted? 
> 
> This patchset does involve a file format change to the PCB file but it is 
> backwards compatible and introduces a useful new feature.
> 
> On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters 
> mailto:oliver.henry.walt...@gmail.com>> 
> wrote:
> The attached patchset expands on the "Preview" checkbox in the 3D model tab 
> in the footprint editor. 
> 
> This "Preview" option currently only applies to the preview window. However 
> if the user wishes to disable display of a given 3D model in the PCB renderer 
> they must delete the 3D model from the footprint entirely.
> 
> The new patchset does the following:
> 
> 1) The state of the m_Preview parameter for each 3D model is observed in the 
> various 3D renderers and exporters
> 
> 2) The m_Preview parameter is saved to file (both .kicad_mod and .kicad_pcb)
> 
> With regard to file saving, if the 3D model is "enabled" (default state) then 
> the file is unchanged making this change largely backwards compatible. If the 
> 3D model is disabled, then the keyword "(disabled)" is added to the file.
> 
> You can now quickly toggle 3D models on/off on an individual basis and this 
> is statefully saved between sessions.
> 
> Patch-set is rebased and compiled from 
> b445b0fab28f7dd41273801d06d7705215c57c0f
> 
> Regards,
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Oliver Walters]

This has gone unresolved for a while now - if I put in some effort to
rebase this, is there any likelihood it will be accepted?

This patchset does involve a file format change to the PCB file but it is
backwards compatible and introduces a useful new feature.

On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters <
oliver.henry.walt...@gmail.com> wrote:

> The attached patchset expands on the "Preview" checkbox in the 3D model
> tab in the footprint editor.
>
> This "Preview" option currently only applies to the preview window.
> However if the user wishes to disable display of a given 3D model in the
> PCB renderer they must delete the 3D model from the footprint entirely.
>
> The new patchset does the following:
>
> 1) The state of the m_Preview parameter for each 3D model is observed in
> the various 3D renderers and exporters
>
> 2) The m_Preview parameter is saved to file (both .kicad_mod and
> .kicad_pcb)
>
> With regard to file saving, if the 3D model is "enabled" (default state)
> then the file is unchanged making this change largely backwards compatible.
> If the 3D model is disabled, then the keyword "(disabled)" is added to the
> file.
>
> You can now quickly toggle 3D models on/off on an individual basis and
> this is statefully saved between sessions.
>
> Patch-set is rebased and compiled
> from b445b0fab28f7dd41273801d06d7705215c57c0f
>
> Regards,
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Wayne Stambaugh]

I haven't had a chance to review this patch yet.  It's on my to do list.
 Until 5.1 is tagged and branched, no file format changes are allowed.
Once the v6 development window opens, this patch will be up for
consideration.

Cheers,

Wayne

On 11/6/2018 4:46 PM, Mário Luzeiro wrote:
> Hi Oliver,
> I was about to bump your email too :)
> 
>> 2) The m_Preview parameter is saved to file (both .kicad_mod and .kicad_pcb)
> 
> At the time I worked on the 3D Viewer, some ideas arise that involve to add 
> new tags to the .kicad_pcb
> I understood that at that time it was not a good time to introduce changes on 
> the format files, special because as the stable release was approaching..
> 
> So, for this patch, I think the main question is if it is possible to 
> introduce new tags on the file formats.
> 
> Nice to see someone adding new features related to the 3D Viewer!
> 
> Regards,
> Mario Luzeiro
> 
> 
> From: Kicad-developers 
>  on behalf of 
> Oliver Walters 
> Sent: 06 November 2018 21:18:20
> To: KiCad Developers
> Subject: Re: [Kicad-developers] [PATCH] Option to not render 3D models for
>   footprints
> 
> Bump :)
> 
> On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters 
> mailto:oliver.henry.walt...@gmail.com>> wrote:
> The attached patchset expands on the "Preview" checkbox in the 3D model tab 
> in the footprint editor.
> 
> This "Preview" option currently only applies to the preview window. However 
> if the user wishes to disable display of a given 3D model in the PCB renderer 
> they must delete the 3D model from the footprint entirely.
> 
> The new patchset does the following:
> 
> 1) The state of the m_Preview parameter for each 3D model is observed in the 
> various 3D renderers and exporters
> 
> 2) The m_Preview parameter is saved to file (both .kicad_mod and .kicad_pcb)
> 
> With regard to file saving, if the 3D model is "enabled" (default state) then 
> the file is unchanged making this change largely backwards compatible. If the 
> 3D model is disabled, then the keyword "(disabled)" is added to the file.
> 
> You can now quickly toggle 3D models on/off on an individual basis and this 
> is statefully saved between sessions.
> 
> Patch-set is rebased and compiled from 
> b445b0fab28f7dd41273801d06d7705215c57c0f
> 
> Regards,
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Mário Luzeiro]

Hi Oliver,
I was about to bump your email too :)

> 2) The m_Preview parameter is saved to file (both .kicad_mod and .kicad_pcb)

At the time I worked on the 3D Viewer, some ideas arise that involve to add new 
tags to the .kicad_pcb
I understood that at that time it was not a good time to introduce changes on 
the format files, special because as the stable release was approaching..

So, for this patch, I think the main question is if it is possible to introduce 
new tags on the file formats.

Nice to see someone adding new features related to the 3D Viewer!

Regards,
Mario Luzeiro


From: Kicad-developers 
 on behalf of 
Oliver Walters 
Sent: 06 November 2018 21:18:20
To: KiCad Developers
Subject: Re: [Kicad-developers] [PATCH] Option to not render 3D models for  
footprints

Bump :)

On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters 
mailto:oliver.henry.walt...@gmail.com>> wrote:
The attached patchset expands on the "Preview" checkbox in the 3D model tab in 
the footprint editor.

This "Preview" option currently only applies to the preview window. However if 
the user wishes to disable display of a given 3D model in the PCB renderer they 
must delete the 3D model from the footprint entirely.

The new patchset does the following:

1) The state of the m_Preview parameter for each 3D model is observed in the 
various 3D renderers and exporters

2) The m_Preview parameter is saved to file (both .kicad_mod and .kicad_pcb)

With regard to file saving, if the 3D model is "enabled" (default state) then 
the file is unchanged making this change largely backwards compatible. If the 
3D model is disabled, then the keyword "(disabled)" is added to the file.

You can now quickly toggle 3D models on/off on an individual basis and this is 
statefully saved between sessions.

Patch-set is rebased and compiled from b445b0fab28f7dd41273801d06d7705215c57c0f

Regards,


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Option to not render 3D models for footprints

[Oliver Walters]

Bump :)

On Tue, Oct 30, 2018 at 11:27 PM Oliver Walters <
oliver.henry.walt...@gmail.com> wrote:

> The attached patchset expands on the "Preview" checkbox in the 3D model
> tab in the footprint editor.
>
> This "Preview" option currently only applies to the preview window.
> However if the user wishes to disable display of a given 3D model in the
> PCB renderer they must delete the 3D model from the footprint entirely.
>
> The new patchset does the following:
>
> 1) The state of the m_Preview parameter for each 3D model is observed in
> the various 3D renderers and exporters
>
> 2) The m_Preview parameter is saved to file (both .kicad_mod and
> .kicad_pcb)
>
> With regard to file saving, if the 3D model is "enabled" (default state)
> then the file is unchanged making this change largely backwards compatible.
> If the 3D model is disabled, then the keyword "(disabled)" is added to the
> file.
>
> You can now quickly toggle 3D models on/off on an individual basis and
> this is statefully saved between sessions.
>
> Patch-set is rebased and compiled
> from b445b0fab28f7dd41273801d06d7705215c57c0f
>
> Regards,
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp