Re: [Kicad-developers] [PATCH] eeschema: Allow hierarchy navigator to stay open

2019-11-03 Thread Seth Hillbrand 

On 2019-11-03 04:28, Franck Jullien wrote:

Le jeu. 24 oct. 2019 à 19:29,  a écrit :




ping




Hi Franck-

Sorry for the slow response time here.  Can you please attach the 
results of `git format-patch` as an attachment to the e-mail?  This will 
help us to review, comment and apply the patch.


Best-
Seth

Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] eeschema: Allow hierarchy navigator to stay open

2019-11-03 Thread Franck Jullien 
Le jeu. 24 oct. 2019 à 19:29,  a écrit :
>
> From: Franck Jullien 
>
> Signed-off-by: Franck Jullien 
> ---
>  eeschema/dialogs/panel_eeschema_settings.cpp  |  2 +
>  .../dialogs/panel_eeschema_settings_base.cpp  |  2 +
>  .../dialogs/panel_eeschema_settings_base.fbp  | 88 +++
>  .../dialogs/panel_eeschema_settings_base.h|  3 +-
>  eeschema/eeschema_config.cpp  |  3 +
>  eeschema/hierarch.cpp |  6 +-
>  eeschema/sch_edit_frame.h |  4 +
>  7 files changed, 104 insertions(+), 4 deletions(-)
>
> diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp 
> b/eeschema/dialogs/panel_eeschema_settings.cpp
> index d50b8a373..3ad650d18 100644
> --- a/eeschema/dialogs/panel_eeschema_settings.cpp
> +++ b/eeschema/dialogs/panel_eeschema_settings.cpp
> @@ -46,6 +46,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
>
>  m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
>  m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
> +m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
>
>  m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
>  m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
> @@ -75,6 +76,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
>
>  m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
>  m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
> +m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
>
>  m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
>  m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
> diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp 
> b/eeschema/dialogs/panel_eeschema_settings_base.cpp
> index 84c6470b1..7553170b0 100644
> --- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
> +++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
> @@ -124,6 +124,8 @@ 
> PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( wxWindow* parent, 
> wx
> m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show 
> footprint previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
> bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
>
> +   m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow 
> hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
> +   bSizer9->Add( m_navigatorStaysOpen, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );
>
> bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );
>
> diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp 
> b/eeschema/dialogs/panel_eeschema_settings_base.fbp
> index 6bc9b6da1..a8996f56f 100644
> --- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
> +++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
> @@ -1810,6 +1810,94 @@
>  
>  
>  
> +
> +5
> +wxALL
> +0
> +
> + name="BottomDockable">1
> + name="LeftDockable">1
> + name="RightDockable">1
> + name="TopDockable">1
> + name="aui_layer">
> +
> + name="aui_position">
> +
> + name="best_size">
> +
> +
> + name="caption_visible">1
> + name="center_pane">0
> +1
> + name="close_button">1
> + name="context_help">
> + name="context_menu">1
> + name="default_pane">0
> +Dock
> + name="dock_fixed">0
> + name="docking">Left
> +1
> +
> + name="floatable">1
> +
> +0
> +0
> + name="id">wxID_ANY
> +Allow 
> hierarchy navigator to stay open
> +
> +

[Kicad-developers] [PATCH] eeschema: Allow hierarchy navigator to stay open

2019-10-24 Thread franck . jullien 
From: Franck Jullien 

Signed-off-by: Franck Jullien 
---
 eeschema/dialogs/panel_eeschema_settings.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.cpp  |  2 +
 .../dialogs/panel_eeschema_settings_base.fbp  | 88 +++
 .../dialogs/panel_eeschema_settings_base.h|  3 +-
 eeschema/eeschema_config.cpp  |  3 +
 eeschema/hierarch.cpp |  6 +-
 eeschema/sch_edit_frame.h |  4 +
 7 files changed, 104 insertions(+), 4 deletions(-)

diff --git a/eeschema/dialogs/panel_eeschema_settings.cpp 
b/eeschema/dialogs/panel_eeschema_settings.cpp
index d50b8a373..3ad650d18 100644
--- a/eeschema/dialogs/panel_eeschema_settings.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings.cpp
@@ -46,6 +46,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataToWindow()
 
 m_checkHVOrientation->SetValue( m_frame->GetForceHVLines() );
 m_footprintPreview->SetValue( m_frame->GetShowFootprintPreviews() );
+m_navigatorStaysOpen->SetValue( m_frame->GetNavigatorStaysOpen() );
 
 m_checkAutoplaceFields->SetValue( m_frame->GetAutoplaceFields() );
 m_checkAutoplaceJustify->SetValue( m_frame->GetAutoplaceJustify() );
@@ -75,6 +76,7 @@ bool PANEL_EESCHEMA_SETTINGS::TransferDataFromWindow()
 
 m_frame->SetForceHVLines( m_checkHVOrientation->GetValue() );
 m_frame->SetShowFootprintPreviews( m_footprintPreview->GetValue() );
+m_frame->SetNavigatorStaysOpen( m_navigatorStaysOpen->GetValue() );
 
 m_frame->SetAutoplaceFields( m_checkAutoplaceFields->GetValue() );
 m_frame->SetAutoplaceJustify( m_checkAutoplaceJustify->GetValue() );
diff --git a/eeschema/dialogs/panel_eeschema_settings_base.cpp 
b/eeschema/dialogs/panel_eeschema_settings_base.cpp
index 84c6470b1..7553170b0 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.cpp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.cpp
@@ -124,6 +124,8 @@ PANEL_EESCHEMA_SETTINGS_BASE::PANEL_EESCHEMA_SETTINGS_BASE( 
wxWindow* parent, wx
m_footprintPreview = new wxCheckBox( this, wxID_ANY, _("Show footprint 
previews in symbol chooser"), wxDefaultPosition, wxDefaultSize, 0 );
bSizer9->Add( m_footprintPreview, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );

+   m_navigatorStaysOpen = new wxCheckBox( this, wxID_ANY, _("Allow 
hierarchy navigator to stay open"), wxDefaultPosition, wxDefaultSize, 0 );
+   bSizer9->Add( m_navigatorStaysOpen, 0, wxBOTTOM|wxLEFT|wxRIGHT, 5 );

bLeftColumn->Add( bSizer9, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );

diff --git a/eeschema/dialogs/panel_eeschema_settings_base.fbp 
b/eeschema/dialogs/panel_eeschema_settings_base.fbp
index 6bc9b6da1..a8996f56f 100644
--- a/eeschema/dialogs/panel_eeschema_settings_base.fbp
+++ b/eeschema/dialogs/panel_eeschema_settings_base.fbp
@@ -1810,6 +1810,94 @@
 
 
 
+
+5
+wxALL
+0
+
+1
+1
+1
+1
+
+
+
+
+
+
+
+1
+0
+1
+1
+
+1
+0
+Dock
+0
+Left
+1
+
+1
+
+0
+0
+wxID_ANY
+Allow hierarchy 
navigator to stay open
+
+0
+
+
+0
+
+1
+m_navigatorStaysOpen
+1
+
+
+protected
+1
+