Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
Hi Wayne, On Tue, Jul 16, 2019 at 06:24:30PM -0400, Wayne Stambaugh wrote: > I'm ready to push this patch set. I'm assuming this is the same changes > as the merge request. If not please let me know. The merge request is better: - two small fixes for things that happened while rebasing - MSVC needs "/utf-8", not "/UTF-8", the latter would be an #undef - an unused CMake variable got readded - keeps the attribution for Tom's commits. I've done a rebased branch for 5.1 as well, but will test it first before I submit that. Since I have a proper day job now, that will be some time. Simon ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
Simon, I'm ready to push this patch set. I'm assuming this is the same changes as the merge request. If not please let me know. Cheers, Wayne On 7/4/2019 12:05 PM, Simon Richter wrote: > Hi, > > another attempt at getting the MSVC patchset merged. :) > > The mails with the patches are for commenting, this branch should probably > be merged from the "msvc" branch under https://git.launchpad.net/~sjr/kicad > in order to preserve author/date information properly. > >Simon > > Simon Richter (5): > Set _USE_MATH_DEFINES on Windows > Remove own copy of FindOpenSSL.cmake > Work around missing min/max in Windows headers > Pull in macro definition for strncasecmp on MSVC > Define compiler flags for MSVC > > Tomasz Wlostowski (3): > pcbnew: can't return a copy of ptr_vector if items are polymorphic and > have no clone() methods. Work it around. > Export LIB_TREE_ITEM > MSVC support for libcontext > > CMakeLists.txt | 44 + > CMakeModules/FindOpenSSL.cmake | 342 > --- > common/gal/cairo/cairo_print.cpp | 6 + > common/system/libcontext.cpp | 66 > eeschema/sim/ngspice.cpp | 1 + > include/lib_tree_item.h | 4 +- > include/system/libcontext.h | 16 +- > include/tool/coroutine.h | 8 +- > pcbnew/pcb_edit_frame.h | 3 +- > pcbnew/pcbnew_config.cpp | 12 +- > 10 files changed, 148 insertions(+), 354 deletions(-) > delete mode 100644 CMakeModules/FindOpenSSL.cmake > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
Simon, On 7/12/2019 4:00 PM, Simon Richter wrote: > Hi Wayne, > >> I have to apply the patches, build, and test. I should be able to get >> to it over the weekend. My only comment is on patch #1. I would have >> preferred that we implemented the missing boost pointer container object >> clone methods rather the work around. As a temporary fix I could live >> with this but it just feels wrong to me. > > I'm not even sure it is wrong -- if I understood the problem correctly, > we'd do a deep clone of a container containing objects, and then throw away > the original, so we could just return the original instead. It's not so much wrong in that it is likely to cause issues if someone wants to make a deep copy of these object types without manipulating the original copy. I'm surprised this hasn't bit anyone before now. I suppose we could use a different container if we are never going to make copies of the objects. The boost pointer containers are somewhat predicated on the fact that the clone operator will be provided in order for the template to be complete. > >> Everything else seems pretty >> straight forward. I definitely want to get some testing due to the >> changes to make sure nothing is broken before we cherry pick this to the >> 5.1 branch. > > I haven't tested this on 5.1 yet, because I was expecting this to go into > master only. I was working under the assumption that devs would want to build the 5.1 branch with msvc but I have no problems with making this v6 and later. Wayne > >Simon > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
Hi Wayne, > I have to apply the patches, build, and test. I should be able to get > to it over the weekend. My only comment is on patch #1. I would have > preferred that we implemented the missing boost pointer container object > clone methods rather the work around. As a temporary fix I could live > with this but it just feels wrong to me. I'm not even sure it is wrong -- if I understood the problem correctly, we'd do a deep clone of a container containing objects, and then throw away the original, so we could just return the original instead. > Everything else seems pretty > straight forward. I definitely want to get some testing due to the > changes to make sure nothing is broken before we cherry pick this to the > 5.1 branch. I haven't tested this on 5.1 yet, because I was expecting this to go into master only. Simon ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
I have to apply the patches, build, and test. I should be able to get to it over the weekend. My only comment is on patch #1. I would have preferred that we implemented the missing boost pointer container object clone methods rather the work around. As a temporary fix I could live with this but it just feels wrong to me. Everything else seems pretty straight forward. I definitely want to get some testing due to the changes to make sure nothing is broken before we cherry pick this to the 5.1 branch. Wayne On 7/12/2019 1:10 PM, Seth Hillbrand wrote: > Agreed. Wayne are you comfortable with this? > > -S > > On 2019-07-11 15:00, Nick Østergaard wrote: >> It looks like people are happy with the patches, can we get them >> merged so they don't get lost and we don't need to rebase them locally >> all the time? >> >> On Fri, 5 Jul 2019 at 19:01, Simon Richter >> wrote: >>> >>> Hi, >>> >>> On Fri, Jul 05, 2019 at 06:24:45PM +0200, Tomasz Wlostowski wrote: >>> >>> > > I can't test the Windows functionality but this doesn't appear to >>> break >>> > > anything on Linux. >>> >>> > I'm ok with Simon's patches. Can give them a try on MSVC, but I'm >>> pretty >>> > confident they will work already. >>> >>> These are tested on Linux (with "git rebase -x make", so individual >>> commits >>> compile on their own) and Windows with MSYS2 and MSVC through Jenkins. I >>> can't test MacOS. >>> >>> > @Simon: Now that we'll be supporting MSVC, should we put a 'MSVC >>> > precompiled library kit' somewhere on Kicad webpage to spare people >>> the >>> > hassle of finding the right version on Jenkins? >>> >>> Yes, can do. I'm going to investigate vcpkg as well, since it has cmake >>> integration, so it reduces to "tell vcpkg that we need these >>> packages, and >>> tell cmake to talk to vcpkg". My initial experiments were promising, it >>> seems to be missing oce and ngspice, and I'm unsure about the status of >>> wxpython, but everything else seems to be there. >>> >>> Simon >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
Agreed. Wayne are you comfortable with this? -S On 2019-07-11 15:00, Nick Østergaard wrote: It looks like people are happy with the patches, can we get them merged so they don't get lost and we don't need to rebase them locally all the time? On Fri, 5 Jul 2019 at 19:01, Simon Richter wrote: Hi, On Fri, Jul 05, 2019 at 06:24:45PM +0200, Tomasz Wlostowski wrote: > > I can't test the Windows functionality but this doesn't appear to break > > anything on Linux. > I'm ok with Simon's patches. Can give them a try on MSVC, but I'm pretty > confident they will work already. These are tested on Linux (with "git rebase -x make", so individual commits compile on their own) and Windows with MSYS2 and MSVC through Jenkins. I can't test MacOS. > @Simon: Now that we'll be supporting MSVC, should we put a 'MSVC > precompiled library kit' somewhere on Kicad webpage to spare people the > hassle of finding the right version on Jenkins? Yes, can do. I'm going to investigate vcpkg as well, since it has cmake integration, so it reduces to "tell vcpkg that we need these packages, and tell cmake to talk to vcpkg". My initial experiments were promising, it seems to be missing oce and ngspice, and I'm unsure about the status of wxpython, but everything else seems to be there. Simon ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
It looks like people are happy with the patches, can we get them merged so they don't get lost and we don't need to rebase them locally all the time? On Fri, 5 Jul 2019 at 19:01, Simon Richter wrote: > > Hi, > > On Fri, Jul 05, 2019 at 06:24:45PM +0200, Tomasz Wlostowski wrote: > > > > I can't test the Windows functionality but this doesn't appear to break > > > anything on Linux. > > > I'm ok with Simon's patches. Can give them a try on MSVC, but I'm pretty > > confident they will work already. > > These are tested on Linux (with "git rebase -x make", so individual commits > compile on their own) and Windows with MSYS2 and MSVC through Jenkins. I > can't test MacOS. > > > @Simon: Now that we'll be supporting MSVC, should we put a 'MSVC > > precompiled library kit' somewhere on Kicad webpage to spare people the > > hassle of finding the right version on Jenkins? > > Yes, can do. I'm going to investigate vcpkg as well, since it has cmake > integration, so it reduces to "tell vcpkg that we need these packages, and > tell cmake to talk to vcpkg". My initial experiments were promising, it > seems to be missing oce and ngspice, and I'm unsure about the status of > wxpython, but everything else seems to be there. > >Simon > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
Hi, On Fri, Jul 05, 2019 at 06:24:45PM +0200, Tomasz Wlostowski wrote: > > I can't test the Windows functionality but this doesn't appear to break > > anything on Linux. > I'm ok with Simon's patches. Can give them a try on MSVC, but I'm pretty > confident they will work already. These are tested on Linux (with "git rebase -x make", so individual commits compile on their own) and Windows with MSYS2 and MSVC through Jenkins. I can't test MacOS. > @Simon: Now that we'll be supporting MSVC, should we put a 'MSVC > precompiled library kit' somewhere on Kicad webpage to spare people the > hassle of finding the right version on Jenkins? Yes, can do. I'm going to investigate vcpkg as well, since it has cmake integration, so it reduces to "tell vcpkg that we need these packages, and tell cmake to talk to vcpkg". My initial experiments were promising, it seems to be missing oce and ngspice, and I'm unsure about the status of wxpython, but everything else seems to be there. Simon ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
On 05/07/2019 18:21, Seth Hillbrand wrote: > I can't test the Windows functionality but this doesn't appear to break > anything on Linux. > I'm ok with Simon's patches. Can give them a try on MSVC, but I'm pretty confident they will work already. @Simon: Now that we'll be supporting MSVC, should we put a 'MSVC precompiled library kit' somewhere on Kicad webpage to spare people the hassle of finding the right version on Jenkins? Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH v2 0/8] MSVC Build
I can't test the Windows functionality but this doesn't appear to break anything on Linux. -Seth On 2019-07-04 12:05, Simon Richter wrote: Hi, another attempt at getting the MSVC patchset merged. :) The mails with the patches are for commenting, this branch should probably be merged from the "msvc" branch under https://git.launchpad.net/~sjr/kicad in order to preserve author/date information properly. Simon Simon Richter (5): Set _USE_MATH_DEFINES on Windows Remove own copy of FindOpenSSL.cmake Work around missing min/max in Windows headers Pull in macro definition for strncasecmp on MSVC Define compiler flags for MSVC Tomasz Wlostowski (3): pcbnew: can't return a copy of ptr_vector if items are polymorphic and have no clone() methods. Work it around. Export LIB_TREE_ITEM MSVC support for libcontext CMakeLists.txt | 44 + CMakeModules/FindOpenSSL.cmake | 342 --- common/gal/cairo/cairo_print.cpp | 6 + common/system/libcontext.cpp | 66 eeschema/sim/ngspice.cpp | 1 + include/lib_tree_item.h | 4 +- include/system/libcontext.h | 16 +- include/tool/coroutine.h | 8 +- pcbnew/pcb_edit_frame.h | 3 +- pcbnew/pcbnew_config.cpp | 12 +- 10 files changed, 148 insertions(+), 354 deletions(-) delete mode 100644 CMakeModules/FindOpenSSL.cmake ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] [PATCH v2 0/8] MSVC Build
Hi, another attempt at getting the MSVC patchset merged. :) The mails with the patches are for commenting, this branch should probably be merged from the "msvc" branch under https://git.launchpad.net/~sjr/kicad in order to preserve author/date information properly. Simon Simon Richter (5): Set _USE_MATH_DEFINES on Windows Remove own copy of FindOpenSSL.cmake Work around missing min/max in Windows headers Pull in macro definition for strncasecmp on MSVC Define compiler flags for MSVC Tomasz Wlostowski (3): pcbnew: can't return a copy of ptr_vector if items are polymorphic and have no clone() methods. Work it around. Export LIB_TREE_ITEM MSVC support for libcontext CMakeLists.txt | 44 + CMakeModules/FindOpenSSL.cmake | 342 --- common/gal/cairo/cairo_print.cpp | 6 + common/system/libcontext.cpp | 66 eeschema/sim/ngspice.cpp | 1 + include/lib_tree_item.h | 4 +- include/system/libcontext.h | 16 +- include/tool/coroutine.h | 8 +- pcbnew/pcb_edit_frame.h | 3 +- pcbnew/pcbnew_config.cpp | 12 +- 10 files changed, 148 insertions(+), 354 deletions(-) delete mode 100644 CMakeModules/FindOpenSSL.cmake -- 2.11.0 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
