Re: [Kicad-developers] Polygon build broken

[Gabriel Staples, ElectricRCAircraftGuy.com]

Seth,

Thanks for the reply. I just want to mention I wasn't trying to get anyone
called out publicly. My thinking was simply that if you know who landed the
diff that broke it, privately messaging them would make sense to me because
they'd most likely be the most familiar with that change and that part of
the code base and would be most apt to fixing it without introducing
further errors or taking extra time to get their bearings. In other words,
that person could most likely fix it the fastest and best. That's all.

I hope I didn't come off wrong,

Gabe



On Wed, Dec 12, 2018 at 10:49 AM Seth Hillbrand  wrote:

> Am 2018-12-12 13:30, schrieb Gabriel Staples, ElectricRCAircraftGuy.com:
> > Seth,
> >
> > You're probably already aware, but just in case: `git blame file_path`
> > will tell you the commit hash, person, & date for every line, to see
> > who landed the problem line, and `git bisect`
> > (https://stackoverflow.com/a/37306623/4561887) will help you binary
> > search between a known good commit and a known bad commit to find out
> > which commit introduced the bug.
>
> Thanks, that's good information.  I take this approach because there's
> little upside in publicly calling attention to mistakes/oversights by
> name, especially in a mailing list archived and searchable for an
> indefinite period.  In the same way that we wouldn't publicly call out a
> person for a mistake in a group meeting (unless we're a very
> dysfunctional workplace).
>
> This was just a heads up that the build is broken.  I'm not in a
> position at the moment to fix it myself but perhaps someone else is.
>
> I do always appreciate the useful git tips though!
>
> Best-
> Seth
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Polygon build broken

[jp charras]

Le 12/12/2018 à 19:49, Seth Hillbrand a écrit :
> Am 2018-12-12 13:30, schrieb Gabriel Staples, ElectricRCAircraftGuy.com:
>> Seth,
>>
>> You're probably already aware, but just in case: `git blame file_path`
>> will tell you the commit hash, person, & date for every line, to see
>> who landed the problem line, and `git bisect`
>> (https://stackoverflow.com/a/37306623/4561887) will help you binary
>> search between a known good commit and a known bad commit to find out
>> which commit introduced the bug.
> 
> Thanks, that's good information.  I take this approach because there's
> little upside in publicly calling attention to mistakes/oversights by
> name, especially in a mailing list archived and searchable for an
> indefinite period.  In the same way that we wouldn't publicly call out a
> person for a mistake in a group meeting (unless we're a very
> dysfunctional workplace).
> 
> This was just a heads up that the build is broken.  I'm not in a
> position at the moment to fix it myself but perhaps someone else is.
> 
> I do always appreciate the useful git tips though!
> 
> Best-
> Seth

Should be fixed now.
Thanks, Seth.

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Polygon build broken

[Seth Hillbrand]

Am 2018-12-12 13:30, schrieb Gabriel Staples, ElectricRCAircraftGuy.com:

Seth,

You're probably already aware, but just in case: `git blame file_path`
will tell you the commit hash, person, & date for every line, to see
who landed the problem line, and `git bisect`
(https://stackoverflow.com/a/37306623/4561887) will help you binary
search between a known good commit and a known bad commit to find out
which commit introduced the bug.


Thanks, that's good information.  I take this approach because there's 
little upside in publicly calling attention to mistakes/oversights by 
name, especially in a mailing list archived and searchable for an 
indefinite period.  In the same way that we wouldn't publicly call out a 
person for a mistake in a group meeting (unless we're a very 
dysfunctional workplace).


This was just a heads up that the build is broken.  I'm not in a 
position at the moment to fix it myself but perhaps someone else is.


I do always appreciate the useful git tips though!

Best-
Seth

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Polygon build broken

[Gabriel Staples, ElectricRCAircraftGuy.com]

Seth,

You're probably already aware, but just in case: `git blame file_path` will
tell you the commit hash, person, & date for every line, to see who landed
the problem line, and `git bisect` (
https://stackoverflow.com/a/37306623/4561887) will help you binary search
between a known good commit and a known bad commit to find out which commit
introduced the bug.

Gabe


Electric RC Aircraft Guy, LLC
www.ElectricRCAircraftGuy.com 

*Check out my Computa Pranksta

USB
device sold on Amazon!*



On Wed, Dec 12, 2018 at 10:23 AM Seth Hillbrand  wrote:

> Hi All-
>
> A recent commit broke the polygon build
>
> Here's the error:
>
> /home/seth/code/kicad/kicad-launchpad/polygon/PolyLine.cpp: In member
> function ‘bool CPolyLine::TestPointInside(int, int)’:
> /home/seth/code/kicad/kicad-launchpad/polygon/PolyLine.cpp:934:37:
> error: cannot convert ‘CPOLYGONS_LIST’ to ‘const wxPoint*’
>   if( TestPointInsidePolygon( m_CornersList, istart, iend, px, py
> ) )
>   ^
> In file included from
> /home/seth/code/kicad/kicad-launchpad/polygon/PolyLine.cpp:46:
> /home/seth/code/kicad/kicad-launchpad/polygon/./polygon_test_point_inside.h:63:45:
>
> note:   initializing argument 1 of ‘bool TestPointInsidePolygon(const
> wxPoint*, int, const wxPoint&)’
>   bool TestPointInsidePolygon( const wxPoint* aPolysList,
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Polygon build broken

[Seth Hillbrand]

Hi All-

A recent commit broke the polygon build

Here's the error:

/home/seth/code/kicad/kicad-launchpad/polygon/PolyLine.cpp: In member 
function ‘bool CPolyLine::TestPointInside(int, int)’:
/home/seth/code/kicad/kicad-launchpad/polygon/PolyLine.cpp:934:37: 
error: cannot convert ‘CPOLYGONS_LIST’ to ‘const wxPoint*’
 if( TestPointInsidePolygon( m_CornersList, istart, iend, px, py 
) )

 ^
In file included from 
/home/seth/code/kicad/kicad-launchpad/polygon/PolyLine.cpp:46:
/home/seth/code/kicad/kicad-launchpad/polygon/./polygon_test_point_inside.h:63:45: 
note:   initializing argument 1 of ‘bool TestPointInsidePolygon(const 
wxPoint*, int, const wxPoint&)’

 bool TestPointInsidePolygon( const wxPoint* aPolysList,


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp