Re: [Kicad-developers] small typos (missing spaces)
Le 08/05/2019 à 15:37, Wayne Stambaugh a écrit : > Marco, > > On 4/10/19 2:35 AM, Marco Ciampa wrote: >> On Tue, Apr 09, 2019 at 08:58:48PM +0200, Tomasz Wlostowski wrote: >>> On 09/04/2019 18:43, Kerusey Karyu wrote: Guys > #: pcbnew/exporters/export_hyperlynx.cpp:190 > > m_reporter->Report( > _( "File contains pad shapes that are not supported by the" > "Hyperlynx exporter (oval, rectangle, circle). They have been" > "exported as oval pads." ), > REPORTER::RPT_WARNING ); Is there no contradiction here or poor wording? The first sentence says that oval, rectangular or circular are *not* supported - as I understand. But finally these are still exported as ovals, which are... after all, unsupported. Maybe: "File contains pad shapes that are not supported by the" "Hyperlynx exporter. Only oval, rectangle, circle are allowed." "During export, they will be changed to ovals." >>> >>> My bad, please send me the patch with the wording you prefer. But didn't >>> you notice this message is not (yet) printed anywhere as the m_reporter >>> is always null? >> >> Here is the patch (thanks Kerusey for the hint) ... check if the meaning >> is right please... > > You patch no longer applies cleanly. Please rebase and resubmit your patch. > > Thanks, > > Wayne Hi Wayne and Marco, Some time ago, I committed a similar fix. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] small typos (missing spaces)
Marco, On 4/10/19 2:35 AM, Marco Ciampa wrote: > On Tue, Apr 09, 2019 at 08:58:48PM +0200, Tomasz Wlostowski wrote: >> On 09/04/2019 18:43, Kerusey Karyu wrote: >>> Guys >>> #: pcbnew/exporters/export_hyperlynx.cpp:190 m_reporter->Report( _( "File contains pad shapes that are not supported by the" "Hyperlynx exporter (oval, rectangle, circle). They have been" "exported as oval pads." ), REPORTER::RPT_WARNING ); >>> >>> Is there no contradiction here or poor wording? >>> >>> The first sentence says that oval, rectangular or circular are *not* >>> supported - as I understand. But finally these are still exported as >>> ovals, which are... after all, unsupported. >>> >>> Maybe: >>> >>> "File contains pad shapes that are not supported by the" >>> "Hyperlynx exporter. Only oval, rectangle, circle are allowed." >>> "During export, they will be changed to ovals." >>> >> >> My bad, please send me the patch with the wording you prefer. But didn't >> you notice this message is not (yet) printed anywhere as the m_reporter >> is always null? > > Here is the patch (thanks Kerusey for the hint) ... check if the meaning > is right please... You patch no longer applies cleanly. Please rebase and resubmit your patch. Thanks, Wayne ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] small typos (missing spaces)
On Tue, Apr 09, 2019 at 08:58:48PM +0200, Tomasz Wlostowski wrote:
> On 09/04/2019 18:43, Kerusey Karyu wrote:
> > Guys
> >
> >> #: pcbnew/exporters/export_hyperlynx.cpp:190
> >>
> >> m_reporter->Report(
> >> _( "File contains pad shapes that are not supported by the"
> >> "Hyperlynx exporter (oval, rectangle, circle). They have been"
> >> "exported as oval pads." ),
> >> REPORTER::RPT_WARNING );
> >
> > Is there no contradiction here or poor wording?
> >
> > The first sentence says that oval, rectangular or circular are *not*
> > supported - as I understand. But finally these are still exported as
> > ovals, which are... after all, unsupported.
> >
> > Maybe:
> >
> > "File contains pad shapes that are not supported by the"
> > "Hyperlynx exporter. Only oval, rectangle, circle are allowed."
> > "During export, they will be changed to ovals."
> >
>
> My bad, please send me the patch with the wording you prefer. But didn't
> you notice this message is not (yet) printed anywhere as the m_reporter
> is always null?
Here is the patch (thanks Kerusey for the hint) ... check if the meaning
is right please...
--
Marco Ciampa
I know a joke about UDP, but you might not get it.
GNU/Linux User #78271
FSFE fellow #364
>From 665bc2ed73e4226ae22de2b7110f4d34f66f405d Mon Sep 17 00:00:00 2001
From: Marco Ciampa
Date: Wed, 10 Apr 2019 08:33:41 +0200
Subject: [PATCH 1/1] Rewording of hyperlynx exporter message
---
pcbnew/exporters/export_hyperlynx.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pcbnew/exporters/export_hyperlynx.cpp b/pcbnew/exporters/export_hyperlynx.cpp
index 2b21c5c35..7b3e9be13 100644
--- a/pcbnew/exporters/export_hyperlynx.cpp
+++ b/pcbnew/exporters/export_hyperlynx.cpp
@@ -185,9 +185,9 @@ private:
if( m_reporter )
{
m_reporter->Report(
-_( "File contains pad shapes that are not supported by the "
- "Hyperlynx exporter (oval, rectangle, circle). They have been "
- "exported as oval pads." ),
+ _( "File contains pad shapes that are not supported by the "
+ "Hyperlynx exporter. Only ovals, rectangles and circles are allowed. "
+ "During export, they will be changed to ovals."),
REPORTER::RPT_WARNING );
}
break;
--
2.17.1
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] small typos (missing spaces)
> > My bad, please send me the patch with the wording you > prefer. But didn't you notice this message is not > (yet) printed anywhere as the m_reporter is always > null? > > Cheers, > Tom > I am just translating here... :( Kerusey ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] small typos (missing spaces)
On 09/04/2019 18:43, Kerusey Karyu wrote: > Guys > >> #: pcbnew/exporters/export_hyperlynx.cpp:190 >> >> m_reporter->Report( >> _( "File contains pad shapes that are not supported by the" >> "Hyperlynx exporter (oval, rectangle, circle). They have been" >> "exported as oval pads." ), >> REPORTER::RPT_WARNING ); > > Is there no contradiction here or poor wording? > > The first sentence says that oval, rectangular or circular are *not* > supported - as I understand. But finally these are still exported as > ovals, which are... after all, unsupported. > > Maybe: > > "File contains pad shapes that are not supported by the" > "Hyperlynx exporter. Only oval, rectangle, circle are allowed." > "During export, they will be changed to ovals." > My bad, please send me the patch with the wording you prefer. But didn't you notice this message is not (yet) printed anywhere as the m_reporter is always null? Cheers, Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] small typos (missing spaces)
Guys > #: pcbnew/exporters/export_hyperlynx.cpp:190 > > m_reporter->Report( > _( "File contains pad shapes that are not supported by the" > "Hyperlynx exporter (oval, rectangle, circle). They have been" > "exported as oval pads." ), > REPORTER::RPT_WARNING ); Is there no contradiction here or poor wording? The first sentence says that oval, rectangular or circular are *not* supported - as I understand. But finally these are still exported as ovals, which are... after all, unsupported. Maybe: "File contains pad shapes that are not supported by the" "Hyperlynx exporter. Only oval, rectangle, circle are allowed." "During export, they will be changed to ovals." Cheers Kerusey ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] small typos (missing spaces)
Marco, Good catch. I just pushed the fix for this. Thanks, Wayne On 4/9/2019 6:51 AM, Marco Ciampa wrote: > Small typos in here (master branch): > > #: pcbnew/exporters/export_hyperlynx.cpp:190 > > m_reporter->Report( > _( "File contains pad shapes that are not supported > by the" >"Hyperlynx exporter (oval, rectangle, circle). > They have been" >"exported as oval pads." ), > REPORTER::RPT_WARNING ); > > ... there are no spaces nor \n ... > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] small typos (missing spaces)
Small typos in here (master branch): #: pcbnew/exporters/export_hyperlynx.cpp:190 m_reporter->Report( _( "File contains pad shapes that are not supported by the" "Hyperlynx exporter (oval, rectangle, circle). They have been" "exported as oval pads." ), REPORTER::RPT_WARNING ); ... there are no spaces nor \n ... -- Marco Ciampa I know a joke about UDP, but you might not get it. GNU/Linux User #78271 FSFE fellow #364 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
