Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Simon Wells]

fair enough,

In case you missed it wx 3.1 has been announced for release on 29/02,
however this probably won't mean much until 3.2 is out as it seems
they follow the old linux numbering where odd minor is not stable

On Fri, Feb 26, 2016 at 9:30 PM, Bernhard Stegmaier
<stegma...@sw-systems.de> wrote:
> I guess the other gestures would have to be covered by wxWidgets in a way
> similar to pinch-to-zoom.
>
> You can have a look here:
>   http://docs.wxwidgets.org/trunk/classwx_mouse_event.html
> wxWidgets recently added the EVT_MAGNIFY for pinch-to-zoom, but apparently
> they didn't yet think of supporting more gestures.
>
>
> Regards,
> Bernhard
>
>
> On 2016-02-26 08:10, Simon Wells wrote:
>>
>> thanks bernhard... this has increased usability on osx for me by an
>> infinite amount Do you have any code for using 2 finger rotate in
>> 3d-viewer?
>>
>> On Fri, Feb 26, 2016 at 8:06 PM, Bernhard Stegmaier
>> <stegma...@sw-systems.de> wrote:
>>>
>>> Hi Mario,
>>>
>>> didn’t see on first glance, you mean the 3d-viewer.
>>> Yes, sorry about that… obviously the .y should be a .x in the “else if(
>>> event.ControlDown() )” block.
>>> I’ll check that tonight.
>>> I will also check the default step size.
>>>
>>>
>>> Regards,
>>> Bernhard
>>>
>>>
>>>> On 26 Feb 2016, at 07:40, Bernhard Stegmaier <stegma...@sw-systems.de>
>>>> wrote:
>>>>
>>>> Hi Mario,
>>>>
>>>> what canvas are you talking about?
>>>> What do you mean with “in steps of 6 / -6”?
>>>>
>>>>
>>>> Regards,
>>>> Bernhard
>>>>
>>>>> On 25 Feb 2016, at 23:10, Mário Luzeiro <mrluze...@ua.pt> wrote:
>>>>>
>>>>> Hi Wayne, Bernhard,
>>>>>
>>>>> I am not sure if this patch is correct.
>>>>> I updated my trunk kicad and install it (to make sure I was using the
>>>>> trunk version)
>>>>>
>>>>> First if I select the option and scroll with mouse, it will jump in the
>>>>> Y in steps of 6 / -6 .. but I am not sure how it is supposed to work (I 
>>>>> dont
>>>>> have a compatible? touchpad)
>>>>> Second, I think it breaks the previous function of vertical /
>>>>> horizontal scrolling:
>>>>>
>>>>> because if I (uncheck the option and) press shift / ctrl.. I also got
>>>>> that 6/-6 steps..
>>>>> also it only work for Y.. and not for X
>>>>>
>>>>>
>>>>> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/3d-viewer/3d_canvas.cpp#L284
>>>>>
>>>>> So I think for my case the
>>>>> if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )
>>>>>
>>>>> is not horizontal when I press the shift and scroll..
>>>>>
>>>>> Would you mind to verify?
>>>>>
>>>>> Thanks!
>>>>> Mario
>>>>>
>>>>> 
>>>>> From: Kicad-developers
>>>>> [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf 
>>>>> of
>>>>> Wayne Stambaugh [stambau...@gmail.com]
>>>>> Sent: 24 February 2016 19:56
>>>>> To: Bernhard Stegmaier
>>>>> Cc: KiCad Developers
>>>>> Subject: Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning
>>>>>
>>>>> Patch committed in r6586.  Thanks!
>>>>>
>>>>> Wayne
>>>>>
>>>>> On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:
>>>>>>
>>>>>>
>>>>>>> On 23.02.2016, at 17:44, Bernhard Stegmaier <stegma...@sw-systems.de>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> * The touchpad panning is not implemented in the component viewer,
>>>>>>>> component editor, footprint viewer, and footprint editor.  I would
>>>>>>>> think
>>>>>>>> that we would want it implemented in these windows for the sake of
>>>>>>>> consistency.  I image the first bug report filed against this patch
>>>>>>>> will
>>>>>>>> be about that.
>>>>>>>
>>>>>>>
>>>>>>

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Mário Luzeiro]

yes it is on 3d-viewer. Everytime I scroll the y coordinate "jumps" in 6 steps.
It is not usable for me :/

Mario

From: Bernhard Stegmaier [stegma...@sw-systems.de]
Sent: 26 February 2016 06:40
To: Mário Luzeiro
Cc: Wayne Stambaugh; KiCad Developers
Subject: Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

Hi Mario,

what canvas are you talking about?
What do you mean with “in steps of 6 / -6”?


Regards,
Bernhard

> On 25 Feb 2016, at 23:10, Mário Luzeiro <mrluze...@ua.pt> wrote:
>
> Hi Wayne, Bernhard,
>
> I am not sure if this patch is correct.
> I updated my trunk kicad and install it (to make sure I was using the trunk 
> version)
>
> First if I select the option and scroll with mouse, it will jump in the Y in 
> steps of 6 / -6 .. but I am not sure how it is supposed to work (I dont have 
> a compatible? touchpad)
> Second, I think it breaks the previous function of vertical / horizontal 
> scrolling:
>
> because if I (uncheck the option and) press shift / ctrl.. I also got that 
> 6/-6 steps..
> also it only work for Y.. and not for X
>
> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/3d-viewer/3d_canvas.cpp#L284
>
> So I think for my case the
> if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )
>
> is not horizontal when I press the shift and scroll..
>
> Would you mind to verify?
>
> Thanks!
> Mario
>
> 
> From: Kicad-developers 
> [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of 
> Wayne Stambaugh [stambau...@gmail.com]
> Sent: 24 February 2016 19:56
> To: Bernhard Stegmaier
> Cc: KiCad Developers
> Subject: Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning
>
> Patch committed in r6586.  Thanks!
>
> Wayne
>
> On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:
>>
>>> On 23.02.2016, at 17:44, Bernhard Stegmaier <stegma...@sw-systems.de> wrote:
>>>
>>>> * The touchpad panning is not implemented in the component viewer,
>>>> component editor, footprint viewer, and footprint editor.  I would think
>>>> that we would want it implemented in these windows for the sake of
>>>> consistency.  I image the first bug report filed against this patch will
>>>> be about that.
>>>
>>> Strange, all of them work for me on OS X, both with legacy and GAL canvas.
>>> I’ll retest on Linux.
>>>
>>> I currently couldn’t imagine any reason why it shouldn’t work in Windows…
>>> The changes are just in the EDA_DRAW_PANEL classes.
>>> Are they different on Windows?
>>
>> I just verified on my Debian/Xfce (via VirtualBox on OS X) and all of them
>> do work with touchpad-panning.
>>
>> What is the problem with it?
>> Doesn’t it pan at all?
>>
>> As said in the other mail these are the same events as for the scroll-wheel.
>> So, if the touchpad in general works with touchpad-panning disabled and
>> using shift/ctrl modifiers, it should also be OK with it enabled.
>> There is no platform magic involved...
>>
>>
>> Regards
>> Bernhard
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

I guess the other gestures would have to be covered by wxWidgets in a 
way

similar to pinch-to-zoom.

You can have a look here:
  http://docs.wxwidgets.org/trunk/classwx_mouse_event.html
wxWidgets recently added the EVT_MAGNIFY for pinch-to-zoom, but 
apparently

they didn't yet think of supporting more gestures.


Regards,
Bernhard

On 2016-02-26 08:10, Simon Wells wrote:

thanks bernhard... this has increased usability on osx for me by an
infinite amount Do you have any code for using 2 finger rotate in
3d-viewer?

On Fri, Feb 26, 2016 at 8:06 PM, Bernhard Stegmaier
<stegma...@sw-systems.de> wrote:

Hi Mario,

didn’t see on first glance, you mean the 3d-viewer.
Yes, sorry about that… obviously the .y should be a .x in the “else 
if( event.ControlDown() )” block.

I’ll check that tonight.
I will also check the default step size.


Regards,
Bernhard


On 26 Feb 2016, at 07:40, Bernhard Stegmaier 
<stegma...@sw-systems.de> wrote:


Hi Mario,

what canvas are you talking about?
What do you mean with “in steps of 6 / -6”?


Regards,
Bernhard


On 25 Feb 2016, at 23:10, Mário Luzeiro <mrluze...@ua.pt> wrote:

Hi Wayne, Bernhard,

I am not sure if this patch is correct.
I updated my trunk kicad and install it (to make sure I was using 
the trunk version)


First if I select the option and scroll with mouse, it will jump in 
the Y in steps of 6 / -6 .. but I am not sure how it is supposed to 
work (I dont have a compatible? touchpad)
Second, I think it breaks the previous function of vertical / 
horizontal scrolling:


because if I (uncheck the option and) press shift / ctrl.. I also 
got that 6/-6 steps..

also it only work for Y.. and not for X

http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/3d-viewer/3d_canvas.cpp#L284

So I think for my case the
if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )

is not horizontal when I press the shift and scroll..

Would you mind to verify?

Thanks!
Mario


From: Kicad-developers 
[kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on 
behalf of Wayne Stambaugh [stambau...@gmail.com]

Sent: 24 February 2016 19:56
To: Bernhard Stegmaier
Cc: KiCad Developers
Subject: Re: [Kicad-developers] [PATCH] New Feature: Touchpad 
Panning


Patch committed in r6586.  Thanks!

Wayne

On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:


On 23.02.2016, at 17:44, Bernhard Stegmaier 
<stegma...@sw-systems.de> wrote:


* The touchpad panning is not implemented in the component 
viewer,
component editor, footprint viewer, and footprint editor.  I 
would think
that we would want it implemented in these windows for the sake 
of
consistency.  I image the first bug report filed against this 
patch will

be about that.


Strange, all of them work for me on OS X, both with legacy and GAL 
canvas.

I’ll retest on Linux.

I currently couldn’t imagine any reason why it shouldn’t work in 
Windows…

The changes are just in the EDA_DRAW_PANEL classes.
Are they different on Windows?


I just verified on my Debian/Xfce (via VirtualBox on OS X) and all 
of them

do work with touchpad-panning.

What is the problem with it?
Doesn’t it pan at all?

As said in the other mail these are the same events as for the 
scroll-wheel.
So, if the touchpad in general works with touchpad-panning disabled 
and

using shift/ctrl modifiers, it should also be OK with it enabled.
There is no platform magic involved...


Regards
Bernhard



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Simon Wells]

thanks bernhard... this has increased usability on osx for me by an
infinite amount Do you have any code for using 2 finger rotate in
3d-viewer?

On Fri, Feb 26, 2016 at 8:06 PM, Bernhard Stegmaier
<stegma...@sw-systems.de> wrote:
> Hi Mario,
>
> didn’t see on first glance, you mean the 3d-viewer.
> Yes, sorry about that… obviously the .y should be a .x in the “else if( 
> event.ControlDown() )” block.
> I’ll check that tonight.
> I will also check the default step size.
>
>
> Regards,
> Bernhard
>
>
>> On 26 Feb 2016, at 07:40, Bernhard Stegmaier <stegma...@sw-systems.de> wrote:
>>
>> Hi Mario,
>>
>> what canvas are you talking about?
>> What do you mean with “in steps of 6 / -6”?
>>
>>
>> Regards,
>> Bernhard
>>
>>> On 25 Feb 2016, at 23:10, Mário Luzeiro <mrluze...@ua.pt> wrote:
>>>
>>> Hi Wayne, Bernhard,
>>>
>>> I am not sure if this patch is correct.
>>> I updated my trunk kicad and install it (to make sure I was using the trunk 
>>> version)
>>>
>>> First if I select the option and scroll with mouse, it will jump in the Y 
>>> in steps of 6 / -6 .. but I am not sure how it is supposed to work (I dont 
>>> have a compatible? touchpad)
>>> Second, I think it breaks the previous function of vertical / horizontal 
>>> scrolling:
>>>
>>> because if I (uncheck the option and) press shift / ctrl.. I also got that 
>>> 6/-6 steps..
>>> also it only work for Y.. and not for X
>>>
>>> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/3d-viewer/3d_canvas.cpp#L284
>>>
>>> So I think for my case the
>>> if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )
>>>
>>> is not horizontal when I press the shift and scroll..
>>>
>>> Would you mind to verify?
>>>
>>> Thanks!
>>> Mario
>>>
>>> 
>>> From: Kicad-developers 
>>> [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of 
>>> Wayne Stambaugh [stambau...@gmail.com]
>>> Sent: 24 February 2016 19:56
>>> To: Bernhard Stegmaier
>>> Cc: KiCad Developers
>>> Subject: Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning
>>>
>>> Patch committed in r6586.  Thanks!
>>>
>>> Wayne
>>>
>>> On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:
>>>>
>>>>> On 23.02.2016, at 17:44, Bernhard Stegmaier <stegma...@sw-systems.de> 
>>>>> wrote:
>>>>>
>>>>>> * The touchpad panning is not implemented in the component viewer,
>>>>>> component editor, footprint viewer, and footprint editor.  I would think
>>>>>> that we would want it implemented in these windows for the sake of
>>>>>> consistency.  I image the first bug report filed against this patch will
>>>>>> be about that.
>>>>>
>>>>> Strange, all of them work for me on OS X, both with legacy and GAL canvas.
>>>>> I’ll retest on Linux.
>>>>>
>>>>> I currently couldn’t imagine any reason why it shouldn’t work in Windows…
>>>>> The changes are just in the EDA_DRAW_PANEL classes.
>>>>> Are they different on Windows?
>>>>
>>>> I just verified on my Debian/Xfce (via VirtualBox on OS X) and all of them
>>>> do work with touchpad-panning.
>>>>
>>>> What is the problem with it?
>>>> Doesn’t it pan at all?
>>>>
>>>> As said in the other mail these are the same events as for the 
>>>> scroll-wheel.
>>>> So, if the touchpad in general works with touchpad-panning disabled and
>>>> using shift/ctrl modifiers, it should also be OK with it enabled.
>>>> There is no platform magic involved...
>>>>
>>>>
>>>> Regards
>>>> Bernhard
>>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

Hi Mario,

didn’t see on first glance, you mean the 3d-viewer.
Yes, sorry about that… obviously the .y should be a .x in the “else if( 
event.ControlDown() )” block.
I’ll check that tonight.
I will also check the default step size.


Regards,
Bernhard 


> On 26 Feb 2016, at 07:40, Bernhard Stegmaier <stegma...@sw-systems.de> wrote:
> 
> Hi Mario,
> 
> what canvas are you talking about?
> What do you mean with “in steps of 6 / -6”?
> 
> 
> Regards,
> Bernhard
> 
>> On 25 Feb 2016, at 23:10, Mário Luzeiro <mrluze...@ua.pt> wrote:
>> 
>> Hi Wayne, Bernhard,
>> 
>> I am not sure if this patch is correct.
>> I updated my trunk kicad and install it (to make sure I was using the trunk 
>> version)
>> 
>> First if I select the option and scroll with mouse, it will jump in the Y in 
>> steps of 6 / -6 .. but I am not sure how it is supposed to work (I dont have 
>> a compatible? touchpad)
>> Second, I think it breaks the previous function of vertical / horizontal 
>> scrolling:
>> 
>> because if I (uncheck the option and) press shift / ctrl.. I also got that 
>> 6/-6 steps..
>> also it only work for Y.. and not for X
>> 
>> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/3d-viewer/3d_canvas.cpp#L284
>> 
>> So I think for my case the
>> if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )
>> 
>> is not horizontal when I press the shift and scroll..
>> 
>> Would you mind to verify?
>> 
>> Thanks!
>> Mario
>> 
>> 
>> From: Kicad-developers 
>> [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of 
>> Wayne Stambaugh [stambau...@gmail.com]
>> Sent: 24 February 2016 19:56
>> To: Bernhard Stegmaier
>> Cc: KiCad Developers
>> Subject: Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning
>> 
>> Patch committed in r6586.  Thanks!
>> 
>> Wayne
>> 
>> On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:
>>> 
>>>> On 23.02.2016, at 17:44, Bernhard Stegmaier <stegma...@sw-systems.de> 
>>>> wrote:
>>>> 
>>>>> * The touchpad panning is not implemented in the component viewer,
>>>>> component editor, footprint viewer, and footprint editor.  I would think
>>>>> that we would want it implemented in these windows for the sake of
>>>>> consistency.  I image the first bug report filed against this patch will
>>>>> be about that.
>>>> 
>>>> Strange, all of them work for me on OS X, both with legacy and GAL canvas.
>>>> I’ll retest on Linux.
>>>> 
>>>> I currently couldn’t imagine any reason why it shouldn’t work in Windows…
>>>> The changes are just in the EDA_DRAW_PANEL classes.
>>>> Are they different on Windows?
>>> 
>>> I just verified on my Debian/Xfce (via VirtualBox on OS X) and all of them
>>> do work with touchpad-panning.
>>> 
>>> What is the problem with it?
>>> Doesn’t it pan at all?
>>> 
>>> As said in the other mail these are the same events as for the scroll-wheel.
>>> So, if the touchpad in general works with touchpad-panning disabled and
>>> using shift/ctrl modifiers, it should also be OK with it enabled.
>>> There is no platform magic involved...
>>> 
>>> 
>>> Regards
>>> Bernhard
>>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

Hi Mario,

what canvas are you talking about?
What do you mean with “in steps of 6 / -6”?


Regards,
Bernhard

> On 25 Feb 2016, at 23:10, Mário Luzeiro <mrluze...@ua.pt> wrote:
> 
> Hi Wayne, Bernhard,
> 
> I am not sure if this patch is correct.
> I updated my trunk kicad and install it (to make sure I was using the trunk 
> version)
> 
> First if I select the option and scroll with mouse, it will jump in the Y in 
> steps of 6 / -6 .. but I am not sure how it is supposed to work (I dont have 
> a compatible? touchpad)
> Second, I think it breaks the previous function of vertical / horizontal 
> scrolling:
> 
> because if I (uncheck the option and) press shift / ctrl.. I also got that 
> 6/-6 steps..
> also it only work for Y.. and not for X
> 
> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/3d-viewer/3d_canvas.cpp#L284
> 
> So I think for my case the
> if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )
> 
> is not horizontal when I press the shift and scroll..
> 
> Would you mind to verify?
> 
> Thanks!
> Mario
> 
> 
> From: Kicad-developers 
> [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of 
> Wayne Stambaugh [stambau...@gmail.com]
> Sent: 24 February 2016 19:56
> To: Bernhard Stegmaier
> Cc: KiCad Developers
> Subject: Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning
> 
> Patch committed in r6586.  Thanks!
> 
> Wayne
> 
> On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:
>> 
>>> On 23.02.2016, at 17:44, Bernhard Stegmaier <stegma...@sw-systems.de> wrote:
>>> 
>>>> * The touchpad panning is not implemented in the component viewer,
>>>> component editor, footprint viewer, and footprint editor.  I would think
>>>> that we would want it implemented in these windows for the sake of
>>>> consistency.  I image the first bug report filed against this patch will
>>>> be about that.
>>> 
>>> Strange, all of them work for me on OS X, both with legacy and GAL canvas.
>>> I’ll retest on Linux.
>>> 
>>> I currently couldn’t imagine any reason why it shouldn’t work in Windows…
>>> The changes are just in the EDA_DRAW_PANEL classes.
>>> Are they different on Windows?
>> 
>> I just verified on my Debian/Xfce (via VirtualBox on OS X) and all of them
>> do work with touchpad-panning.
>> 
>> What is the problem with it?
>> Doesn’t it pan at all?
>> 
>> As said in the other mail these are the same events as for the scroll-wheel.
>> So, if the touchpad in general works with touchpad-panning disabled and
>> using shift/ctrl modifiers, it should also be OK with it enabled.
>> There is no platform magic involved...
>> 
>> 
>> Regards
>> Bernhard
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Mário Luzeiro]

Hi Wayne, Bernhard,

I am not sure if this patch is correct.
I updated my trunk kicad and install it (to make sure I was using the trunk 
version)

First if I select the option and scroll with mouse, it will jump in the Y in 
steps of 6 / -6 .. but I am not sure how it is supposed to work (I dont have a 
compatible? touchpad)
Second, I think it breaks the previous function of vertical / horizontal 
scrolling:

because if I (uncheck the option and) press shift / ctrl.. I also got that 6/-6 
steps..
also it only work for Y.. and not for X

http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/3d-viewer/3d_canvas.cpp#L284

So I think for my case the
if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )

is not horizontal when I press the shift and scroll..

Would you mind to verify?

Thanks!
Mario


From: Kicad-developers 
[kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of 
Wayne Stambaugh [stambau...@gmail.com]
Sent: 24 February 2016 19:56
To: Bernhard Stegmaier
Cc: KiCad Developers
Subject: Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

Patch committed in r6586.  Thanks!

Wayne

On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:
>
>> On 23.02.2016, at 17:44, Bernhard Stegmaier <stegma...@sw-systems.de> wrote:
>>
>>> * The touchpad panning is not implemented in the component viewer,
>>> component editor, footprint viewer, and footprint editor.  I would think
>>> that we would want it implemented in these windows for the sake of
>>> consistency.  I image the first bug report filed against this patch will
>>> be about that.
>>
>> Strange, all of them work for me on OS X, both with legacy and GAL canvas.
>> I’ll retest on Linux.
>>
>> I currently couldn’t imagine any reason why it shouldn’t work in Windows…
>> The changes are just in the EDA_DRAW_PANEL classes.
>> Are they different on Windows?
>
> I just verified on my Debian/Xfce (via VirtualBox on OS X) and all of them
> do work with touchpad-panning.
>
> What is the problem with it?
> Doesn’t it pan at all?
>
> As said in the other mail these are the same events as for the scroll-wheel.
> So, if the touchpad in general works with touchpad-panning disabled and
> using shift/ctrl modifiers, it should also be OK with it enabled.
> There is no platform magic involved...
>
>
> Regards
> Bernhard
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Wayne Stambaugh]

Patch committed in r6586.  Thanks!

Wayne

On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:
> 
>> On 23.02.2016, at 17:44, Bernhard Stegmaier  wrote:
>>
>>> * The touchpad panning is not implemented in the component viewer,
>>> component editor, footprint viewer, and footprint editor.  I would think
>>> that we would want it implemented in these windows for the sake of
>>> consistency.  I image the first bug report filed against this patch will
>>> be about that.
>>
>> Strange, all of them work for me on OS X, both with legacy and GAL canvas.
>> I’ll retest on Linux.
>>
>> I currently couldn’t imagine any reason why it shouldn’t work in Windows… 
>> The changes are just in the EDA_DRAW_PANEL classes.
>> Are they different on Windows?
> 
> I just verified on my Debian/Xfce (via VirtualBox on OS X) and all of them
> do work with touchpad-panning.
> 
> What is the problem with it?
> Doesn’t it pan at all?
> 
> As said in the other mail these are the same events as for the scroll-wheel.
> So, if the touchpad in general works with touchpad-panning disabled and 
> using shift/ctrl modifiers, it should also be OK with it enabled.
> There is no platform magic involved...
> 
> 
> Regards
> Bernhard
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Wayne Stambaugh]

On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:
> 
>> On 23.02.2016, at 17:44, Bernhard Stegmaier  wrote:
>>
>>> * The touchpad panning is not implemented in the component viewer,
>>> component editor, footprint viewer, and footprint editor.  I would think
>>> that we would want it implemented in these windows for the sake of
>>> consistency.  I image the first bug report filed against this patch will
>>> be about that.
>>
>> Strange, all of them work for me on OS X, both with legacy and GAL canvas.
>> I’ll retest on Linux.
>>
>> I currently couldn’t imagine any reason why it shouldn’t work in Windows… 
>> The changes are just in the EDA_DRAW_PANEL classes.
>> Are they different on Windows?
> 
> I just verified on my Debian/Xfce (via VirtualBox on OS X) and all of them
> do work with touchpad-panning.
> 
> What is the problem with it?
> Doesn’t it pan at all?
> 
> As said in the other mail these are the same events as for the scroll-wheel.
> So, if the touchpad in general works with touchpad-panning disabled and 
> using shift/ctrl modifiers, it should also be OK with it enabled.
> There is no platform magic involved...
> 
> 
> Regards
> Bernhard
> 

OK, it looks like it was cockpit error on my part.  I get the same
behavior you described on all of the windows that have an EDA_DRAW_PANEL
so that's good.  The two finger scrolling on my win7 pro work laptop
leaves something to be desired but it does appear to work.  I could just
be my ignorance of using the two finger scrolling or maybe I need to
tweak my touchpad settings.  If no one else objects, I'll commit this
patch in the next day or so.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

> On 23.02.2016, at 17:44, Bernhard Stegmaier  wrote:
> 
>> * The touchpad panning is not implemented in the component viewer,
>> component editor, footprint viewer, and footprint editor.  I would think
>> that we would want it implemented in these windows for the sake of
>> consistency.  I image the first bug report filed against this patch will
>> be about that.
> 
> Strange, all of them work for me on OS X, both with legacy and GAL canvas.
> I’ll retest on Linux.
> 
> I currently couldn’t imagine any reason why it shouldn’t work in Windows… 
> The changes are just in the EDA_DRAW_PANEL classes.
> Are they different on Windows?

I just verified on my Debian/Xfce (via VirtualBox on OS X) and all of them
do work with touchpad-panning.

What is the problem with it?
Doesn’t it pan at all?

As said in the other mail these are the same events as for the scroll-wheel.
So, if the touchpad in general works with touchpad-panning disabled and 
using shift/ctrl modifiers, it should also be OK with it enabled.
There is no platform magic involved...


Regards
Bernhard


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

> On 23 Feb 2016, at 17:00, Wayne Stambaugh  wrote:
> 
> * Is there any reason that the mouse scroll wheel behavior has to be
> disabled to support the touchpad panning?  It's kind of a pain to switch
> it on and off when I install my mouse on my laptop.  Perhaps remapping
> the touchpad events to the appropriate mouse wheel events would do the
> trick so that both behaviors could exist at the same time.

Just a note:
The events are exactly the same for scroll-wheel or touchpad-panning.
Basically the only thing changed by this patch is to also look for the scroll 
wheel axis and to pan without any shift/ctrl modifier instead of zooming.
So, with enabled touchpad-panning when using a mouse you don’t lose
anything except zoom via wheel.

Just tested:
* Wheel or ctrl-wheel is vertical scrolling
* shift-Wheel is horizontal


Regards,
Bernhard
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

> On 23 Feb 2016, at 17:00, Wayne Stambaugh  wrote:
> 
> * In Eeschema the mouse wheel is completely disabled but in Pcbnew
> (legacy canvas) and GerbView the mouse wheel causes vertical scrolling.
> It should be consistent across all canvases.

Wait a second… did you zoom in eeschema after opening?
The default “view all” view in eeschema doesn’t scroll, you have zoom in or out 
one step.
But that is the same without my patch...


Regards,
Bernhard
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

Hi Wayne,

> On 23 Feb 2016, at 17:00, Wayne Stambaugh  wrote:
> 
> * In Eeschema the mouse wheel is completely disabled but in Pcbnew
> (legacy canvas) and GerbView the mouse wheel causes vertical scrolling.
> It should be consistent across all canvases.

You are talking about the mouse wheel of a real mouse with touchpad-panning on 
or off? With touchpad-panning off I didn’t see any any difference in behaviour 
on 
OSX/Linux with all the tests I did.

I will check, of course… especially GerbView.

> * The touchpad panning is not implemented in the component viewer,
> component editor, footprint viewer, and footprint editor.  I would think
> that we would want it implemented in these windows for the sake of
> consistency.  I image the first bug report filed against this patch will
> be about that.

Strange, all of them work for me on OS X, both with legacy and GAL canvas.
I’ll retest on Linux.

I currently couldn’t imagine any reason why it shouldn’t work in Windows… 
The changes are just in the EDA_DRAW_PANEL classes.
Are they different on Windows?

> * Is there any reason that the mouse scroll wheel behavior has to be
> disabled to support the touchpad panning?  It's kind of a pain to switch
> it on and off when I install my mouse on my laptop.  Perhaps remapping
> the touchpad events to the appropriate mouse wheel events would do the
> trick so that both behaviors could exist at the same time.

In my tests with Linux and a normal mouse on OS X mouse wheel scrolling 
did work just the same as with disabled touchpad-panning.
The only thing of course is, that it scrolls (vertical I think) when using the 
scroll wheel without any modifier (when touchpad-panning is enabled).


Regards,
Bernhard


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Wayne Stambaugh]

Bernhard,

I tested this patch on Windows and it causes some odd behavior.

* In Eeschema the mouse wheel is completely disabled but in Pcbnew
(legacy canvas) and GerbView the mouse wheel causes vertical scrolling.
It should be consistent across all canvases.

* The touchpad panning is not implemented in the component viewer,
component editor, footprint viewer, and footprint editor.  I would think
that we would want it implemented in these windows for the sake of
consistency.  I image the first bug report filed against this patch will
be about that.

* Is there any reason that the mouse scroll wheel behavior has to be
disabled to support the touchpad panning?  It's kind of a pain to switch
it on and off when I install my mouse on my laptop.  Perhaps remapping
the touchpad events to the appropriate mouse wheel events would do the
trick so that both behaviors could exist at the same time.

Thanks,

Wayne

On 2/22/2016 3:01 PM, Bernhard Stegmaier wrote:
> The retina patch is unrelated.
> It should (still) apply without any conflicts (I guess/hope, I didn’t try).
> If it doesn’t, I can generate a new one.
> 
> Attached a new patch against rev6578.
> 
> 
> Regards,
> Bernhard
> 
> 
> 
> 
> 
> 
>> On 22.02.2016, at 16:42, Wayne Stambaugh  wrote:
>>
>> Bernhard,
>>
>> I'll wait until this evening that way I can test it on linux and
>> windows.  Does the touchpad panning patch need to be applied before the
>> retina patch?
>>
>> Thanks,
>>
>> Wayne
>>
>> On 2/22/2016 10:08 AM, Bernhard Stegmaier wrote:
>>> Sure, no problem. I'll send an updated version this evening.
>>>
>>> You also could pull it directly from
>>>  https://github.com/bstegmaier75/kicad-source-mirror/tree/touchpad-panning
>>> Updated this weekend...
>>>
>>>
>>> Regards,
>>> Bernhard
>>>
>>> On 2016-02-22 15:34, Wayne Stambaugh wrote:
 Bernhard,

 This patch no longer applies cleanly.  Would you please rebase it so I
 can test it?

 Thanks,

 Wayne

 On 2/20/2016 7:56 AM, Bernhard Stegmaier wrote:
> Any plans/comments whether this one will get merged?
>
>> On 12.02.2016, at 20:38, Bernhard Stegmaier
>>  wrote:
>>
>> Hi all,
>>
>> attached a patch to add a new feature “touchpad panning”.
>> When enabled, you can pan in x/y-direction by just using usual
>> 2-finger touchpad gestures without shift/ctrl modifiers instead of
>> scroll wheel zoom.
>>
>> It is particularly useful on OS X, because any Apple touchpad/mouse
>> supports these 2-finger gestures (1-finger with MagicMouse).
>> It makes KiCad behave more like any other regular OS X application
>> and has been requested for some time by some/many OS X users.
>>
>> It is built on top of platform independent wxWidgets functions, so
>> it should work also on any other platform and device supporting x/y
>> mousewheel events and is not restricted to OS X.
>>
>> I added preference options to each application like the other
>> pan/zoom options (and a menu entry for 3d-Viewer).
>> If disabled, panning/scrolling should work the same as without the
>> patch.
>>
>> I tested it on
>> * OS X with touchpad, MagicMouse, MightMouse
>> * OS X with normal PC mouse
>> * Linux running inside a VirtualBox on OS X (debian testing with
>> xfce desktop)
>>
>> I would be great if someone could test it on native Windows/Linux
>> with a touchpad.
>> It should be OK, the only problem that I could imagine is that
>> panning speed might have to be adapted (frequency/granularity of
>> mousewheel events could be different between OS X and other
>> platforms, there are already some platform specific adaptions in the
>> code before the patch).
>>
>> Of course, any other feedback is also welcome!
>>
>> Note:
>> This patch contains the patch discussed in the other mail thread,
>> which disables framerate throttling in GAL on OS X.
>>
>>
>> Regards,
>> Bernhard
>>
>> 
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
> 

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

The retina patch is unrelated.
It should (still) apply without any conflicts (I guess/hope, I didn’t try).
If it doesn’t, I can generate a new one.

Attached a new patch against rev6578.


Regards,
Bernhard



touchpad-panning.patch
Description: Binary data



> On 22.02.2016, at 16:42, Wayne Stambaugh  wrote:
> 
> Bernhard,
> 
> I'll wait until this evening that way I can test it on linux and
> windows.  Does the touchpad panning patch need to be applied before the
> retina patch?
> 
> Thanks,
> 
> Wayne
> 
> On 2/22/2016 10:08 AM, Bernhard Stegmaier wrote:
>> Sure, no problem. I'll send an updated version this evening.
>> 
>> You also could pull it directly from
>>  https://github.com/bstegmaier75/kicad-source-mirror/tree/touchpad-panning
>> Updated this weekend...
>> 
>> 
>> Regards,
>> Bernhard
>> 
>> On 2016-02-22 15:34, Wayne Stambaugh wrote:
>>> Bernhard,
>>> 
>>> This patch no longer applies cleanly.  Would you please rebase it so I
>>> can test it?
>>> 
>>> Thanks,
>>> 
>>> Wayne
>>> 
>>> On 2/20/2016 7:56 AM, Bernhard Stegmaier wrote:
 Any plans/comments whether this one will get merged?
 
> On 12.02.2016, at 20:38, Bernhard Stegmaier
>  wrote:
> 
> Hi all,
> 
> attached a patch to add a new feature “touchpad panning”.
> When enabled, you can pan in x/y-direction by just using usual
> 2-finger touchpad gestures without shift/ctrl modifiers instead of
> scroll wheel zoom.
> 
> It is particularly useful on OS X, because any Apple touchpad/mouse
> supports these 2-finger gestures (1-finger with MagicMouse).
> It makes KiCad behave more like any other regular OS X application
> and has been requested for some time by some/many OS X users.
> 
> It is built on top of platform independent wxWidgets functions, so
> it should work also on any other platform and device supporting x/y
> mousewheel events and is not restricted to OS X.
> 
> I added preference options to each application like the other
> pan/zoom options (and a menu entry for 3d-Viewer).
> If disabled, panning/scrolling should work the same as without the
> patch.
> 
> I tested it on
> * OS X with touchpad, MagicMouse, MightMouse
> * OS X with normal PC mouse
> * Linux running inside a VirtualBox on OS X (debian testing with
> xfce desktop)
> 
> I would be great if someone could test it on native Windows/Linux
> with a touchpad.
> It should be OK, the only problem that I could imagine is that
> panning speed might have to be adapted (frequency/granularity of
> mousewheel events could be different between OS X and other
> platforms, there are already some platform specific adaptions in the
> code before the patch).
> 
> Of course, any other feedback is also welcome!
> 
> Note:
> This patch contains the patch discussed in the other mail thread,
> which disables framerate throttling in GAL on OS X.
> 
> 
> Regards,
> Bernhard
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
 
 
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Wayne Stambaugh]

Bernhard,

I'll wait until this evening that way I can test it on linux and
windows.  Does the touchpad panning patch need to be applied before the
retina patch?

Thanks,

Wayne

On 2/22/2016 10:08 AM, Bernhard Stegmaier wrote:
> Sure, no problem. I'll send an updated version this evening.
> 
> You also could pull it directly from
>   https://github.com/bstegmaier75/kicad-source-mirror/tree/touchpad-panning
> Updated this weekend...
> 
> 
> Regards,
> Bernhard
> 
> On 2016-02-22 15:34, Wayne Stambaugh wrote:
>> Bernhard,
>>
>> This patch no longer applies cleanly.  Would you please rebase it so I
>> can test it?
>>
>> Thanks,
>>
>> Wayne
>>
>> On 2/20/2016 7:56 AM, Bernhard Stegmaier wrote:
>>> Any plans/comments whether this one will get merged?
>>>
 On 12.02.2016, at 20:38, Bernhard Stegmaier
  wrote:

 Hi all,

 attached a patch to add a new feature “touchpad panning”.
 When enabled, you can pan in x/y-direction by just using usual
 2-finger touchpad gestures without shift/ctrl modifiers instead of
 scroll wheel zoom.

 It is particularly useful on OS X, because any Apple touchpad/mouse
 supports these 2-finger gestures (1-finger with MagicMouse).
 It makes KiCad behave more like any other regular OS X application
 and has been requested for some time by some/many OS X users.

 It is built on top of platform independent wxWidgets functions, so
 it should work also on any other platform and device supporting x/y
 mousewheel events and is not restricted to OS X.

 I added preference options to each application like the other
 pan/zoom options (and a menu entry for 3d-Viewer).
 If disabled, panning/scrolling should work the same as without the
 patch.

 I tested it on
 * OS X with touchpad, MagicMouse, MightMouse
 * OS X with normal PC mouse
 * Linux running inside a VirtualBox on OS X (debian testing with
 xfce desktop)

 I would be great if someone could test it on native Windows/Linux
 with a touchpad.
 It should be OK, the only problem that I could imagine is that
 panning speed might have to be adapted (frequency/granularity of
 mousewheel events could be different between OS X and other
 platforms, there are already some platform specific adaptions in the
 code before the patch).

 Of course, any other feedback is also welcome!

 Note:
 This patch contains the patch discussed in the other mail thread,
 which disables framerate throttling in GAL on OS X.


 Regards,
 Bernhard

 

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

Sure, no problem. I'll send an updated version this evening.

You also could pull it directly from
  
https://github.com/bstegmaier75/kicad-source-mirror/tree/touchpad-panning

Updated this weekend...


Regards,
Bernhard

On 2016-02-22 15:34, Wayne Stambaugh wrote:

Bernhard,

This patch no longer applies cleanly.  Would you please rebase it so I
can test it?

Thanks,

Wayne

On 2/20/2016 7:56 AM, Bernhard Stegmaier wrote:

Any plans/comments whether this one will get merged?

On 12.02.2016, at 20:38, Bernhard Stegmaier  
wrote:


Hi all,

attached a patch to add a new feature “touchpad panning”.
When enabled, you can pan in x/y-direction by just using usual 
2-finger touchpad gestures without shift/ctrl modifiers instead of 
scroll wheel zoom.


It is particularly useful on OS X, because any Apple touchpad/mouse 
supports these 2-finger gestures (1-finger with MagicMouse).
It makes KiCad behave more like any other regular OS X application 
and has been requested for some time by some/many OS X users.


It is built on top of platform independent wxWidgets functions, so it 
should work also on any other platform and device supporting x/y 
mousewheel events and is not restricted to OS X.


I added preference options to each application like the other 
pan/zoom options (and a menu entry for 3d-Viewer).
If disabled, panning/scrolling should work the same as without the 
patch.


I tested it on
* OS X with touchpad, MagicMouse, MightMouse
* OS X with normal PC mouse
* Linux running inside a VirtualBox on OS X (debian testing with xfce 
desktop)


I would be great if someone could test it on native Windows/Linux 
with a touchpad.
It should be OK, the only problem that I could imagine is that 
panning speed might have to be adapted (frequency/granularity of 
mousewheel events could be different between OS X and other 
platforms, there are already some platform specific adaptions in the 
code before the patch).


Of course, any other feedback is also welcome!

Note:
This patch contains the patch discussed in the other mail thread, 
which disables framerate throttling in GAL on OS X.



Regards,
Bernhard



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Wayne Stambaugh]

Bernhard,

This patch no longer applies cleanly.  Would you please rebase it so I
can test it?

Thanks,

Wayne

On 2/20/2016 7:56 AM, Bernhard Stegmaier wrote:
> Any plans/comments whether this one will get merged?
> 
>> On 12.02.2016, at 20:38, Bernhard Stegmaier  wrote:
>>
>> Hi all,
>>
>> attached a patch to add a new feature “touchpad panning”.
>> When enabled, you can pan in x/y-direction by just using usual 2-finger 
>> touchpad gestures without shift/ctrl modifiers instead of scroll wheel zoom.
>>
>> It is particularly useful on OS X, because any Apple touchpad/mouse supports 
>> these 2-finger gestures (1-finger with MagicMouse). 
>> It makes KiCad behave more like any other regular OS X application and has 
>> been requested for some time by some/many OS X users.
>>
>> It is built on top of platform independent wxWidgets functions, so it should 
>> work also on any other platform and device supporting x/y mousewheel events 
>> and is not restricted to OS X.
>>
>> I added preference options to each application like the other pan/zoom 
>> options (and a menu entry for 3d-Viewer).
>> If disabled, panning/scrolling should work the same as without the patch.
>>
>> I tested it on
>> * OS X with touchpad, MagicMouse, MightMouse
>> * OS X with normal PC mouse
>> * Linux running inside a VirtualBox on OS X (debian testing with xfce 
>> desktop)
>>
>> I would be great if someone could test it on native Windows/Linux with a 
>> touchpad.
>> It should be OK, the only problem that I could imagine is that panning speed 
>> might have to be adapted (frequency/granularity of mousewheel events could 
>> be different between OS X and other platforms, there are already some 
>> platform specific adaptions in the code before the patch).
>>
>> Of course, any other feedback is also welcome!
>>
>> Note:
>> This patch contains the patch discussed in the other mail thread, which 
>> disables framerate throttling in GAL on OS X.
>>
>>
>> Regards,
>> Bernhard
>>
>> 
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Wayne Stambaugh]

On 2/22/2016 8:57 AM, Tomasz Wlostowski wrote:
> On 20.02.2016 13:56, Bernhard Stegmaier wrote:
>> Any plans/comments whether this one will get merged?
> 
> Hi Bernard,
> 
> I don't have a Mac, so I can't test the OSX changes myself, but as no
> one among the OSX Kicad has complained for the last 2 weeks, I'd vote
> for merging it...

Has any one tested it on windows and/or linux?  There are quite a few
changes that are not OSX specific so we need to make sure it doesn't
break the existing behavior before I commit it.  I'll try to test it
today on windows.

> 
> Cheers,
> Tom
>>
>>> On 12.02.2016, at 20:38, Bernhard Stegmaier  wrote:
>>>
>>> Hi all,
>>>
>>> attached a patch to add a new feature “touchpad panning”.
>>> When enabled, you can pan in x/y-direction by just using usual 2-finger 
>>> touchpad gestures without shift/ctrl modifiers instead of scroll wheel zoom.
>>>
>>> It is particularly useful on OS X, because any Apple touchpad/mouse 
>>> supports these 2-finger gestures (1-finger with MagicMouse). 
>>> It makes KiCad behave more like any other regular OS X application and has 
>>> been requested for some time by some/many OS X users.
>>>
>>> It is built on top of platform independent wxWidgets functions, so it 
>>> should work also on any other platform and device supporting x/y mousewheel 
>>> events and is not restricted to OS X.
>>>
>>> I added preference options to each application like the other pan/zoom 
>>> options (and a menu entry for 3d-Viewer).
>>> If disabled, panning/scrolling should work the same as without the patch.
>>>
>>> I tested it on
>>> * OS X with touchpad, MagicMouse, MightMouse
>>> * OS X with normal PC mouse
>>> * Linux running inside a VirtualBox on OS X (debian testing with xfce 
>>> desktop)
>>>
>>> I would be great if someone could test it on native Windows/Linux with a 
>>> touchpad.
>>> It should be OK, the only problem that I could imagine is that panning 
>>> speed might have to be adapted (frequency/granularity of mousewheel events 
>>> could be different between OS X and other platforms, there are already some 
>>> platform specific adaptions in the code before the patch).
>>>
>>> Of course, any other feedback is also welcome!
>>>
>>> Note:
>>> This patch contains the patch discussed in the other mail thread, which 
>>> disables framerate throttling in GAL on OS X.
>>>
>>>
>>> Regards,
>>> Bernhard
>>>
>>> 
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Tomasz Wlostowski]

On 20.02.2016 13:56, Bernhard Stegmaier wrote:
> Any plans/comments whether this one will get merged?

Hi Bernard,

I don't have a Mac, so I can't test the OSX changes myself, but as no
one among the OSX Kicad has complained for the last 2 weeks, I'd vote
for merging it...

Cheers,
Tom
> 
>> On 12.02.2016, at 20:38, Bernhard Stegmaier  wrote:
>>
>> Hi all,
>>
>> attached a patch to add a new feature “touchpad panning”.
>> When enabled, you can pan in x/y-direction by just using usual 2-finger 
>> touchpad gestures without shift/ctrl modifiers instead of scroll wheel zoom.
>>
>> It is particularly useful on OS X, because any Apple touchpad/mouse supports 
>> these 2-finger gestures (1-finger with MagicMouse). 
>> It makes KiCad behave more like any other regular OS X application and has 
>> been requested for some time by some/many OS X users.
>>
>> It is built on top of platform independent wxWidgets functions, so it should 
>> work also on any other platform and device supporting x/y mousewheel events 
>> and is not restricted to OS X.
>>
>> I added preference options to each application like the other pan/zoom 
>> options (and a menu entry for 3d-Viewer).
>> If disabled, panning/scrolling should work the same as without the patch.
>>
>> I tested it on
>> * OS X with touchpad, MagicMouse, MightMouse
>> * OS X with normal PC mouse
>> * Linux running inside a VirtualBox on OS X (debian testing with xfce 
>> desktop)
>>
>> I would be great if someone could test it on native Windows/Linux with a 
>> touchpad.
>> It should be OK, the only problem that I could imagine is that panning speed 
>> might have to be adapted (frequency/granularity of mousewheel events could 
>> be different between OS X and other platforms, there are already some 
>> platform specific adaptions in the code before the patch).
>>
>> Of course, any other feedback is also welcome!
>>
>> Note:
>> This patch contains the patch discussed in the other mail thread, which 
>> disables framerate throttling in GAL on OS X.
>>
>>
>> Regards,
>> Bernhard
>>
>> 
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

[Bernhard Stegmaier]

Any plans/comments whether this one will get merged?

> On 12.02.2016, at 20:38, Bernhard Stegmaier  wrote:
> 
> Hi all,
> 
> attached a patch to add a new feature “touchpad panning”.
> When enabled, you can pan in x/y-direction by just using usual 2-finger 
> touchpad gestures without shift/ctrl modifiers instead of scroll wheel zoom.
> 
> It is particularly useful on OS X, because any Apple touchpad/mouse supports 
> these 2-finger gestures (1-finger with MagicMouse). 
> It makes KiCad behave more like any other regular OS X application and has 
> been requested for some time by some/many OS X users.
> 
> It is built on top of platform independent wxWidgets functions, so it should 
> work also on any other platform and device supporting x/y mousewheel events 
> and is not restricted to OS X.
> 
> I added preference options to each application like the other pan/zoom 
> options (and a menu entry for 3d-Viewer).
> If disabled, panning/scrolling should work the same as without the patch.
> 
> I tested it on
> * OS X with touchpad, MagicMouse, MightMouse
> * OS X with normal PC mouse
> * Linux running inside a VirtualBox on OS X (debian testing with xfce desktop)
> 
> I would be great if someone could test it on native Windows/Linux with a 
> touchpad.
> It should be OK, the only problem that I could imagine is that panning speed 
> might have to be adapted (frequency/granularity of mousewheel events could be 
> different between OS X and other platforms, there are already some platform 
> specific adaptions in the code before the patch).
> 
> Of course, any other feedback is also welcome!
> 
> Note:
> This patch contains the patch discussed in the other mail thread, which 
> disables framerate throttling in GAL on OS X.
> 
> 
> Regards,
> Bernhard
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp