Re: [Kicad-developers] [PATCH] PL Editor UI improvements

[Michael Kavanagh]

The typical terminology I've come across in other EDA suites is either
"border" or frame". I feel "template" could be confused with the "New
project from template" function in the KiCad Manager.

I think the task of integrating these functions into the eeschema/pcbnew is
beyond my ability at the moment, although I do think it is a good idea.

Michael


On 30 August 2017 at 19:37, Ruth Ivimey-Cook  wrote:

> Michael
>
> Is it very clear from the context what a 'worksheet' is?  Is worksheet a
> term that is used in multiple other relevant applications?
>
> Although it is longer (which I dislike) at least the 'layout' version
> gives additional information that would assist a reader in determining its
> purpose and remembering that. In general: good UX design involves reducing
> cognitive load.
>
> I wonder if using the word 'template' helps?
>
>- Worksheet Layout Editor
>- Worksheet Templates
>- Worksheet Template Manager
>- Drawing Template Editor
>- Drawing Templates
>
> I agree it would be good to merge the tools for this editor with others,
> such that UI actions & appearance possible in one are also elsewhere
> (consistency); however I can see a point in having the worksheet be edited
> using a tool that knows what it is editing, and thus can offer appropriate
> help and context.
>
> On 29/08/2017 20:53, Michael Kavanagh wrote:
>
> Cheers! Sorry about the policy violations, I'll be more careful next time.
> Which of "Worksheet Editor"/"Worksheet Layout Editor" would be the
> preferred application name? I like the former best.
>
> Regards,
> Michael
>
> On 29 August 2017 at 17:25, Wayne Stambaugh  wrote:
>
>> Michael,
>
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] PL Editor UI improvements

[Tomasz Wlostowski]

On 30.08.2017 15:08, Wayne Stambaugh wrote:
> I prefer "Worksheet Editor" but either one works for me.  If no one else
> objects, I would go with that.
> 
> On 8/29/2017 3:53 PM, Michael Kavanagh wrote:
>> Cheers! Sorry about the policy violations, I'll be more careful next time.
>> Which of "Worksheet Editor"/"Worksheet Layout Editor" would be the
>> preferred application name? I like the former best.

Hi,

Sorry for diverging from the original subject, but wouldn't it be
simpler to add an option to export worksheets (from the graphical
primitives) in eeschema/pcbnew instead of maintaining a separate
worksheet editor program?

-- my 5 cents,
Tom


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] PL Editor UI improvements

[Wayne Stambaugh]

I prefer "Worksheet Editor" but either one works for me.  If no one else
objects, I would go with that.

On 8/29/2017 3:53 PM, Michael Kavanagh wrote:
> Cheers! Sorry about the policy violations, I'll be more careful next time.
> Which of "Worksheet Editor"/"Worksheet Layout Editor" would be the
> preferred application name? I like the former best.
> 
> Regards,
> Michael
> 
> On 29 August 2017 at 17:25, Wayne Stambaugh  > wrote:
> 
> Michael,
> 
> I committed your patch to the master branch.  Thank you for your
> contribution to KiCad.  I did notice a few minor coding policy issues.
> It appears that you followed the previous coding violations (missing
> spaces between braces) when you made some of your changes.  In the
> future, please fix coding policy violations when you find them.
> 
> Thank you for deciding to look into the worksheet transition as a
> separate patch.  I don't know how long you have been lurking on the
> developers mailing list but the preference is small patches whenever
> possible.  It makes reviewing them far easier.
> 
> Cheers,
> 
> Wayne
> 
> On 8/29/2017 11:14 AM, Michael Kavanagh wrote:
> > Hi,
> >
> > I have attached an updated patch, reverting back to the "Append"
> > terminology. I will look into transitioning over to using "worksheet"
> > but this looks like a fairly big task.
> >
> > Regards,
> > Michael
> >
> > On 29 August 2017 at 09:35, Michael Kavanagh 
> 
> >  >> wrote:
> >
> >     Hi Orson,
> >
> >     I used that term because I felt it was more 'user friendly' than
> >     append. I shall attach an updated patch when I get the chance
> >     hopefully tonight.
> >
> >     Following from Olivers message on "[PATCH] minor icon improvements",
> >     I noticed the KiCad manager uses the term "Worksheet layout editor"
> >     in the tooltip for the page layout editor in the main toolbar. Do
> >     people prefer the term "Page layout" or "worksheet"? I prefer the
> >     latter as in my opinion its more succinct and less likely to confuse
> >     "page layout" with "page settings". I can include the changes to
> >     using "worksheet" in the same patch if you think this is a good 
> idea.
> >
> >     Regards,
> >     Michael
> >
> >     On 29 August 2017 at 08:16, Maciej Sumiński 
> 
> >      >> wrote:
> >
> >         Hi Michael,
> >
> >         Thank you for your contribution. I like the changes, but I
> would
> >         keep
> >         'Append' rather than 'Import'. In my opinion it is a better
> >         description
> >         for the action.
> >
> >         Regards,
> >         Orson
> >
> >         On 08/27/2017 11:12 PM, Michael Kavanagh wrote:
> >         > Dear All,
> >         > I am a university EEE student looking to start
> contributing to
> >         the KiCad
> >         > project. I have little/no experience with such large coding
> >         projects so am
> >         > starting small. Through my summer internships I have gained
> >         some good
> >         > experience with "Enterprise Class" EDA tools.
> >         > Please find attached my first small patch with some UI
> >         improvements for the
> >         > page layout editor.
> >         > Hopefully this is okay. Please let me know if there is
> >         anything I need to
> >         > change.
> >         > Kind regards,
> >         > Michael
> >         >
> >         >
> >         >
> >         > ___
> >         > Mailing list: https://launchpad.net/~kicad-developers
> 
> >          >
> >         > Post to     : kicad-developers@lists.launchpad.net
> 
> >          >
> >         > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> >          >
> >         > More help   : https://help.launchpad.net/ListHelp
> 
> >          >
> >         >
> >
> >
>

Re: [Kicad-developers] [PATCH] PL Editor UI improvements

[Michael Kavanagh]

Cheers! Sorry about the policy violations, I'll be more careful next time.
Which of "Worksheet Editor"/"Worksheet Layout Editor" would be the
preferred application name? I like the former best.

Regards,
Michael

On 29 August 2017 at 17:25, Wayne Stambaugh  wrote:

> Michael,
>
> I committed your patch to the master branch.  Thank you for your
> contribution to KiCad.  I did notice a few minor coding policy issues.
> It appears that you followed the previous coding violations (missing
> spaces between braces) when you made some of your changes.  In the
> future, please fix coding policy violations when you find them.
>
> Thank you for deciding to look into the worksheet transition as a
> separate patch.  I don't know how long you have been lurking on the
> developers mailing list but the preference is small patches whenever
> possible.  It makes reviewing them far easier.
>
> Cheers,
>
> Wayne
>
> On 8/29/2017 11:14 AM, Michael Kavanagh wrote:
> > Hi,
> >
> > I have attached an updated patch, reverting back to the "Append"
> > terminology. I will look into transitioning over to using "worksheet"
> > but this looks like a fairly big task.
> >
> > Regards,
> > Michael
> >
> > On 29 August 2017 at 09:35, Michael Kavanagh  > > wrote:
> >
> > Hi Orson,
> >
> > I used that term because I felt it was more 'user friendly' than
> > append. I shall attach an updated patch when I get the chance
> > hopefully tonight.
> >
> > Following from Olivers message on "[PATCH] minor icon improvements",
> > I noticed the KiCad manager uses the term "Worksheet layout editor"
> > in the tooltip for the page layout editor in the main toolbar. Do
> > people prefer the term "Page layout" or "worksheet"? I prefer the
> > latter as in my opinion its more succinct and less likely to confuse
> > "page layout" with "page settings". I can include the changes to
> > using "worksheet" in the same patch if you think this is a good idea.
> >
> > Regards,
> > Michael
> >
> > On 29 August 2017 at 08:16, Maciej Sumiński  > > wrote:
> >
> > Hi Michael,
> >
> > Thank you for your contribution. I like the changes, but I would
> > keep
> > 'Append' rather than 'Import'. In my opinion it is a better
> > description
> > for the action.
> >
> > Regards,
> > Orson
> >
> > On 08/27/2017 11:12 PM, Michael Kavanagh wrote:
> > > Dear All,
> > > I am a university EEE student looking to start contributing to
> > the KiCad
> > > project. I have little/no experience with such large coding
> > projects so am
> > > starting small. Through my summer internships I have gained
> > some good
> > > experience with "Enterprise Class" EDA tools.
> > > Please find attached my first small patch with some UI
> > improvements for the
> > > page layout editor.
> > > Hopefully this is okay. Please let me know if there is
> > anything I need to
> > > change.
> > > Kind regards,
> > > Michael
> > >
> > >
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > > Post to : kicad-developers@lists.launchpad.net
> > 
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > > More help   : https://help.launchpad.net/ListHelp
> > 
> > >
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > More help   : https://help.launchpad.net/ListHelp
> > 
> >
> >
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Re: [Kicad-developers] [PATCH] PL Editor UI improvements

[Wayne Stambaugh]

Michael,

I committed your patch to the master branch.  Thank you for your
contribution to KiCad.  I did notice a few minor coding policy issues.
It appears that you followed the previous coding violations (missing
spaces between braces) when you made some of your changes.  In the
future, please fix coding policy violations when you find them.

Thank you for deciding to look into the worksheet transition as a
separate patch.  I don't know how long you have been lurking on the
developers mailing list but the preference is small patches whenever
possible.  It makes reviewing them far easier.

Cheers,

Wayne

On 8/29/2017 11:14 AM, Michael Kavanagh wrote:
> Hi,
> 
> I have attached an updated patch, reverting back to the "Append"
> terminology. I will look into transitioning over to using "worksheet"
> but this looks like a fairly big task.
> 
> Regards,
> Michael
> 
> On 29 August 2017 at 09:35, Michael Kavanagh  > wrote:
> 
> Hi Orson,
> 
> I used that term because I felt it was more 'user friendly' than
> append. I shall attach an updated patch when I get the chance
> hopefully tonight.
> 
> Following from Olivers message on "[PATCH] minor icon improvements",
> I noticed the KiCad manager uses the term "Worksheet layout editor"
> in the tooltip for the page layout editor in the main toolbar. Do
> people prefer the term "Page layout" or "worksheet"? I prefer the
> latter as in my opinion its more succinct and less likely to confuse
> "page layout" with "page settings". I can include the changes to
> using "worksheet" in the same patch if you think this is a good idea.
> 
> Regards,
> Michael
> 
> On 29 August 2017 at 08:16, Maciej Sumiński  > wrote:
> 
> Hi Michael,
> 
> Thank you for your contribution. I like the changes, but I would
> keep
> 'Append' rather than 'Import'. In my opinion it is a better
> description
> for the action.
> 
> Regards,
> Orson
> 
> On 08/27/2017 11:12 PM, Michael Kavanagh wrote:
> > Dear All,
> > I am a university EEE student looking to start contributing to
> the KiCad
> > project. I have little/no experience with such large coding
> projects so am
> > starting small. Through my summer internships I have gained
> some good
> > experience with "Enterprise Class" EDA tools.
> > Please find attached my first small patch with some UI
> improvements for the
> > page layout editor.
> > Hopefully this is okay. Please let me know if there is
> anything I need to
> > change.
> > Kind regards,
> > Michael
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> >
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] PL Editor UI improvements

[Michael Kavanagh]

Hi,

I have attached an updated patch, reverting back to the "Append"
terminology. I will look into transitioning over to using "worksheet" but
this looks like a fairly big task.

Regards,
Michael

On 29 August 2017 at 09:35, Michael Kavanagh 
wrote:

> Hi Orson,
>
> I used that term because I felt it was more 'user friendly' than append. I
> shall attach an updated patch when I get the chance hopefully tonight.
>
> Following from Olivers message on "[PATCH] minor icon improvements", I
> noticed the KiCad manager uses the term "Worksheet layout editor" in the
> tooltip for the page layout editor in the main toolbar. Do people prefer
> the term "Page layout" or "worksheet"? I prefer the latter as in my opinion
> its more succinct and less likely to confuse "page layout" with "page
> settings". I can include the changes to using "worksheet" in the same patch
> if you think this is a good idea.
>
> Regards,
> Michael
>
> On 29 August 2017 at 08:16, Maciej Sumiński 
> wrote:
>
>> Hi Michael,
>>
>> Thank you for your contribution. I like the changes, but I would keep
>> 'Append' rather than 'Import'. In my opinion it is a better description
>> for the action.
>>
>> Regards,
>> Orson
>>
>> On 08/27/2017 11:12 PM, Michael Kavanagh wrote:
>> > Dear All,
>> > I am a university EEE student looking to start contributing to the KiCad
>> > project. I have little/no experience with such large coding projects so
>> am
>> > starting small. Through my summer internships I have gained some good
>> > experience with "Enterprise Class" EDA tools.
>> > Please find attached my first small patch with some UI improvements for
>> the
>> > page layout editor.
>> > Hopefully this is okay. Please let me know if there is anything I need
>> to
>> > change.
>> > Kind regards,
>> > Michael
>> >
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>


0001-PL-Editor-UI-Improvements-Menubar-toolbar-and-hotkey.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] PL Editor UI improvements

[Michael Kavanagh]

Hi Orson,

I used that term because I felt it was more 'user friendly' than append. I
shall attach an updated patch when I get the chance hopefully tonight.

Following from Olivers message on "[PATCH] minor icon improvements", I
noticed the KiCad manager uses the term "Worksheet layout editor" in the
tooltip for the page layout editor in the main toolbar. Do people prefer
the term "Page layout" or "worksheet"? I prefer the latter as in my opinion
its more succinct and less likely to confuse "page layout" with "page
settings". I can include the changes to using "worksheet" in the same patch
if you think this is a good idea.

Regards,
Michael

On 29 August 2017 at 08:16, Maciej Sumiński  wrote:

> Hi Michael,
>
> Thank you for your contribution. I like the changes, but I would keep
> 'Append' rather than 'Import'. In my opinion it is a better description
> for the action.
>
> Regards,
> Orson
>
> On 08/27/2017 11:12 PM, Michael Kavanagh wrote:
> > Dear All,
> > I am a university EEE student looking to start contributing to the KiCad
> > project. I have little/no experience with such large coding projects so
> am
> > starting small. Through my summer internships I have gained some good
> > experience with "Enterprise Class" EDA tools.
> > Please find attached my first small patch with some UI improvements for
> the
> > page layout editor.
> > Hopefully this is okay. Please let me know if there is anything I need to
> > change.
> > Kind regards,
> > Michael
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] PL Editor UI improvements

[Maciej Sumiński]

Hi Michael,

Thank you for your contribution. I like the changes, but I would keep
'Append' rather than 'Import'. In my opinion it is a better description
for the action.

Regards,
Orson

On 08/27/2017 11:12 PM, Michael Kavanagh wrote:
> Dear All,
> I am a university EEE student looking to start contributing to the KiCad
> project. I have little/no experience with such large coding projects so am
> starting small. Through my summer internships I have gained some good
> experience with "Enterprise Class" EDA tools.
> Please find attached my first small patch with some UI improvements for the
> page layout editor.
> Hopefully this is okay. Please let me know if there is anything I need to
> change.
> Kind regards,
> Michael
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] PL Editor UI improvements

[Wayne Stambaugh]

Michael,

Thank you for your interest in contributing to KiCad and welcome to the
KiCad developers mailing list.  We can always use the help especially
when it comes to our UI.

I looked at your patch and everything looks fine.  I will merge it as
soon as I get a chance.  Thank you for your contribution to KiCad.

Cheers,

Wayne

On 8/27/2017 5:12 PM, Michael Kavanagh wrote:
> Dear All,
> I am a university EEE student looking to start contributing to the KiCad
> project. I have little/no experience with such large coding projects so
> am starting small. Through my summer internships I have gained some good
> experience with "Enterprise Class" EDA tools.
> Please find attached my first small patch with some UI improvements for
> the page layout editor.
> Hopefully this is okay. Please let me know if there is anything I need
> to change.
> Kind regards,
> Michael
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp