Re: [Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

[Wayne Stambaugh]

No problem.  I think the original concern was abuse of virtual not the
use of override.  If Simon R doesn't have time to fix this, I'm not
opposed to applying your patch temporarily until we can get it resolved.

On 9/21/2016 4:57 PM, Simon Wells wrote:
> Oh my apologies wayne, i vaguely remembered them being discussed on
> list and i thought that it was decided that it wasn't an issue or
> something
> 
> On Thu, Sep 22, 2016 at 8:48 AM, Wayne Stambaugh  wrote:
>> Simon,
>>
>> Simon Richter had a patch with all or most of the overrides warnings
>> fixed.  I asked him to rebase it so I could get it merged because it was
>> out of sync.  That was a while ago.  I haven't heard anything from him
>> since then unless I missed it.  I actually like the override since it
>> specifically makes the intention of the developer known.  As long as we
>> don't abuse virtual in base classes, I would like to see this fixed now
>> that we are officially a c+11 project rather than just disable the
>> warning.  I understand all the build warnings are annoying but we should
>> start fixing them unless we have a good reason not to.  This would be a
>> big step forward in that regard.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 9/21/2016 4:01 PM, Simon Wells wrote:
>>> ---
>>>  CMakeLists.txt | 5 +
>>>  1 file changed, 5 insertions(+)
>>>
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

[Simon Wells]

Oh my apologies wayne, i vaguely remembered them being discussed on
list and i thought that it was decided that it wasn't an issue or
something

On Thu, Sep 22, 2016 at 8:48 AM, Wayne Stambaugh  wrote:
> Simon,
>
> Simon Richter had a patch with all or most of the overrides warnings
> fixed.  I asked him to rebase it so I could get it merged because it was
> out of sync.  That was a while ago.  I haven't heard anything from him
> since then unless I missed it.  I actually like the override since it
> specifically makes the intention of the developer known.  As long as we
> don't abuse virtual in base classes, I would like to see this fixed now
> that we are officially a c+11 project rather than just disable the
> warning.  I understand all the build warnings are annoying but we should
> start fixing them unless we have a good reason not to.  This would be a
> big step forward in that regard.
>
> Cheers,
>
> Wayne
>
> On 9/21/2016 4:01 PM, Simon Wells wrote:
>> ---
>>  CMakeLists.txt | 5 +
>>  1 file changed, 5 insertions(+)
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

[Wayne Stambaugh]

Simon,

Simon Richter had a patch with all or most of the overrides warnings
fixed.  I asked him to rebase it so I could get it merged because it was
out of sync.  That was a while ago.  I haven't heard anything from him
since then unless I missed it.  I actually like the override since it
specifically makes the intention of the developer known.  As long as we
don't abuse virtual in base classes, I would like to see this fixed now
that we are officially a c+11 project rather than just disable the
warning.  I understand all the build warnings are annoying but we should
start fixing them unless we have a good reason not to.  This would be a
big step forward in that regard.

Cheers,

Wayne

On 9/21/2016 4:01 PM, Simon Wells wrote:
> ---
>  CMakeLists.txt | 5 +
>  1 file changed, 5 insertions(+)
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp