Re: [Kicad-developers] 5.1.5 release status

[Carsten Schoenert]

Hi Ian,

Am 23.10.19 um 18:59 schrieb Ian McInerney:
> Carsten, I just made a merge request on the Debian packaging repo to do
> this. Can you take a look at it and comment? After this change, I see
> the -DNDEBUG appearing in the compile command when I do a local build on
> my machine.

thanks, I merged your PR right now.

-- 
Regards
Carsten Schoenert

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Ian McInerney]

This looks to be Debian specific. The build logs for the most recent Fedora
build [1] show -DNDEBUG in the flags but the Debian build log [2] does not.
It looks like the release type is not being specified properly in the
Debian packaging since they are forcing the release type to None (they use
custom flags and do not want CMake to actually set any flags itself
apparently [3, 4]). Therefore, we will need to add the flag in manually.

Carsten, I just made a merge request on the Debian packaging repo to do
this. Can you take a look at it and comment? After this change, I see the
-DNDEBUG appearing in the compile command when I do a local build on my
machine.

-Ian

[1]
https://kojipkgs.fedoraproject.org//packages/kicad/5.1.4/5.fc32/data/logs/x86_64/build.log
[2]
https://buildd.debian.org/status/fetch.php?pkg=kicad=amd64=5.1.4%2Bdfsg1-2=1570912510=0
[3]
https://github.com/Debian/debhelper/blob/master/lib/Debian/Debhelper/Buildsystem/cmake.pm
[4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=701233

On Wed, Oct 23, 2019 at 4:42 PM Wayne Stambaugh 
wrote:

> I see -DNDEBUG defined in windows release builds where CMake is
> configured with -DCMAKE_BUILD_TYPE=Release.  Is this not the case with
> Linux and/or macos?  Did we make the mistake of doing something like:
>
> set( CMAKE_COMPILER_FLAGS "-foo" )
>
> instead of:
>
> set( CMAKE_COMPILER_FLAGS "${CMAKE_COMPILER_FLAGS} -foo" )
>
> in one of the none windows build code paths?  Doing this will wipe out
> any compiler flags set by CMake.
>
> On 10/23/2019 11:16 AM, Ian McInerney wrote:
> > It looks like the build flags for KiCad are not getting NDEBUG defined
> > to remove the assertions. We should add -DNDEBUG to the flags passed
> > into CMake alongside the Debian flags.
> >
> > -Ian
> >
> > On Wed, Oct 23, 2019 at 6:38 AM Carsten Schoenert
> > mailto:c.schoen...@t-online.de>> wrote:
> >
> > Hello Seth,
> >
> > Am 22.10.19 um 18:10 schrieb Seth Hillbrand:
> > > Why do you have "hardening=+all" enabled?
> >
> > mostly because this is the default for building binary packages with
> > enabled hardening.
> >
> > https://wiki.debian.org/Hardening#Using_Hardening_Options
> >
> > > This is likely where the assertions are happening.  We might
> consider
> > >  "hardening=-all,+format,+fortify"
> > I'm not that deep into the details here or at least would need to
> keep
> > reading some stuff. But as far I've understand the hardening flags
> > should have no effect on this.
> >
> > Maybe Simon can give some enlightenment on this?
> >
> > --
> > Regards
> > Carsten Schoenert
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

No problem.  Unless something critical happens between now and then, I
will tag the 5.1 branch Friday around 12PM EDT.  If anyone has any last
minute bug fixes to commit to the 5.1 branch, now would be a good time.

Cheers,

Wayne

On 10/23/2019 10:31 AM, Adam Wolf wrote:
> It may take me another few days to get the wx-built-without-debug on
> releases setup in kicad-macos-builder, but that won't be source
> changes.  I can get it ready and then use the rc code for it, and get
> folks to test.
> 
> Adam
> 
> On Wed, Oct 23, 2019 at 8:50 AM Wayne Stambaugh  wrote:
>>
>> Now that JP fixed lp:1849289[1], is there anything else that needs to be
>> fixed before I tag rc1?  If not, I will tag it Friday.  That means that
>> we will be in a string freeze until the 5.1.5 release and that no new
>> bug fixes other than bugs that already affect rc1 (including bugs moved
>> to 5.1.6) cannot be committed without first discussing it on the dev
>> mailing list.
>>
>> Cheers,
>>
>> Wayne
>>
>> [1]: https://bugs.launchpad.net/kicad/+bug/1849289
>>
>> On 10/21/2019 3:11 PM, Ian McInerney wrote:
>>> There were two bugs still on the 5.1.5 milestone [1], [2] that related
>>> to the editing of H/V/45 constrained polygons. I have bumped those to
>>> 6.0 now. Should we reopen and move [3] and [4] to 6.0 so that we
>>> actually fix the issues there?
>>>
>>> -Ian
>>>
>>> [1] https://bugs.launchpad.net/kicad/+bug/1842055
>>> [2] https://bugs.launchpad.net/kicad/+bug/1842195
>>> [3] https://bugs.launchpad.net/kicad/+bug/1847722
>>> [4] https://bugs.launchpad.net/kicad/+bug/1846029
>>>
>>> On Mon, Oct 21, 2019 at 7:02 PM Seth Hillbrand >> > wrote:
>>>
>>> On 2019-10-21 10:52, Ian McInerney wrote:
>>>
>>> > Seth,
>>> >
>>> > Just to clarify, for 5.1.5 (and future 5.1 releases), the H/V/45 is
>>> > only available during initial zone creation and is not going to be
>>> > active for editing the lines after creation? If this is the case, I
>>> > will push the bugs for this into the 6.0 milestone, so they can be
>>> > addressed there.
>>> >
>>> > -Ian
>>>
>>> That is correct.  I've already reset that bug[1].  But if you see
>>> others
>>> that relate to it, feel free to mark the dupes.
>>>
>>> -Seth
>>>
>>> Seth Hillbrand
>>> KiCad Services Corporation
>>> https://www.kipro-pcb.com
>>> +1 530 302 5483 | +1 212 603 9372
>>>
>>> [1] https://bugs.launchpad.net/kicad/+bug/1833673
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

I see -DNDEBUG defined in windows release builds where CMake is
configured with -DCMAKE_BUILD_TYPE=Release.  Is this not the case with
Linux and/or macos?  Did we make the mistake of doing something like:

set( CMAKE_COMPILER_FLAGS "-foo" )

instead of:

set( CMAKE_COMPILER_FLAGS "${CMAKE_COMPILER_FLAGS} -foo" )

in one of the none windows build code paths?  Doing this will wipe out
any compiler flags set by CMake.

On 10/23/2019 11:16 AM, Ian McInerney wrote:
> It looks like the build flags for KiCad are not getting NDEBUG defined
> to remove the assertions. We should add -DNDEBUG to the flags passed
> into CMake alongside the Debian flags.
> 
> -Ian
> 
> On Wed, Oct 23, 2019 at 6:38 AM Carsten Schoenert
> mailto:c.schoen...@t-online.de>> wrote:
> 
> Hello Seth,
> 
> Am 22.10.19 um 18:10 schrieb Seth Hillbrand:
> > Why do you have "hardening=+all" enabled?
> 
> mostly because this is the default for building binary packages with
> enabled hardening.
> 
> https://wiki.debian.org/Hardening#Using_Hardening_Options
> 
> > This is likely where the assertions are happening.  We might consider
> >  "hardening=-all,+format,+fortify"
> I'm not that deep into the details here or at least would need to keep
> reading some stuff. But as far I've understand the hardening flags
> should have no effect on this.
> 
> Maybe Simon can give some enlightenment on this?
> 
> -- 
> Regards
> Carsten Schoenert
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Ian McInerney]

It looks like the build flags for KiCad are not getting NDEBUG defined to
remove the assertions. We should add -DNDEBUG to the flags passed into
CMake alongside the Debian flags.

-Ian

On Wed, Oct 23, 2019 at 6:38 AM Carsten Schoenert 
wrote:

> Hello Seth,
>
> Am 22.10.19 um 18:10 schrieb Seth Hillbrand:
> > Why do you have "hardening=+all" enabled?
>
> mostly because this is the default for building binary packages with
> enabled hardening.
>
> https://wiki.debian.org/Hardening#Using_Hardening_Options
>
> > This is likely where the assertions are happening.  We might consider
> >  "hardening=-all,+format,+fortify"
> I'm not that deep into the details here or at least would need to keep
> reading some stuff. But as far I've understand the hardening flags
> should have no effect on this.
>
> Maybe Simon can give some enlightenment on this?
>
> --
> Regards
> Carsten Schoenert
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Adam Wolf]

It may take me another few days to get the wx-built-without-debug on
releases setup in kicad-macos-builder, but that won't be source
changes.  I can get it ready and then use the rc code for it, and get
folks to test.

Adam

On Wed, Oct 23, 2019 at 8:50 AM Wayne Stambaugh  wrote:
>
> Now that JP fixed lp:1849289[1], is there anything else that needs to be
> fixed before I tag rc1?  If not, I will tag it Friday.  That means that
> we will be in a string freeze until the 5.1.5 release and that no new
> bug fixes other than bugs that already affect rc1 (including bugs moved
> to 5.1.6) cannot be committed without first discussing it on the dev
> mailing list.
>
> Cheers,
>
> Wayne
>
> [1]: https://bugs.launchpad.net/kicad/+bug/1849289
>
> On 10/21/2019 3:11 PM, Ian McInerney wrote:
> > There were two bugs still on the 5.1.5 milestone [1], [2] that related
> > to the editing of H/V/45 constrained polygons. I have bumped those to
> > 6.0 now. Should we reopen and move [3] and [4] to 6.0 so that we
> > actually fix the issues there?
> >
> > -Ian
> >
> > [1] https://bugs.launchpad.net/kicad/+bug/1842055
> > [2] https://bugs.launchpad.net/kicad/+bug/1842195
> > [3] https://bugs.launchpad.net/kicad/+bug/1847722
> > [4] https://bugs.launchpad.net/kicad/+bug/1846029
> >
> > On Mon, Oct 21, 2019 at 7:02 PM Seth Hillbrand  > > wrote:
> >
> > On 2019-10-21 10:52, Ian McInerney wrote:
> >
> > > Seth,
> > >
> > > Just to clarify, for 5.1.5 (and future 5.1 releases), the H/V/45 is
> > > only available during initial zone creation and is not going to be
> > > active for editing the lines after creation? If this is the case, I
> > > will push the bugs for this into the 6.0 milestone, so they can be
> > > addressed there.
> > >
> > > -Ian
> >
> > That is correct.  I've already reset that bug[1].  But if you see
> > others
> > that relate to it, feel free to mark the dupes.
> >
> > -Seth
> >
> > Seth Hillbrand
> > KiCad Services Corporation
> > https://www.kipro-pcb.com
> > +1 530 302 5483 | +1 212 603 9372
> >
> > [1] https://bugs.launchpad.net/kicad/+bug/1833673
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Ian McInerney]

Can we slip [1] into 5.1.5, or would you rather hold it until we open for
5.1.6 work?

-Ian

[1] https://bugs.launchpad.net/kicad/+bug/1847580

On Wed, Oct 23, 2019 at 2:50 PM Wayne Stambaugh 
wrote:

> Now that JP fixed lp:1849289[1], is there anything else that needs to be
> fixed before I tag rc1?  If not, I will tag it Friday.  That means that
> we will be in a string freeze until the 5.1.5 release and that no new
> bug fixes other than bugs that already affect rc1 (including bugs moved
> to 5.1.6) cannot be committed without first discussing it on the dev
> mailing list.
>
> Cheers,
>
> Wayne
>
> [1]: https://bugs.launchpad.net/kicad/+bug/1849289
>
> On 10/21/2019 3:11 PM, Ian McInerney wrote:
> > There were two bugs still on the 5.1.5 milestone [1], [2] that related
> > to the editing of H/V/45 constrained polygons. I have bumped those to
> > 6.0 now. Should we reopen and move [3] and [4] to 6.0 so that we
> > actually fix the issues there?
> >
> > -Ian
> >
> > [1] https://bugs.launchpad.net/kicad/+bug/1842055
> > [2] https://bugs.launchpad.net/kicad/+bug/1842195
> > [3] https://bugs.launchpad.net/kicad/+bug/1847722
> > [4] https://bugs.launchpad.net/kicad/+bug/1846029
> >
> > On Mon, Oct 21, 2019 at 7:02 PM Seth Hillbrand  > > wrote:
> >
> > On 2019-10-21 10:52, Ian McInerney wrote:
> >
> > > Seth,
> > >
> > > Just to clarify, for 5.1.5 (and future 5.1 releases), the H/V/45 is
> > > only available during initial zone creation and is not going to be
> > > active for editing the lines after creation? If this is the case, I
> > > will push the bugs for this into the 6.0 milestone, so they can be
> > > addressed there.
> > >
> > > -Ian
> >
> > That is correct.  I've already reset that bug[1].  But if you see
> > others
> > that relate to it, feel free to mark the dupes.
> >
> > -Seth
> >
> > Seth Hillbrand
> > KiCad Services Corporation
> > https://www.kipro-pcb.com
> > +1 530 302 5483 | +1 212 603 9372
> >
> > [1] https://bugs.launchpad.net/kicad/+bug/1833673
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

Now that JP fixed lp:1849289[1], is there anything else that needs to be
fixed before I tag rc1?  If not, I will tag it Friday.  That means that
we will be in a string freeze until the 5.1.5 release and that no new
bug fixes other than bugs that already affect rc1 (including bugs moved
to 5.1.6) cannot be committed without first discussing it on the dev
mailing list.

Cheers,

Wayne

[1]: https://bugs.launchpad.net/kicad/+bug/1849289

On 10/21/2019 3:11 PM, Ian McInerney wrote:
> There were two bugs still on the 5.1.5 milestone [1], [2] that related
> to the editing of H/V/45 constrained polygons. I have bumped those to
> 6.0 now. Should we reopen and move [3] and [4] to 6.0 so that we
> actually fix the issues there?
> 
> -Ian
> 
> [1] https://bugs.launchpad.net/kicad/+bug/1842055
> [2] https://bugs.launchpad.net/kicad/+bug/1842195
> [3] https://bugs.launchpad.net/kicad/+bug/1847722
> [4] https://bugs.launchpad.net/kicad/+bug/1846029
> 
> On Mon, Oct 21, 2019 at 7:02 PM Seth Hillbrand  > wrote:
> 
> On 2019-10-21 10:52, Ian McInerney wrote:
> 
> > Seth,
> >
> > Just to clarify, for 5.1.5 (and future 5.1 releases), the H/V/45 is
> > only available during initial zone creation and is not going to be
> > active for editing the lines after creation? If this is the case, I
> > will push the bugs for this into the 6.0 milestone, so they can be
> > addressed there.
> >
> > -Ian
> 
> That is correct.  I've already reset that bug[1].  But if you see
> others
> that relate to it, feel free to mark the dupes.
> 
> -Seth
> 
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372
> 
> [1] https://bugs.launchpad.net/kicad/+bug/1833673
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Carsten Schoenert]

Hello Seth,

Am 22.10.19 um 18:10 schrieb Seth Hillbrand:
> Why do you have "hardening=+all" enabled?

mostly because this is the default for building binary packages with
enabled hardening.

https://wiki.debian.org/Hardening#Using_Hardening_Options

> This is likely where the assertions are happening.  We might consider
>  "hardening=-all,+format,+fortify"
I'm not that deep into the details here or at least would need to keep
reading some stuff. But as far I've understand the hardening flags
should have no effect on this.

Maybe Simon can give some enlightenment on this?

-- 
Regards
Carsten Schoenert

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Seth Hillbrand]

On 2019-10-21 22:08, Carsten Schoenert wrote:

Hi,

Am 21.10.19 um 23:16 schrieb Ian McInerney:
We also seem to have assertions enabled in the Debian build (there 
have

been two reports from users [1], [2]). Is this something we control as
well, or is the the distribution packaging forcing them on?


the Debian build configuration is visible in the GitLab repo for KiCad
on Salsa.

https://salsa.debian.org/electronics-team/KiCad/kicad
https://salsa.debian.org/electronics-team/KiCad/kicad/blob/debian/sid/debian/rules

I'm happily taken any patches if provided.


Hi Carsten-

Why do you have "hardening=+all" enabled?  This is likely where the 
assertions are happening.  We might consider 
"hardening=-all,+format,+fortify"


Note, this is different from the mac builds where the debug asserts are 
happening in the wx code.


-Seth

Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

I would prefer that stable release builds have assertions disabled in
KiCad and all of it's library dependencies.  If we want to provide debug
builds for users who want to help with debugging, I'm fine with that.

Wayne

On 10/22/19 7:43 AM, Adam Wolf wrote:
> I can look into doing this for release builds on macOS  If I do this, I
> will need to make a pre-release build for folks to test since by
> definition this wouldn't be tested on nightlies, right?
> 
> Are there other dependencies that we want to build differently for
> release vs nightly?
> 
> Adam
> 
> On Tue, Oct 22, 2019, 12:08 AM Carsten Schoenert
> mailto:c.schoen...@t-online.de>> wrote:
> 
> Hi,
> 
> Am 21.10.19 um 23:16 schrieb Ian McInerney:
> > We also seem to have assertions enabled in the Debian build (there
> have
> > been two reports from users [1], [2]). Is this something we control as
> > well, or is the the distribution packaging forcing them on?
> 
> the Debian build configuration is visible in the GitLab repo for KiCad
> on Salsa.
> 
> https://salsa.debian.org/electronics-team/KiCad/kicad
> 
> https://salsa.debian.org/electronics-team/KiCad/kicad/blob/debian/sid/debian/rules
> 
> I'm happily taken any patches if provided.
> 
> I personally haven't seen these asserts.
> 
> -- 
> Regards
> Carsten Schoenert
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

On 10/22/19 1:08 AM, Carsten Schoenert wrote:
> Hi,
> 
> Am 21.10.19 um 23:16 schrieb Ian McInerney:
>> We also seem to have assertions enabled in the Debian build (there have
>> been two reports from users [1], [2]). Is this something we control as
>> well, or is the the distribution packaging forcing them on?
> 
> the Debian build configuration is visible in the GitLab repo for KiCad
> on Salsa.
> 
> https://salsa.debian.org/electronics-team/KiCad/kicad
> https://salsa.debian.org/electronics-team/KiCad/kicad/blob/debian/sid/debian/rules
> 
> I'm happily taken any patches if provided.
> 
> I personally haven't seen these asserts.
> 

I don't think we can control this from the KiCad package build
configuration.  It needs to be done when configuring the wxWidgets
package builds.  This is probably why we don't see them in Linux unless
you are using the debug package of wxWidgets.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Adam Wolf]

I can look into doing this for release builds on macOS  If I do this, I
will need to make a pre-release build for folks to test since by definition
this wouldn't be tested on nightlies, right?

Are there other dependencies that we want to build differently for release
vs nightly?

Adam

On Tue, Oct 22, 2019, 12:08 AM Carsten Schoenert 
wrote:

> Hi,
>
> Am 21.10.19 um 23:16 schrieb Ian McInerney:
> > We also seem to have assertions enabled in the Debian build (there have
> > been two reports from users [1], [2]). Is this something we control as
> > well, or is the the distribution packaging forcing them on?
>
> the Debian build configuration is visible in the GitLab repo for KiCad
> on Salsa.
>
> https://salsa.debian.org/electronics-team/KiCad/kicad
>
> https://salsa.debian.org/electronics-team/KiCad/kicad/blob/debian/sid/debian/rules
>
> I'm happily taken any patches if provided.
>
> I personally haven't seen these asserts.
>
> --
> Regards
> Carsten Schoenert
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Carsten Schoenert]

Hi,

Am 21.10.19 um 23:16 schrieb Ian McInerney:
> We also seem to have assertions enabled in the Debian build (there have
> been two reports from users [1], [2]). Is this something we control as
> well, or is the the distribution packaging forcing them on?

the Debian build configuration is visible in the GitLab repo for KiCad
on Salsa.

https://salsa.debian.org/electronics-team/KiCad/kicad
https://salsa.debian.org/electronics-team/KiCad/kicad/blob/debian/sid/debian/rules

I'm happily taken any patches if provided.

I personally haven't seen these asserts.

-- 
Regards
Carsten Schoenert

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Ian McInerney]

We also seem to have assertions enabled in the Debian build (there have
been two reports from users [1], [2]). Is this something we control as
well, or is the the distribution packaging forcing them on?

-Ian

[1] https://bugs.launchpad.net/kicad/+bug/1847554
[2] https://bugs.launchpad.net/kicad/+bug/1848107

On Mon, Oct 21, 2019 at 6:51 PM Wayne Stambaugh 
wrote:

> I thought this might be the case.  If you click cancel, the assertion
> dialog will not be displayed again until you restart KiCad.
>
> Would one of our macos devs please take a look at the config settings
> use to build wxWidgets and see if we can turn the assertions off on
> release builds?  This might require some compiler flag settings to
> completely disable.
>
> On 10/21/19 1:39 PM, Kymatica wrote:
> > Ok. It’s not crashing after I tap No, but it’s ”a bit” annoying,
> especially when there’s a chain of 5 or so assertion pop-ups, as seems to
> happen sometimes when rerunning simulation while some error in the
> schematics make the sim fail and not finding the plotted nets.
> >
> > /Jonatan
> >
> >> 21 okt. 2019 kl. 19:44 skrev Wayne Stambaugh :
> >>
> >> Hi Jonaton,
> >>
> >> This is an assertion in wxWidgets being raised.  This really shouldn't
> >> happen on release builds.  While assertions like this are annoying they
> >> are not show stoppers unless clicking either the "No" or "Cancel"
> >> buttons cause KiCad to crash.  I'm guessing this is not the case but one
> >> of our macos devs can confirm this.  It looks like our macos wxWidgets
> >> library builds need to have the assertions disabled.
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >>> On 10/20/19 10:37 AM, Kymatica wrote:
> >>> I still see this a lot on macOS, not only when editing symbol fields
> but
> >>> here and there:
> >>>
> >>> https://bugs.launchpad.net/bugs/1844545
> >>>
> >>> I don’t think 5.1.5 is ”production ready” until this is fixed.
> >>>
> >>> /Jonatan
> >>>
> > 20 okt. 2019 kl. 17:13 skrev Seth Hillbrand :
> 
>  On 2019-10-20 06:41, Wayne Stambaugh wrote:
> > Where are we on the 5.1.5 release?  I took a look at the bug tacker
> and
> > the only serious bug I saw was the glib assertion bug[1].  How close
> are
> > we to getting this fixed?  There is still some unexpected behavior
> with
> > the constrained zone drawing and editing changes that should be fixed
> > before we release.  I would like to tag -rc1 and start the string
> freeze
> > by the end of October.
> 
>  Odd, I didn't see that one come through.  I'll fix that this weekend.
> 
>  -S
> 
>  Seth Hillbrand
>  KiCad Services Corporation
>  https://www.kipro-pcb.com
>  +1 530 302 5483 | +1 212 603 9372
> 
>  ___
>  Mailing list: https://launchpad.net/~kicad-developers
>  Post to : kicad-developers@lists.launchpad.net
>  Unsubscribe : https://launchpad.net/~kicad-developers
>  More help   : https://help.launchpad.net/ListHelp
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Ian McInerney]

There were two bugs still on the 5.1.5 milestone [1], [2] that related to
the editing of H/V/45 constrained polygons. I have bumped those to 6.0 now.
Should we reopen and move [3] and [4] to 6.0 so that we actually fix the
issues there?

-Ian

[1] https://bugs.launchpad.net/kicad/+bug/1842055
[2] https://bugs.launchpad.net/kicad/+bug/1842195
[3] https://bugs.launchpad.net/kicad/+bug/1847722
[4] https://bugs.launchpad.net/kicad/+bug/1846029

On Mon, Oct 21, 2019 at 7:02 PM Seth Hillbrand  wrote:

> On 2019-10-21 10:52, Ian McInerney wrote:
>
> > Seth,
> >
> > Just to clarify, for 5.1.5 (and future 5.1 releases), the H/V/45 is
> > only available during initial zone creation and is not going to be
> > active for editing the lines after creation? If this is the case, I
> > will push the bugs for this into the 6.0 milestone, so they can be
> > addressed there.
> >
> > -Ian
>
> That is correct.  I've already reset that bug[1].  But if you see others
> that relate to it, feel free to mark the dupes.
>
> -Seth
>
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372
>
> [1] https://bugs.launchpad.net/kicad/+bug/1833673
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Seth Hillbrand]

On 2019-10-21 10:52, Ian McInerney wrote:


Seth,

Just to clarify, for 5.1.5 (and future 5.1 releases), the H/V/45 is 
only available during initial zone creation and is not going to be 
active for editing the lines after creation? If this is the case, I 
will push the bugs for this into the 6.0 milestone, so they can be 
addressed there.


-Ian


That is correct.  I've already reset that bug[1].  But if you see others 
that relate to it, feel free to mark the dupes.


-Seth

Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372

[1] https://bugs.launchpad.net/kicad/+bug/1833673

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

I thought this might be the case.  If you click cancel, the assertion
dialog will not be displayed again until you restart KiCad.

Would one of our macos devs please take a look at the config settings
use to build wxWidgets and see if we can turn the assertions off on
release builds?  This might require some compiler flag settings to
completely disable.

On 10/21/19 1:39 PM, Kymatica wrote:
> Ok. It’s not crashing after I tap No, but it’s ”a bit” annoying, especially 
> when there’s a chain of 5 or so assertion pop-ups, as seems to happen 
> sometimes when rerunning simulation while some error in the schematics make 
> the sim fail and not finding the plotted nets.
> 
> /Jonatan 
> 
>> 21 okt. 2019 kl. 19:44 skrev Wayne Stambaugh :
>>
>> Hi Jonaton,
>>
>> This is an assertion in wxWidgets being raised.  This really shouldn't
>> happen on release builds.  While assertions like this are annoying they
>> are not show stoppers unless clicking either the "No" or "Cancel"
>> buttons cause KiCad to crash.  I'm guessing this is not the case but one
>> of our macos devs can confirm this.  It looks like our macos wxWidgets
>> library builds need to have the assertions disabled.
>>
>> Cheers,
>>
>> Wayne
>>
>>> On 10/20/19 10:37 AM, Kymatica wrote:
>>> I still see this a lot on macOS, not only when editing symbol fields but
>>> here and there: 
>>>
>>> https://bugs.launchpad.net/bugs/1844545
>>>
>>> I don’t think 5.1.5 is ”production ready” until this is fixed.
>>>
>>> /Jonatan 
>>>
> 20 okt. 2019 kl. 17:13 skrev Seth Hillbrand :

 On 2019-10-20 06:41, Wayne Stambaugh wrote:
> Where are we on the 5.1.5 release?  I took a look at the bug tacker and
> the only serious bug I saw was the glib assertion bug[1].  How close are
> we to getting this fixed?  There is still some unexpected behavior with
> the constrained zone drawing and editing changes that should be fixed
> before we release.  I would like to tag -rc1 and start the string freeze
> by the end of October.

 Odd, I didn't see that one come through.  I'll fix that this weekend.

 -S

 Seth Hillbrand
 KiCad Services Corporation
 https://www.kipro-pcb.com
 +1 530 302 5483 | +1 212 603 9372

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Ian McInerney]

Seth,

Just to clarify, for 5.1.5 (and future 5.1 releases), the H/V/45 is only
available during initial zone creation and is not going to be active for
editing the lines after creation? If this is the case, I will push the bugs
for this into the 6.0 milestone, so they can be addressed there.

-Ian

On Sun, Oct 20, 2019 at 5:02 PM Seth Hillbrand  wrote:

> On 2019-10-20 08:40, Ian McInerney wrote:
>
> > There is also this H/V/45 issue [1]. It is more of a gray area though,
> > since it will probably involve touching the file format due to what is
> > happening (the H/V/45 is being saved as a global board setting rather
> > than a per-zone setting as the GUI would seem to make it).
> >
> > -Ian
> >
> > [1] https://bugs.launchpad.net/kicad/+bug/1847722
>
> Ugh.  You are right Ian.  We definitely need to fix that one.  Since I'm
> in the area, I'll deal with it.  I'm going to disable the H/V/45 during
> edits.  The setting will then only affect the newly created zone.  Since
> we don't have a place to store the information, keeping it with the zone
> info doesn't make sense because it will change based on opening/closing
> the file.
>
> For v6, I think we add the parameter to the zone unless people object.
>
> -Seth
>
>
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Adam Wolf]

It may be a false alarm--I am reviewing everything and it looks like
it is working for everyone so far.  There may be some documentation we
have to add to the macOS specific things about allowing permissions
when a popup pops up on first run, but if I am understanding correctly
none of the issues seem like blockers.

I have asked on the bug to see if anyone is having this problem still.

On Mon, Oct 21, 2019 at 9:54 AM Wayne Stambaugh  wrote:
>
> Do we know if this is a KiCad source bug issue or a macos packaging
> issue?  I was getting the distinct impression that it was the latter.  I
> agree that we do not want to release 5.1.5 without a functioning macos
> package.  I'm willing to hold off on the rc1 tag until we resolve this
> issue.  It may give us an opportunity to fix some additional bug for 5.1.5.
>
> On 10/20/19 9:02 PM, Adam Wolf wrote:
> > Hi folks.
> >
> > I was under the impression that although the macOS 10.15 betas had
> > weird issues with KiCad, that the release Catalina was fine.  This may
> > not be the case.  I am mobile today and only using my phone, so it's
> > difficult for me to dig into it right now. If folks are still
> > reporting that they create new projects, I would request that we
> > postpone a release until this is resolved.
> >
> > (I had posted a small and unhelpful error message, and was going to
> > get a debugger on a 10.15 machine to get a real stack trace, but
> > postponed going to 10.15 on that machine based on reports that it was
> > working--but I may have to get that set up this week, unless someone
> > else can.)
> >
> > Adam
> >
> > On Sun, Oct 20, 2019 at 6:50 PM Seth Hillbrand  wrote:
> >>
> >> Hi Wayne-
> >>
> >> These should be fixed.  I've pushed the reload issue off to v6 as the
> >> setting isn't available in the current file format as Ian mentioned, so
> >> I've reset the associated bug with a new milestone.
> >>
> >> We should be clear for these reports now.  It's safe to tag 5.1.5RC1
> >> from my perspective and we'll get some testing of the fixes.  It might
> >> be good to get a 5.1.6 milestone in launchpad at the same time and I
> >> will move all unaddressed items to that milestone so that we are only
> >> fixing issues with 5.1.5 commits during the RC phase.
> >>
> >> Thoughts?
> >>
> >> -Seth
> >>
> >> On 2019-10-20 07:38, Wayne Stambaugh wrote:
> >>> Thanks Seth,
> >>>
> >>> There is also this[1] bug and this[2] bug and this[3] bug related to
> >>> the
> >>> zone constraint changes.  I probably wont hold up the 5.1.5 release for
> >>> them but they are behavioral changes which users will not expect.  The
> >>> most annoying one is lp:1846028.
> >>>
> >>> Cheers,
> >>>
> >>> Wayne
> >>>
> >>> [1]: https://bugs.launchpad.net/kicad/+bug/1842195
> >>> [2]: https://bugs.launchpad.net/kicad/+bug/1846028
> >>> [3]: https://bugs.launchpad.net/kicad/+bug/1846029
> >>>
> >>> On 10/20/19 10:13 AM, Seth Hillbrand wrote:
>  On 2019-10-20 06:41, Wayne Stambaugh wrote:
> > Where are we on the 5.1.5 release?  I took a look at the bug tacker
> > and
> > the only serious bug I saw was the glib assertion bug[1].  How close
> > are
> > we to getting this fixed?  There is still some unexpected behavior
> > with
> > the constrained zone drawing and editing changes that should be fixed
> > before we release.  I would like to tag -rc1 and start the string
> > freeze
> > by the end of October.
> 
>  Odd, I didn't see that one come through.  I'll fix that this weekend.
> 
>  -S
> 
>  Seth Hillbrand
>  KiCad Services Corporation
>  https://www.kipro-pcb.com
>  +1 530 302 5483 | +1 212 603 9372
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>
> >> Seth Hillbrand
> >> KiCad Services Corporation
> >> https://www.kipro-pcb.com
> >> +1 530 302 5483 | +1 212 603 9372
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

Hi Jonaton,

This is an assertion in wxWidgets being raised.  This really shouldn't
happen on release builds.  While assertions like this are annoying they
are not show stoppers unless clicking either the "No" or "Cancel"
buttons cause KiCad to crash.  I'm guessing this is not the case but one
of our macos devs can confirm this.  It looks like our macos wxWidgets
library builds need to have the assertions disabled.

Cheers,

Wayne

On 10/20/19 10:37 AM, Kymatica wrote:
> I still see this a lot on macOS, not only when editing symbol fields but
> here and there: 
> 
> https://bugs.launchpad.net/bugs/1844545
> 
> I don’t think 5.1.5 is ”production ready” until this is fixed.
> 
> /Jonatan 
> 
>> 20 okt. 2019 kl. 17:13 skrev Seth Hillbrand :
>>
>> On 2019-10-20 06:41, Wayne Stambaugh wrote:
>>> Where are we on the 5.1.5 release?  I took a look at the bug tacker and
>>> the only serious bug I saw was the glib assertion bug[1].  How close are
>>> we to getting this fixed?  There is still some unexpected behavior with
>>> the constrained zone drawing and editing changes that should be fixed
>>> before we release.  I would like to tag -rc1 and start the string freeze
>>> by the end of October.
>>
>> Odd, I didn't see that one come through.  I'll fix that this weekend.
>>
>> -S
>>
>> Seth Hillbrand
>> KiCad Services Corporation
>> https://www.kipro-pcb.com
>> +1 530 302 5483 | +1 212 603 9372
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

On 10/20/19 12:02 PM, Seth Hillbrand wrote:
> On 2019-10-20 08:40, Ian McInerney wrote:
> 
>> There is also this H/V/45 issue [1]. It is more of a gray area though,
>> since it will probably involve touching the file format due to what is
>> happening (the H/V/45 is being saved as a global board setting rather
>> than a per-zone setting as the GUI would seem to make it).
>>
>> -Ian
>>
>> [1] https://bugs.launchpad.net/kicad/+bug/1847722
> 
> Ugh.  You are right Ian.  We definitely need to fix that one.  Since I'm
> in the area, I'll deal with it.  I'm going to disable the H/V/45 during
> edits.  The setting will then only affect the newly created zone.  Since
> we don't have a place to store the information, keeping it with the zone
> info doesn't make sense because it will change based on opening/closing
> the file.
> 
> For v6, I think we add the parameter to the zone unless people object.

This is definitely a v6 bug fix.  We have a strict stable release file
format change policy.  I don't think this bug is severe enough to break
with that policy.

Wayne

> 
> -Seth
> 
> 
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

Do we know if this is a KiCad source bug issue or a macos packaging
issue?  I was getting the distinct impression that it was the latter.  I
agree that we do not want to release 5.1.5 without a functioning macos
package.  I'm willing to hold off on the rc1 tag until we resolve this
issue.  It may give us an opportunity to fix some additional bug for 5.1.5.

On 10/20/19 9:02 PM, Adam Wolf wrote:
> Hi folks.
> 
> I was under the impression that although the macOS 10.15 betas had
> weird issues with KiCad, that the release Catalina was fine.  This may
> not be the case.  I am mobile today and only using my phone, so it's
> difficult for me to dig into it right now. If folks are still
> reporting that they create new projects, I would request that we
> postpone a release until this is resolved.
> 
> (I had posted a small and unhelpful error message, and was going to
> get a debugger on a 10.15 machine to get a real stack trace, but
> postponed going to 10.15 on that machine based on reports that it was
> working--but I may have to get that set up this week, unless someone
> else can.)
> 
> Adam
> 
> On Sun, Oct 20, 2019 at 6:50 PM Seth Hillbrand  wrote:
>>
>> Hi Wayne-
>>
>> These should be fixed.  I've pushed the reload issue off to v6 as the
>> setting isn't available in the current file format as Ian mentioned, so
>> I've reset the associated bug with a new milestone.
>>
>> We should be clear for these reports now.  It's safe to tag 5.1.5RC1
>> from my perspective and we'll get some testing of the fixes.  It might
>> be good to get a 5.1.6 milestone in launchpad at the same time and I
>> will move all unaddressed items to that milestone so that we are only
>> fixing issues with 5.1.5 commits during the RC phase.
>>
>> Thoughts?
>>
>> -Seth
>>
>> On 2019-10-20 07:38, Wayne Stambaugh wrote:
>>> Thanks Seth,
>>>
>>> There is also this[1] bug and this[2] bug and this[3] bug related to
>>> the
>>> zone constraint changes.  I probably wont hold up the 5.1.5 release for
>>> them but they are behavioral changes which users will not expect.  The
>>> most annoying one is lp:1846028.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>> [1]: https://bugs.launchpad.net/kicad/+bug/1842195
>>> [2]: https://bugs.launchpad.net/kicad/+bug/1846028
>>> [3]: https://bugs.launchpad.net/kicad/+bug/1846029
>>>
>>> On 10/20/19 10:13 AM, Seth Hillbrand wrote:
 On 2019-10-20 06:41, Wayne Stambaugh wrote:
> Where are we on the 5.1.5 release?  I took a look at the bug tacker
> and
> the only serious bug I saw was the glib assertion bug[1].  How close
> are
> we to getting this fixed?  There is still some unexpected behavior
> with
> the constrained zone drawing and editing changes that should be fixed
> before we release.  I would like to tag -rc1 and start the string
> freeze
> by the end of October.

 Odd, I didn't see that one come through.  I'll fix that this weekend.

 -S

 Seth Hillbrand
 KiCad Services Corporation
 https://www.kipro-pcb.com
 +1 530 302 5483 | +1 212 603 9372
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> Seth Hillbrand
>> KiCad Services Corporation
>> https://www.kipro-pcb.com
>> +1 530 302 5483 | +1 212 603 9372
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

Hi Seth,

On 10/20/19 1:48 PM, Seth Hillbrand wrote:
> Hi Wayne-
> 
> These should be fixed.  I've pushed the reload issue off to v6 as the
> setting isn't available in the current file format as Ian mentioned, so
> I've reset the associated bug with a new milestone.

Thanks.  I appreciate the speedy fixes.

> 
> We should be clear for these reports now.  It's safe to tag 5.1.5RC1
> from my perspective and we'll get some testing of the fixes.  It might
> be good to get a 5.1.6 milestone in launchpad at the same time and I
> will move all unaddressed items to that milestone so that we are only
> fixing issues with 5.1.5 commits during the RC phase.

I just created the 5.1.6 milestone.  I will move the unaddressed 5.1.5
items today.  I only want the issues fixed with the 5.1.5 commits during
the RC phase so please no other bug fix commits without at least
discussing them on the mailing list first.  I want to avoid some of the
issues we've had during the a couple of the 5.1 releases.  If the fix is
trivial and unlikely to cause any other issues, than we can decide to
commit them as part of the 5.1.5 release.  However, if there is a
possibility that the fix could create additional bugs, they will have to
be pushed back to 5.1.6.

Cheers,

Wayne

> 
> Thoughts?
> 
> -Seth
> 
> On 2019-10-20 07:38, Wayne Stambaugh wrote:
>> Thanks Seth,
>>
>> There is also this[1] bug and this[2] bug and this[3] bug related to the
>> zone constraint changes.  I probably wont hold up the 5.1.5 release for
>> them but they are behavioral changes which users will not expect.  The
>> most annoying one is lp:1846028.
>>
>> Cheers,
>>
>> Wayne
>>
>> [1]: https://bugs.launchpad.net/kicad/+bug/1842195
>> [2]: https://bugs.launchpad.net/kicad/+bug/1846028
>> [3]: https://bugs.launchpad.net/kicad/+bug/1846029
>>
>> On 10/20/19 10:13 AM, Seth Hillbrand wrote:
>>> On 2019-10-20 06:41, Wayne Stambaugh wrote:
 Where are we on the 5.1.5 release?  I took a look at the bug tacker and
 the only serious bug I saw was the glib assertion bug[1].  How close
 are
 we to getting this fixed?  There is still some unexpected behavior with
 the constrained zone drawing and editing changes that should be fixed
 before we release.  I would like to tag -rc1 and start the string
 freeze
 by the end of October.
>>>
>>> Odd, I didn't see that one come through.  I'll fix that this weekend.
>>>
>>> -S
>>>
>>> Seth Hillbrand
>>> KiCad Services Corporation
>>> https://www.kipro-pcb.com
>>> +1 530 302 5483 | +1 212 603 9372
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Adam Wolf]

Hi folks.

I was under the impression that although the macOS 10.15 betas had
weird issues with KiCad, that the release Catalina was fine.  This may
not be the case.  I am mobile today and only using my phone, so it's
difficult for me to dig into it right now. If folks are still
reporting that they create new projects, I would request that we
postpone a release until this is resolved.

(I had posted a small and unhelpful error message, and was going to
get a debugger on a 10.15 machine to get a real stack trace, but
postponed going to 10.15 on that machine based on reports that it was
working--but I may have to get that set up this week, unless someone
else can.)

Adam

On Sun, Oct 20, 2019 at 6:50 PM Seth Hillbrand  wrote:
>
> Hi Wayne-
>
> These should be fixed.  I've pushed the reload issue off to v6 as the
> setting isn't available in the current file format as Ian mentioned, so
> I've reset the associated bug with a new milestone.
>
> We should be clear for these reports now.  It's safe to tag 5.1.5RC1
> from my perspective and we'll get some testing of the fixes.  It might
> be good to get a 5.1.6 milestone in launchpad at the same time and I
> will move all unaddressed items to that milestone so that we are only
> fixing issues with 5.1.5 commits during the RC phase.
>
> Thoughts?
>
> -Seth
>
> On 2019-10-20 07:38, Wayne Stambaugh wrote:
> > Thanks Seth,
> >
> > There is also this[1] bug and this[2] bug and this[3] bug related to
> > the
> > zone constraint changes.  I probably wont hold up the 5.1.5 release for
> > them but they are behavioral changes which users will not expect.  The
> > most annoying one is lp:1846028.
> >
> > Cheers,
> >
> > Wayne
> >
> > [1]: https://bugs.launchpad.net/kicad/+bug/1842195
> > [2]: https://bugs.launchpad.net/kicad/+bug/1846028
> > [3]: https://bugs.launchpad.net/kicad/+bug/1846029
> >
> > On 10/20/19 10:13 AM, Seth Hillbrand wrote:
> >> On 2019-10-20 06:41, Wayne Stambaugh wrote:
> >>> Where are we on the 5.1.5 release?  I took a look at the bug tacker
> >>> and
> >>> the only serious bug I saw was the glib assertion bug[1].  How close
> >>> are
> >>> we to getting this fixed?  There is still some unexpected behavior
> >>> with
> >>> the constrained zone drawing and editing changes that should be fixed
> >>> before we release.  I would like to tag -rc1 and start the string
> >>> freeze
> >>> by the end of October.
> >>
> >> Odd, I didn't see that one come through.  I'll fix that this weekend.
> >>
> >> -S
> >>
> >> Seth Hillbrand
> >> KiCad Services Corporation
> >> https://www.kipro-pcb.com
> >> +1 530 302 5483 | +1 212 603 9372
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Seth Hillbrand]

Hi Wayne-

These should be fixed.  I've pushed the reload issue off to v6 as the 
setting isn't available in the current file format as Ian mentioned, so 
I've reset the associated bug with a new milestone.


We should be clear for these reports now.  It's safe to tag 5.1.5RC1 
from my perspective and we'll get some testing of the fixes.  It might 
be good to get a 5.1.6 milestone in launchpad at the same time and I 
will move all unaddressed items to that milestone so that we are only 
fixing issues with 5.1.5 commits during the RC phase.


Thoughts?

-Seth

On 2019-10-20 07:38, Wayne Stambaugh wrote:

Thanks Seth,

There is also this[1] bug and this[2] bug and this[3] bug related to 
the

zone constraint changes.  I probably wont hold up the 5.1.5 release for
them but they are behavioral changes which users will not expect.  The
most annoying one is lp:1846028.

Cheers,

Wayne

[1]: https://bugs.launchpad.net/kicad/+bug/1842195
[2]: https://bugs.launchpad.net/kicad/+bug/1846028
[3]: https://bugs.launchpad.net/kicad/+bug/1846029

On 10/20/19 10:13 AM, Seth Hillbrand wrote:

On 2019-10-20 06:41, Wayne Stambaugh wrote:
Where are we on the 5.1.5 release?  I took a look at the bug tacker 
and
the only serious bug I saw was the glib assertion bug[1].  How close 
are
we to getting this fixed?  There is still some unexpected behavior 
with

the constrained zone drawing and editing changes that should be fixed
before we release.  I would like to tag -rc1 and start the string 
freeze

by the end of October.


Odd, I didn't see that one come through.  I'll fix that this weekend.

-S

Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Seth Hillbrand]

On 2019-10-20 08:40, Ian McInerney wrote:

There is also this H/V/45 issue [1]. It is more of a gray area though, 
since it will probably involve touching the file format due to what is 
happening (the H/V/45 is being saved as a global board setting rather 
than a per-zone setting as the GUI would seem to make it).


-Ian

[1] https://bugs.launchpad.net/kicad/+bug/1847722


Ugh.  You are right Ian.  We definitely need to fix that one.  Since I'm 
in the area, I'll deal with it.  I'm going to disable the H/V/45 during 
edits.  The setting will then only affect the newly created zone.  Since 
we don't have a place to store the information, keeping it with the zone 
info doesn't make sense because it will change based on opening/closing 
the file.


For v6, I think we add the parameter to the zone unless people object.

-Seth


Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Ian McInerney]

There is also this H/V/45 issue [1]. It is more of a gray area though,
since it will probably involve touching the file format due to what is
happening (the H/V/45 is being saved as a global board setting rather than
a per-zone setting as the GUI would seem to make it).

-Ian

[1] https://bugs.launchpad.net/kicad/+bug/1847722

On Sun, Oct 20, 2019 at 4:28 PM Wayne Stambaugh 
wrote:

> Thanks Seth,
>
> There is also this[1] bug and this[2] bug and this[3] bug related to the
> zone constraint changes.  I probably wont hold up the 5.1.5 release for
> them but they are behavioral changes which users will not expect.  The
> most annoying one is lp:1846028.
>
> Cheers,
>
> Wayne
>
> [1]: https://bugs.launchpad.net/kicad/+bug/1842195
> [2]: https://bugs.launchpad.net/kicad/+bug/1846028
> [3]: https://bugs.launchpad.net/kicad/+bug/1846029
>
> On 10/20/19 10:13 AM, Seth Hillbrand wrote:
> > On 2019-10-20 06:41, Wayne Stambaugh wrote:
> >> Where are we on the 5.1.5 release?  I took a look at the bug tacker and
> >> the only serious bug I saw was the glib assertion bug[1].  How close are
> >> we to getting this fixed?  There is still some unexpected behavior with
> >> the constrained zone drawing and editing changes that should be fixed
> >> before we release.  I would like to tag -rc1 and start the string freeze
> >> by the end of October.
> >
> > Odd, I didn't see that one come through.  I'll fix that this weekend.
> >
> > -S
> >
> > Seth Hillbrand
> > KiCad Services Corporation
> > https://www.kipro-pcb.com
> > +1 530 302 5483 | +1 212 603 9372
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Wayne Stambaugh]

Thanks Seth,

There is also this[1] bug and this[2] bug and this[3] bug related to the
zone constraint changes.  I probably wont hold up the 5.1.5 release for
them but they are behavioral changes which users will not expect.  The
most annoying one is lp:1846028.

Cheers,

Wayne

[1]: https://bugs.launchpad.net/kicad/+bug/1842195
[2]: https://bugs.launchpad.net/kicad/+bug/1846028
[3]: https://bugs.launchpad.net/kicad/+bug/1846029

On 10/20/19 10:13 AM, Seth Hillbrand wrote:
> On 2019-10-20 06:41, Wayne Stambaugh wrote:
>> Where are we on the 5.1.5 release?  I took a look at the bug tacker and
>> the only serious bug I saw was the glib assertion bug[1].  How close are
>> we to getting this fixed?  There is still some unexpected behavior with
>> the constrained zone drawing and editing changes that should be fixed
>> before we release.  I would like to tag -rc1 and start the string freeze
>> by the end of October.
> 
> Odd, I didn't see that one come through.  I'll fix that this weekend.
> 
> -S
> 
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] 5.1.5 release status

[Seth Hillbrand]

On 2019-10-20 06:41, Wayne Stambaugh wrote:

Where are we on the 5.1.5 release?  I took a look at the bug tacker and
the only serious bug I saw was the glib assertion bug[1].  How close 
are

we to getting this fixed?  There is still some unexpected behavior with
the constrained zone drawing and editing changes that should be fixed
before we release.  I would like to tag -rc1 and start the string 
freeze

by the end of October.


Odd, I didn't see that one come through.  I'll fix that this weekend.

-S

Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp