Re: [Kicad-developers] Patch: Fixing a compile error on Power PC
Hi, On Tue, Aug 27, 2019 at 05:14:47PM +0200, Tomasz Wlostowski wrote: > Does anybody here have a PPC machine to test this? Preferably one with > working OpenGL? I have half of one, missing a case though so it's not set up yet. With luck, I'll get to that next week, then I can also integrate it with Jenkins so we can get regular reports. Simon ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Patch: Fixing a compile error on Power PC
On 8/27/19 11:14 AM, Tomasz Wlostowski wrote: > On 27/08/2019 16:18, Steven A. Falco wrote: >> On 8/26/19 4:16 PM, Seth Hillbrand wrote: >>> On 2019-08-26 16:05, Tomasz Wlostowski wrote: On 26/08/2019 17:24, Seth Hillbrand wrote: > Agreed. That looks like it may be have been a rebase issue as the > commit was for MSVC and shouldn't affect PPC. > > @Tom, shout if you see an issue here. I've pushed the patch to master > in the meantime. > I don't see a technical issue, but rather a practical one: why Linux distributions dictate us what architectures we should support? I've never seen a machine with a little-endian PPC. Tom >>> >>> The LE variant is the PPC future starting with POWER8[1][2]. >>> >>> [1] >>> https://www.phoronix.com/scan.php?page=news_item=POWER-PPC64-Discontinue-Fedora >>> [2] https://developer.ibm.com/articles/l-power-little-endian-faq-trs/ >>> >> >> I don't think it is a question of LE vs BE. The issue is 32-bit vs 64-bit. >> >> On a 64-bit PPC machine, gcc defines both _ARCH_PPC and _ARCH_PPC64, so the >> test in libcontext.h was wrong, and resulted in both 32-bit and 64-bit code >> trying to be compiled simultaneously. My patch simply makes it "either >> 32bit or 64-bit" rather than "both 32-bit and 64-bit at the same time". >> > > Does anybody here have a PPC machine to test this? Preferably one with > working OpenGL? > > Cheers, > Tom > I actually tested it on a PPC64LE virtual machine. While it is naturally slow on a VM, I was able to launch KiCAD with my patch, and it worked perfectly. Steve ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Patch: Fixing a compile error on Power PC
On 27/08/2019 16:18, Steven A. Falco wrote: > On 8/26/19 4:16 PM, Seth Hillbrand wrote: >> On 2019-08-26 16:05, Tomasz Wlostowski wrote: >>> On 26/08/2019 17:24, Seth Hillbrand wrote: Agreed. That looks like it may be have been a rebase issue as the commit was for MSVC and shouldn't affect PPC. @Tom, shout if you see an issue here. I've pushed the patch to master in the meantime. >>> I don't see a technical issue, but rather a practical one: why Linux >>> distributions dictate us what architectures we should support? >>> >>> I've never seen a machine with a little-endian PPC. >>> >>> Tom >> >> The LE variant is the PPC future starting with POWER8[1][2]. >> >> [1] >> https://www.phoronix.com/scan.php?page=news_item=POWER-PPC64-Discontinue-Fedora >> [2] https://developer.ibm.com/articles/l-power-little-endian-faq-trs/ >> > > I don't think it is a question of LE vs BE. The issue is 32-bit vs 64-bit. > > On a 64-bit PPC machine, gcc defines both _ARCH_PPC and _ARCH_PPC64, so the > test in libcontext.h was wrong, and resulted in both 32-bit and 64-bit code > trying to be compiled simultaneously. My patch simply makes it "either 32bit > or 64-bit" rather than "both 32-bit and 64-bit at the same time". > Does anybody here have a PPC machine to test this? Preferably one with working OpenGL? Cheers, Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Patch: Fixing a compile error on Power PC
On 8/26/19 4:16 PM, Seth Hillbrand wrote: > On 2019-08-26 16:05, Tomasz Wlostowski wrote: >> On 26/08/2019 17:24, Seth Hillbrand wrote: >>> Agreed. That looks like it may be have been a rebase issue as the >>> commit was for MSVC and shouldn't affect PPC. >>> >>> @Tom, shout if you see an issue here. I've pushed the patch to master >>> in the meantime. >>> >> I don't see a technical issue, but rather a practical one: why Linux >> distributions dictate us what architectures we should support? >> >> I've never seen a machine with a little-endian PPC. >> >> Tom > > The LE variant is the PPC future starting with POWER8[1][2]. > > [1] > https://www.phoronix.com/scan.php?page=news_item=POWER-PPC64-Discontinue-Fedora > [2] https://developer.ibm.com/articles/l-power-little-endian-faq-trs/ > I don't think it is a question of LE vs BE. The issue is 32-bit vs 64-bit. On a 64-bit PPC machine, gcc defines both _ARCH_PPC and _ARCH_PPC64, so the test in libcontext.h was wrong, and resulted in both 32-bit and 64-bit code trying to be compiled simultaneously. My patch simply makes it "either 32bit or 64-bit" rather than "both 32-bit and 64-bit at the same time". Steve ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Patch: Fixing a compile error on Power PC
On 2019-08-26 16:05, Tomasz Wlostowski wrote: On 26/08/2019 17:24, Seth Hillbrand wrote: Agreed. That looks like it may be have been a rebase issue as the commit was for MSVC and shouldn't affect PPC. @Tom, shout if you see an issue here. I've pushed the patch to master in the meantime. I don't see a technical issue, but rather a practical one: why Linux distributions dictate us what architectures we should support? I've never seen a machine with a little-endian PPC. Tom The LE variant is the PPC future starting with POWER8[1][2]. [1] https://www.phoronix.com/scan.php?page=news_item=POWER-PPC64-Discontinue-Fedora [2] https://developer.ibm.com/articles/l-power-little-endian-faq-trs/ ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Patch: Fixing a compile error on Power PC
On 26/08/2019 17:24, Seth Hillbrand wrote: > Agreed. That looks like it may be have been a rebase issue as the > commit was for MSVC and shouldn't affect PPC. > > @Tom, shout if you see an issue here. I've pushed the patch to master > in the meantime. > I don't see a technical issue, but rather a practical one: why Linux distributions dictate us what architectures we should support? I've never seen a machine with a little-endian PPC. Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Patch: Fixing a compile error on Power PC
Agreed. That looks like it may be have been a rebase issue as the commit was for MSVC and shouldn't affect PPC. @Tom, shout if you see an issue here. I've pushed the patch to master in the meantime. Best- Seth On 2019-08-24 18:00, Steven A. Falco wrote: I have enabled compilation for PPC64LE, because that was requested by a Fedora user. KiCAD builds fine for 5.1, but the PPC64 compilation is broken on master. The attached patch fixes that by reverting a small portion of commit 6cab769f41f. Basically, on a 64-bit PPC machine, gcc defines both _ARCH_PPC and _ARCH_PPC64, thus commit 6cab769f41f resulted in trying to compile 32-bit PPC assembly code on PPC64. Also, assuming the assembly worked, we would have wound up with multiple copies of the context code. Steve ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
