Re: [Kicad-developers] disable icons in menus by default on osx

[Wayne Stambaugh]

The correct way to fix this would be to leave the #ifdef in place and
put m_useIconsInMenus in the Read() setting function as the default so
the correct default value is used the first time kicad is run.  Your
change makes off the default for all platforms which doesn't fix the
underlying issue.  I'll fix this.  It's a trivial change.

On 9/12/2017 4:57 PM, Michael Kavanagh wrote:
> Doesn't matter to me (although I personally always turn them off). I was
> just pointing out that the code didn't appear to work as it was intended
> to on macOS and provided an alternative.
> 
> Michael
> 
> On 12 September 2017 at 16:28, Wayne Stambaugh  > wrote:
> 
> Do we really need to change the default?  All this will do is change
> which group of users complains about the default setting.  The reason we
> changed this is that some users wanted the menu bitmaps even on
> platforms where it is recommended not to use them.  I just don't see any
> benefit to making this change.  Is it that difficult for users to check
> or uncheck the menu bitmap setting according to their preference?
> 
> Wayne
> 
> On 9/12/2017 8:56 AM, Fabrizio Tappero wrote:
> > Hi Diogo,
> > thanks for point it our. This has been fixed in a patch that is
> > currently in the pipeline.
> >
> > Cheers
> > Fabrizio
> >
> >
> > On Mon, Sep 11, 2017 at 7:51 PM, Diogo Condeço  
> > >> wrote:
> >
> >     While personally I won't use icons in the menus if that option is
> >     available to me, I can see why someone would like to use them. 
> >
> >     I can see it being useful to identify actions visually, but with
> >     that in mind, I can't understand why having icons and reusing them
> >     on different functions would help anyone. I've attached a screenshot
> >     where the same icon is used for 3 different actions
> >
> >     BR,
> >     Diogo
> >
> >     On Thu, Sep 7, 2017 at 3:59 PM, Miguel Angel Ajo Pelayo
> >     
> >> wrote:
> >
> >         I personally (as a user) find the icons visually more intuitive.
> >         Specially for newcomers and better adoption of KiCad.
> >
> >         I know it's out of some guidelines, but this is a very complex
> >         software.
> >
> >         My feeling is that it's better with a "on" by default setting,
> >         as long as people already used to the software, or not liking
> >         icons could disable them.
> >
> >         On Thu, Sep 7, 2017 at 4:34 PM, Michael Kavanagh
> >          
> >>
> >         wrote:
> >
> >             Hi,
> >
> >             Sorry to bring this up again, but for me icons are still
> >             enabled by default on macOS (and Windows unsurprisingly). I
> >             deleted /Library/Application Support/kicad,
> >             ~/Library/Preferences/kicad and /Applications/Kicad,
> >             reinstalled from most recent nightly (07-Sep-2017) and the
> >             icons were there upon startup.
> >
> >             I think the problem was the default value was true when the
> >             key wasn't found (ie for new install),
> >             see 
> http://docs.wxwidgets.org/trunk/classwx_config_base.html#a93b700301e0b73f1b42f14497f2e6bc7
> 
> 
> >             
>  
> >
> >
> >             I have attached a patch to turn icons off by default on all
> >             platforms (doing away with "ugly" #if defined()/#endif). I
> >             think this would be preferable as per both the macOS and
> >             Windows guidelines. I am unfamiliar with Linux UI's but if
> >             Linux users want the icons enabled by default the #if will
> >             have to be added again.
> >
> >             Cheers,
> >             Michael
> >
> >
> >             On 13 April 2017 at 18:51, Wayne Stambaugh
> >             
> >> wrote:
> >
> >                 Simon,
> >
> >                 I committed your patch since osx expects the icons to be
> >        

Re: [Kicad-developers] disable icons in menus by default on osx

[Michael Kavanagh]

Doesn't matter to me (although I personally always turn them off). I was
just pointing out that the code didn't appear to work as it was intended to
on macOS and provided an alternative.

Michael

On 12 September 2017 at 16:28, Wayne Stambaugh  wrote:

> Do we really need to change the default?  All this will do is change
> which group of users complains about the default setting.  The reason we
> changed this is that some users wanted the menu bitmaps even on
> platforms where it is recommended not to use them.  I just don't see any
> benefit to making this change.  Is it that difficult for users to check
> or uncheck the menu bitmap setting according to their preference?
>
> Wayne
>
> On 9/12/2017 8:56 AM, Fabrizio Tappero wrote:
> > Hi Diogo,
> > thanks for point it our. This has been fixed in a patch that is
> > currently in the pipeline.
> >
> > Cheers
> > Fabrizio
> >
> >
> > On Mon, Sep 11, 2017 at 7:51 PM, Diogo Condeço  > > wrote:
> >
> > While personally I won't use icons in the menus if that option is
> > available to me, I can see why someone would like to use them.
> >
> > I can see it being useful to identify actions visually, but with
> > that in mind, I can't understand why having icons and reusing them
> > on different functions would help anyone. I've attached a screenshot
> > where the same icon is used for 3 different actions
> >
> > BR,
> > Diogo
> >
> > On Thu, Sep 7, 2017 at 3:59 PM, Miguel Angel Ajo Pelayo
> > > wrote:
> >
> > I personally (as a user) find the icons visually more intuitive.
> > Specially for newcomers and better adoption of KiCad.
> >
> > I know it's out of some guidelines, but this is a very complex
> > software.
> >
> > My feeling is that it's better with a "on" by default setting,
> > as long as people already used to the software, or not liking
> > icons could disable them.
> >
> > On Thu, Sep 7, 2017 at 4:34 PM, Michael Kavanagh
> > >
> > wrote:
> >
> > Hi,
> >
> > Sorry to bring this up again, but for me icons are still
> > enabled by default on macOS (and Windows unsurprisingly). I
> > deleted /Library/Application Support/kicad,
> > ~/Library/Preferences/kicad and /Applications/Kicad,
> > reinstalled from most recent nightly (07-Sep-2017) and the
> > icons were there upon startup.
> >
> > I think the problem was the default value was true when the
> > key wasn't found (ie for new install),
> > see http://docs.wxwidgets.org/trunk/classwx_config_base.
> html#a93b700301e0b73f1b42f14497f2e6bc7
> >  a93b700301e0b73f1b42f14497f2e6bc7>
> >
> > I have attached a patch to turn icons off by default on all
> > platforms (doing away with "ugly" #if defined()/#endif). I
> > think this would be preferable as per both the macOS and
> > Windows guidelines. I am unfamiliar with Linux UI's but if
> > Linux users want the icons enabled by default the #if will
> > have to be added again.
> >
> > Cheers,
> > Michael
> >
> >
> > On 13 April 2017 at 18:51, Wayne Stambaugh
> > > wrote:
> >
> > Simon,
> >
> > I committed your patch since osx expects the icons to be
> > disabled by
> > default.
> >
> > Thanks,
> >
> > Wayne
> >
> > On 4/8/2017 6:42 AM, Simon Wells wrote:
> > > Please see attached patch to disable icons in the
> menus by default on osx
> > >
> > >
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > > Post to : kicad-developers@lists.launchpad.net
> > 
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > > More help   : https://help.launchpad.net/ListHelp
> > 
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : 

Re: [Kicad-developers] disable icons in menus by default on osx

[Wayne Stambaugh]

Do we really need to change the default?  All this will do is change
which group of users complains about the default setting.  The reason we
changed this is that some users wanted the menu bitmaps even on
platforms where it is recommended not to use them.  I just don't see any
benefit to making this change.  Is it that difficult for users to check
or uncheck the menu bitmap setting according to their preference?

Wayne

On 9/12/2017 8:56 AM, Fabrizio Tappero wrote:
> Hi Diogo,
> thanks for point it our. This has been fixed in a patch that is
> currently in the pipeline.
> 
> Cheers
> Fabrizio
> 
> 
> On Mon, Sep 11, 2017 at 7:51 PM, Diogo Condeço  > wrote:
> 
> While personally I won't use icons in the menus if that option is
> available to me, I can see why someone would like to use them. 
> 
> I can see it being useful to identify actions visually, but with
> that in mind, I can't understand why having icons and reusing them
> on different functions would help anyone. I've attached a screenshot
> where the same icon is used for 3 different actions
> 
> BR,
> Diogo
> 
> On Thu, Sep 7, 2017 at 3:59 PM, Miguel Angel Ajo Pelayo
> > wrote:
> 
> I personally (as a user) find the icons visually more intuitive.
> Specially for newcomers and better adoption of KiCad.
> 
> I know it's out of some guidelines, but this is a very complex
> software.
> 
> My feeling is that it's better with a "on" by default setting,
> as long as people already used to the software, or not liking
> icons could disable them.
> 
> On Thu, Sep 7, 2017 at 4:34 PM, Michael Kavanagh
> >
> wrote:
> 
> Hi,
> 
> Sorry to bring this up again, but for me icons are still
> enabled by default on macOS (and Windows unsurprisingly). I
> deleted /Library/Application Support/kicad,
> ~/Library/Preferences/kicad and /Applications/Kicad,
> reinstalled from most recent nightly (07-Sep-2017) and the
> icons were there upon startup.
> 
> I think the problem was the default value was true when the
> key wasn't found (ie for new install),
> see 
> http://docs.wxwidgets.org/trunk/classwx_config_base.html#a93b700301e0b73f1b42f14497f2e6bc7
> 
> 
> 
> I have attached a patch to turn icons off by default on all
> platforms (doing away with "ugly" #if defined()/#endif). I
> think this would be preferable as per both the macOS and
> Windows guidelines. I am unfamiliar with Linux UI's but if
> Linux users want the icons enabled by default the #if will
> have to be added again.
> 
> Cheers,
> Michael
> 
> 
> On 13 April 2017 at 18:51, Wayne Stambaugh
> > wrote:
> 
> Simon,
> 
> I committed your patch since osx expects the icons to be
> disabled by
> default.
> 
> Thanks,
> 
> Wayne
> 
> On 4/8/2017 6:42 AM, Simon Wells wrote:
> > Please see attached patch to disable icons in the menus by 
> default on osx
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> ___
> Mailing list: 

Re: [Kicad-developers] disable icons in menus by default on osx

[Wayne Stambaugh]

On 9/11/2017 1:51 PM, Diogo Condeço wrote:
> While personally I won't use icons in the menus if that option is
> available to me, I can see why someone would like to use them. 
> 
> I can see it being useful to identify actions visually, but with that in
> mind, I can't understand why having icons and reusing them on different
> functions would help anyone. I've attached a screenshot where the same
> icon is used for 3 different actions

The "Component Libraries" menu entry is soon going to go away leaving
only the "Symbol Library Table" menu entry so there will not be a
duplicate bitmap once this work is complete.

> 
> BR,
> Diogo
> 
> On Thu, Sep 7, 2017 at 3:59 PM, Miguel Angel Ajo Pelayo
> > wrote:
> 
> I personally (as a user) find the icons visually more intuitive.
> Specially for newcomers and better adoption of KiCad.
> 
> I know it's out of some guidelines, but this is a very complex software.
> 
> My feeling is that it's better with a "on" by default setting, as
> long as people already used to the software, or not liking icons
> could disable them.
> 
> On Thu, Sep 7, 2017 at 4:34 PM, Michael Kavanagh
> > wrote:
> 
> Hi,
> 
> Sorry to bring this up again, but for me icons are still enabled
> by default on macOS (and Windows unsurprisingly). I deleted
> /Library/Application Support/kicad, ~/Library/Preferences/kicad
> and /Applications/Kicad, reinstalled from most recent nightly
> (07-Sep-2017) and the icons were there upon startup.
> 
> I think the problem was the default value was true when the key
> wasn't found (ie for new install),
> see 
> http://docs.wxwidgets.org/trunk/classwx_config_base.html#a93b700301e0b73f1b42f14497f2e6bc7
> 
> 
> 
> I have attached a patch to turn icons off by default on all
> platforms (doing away with "ugly" #if defined()/#endif). I think
> this would be preferable as per both the macOS and Windows
> guidelines. I am unfamiliar with Linux UI's but if Linux users
> want the icons enabled by default the #if will have to be added
> again.
> 
> Cheers,
> Michael
> 
> 
> On 13 April 2017 at 18:51, Wayne Stambaugh  > wrote:
> 
> Simon,
> 
> I committed your patch since osx expects the icons to be
> disabled by
> default.
> 
> Thanks,
> 
> Wayne
> 
> On 4/8/2017 6:42 AM, Simon Wells wrote:
> > Please see attached patch to disable icons in the menus by 
> default on osx
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More 

Re: [Kicad-developers] disable icons in menus by default on osx

[Fabrizio Tappero]

Hi Diogo,
thanks for point it our. This has been fixed in a patch that is currently
in the pipeline.

Cheers
Fabrizio


On Mon, Sep 11, 2017 at 7:51 PM, Diogo Condeço 
wrote:

> While personally I won't use icons in the menus if that option is
> available to me, I can see why someone would like to use them.
>
> I can see it being useful to identify actions visually, but with that in
> mind, I can't understand why having icons and reusing them on different
> functions would help anyone. I've attached a screenshot where the same icon
> is used for 3 different actions
>
> BR,
> Diogo
>
> On Thu, Sep 7, 2017 at 3:59 PM, Miguel Angel Ajo Pelayo <
> majop...@redhat.com> wrote:
>
>> I personally (as a user) find the icons visually more intuitive.
>> Specially for newcomers and better adoption of KiCad.
>>
>> I know it's out of some guidelines, but this is a very complex software.
>>
>> My feeling is that it's better with a "on" by default setting, as long as
>> people already used to the software, or not liking icons could disable them.
>>
>> On Thu, Sep 7, 2017 at 4:34 PM, Michael Kavanagh <
>> mich...@michaelkavanagh.me> wrote:
>>
>>> Hi,
>>>
>>> Sorry to bring this up again, but for me icons are still enabled by
>>> default on macOS (and Windows unsurprisingly). I deleted
>>> /Library/Application Support/kicad, ~/Library/Preferences/kicad and
>>> /Applications/Kicad, reinstalled from most recent nightly (07-Sep-2017)
>>> and the icons were there upon startup.
>>>
>>> I think the problem was the default value was true when the key wasn't
>>> found (ie for new install), see http://docs.wxwidgets.org/
>>> trunk/classwx_config_base.html#a93b700301e0b73f1b42f14497f2e6bc7
>>>
>>> I have attached a patch to turn icons off by default on all platforms
>>> (doing away with "ugly" #if defined()/#endif). I think this would be
>>> preferable as per both the macOS and Windows guidelines. I am
>>> unfamiliar with Linux UI's but if Linux users want the icons enabled by
>>> default the #if will have to be added again.
>>>
>>> Cheers,
>>> Michael
>>>
>>>
>>> On 13 April 2017 at 18:51, Wayne Stambaugh  wrote:
>>>
 Simon,

 I committed your patch since osx expects the icons to be disabled by
 default.

 Thanks,

 Wayne

 On 4/8/2017 6:42 AM, Simon Wells wrote:
 > Please see attached patch to disable icons in the menus by default on
 osx
 >
 >
 >
 > ___
 > Mailing list: https://launchpad.net/~kicad-developers
 > Post to : kicad-developers@lists.launchpad.net
 > Unsubscribe : https://launchpad.net/~kicad-developers
 > More help   : https://help.launchpad.net/ListHelp
 >

 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
>
> --
> Diogo Condeço
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] disable icons in menus by default on osx

[Diogo Condeço]

While personally I won't use icons in the menus if that option is available
to me, I can see why someone would like to use them.

I can see it being useful to identify actions visually, but with that in
mind, I can't understand why having icons and reusing them on different
functions would help anyone. I've attached a screenshot where the same icon
is used for 3 different actions

BR,
Diogo

On Thu, Sep 7, 2017 at 3:59 PM, Miguel Angel Ajo Pelayo  wrote:

> I personally (as a user) find the icons visually more intuitive. Specially
> for newcomers and better adoption of KiCad.
>
> I know it's out of some guidelines, but this is a very complex software.
>
> My feeling is that it's better with a "on" by default setting, as long as
> people already used to the software, or not liking icons could disable them.
>
> On Thu, Sep 7, 2017 at 4:34 PM, Michael Kavanagh <
> mich...@michaelkavanagh.me> wrote:
>
>> Hi,
>>
>> Sorry to bring this up again, but for me icons are still enabled by
>> default on macOS (and Windows unsurprisingly). I deleted
>> /Library/Application Support/kicad, ~/Library/Preferences/kicad and
>> /Applications/Kicad, reinstalled from most recent nightly (07-Sep-2017)
>> and the icons were there upon startup.
>>
>> I think the problem was the default value was true when the key wasn't
>> found (ie for new install), see http://docs.wxwidgets.org/
>> trunk/classwx_config_base.html#a93b700301e0b73f1b42f14497f2e6bc7
>>
>> I have attached a patch to turn icons off by default on all platforms
>> (doing away with "ugly" #if defined()/#endif). I think this would be
>> preferable as per both the macOS and Windows guidelines. I am
>> unfamiliar with Linux UI's but if Linux users want the icons enabled by
>> default the #if will have to be added again.
>>
>> Cheers,
>> Michael
>>
>>
>> On 13 April 2017 at 18:51, Wayne Stambaugh  wrote:
>>
>>> Simon,
>>>
>>> I committed your patch since osx expects the icons to be disabled by
>>> default.
>>>
>>> Thanks,
>>>
>>> Wayne
>>>
>>> On 4/8/2017 6:42 AM, Simon Wells wrote:
>>> > Please see attached patch to disable icons in the menus by default on
>>> osx
>>> >
>>> >
>>> >
>>> > ___
>>> > Mailing list: https://launchpad.net/~kicad-developers
>>> > Post to : kicad-developers@lists.launchpad.net
>>> > Unsubscribe : https://launchpad.net/~kicad-developers
>>> > More help   : https://help.launchpad.net/ListHelp
>>> >
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Diogo Condeço
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] disable icons in menus by default on osx

[Miguel Angel Ajo Pelayo]

I personally (as a user) find the icons visually more intuitive. Specially
for newcomers and better adoption of KiCad.

I know it's out of some guidelines, but this is a very complex software.

My feeling is that it's better with a "on" by default setting, as long as
people already used to the software, or not liking icons could disable them.

On Thu, Sep 7, 2017 at 4:34 PM, Michael Kavanagh  wrote:

> Hi,
>
> Sorry to bring this up again, but for me icons are still enabled by
> default on macOS (and Windows unsurprisingly). I deleted
> /Library/Application Support/kicad, ~/Library/Preferences/kicad and
> /Applications/Kicad, reinstalled from most recent nightly (07-Sep-2017)
> and the icons were there upon startup.
>
> I think the problem was the default value was true when the key wasn't
> found (ie for new install), see http://docs.wxwidgets.org/
> trunk/classwx_config_base.html#a93b700301e0b73f1b42f14497f2e6bc7
>
> I have attached a patch to turn icons off by default on all platforms
> (doing away with "ugly" #if defined()/#endif). I think this would be
> preferable as per both the macOS and Windows guidelines. I am
> unfamiliar with Linux UI's but if Linux users want the icons enabled by
> default the #if will have to be added again.
>
> Cheers,
> Michael
>
>
> On 13 April 2017 at 18:51, Wayne Stambaugh  wrote:
>
>> Simon,
>>
>> I committed your patch since osx expects the icons to be disabled by
>> default.
>>
>> Thanks,
>>
>> Wayne
>>
>> On 4/8/2017 6:42 AM, Simon Wells wrote:
>> > Please see attached patch to disable icons in the menus by default on
>> osx
>> >
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] disable icons in menus by default on osx

[Michael Kavanagh]

Hi,

Sorry to bring this up again, but for me icons are still enabled by default
on macOS (and Windows unsurprisingly). I deleted /Library/Application
Support/kicad, ~/Library/Preferences/kicad and /Applications/Kicad,
reinstalled from most recent nightly (07-Sep-2017) and the icons were there
upon startup.

I think the problem was the default value was true when the key wasn't
found (ie for new install), see
http://docs.wxwidgets.org/trunk/classwx_config_base.html#a93b700301e0b73f1b42f14497f2e6bc7

I have attached a patch to turn icons off by default on all platforms
(doing away with "ugly" #if defined()/#endif). I think this would be
preferable as per both the macOS and Windows guidelines. I am
unfamiliar with Linux UI's but if Linux users want the icons enabled by
default the #if will have to be added again.

Cheers,
Michael


On 13 April 2017 at 18:51, Wayne Stambaugh  wrote:

> Simon,
>
> I committed your patch since osx expects the icons to be disabled by
> default.
>
> Thanks,
>
> Wayne
>
> On 4/8/2017 6:42 AM, Simon Wells wrote:
> > Please see attached patch to disable icons in the menus by default on osx
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


0001-Change-menubar-icons-to-off-by-default.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] disable icons in menus by default on osx

[Wayne Stambaugh]

Simon,

I committed your patch since osx expects the icons to be disabled by
default.

Thanks,

Wayne

On 4/8/2017 6:42 AM, Simon Wells wrote:
> Please see attached patch to disable icons in the menus by default on osx
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] disable icons in menus by default on osx

[Andy Peters]

> On Apr 10, 2017, at 12:12 PM, Wayne Stambaugh  wrote:
> 
> I thought the reason that we added this option is so that users could
> choose if they wanted to show the icons in menus.  I seem to remember
> from the original discussion that some of our osx users didn't like the
> fact that they were compiled out of osx builds.  Do we really need to
> add the ugly #if defined()/#endif code?

I believe that the standard OS X user-interface design guidelines oppose 
in-menu icons. (I don’t care either way.)


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] disable icons in menus by default on osx

[Simon Wells]

this is only a single #ifdef to default it to off as osx has been as
long as i have been using it, its not compiling the icons out or
anything

On 11 April 2017 at 07:12, Wayne Stambaugh  wrote:
> I thought the reason that we added this option is so that users could
> choose if they wanted to show the icons in menus.  I seem to remember
> from the original discussion that some of our osx users didn't like the
> fact that they were compiled out of osx builds.  Do we really need to
> add the ugly #if defined()/#endif code?
>
> As for the icon size, fixing that would likely not be trivial.  A long
> time ago we used 16 X 16 images but users were complaining that they
> were too small as display resolution increased so we increased them to
> 24 X 24.  We could create an image library with multiple size images to
> resolve this issue.
>
> On 4/8/2017 6:55 AM, Simon Wells wrote:
>> also as noticed with this the icons seem overly huge for the menu, are
>> they actually the right size on any platform? as on osx at least if you
>> want the option there they should really be created at the right size so
>> that it fits in with how tall a row should be in a menu rather than
>> making each row huge as seen in screenshot
>>
>>
>>
>>
>> On 8 April 2017 at 22:42, Simon Wells > > wrote:
>>
>> Please see attached patch to disable icons in the menus by default
>> on osx
>>
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] disable icons in menus by default on osx

[Wayne Stambaugh]

I thought the reason that we added this option is so that users could
choose if they wanted to show the icons in menus.  I seem to remember
from the original discussion that some of our osx users didn't like the
fact that they were compiled out of osx builds.  Do we really need to
add the ugly #if defined()/#endif code?

As for the icon size, fixing that would likely not be trivial.  A long
time ago we used 16 X 16 images but users were complaining that they
were too small as display resolution increased so we increased them to
24 X 24.  We could create an image library with multiple size images to
resolve this issue.

On 4/8/2017 6:55 AM, Simon Wells wrote:
> also as noticed with this the icons seem overly huge for the menu, are
> they actually the right size on any platform? as on osx at least if you
> want the option there they should really be created at the right size so
> that it fits in with how tall a row should be in a menu rather than
> making each row huge as seen in screenshot
> 
> 
> 
> 
> On 8 April 2017 at 22:42, Simon Wells  > wrote:
> 
> Please see attached patch to disable icons in the menus by default
> on osx
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp