Re: [Kicad-developers] eeschema regression

[Wayne Stambaugh]

When opening the symbol chooser dialog, the progress dialog is only
shown the first time.  When the progress dialog was being shown every
time, the libraries were not actually being reloaded.  So the only issue
was the progress dialog being shown every time.

However, the same cannot be said for the new symbol library editor which
uses a new library manager object which forces a complete reload of the
symbol library table.  I have serious reservations about this code and
the changes made to the component tree adapter code to support it.  I
will be addressing soon.

On 1/3/2018 7:25 PM, Oliver Walters wrote:
> Has this been fixed? I feel it should be addressed before v5 release. I
> haven't had a chance to see if it has been remedied in a recent nightly. 
> 
> On 22 Dec 2017 04:55, "Wayne Stambaugh"  > wrote:
> 
> I was working a new board and I'm seeing this now too.  I didn't make
> any changes to this code so who ever broke it, please fix it.  You
> shouldn't need to reload the entire library table every time you add a
> symbol.  The library caches should only get reloaded the first time they
> are opened, a change occurs to the library file since the last time they
> were opened (this is automatic and doesn't require you do anything), or
> changes are made to the library table.
> 
> On 12/17/2017 2:19 PM, Nick Østergaard wrote:
> > I am not sure why, but I see the progress dialog opened for an equal
> > amount of time every time in my case. Testing on windows 10.
> >
> > The path Seth proposed seem to work sort of. But it does not show the
> > loading dialog on init and I get an error dialog shortly after I open
> > eeschema that it fails to load a dcm file. This error does not occur
> > without Seths patch.
> >
> > But on subsequent additions of a symbol the dialog is not shown
> and with
> > no delay as expected.
> >
> > 2017-12-16 23:52 GMT+01:00 Oliver Walters
> >  
>  >>:
> >
> >     Wayne,
> >
> >     I believe you are correct, they are cached and the progress dialog
> >     is the actual source of the perceived delay. If this dialog is
> only
> >     shown on first library load that would be sufficient.
> >
> >     On Sun, Dec 17, 2017 at 12:40 AM, Wayne Stambaugh
> >     
> >> wrote:
> >
> >         Are you sure the libraries are actually being reloaded?  The
> >         behavior I
> >         observe is the first time I open the symbol chooser, the
> >         progress dialog
> >         is open for a significant amount of time while the
> libraries are
> >         being
> >         loaded.  On all subsequent openings of the symbol chooser, the
> >         progress
> >         dialog is dismissed very quickly indicating that the
> libraries have
> >         already been cached.  I agree that the progress dialog being
> >         displayed
> >         every time the symbol chooser is opened is annoying.  I
> probably
> >         merged
> >         this patch too quickly.  After the initial loading of all
> of the
> >         symbol
> >         libraries, the progress dialog doesn't need to be shown.
> >
> >         On 12/15/2017 09:10 PM, Oliver Walters wrote:
> >         > I think that there has been a functional regression in a
> >         recent build,
> >         > relating to placing symbols in eeschema.
> >         >
> >         > Previously, the libraries were loaded once when the
> schematic
> >         was opened.
> >         >
> >         > now, the entire symbol library set is re-loaded every
> time you
> >         select
> >         > "Place Symbol". This brings up the "loading symbol
> libraries"
> >         progress
> >         > dialog before opening the component selector window.
> >         >
> >         > This is very tedious - especially on Windows where loading
> >         symbols can
> >         > be an order of magnitude slower than linux. It really
> >         interrupts work flow.
> >         >
> >         > I do not imagine this is intended behaviour? Can anyone
> >         comment on this?
> >         >
> >         > Oliver
> >         >
> >         >
> >         > ___
> >         > Mailing list: https://launchpad.net/~kicad-developers
> 
> >          

Re: [Kicad-developers] eeschema regression

[Oliver Walters]

Has this been fixed? I feel it should be addressed before v5 release. I
haven't had a chance to see if it has been remedied in a recent nightly.

On 22 Dec 2017 04:55, "Wayne Stambaugh"  wrote:

> I was working a new board and I'm seeing this now too.  I didn't make
> any changes to this code so who ever broke it, please fix it.  You
> shouldn't need to reload the entire library table every time you add a
> symbol.  The library caches should only get reloaded the first time they
> are opened, a change occurs to the library file since the last time they
> were opened (this is automatic and doesn't require you do anything), or
> changes are made to the library table.
>
> On 12/17/2017 2:19 PM, Nick Østergaard wrote:
> > I am not sure why, but I see the progress dialog opened for an equal
> > amount of time every time in my case. Testing on windows 10.
> >
> > The path Seth proposed seem to work sort of. But it does not show the
> > loading dialog on init and I get an error dialog shortly after I open
> > eeschema that it fails to load a dcm file. This error does not occur
> > without Seths patch.
> >
> > But on subsequent additions of a symbol the dialog is not shown and with
> > no delay as expected.
> >
> > 2017-12-16 23:52 GMT+01:00 Oliver Walters
> >  >>:
> >
> > Wayne,
> >
> > I believe you are correct, they are cached and the progress dialog
> > is the actual source of the perceived delay. If this dialog is only
> > shown on first library load that would be sufficient.
> >
> > On Sun, Dec 17, 2017 at 12:40 AM, Wayne Stambaugh
> > > wrote:
> >
> > Are you sure the libraries are actually being reloaded?  The
> > behavior I
> > observe is the first time I open the symbol chooser, the
> > progress dialog
> > is open for a significant amount of time while the libraries are
> > being
> > loaded.  On all subsequent openings of the symbol chooser, the
> > progress
> > dialog is dismissed very quickly indicating that the libraries
> have
> > already been cached.  I agree that the progress dialog being
> > displayed
> > every time the symbol chooser is opened is annoying.  I probably
> > merged
> > this patch too quickly.  After the initial loading of all of the
> > symbol
> > libraries, the progress dialog doesn't need to be shown.
> >
> > On 12/15/2017 09:10 PM, Oliver Walters wrote:
> > > I think that there has been a functional regression in a
> > recent build,
> > > relating to placing symbols in eeschema.
> > >
> > > Previously, the libraries were loaded once when the schematic
> > was opened.
> > >
> > > now, the entire symbol library set is re-loaded every time you
> > select
> > > "Place Symbol". This brings up the "loading symbol libraries"
> > progress
> > > dialog before opening the component selector window.
> > >
> > > This is very tedious - especially on Windows where loading
> > symbols can
> > > be an order of magnitude slower than linux. It really
> > interrupts work flow.
> > >
> > > I do not imagine this is intended behaviour? Can anyone
> > comment on this?
> > >
> > > Oliver
> > >
> > >
> > > ___
> > > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > > Post to : kicad-developers@lists.launchpad.net
> > 
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > > More help   : https://help.launchpad.net/ListHelp
> > 
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > 
> > More help   : https://help.launchpad.net/ListHelp
> > 
> >
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > 
> > Unsubscribe : 

Re: [Kicad-developers] eeschema regression

[Wayne Stambaugh]

I was working a new board and I'm seeing this now too.  I didn't make
any changes to this code so who ever broke it, please fix it.  You
shouldn't need to reload the entire library table every time you add a
symbol.  The library caches should only get reloaded the first time they
are opened, a change occurs to the library file since the last time they
were opened (this is automatic and doesn't require you do anything), or
changes are made to the library table.

On 12/17/2017 2:19 PM, Nick Østergaard wrote:
> I am not sure why, but I see the progress dialog opened for an equal
> amount of time every time in my case. Testing on windows 10.
> 
> The path Seth proposed seem to work sort of. But it does not show the
> loading dialog on init and I get an error dialog shortly after I open
> eeschema that it fails to load a dcm file. This error does not occur
> without Seths patch.
> 
> But on subsequent additions of a symbol the dialog is not shown and with
> no delay as expected.
> 
> 2017-12-16 23:52 GMT+01:00 Oliver Walters
> >:
> 
> Wayne,
> 
> I believe you are correct, they are cached and the progress dialog
> is the actual source of the perceived delay. If this dialog is only
> shown on first library load that would be sufficient.
> 
> On Sun, Dec 17, 2017 at 12:40 AM, Wayne Stambaugh
> > wrote:
> 
> Are you sure the libraries are actually being reloaded?  The
> behavior I
> observe is the first time I open the symbol chooser, the
> progress dialog
> is open for a significant amount of time while the libraries are
> being
> loaded.  On all subsequent openings of the symbol chooser, the
> progress
> dialog is dismissed very quickly indicating that the libraries have
> already been cached.  I agree that the progress dialog being
> displayed
> every time the symbol chooser is opened is annoying.  I probably
> merged
> this patch too quickly.  After the initial loading of all of the
> symbol
> libraries, the progress dialog doesn't need to be shown.
> 
> On 12/15/2017 09:10 PM, Oliver Walters wrote:
> > I think that there has been a functional regression in a
> recent build,
> > relating to placing symbols in eeschema.
> >
> > Previously, the libraries were loaded once when the schematic
> was opened.
> >
> > now, the entire symbol library set is re-loaded every time you
> select
> > "Place Symbol". This brings up the "loading symbol libraries"
> progress
> > dialog before opening the component selector window.
> >
> > This is very tedious - especially on Windows where loading
> symbols can
> > be an order of magnitude slower than linux. It really
> interrupts work flow.
> >
> > I do not imagine this is intended behaviour? Can anyone
> comment on this?
> >
> > Oliver
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> 
> > Post to     : kicad-developers@lists.launchpad.net
> 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> 
> > More help   : https://help.launchpad.net/ListHelp
> 
> >
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : 

Re: [Kicad-developers] EESchema: regression in object moving?

[Jeff Young]

Odd… 

After rolling back all the way past 4.0.7 and still getting buggy behaviour in 
my development build, I gave up.  

However, coming back forward produced odd build errors and the like.  So I 
re-applied the wxWidgets OSX patches, rebuilt wxWidgets, re-ran kicad’s CMake, 
and did a full build.  Not only does it now build cleanly, but the bug is gone 
as well….

Cheers,
Jeff.

> On 17 Dec 2017, at 22:00, Jeff Young  wrote:
> 
> Has anyone noticed that dragging an object in EESchema doesn’t erase the old 
> images (it just smears the canvas each time its redrawn during the drag 
> operation)?


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eeschema regression

[Nick Østergaard]

I am not sure why, but I see the progress dialog opened for an equal amount
of time every time in my case. Testing on windows 10.

The path Seth proposed seem to work sort of. But it does not show the
loading dialog on init and I get an error dialog shortly after I open
eeschema that it fails to load a dcm file. This error does not occur
without Seths patch.

But on subsequent additions of a symbol the dialog is not shown and with no
delay as expected.

2017-12-16 23:52 GMT+01:00 Oliver Walters :

> Wayne,
>
> I believe you are correct, they are cached and the progress dialog is the
> actual source of the perceived delay. If this dialog is only shown on first
> library load that would be sufficient.
>
> On Sun, Dec 17, 2017 at 12:40 AM, Wayne Stambaugh 
> wrote:
>
>> Are you sure the libraries are actually being reloaded?  The behavior I
>> observe is the first time I open the symbol chooser, the progress dialog
>> is open for a significant amount of time while the libraries are being
>> loaded.  On all subsequent openings of the symbol chooser, the progress
>> dialog is dismissed very quickly indicating that the libraries have
>> already been cached.  I agree that the progress dialog being displayed
>> every time the symbol chooser is opened is annoying.  I probably merged
>> this patch too quickly.  After the initial loading of all of the symbol
>> libraries, the progress dialog doesn't need to be shown.
>>
>> On 12/15/2017 09:10 PM, Oliver Walters wrote:
>> > I think that there has been a functional regression in a recent build,
>> > relating to placing symbols in eeschema.
>> >
>> > Previously, the libraries were loaded once when the schematic was
>> opened.
>> >
>> > now, the entire symbol library set is re-loaded every time you select
>> > "Place Symbol". This brings up the "loading symbol libraries" progress
>> > dialog before opening the component selector window.
>> >
>> > This is very tedious - especially on Windows where loading symbols can
>> > be an order of magnitude slower than linux. It really interrupts work
>> flow.
>> >
>> > I do not imagine this is intended behaviour? Can anyone comment on this?
>> >
>> > Oliver
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eeschema regression

[Oliver Walters]

Wayne,

I believe you are correct, they are cached and the progress dialog is the
actual source of the perceived delay. If this dialog is only shown on first
library load that would be sufficient.

On Sun, Dec 17, 2017 at 12:40 AM, Wayne Stambaugh 
wrote:

> Are you sure the libraries are actually being reloaded?  The behavior I
> observe is the first time I open the symbol chooser, the progress dialog
> is open for a significant amount of time while the libraries are being
> loaded.  On all subsequent openings of the symbol chooser, the progress
> dialog is dismissed very quickly indicating that the libraries have
> already been cached.  I agree that the progress dialog being displayed
> every time the symbol chooser is opened is annoying.  I probably merged
> this patch too quickly.  After the initial loading of all of the symbol
> libraries, the progress dialog doesn't need to be shown.
>
> On 12/15/2017 09:10 PM, Oliver Walters wrote:
> > I think that there has been a functional regression in a recent build,
> > relating to placing symbols in eeschema.
> >
> > Previously, the libraries were loaded once when the schematic was opened.
> >
> > now, the entire symbol library set is re-loaded every time you select
> > "Place Symbol". This brings up the "loading symbol libraries" progress
> > dialog before opening the component selector window.
> >
> > This is very tedious - especially on Windows where loading symbols can
> > be an order of magnitude slower than linux. It really interrupts work
> flow.
> >
> > I do not imagine this is intended behaviour? Can anyone comment on this?
> >
> > Oliver
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eeschema regression

[Wayne Stambaugh]

Are you sure the libraries are actually being reloaded?  The behavior I
observe is the first time I open the symbol chooser, the progress dialog
is open for a significant amount of time while the libraries are being
loaded.  On all subsequent openings of the symbol chooser, the progress
dialog is dismissed very quickly indicating that the libraries have
already been cached.  I agree that the progress dialog being displayed
every time the symbol chooser is opened is annoying.  I probably merged
this patch too quickly.  After the initial loading of all of the symbol
libraries, the progress dialog doesn't need to be shown.

On 12/15/2017 09:10 PM, Oliver Walters wrote:
> I think that there has been a functional regression in a recent build,
> relating to placing symbols in eeschema.
> 
> Previously, the libraries were loaded once when the schematic was opened.
> 
> now, the entire symbol library set is re-loaded every time you select
> "Place Symbol". This brings up the "loading symbol libraries" progress
> dialog before opening the component selector window.
> 
> This is very tedious - especially on Windows where loading symbols can
> be an order of magnitude slower than linux. It really interrupts work flow.
> 
> I do not imagine this is intended behaviour? Can anyone comment on this?
> 
> Oliver
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eeschema regression

[Wayne Stambaugh]

Seth,

This probably belongs in the PROJECT object in common/project.cpp.  This
is where most shared project level code resides and is where the symbol
library table pointer is stored.

Wayne

On 12/15/2017 10:30 PM, Seth Hillbrand wrote:
> Hi Oliver-
> 
> I've had similar issues.  If you can, would you mind testing the
> attached patch on Windows?  It offloads the library processing to a
> thread that runs when the schematic loads or the library table changes.
> 
> It isn't ready for merge consideration yet because I'm not convinced
> that the BASE_FRAME is the correct place for it, nor am I completely
> happy with the process for figuring out when an update is needed.  But
> the bones are in place and I haven't found any bugs yet in Linux or Mac,
> so please let me know if it has any adverse effects in Windows.
> 
> Best-
> Seth
> 
> On Fri, Dec 15, 2017 at 6:10 PM, Oliver Walters
> >
> wrote:
> 
> I think that there has been a functional regression in a recent
> build, relating to placing symbols in eeschema.
> 
> Previously, the libraries were loaded once when the schematic was
> opened.
> 
> now, the entire symbol library set is re-loaded every time you
> select "Place Symbol". This brings up the "loading symbol libraries"
> progress dialog before opening the component selector window.
> 
> This is very tedious - especially on Windows where loading symbols
> can be an order of magnitude slower than linux. It really interrupts
> work flow.
> 
> I do not imagine this is intended behaviour? Can anyone comment on this?
> 
> Oliver
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> 
> Post to     : kicad-developers@lists.launchpad.net
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> 
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eeschema regression

[Seth Hillbrand]

Hi Oliver-

I've had similar issues.  If you can, would you mind testing the attached
patch on Windows?  It offloads the library processing to a thread that runs
when the schematic loads or the library table changes.

It isn't ready for merge consideration yet because I'm not convinced that
the BASE_FRAME is the correct place for it, nor am I completely happy with
the process for figuring out when an update is needed.  But the bones are
in place and I haven't found any bugs yet in Linux or Mac, so please let me
know if it has any adverse effects in Windows.

Best-
Seth

On Fri, Dec 15, 2017 at 6:10 PM, Oliver Walters <
oliver.henry.walt...@gmail.com> wrote:

> I think that there has been a functional regression in a recent build,
> relating to placing symbols in eeschema.
>
> Previously, the libraries were loaded once when the schematic was opened.
>
> now, the entire symbol library set is re-loaded every time you select
> "Place Symbol". This brings up the "loading symbol libraries" progress
> dialog before opening the component selector window.
>
> This is very tedious - especially on Windows where loading symbols can be
> an order of magnitude slower than linux. It really interrupts work flow.
>
> I do not imagine this is intended behaviour? Can anyone comment on this?
>
> Oliver
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>


0001-Eeschema-Asynchronous-library-loading.patch
Description: Binary data
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp