[kmymoney] [Bug 390979] securities have changed into currency

2018-02-24 Thread David Nelson
https://bugs.kde.org/show_bug.cgi?id=390979

--- Comment #3 from David Nelson  ---
this looks good now.
thanks for the speedy fix!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390979] securities have changed into currency

2018-02-24 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=390979

Thomas Baumgart  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kmy
   ||money/6e2321172a285f686e7d7
   ||95577fce23702bfc672
 Resolution|--- |FIXED

--- Comment #2 from Thomas Baumgart  ---
Git commit 6e2321172a285f686e7d795577fce23702bfc672 by Thomas Baumgart.
Committed on 24/02/2018 at 16:58.
Pushed by tbaumgart into branch 'master'.

Fix security retrieval from engine

The call to MyMoneyFile::currency() not only returns currencies but also
securities. This was broken due to a recent change.

M  +13   -4kmymoney/mymoney/mymoneyfile.cpp

https://commits.kde.org/kmymoney/6e2321172a285f686e7d795577fce23702bfc672

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 390979] securities have changed into currency

2018-02-24 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=390979

Thomas Baumgart  changed:

   What|Removed |Added

   Priority|NOR |HI
   Severity|normal  |grave
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Thomas Baumgart  ---
This seems to be the requested follow-up to #390044. I keep the reference here,
as it contains a specific commit (5.0.80-7150b4a5) that might be related to the
problem.

In fact, this might be a problem on current git master which changes your data
(I have seen the same here in my data and cannot experience the problem in the
5.0 branch).

So it is very likely that master is currently broken in the investment storage
area. Here's what I have done. I opened a file written with 5.0 (where
investments are shown correctly) in master and I see, that the file is modified
without me doing anything. Saving the file and comparing it shows the following
effect (besides others which are not causing trouble):

in the file written by 5.0 I see:



and the same record in the file written by master shows as



The order of the attributes is not a problem, but the modification of the
currency attribute is causing the trouble and explains what the OP sees.

The file contents must be fixed manually (reverting the currency assignment)
and master is currently broken for that. I adjusted the importance of this
entry accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.