[Koha-bugs] [Bug 7350] In New order the + button duplicates input text but not the selected in ddl

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350

--- Comment #4 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2012-01-15 13:49:05 UTC ---
Hello M. de Rooy,
sorry...
So I join you two snapshots.
Koha is moving so kickly, no more + but now we have Add...
So step by step :
1° You create a basket in acqui or you use an active one, no matter.
2° After you choose Add Order To Basket, new, from..., no matter.
3° You fill in Item block, all the Drop Down Lists, don't choose the first
value.
4° You want a second item, so you clone it with Add, and as you are lazy, you
expect that all your choices will be kept... :o( Only the imput text are kept.
Regards

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7350] In New order the + button duplicates input text but not the selected in ddl

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350

--- Comment #5 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2012-01-15 13:51:31 UTC ---
Created attachment 7160
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7160
to clone

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7350] In New order the + button duplicates input text but not the selected in ddl

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350

--- Comment #6 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2012-01-15 13:53:30 UTC ---
Created attachment 7161
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7161
ddl are not duplicated

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7350] In New order the + button duplicates input text but not the selected in ddl

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7350

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

   Attachment #7160|0   |1
is obsolete||

--- Comment #7 from Christophe Croullebois 
christophe.croulleb...@biblibre.com 2012-01-15 13:54:44 UTC ---
Created attachment 7162
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7162
to clone

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7446] New: Redundant display of availablecount in staff client (results.tt)

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7446

 Bug #: 7446
   Summary: Redundant display of availablecount in staff client
(results.tt)
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Platform: All
OS/Version: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Staff Client
AssignedTo: paul.poul...@biblibre.com
ReportedBy: r...@bywatersolutions.com
 QAContact: ian.wa...@bywatersolutions.com
CC: gmcha...@gmail.com


In the search results, the staff client is showing (for example)

strong3 items, 3 available:/strong
3 available:

...followed by a ul showing which branches have items, along with calls and
counts.  The second available count is redundant, and it refers to the same
variable as in the line above.  

Patch coming momentarily to remove this redundancy.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7446] Redundant display of availablecount in staff client (results.tt)

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7446

D Ruth Bavousett r...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|paul.poul...@biblibre.com   |r...@bywatersolutions.com

--- Comment #1 from D Ruth Bavousett r...@bywatersolutions.com 2012-01-15 
15:55:09 UTC ---
Created attachment 7163
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7163
Proposed patch

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7446] Redundant display of availablecount in staff client (results.tt)

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7446

D Ruth Bavousett r...@bywatersolutions.com changed:

   What|Removed |Added

   Priority|P5 - low|PATCH-Sent

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7175] Improve order receiving page

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7175

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
18:16:30 UTC ---
Some notes:

1) The change only changes the behaviour for AcqCreateItem = on order. The
other settings still work as before. So all ok.

2) The main difference between this implementation and the implementation of
bug 3966 is the presentation of the item information on the order receive
screen. 3966 uses the standard item form and pulls in all ordered items. If you
order a lot of items, the form can get pretty big and hard to work with. 
This implementation uses a separate table with items, edit links and
checkboxes. The editing of items from this screen works very nicely and saving
the form redirects correctly to the receive screen. 
I like the way it's done here.

Fields displayed in the table are:
Barcode Home branch Location Call number 

Some notes about the table:

a) Home branch and location display the codes instead of the descriptions.
I would like to see the description displayed here.

b) Collection is never displayed, even if it's set for one of the items. 
It would be nice to make this configurable or display location/collection and
some other fields if they are set for one of the items.

3) Workflow change: You now have to use the checkboxes to select how many items
you want to receive instead of entering the number in the field. The field is
blocked and the number can not be entered there directly. 
Checking and unchecking the checkboxes to select the items works nicely.
Is it a problem that the quantity can not be entered directly?
Suggestion: Make it possible to edit the number manually and check/uncheck
items from top to bottom accordingly.

4) It's no longer possible to receive more items than have been ordered. This
was possible before the change, but I am not sure it's a good feature. If you
receive more items than have been ordered no item records are created. You have
to create them in cataloguing and by doing so the items will not be linked to
the order.
Suggestion: Add a link to add a new item, redirect like the edit links do and
increase the item number on the order accordingly.

I am a bit worried about 4) although I am not sure if this feature is used by
many(?) libraries.

I am signing off on the first patch and I think a second opinion for the
workflow changes described in 3) and 4) would be good.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7175] Improve order receiving page

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7175

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
18:28:59 UTC ---
I checked the logs before signing off the first patch and there are a lot of
warnings for finishreceive.pl:

[Sun Jan 15 19:23:47 2012] [error] [client 127.0.0.1] [Sun Jan 15 19:23:47
2012] finishreceive.pl: Use of uninitialized value in pattern match (m//) at
/home/katrin/kohaclone/C4/SQLHelper.pm line 361., referer:
http://localhost:8080/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=14invoice=Order%20123gst=0supplierid=2
[Sun Jan 15 19:23:47 2012] [error] [client 127.0.0.1] [Sun Jan 15 19:23:47
2012] finishreceive.pl: Use of uninitialized value in pattern match (m//) at
/home/katrin/kohaclone/C4/SQLHelper.pm line 361., referer:
http://localhost:8080/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=14invoice=Order%20123gst=0supplierid=2
[Sun Jan 15 19:23:47 2012] [error] [client 127.0.0.1] [Sun Jan 15 19:23:47
2012] finishreceive.pl: Use of uninitialized value in pattern match (m//) at
/home/katrin/kohaclone/C4/SQLHelper.pm line 361., referer:
http://localhost:8080/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=14invoice=Order%20123gst=0supplierid=2
[Sun Jan 15 19:23:47 2012] [error] [client 127.0.0.1] [Sun Jan 15 19:23:47
2012] finishreceive.pl: Use of uninitialized value in pattern match (m//) at
/home/katrin/kohaclone/C4/SQLHelper.pm line 361., referer:
http://localhost:8080/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=14invoice=Order%20123gst=0supplierid=2
[Sun Jan 15 19:23:47 2012] [error] [client 127.0.0.1] [Sun Jan 15 19:23:47
2012] finishreceive.pl: Use of uninitialized value $error_url_str in
concatenation (.) or string at /home/katrin/kohaclone/acqui/finishreceive.pl
line 117., referer:
http://localhost:8080/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=14invoice=Order%20123gst=0supplierid=2

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7175] Improve order receiving page

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7175

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #7139|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
18:30:46 UTC ---
Created attachment 7164
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7164
[SIGNED-OFF] Bug 7175: orderreceive.pl cosmetic changes

- use warnings
- replace @$results[0] by $order when $count == 1

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Checked the logs for warnings.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7243] Do not take rentals as fines

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
18:45:30 UTC ---
Hi Srdjan, 
thx a lot for taking my comments into account. 

Reading through this again I wonder if a better solution would be to make the
fine types that can block checkouts a list? We have some system preferences now
that take | or comma separated lists of values. It would allow for more
flexibility and it would work with 1 additional system preference instead of 2.

I am really not sure here and perhaps your solution is what others think is the
best way to do it. Some more opinions about this would be good.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4438] incorrect Budget total exceeds period allocation error when editing fund

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4438

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
19:02:46 UTC ---
Hi Fred,
can you give me a test plan to reproduce the problem?
I checked the lines you mention on current master and they seem unchanged. But
I am not sure the problem is still there. 

  99 if ( $parent_id) {
 100 if ( ($total  $sub_unalloc )  $sub_unalloc )  {
 101 $returncode = 1;
 102 }
 103 } elsif ( ( $total  $budget_period_unalloc )  $budget_period_unalloc )
{
 104 $returncode = 2;
 105 
 106 } else {
 107 $returncode = 0;
 108 }

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
19:30:57 UTC ---
I fixed the conflicts in systempreferences.sql and updatedatabase.pl and
checked the code.

The patch uses subfield codes instead of the Koha to MARC mappings:

+sub removeFieldsForPrefill {
+#FIXME: this is not generic enough. We could define fields to remove in a
syspref.
+my $item = shift;
+# Getting item tag
+my ($tag, $subtag) = GetMarcFromKohaField(items.barcode, '');
+if ($tag) {
+my $field = $item-field($tag);
+if ($field) {
+$field-delete_subfield(code = 'f');
+$field-delete_subfield(code = 'k');
+$field-delete_subfield(code = 'u');
+$field-delete_subfield(code = 'v');
+$field-delete_subfield(code = 'x');
+$field-delete_subfield(code = 'z');
+}
+}
+return $item;
+
+}

I checked and the item subfields between UNIMARC and MARC21 are quite
different. Also it should be documented which fields are pre-filled and which
not.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
20:06:29 UTC ---
Follow up does not apply:

[~/kohaclone (6030_htmloverdues)⚡] git am -iu3
/tmp/proposed-patch-follow-up-jH3H5e.patch
Commit Body is:
--
Bug 6030 follow-up

Fixing problem detected previously:
* add column_def retrieval, to have header displaying the explained row name,
not the table name. (the name is not expanded for CSV exports)
* removed some warnings.
* fixed some problems with csvfilename being defined/empty. Now, csvfilename is
always defined, and set to '' by default. Some tests have been updated
accordingly
* added the charset=UTF8 on mail headers.

This patch also adds some missing columns to columns.def
--
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Bug 6030 follow-up
fatal: sha1 information is lacking or useless
(misc/cronjobs/overdue_notices.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 6030 follow-up
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
20:07:25 UTC ---
Paul, can you clear up the relationship to bug 5878? - Can this bug be closed
as features will be implemented incrementally by other bugs/patches?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #7116|0   |1
is obsolete||

--- Comment #37 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
22:05:44 UTC ---
Created attachment 7165
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7165
[SIGNED-OFF] Bug 5668 - Star ratings in the opac

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
1) All test complete successfully.
perl  t/db_dependent/Ratings.t

2) Display works according to system preference settings
OpacStarRatings = only details
OpacStarRatings = no
OpacStarRatings = results and details
All settings work.

3) Add/change/delete ratings
Adding, changing and deleting ratings works.
Only logged in users can rate books.
Rating works only on OPAC detail pages.

Problems found:
1) New system preference is not added to sysprefs.sql

2) It seems there is some javascript code in opac-ragings-ajax.pl:
+  window.alert('Your CGI session cookie ($sessid) is not current.  
+  . Please refresh the page and try again.');\n;
I was wondering if this should be in the pl file, it's also not translatable.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5668] Star ratings in the opac

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

--- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 
22:05:54 UTC ---
Created attachment 7166
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7166
Bug 5668: Follow up - Star ratings

- adds new system preference OpacStarRatings to sysprefs.sql file
  - changes NULL NULL to 'yes|no|details','Choice'
- changes updatedatabase.pl
  - removes mysqlisms from the table definition
  - changes INSERT to make it more robust and match sysprefs.sql

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7243] Do not take rentals as fines

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243

--- Comment #6 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-15 
23:42:15 UTC ---
I have no personal preferences in terms how we store sysprefs. Two sysprefs
were suggested, and I went with that. I'm still kind of learning how community
operates. Having one syspref with comma or | delimited values (as I saw it
elsewhere) makes sense, but some people may find it confusing. From my point of
view it is trivial how we store it, so if you think it's better to have one
syspref I can change it.
One syspref has following advantages:
* it scales better, ie if a new charge code needs to be added
* MAN_INV charges can be fine grained
Disadvantage is that is maybe harder to understand/use.

Your call.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7277] keyword mapping needs spaces in the OPAC

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7277

Garry Collum gcol...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|oleon...@myacpl.org |gcol...@gmail.com

--- Comment #3 from Garry Collum gcol...@gmail.com 2012-01-16 00:23:56 UTC ---
Created attachment 7167
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7167
Proposed patch

Proposed patch.  For testing purposes XSLTResultsDisplay in both Staff client
preferences and Opac preferences must be set to 'normally.'

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7446] Redundant display of availablecount in staff client (results.tt)

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7446

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz 2012-01-16 
04:03:16 UTC ---
(Gotta remember to set the status now Ruth, now its been change to that, rather
than the old patch status)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6943] Create new budget from a copy of a previous budget

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Attachment #7043|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-16 
06:49:33 UTC ---
Created attachment 7168
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7168
[SIGNED-OFF] Bug 6943: Added ability to duplicate a budget tree (from the edit
sub menu) bug 6953

http://bugs.koha-community.org/show_bug.cgi?id=6943

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
- all new javascript alerts have translations markers _()
- hierarchies and permissions were copied correctly

Possible enhancements:
- make it possible to move orders from old to new funds
- make it possible to change description while copying, saving 1 additional
step

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6943] Create new budget from a copy of a previous budget

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-16 
06:54:03 UTC ---
I looked at Maxime's patch too. 
It still applies but /cgi-bin/koha/admin/aqbudgetperiods.pl gives me a 404.
[Mon Jan 16 07:51:05 2012] [error] [client 127.0.0.1] script not found or
unable to stat: /home/katrin/kohaclone/admin/aqbudgetperiods.pl, referer:
http://localhost:8080/cgi-bin/koha/acqui/acqui-home.pl

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7001] User Configurable Slips

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

   Attachment #7129|0   |1
is obsolete||

--- Comment #39 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-16 
07:01:46 UTC ---
Created attachment 7169
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7169
patch

Apologies, missed that one. Should be fine now.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4300] Display 866z summary holdings public note in OPAC

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4300

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||katrin.fisc...@bsz-bw.de
 Resolution|FIXED   |

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-16 
07:13:55 UTC ---
Only subfield 866$z is displayed, but ; is added for each 866 field. 
This does only work correctly, when each 866 has a public note in $z.

Example:
866 $a1-86 (1941-1987)$xbound in 2 v. per year$zSome issues missing
866 $a1-86 (1941-1987)

Shows up as:
Holdings Note: Some issues missing; .

866 - Textual Holdings-Basic Bibliographic Unit (R)
$a - Textual holdings (NR)
$x - Nonpublic note (R)
$z - Public note (R)

Holdings note is also only shown in OPAC, not in staff.

!-- 866 holdings public note --
xsl:if test=marc:datafield[@tag=866]
span class=results_summary holdings_notespan class=labelHoldings Note:
/span
xsl:for-each select=marc:datafield[@tag=866]
xsl:value-of select=marc:subfield[@code='z']/
xsl:choosexsl:when
test=position()=last()xsl:text./xsl:text/xsl:whenxsl:otherwisexsl:text;
/xsl:text/xsl:otherwise/xsl:choose
/xsl:for-each
/span
/xsl:if

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4300] Display 866z summary holdings public note in OPAC

2012-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4300

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-16 
07:16:07 UTC ---
Also only first $z of each 866 will be displayed, but subfield is repeatable.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/