[Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675 --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #4) Are you sure a file like this should go in xt? xt/ is generally for tests, I think. You are probably right ;) Found a better place for the other two scripts in xt as well. My next candidate is: misc/bin ! Sounds much better, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675 --- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 8173 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8173action=edit Patch for moving the other two xt scripts Just moving two files and eliminating two trailings spaces.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #8089|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #6364|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #6365|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #16 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 8174 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8174action=edit Moving license scripts to misc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 8175 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8175action=edit Moving license scripts to misc Second try -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #19 from Chris Cormack ch...@bigballofwax.co.nz --- Hmmm these scripts should stay in xt/ They are tests that should be run before release, by developers, not scripts that should be run by Koha users. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #20 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 8177 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8177action=edit Followup on find-license-problems.pl Adds current directory as default argument. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #19) Hmmm these scripts should stay in xt/ They are tests that should be run before release, by developers, not scripts that should be run by Koha users. xt is not completely clear to me? see also 7675 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl --- xt/perltidyrc ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #23 from Chris Cormack ch...@bigballofwax.co.nz --- xt/ is tests, tests for things like template validity, missing copyrights. Not unit tests, they live in t/ t/ tests functionality xt/ tests things like translatablity, missing copyrights. It should contain things meant to be run by the installer (like you selinux paths things in bug 7675) but should definitely contain scripts to check fsf addresses xt/ is designed to contain best practice release only tests, so yes things like perltidy etc should live there. Things that don't effect functionality, but test style. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #8176|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #8177|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4330] Copyright statements out of date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl --- OK Thanks. Obsoleting two attachments.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- See 4330 comments too. Obsoleting the new attachments, getting back the old one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #8173|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6743] displayFacetCount not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6743 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 Status|Pushed to Master|RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |FIXED --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Works in 3.6.3. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5917] Switch Koha to use Template::Toolkit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5917 Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #8089|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7178] Improve order item creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178 --- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl --- Julian: That error was also at the first time. Did tests with both yui choices but with same result. Only two document.getElementById() is null-errors remain. See further comment 20. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #7 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #4) I propose to expand this functionality to the formatting of currency values as well. Marc, when you say that you propose does it mean that you'll submit a patch ? Or you propose to go this way (and I agree), and hope someone else will write a patch. Aleksa = we have no feedback from you ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz --- Aleksa was a high school student doing some work on the school holidays. He may time and/or the desire to work on this again. But to expect him to leap in and make a template::toolkit plugin is a pretty big ask for a high school kid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #53 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #52) Paul, the dragClass class in css file was not in my original patch. You can remove this declaration. If table in admin/updatedatabase is different from others datatables, it is probably owed to modification of bug 6836. coud you take care of the follow-up ? (I can't find time for it myself...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7587] Wrong table name for local cover images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7587 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from Ian Walls koha.sek...@gmail.com --- Deletes an unusable table and creates a usable replacement in it's place. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7602] Spent and Ordered pages require full acquisition permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Ian Walls koha.sek...@gmail.com --- First patch: simple change to permissions. Passed QA Second patch: adds conditional to template to links only show if they're relevant to the user. Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added QA Contact|koha.sek...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7698] Add ICU option to Koha out of the box
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7698 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #2 from Ian Walls koha.sek...@gmail.com --- Adds the ZEBRA_TOKENIZER option to the Makefile, and properly passes it about on make. New ICU chain XML file is the standard most of us have been using for the last few years, only with a blank locale attribute in the root element (better for l10n than any default value). Glad to have this as an official option now. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3216] UNIMARC author facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3216 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #16 from Ian Walls koha.sek...@gmail.com --- Makes faceting code much, much more flexible. Subfields from one field can now be mixed with different subfields from another (previously impossible). This allows, for example, a unified Item Type facet that pulls from both 942$c and 952$y. Marking, very happily, as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3216] UNIMARC author facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3216 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P2 QA Contact||koha.sek...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5341] Serial issues improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5341 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||koha.sek...@gmail.com --- Comment #3 from Ian Walls koha.sek...@gmail.com --- Template only change, moving code from bottom of page to top. Marking as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7420] Add max fines to circulation matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #16 from Ian Walls koha.sek...@gmail.com --- First patch renames 'MaxFine' to 'MAXFINE' in sysprefs.sql, which will cause breakage for new installations. The usage of 900 as an 'arbitrary value' for determining whether or not to port over the values from sysprefs to circ matrix is... unclear. Marking Failed QA. I'm concerned about this patch changing too much out from under the library. The meaning of MaxFine will change, and while this will port over *most* values of MaxFine into the circ matrix, this may still cause some confusion for folks who always thought that MaxFine was the total maximum for fines. Don't get me wrong, I'm behind separating this logic so folks can have both an item-specific max and a global max, but we need to make it VERY CLEAR on upgrade that this has changed. Perhaps that's more the job of the documenters and trainers than the coders, but I wanted to raise the point. I'm in favour making updatedatabase patches easier to merge, but I think the XXX markers are not the right way to go about it. What about just adding more whitespace between DB update lines? If that distance is greater than 3, Git won't grumble about a conflict, and so long as the spacing is less than 3 between the last DB update and the DropAllForeignKeys call, then the new update will be properly placed even if other updates have slipped in after it. An aside: this patch touches two very shaky areas of the codebase, Accounts and Circ Rules. These areas are already very prone to bugs, and need to be re-examined and probably rewritten. However, I don't think it's practical for me hold this up waiting on these large fixes. Get the MAXFINE issue solved, and make some attempt at forcing users to notice the change in behaviour, and we'll get a Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 delaye stephane.del...@biblibre.com changed: What|Removed |Added CC||stephane.del...@biblibre.co ||m --- Comment #7 from delaye stephane.del...@biblibre.com --- i apply the patch : when i delete a order since recept sceen i have a message (confirmation) but i can't add a reason for cancellation and the order is deleted not cancelled so i don't understand the funtions of this patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4048] CSS and JS libs must be outside of translated paths
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |In Discussion CC||koha.sek...@gmail.com --- Comment #6 from Ian Walls koha.sek...@gmail.com --- This patch, since it adds files copied outside git, breaks our git blame for all the intranet CSS and JS. Alternatives: git mv all the files as necessary, then add symlinks for the old directories Moving to In Discussion while we work out what approach will be the best for this fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #9 from Marc Véron ve...@veron.ch --- Paul, If everybody agrees with my proposition I can try to submit a patch within the next weeks. However I would like to try first with some smaller issue, just to find out how to patch. Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||jcam...@cpbibliography.com --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch is for Koha 3.2 which is no longer maintained by the community. Also, reports are often written which include links (using a href=... concatenated into the results). This patch would break those links. Marking failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 8179 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8179action=edit Typo in cart_to_shelf Changing usage print statement only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6440] Koha's OAI-PMH does not support sets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6440 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added CC||koha.sek...@gmail.com --- Comment #21 from Ian Walls koha.sek...@gmail.com --- So, what this patch does is, essentially, allow us to create and maintain automated groups of biblios. Structurally, this is much like Lists, only instead of being associated with a person and added to manually, it's associated with some kind of attribution in the MARC, and new materials are added automated as they're catalogued. This seems to have much wider applications than just OAI... I'd advocate looking at a generalized naming scheme, and making OAI just one exemplar of usage. Not a QA comment, just one of my own personal preference. QAing will come shortly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4048] CSS and JS libs must be outside of translated paths
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048 --- Comment #7 from Owen Leonard oleon...@myacpl.org --- Good point about the git blame. Since the goal is to eventually git rid of the CSS and JS inside the language directories perhaps it's enough to git mv the files and then copy them back to the old location? The files in the proper place would have correct info and the others would be only temporary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- with koha-conf.xml being memcached now, I think this is no more interesting. Plus the patch does not work, it would need much more work to be managed during install. So marking RESO WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7661] Moving C4::tests to unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7661 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #6 from Paul Poulain paul.poul...@biblibre.com --- mmm... isn't the 31.36KB patch (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8055) really obsoleted ? I think it's a mistake, could you confirm ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7661] Moving C4::tests to unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7661 --- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #6) mmm... isn't the 31.36KB patch (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8055) really obsoleted ? I think it's a mistake, could you confirm ? Think it's okay. Obsoleted by signoff. The newer git version creates a smaller patch file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #8035|0 |1 is obsolete|| --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 8180 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8180action=edit Bug 5596 [REVISED] add author to holds to pull report Adding output of author and, for good measure, subtitle. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7703] New: Don't block bulk hold action on search results if some items can't be placed on hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Priority: P5 - low Change sponsored?: --- Bug ID: 7703 CC: gmcha...@gmail.com Assignee: oleon...@myacpl.org Summary: Don't block bulk hold action on search results if some items can't be placed on hold QA Contact: koha.sek...@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: oleon...@myacpl.org Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha In the staff client if you check multiple lines in search results and click the button to place hold you might be blocked from proceeding because One or more selected items cannot be placed on hold. The next stage of the holds process is perfectly capable of warning the user about such problems. The user should not have to search back through the list of items they checked to find which one to un-check. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- I wonder if the holds total should be shown at the top of the holdings list instead of the bottom? It would be hard to spot on a title with lots of items. I also wonder if the holds column in the holdings table should say Holds on this item. That's a long label, but I'm concerned that it is confusing to patrons to see one number for total holds and another number in the table. For instance, 4 holds total, but only one line in the table says Holds: 1 because only one is an item-level hold? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 8181 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8181action=edit Screenshot showing total holds count versus item hold count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6035] Mobile interface for OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6035 David Schuster dschu...@gmail.com changed: What|Removed |Added CC||dschu...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6036] Mobile interface for Intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6036 David Schuster dschu...@gmail.com changed: What|Removed |Added CC||dschu...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 --- Comment #15 from Kyle M Hall kyle.m.h...@gmail.com --- Created attachment 8182 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8182action=edit Bug 7515 - Followup - Only set itemnotes to authorised value if said value exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7741|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Savitra Sirohi savitra.sir...@osslabs.biz changed: What|Removed |Added Status|NEW |ASSIGNED CC||savitra.sir...@osslabs.biz Assignee|kyle.m.h...@gmail.com |savitra.sir...@osslabs.biz --- Comment #1 from Savitra Sirohi savitra.sir...@osslabs.biz --- Draft Design syspref: forgivefinewhenlost Syspref description: Forgive/Don't forgive fines when item status is set to lost Item status can be set to lost from: catalogue/moredetail.pl cataloguing/additem.pl tools/batchMod.pl Design: Change sub C4::Circulation::LostItem to forgive fines on the item depending on the value of syspref forgivefinewhenlost. This sub is currently used to return an item and charge a replacement cost. Currently this sub is not called in additem.pl and therefore an item is not returned/charged when item status is set to lost from here. As part of this change, we will make a call to the LostItem sub from this script as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7609] Improving links to find analytics and volumes when using UseControlnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7609 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: The remaining patch is for opac and staff. Small patch, touching few lines in xslt files. Looks good, works as described. Updating status. Just wondering about a line in the direct context of the change for volumes: The test substring($controlField008,22,1)='m' is only relevant when leader7=s. Now, it is used in general. (New report or a followup?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7638] one page notice for printing per student?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7638 Savitra Sirohi savitra.sir...@osslabs.biz changed: What|Removed |Added Status|NEW |ASSIGNED CC||savitra.sir...@osslabs.biz Assignee|henridam...@koha-fr.org |savitra.sir...@osslabs.biz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7261] System Preference to select the first day of week (Sunday or Monday) to use in the calendar (OPAC and Intranet)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 8183 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8183action=edit Followup to make tests consistent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7261] System Preference to select the first day of week (Sunday or Monday) to use in the calendar (OPAC and Intranet)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- Marking it as Passed QA, while adding a followup to make the two tests in Auth.pm the same. Trivial merge conflict in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #9) Paul, If everybody agrees with my proposition I can try to submit a patch within the next weeks. I don't understand why we need a column in currencies table. There is only one currency displayed, it's the one that has active=1. When you select a different currency when you enter an amount, it's transformed, with the rate, to become a currency that has active=1. So I think the CurrencyFormat should be switched to a formatting display, but we shouldn't need a column. However I would like to try first with some smaller issue, just to find out how to patch. Just in case: Marc, I see you're from switzerland. Do you know that next week, BibLibre organize a hackfest in Marseille (France), there will be mbalmer, from Switzerland too, you're welcomed if you want can join us ( http://drupal.biblibre.com/en/blog/entry/2012-hackfest-in-europe) The hackfest would be the perfect place to write your first patches ! just drop me a mail or catch me on IRC for more information if you want -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7638] one page notice for printing per student?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7638 --- Comment #1 from Savitra Sirohi savitra.sir...@osslabs.biz --- Draft Design: A new tool called Print Patron notices, that can perhaps be extended later to print other kinds of notices. A default template (ACCTLINES_PRINT) will be created as part of this patch. The template will contain a header with borrower and borrower attributes fields and a body containing accountlines fields such as accounttype, amount, date. A mechanism to specify which borrower attribute(s) are to included in the notice will be provided. E.g. borrower_attributes.attribute|GRADE will allow the attribute for code GRADE to be included. Only those acccountlines records that have outstanding amounts 0 will be displayed in the report. The tool will generate a PDF file containing a report per patron, each report will contain text per the notice template. Following filters will be made available during report generation: Branch Patron category Transaction date range The pages in the PDF fike will be of size Letter (8.5*11) by default. This can be extended later to include other paper sizes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7656] undefined pop-up message when putting hold on reference item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #8043|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 8184 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8184action=edit Bug 7656 - undefined pop-up message when putting hold on reference item This is a single line fix. Initializing the msg var to an empty string solves the problem. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7656] undefined pop-up message when putting hold on reference item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3966] receiving items should allow for entering barcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3966 delaye stephane.del...@biblibre.com changed: What|Removed |Added CC||stephane.del...@biblibre.co ||m --- Comment #20 from delaye stephane.del...@biblibre.com --- After apply the patch, I'm confused and I do not know what to test. I understood that the patch allowed you to turn when receiving the opportunity to enter a bar code for each copy when the preference system AcqCreateItem = on order This is a recurring request from many customers: the ability to create copies on the orders while having the opportunity having the opportunity upon receipt to indicate the bar code of each copy received it to avoid to go in the module cataloging -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7434] Display of issue number for serials in overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7434 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Attachment #7138|0 |1 is obsolete|| --- Comment #10 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 8185 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8185action=edit proposed patch #2 with enumchron New patch using enumchron instead of serialseq. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7434] Display of issue number for serials in overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7434 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7294] status in order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #6 from Kyle M Hall kyle.m.h...@gmail.com --- Can we get a testing scenario for this? I create a 951 field with subfields that mapped to the aqorders fields that you listed, and created an on order item, but the marc fields do not seem to have been populated with the data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7294] status in order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, only wondering - were you using the ACQ framework in your tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #8 from delaye stephane.del...@biblibre.com --- when i use the link delete order in the screen parcel.pl i have the erreur 404 and url ../cgi-bin/koha/acqui/cancelorder.pl?ordernumber=13biblionumber=516referrer=/cgi-bin/koha/acqui/parcel.pl%3Fsupplierid=%26datereceived=2012-03-12%26invoice= -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7538] in transit items say available in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7538 --- Comment #2 from Nicole C. Engard neng...@gmail.com --- By the way, it isn't just in-transits that show as availiable. Items waiting for pick-up also say available. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7699] Restricted until datepicker broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7699 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #8159|0 |1 is obsolete|| --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 8186 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8186action=edit [SIGNED-OFF] Bug 7699: Restricted until datepicker broken To test: 1. Edit a patron, and try to use the datepicker to set the date the patron is restricted until. 2. Note that the datepicker does not come up. 3. Apply patch. 4. Repeat step 1. 5. Note that the datepicker does come up. Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7699] Restricted until datepicker broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7699 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 delaye stephane.del...@biblibre.com changed: What|Removed |Added CC||stephane.del...@biblibre.co ||m --- Comment #8 from delaye stephane.del...@biblibre.com --- After apply the patch i test the steps Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA (Set Library link top/right) * check-in the book = it's possible whatever your setup == ok BUt I can save a tranfert B -A and save a use with the item B in branch A... it'sl normal.. I don't understand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7699] Restricted until datepicker broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7699 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from Ian Walls koha.sek...@gmail.com --- Simple change to handle renaming of field. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7577] Suggestion show page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7577 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Attachment #8180|0 |1 is obsolete|| --- Comment #4 from Liz Rea wizzy...@gmail.com --- Created attachment 8187 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8187action=edit Bug 5596 [REVISED] add author to holds to pull report Adding output of author and, for good measure, subtitle. Signed-off-by: Liz Rea wizzy...@gmail.com Passes tests, author and subtitle shown on holds to pull report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||wizzy...@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7031] More options for AdvancedSearchTypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7031
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Passed QA |Failed QA
CC||paul.poul...@biblibre.com
Version|master |rel_3_8
--- Comment #24 from Paul Poulain paul.poul...@biblibre.com ---
QA comment:
After applying the 4 patches, I get:
my variable $total masks earlier declaration in same scope at
catalogue/search.pl line 706.
that was here before the patch
(perl -wc catalogue/search.pl)
so it's OK
staff-global.css says:
+.adsearch {
isn't there a typo here ? shouldn't it be advsearch (add a v), as it's
everywhere else ? I've grepped adsearch, and it appears nowhere except in
staff-global.css, so I think it's a typo.
If you confirm it is, just switch back to passed QA, i'll do the fix push
this (great) feature, as everything seems to work well.
Note : I tested with my UNIMARC setup, and everything worked out of the box,
well done !
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7670] make required fields red in additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com Summary|make required fields red|make required fields red in ||additem.pl --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- QA comment: If you try to save without entering a mandatory field, the highlighting is made light red on dark red, that's quite hard to read. If I compare the result with the addbiblio.pl file, it's not consistent (in addbiblio.pl, an empty mandatory field become yellow, the description is not updated) Could you do improve your patch a little bit more ? (not marking failed QA, if you say no, i'll push it as it is, and yell that you're the one to blame if someone complain :D :D ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7458] New call number allocation plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #28 from Paul Poulain paul.poul...@biblibre.com --- follow-up pushed, still untested by me as it's very specific -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7670] make required fields red in additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7741|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7741|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7700|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall kyle.m.h...@gmail.com --- Created attachment 8188 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8188action=edit Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured Signed-off-by: Kyle M Hall k...@bywatersolutions.com Enable for either A) SingleBranchMode is enabled or B) There is only one branch in the branches table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #8188|0 |1 is obsolete|| --- Comment #13 from Nicole C. Engard neng...@gmail.com --- Created attachment 8189 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8189action=edit [SIGNED-OFF] Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured Signed-off-by: Kyle M Hall k...@bywatersolutions.com Enable for either A) SingleBranchMode is enabled or B) There is only one branch in the branches table Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Tested with one branch and with multiple branches, tested with SingleBranchMode on and off. All tests passed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7294] status in order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #8 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to comment #7) Hm, only wondering - were you using the ACQ framework in your tests? No, I modified and was using the default framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7670] make required fields red in additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #8093|0 |1 is obsolete|| --- Comment #5 from Owen Leonard oleon...@myacpl.org --- Created attachment 8190 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8190action=edit Bug 7670 - make required fields red Adding required style and Required note to additem fields, consistent with the way required fields are displayed on the add patron form. This patch also corrects an error in the client-side validation script which misidentified which fields were required. Leaving a required field empty should result in an alert and the missing field being highlighted in yellow. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a Required note. Submit the form while some required fields are empty. You should see a javascript alert. The empty mandatory fields should have a yellow background. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7670] make required fields red in additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7670] make required fields red in additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Attachment #8190|0 |1 is obsolete|| --- Comment #6 from Liz Rea wizzy...@gmail.com --- Created attachment 8191 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8191action=edit Bug 7670 - make required fields red Adding required style and Required note to additem fields, consistent with the way required fields are displayed on the add patron form. This patch also corrects an error in the client-side validation script which misidentified which fields were required. Leaving a required field empty should result in an alert and the missing field being highlighted in yellow. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a Required note. Submit the form while some required fields are empty. You should see a javascript alert. The empty mandatory fields should have a yellow background. Signed-off-by: Liz Rea wizzy...@gmail.com Works - passes tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7670] make required fields red in additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 David Cook dc...@prosentient.com.au changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #3 from David Cook dc...@prosentient.com.au --- I'm not sure that I understand why/how Koha 3.2 wouldn't be supported by the community (am I not a member of the community?), since the branch is still available via the git. Also, it appears that you are incorrect about the patch breaking the links in the report. If you look at guided_reports_start.tmpl, you'll see that I'm just escaping the HTML characters in the SQL that is displayed above the results. The HTML in the actual results still works perfectly fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- David, Sorry, I misunderstood what it did! It doesn't apply, so I wasn't able to test it. What I meant by is no longer maintained is that no one has stepped forward to act as release maintainer for Koha 3.2, so there will be no further releases in 3.2.x (unless you want to volunteer, which would be awesome!). Regards, Jared -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #3) I'm not sure that I understand why/how Koha 3.2 wouldn't be supported by the community (am I not a member of the community?), since the branch is still available via the git. Not supported, maintained. It's still available on git, but has been end of lifed. There will be no more 3.2.x releases ever. The 2 stable branches are 3.4.x and 3.6.x .. the current stable releases are 3.4.7 and 3.6.4. The last release for 3.2.x was 3.2.11 3 months ago. When 3.8.0 is released in april, the 3.4.x branch will be end of lifed also. We keep 2 stable branches and 1 development branch running. Also, it appears that you are incorrect about the patch breaking the links in the report. If you look at guided_reports_start.tmpl, you'll see that I'm just escaping the HTML characters in the SQL that is displayed above the results. The HTML in the actual results still works perfectly fine. There are no longer any .tmpl files in Koha, since 3.4.0 we switched to template toolkit. This is a major reason this patch will not apply for master. Patches should be written to be applied to master, then cherry-picked by the release maintainer to the appropriate stable branch. If this patch was rewritten to apply to the master (development branch) then it could be backported to 3.4.x and 3.6.x and be in the next releases of those. As well as being in the next feature release 3.8.0. Hope this clears it up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 --- Comment #6 from David Cook dc...@prosentient.com.au --- (In reply to comment #5) (In reply to comment #3) I'm not sure that I understand why/how Koha 3.2 wouldn't be supported by the community (am I not a member of the community?), since the branch is still available via the git. Not supported, maintained. It's still available on git, but has been end of lifed. There will be no more 3.2.x releases ever. The 2 stable branches are 3.4.x and 3.6.x .. the current stable releases are 3.4.7 and 3.6.4. The last release for 3.2.x was 3.2.11 3 months ago. When 3.8.0 is released in april, the 3.4.x branch will be end of lifed also. We keep 2 stable branches and 1 development branch running. Also, it appears that you are incorrect about the patch breaking the links in the report. If you look at guided_reports_start.tmpl, you'll see that I'm just escaping the HTML characters in the SQL that is displayed above the results. The HTML in the actual results still works perfectly fine. There are no longer any .tmpl files in Koha, since 3.4.0 we switched to template toolkit. This is a major reason this patch will not apply for master. Patches should be written to be applied to master, then cherry-picked by the release maintainer to the appropriate stable branch. If this patch was rewritten to apply to the master (development branch) then it could be backported to 3.4.x and 3.6.x and be in the next releases of those. As well as being in the next feature release 3.8.0. Hope this clears it up. Thanks Jared and Chris. That really does clear things up a lot. I've taken a look at the master code, and the fix looks conceptually the same, despite the change in template management. Should I upload a new patch for the master branch on this same bug (after changing the version details)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #6) I've taken a look at the master code, and the fix looks conceptually the same, despite the change in template management. Should I upload a new patch for the master branch on this same bug (after changing the version details)? That would be perfect in TT to filter you would do | html eg [% sql | html %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 David Cook dc...@prosentient.com.au changed: What|Removed |Added Attachment #7976|0 |1 is obsolete|| --- Comment #8 from David Cook dc...@prosentient.com.au --- Created attachment 8192 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8192action=edit Bug 7618 HTML Escaped SQL (master) Here is the the patch for escaping the HTML in the SQL that displays above report results for instances of Koha using the template toolkit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 David Cook dc...@prosentient.com.au changed: What|Removed |Added Status|In Discussion |Needs Signoff Version|rel_3_2 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #8192|0 |1 is obsolete|| --- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 8193 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8193action=edit Bug 7618 Escape HTML special characters for SQL displayed above results in Report module Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
