[Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263

M. de Rooy  changed:

   What|Removed |Added

  Attachment #10355|0   |1
is obsolete||

--- Comment #5 from M. de Rooy  ---
Created attachment 10396
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10396&action=edit
Rebased dbrev for 8263

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

Marc Véron  changed:

   What|Removed |Added

  Attachment #10144|0   |1
is obsolete||

--- Comment #23 from Marc Véron  ---
Created attachment 10395
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10395&action=edit
[REBASED] BUG 7621 [ENH] Circulation: Match age restriction of title with
borrower's age without using categories

Signed-off-by: Chris Cormack 

New version implementing Paul's advice.
See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7993] saved report with hierarchies

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993

--- Comment #1 from Srdjan Jankovic  ---
Created attachment 10394
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10394&action=edit
bug_7993: Save reports with Group/Subgroup hierarchy

This should make saved reports more manageable.
Group/Subgroup hierarchy is stored in authorised_values,
categories REPORT_GROUP and REPORT_SUBGROUP, connected by
REPORT_SUBGROUP.lib_opac -> REPORT_GROUP.authorised_value

Database changes:
* authorised_values: expanded category to 16 chars
* created default set of REPORT_GROUP authorised values to match
  hardcoded report areas
* reports_dictionary: replaced area int with report_area text, converted
  values
* saved_sql: added report_area, report_group and report_subgroup;
  report_area is not currently used, saved for the record

C4/Reports/Guided.pm:
* Replaced Area numeric values with the mnemonic codes
* get_report_areas(): returns hardcoded areas list
* created get_report_areas(): returns full hierarchy (groups with belonging
  subgroups)
* save_report(): changed iterface, accepts fields hashref as input
* update_sql(): changed iterface, accepts id and fields hashref as input
* get_saved_reports():]
- join to authorised_values to pick group and subgroup name
- accept group and subgroup filter params
* get_saved_report():
- changed iterface, return record hashref
- join to authorised_values to pick group and subgroup name
* build_authorised_value_list(): new sub, moved code from
  reports/guided_reports.pl
* Updated interfaces in:
cronjobs/runreport.pl, svc/report, opac/svc/report: get_saved_report()
reports/dictionary.pl: get_report_areas()
reports/guided_reports.pl

reports/guided_reports_start.tt:
* Reports list:
- added group/subgroup filter
- display area/group/subgroup for the reports
* Create report wizard:
- carry area to the end
- select group and subgroup when saving the report; group defaults to area,
  useful when report groups match areas
* Update report and Create from SQL: added group/subgroup
* Amended reports/guided_reports.pl accordingly

Conflicts:

C4/Reports/Guided.pm
admin/authorised_values.pl
installer/data/mysql/kohastructure.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl
misc/cronjobs/runreport.pl
reports/dictionary.pl
reports/guided_reports.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

--- Comment #29 from Srdjan Jankovic  ---
First one is OK as is, other one needs sign-off and then both need qa together
I suppose.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387

--- Comment #8 from Chris Cormack  ---
(In reply to comment #7)
> (In reply to comment #3)
> > QA comment: chris, there is no explanation of the positive effect of this.
> > What would be the next step if this patch is included ? could we do that
> > with all includes ? more explanation welcomed !
> 
> Chris, before pushing this patch, i'd like to understand what will be the
> next step. Should all templates be switched to:
> -[% INCLUDE 'doc-head-open.inc' %]
> +[% USE cache = Cache %]
> +[% cache.inc(
> +'template' => 'doc-head-open.inc',
> +'keys' => {'dochead' => 'dochead'},
> +'ttl' => 360
> +)
> +%]
> 
> ?
> (if that's the case, then I'll add this to my next RM newsletter & send a
> mail to koha-devel about that)
> Do you already have a list of other .inc we could cache too ?

Nope d, in fact caching that one won't win us much at all it's fast to render
anyway. But looking into caching things that require computation, would be
good. This patch is just to enable people to cache includes when they find
ones, or even better create includes and cache them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

--- Comment #28 from Melia Meggs  ---
What is the next step here?  Is the first patch staying as is, or does it
require changes?  Does the patch that stops the perlcritic warnings need to be
signed off now?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #4 from Chris Cormack  ---
This is currently english only.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Chris Cormack  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #3 from Chris Cormack  ---
Created attachment 10393
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10393&action=edit
Bug 5858 - Updating the marc21_framework_DEFAULT.sql to MARC21 version 14

Based on work in the Koha Kobli fork

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8272] OPAC : date expiration format

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7367] General OPAC typo omnibus

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #15 from Chris Cormack  ---
String changes, held for 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|unspecified |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8222] The zip code field is mandatory by default

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #6 from Chris Cormack  ---
No string changes, pushed to 3.8.x will be in 3.8.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8267] Overdue notices not working

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8

--- Comment #6 from Paul Poulain  ---
Patch pushed, update the patch description with comment 2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

--- Comment #12 from Paul Poulain  ---
Path pushed,

I really find the
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=1529 useful, i've
sent a mail to nicole to suggest adding it to the documentation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910

--- Comment #17 from Jared Camins-Esakov  ---
(In reply to comment #16)
> What about doing a follow-up like :
>  * removing blank authority type in an updatedatabase
>  * remove the [% if (unimarc) %]
> would it do the job ?

Unfortunately, it seems like old Koha installations are actually dependent on
the "Default" authority type. I hope to reduce the dependency on the Default
authority type with my work in the authority module, but as of right now, I
don't think we can safely remove it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4255] Add item type to facet list

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||claire.hernandez@biblibre.c
   ||om,
   ||paul.poul...@biblibre.com
Version|master  |rel_3_10

--- Comment #7 from Paul Poulain  ---
Patch pushed, a follow-up for UNIMARC would be usefull, will ask claire

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #27 from Chris Cormack  ---
(In reply to comment #26)
> Further investigation:  the test script tests 'is_holiday', which is what's
> used in fines.pl to determine whether or not to charge the fine.  If the
> tests pass, then is_holiday works as expected (at least for the 4 tested
> dates), and fines.pl shouldn't calculate the fine for today (if today is a
> holiday).
> 
> This should be relatively easy to test:
> 
> 1.  Mark today as a holiday for a branch
> 2.  Find an overdue material that should be accruing fines for this branch
> 3.  Run fines.pl
> 4.  confirm that the fine is NOT added

5. Switch dateformat syspref and try again

Chris

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Chris Cormack  ---
No string changes, no functionality changes, safe to push this close to a
release. Pushed to 3.8.x will be in 3.8.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910

--- Comment #16 from Paul Poulain  ---
(In reply to comment #15)
> (In reply to comment #14)
> > if it works under MARC21, why wouldn't we use the same method for UNIMARC ?
> > How does it work for MARC21 ?
> 
> Actually, the way it works for MARC21 can only be called... uhhh... weird?
> There is actually a blank authority type for MARC21, and since Zebra cannot
> search on blank fields, that is de facto the same as all authority types.
> The way UNIMARC does it is a lot better.

What about doing a follow-up like :
 * removing blank authority type in an updatedatabase
 * remove the [% if (unimarc) %]
would it do the job ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910

--- Comment #15 from Jared Camins-Esakov  ---
(In reply to comment #14)
> if it works under MARC21, why wouldn't we use the same method for UNIMARC ?
> How does it work for MARC21 ?

Actually, the way it works for MARC21 can only be called... uhhh... weird?
There is actually a blank authority type for MARC21, and since Zebra cannot
search on blank fields, that is de facto the same as all authority types. The
way UNIMARC does it is a lot better.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #26 from Ian Walls  ---
Further investigation:  the test script tests 'is_holiday', which is what's
used in fines.pl to determine whether or not to charge the fine.  If the tests
pass, then is_holiday works as expected (at least for the 4 tested dates), and
fines.pl shouldn't calculate the fine for today (if today is a holiday).

This should be relatively easy to test:

1.  Mark today as a holiday for a branch
2.  Find an overdue material that should be accruing fines for this branch
3.  Run fines.pl
4.  confirm that the fine is NOT added

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910

Paul Poulain  changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P3
 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

--- Comment #14 from Paul Poulain  ---
I've pushed the patches because they work as announced but I'd like to
understand why 
> UNIMARC is the only marcflavour that does not already have an option
> for searching all authority types, so check that the marcflavour is
> UNIMARC before displaying the additional "All authority types" option.

if it works under MARC21, why wouldn't we use the same method for UNIMARC ? How
does it work for MARC21 ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6634] manager_id not populated when paying fines

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
   Severity|enhancement |normal

--- Comment #26 from Paul Poulain  ---
New follow-up pushed

(it's not an ENH, chris_c, I think those patches should to ported to 3.8)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Ian Walls  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Ian Walls  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion
 CC||koha.sek...@gmail.com

--- Comment #25 from Ian Walls  ---
The test plan for this patch has drifted from the original problem.  Most
testing seems to be running the new Holidays DB dependent unit test, rather
than testing fines.pl to see if fines are accruing on holidays.

This fix looks good and solid for what it is, but I'm not 100% convinced that
it fixes the actual problem reported.  Please test against fines.pl, and
confirm this patch prevents fines from accruing on closed days.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6774] Display barcode on OPAC detail page

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774

Paul Poulain  changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P3
 Status|Passed QA   |Pushed to Master
Version|rel_3_6 |rel_3_10

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387

--- Comment #7 from Paul Poulain  ---
(In reply to comment #3)
> QA comment: chris, there is no explanation of the positive effect of this.
> What would be the next step if this patch is included ? could we do that
> with all includes ? more explanation welcomed !

Chris, before pushing this patch, i'd like to understand what will be the next
step. Should all templates be switched to:
-[% INCLUDE 'doc-head-open.inc' %]
+[% USE cache = Cache %]
+[% cache.inc(
+'template' => 'doc-head-open.inc',
+'keys' => {'dochead' => 'dochead'},
+'ttl' => 360
+)
+%]

?
(if that's the case, then I'll add this to my next RM newsletter & send a mail
to koha-devel about that)
Do you already have a list of other .inc we could cache too ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747

Owen Leonard  changed:

   What|Removed |Added

 Depends on||8278

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8278] New: Replace YUI autocomplete in UNIMARC 210c plugin

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8278
  Assignee: oleon...@myacpl.org
Blocks: 7747
   Summary: Replace YUI autocomplete in UNIMARC 210c plugin
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: oleon...@myacpl.org
  Hardware: All
Status: NEW
   Version: master
 Component: Templates
   Product: Koha

There is a YUI autocomplete instance in a UNIMARC plugin
(unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a
sandbox set up with UNIMARC. I could use help with a follow-up to Bug 7747.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7447] Allow to specify a date in overdue_notice.pl

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_8
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7857] database upgrade fails with plack

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it receives an invalid message

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787

Ian Walls  changed:

   What|Removed |Added

  Attachment #10362|0   |1
is obsolete||

--- Comment #14 from Ian Walls  ---
Comment on attachment 10362
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10362
Signed off patch

Minor conflict with perl critic fixes... fixed now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it receives an invalid message

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787

--- Comment #13 from Ian Walls  ---
Created attachment 10392
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10392&action=edit
[SIGNED OFF] Bug 7787: Make the SIP server much more robust.

Be liberal in what we accept, but strict in what we send:
Never exit the server process, but send a SC_RESEND message (96)
to the client if we received anything we don't understand.
 This is consistent with SIP server implementations of other ILSs.

Signed-off-by: Colin Campbell 
Signed-off-by: Ian Walls 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it receives an invalid message

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787

--- Comment #12 from Ian Walls  ---
Removes 3 strikes logic in favour of continuous monitoring of the input.  If
bad input is passed, the RESEND message is returned, rather than the system
hanging.  This seems like a solid way to go, in my opinion, but I don't have
sufficient SIP clients to test against.

Personally, I'm inclined to sign off on this, but I'm not 100% it should pass
QA just on my say so.  Would another member of the QA team please review this
patch as well, preferably running it through some kind of live SIP client? 
This is one of those occasions where having an extra set of QA-eyes will be
very helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7955] Statistics tab in patron module

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7905] Multi-line notes are displayed on one line in Staff Serials page

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #6 from Ian Walls  ---
Both patches are template only, and add the HTML line break filter to fields
that are known to have line breaks.  Marking Passed QA on both.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8255] Local cover images should be cacheable

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #4 from Ian Walls  ---
Just changes caching rules to make more sense.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #11 from Ian Walls  ---
While this is a very large patch, it is entirely template based.  It moves us
from one implementation of the datepicker to a better one, with a little
spacing cleanup along the way for good measure.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181

Ian Walls  changed:

   What|Removed |Added

  Attachment #10371|0   |1
is obsolete||

--- Comment #10 from Ian Walls  ---
Comment on attachment 10371
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10371
Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version

Rebased patch to apply on current master (trivial conflicts resolved)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181

--- Comment #9 from Ian Walls  ---
Created attachment 10391
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10391&action=edit
[PASSED QA] Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI
version

All instances of the old DynArch calendar have been replaced with
jQueryUI versions and the old library files have been removed.

calendar.inc has been modified to include jQueryUI localization
strings and global configuration options. Just add a "datepicker"
class to an input field to trigger a datepicker prompt.

If you would like two fields in one from to limit each other (one
is date from, one is date to), add these classes to each:
"datepickerfrom" and "datepickerto." This will prevent an invalid
entry, e.g. a date in the latter which falls before the former.

jQueryUI is now upgraded to the latest verision, 1.8.21.

Edit: Now with proper translatability, date formatting, first day
of the week handling, and RTL support.

Signed-off-by: Chris Cormack 
Signed-off-by: Ian Walls 
QA Comment:  rebased on current master; minor merge conflicts with other
patches pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

--- Comment #26 from Paul Poulain  ---
Patch pushed, and I don't think a follow-up is needed to add the dependency,
because it's unneeded for a standard production server, ppl installing will be
wondering why and if they should install this package

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8272] OPAC : date expiration format

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #6 from Ian Walls  ---
Template only change to add date filter.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #5 from Ian Walls  ---
Correctly reimplements duration as signed instead of absolute value.  Marking
Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #5 from Ian Walls  ---
Template only change, moving  boundaries around.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values doesn't appear in planning list

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #3 from Ian Walls  ---
Removes conditional check for "authcat" in order to display auth values list. 
Template only change, handles indentation, marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #9 from Ian Walls  ---
New subroutine is added to advance_notices.pl that makes use of
GetMemberDetails to get the borrower's branchcode.  This is incredibly
inefficient, and should be replaced with GetMember.  See bug 7058.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154

Ian Walls  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #8 from Ian Walls  ---
As this patch implements something I suggested, perhaps I'm not the best person
to QA it, but from what I can tell, it does the job of fixing the comparison
types most handily, and using modern Koha modules.  Marking Passed QA if
anyone objects to this, please say so.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8006] Loading offline circulation does not anonymize

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8006

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com

--- Comment #4 from Paul Poulain  ---
patch pushed (untested, but very simple patch, trusting signoffer)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8098] DataTables in Acquisision module: parcel.tt

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8098

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8099] DataTables in Acquisision module: acqui-home.tt

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8099

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|unspecified |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8100] DataTables in Acquisision module: neworderbiblio.tt

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8100

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|unspecified |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8102] DataTables in Acquisision module: supplier.tt

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8102

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|unspecified |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8103] DataTables in Acquisision module: parcels.tt

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8103

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|unspecified |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8104] DataTables in Acquisision module: lateorders.tt

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8104

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|unspecified |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8105] DataTables in Acquisision module: basketgroup.tt

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||paul.poul...@biblibre.com

--- Comment #4 from Paul Poulain  ---
The patch does not apply, I tried to solve the conflits, as it looked easy, but
no success.

Please fix & switch back to passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8152] Clicking cancel on edit suggestion redirect to the suggestion detail

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8152

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|unspecified |rel_3_8
   Severity|enhancement |normal

--- Comment #4 from Paul Poulain  ---
It's a bugfix, not an ENH !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183

Paul Poulain  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8277] item form not always showing when ordering

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8277

Albert Oller  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

--- Comment #2 from Albert Oller  ---
I've tested this on 3 systems, and found the problem with one of the systems.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

--- Comment #9 from Jared Camins-Esakov  ---
(In reply to comment #8)
> I have been pondering this... but feel it's not ok to change existing
> behaviour - some libraries might like it. And maybe with hierarchical
> authorities it makes sense to see unused authorities too?

This was my reasoning, too. Also, with the integration of semantikoha data into
authorities, one could imagine libraries using the "Browse authors" section as
almost a biographical dictionary. Which would be very cool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

--- Comment #8 from Katrin Fischer  ---
I have been pondering this... but feel it's not ok to change existing behaviour
- some libraries might like it. And maybe with hierarchical authorities it
makes sense to see unused authorities too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

--- Comment #7 from Paul Poulain  ---
(In reply to comment #5)
> I think for the staff interface a filter like you suggest would be nice, but
> for OPAC users authorities without biblios are not really useful. 
The more I think of it the more I agree with you here.

> They might
> be duplicates or accidentally created stubs or just weird authorities from a
> big imported authority file. So I think for the OPAC a syspref is really a
> good way to deal with this.

The good news for the FAUSP leader: doesn't it mean we don't need the syspref,
we just should display authorities linked ? I can't see a use case where it's
usefull to see unattached authorities...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8277] item form not always showing when ordering

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8277

--- Comment #1 from Nicole C. Engard  ---
I should note that AcqCreateItem  is set to 'placing an order' on all installs
I tested.

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8277] New: item form not always showing when ordering

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8277

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8277
  Assignee: koha-bugs@lists.koha-community.org
   Summary: item form not always showing when ordering
  Severity: critical
Classification: Unclassified
OS: All
  Reporter: neng...@gmail.com
  Hardware: All
Status: NEW
   Version: master
 Component: Acquisitions
   Product: Koha

When ordering in acquisitions the item form isn't always showing (see:
http://screencast.com/t/USJxXyTO9). I have tested on 3 3.8.1 systems and see
this on two of them .. I can't figure out what's going on, or why it works on
one and not the others, but wanted to get the report out here.

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8276] New: circ history not sorting right

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8276
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: circ history not sorting right
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: neng...@gmail.com
  Hardware: All
Status: NEW
   Version: master
 Component: Circulation
   Product: Koha

Created attachment 10390
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10390&action=edit
sort error

When you're on the patron's circulation history in the staff client the far
right column is sorting by month/day in descending order, but year is
ascending.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Mason James  changed:

   What|Removed |Added

  Attachment #10388|0   |1
is obsolete||

--- Comment #24 from Mason James  ---
Created attachment 10389
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10389&action=edit
bug 8110 - add 'sample_holidays.sql' files for all languages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Mason James  changed:

   What|Removed |Added

  Attachment #10387|0   |1
is obsolete||

--- Comment #23 from Mason James  ---
Created attachment 10388
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10388&action=edit
bug 8110 - add 'sample_holidays.sql' files for all languages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4221] defaultSortField & OPACdefaultSortField non functioning

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4221

--- Comment #9 from Fridolyn SOMERS  ---
(In reply to comment #8)
> Without applying any patch, I have tried to change the value of thoses
> sysprefs several times and search results seems to be correctly sorted.
> Nicole, could you give more information if it still does not work for you ?

The problem only occurs on a fresh install.
The first modification of the syspref will set a value.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8267] Overdue notices not working

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #5 from M. de Rooy  ---
Small fix, explained. Looks good to me. Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #22 from Katrin Fischer  ---
Thx for the patch Mason :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #21 from Mason James  ---
(In reply to comment #19)
> Comment on attachment 10382 [details]
> [SIGNED-OFF] bug 8110 - add branchcode MPL to sample holidays to facilitate
> automated testing.
> 
> This patch only updates the English sample files, it would avoid problems if
> we could update all sample holiday files for all languages.


oops, good spotting! - i've just added those files now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8267] Overdue notices not working

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #20 from Mason James  ---
Created attachment 10387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10387&action=edit
bug 8110 - add 'sample_holidays.sql' files for all languages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8267] Overdue notices not working

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

Julian Maurice  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8267] Overdue notices not working

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

Julian Maurice  changed:

   What|Removed |Added

  Attachment #10357|0   |1
is obsolete||

--- Comment #4 from Julian Maurice  ---
Created attachment 10386
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10386&action=edit
[SIGNED-OFF] Bug 8267 - Overdue notices not working

Without patch:

Used letter corresponds to the number of issues in notice triggers:
1 issue => First trigger letter
2 issues => Second trigger letter
...
4 issues and more => Error: no more than 3 triggers =)

Patch fix the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8275] New: xml parsing error when the webservice GetPatronInfo/show_loans is called

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8275

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8275
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: xml parsing error when the webservice
GetPatronInfo/show_loans is called
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: k...@univ-lyon3.fr
  Hardware: All
Status: NEW
   Version: rel_3_8
 Component: Circulation
   Product: Koha

When called by the webservice GetPatronInfo (C4/ILSDI/Services.pm) with
show_loans parameter defined, the GetPendingIssues routine return a hash
including Datetime object (since Bug 5549 - Hourly Loans). These Datetime
objects seem to have some bad consequences on the display :

The final display :
Parsing error...
A Datetime object can only be compared to another Datetime object
(DateTime=HASH(0xaa1a3000), HASH(0xa960xf0)) at /usr/share/perl5/XML/Simple.xml
line 1406

As a work-around, I added theese lines (wich permit a correct display) in
Services.pm line 421 :

if ( $cgi->param('show_loans') eq "1" ) {
my $issues = GetPendingIssues($borrowernumber);
+foreach my $issue ( @$issues ){
+$issue->{issuedate} =  $issue->{issuedate}->ymd;
+$issue->{date_due} =  $issue->{date_due}->ymd;
+}
$borrower->{'loans'}->{'loan'} = $issues;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #19 from Katrin Fischer  ---
Comment on attachment 10382
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10382
[SIGNED-OFF] bug 8110 - add branchcode MPL to sample holidays to facilitate
automated testing.

This patch only updates the English sample files, it would avoid problems if we
could update all sample holiday files for all languages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Mason James  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com

--- Comment #18 from Mason James  ---
QA Comment:
this patch-set passes all perl-critic and prove tests.

---
$ perl  ~/bin/git-perlcritic.pl 
Koha/Calendar.pm: OK
t/db_dependent/Holidays.t: OK

$ mysql head < installer/data/mysql/en/optional/sample_holidays.sql

$ prove ./t/db_dependent/Holidays.t ./t/db_dependent/Holidays.t .. ok   
All tests successful.
Files=1, Tests=8,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.28 cusr  0.03
csys =  0.34 CPU)
Result: PASS
---

Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Mason James  changed:

   What|Removed |Added

  Attachment #10349|0   |1
is obsolete||
  Attachment #10384|0   |1
is obsolete||

--- Comment #17 from Mason James  ---
Created attachment 10385
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10385&action=edit
[SIGNED-OFF] Holidays Test Plan - DB Dependent

mason@xen1:~/g/head$ mysql head <
installer/data/mysql/en/optional/sample_holidays.sql

mason@xen1:~/g/head$ prove ./t/db_dependent/Holidays.t
./t/db_dependent/Holidays.t .. ok   
All tests successful.
Files=1, Tests=8,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.28 cusr  0.03
csys =  0.34 CPU)
Result: PASS

Holidays.t works as stated. signing-off :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #16 from Mason James  ---
Created attachment 10384
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10384&action=edit
Holidays Test Plan - DB Dependent

This test file is meant to be used with the sample database
with a minimum of the sample libraries and sample holidays installed.

Holidays.t works as stated. signing-off :)

mason@xen1:~/g/head$ mysql head <
installer/data/mysql/en/optional/sample_holidays.sql

mason@xen1:~/g/head$ prove ./t/db_dependent/Holidays.t
./t/db_dependent/Holidays.t .. ok   
All tests successful.
Files=1, Tests=8,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.28 cusr  0.03
csys =  0.34 CPU)
Result: PASS !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018

--- Comment #12 from Katrin Fischer  ---
I think it might be good to show all subfields, because you can have items from
different frameworks on your list easily. Not sure which framework is used in
this case currently? There are also fields like onloan you don't want people to
batch edit. I am not sure, what the best solution here is.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8270] Software error: Can't call method "subfield" on an undefined value at /usr/share/koha/lib/C4/Biblio.pm line 2919

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8270

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Kyle M Hall  ---
This is almost certainly the result of a corrupted MARC record in your
database, and not a problem with Koha itself. I'd recommend you pinpoint your
problem record and re-catalog it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #15 from Kyle M Hall  ---
Liz, Tomás, would one or both of you consider the "Holidays Test Plan - DB
Dependent" patch to be signed off as well, considering it was necessary for
testing. I think it should be included in Koha proper. I think we need for more
db dependent testing than we have had in the past. That's why this bug exists,
after all!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #10363|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #14 from Kyle M Hall  ---
Created attachment 10383
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10383&action=edit
[SIGNED-OFF] 8110 - Fines accruing on closed days - Fix Day/Month Holidays Bug

This patch fixes a bug in which day/month holidays are stored in the
Koha::Calendar internal hash not by month/day but incorrectly by day/month.

To test:
1) Apply 'Holidays Test Plan - DB Dependent' patch, create MPL
   holidays for Sunday, New Years Day, and Christmas.

2) Run test plan, only Christmas should fail ( New Years does not
   because 1-1 means the day and month position do not matter ).

3) Apply this patch

4) Run test plan again

Signed-off-by: Liz Rea 
Test plan works as advertised.

Signed-off-by: Tomas Cohen Arazi 
Test runs flawlessly. I originaly missed to set the expected branchcode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6090] empty mails in message_queue are sent

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #15 from M. de Rooy  ---
Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8110] Fines accruing on closed days

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #10368|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall  ---
Created attachment 10382
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10382&action=edit
[SIGNED-OFF] bug 8110 - add branchcode MPL to sample holidays to facilitate
automated testing.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

M. de Rooy  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #71 from M. de Rooy  ---
Well, we had this bug a week in discussion with feedback from Jared, Ian,
Robin, Chris N and Mason. This makes me draw the following conclusions with
reference to my former QA comment:

1) My suggestion to turn dev mode on via a preference was not accepted. So we
can leave that as it is (via $ENV{DEBUG}).
2) The distinction between numbered dbrevs and unnumbered ones should be added.
Note however that my suggestion to not show them in normal mode can be
discarded.
3) Although only Ian is rather hesitant in accepting this solution, his idea of
reverting/undoing a dbrev is quite interesting for a future followup.

Could you please adjust the patch with these comments on the former QA comment
in mind? Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6090] empty mails in message_queue are sent

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6090] empty mails in message_queue are sent

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #10378|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall  ---
Created attachment 10381
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10381&action=edit
[SIGNED-OFF] Bug 6090: Do not enqueue empty messages

This patch avoid enqueuing messages that have an empty body. It can
happen when letter is empty or becomes empty after being processed by
parseletter

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #12 from Jared Camins-Esakov  ---
Another signoff for the first patch now that it's been rebased would be super
keen.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #10294|0   |1
is obsolete||

--- Comment #11 from Jared Camins-Esakov  ---
Created attachment 10380
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10380&action=edit
Bug 6720: Display the authority type in OPAC

Due to a peculiarity in the way SearchAuthorities worked, the authority
search results on the OPAC always listed the authority type that the
user searched for, rather than the authority type of the results.

Signed-off-by: Katrin Fischer 
Works nicely, result list for OPAC search now shows the authority type
for each record.

Signed-off-by: Jared Camins-Esakov 
Rebased 20 June 2012.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5295] ctype index Zebra configuration

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295

--- Comment #9 from Fridolyn SOMERS  ---
I think indeed MARC21 will be broken because it uses ctype in record.abs.

By now, "ctype" works for MARC21 but it's a best pratice to use long names in
configuration and short names only in CCL queries, no?

Can we replace "ctype" by "Content-type" for all record.abs ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians

2012-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304

M. de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #18 from M. de Rooy  ---
The size of this patch and the relative small changes to the code (compared to
last version) may justify keeping it in Signed-off state.
Several points of QA comment have received attention. No dependency is added.
Good to see that you also remove the warning on redefine.
Although I still believe that some code improvements could be made here as
referred to in my previous comments, they should not block this patch from
getting through.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >