[Koha-bugs] [Bug 5981] OPAC: Add limits to search history

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|rel_3_8 |master

--- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
There are some strange side effects of this patch on master too. It all resumes
to working normally as soon as I turn opacsearchhistory off or revert this
patch out. 

Symptoms:
- Every search seems to freeze the browser, but after a minute or so the search
result page appears
- Paging works for me, but at a 1 page/minute speed

I tried lots of different things before I figured out it was this patch making
the difference:
- rebuilt my indexes several times
- ran Makefile to make sure I have all current zebra files
- changed from grs to dom indexing
- changed to icu 

None of that worked.

I have no idea what's going on here, but I think reverting out of master would
be good until we figure it out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 166] Member details form shows yyyy/mm/dd, but instructions say otherwise

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=166

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|VERIFIED|RESOLVED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
This is not a problem in current stable releases. Closing this bug for good :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 10690
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10690action=edit
[SIGNED-OFF] Bug 7143 – Bug for tracking changes to the about page

This patch updates the German translators. To be applied after attachment
10681.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #10689|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 10691
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10691action=edit
screenshot

Hi Jared, 

I tested this and I think there is a small mistake in the linking. In my
catalog it didn't only link the see also, but also the used for/see from. 
The links are not correct too.
The last see also link is used for all links below until the next see also.

I was also wondering what happens when the linked authority does not exist. I
tried on of the links and I had a empty line on top of the list with a ^
instead of a heading.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #4547|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Attachment #4543|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

--- Comment #32 from Kyle M Hall kyle.m.h...@gmail.com ---
My patch was a a full rewrite of Elliot's patch, as his sat here too long
without testing any became very out of sync with master. I didn't obsolete his
implementation out of courtesy, but since mine has already been signed off, it
seems silly not to push forward with it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jared,

I tested this on current master and there are some problems. 

I got mails with the following errors from my system:

Useless use of substr in void context at
/home/katrin/kohaclone/C4/AuthoritiesMarc.pm line 1089.
Useless use of substr in void context at
/home/katrin/kohaclone/C4/AuthoritiesMarc.pm line 1102.

The main heading shows as HASH(0x3b1a130).

The new detail view displays nicely for me. Some thoughts about this:
- The heading See also: should only show when there are see alsos
- I wonder if the preferred form should also be bold.

I think your patch totally removes the labelled MARC view. Could it be an
option to have tabs for authorities advertising different views?
Maybe some time in the future a plain MARC view would also be nice, as would be
a download option.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

--- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think your patch totally removes the labelled MARC view. Could it be an 
option to have tabs for authorities advertising different views?
Maybe some time in the future a plain MARC view would also be nice, as would 
be a download option.

was totally wrong about that - tabs are there!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #10592|0   |1
is obsolete||

--- Comment #13 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10692
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10692action=edit
Bug 8204: Add user friendly authority view to OPAC

Up until now, the only authority view in the OPAC was a
rather-unfriendly expanded MARC view. This patch adds a user-friendly
view similar to the biblio details view.

Specific features to be aware of:
* Right-to-left text in the MARC21 880 field will show up in the
  appropriate location with the appropriate alignment and wrapping
* There is very little CSS styling. Any suggestions for how to make
  the display more attractive would be gratefully received.

To test:
1) Do a search for an authority in the OPAC.
2) Choose an authority record to view.
3) Observe that the view is more user-friendly and polished.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

--- Comment #14 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Revised the patch to take care of the issues identified by Katrin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #10422|0   |1
is obsolete||

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10693
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10693action=edit
Bug 3462: Links in authorities should be hyperlinks

Make see also links in both the OPAC and authority module search results
into hyperlinks and not just textual strings.

To test:
1. Do a search for an authority that will bring up a heading with a
   see also reference in the staff client and the OPAC.
2. Confirm that the see also references listed in the search results
   are now hyperlinks, which work.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #10692|0   |1
is obsolete||

--- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10694
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10694action=edit
Bug 8204: Add user friendly authority view to OPAC

Up until now, the only authority view in the OPAC was a
rather-unfriendly expanded MARC view. This patch adds a user-friendly
view similar to the biblio details view.

Specific features to be aware of:
* Right-to-left text in the MARC21 880 field will show up in the
  appropriate location with the appropriate alignment and wrapping
* There is very little CSS styling. Any suggestions for how to make
  the display more attractive would be gratefully received.

To test:
1) Do a search for an authority in the OPAC.
2) Choose an authority record to view.
3) Observe that the view is more user-friendly and polished.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com ---
The problem, it turns out, is that when you call a TT block enough times,
variables don't get cleared when they go out of scope. The fix was simply to
explicitly unset the URL variable whenever there was no URL.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #10693|0   |1
is obsolete||

--- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10695
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10695action=edit
Bug 3462: Links in authorities should be hyperlinks

Make see also links in both the OPAC and authority module search results
into hyperlinks and not just textual strings.

To test:
1. Do a search for an authority that will bring up a heading with a
   see also reference in the staff client and the OPAC.
2. Confirm that the see also references listed in the search results
   are now hyperlinks, which work.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #10695|0   |1
is obsolete||

--- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10696
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10696action=edit
Bug 3462: Links in authorities should be hyperlinks

Make see also links in both the OPAC and authority module search results
into hyperlinks and not just textual strings.

To test:
1. Do a search for an authority that will bring up a heading with a
   see also reference in the staff client and the OPAC.
2. Confirm that the see also references listed in the search results
   are now hyperlinks, which work.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7721] Global xslt parsing in XSLT.pm under mod_perl

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7721

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch does not apply. Also, it would be very helpful to have a test plan
for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #10696|0   |1
is obsolete||

--- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10697
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10697action=edit
Bug 3462: Links in authorities should be hyperlinks

Make see also links in both the OPAC and authority module search results
into hyperlinks and not just textual strings.

To test:
1. Do a search for an authority that will bring up a heading with a
   see also reference in the staff client and the OPAC.
2. Confirm that the see also references listed in the search results
   are now hyperlinks, which work.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

--- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10698
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10698action=edit
Bug 3462: quiet warn

Quiets an unnecessary warning about an uninitialized value.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #10697|0   |1
is obsolete||
  Attachment #10698|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 10699
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10699action=edit
[SIGNED-OFF] Bug 3462: Links in authorities should be hyperlinks

Make see also links in both the OPAC and authority module search results
into hyperlinks and not just textual strings.

To test:
1. Do a search for an authority that will bring up a heading with a
   see also reference in the staff client and the OPAC.
2. Confirm that the see also references listed in the search results
   are now hyperlinks, which work.

Bug 3462: quiet warn

Quiets an unnecessary warning about an uninitialized value.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Patch works nicely and is a great improvement.

Tests:
- Checked links for existing and non existing see alsos give correct
  search results
- Verified links show up for all see alsos in a result list
- Verified links are properly linked with the correct names
- Checked logs don't show errors

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #10694|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 10700
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10700action=edit
[SIGNED-OFF] Bug 8204: Add user friendly authority view to OPAC

Up until now, the only authority view in the OPAC was a
rather-unfriendly expanded MARC view. This patch adds a user-friendly
view similar to the biblio details view.

Specific features to be aware of:
* Right-to-left text in the MARC21 880 field will show up in the
  appropriate location with the appropriate alignment and wrapping
* There is very little CSS styling. Any suggestions for how to make
  the display more attractive would be gratefully received.

To test:
1) Do a search for an authority in the OPAC.
2) Choose an authority record to view.
3) Observe that the view is more user-friendly and polished.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works very nicely now. The old view is still available, but the
user is presented with a nicer non-MARC view first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] New: It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8382
  Assignee: koha-bugs@lists.koha-community.org
   Summary: It is not possible to cancel an order when receiving
on a filtered page in parcel.pl
  Severity: blocker
Classification: Unclassified
OS: All
  Reporter: christophe.croulleb...@biblibre.com
  Hardware: All
Status: NEW
   Version: master
 Component: Acquisitions
   Product: Koha

Because in parcel.pl page the filter (on the left) makes a table using jscript
and a very different workflow, the cancel link does nothing just asking for
cancelling.
Principaly due to the use of the filter js function that call the parcel.pl
page and does all the job in a separate block with a separate perl function
(SearchOrder)
that sends all to js, that constructs html to finally append it to table.
So I have decided to rebuild entirely the filter.
I have choosen to overload the function GetPendingOrders to enable it to
accept new arguments.
To test : when you are in parcel.pl ready to receive orders, simply select a
filter on the left and on the filtered page try to cancel a line, you'll have
the warning message but no more, the line will be not canceled.
Instead having Delete order and Delete order and catalog record, you have
cancel.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |christophe.croullebois@bibl
   |ity.org |ibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

--- Comment #1 from Christophe Croullebois 
christophe.croulleb...@biblibre.com ---
Created attachment 10701
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10701action=edit
proposed patch

thx for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

Christophe Croullebois christophe.croulleb...@biblibre.com changed:

   What|Removed |Added

  Attachment #10701|0   |1
is obsolete||

--- Comment #3 from Christophe Croullebois 
christophe.croulleb...@biblibre.com ---
Created attachment 10702
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10702action=edit
proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7351] ability to edit a range of holidays

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351

--- Comment #35 from Christophe Croullebois 
christophe.croulleb...@biblibre.com ---
Paul, too much time has passed, the calendar has changed, I have to rewrite
code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jared, 

I am not sure about the field description 9 (RLIN). Would it be possible to
use something more descriptive? Is this is a Koha specific use of the subfield?
Can we get some more opinions on that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #2)
 Hi Jared, 
 
 I am not sure about the field description 9 (RLIN). Would it be possible
 to use something more descriptive? Is this is a Koha specific use of the
 subfield?
 Can we get some more opinions on that?

At present we use RLIN in the bibliographic frameworks, so I used the same.
I'd be happy to change the description for the authority frameworks, but I
can't translate it as part of the update, and I am definitely not going to be
editing the bibliographic frameworks (to preserve consistency). Our use of the
subfield 9 is entirely Koha-specific.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #10551|0   |1
is obsolete||

--- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10703
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10703action=edit
Bug 8207: Allow see also fields in auths to link to thesauri

Right now if you were to link a field in an authority to a thesaurus, it
would not work properly. The authority type frameworks require some
adjustments to allow see also headings to be linked to thesauri (such as
adding subfield $9).

This patch adds subfield $9 and thesaurus links to existing installs
for those 5xx fields (under MARC21 and NORMARC only) which do not yet
have any subfield $9 or thesauri configured, as well as adding that to
new English language installs. There will be a follow-up patch adding
the subfields to new non-English language install files later, once
it is clear that the changes proposed and demonstrated in the English
files are accepable to the community.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8383] New: Need test to check that Perl files will compile

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383

  Priority: P1 - high
 Change sponsored?: ---
Bug ID: 8383
  Assignee: jcam...@cpbibliography.com
   Summary: Need test to check that Perl files will compile
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Test Suite
   Product: Koha

We have t/00-load.t to make sure that C4 and Koha modules can be loaded, but
right now there is no test to prevent the inclusion of a Perl script that does
not compile in Koha. There should be one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8384] New: Some Perl scripts do not compile

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8384

  Priority: P1 - high
 Change sponsored?: ---
Bug ID: 8384
  Assignee: gmcha...@gmail.com
   Summary: Some Perl scripts do not compile
  Severity: major
Classification: Unclassified
OS: All
  Reporter: jcam...@cpbibliography.com
  Hardware: All
Status: NEW
   Version: master
 Component: Architecture, internals, and plumbing
   Product: Koha

Three Perl scripts that are currently included in master do not compile: 
* misc/translator/text-extract2.pl
* misc/migration_tools/build6xx.pl
* misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl

They should.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8383] Need test to check that Perl files will compile

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383

--- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10704
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10704action=edit
Bug 8383: Add test to check that Perl scripts compile

This patch adds t/00-strict.pl which tests that all Perl scripts
compile. I chose to use Test::Strict so that in the future we can
also have the test check that use strict and use warnings are
enabled.

To test:
1. Run t/00-strict.pl.
2. Run around waving your arms in the air that we have a couple of
   scripts that don't compile.
3. Actually, that's about it. You could test my patch for bug 8384 next.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8384] Some Perl scripts do not compile

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8384

--- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 10705
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10705action=edit
Bug 8384: Some Perl scripts do not compile

Fix syntax errors preventing the scripts misc/translator/text-extract2.pl
and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling.

Remove misc/migration_tools/build6xx.pl entirely since it refers to
columns that no longer exist in the Koha database, and has seemingly
had broken encoding since Koha switched from CVS to git (or before!).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8384] Some Perl scripts do not compile

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8384

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8383] Need test to check that Perl files will compile

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8383] Need test to check that Perl files will compile

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
I like it, except this does more than check they will compile.

eg
not ok 28 - Syntax check acqui/modordernotes.pl
#   Failed test 'Syntax check acqui/modordernotes.pl'
#   at /usr/share/perl5/Test/Strict.pm line 305.
# DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed:
Access denied for user 'kohaadmin'@'localhost' (using password: YES) at
C4/Context.pm line 758


Because they use C4::Context, to do a test like this we need a database, hence
we need this script in t/db_dependent/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8384] Some Perl scripts do not compile

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8384

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Before the patch

perl -I ../../ -c text-extract2.pl   
Bareword TmplTokenType::TAG not allowed while strict subs in use at
text-extract2.pl line 45.
Bareword TmplTokenType::TEXT_PARAMETRIZED not allowed while strict subs in
use at text-extract2.pl line 53.
text-extract2.pl had compilation errors.

 perl -c misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl 
syntax error at misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl line 67,
near $IN open
Global symbol $IN requires explicit package name at
misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl line 67.
misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl had compilation errors.

After the patch

perl -I ../../ -c text-extract2.pl  
text-extract2.pl syntax OK

perl -c misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl
misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl syntax OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8384] Some Perl scripts do not compile

2012-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8384

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #10705|0   |1
is obsolete||

--- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 10706
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10706action=edit
Bug 8384: Some Perl scripts do not compile

Fix syntax errors preventing the scripts misc/translator/text-extract2.pl
and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling.

Remove misc/migration_tools/build6xx.pl entirely since it refers to
columns that no longer exist in the Koha database, and has seemingly
had broken encoding since Koha switched from CVS to git (or before!).

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/