[Koha-bugs] [Bug 8487] C4::Installer::PerlDependencies needs Test::Strict hash corrected

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8487

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
See also bug 7368 latest patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #38 from M. Tompsett mtomp...@hotmail.com ---
*** Bug 8487 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8487] C4::Installer::PerlDependencies needs Test::Strict hash corrected

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8487

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Okay, I see that the patch for bug 7368 does fix this problem as Chris desired.
I think I'll mark this as DUPLICATE as a result. Thanks for pointing this out,
M. de Rooy.

*** This bug has been marked as a duplicate of bug 7368 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #11048|0   |1
is obsolete||

--- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11069
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11069action=edit
[SIGNED-OFF] Adjusted patch for perl deps

hum... strange, I have no error on current master.

And your last patch fixes my previous problem :-)

Then I switch to signed-off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #40 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #39)
 Created attachment 11069 [details]
 [SIGNED-OFF] Adjusted patch for perl deps
 
 hum... strange, I have no error on current master.
 
 And your last patch fixes my previous problem :-)
 
 Then I switch to signed-off

Thanks. What perl version are you using BTW ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #40)
 Thanks. What perl version are you using BTW ?
$ perl -v 
This is perl 5, version 14, subversion 2 (v5.14.2)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #42 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #41)
 (In reply to comment #40)
  Thanks. What perl version are you using BTW ?
 $ perl -v 
 This is perl 5, version 14, subversion 2 (v5.14.2)

Hmm. I have the same. If I run on master perl koha-perl-deps -a
I have the error referred above..
Looks like some module does not contain a version, but could not find it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #43 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #42)
 Hmm. I have the same. If I run on master perl koha-perl-deps -a
 I have the error referred above..
 Looks like some module does not contain a version, but could not find it?

Note that the error comes first, before the long listing of module names. You
could easily miss it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8153] Bulk serial receive

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8153

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
I like the idea, however

+#if it is bulk receive
+if($op eq 'all')
+{
+my $sth = $dbh-prepare('select subscriptionid from subscription');
+$sth-execute;
+my $row;
+while ($row = $sth-fetchrow_array()) {
+push (@subscriptionids,$row);
+}
+}else {
+@subscriptionids =  $query-param('subscriptionid');
+}


in serials-edit.pl has a few problems.

1/ We shouldn't have sql in .pl files
2/ The indentation fails the coding guidelines
3/ This will get all expired subscriptions, ie, it just gets all, that may be
thousands for a big library

I haven't tested much further. What this patch does, also that is not
advertised is it changes the layout of the serials receive page also.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5635] bulkmarcimport new parameters features

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5635

Gaetan Boisson gaetan.bois...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||gaetan.bois...@biblibre.com

--- Comment #9 from Gaetan Boisson gaetan.bois...@biblibre.com ---
Patch does not apply.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8039] Self Checkout/SIP: Allow authentication with userid and password

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Attachment #9845|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 11070
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11070action=edit
bug_8039: Try userid if cardnumber borrower search fails in SIP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8039] Self Checkout/SIP: Allow authentication with userid and password

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Patch rebased, it is a catalyst patch so I dont want to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8379] Encoding problem under Plack

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379

--- Comment #2 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #1)
 Reloading plack shouldn't make a difference, but I'm wondering did you made
 Z39.50 search before encoding got confused? Or anything which touches C
 libraries?
I don't remember.

I just tried to reproduce the error by searching z3950, playing with addbiblio
again, and could not reproduce the issue :(

I'll add a comment if I have the problem again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5981] OPAC: Add limits to search history

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981

--- Comment #38 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #37)
 Either this patch or the patch to bug 8381 has broken the OPAC search in
 Chrome. With EnableOPACSearchHistory enabled, Chrome crashes on a regular
 keyword search (q=smith), and hangs on searches using idx=kwq=smith.
 Disabling EnableOPACSearchHistory fixes the problem.

mmm... strange, I can't reproduce this problem.

I use chromium shipped with Ubuntu: 18.0.1025.168 (Build de développement
134367 Linux) Ubuntu 12.04

I don't think i've any plugin installed (I don't use chrome daily)

I played with some searches, history page, running a search from history,...

Could you describe exactly what you were doing ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8268] Koha should offer way to backup entire db

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #29 from Paul Poulain paul.poul...@biblibre.com ---
Trivial and neede follow-up, passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8268] Koha should offer way to backup entire db

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8083] Granular parameters permissions

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #13 from Paul Poulain paul.poul...@biblibre.com ---
QA comments: previous comments fixed, no more reason not to pass QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8083] Granular parameters permissions

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|unspecified |rel_3_10

--- Comment #14 from Paul Poulain paul.poul...@biblibre.com ---
I tried to access all admin pages with a superlibrarian account after applying
the patch, no problem displaying those pages.

Good job srdjan.

@all = follow-ups welcomed (in separate bugs) for introducing other admin
granular permissions !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5635] bulkmarcimport new parameters features

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5635

stephane.dela...@biblibre.com changed:

   What|Removed |Added

   Attachment #7485|0   |1
is obsolete||

--- Comment #10 from stephane.dela...@biblibre.com ---
Created attachment 11071
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11071action=edit
proposed patch

updated patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5635] bulkmarcimport new parameters features

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5635

stephane.dela...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #11034|0   |1
is obsolete||

--- Comment #10 from Marc Véron ve...@veron.ch ---
Created attachment 11072
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11072action=edit
[SIGNED-OFF] Bug 7628: Escape '+' characters for categorycode

uri escape the following characters:
, @, /, ;, :, =, +, ? and $

Signed-off-by: Marc Veron ve...@veron.ch

Test and sign off second patch (independently from first patch).

Added categories like '+zwoelf' or '? Test' before applying the patch.
Deletion was not possible.

After applying patch deletion is possible, patch works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com ---
It seems it is caused by the version of Modern::Perl:

$pmvers Modern::Perl
1.03

My Modern/Perl.pm contains 
our $VERSION = '1.03';

Whereas a new version of this module contains:
Modern::Perl::VERSION {
my ($self, $version) = @_;
return $VERSION if $version  2009;
$wanted_date = $version if (caller(1))[3] =~ /::BEGIN/;
return 2012;
}

Actually, I don't know how we can fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8395] order receive not sorting right

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8395] order receive not sorting right

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11073
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11073action=edit
Bug 8395: Fix sort order in parcel.tt (summary)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8395] order receive not sorting right

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8395] order receive not sorting right

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #11073|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8395] order receive not sorting right

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8395] order receive not sorting right

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11074
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11074action=edit
Bug 8395: Fix sort order in parcel.tt (summary)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8395] order receive not sorting right

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8414] Intranet header toplinks display white rather than blue in IE8

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8414

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comments:

Nothing to add

Marking as Passed QA.

I have not a IE8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8470] remove depreciated H:T:P test file

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8470

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Can we delete xt/author/show-template-structure.pl too ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #45 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #44)
 It seems it is caused by the version of Modern::Perl:

Good, you found that. Interesting!
I have this version: $Modern::Perl::VERSION = '1.20120130' and the same
routine.

But I still do not understand it completely. It seems like an error in
Modern::Perl although its docs state that it is not necessary to pass a version
or a year to Modern::Perl.
AFAIK we are not passing numbers to Modern::Perl in our Koha use statements.
But when I test that in a simple script, I do not even raise this warning. What
makes koha_perl_deps do raise that warning? 

Since this is not very important, I will copy the last comments on this error
in a separate report. To be resolved one day :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8491] New: Warning of Modern::Perl raised by koha_perl_deps script

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8491

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8491
  Assignee: gmcha...@gmail.com
   Summary: Warning of Modern::Perl raised by koha_perl_deps
script
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: m.de.r...@rijksmuseum.nl
  Hardware: All
Status: NEW
   Version: master
 Component: Command-line Utilities
   Product: Koha

The actual error is (with perl 5.14.2 and Modern::Perl==1.20120130):
[Fri Jul 20 16:37:07 2012] koha_perl_deps.pl: Use of uninitialized value
$version in numeric lt () at /usr/local/share/perl5/Modern/Perl.pm line 25.
[Fri Jul 20 16:37:07 2012] koha_perl_deps.pl: Use of uninitialized value
$version in numeric lt () at /usr/local/share/perl5/Modern/Perl.pm line 25.

As Jonathan Druart pointed out in bug 7368, it is caused by the way this module
handles version numbers.

So it seems like an error in Modern::Perl although its docs state that it is
not necessary to pass a version or a year to Modern::Perl.
AFAIK we are not passing numbers to Modern::Perl in our Koha use statements.
But when I test that in a simple script, I do not even raise this warning. What
makes koha_perl_deps do raise that warning?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

--- Comment #37 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 11075
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11075action=edit
bug_5911: Make tt_valid.t happy

Signed-off-by: Paul Poulain paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #10919|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #46 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #45)
 Since this is not very important, I will copy the last comments on this
 error in a separate report. To be resolved one day :)

See further bug 8491.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #38 from Paul Poulain paul.poul...@biblibre.com ---
QA comment: no more comments

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

Version|rel_3_6 |master

--- Comment #39 from Paul Poulain paul.poul...@biblibre.com ---
I tried to test this new feature, but can't make it work:

When I reach the page /cgi-bin/koha/admin/transport-cost-matrix.pl
I just get red cells, and the documentation says: Red cells signify no
transfer allowed

One comment : if cell is red, I should not be able to enter a value isn't it ?
I can, but it's not saved when I click on Save. Is it the intended behaviour
? (Sounds strange)

I tried to get rid of the red cells, but couldn't.
 * the  UseBranchTransferLimits doesn't change anything (I tried with both
possible status)
 * Even if limits are enabled, I have added most transfer limits as enabled on
/cgi-bin/koha/admin/branch_transfer_limits.pl, but everything is still red

More explanations welcomed...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7367] General OPAC typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367

--- Comment #17 from Magnus Enger mag...@enger.priv.no ---
Created attachment 11076
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11076action=edit
Bug 7367 - One the too many

On line 123 it says of the the last. One the is probably enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7367] General OPAC typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||mag...@enger.priv.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5339] Parcel closing in acq

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #10934|0   |1
is obsolete||

--- Comment #64 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11077
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11077action=edit
[SIGNED-OFF] Bug 5339: Invoices management improvement

- New pages:
  - invoices.pl: allow to search in invoices on several criteria
  - invoice.pl: permit to view and modify invoice details
- shipment date
- billing date
- shipment cost and budget used for shipment cost

Invoice informations are now stored in their own sql table and aqorders
have a link to it

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5339] Parcel closing in acq

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5339] Parcel closing in acq

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

--- Comment #65 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle,

could you add some information about the tests you did?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8434] Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm)

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8434

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #10831|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11078
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11078action=edit
[SIGNED-OFF] Bug 8434 - Notice generation fails for Advanced Notices, Item Due,
and Overdues when run in shell (due to error in Letters.pm)

QA Comments:

The patch fixes the error if getletter is called by a command line script.

(This one fixes a bad indentation)

Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8434] Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm)

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8434

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Attachment #9706|0   |1
is obsolete||

--- Comment #4 from Marc Véron ve...@veron.ch ---
Created attachment 11079
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11079action=edit
[SIGNED-OFF] Bug 8137 - Checkout limit by patron category for all libraries

We have a patron category Temporary Adult WTMP. Under Checkout limit by patron
category for all libraries the limit is set to 5. This limit is not working. I
was able to check out 7 items to a patron in the WTMP category.

If the item's home library is LibA, and the borrower has 4 items checked out
whose home library is LibA, than the item will be checked out ( regardless of
how many items are checked out ). If the borrower has 5 items checked out
whose home library is LibA, Koha will indeed warn of too many checkouts.

I think circcontrol is being mis-used here. It should use the
maxissueqty for the item's home library ( or fallback to the
'all libraries' rule ), but it should still count all issues
from any library

Signed-off-by: Marc Veron ve...@veron.ch

How I teested:

Set patrons category restriction to 2 checkouts. Set checkout restrictions for
libraries to 10 checkouts.

Without patch, I could checkout more items than allowed by patrons category
restriction (but only if items from different libraries were involved).

With patch, the patrons category restriction was respected (warning: 'Too many
checked out. 2 checked out, only 2 are allowed.').

Patch behaves as described.expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact||koha.sek...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7367] General OPAC typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7367] General OPAC typo omnibus

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Trivial fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8062] Cart email broken for non english templates

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comments:

Bug 8062 introduced this new dependency in opac-sendbasket. But it did not call
a routine of this module. 
As no new call have been added since, it's useless.

Marking as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8392] Memberentry is not enforcing birthdate restrictions

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comments:

Humm, I think it would have been better to rename the second field_check
variable. Thus the initialisation of $dateofbirthmandatory keeps close to it
usage (l.~100 and l.~270).

But it works.
Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8392] Memberentry is not enforcing birthdate restrictions

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8476] Little bug in OPAC XSLT on OPACURLOpenInNewWindow

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8476

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Typo fix

Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8476] Little bug in OPAC XSLT on OPACURLOpenInNewWindow

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8476

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7153] Show Open Library as Search Target in More Searches in OPAC detail page

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
It seems good for me. But I let Ian make the decision (he is the QA contact for
this bug).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5409] Call number is not show on Opac search result page.

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comments:
Display the location and itemcallnumber for items if the syspref
OPACItemsResultsDisplay is on.

Marking as Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7153] Show Open Library as Search Target in More Searches in OPAC detail page

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #19 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #18)
 It seems good for me. But I let Ian make the decision (he is the QA contact
 for this bug).
Jonathan, that was done default by the system (see history).
You can take over the QA field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8448] Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #11045|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11080
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11080action=edit
[SIGNED-OFF] Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting
item with multiple holds displays a blank screen instead of a warning prompt

Since Bug 6039, cancel_result is an arrayref.
It is logical to do a FOREACH on it.

Marking as Passed QA.

This new patch replaces tab characters with 4 spaces, please update your editor
configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8442] Error when printing labels under plack

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8442

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8162] packaging scripts create user incorrectly

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8162

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Perhaps you could take advantage of modiying this file to remove the useless
use of cat:
   [ `cat $PASSWDFILE | grep ^$name:` ]
can be replaced with
[ ` grep ^$name: $PASSWDFILE ` ]

It seems good but I have not Ubuntu for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8478] Update Ubuntu related files

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701

--- Comment #16 from Paul Poulain paul.poul...@biblibre.com ---
QA comment:

The code now says
 ShelfToCart( $item-{'itemnumber'} );
= shouldn't we deal with the syspref and say
ShelfToCart( $item-{'itemnumber'} ) if
C4::Context-preference(ReturnToShelvingCart);
?

2nd question: when the item reaches it's homebranch, a check-in is done, right
?
I tried that, and the location stayed to 'CART' instead of being switched back
to items.permanentlocation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #39 from Paul Poulain paul.poul...@biblibre.com ---
mmm... either I missed something, either some parts of this patch must still be
removed.
Now, with bug 4032, each library has the opportunity to have his own XSLT.
So, I think that:
 * the XSLT.pm part is OK = we must send the datas to the XSLT
 * the XSLT update is OK = provide the information in the default XSLT
 * the systempreference is KO = if a library don't want the shelving location,
let's change the XSLT (please don't say it's harder to update a XSLT than
updating a syspref, that's the case for any display change: some libraries
want the barcode, some don't)

I -strongly- think providing the info by default is better. If you think it's
not, then just update XSLT.pm and let libraries wanting the info have their own
syspref.

conclusion: FAUSP leader striked again ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8130] attach PDF files to a patron record

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
Version|master  |rel_3_10

--- Comment #32 from Paul Poulain paul.poul...@biblibre.com ---
follow-ups pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8130] attach PDF files to a patron record

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #123 from Paul Poulain paul.poul...@biblibre.com ---
seems there's something wrong with -- comment at table level

I applied all those patches, then tried to load kohastructure.sql, and got a
nasty:
ERROR 1064 (42000) at line 2737: You have an error in your SQL syntax; check
the manual that corresponds to your MySQL server version for the right syntax
to use near '--information related to the basket line items
  `ordernumber` int(11) NOT NULL ' at line 1

which is:
DROP TABLE IF EXISTS `aqorders`;
CREATE TABLE `aqorders` ( --information related to the basket line items
  `ordernumber` int(11) NOT NULL auto_increment, -- primary key and unique
identifier assigned by Koha to each li ne

seems mySQL don't like the --SOMETHING without space: after adding a space:
CREATE TABLE `aqorders` ( -- information related to the basket line items

things are OK

signed off, passed QA and pushed in master branch all in one go.

Thx for your hard work Nicole !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7420] Add max fines to circulation matrix

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420

--- Comment #30 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 11083
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11083action=edit
Bug 7420 tiny follow-up, mysql want a space after the --

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #10789|0   |1
is obsolete||
  Attachment #10790|0   |1
is obsolete||
  Attachment #10791|0   |1
is obsolete||
  Attachment #10792|0   |1
is obsolete||
  Attachment #10793|0   |1
is obsolete||
  Attachment #10794|0   |1
is obsolete||
  Attachment #10795|0   |1
is obsolete||
  Attachment #10822|0   |1
is obsolete||
  Attachment #10823|0   |1
is obsolete||
  Attachment #10824|0   |1
is obsolete||
  Attachment #10832|0   |1
is obsolete||
  Attachment #10833|0   |1
is obsolete||
  Attachment #10942|0   |1
is obsolete||
  Attachment #10970|0   |1
is obsolete||
  Attachment #10975|0   |1
is obsolete||
  Attachment #11019|0   |1
is obsolete||
  Attachment #11020|0   |1
is obsolete||
  Attachment #11021|0   |1
is obsolete||
  Attachment #11022|0   |1
is obsolete||
  Attachment #11023|0   |1
is obsolete||

--- Comment #124 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 11084
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11084action=edit
Bug 6716 tiny follow-up, mysql want a space after the --

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6716] Database Documentation

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #11084|0   |1
is obsolete||

--- Comment #125 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 11084
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11084
Bug 6716 tiny follow-up, mysql want a space after the --

this patch has been pushed, with many others, (on master branch directly)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8476] Little bug in OPAC XSLT on OPACURLOpenInNewWindow

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8476

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7889] Use standard style for errors and messages

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889

--- Comment #11 from Owen Leonard oleon...@myacpl.org ---
Created attachment 11085
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11085action=edit
Bug 7889 - Use standard style for errors and messages

Correcting the markup of error messages in three places:
catalogue merge, CSV profile editing, and opac comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7889] Use standard style for errors and messages

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED
Version|rel_3_10|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7889] Use standard style for errors and messages

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7889

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8163] Click to populate XSLT preferences with default or empty values

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Attachment #9840|0   |1
is obsolete||

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
Created attachment 11086
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11086action=edit
Bug 8163 [REVISED] Click to populate XSLT preferences with default or empty
values

This patch adds markup and JavaScript to the system preferences
interface so that the user can click default or empty to populate
an XSLT-related pref with those vaules.

To test, open system preferences for the OPAC or staff client. In
the description for an XSLT-related preference click the default
link to populate the field with default. Click the leave empty
link to empty the field.

Revised according to Julian Maurice's suggestion for a more
generic, flexible way to implement it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4048] CSS and JS libs must be outside of translated paths

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #13 from Owen Leonard oleon...@myacpl.org ---
Revised again following major changes to jQuery and YUI assets. The correction
in Julian's first patch has been incorporated. Yet another updated branch here:
http://gitorious.org/koha-dev/koha-dev/commits/ip-bug-4048-css-js-libs-2012-04-24

This patch is an attempt to tackle Bug 4048 in a more incremental
way. As suggested by Paul, this patch leaves in place a copy of
the CSS and JS files in their original location to allow
full implementation to be gradual.

1. Template.pm has been modified to pass an interface variable
   to the templates so that references to [% themelang %] can be
   replaced with [% interface %]/[% theme %] (intranet-tmpl/prog)
   where appropriate.

2. The staff client's css, js, and lib directories have been
   'git mv'ed to intanet-tmpl/prog where the img directory is.
   'git mv' was used to preserve the git history of the files
   which are in their correct location.

3. The staff client's css, js, and lib directories have been
   copied back to their original location in order to provide
   a fallback as we make corrections to individual templates.
   These files have lost their git history, but will ultimately
   be deleted anyway.

4. The staff client's primary document header include files have
   been updated with the new paths. These are the files that
   define the paths to all the core CSS and JS files.

5. Relative image paths in the moved CSS files have been corrected to
   point to the right directory.

TO TEST:

After applying the patch, look at any page in the staff client.
If the CSS paths are correct everything should look normal. View
source to confirm that core assets are being pulled from the new
location. If you use Firefox and have Firebug enabled it should
report no NetworkError: 404 errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4048] CSS and JS libs must be outside of translated paths

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Attachment #9587|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8253] Fine doubling

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #10405|0   |1
is obsolete||
  Attachment #10436|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11087
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11087action=edit
Bug 8253 - Fine doubling

This issue only occurs when upgrading from pre-3.8 to post 3.8 Koha.

The issue is caused by the change from dates to datetimes that was
neccesary to implement hourly loans. All pre-3.8 fines have the date
in the description. This date is how the fines script know which fine
to update. If the fine script does not locate an existing row to update,
it creates a new row.

The switch from dates to datetimes means the fines script now looks
for a format such as '-MM-DD 00:00' ( for iso ), but all the previous
fines are still in the format '-MM-DD' and so it fails to find
the matching row, and creates a new row instead.

This commit consists of a database update that alters the dates
in the accountlines description field to be datetimes instead. This
eliminates future fine doubling. It is also safe to run on a system
that has been previously upgraded, it will ignore any rows where
the date is already of the format '-MM-DD HH:MM' ( or whichever
date format you have chosen ).

The second part of this update will remove any existing duplicate fines
that have been created as a result of this error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #10799|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11088
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11088action=edit
Bug 8431 - Increase the borrower attribute field size from 64 characters to 255

Some libraries would like to store more verbose data in a borrower attribute
field.
This commit increases the maximum length of a borrower attribute from 64
characters
to 255 characters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Attachment #9384|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11089
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11089action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl

Adds a column to indicate holds on recieved items, as well as adding
a new column for fund and showing the subtotals per fund above
the total subtotal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7901] Add batch delete borrowers script

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Attachment #8914|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11090
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11090action=edit
Bug 7901 - Add batch delete borrowers script

Simple script that takes a file of borrower
cardnumbers and deletes those borrowers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7901] Add batch delete borrowers script

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #10149|0   |1
is obsolete||

--- Comment #37 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11091
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11091action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11091|0   |1
is obsolete||

--- Comment #38 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11092
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11092action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a Home Library column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
Location column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

http://bugs.koha-community.org/show_bug.cgi?id=7220

http://bugs.koha-community.org/show_bug.cgi?id=3556

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701

--- Comment #17 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #16)
 QA comment:
 
 The code now says
  ShelfToCart( $item-{'itemnumber'} );
 = shouldn't we deal with the syspref and say
 ShelfToCart( $item-{'itemnumber'} ) if
 C4::Context-preference(ReturnToShelvingCart);
 ?

You are right, I'll fix that.

 2nd question: when the item reaches it's homebranch, a check-in is done,
 right ?
 I tried that, and the location stayed to 'CART' instead of being switched
 back to items.permanentlocation.

Yes, a check-in is done, but that sets the location to 'CART' if it is not
already set. Later, the cronjob will change the status from 'CART' back to the
item's permanent location.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #10908|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11093
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11093action=edit
BugFix - ReturnToShelvingCart

If the ReturnToShelvingCart syspref is on, and something needs to go in
transit,
the shelving cart setting is overriding the transit.

What seems to be happening is this:
  * Item is checked in, and flagged as needing to go in transit from A to B.
  * Item is immediately flagged as shelving cart, though.  Current display says
both shelving cart and in transit.
  * After the cart-to-shelf script runs, item comes out of transit and
shows as being available at the destination library, although it hasn't
arrived yet and no one has manually checked it in.

http://bugs.koha-community.org/show_bug.cgi?id=3701

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8492] New: Restrict OpacSuppression to IP adresses outside of an IP range

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8492
  Assignee: 5...@gmx.de
   Summary: Restrict OpacSuppression to IP adresses outside of an
IP range
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: 5...@gmx.de
  Hardware: All
Status: NEW
   Version: master
 Component: Searching
   Product: Koha

This enhancement extends the OpacSuppression feature with an optional IP
address range within which results are _not_ suppressed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492

--- Comment #1 from Mirko Tietgen 5...@gmx.de ---
Created attachment 11094
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11094action=edit
Bug 8492 [ENH] Restrict OpacSuppression to IP adresses outside of an IP range

This enhancement extends the OpacSuppression feature with an optional IP
address range within which results are _not_ suppressed.

To test

* turn on OpacSuppression (Administration-System preferences-Cataloging) and
enter an IP address range in the OpacSuppressionByIPRange field.
* set at least one bibliographic record to suppress=1 (enter '1' in 942$n)
* fully reindex your data
* do an OPAC search that should bring up your suppressed record
* try with IP ranges that match your IP and ranges that don't

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492

Mirko Tietgen 5...@gmx.de changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

--- Comment #41 from Srdjan Jankovic srd...@catalyst.net.nz ---
Created attachment 11095
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11095action=edit
bug_5911: Javascript and error messages corrections

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8493] New: improve verbosity output of rebuild_zebra.pl script

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8493

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8493
  Assignee: gmcha...@gmail.com
   Summary: improve verbosity output of rebuild_zebra.pl script
  Severity: trivial
Classification: Unclassified
OS: All
  Reporter: m...@kohaaloha.com
  Hardware: All
Status: NEW
   Version: master
 Component: Command-line Utilities
   Product: Koha

currently the output behaviour of this script is a little broken
you either get no output, or too much output

this patch introduces 2 levels of verbosity

this patch will increase peoples ability to debug zebra indexing problems 
by eliminating many needless lines of ...


1...101.201.301.401.501.601.701.801.901.100111011201..
 
..130114011501..


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

--- Comment #42 from Srdjan Jankovic srd...@catalyst.net.nz ---
Created attachment 11096
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11096action=edit
[PATCH] bug_5911: Transport Cost Matrix

I am deeply ashamed but I did not know how to squash those previous commits. I
can list what I tried to provide some entertainment if you wish.
Instead, I am providing a full patch.
If anyone can help with some instructions I would appreciate.

So the latest fix is Javascript and error messages corrections, and one after
is the full patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs

2012-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

--- Comment #40 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to comment #39)
 mmm... either I missed something, either some parts of this patch must still
 be removed.
 Now, with bug 4032, each library has the opportunity to have his own XSLT.
 So, I think that:
  * the XSLT.pm part is OK = we must send the datas to the XSLT
  * the XSLT update is OK = provide the information in the default XSLT
  * the systempreference is KO = if a library don't want the shelving
 location, let's change the XSLT (please don't say it's harder to update a
 XSLT than updating a syspref, that's the case for any display change: some
 libraries want the barcode, some don't)
 
 I -strongly- think providing the info by default is better. If you think
 it's not, then just update XSLT.pm and let libraries wanting the info have
 their own syspref.
 
I disagree strongly.

The convention is always don't change the behaviour people are used to, but let
them switch a syspref to change it. This we have done for ever. 
I see no reason to change it because one person doesn't like system
preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >