[Koha-bugs] [Bug 8653] With DOM indexing turned on subject authority links are not indexed

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #11646|0   |1
is obsolete||

--- Comment #3 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 11655
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11655action=edit
Revised Patch

Earlier patch omitted the biblio-zebra-indexdefs.xsl - This has been included

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5343] Subscription cost

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
 Depends on||5335

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5335] More granular VAT

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||5343

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5343] Subscription cost

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|henridam...@koha-fr.org |jonathan.dru...@biblibre.co
   ||m

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
This patch will allow to create a new order from a subscription.

It is currently blocked by Bug 5335.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690

--- Comment #3 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #2)
 Is this still a problem?I can't reproduce it and also if we're going to
 remove hidelostitems
 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619) do we need
 this patch?

Yes it is still a problem, this bug concerns hidelostitems but also
OpacHiddenItems behavior.

I forgot : to reproduce the but, hidden items must be unavailable (on loan,
damaged, not for loan ...).

Tell me if you need a better test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7167] updatedatabase improvements

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7993] saved report with hierarchies

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993

claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om
   Assignee|gmcha...@gmail.com  |srd...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6858] Adds staticfines.pl for static fines processing

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6858

--- Comment #30 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Hi Viktor,

Perhaps you could create another ticket for the enhancements you'd like to
have, so we can close this ticket, as the patch has already been pushed ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7993] saved report with hierarchies

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #10618|0   |1
is obsolete||

--- Comment #4 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 11656
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11656action=edit
[SIGNED-OFF] Bug 7993: Save reports with Group/Subgroup hierarchy

This should make saved reports more manageable.
Group/Subgroup hierarchy is stored in authorised_values,
categories REPORT_GROUP and REPORT_SUBGROUP, connected by
REPORT_SUBGROUP.lib_opac - REPORT_GROUP.authorised_value

Database changes:
* authorised_values: expanded category to 16 chars
* created default set of REPORT_GROUP authorised values to match
  hardcoded report areas
* reports_dictionary: replaced area int with report_area text, converted
  values
* saved_sql: added report_area, report_group and report_subgroup;
  report_area is not currently used, saved for the record

C4/Reports/Guided.pm:
* Replaced Area numeric values with the mnemonic codes
* get_report_areas(): returns hardcoded areas list
* created get_report_areas(): returns full hierarchy (groups with belonging
  subgroups)
* save_report(): changed iterface, accepts fields hashref as input
* update_sql(): changed iterface, accepts id and fields hashref as input
* get_saved_reports():]
- join to authorised_values to pick group and subgroup name
- accept group and subgroup filter params
* get_saved_report():
- changed iterface, return record hashref
- join to authorised_values to pick group and subgroup name
* build_authorised_value_list(): new sub, moved code from
  reports/guided_reports.pl
* Updated interfaces in:
cronjobs/runreport.pl, svc/report, opac/svc/report: get_saved_report()
reports/dictionary.pl: get_report_areas()
reports/guided_reports.pl

reports/guided_reports_start.tt:
* Reports list:
- added group/subgroup filter
- display area/group/subgroup for the reports
* Create report wizard:
- carry area to the end
- select group and subgroup when saving the report; group defaults to area,
  useful when report groups match areas
* Update report and Create from SQL: added group/subgroup
* Amended reports/guided_reports.pl accordingly

Conflicts:

C4/Reports/Guided.pm
admin/authorised_values.pl
installer/data/mysql/kohastructure.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl
misc/cronjobs/runreport.pl
reports/dictionary.pl
reports/guided_reports.pl

Rebased 2012/07/02 by Jared Camins-Esakov

Signed-off-by: Julian Maurice julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7993] saved report with hierarchies

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #5 from Julian Maurice julian.maur...@biblibre.com ---
Patch rebased on current master and tested OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163

Bug 7163 depends on bug 7303, which changed state.

Bug 7303 Summary: Not being able to create funds with the same name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7303

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7303] Not being able to create funds with the same name

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7303

claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |INVALID

--- Comment #9 from claire.hernan...@biblibre.com 
claire.hernan...@biblibre.com ---
The feature asked by the customer cannot be rebased like this in the community
version.

Technically it is not possible to have a constraint on the fund code or name.
Usability point of view, each time a user adds a new fund with an existant code
koha will asked him are you sure... (could be another bz).

The initial patch adds nothing pertinent in the community version and breaks
another wanted feature (duplicate budget hierarchy) so I will close it.


(In reply to comment #8)
 Hi Jonathan and all,
 
 I still think a unique key on aqbudgets.budget_name and
 aqbudgets.budget_code it's a bad idea and will break workflows for libraries.
 
 1) The aqbudgets table already has a primary key (budget_id) as has
 aqbudgetperiods (budget_period_id).
  
 2) It will make it impossible to duplicate your budget hierarchy for the
 next year which is a working feature in master.
 
 3) A feature I am asked for is a way to move orders and money from one year
 to the next. I think if it's allowed to use the same codes, this is very
 easy to do - but if you are forced to change them each year, you will need
 some tool for mapping funds over several years.
 
 4) The codes libraries here use do not change with each year - you would
 force them to add a prefix/suffix or something similar. This would make
 their life harder, for example when they need reports with the official
 codes and descriptions.
 
 5) It's currently not enforced - I think the update database will not work?
 
 If this is only a check for libraries editing/adding new funds, couldn't we
 make it only check for duplicates in the same time period/budget? And a way
 to overwrite if it's intended?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7029] searching : fuzzy et steming

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029

delaye stephane.del...@biblibre.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #2 from delaye stephane.del...@biblibre.com ---
in the relase 3.8.2

i have the same problem

when i search the terme 'chien' koha display the bib. notice about the 'chine'

i test with the systeme preference 
QueryFuzzy  disabled or not desabled

and
 QueryStemming lemmatise or / not lemmatise

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comments:

All seems good.
But I have 2 questions :)
Why did you create the test file into the db_dependent directory ?
And could you explain me (quickly) what is the use of the \G assertion ? I read
the doc but I did not understand :-/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594

--- Comment #7 from Robin Sheat ro...@catalyst.net.nz ---
1) The Reports::Guided module looks like it's database dependant when it
initialises.

2) \G starts a search from the location that a previous search finished. In
this case, it first looks for 'WHERE', and then starts the search to do the
replacing from that point, and not the start of the string.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #7)
 1) The Reports::Guided module looks like it's database dependant when it
 initialises.
 
 2) \G starts a search from the location that a previous search finished. In
 this case, it first looks for 'WHERE', and then starts the search to do the
 replacing from that point, and not the start of the string.

Ok, thank you Robin !
Marked as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7993] saved report with hierarchies

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comments:
The qa tools says me the patch introduces wrong lines in a tt file:
- xt/tt_valid.t tests... FAIL
intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt: 520, 610,
727, 828 FAIL

See Bug 8407 for more information.

Please correct this and remove some useless commented lines (in opac/svc/report
: else{warn})

Marked as Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8626] Encoding problem with = in cart emails

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comments:
It seems the good way to do that (already used in basket/sendbasket.pl,
opac/opac-sendshelf.pl and virtualshelves/sendshelf.pl).
Marked as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6494] opacmysummaryhtml on reading history

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6494

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comment:

If you think the syspref's name is definitely correct, it's ok for me.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8646] Certain search terms cause browser script taking too long error

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8646

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11657
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11657action=edit
Bug 8215 - Add Course Reserves - Followup - Fix DB Updater  Makefile

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #10)

Thanks for the feedback! I've submitted a followup patch that should resolve
your problems. I was able to successfully run the db updater from the command
line, and I've also added the directory to the Makefile. Thanks again.

Kyle

 I tried again with.  Bug 8215 - Add Course Reserves 
 I'm doing  a standard install.
...
 I was able to access the Course Reserves from the staff interface.
 
 But, without the tables...
 
 wajasu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613

--- Comment #36 from D Ruth Bavousett r...@bywatersolutions.com ---
Srdjan,

The change was not merely aesthetic; I was unable to make pure-XML requests
such as the new_bib functionality work when using the OCLC Connexion
Web--working but different than planned when planned doesn't work, implies a
flawed plan.

The new_bib functionality doesn't take into account the desired settings for
overlay, matching, etc; it just does a brute-force AddBiblio. The Connexion
listener provides for setting up values for overlay, matching, item processing,
and default framework, so making import_bib *not* be a drop-in replacement here
is quite okay; it actually allows the Connexion listener to work as designed.

If new_bib works, well, that's fine. I haven't tested that, so don't *know* if
this will be a desirable replacement--but I *do* know, through rather a lot of
testing, that import_bib as fixed in this patch, does.  (and, as you mentioned,
properly encoded, which is a plus, and also taking into account the settings
from the listener's config file.)

Aside, probably relevant to testing:

OCLC Connexion Web and the OCLC Connexion Client are two entirely different
animals--they send the data differently, and their behavior after doing so is
different as well.  Connexion Web sends the data blindly, and says, okay, I
did it, pretty-much regardless of what is going on in the Koha end--even if
the service is *not turned on*.  The Connexion Desktop Client, however,
actually initiates a connection to the Koha system, confirms the functionality,
knows to log in and what will happen if it can't, and waits for an answer from
the Koha end to make sure the record was added.  Much superior, which is why
the sponsoring libraries are *NOT* using Connexion Web.

Nonetheless, I wanted this to actually work for both.  And now it does.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8646] Certain search terms cause browser script taking too long error

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8646

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11658
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11658action=edit
Bug 8646 - prevent the highlighter from going infinite loop

On certain search queries, for example
http://koha-intra/cgi-bin/koha/catalogue/search.pl?kw=idxq=ti:book%20
the highlighter starts going into an infinite loop until the browser
decides to kill it.

This patch prevents the bad input going to the highlighter.

It also includes the fix on the OPAC, even though the issue doesn't come
up there. Better to be safe...

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8646] Certain search terms cause browser script taking too long error

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8646

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Works as expected.

I fixed that (in BibLibre repo) with:
 function highlightOn() {
 var x;
 for (x in q_array) {
-$(p).highlight(q_array[x]);
+if ( q_array[x].length  0 ) {
+$(p).highlight(q_array[x]);
+}
 }
 $(.highlight_toggle).toggle();
 }

But your patch looks good too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8253] Fine doubling

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253

--- Comment #13 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #12)

Julian,
  I think I understand why this isn't working for you. When I wrote this patch,
Koha also had the bug where it was using '00:00' instead of '23:59' for the
hour/minutes portion. In that case, this would work just fine.

Perhaps we need to make this delete all lines matching 'Orchidées 06/01/2012',
but instead of not matching on 'Orchidées 06/01/2012 23:59, we use the
timestamp of the keeper instead.

So, instead of 

SELECT * FROM accountlines WHERE description LIKE $truncated_description AND
description NOT LIKE $full_description

We would use

SELECT * FROM accountlines WHERE description LIKE $truncated_description AND
timestamp NOT LIKE $keepers_timestamp

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8012] defaultSortOrder and OPACdefaultSortOrder are set to ascending on install

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8012

D Ruth Bavousett r...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |r...@bywatersolutions.com

--- Comment #2 from D Ruth Bavousett r...@bywatersolutions.com ---
Created attachment 11659
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11659action=edit
Proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8012] defaultSortOrder and OPACdefaultSortOrder are set to ascending on install

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8012

D Ruth Bavousett r...@bywatersolutions.com changed:

   What|Removed |Added

Version|rel_3_8 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8253] Fine doubling

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11660
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11660action=edit
Bug 8253 - Fine doubling - Followup

Use timestamp as the 'un-matcher' rather than the fine description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690

--- Comment #4 from Nicole C. Engard neng...@gmail.com ---
I had lost items hidden in the opac and then did a search with XSLT turned off
and lost items were hidden without this patch. A lost item won't be checked out
in most cases, so the item was not checked out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613

Jane Wagner jwag...@ptfs.com changed:

   What|Removed |Added

 CC||jwag...@ptfs.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7294] status in order

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #10745|0   |1
is obsolete||

--- Comment #33 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11661
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11661action=edit
Bug 7294: Adds acquisition informations in marc record

View status 'in order' to the OPAC and staff interface. Specific
fields from aqorders can be mapped to marc fields (using ACQ bibliographic
framework):
aqorders.branchcode
aqorders.quantity
aqorders.listprice
aqorders.uncertainprice
aqorders.rrp
aqorders.ecost
aqorders.notes
aqorders.supplierreference
aqorders.ordernumber

This way, you can keep track on what is currently on order
at biblio level until you receive everything. Once all items have been
received, the marc field is deleted.

Please note that mapping the ordernumber is mandatory for this feature to work

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7294] status in order

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #34 from Kyle M Hall k...@bywatersolutions.com ---
Followed the test plan. Feature works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690

--- Comment #5 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
On my test environment (master revision and sandbox 2 database), I reproduce
the bug.
hilelostitems is active. With 1 item available and 1 lost (itemlost=1), I get :
Availability: Copies available: Le Cannet (1), Lost (1).

Result page gets items from Zebra so after editing an item, don't forget to
rebuild.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8430] Display of old/expired subscriptions

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8430

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||julian.maur...@biblibre.com
 Resolution|--- |WONTFIX

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
This development is not useful anymore, since there are filters on expiration
date in serials/serials-home.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5335] More granular VAT

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11351|0   |1
is obsolete||

--- Comment #42 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11662
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11662action=edit
Bug 5335 - More granular VAT

Signed-off-by: Pierre Angot tredok.pie...@gmail.com
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8654] New: DataTables in Acquisition module: aqbudgetperiods.tt

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8654

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8654
  Assignee: julian.maur...@biblibre.com
   Summary: DataTables in Acquisition module: aqbudgetperiods.tt
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: julian.maur...@biblibre.com
  Hardware: All
Status: ASSIGNED
   Version: master
 Component: Acquisitions
   Product: Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8654] DataTables in Acquisition module: aqbudgetperiods.tt

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8654

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 11663
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11663action=edit
Bug 8654: Replace tablesorter by datatables in aqbudgetperiods.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8654] DataTables in Acquisition module: aqbudgetperiods.tt

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8654

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1111] Order and Basket, two names for the same thing?

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11664
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11664action=edit
Test Patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #10 from Ian Walls koha.sek...@gmail.com ---
Reimplements search as server-side, rather than client side with Javascript and
JSON, so two large chunks of code are removed.

Changes to GetPendingOrders function are clear and safe; new parameters are
added at the end, so existing function calls do not need to be changed, and
while $booksellerid is renamed to $supplierid internally, it's kept consistent
within the function.

POD for GetPendingOrders is updated, but the new parameters are not
sufficiently described.  Please provide more details on what these parameters
actually do (a followup patch would be appropriate for this).

Furthermore, unit tests should be expanded to cover the addition of the new
filter options.  A followup can be provided for this, as well.

I'm still defrosting after a long absence, so all my tests are not yet working
for other reasons, but to the best of my knowledge, this patch is safe and can
pass QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1111] Order and Basket, two names for the same thing?

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Assignee|paul.poul...@biblibre.com   |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1111] Order and Basket, two names for the same thing?

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11665
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11665action=edit
Test Patch 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1111] Order and Basket, two names for the same thing?

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11665|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1111] Order and Basket, two names for the same thing?

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11664|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11666
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11666action=edit
Test Patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1111] Order and Basket, two names for the same thing?

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11666|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11667
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11667action=edit
Test Patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5335] More granular VAT

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335

--- Comment #44 from Joy Nelson j...@bywatersolutions.com ---
Created attachment 11669
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11669action=edit
Bug 5335 - More granular VAT

Signed-off-by: Pierre Angot tredok.pie...@gmail.com
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Joy Nelson j...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1111] Order and Basket, two names for the same thing?

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11667|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 11670
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11670action=edit
Test Patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8607] overdue_notices is broken

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8607

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #5 from Ian Walls koha.sek...@gmail.com ---
Replaces single quotes with double quotes so interpolation will work.  Marking
Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8596] Reports interface date picker doesn't force ISO formatted dates

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #3 from Ian Walls koha.sek...@gmail.com ---
Adds date formatting according to datepicker's conventions (which do -mm-dd
even though it says yy-mm-dd).

Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8621] Template for sending out carts not formatting correctly

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8621

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #8 from Ian Walls koha.sek...@gmail.com ---
Template only change, fixing indenting and other issues.  Easy to read, passed
QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #14 from Ian Walls koha.sek...@gmail.com ---
1st patch:  just increases size of field in new and upgraded installs.  Passed
QA

2nd patch:  changes input to text area to accomodate new size.  Passed QA

3rd patch:  jQuery consolidation of input clearing.  Passed QA.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #11 from Ian Walls koha.sek...@gmail.com ---
Adds a couple small cookies for stickiness, and some logic to handle them. 
Followup patch fixes conditional nesting.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #11347|0   |1
is obsolete||

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
Created attachment 11671
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11671action=edit
[SIGNED-OFF] Bug 8570 - Add pagination to the Z39.50 results page

Add paginations to the Z39.50 search results.

http://bugs.koha-community.org/show_bug.cgi?id=8570
Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6281] Bug in LCC sort routine

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|rel_3_2 |master
   Assignee|paul.poul...@biblibre.com   |gmcha...@gmail.com

--- Comment #1 from Galen Charlton gmcha...@gmail.com ---
I'm taking this on now.  A work-in-progress branch that replaces the current
sort routine with one using Library::CallNumber::LC can be found at

https://github.com/gmcharlt/koha-test/commits/fix_lcc_cn_sort

Additional examples for the test case would be welcome.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6281] Bug in LCC sort routine

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281

Jane Wagner jwag...@ptfs.com changed:

   What|Removed |Added

 CC||jwag...@ptfs.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8607] overdue_notices is broken

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8607

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613

Tom tskohabugzi...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||tskohabugzi...@gmail.com

--- Comment #37 from Tom tskohabugzi...@gmail.com ---
As one of the library's that sponsored development of Koha functionality to
import bibliographic records directly from OCLC's Connexion application, I
would like to inform the community that the patch has been used in production
in our library for roughly 45 days.  We consider the patch well-tested and it
functions properly.  Below are a few comments:

We use it daily and it works well for the way we use it.  We use it to
directly import bibliographic records from OCLC's Connexion application's
Gateway Export.  We do not examine or manually manage the resevoir, rather we
let this new development totally import the records.

We only use OCLC's Connexion client software so this is the OCLC Connexion
product we tested with.  We did not test Koha (the patch) with or use it with
OCLC's web version of the software.  

Of course when the patch is integrated into the stable Koha code, it will need
documentation for the configuration and use.

In closing, we (Preston Library - Virginia Military Institute) would like to
sign-off/indicate that the patch was well tested at our library for the client
version of Connexion.  If we need to do this more formally, please let me know
what I need to do to sign off on it.
Tom

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #10204|0   |1
is obsolete||

--- Comment #26 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 11672
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11672action=edit
Updated Patch

Had to update this for an upgraded site. Have merged all the separate patches
to one and updated it to be applicable to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8646] Certain search terms cause browser script taking too long error

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8646

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #4 from Ian Walls koha.sek...@gmail.com ---
Drops empty strings are the end of the array in order to prevent infinite
loops.  Template only change in JS.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1111] Order and Basket, two names for the same thing?

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11670|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #14 from Ian Walls koha.sek...@gmail.com ---
First two patches are template only changes adding IDs to tags.  Marking them
Passed QA.  The debate of what CSS styling to do with them can be resolved
separately.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8525] Highlight matches on details page

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #6 from Ian Walls koha.sek...@gmail.com ---
Template only changes (except for the addition of a new template param in the
perl file) to allow highlighting on the details page.  Marking as Passed QA,
both primary and followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4324] Let's tangoify Koha

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4324

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #38 from Ian Walls koha.sek...@gmail.com ---
Fixes the daemon and svc import mechanism to actually work, and since this is
in production live for a library that relies on the functionality day to day,
I'm inclined to believe this is a solid improvement.  Again, as it does not
impact the rest of Koha, these changes are safe and Pass QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8496] show local cover images on lists view in opac

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||koha.sek...@gmail.com

--- Comment #3 from Ian Walls koha.sek...@gmail.com ---
Template only change to add support for missing cover image sources.  marking
Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8655] New: Re-order items on administration page to better match configuration priority

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8655

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8655
  Assignee: oleon...@myacpl.org
   Summary: Re-order items on administration page to better match
configuration priority
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: oleon...@myacpl.org
  Hardware: All
Status: ASSIGNED
   Version: master
 Component: Templates
   Product: Koha

The administration home page says Configure these parameters in the order they
appear, but cities and road types appear before circulation and fine rules.
Circ rules have a higher priority.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4476] Improve clarity and usability of issuing rules interface

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4476

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5688] OPAC My Summary tab fines column doesn't display accruing fines

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5688

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||kyle.m.h...@gmail.com
  Component|OPAC|Patrons
Version|rel_3_4 |master
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
 QA Contact|koha-b...@lists.koha-commun |
   |ity.org |
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

Joy Nelson j...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||j...@bywatersolutions.com

--- Comment #20 from Joy Nelson j...@bywatersolutions.com ---
Marking as Does Not Apply

Auto-merging opac/opac-reserve.pl
CONFLICT (content): Merge conflict in opac/opac-reserve.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 6976 Close loophole allowing borrowers extra holds

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

Joy Nelson j...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||j...@bywatersolutions.com

--- Comment #41 from Joy Nelson j...@bywatersolutions.com ---
I was able to apply this patch (a merge conflict with updatedatabase.pl to
resolve first)

In testing, the maxreserves value was set to 9.  

I was not able to place holds for over 9 items.  
I was not able to place holds for exactly 9 items.
I could place holds for 8 items.

I attempted to place a hold on one more item and received two messages on one
screen:

message1:
Sorry, you cannot place holds on all these items. You can only place 1 more
hold(s). Please choose the items you wish to be held.

message2:
Sorry, none of these items can be placed on hold.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4324] Let's tangoify Koha

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4324

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||m...@kohaaloha.com
 Resolution|WONTFIX |---

--- Comment #1 from Mason James m...@kohaaloha.com ---
why change bug status to WONTFIX?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7295] list of librarian managing a basket

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295

Melia Meggs me...@bywatersolutions.com changed:

   What|Removed |Added

 CC||me...@bywatersolutions.com

--- Comment #12 from Melia Meggs me...@bywatersolutions.com ---
I am trying to test this patch but have a few questions.

With superlibrarian permissions and AcqViewBasket set to Show baskets in
system, regardless of owner, I get a message in red telling me that I am not
authorized to access BasketA.  I tried it logged in from the branch that
matches the basket, as well as logged in from a different branch, but I get the
same message either way.  I expected to be able to see and manage all baskets
with these permissions... Am I missing something?

Also, some of the acq permissions seem a little bit confusing to me:

 order_manage  - Manage orders  basket
 order_receive - Manage orders  basket

These two permissions have the exact same description.  Do I need them both to
be able to manage baskets?

 order_manage_all - Manage all orders and baskets, regardless of restrictions
on them

Would this one override the AcqViewBasket sys pref?  For example, if I have the
order_manage_all permission, but AcqViewBasket is set to Show baskets from
staff member's library, should I be able to see and manage ALL baskets, or
only see and manage the baskets from my library?  What if AcqViewBasket is set
to Show baskets in system, regardless of owner but the order_manage_all
permission is not checked?  What should happen then?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||m...@kohaaloha.com

--- Comment #8 from Mason James m...@kohaaloha.com ---
(In reply to comment #7)
 Created attachment 11582 [details]
 Bug 8623: Move YUI out of prog
 
 This patch moves the YUI assets from koha-tmpl/opac-tmpl/prog/en/lib/yui
 to koha-tmpl/opac-tmpl/lib/yui.
 
 NOTE: This was tested on Chrome, FF, and Safari on a Mac, and IE and FF
 on Windows.
 
 To test:
 1) View a smattering of pages on the OPAC and intranet. If the move
did not work flawlessly, layout will be way off.
 
 Signed-off-by: Kyle M Hall k...@bywatersolutions.com

QA comments
patch wont apply against master '322a9c7fbbcf456084d1937f48345b3cdec058ce'

please resend a patch that applies against master


---
mason@xen1:~/git/head-clean$ gl |head -1
commit 322a9c7fbbcf456084d1937f48345b3cdec058ce

mason@xen1:~/git/head-clean$ git bz apply 8623
Bug 8623 - Javascript libraries should be outside theme directories

Bug 8623: Do not accept lib as a valid theme
Apply? [yn] y

Applying: Bug 8623: Do not accept lib as a valid theme
Bug 8623: Move YUI out of prog
Apply? [yn] y

Applying: Bug 8623: Move YUI out of prog
fatal: sha1 information is lacking or useless (C4/Templates.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 8623: Move YUI out of prog
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Patch left in /tmp/Bug-8623-Move-YUI-out-of-prog-DVU7vK.patch

---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623

--- Comment #9 from Mason James m...@kohaaloha.com ---

 please resend a patch that applies against master
 

... or explain a suitable method to apply the patch successfully
(which i might be missing)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8637] Lack of control on mandatory in orderreveive.tt

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #11639|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 11673
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11673action=edit
Bug 8637: Lack of control on mandatory in orderreveive.tt

Just add a check in Jscript when the form is submited, the same as in
additem.tt
On Owen's suggestion I have added the red color and 'Required', the same as in
additem.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8637] Lack of control on mandatory in orderreveive.tt

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Works as described, signing off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8653] With DOM indexing turned on subject authority links are not indexed

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #11655|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 11674
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11674action=edit
Bug 8653 remove erroneous whitespace blocking indexing

The superfluous whitespace after the definition of subject
tag $9s is causing an error when carried over into dom config
files so that the authority links fail to index

Also removed the (harmless) trailing space in the equivalent
Unimarc files

A good editor and git can help in not creating excess whitespace

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8653] With DOM indexing turned on subject authority links are not indexed

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8012] defaultSortOrder and OPACdefaultSortOrder are set to ascending on install

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8012

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #11659|0   |1
is obsolete||

--- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 11675
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11675action=edit
Bug 8012: default values for defaultSortField/defaultSortOrder NULL on install

...which *looks* like relevance/ascending in the staff client, which doesn't
make sense.
This patch initializes the values at relevance/descending, which is a
functional
combination.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8012] defaultSortOrder and OPACdefaultSortOrder are set to ascending on install

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8012

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #11672|0   |1
is obsolete||

--- Comment #27 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 11676
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11676action=edit
Bug 7751: Decrease Loans for Items in Demand for Holds

Rebase and merge based on Mark Gavillet's patch to reduce
the loan period given to items on renewal when they are
in high demand for holds

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/



[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #13 from wajasu matted-34...@mypacks.net ---
Created attachment 11677
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11677action=edit
course_reserves_new_course.png

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

wajasu matted-34...@mypacks.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #14 from wajasu matted-34...@mypacks.net ---
OK. Now we are moving somewhere.  I applied these with no problem.
 Bug 8215 - Add Course Reserves
 Bug 8215 - Add Course Reserves - Followup - Fix DB Updater  Makefile
The updatedatabase.pl ran fine.

The things with a plus at the left I did.  I've attached snapshots of various
places in the workflow. (nice workflow)
Testing Scenario:
+ 1) Create new authorised value categories DEPARTMENT and TERM
  2) Create a new course, add instructors to that course.
+ create a new course (but without instructor)
- no instructor (added a patron as a teacher. Implemented yet?)
Note: Hitting Enter in instructor field Saves :( let me press the button.
  3) Reserve items for that course, verify item attributes have changed.
+ reserved items ( queried db and saw rows )
? tell me where to look to verify item attributes. I attached some images.
  I see a Course Reserves column with the Course Name in the Holdings tab.
  Is that what you mean?  Or some biblio MARC tag field OR other reserve table. 
  4) Disable course, verify item attributes have reverted.
- I still see the Course Reserves in Item's catalog detail page when course
Inactive
  5) Enable course again, verify item attributes again.
  6) Delete course, verify item attributes again.
+ When delted the Course Reserves column if gone. As is the row in the DB.
  7) Create two new courses, add the same item(s) to both courses.
Note: I can create multiple courses with same name, etc. Whats the primary key
or natural key of this table going to be?
  8) Disable one course, verify item attributes have not reverted.
  9) Disable both courses, verify item attributes have reverted.
 10) Enable one course, verify item attributes are again set to the
 new values.
 11) Edit reserve item attributes, verify.
 12) Disable all courses, edit reserve item attributes, verify
 the item itself still has its original attributes, verify
 the reserve item attributes have been updated.
 13) Verify the ability to remove instructors from a course.
 14) Verify new permissions, top level coursereserves, with
 subpermissions add_reserves and delete_reserves.

I did see all fields being saved in these tables:
course_items
course_reserves
courses

In step #4, I think you need to check for each item's course being enabled=true
to show the course name(s), though at the top of
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
you have the right idea to show the Course Reserves column if any one item is
reserved.

The OPAC seemed fine to browse the course and its reserves.

So we are moving in the right direction, and with a little more clarity on what
verifying item attributes means, after your next patch. With instructors,
things may be in good standing.

I think one we get this signed off, other smaller enhancements/bugs can be
addressed separately.

wajasu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #15 from wajasu matted-34...@mypacks.net ---
Created attachment 11678
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11678action=edit
course_reserves_course_details

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #16 from wajasu matted-34...@mypacks.net ---
Created attachment 11679
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11679action=edit
course_reserves_asfter saving a couple of_courses_distinct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #17 from wajasu matted-34...@mypacks.net ---
Created attachment 11680
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11680action=edit
course_reserves_after adding_a_couple_of_items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #18 from wajasu matted-34...@mypacks.net ---
Created attachment 11681
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11681action=edit
course_reserves_add_items_scan_barcode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-08-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #19 from wajasu matted-34...@mypacks.net ---
Created attachment 11682
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11682action=edit
course_reserves_add_item_to_course

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/