[Koha-bugs] [Bug 8795] New: Just add the login branch In orderreveive.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Priority: P5 - low Change sponsored?: --- Bug ID: 8795 Assignee: koha-bugs@lists.koha-community.org Summary: Just add the login branch In orderreveive.tt Severity: enhancement Classification: Unclassified OS: All Reporter: christophe.croulleb...@biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha The homebranch and holdingbranch ddl in item block are not default selected, they just show the first line. With this patch I just put the default choice as the login branch. To test : without patch the first line of the ddl is shown. With the patch the login branch is shown in homebranch and holdingbranch. thx for testing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5339] Parcel closing in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 --- Comment #86 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 12369 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12369action=edit Bug 5339: Fix t/db_dependant/Acquisition.t replaced booksellerinvoicenumber by invoiceid -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #7) You are correct. The smallest followup ever written has been attached ; ) Thank you Kyle. So I mark it as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7351] ability to edit a range of holidays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois christophe.croulleb...@biblibre.com changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #11845|0 |1 is obsolete|| --- Comment #4 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 12371 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12371action=edit Proposed patch (rebased master) Rebased patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5339] Parcel closing in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #87 from Paul Poulain paul.poul...@biblibre.com --- small Follow-ups tested pushed in one go -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5339] Parcel closing in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5339] Parcel closing in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #20 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 12372 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12372action=edit Bug 8377 [ENH] Followup: Move perl module to C4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10485|0 |1 is obsolete|| --- Comment #163 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10485 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10485 [FAILED-QA]Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm This patch is now useless, the same goal has been achieved by a follow-up on bug 8063 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #12054|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12374 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12374action=edit Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #2) Hello Owen, Thanks for your question. It permits me to improve this patch :) How is the renewal date calculated if the renewals period is set to zero (as it will be when the feature is added on top of an existing installation) ? A new query is added to the updatedatabase. It set the renewalperiod field with the issuelength value. Shouldn't this feature accommodate renewal periods in hours or days? How can a library set a renewal period if their loan period is in hours? Now it is possible, the renewalperiod unit is based on the unit value (days or hours) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8441] Hide MODS export for UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8441 --- Comment #3 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 12375 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12375action=edit proposed patch Indeed, thanks! I updated the file containing specific commands for the install in French. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8441] Hide MODS export for UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8441 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5356] Shipping billing address improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11120|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12376 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12376action=edit Bug 5356: delivery place and billing place centralised in basket management - adding 2 select option in basdketheader.tmpl (delivery and billing place) - adding 2 more fields in basket csv export Signed-off-by: Katrin Fischer katrin.fischer...@web.de Tested together with patches for bug 7302. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5356] Shipping billing address improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11952|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12377 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12377action=edit Bug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7473] Non logged OPAC user can create a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7473 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Adrien SAURAT adrien.sau...@biblibre.com --- *** This bug has been marked as a duplicate of bug 6631 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6631] Unrestricted creation of lists by anonymous users
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6631 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added CC||adrien.sau...@biblibre.com --- Comment #7 from Adrien SAURAT adrien.sau...@biblibre.com --- *** Bug 7473 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5356] Shipping billing address improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #26) Well, testing this feature QAing the code one more time, a question arise: what is the freedeliveryplace done for ? * in aqbasketgroup, it was a TEXT, in this patch, for aqbasket it's a varchar(10), that is tiny for a free address ! * I can't see where I can file this freedeliveryplace field (not failing QA until i've an anwser to those questions) Paul, In fact the aqbasket.freedeliveryplace is unused. So I removed it in the last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10494|0 |1 is obsolete|| --- Comment #164 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10494 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10494 Bug 6679 - [SIGNED-OFF]fix 12 perlcritic violations in C4/External/BakerTaylor.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10495|0 |1 is obsolete|| --- Comment #165 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10495 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10495 Bug 6679 - [SIGNED-OFF] fix 12 perlcritic violations in C4/Auth_with_ldap.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10496|0 |1 is obsolete|| --- Comment #166 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10496 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10496 Bug 6679 -[SIGNED-OFF] fix 12 perlcritic violations in C4/Context.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10497|0 |1 is obsolete|| --- Comment #167 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10497 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10497 Bug 6679 - [SIGNED-OFF]fixing 23 'return statement with explicit undef' violations in C4/Tags.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #168 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10517 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10517 Bug 6679 - [FAILED QA]fix 3 perlcritic violations in C4/ClassSortRoutine.pm This patch has NOT been pushed. After applying it, you get a Perl error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10935|0 |1 is obsolete|| --- Comment #169 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10935 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10935 Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #170 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10936 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10936 Bug 6679 - [SIGNED-OFF] fix 11 perlcritic violations in C4/Dates.pm This patch has NOT been pushed. After applying it you get a perl error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10938|0 |1 is obsolete|| --- Comment #171 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10938 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10938 Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10940|0 |1 is obsolete|| --- Comment #172 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10940 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10940 Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/Koha.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10946|0 |1 is obsolete|| --- Comment #173 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10946 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10946 Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10947|0 |1 is obsolete|| --- Comment #174 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10947 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10947 Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10948|0 |1 is obsolete|| --- Comment #175 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10948 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10948 Bug 6679 - [SIGNED-OFF] fix 7 perlcritic violations in C4/Biblio.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10950|0 |1 is obsolete|| --- Comment #176 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10950 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10950 Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10952|0 |1 is obsolete|| --- Comment #177 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10952 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10952 Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10953|0 |1 is obsolete|| --- Comment #178 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10953 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10953 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10955|0 |1 is obsolete|| --- Comment #179 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10955 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10955 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Branch.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10957|0 |1 is obsolete|| --- Comment #180 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10957 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10957 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10959|0 |1 is obsolete|| --- Comment #181 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10959 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10959 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Output.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10960|0 |1 is obsolete|| --- Comment #182 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10960 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10960 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10961|0 |1 is obsolete|| --- Comment #183 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10961 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10961 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Items.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10963|0 |1 is obsolete|| --- Comment #184 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10963 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10963 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10964|0 |1 is obsolete|| --- Comment #185 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10964 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10964 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10965|0 |1 is obsolete|| --- Comment #186 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10965 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10965 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10966|0 |1 is obsolete|| --- Comment #187 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10966 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10966 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comments: Works as expected, nothing to say Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10981|0 |1 is obsolete|| --- Comment #188 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10981 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10981 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10980|0 |1 is obsolete|| --- Comment #189 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10980 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10980 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10979|0 |1 is obsolete|| --- Comment #190 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10979 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10979 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Creators/PDF.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10976|0 |1 is obsolete|| --- Comment #191 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10976 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10976 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Installer.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #192 from Paul Poulain paul.poul...@biblibre.com --- Attachment that are still here either: * does not apply anymore * badly break Koha (resulting in a Perl error) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #12373|0 |1 is obsolete|| --- Comment #22 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 12378 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12378action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 audio and video element. Additionally it gives basic support for the track element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to Play audio resp. Play video. - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration-System preferences-enhanced content-HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together Bug 8377 [ENH] Followup: Move perl module to C4 Bug 8377 [ENH] Followup: fix call for moved module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #23 from Mirko Tietgen mi...@abunchofthings.net --- Hi Paul, thanks a lot for reviewing the patch. I have - rebased to master - moved HTML5Media.pm to C4 - changed references to C4::HTML5Media.pm in catalogue/detail.pl and opac/opac-detail.pl - set up a sandbox to verify everything is OK http://catalogue.test7.biblibre.com/cgi-bin/koha/opac-search.pl?q=8377 http://pro.test7.biblibre.com/cgi-bin/koha/catalogue/search.pl?q=8377 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10938|1 |0 is obsolete|| --- Comment #193 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10938 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10938 Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm I just reverted this patch, as it break translator (missed to test it when I tested patches..) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #12186|0 |1 is obsolete|| --- Comment #10 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 12379 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12379action=edit Bug 8726: ExplodedTerms suggestion plugin (functionality) When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these exploded subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for Arizona, United States, and Phoenix, and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose Subject and broader terms on the advanced search screen with more options displayed), and check that you get the records with the subject Arizona and the records with the subject United States 3) Do a search for su-na:Arizona (or choose Subject and narrower terms on the advanced search screen with more options displayed), and check that you get the records with the subject Arizona and the records with the subject Phoenix 4) Do a search for su-rl:Arizona (or choose Subject and related terms on the advanced search screen with more options displayed), and check that you get the records with the subject Arizona, the records with the subject United States, and the records with the subject Phoenix 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use Did you mean? page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off Signed-off-by: wajasu matted-34...@mypacks.net Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Split into two patches. This patch includes only the functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #11 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 12380 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12380action=edit Bug 8726: ExplodedTerms suggestion plugin (jQueryUI) When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these exploded subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for Arizona, United States, and Phoenix, and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose Subject and broader terms on the advanced search screen with more options displayed), and check that you get the records with the subject Arizona and the records with the subject United States 3) Do a search for su-na:Arizona (or choose Subject and narrower terms on the advanced search screen with more options displayed), and check that you get the records with the subject Arizona and the records with the subject Phoenix 4) Do a search for su-rl:Arizona (or choose Subject and related terms on the advanced search screen with more options displayed), and check that you get the records with the subject Arizona, the records with the subject United States, and the records with the subject Phoenix 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use Did you mean? page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off Signed-off-by: wajasu matted-34...@mypacks.net Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Split into two patches. This patch includes only the jQueryUI upgrade -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #12 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 12381 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12381action=edit Bug 8726 follow-up: fix perlcritic issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #12381|0 |1 is obsolete|| --- Comment #13 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 12382 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12382action=edit Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #12382|0 |1 is obsolete|| --- Comment #14 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 12383 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12383action=edit Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com --- Apologies for the long delay (and the number of patches I just obsoleted). Fixing the perlcritic warnings was much harder than anticipated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comments: - Remove an unused routine (rectify_weights) - Simplify tag weight management - add UT not blocker: - add a tabulation character in C4/Tags.pm (but a lot of already exist) - useless use Data::Dumper in Tags.t Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8794] edit as duplicate for authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8794 --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- This makes sense as a feature. For the non-MARC21 catalogers, I just wanted to clarify when Nicole says turn it into a subject heading she is referring to adding free-floating subdivisions to the name for precomposd headings, not actually changing the authority type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_10 --- Comment #6 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12384 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12384action=edit Bug 8726: Followup FIX save didyoumean syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8746] rebuild_zebra_sliced.sh don't work where Record length of 106041 is larger than the MARC spec allows
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8746 --- Comment #1 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 12386 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12386action=edit Bug 8746: rebuild_zebra_sliced.sh now export/index records as MARCXML This avoid indexing failures due to bad offset or bad length error with ISO2709 format + minor improvements: - --length parameter is optional. If not given, it will execute the right sql query to find the number of records to index - new parameter --reset-index. If set, index is reset before indexing -- Exporting multiple records in the same ISO2709 file can cause problems. If one record is wrong (say a record is longer than 9 bytes, for example), then all following records won't be parsed correctly. For example yaz-marcdump refuse to read records that follow a malformed record. This cause problems in rebuild_zebra_sliced.sh because yaz-marcdump is used to count the number of records contained in one file. So the workaround used here is to export in MARCXML. yaz-marcdump can't split MARCXML files so a piece of Perl code is used instead (I didn't succeed to achieve this job with POSIX tools) To test you can create a biblio record longer than 9 bytes and try to index a range of biblionumbers that contain it. On master indexation of this record should fail and this should succeed with this patch. (Records longer than 9 bytes seem to not alter indexation of following records. I've encountered this behaviour with badly encoded records) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8746] rebuild_zebra_sliced.sh don't work where Record length of 106041 is larger than the MARC spec allows
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8746 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Unit tests failed now :-/ Marked as Failed QA. Can't use string (AuthorityFile) as an ARRAY ref while strict refs in use at /home/koha/Koha/SuggestionEngine.pm line 91. Can't use string (ExplodedTerms) as an ARRAY ref while strict refs in use at /home/koha/Koha/SuggestionEngine.pm line 91. Can't use string (ABCD::EFGH::IJKL) as an ARRAY ref while strict refs in use at /home/koha/Koha/SuggestionEngine.pm line 91. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #11843|0 |1 is obsolete|| --- Comment #13 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 12387 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12387action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose compare barcodes list to result option, the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #14 from Matthias Meusburger matthias.meusbur...@biblibre.com --- This new patch removes the .tmpl file and adds the .tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #10965|1 |0 is obsolete|| --- Comment #194 from Paul Poulain paul.poul...@biblibre.com --- Comment on attachment 10965 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10965 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm This patch has been reverted = jenkins complain: perl t/Installer_pm.t 1..4 ok 1 - use C4::Installer::PerlModules; ok 2 - The object isa C4::Installer::PerlModules ok 3 - returns numeric version not ok 4 - returns correct version # Failed test 'returns correct version' # at t/Installer_pm.t line 23. # Looks like you failed 1 test of 4. After reverting, t/Installer_pm.t is OK Maybe that's the test that must be upgraded, but until it's done, this patch is reverted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 Severity|enhancement |normal --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master I thin it's more a bugfix than en ENH. Switching to normal severity, probably expected for 3.8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8262] Could not add or create List in koha 3.8.1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 verolencinas verolenci...@yahoo.com.ar changed: What|Removed |Added Status|NEW |RESOLVED CC||verolenci...@yahoo.com.ar Resolution|--- |FIXED --- Comment #2 from verolencinas verolenci...@yahoo.com.ar --- The problem is solved if you create the list logged in as a normal user (not kohaadmin). If you try to create a list logged in as administrator, you don't have a borrowernumber and koha can't create lists who don't belong to a user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7913] Automatically receive serial issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 --- Comment #12 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 12388 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12388action=edit Follow-up, hide multi receive button for subs with items Here it is. I also add add a button in edit page (it's just a redirection to serials-collection functionality) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7913] Automatically receive serial issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #11092|0 |1 is obsolete|| --- Comment #41 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12389 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12389action=edit Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a Home Library column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the Location column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #42 from Kyle M Hall k...@bywatersolutions.com --- - The column of item-level holds is not displayed. Even in cases where there is an item-level hold the column is empty. I'm not sure what you are referring to here. Could you post an before/after screenshot? - The patch violates capitalization guidelines (Bug 2780) (Current location and Home Library). Fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8797] New: can't delete quote of the day
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 Priority: P5 - low Change sponsored?: --- Bug ID: 8797 Assignee: cnighswon...@foundations.edu Summary: can't delete quote of the day Severity: normal Classification: Unclassified OS: All Reporter: neng...@gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha I am documenting the QOTD feature and trying to delete a quote, but it's not letting me do it. I click on the quote id number and nothing happens - the row isn't highlighted or anything and so I can't delete. I'm on FF on Mac. If I click to add a new quote and don't enter any data then I can click on the ID column of the new empty quote and delete it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #12383|0 |1 is obsolete|| --- Comment #18 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 12390 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12390action=edit Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Sorry about the problematic last attempt at uploading. I missed a patch when squashing. It is now included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #12384|0 |1 is obsolete|| --- Comment #19 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 12391 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12391action=edit Bug 8726: Followup FIX save didyoumean syspref Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8557] in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Christophe Croullebois christophe.croulleb...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |christophe.croullebois@bibl |ity.org |ibre.com --- Comment #1 from Christophe Croullebois christophe.croulleb...@biblibre.com --- Created attachment 12392 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12392action=edit proposed patch thx for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8797] can't delete quote of the day
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- By the way, it does work on the import quotes screen - if I want to delete quotes from there they highlight when I click on the ID with no problem. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7471] z39.50 search propagation from empty results prepends kw, wrdl to search terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7471 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED CC||gaetan.bois...@biblibre.com Resolution|--- |DUPLICATE --- Comment #1 from Gaetan Boisson gaetan.bois...@biblibre.com --- *** This bug has been marked as a duplicate of bug 5645 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5645] Z39.50 search from search results not parsing query correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #1 from Gaetan Boisson gaetan.bois...@biblibre.com --- *** Bug 7471 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8557] in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Christophe Croullebois christophe.croulleb...@biblibre.com changed: What|Removed |Added Attachment #12392|0 |1 is obsolete|| --- Comment #2 from Christophe Croullebois christophe.croulleb...@biblibre.com --- Created attachment 12393 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12393action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5645] Z39.50 search from search results not parsing query correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added CC||gaetan.bois...@biblibre.com --- Comment #2 from Gaetan Boisson gaetan.bois...@biblibre.com --- Confirmed, still a bug. See Liz Rea's screenshot from bug 7471 : http://screencast.com/t/Zi2saYeF9sz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7595] Add branchcode to accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #8162|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12394 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12394action=edit [SIGNED-OFF] Bug 7595 - Add branchcode to accountlines Adds a branchcode column to the accountlines table. For payments, this inserts the branchcode of the library where the payment was recorded. For manual invoices, it insert the branchcode of the library where the manual invoice was created. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com I tested with creating manual invoices, and paying partial fines, entire fine lines, and writing off fines. All actions record the branch where the action took place properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8557] in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Christophe Croullebois christophe.croulleb...@biblibre.com changed: What|Removed |Added Priority|P5 - low|P3 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7595] Add branchcode to accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12395 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12395action=edit Bug 7595 - Add branchcode to accountlines - Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8509] Allowing the Expected status even if another status has been saved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 --- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 12396 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12396action=edit proposed patch TEST PLAN Receive serials. Change a serial from Expected to another status. Come back to the receive page. Before patch : the serial cannot be set to Expected anymore After patch : the Expected status still appear in the select box and can be used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8509] Allowing the Expected status even if another status has been saved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7595] Add branchcode to accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Now all seem good to me. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8215] Add Course Reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #58 from Paul Poulain paul.poul...@biblibre.com ---
QA comment:
* why is CourseReserve in Circulation tab ? Sounds strange to me (not a reason
to fail QA)
* Authorised_values = hardcoded ones are usually hardcoded on
admin/authorised_values.pl. I think you can add safely DEPARTMENT and TERM.
Even if there is no DEPARTMENT And TERM, they appear, and the user know they
are here.
Look here:
foreach (qw(Asort1 Asort2 Bsort1 Bsort2 SUGGEST DAMAGED LOST REPORT_GROUP
REPORT_SUBGROUP)) {
(in admin/authorised_values.pl)
* I've added a DEPARTMENT: Département Sciences. On course.pl, I get a
nasty:
D�partement Lettres after saving my 1st course (the diacritic reencoded or
something like that) I've added a diacritic to my TERM, and same problem: 2eme
trimestre . other fields are OK. I've checked other authorised values (like
in cataloguing, no encoding problem, it's specific to course.pl)
* GRRR... you don't respect HTML4 coding guideline : Add Reserves should be
Add reserves. There are many many strings like that
* Step 2 of course/add_items.pl, I'm not sure I understand why when
collection/itemtype/location/branch should change, and when it will. Some
documentation (online help ?) welcomed !
* After adding a reserve to my course I see my branchname encoding broken as
well: Unchanged (M�diath�que Cannet des Maures)
* After adding a reserve to my course, I see that the itemtype is Unchanged
() the () make me think you don't handle the case where items.itype is empty,
the itemtype is in biblioitems.itemtype (that's what I have in my database)
* I use the ccsr theme for OPAC, and couldn't find where I could access
opac-course.pl. I understood it's because you add a line to masthead.inc
+[% IF ( UseCourseReserves ) %]span class=pipe | /spana
href=/cgi-bin/koha/opac-course-reserves.plCourse Reserves/a[% END %]
that is not in ccsr masthead.inc
Please add it !
*Something I don't understand functionnally: I places a course reserve on an
item that was on loan. When I check-in the document, nothing happens (ie: i'm
not warned the item is for course X or something like that. Is it the
expected behaviour ? Some functionnal explanations are worth...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5356] Shipping billing address improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356
--- Comment #31 from Paul Poulain paul.poul...@biblibre.com ---
QA comment:
I think this line is wrong:
+basketgroupdeliveryplace = C4::Branch::GetBranchName(
$basketgroup-{deliveryplace} ) || C4::Branch::GetBranchName(
$basketgroup-{freedeliveryplace} ),
C4::Branch::GetBranchName( $basketgroup-{freedeliveryplace} ) will never work,
because freedeliveryplace is free, so not related to a branch code !
do we agree ?
(found this problem when checking if freedeliveryplace had been removed from
your patches ;-) )
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #7 from M. Tompsett mtomp...@hotmail.com --- There are several scripts in the bin directory that use similar logic that trigger the last perlcritic error. My rough idea was to do a push @INC for the variable part, that way the require could just be the library name itself. Haven't tested it. Just a brain storming thought I had. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5335] More granular VAT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #46 from Paul Poulain paul.poul...@biblibre.com ---
QA comment:
* passes koha-qa.pl
* a big patch, but not so much code. A lot is made of cleaning / change in
indentation/... like
-$line{booksellerid} = $booksellerid;
+$line{booksellerid} = $booksellerid;
* I'm not sure the following change
-$biblionumber, $ordernumber, $quantityrec, $user, $unitprice,
-$invoiceid, $replacement, undef, $datereceived, \@received_items);
+$biblionumber,
+$ordernumber,
+$quantityrec,
+$user,
+$order-{unitprice},
+$order-{ecost},
+$invoiceno,
+$order-{rrp},
+undef,
+$datereceived,
+\@received_items,
+);
is very desirable, but I won't fail QA for that
* I'm not sure that t/db_dependent/lib/KohaTest/* is used, so the (tiny)
changes here are probably useless.
Conclusion = Passed QA !
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Attachment #10226|0 |1 is obsolete|| --- Comment #12 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 12398 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12398action=edit Revised Patch This is a revised patch reflecting the EDI as currently running in production. It needs in addition an entry to the db upgrade script, however the location of the code is more standard than in the previous;y submitted patch, small changes have been incorporated and I've addressed some issues that would have triggered failures in critic tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
