[Koha-bugs] [Bug 8304] composed authorities Rameau management

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search.

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8778

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8778] Add Phrase Searching to OPAC Search

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8302

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #25 from wajasu matted-34...@mypacks.net ---
Better news.
I got my fresh debian VM built.  Here are may latest observations:

In the VM:
koha@biblio:~/kohaclone/local/lib/perl5/DBIx$ grep VER *
Class.pm:$VERSION = '0.08200';
So my other VM must have been older (a month, and maybe grabbed an older
version).

koha@biblio:~/kohaclone$ prove t/Context.t 
t/Context.t .. DBIx::Class::Relationship::HasOne::might_have():
might_have/has_one must not be on columns with is_nullable set to true
(Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect
use of those relationship helpers instead of belongs_to. at
/home/koha/kohaclone/Koha/Schema/Result/Borrower.pm line 780
t/Context.t .. ok   
All tests successful.
Files=1, Tests=1,  2 wallclock secs ( 0.04 usr  0.00 sys +  0.78 cusr  0.07
csys =  0.89 CPU)
Result: PASS

(Just guessed that you want DateTime when inflating. You might have not.)
[Maybe you can note the exact dbicdump command line you used in the bug report,
for future reference.  I know they might want Versioned, but I know you have
started tweaks, probably for cardnumber in borrower.]
koha@biblio:~$ dbicdump -o dump_directory=./lib -o
components='[InflateColumn::DateTime]' -o debug=1 Koha::Schema
'DBI:mysql:database=koha;host=localhost' koha koha
Dumping manual schema for Koha::Schema to directory ./lib ...
Schema dump completed.

I got ActionLogs.pm in my dump in this debian VM.

koha@biblio:~/kohaclone$ prove t/Context.t
t/Context.t .. DBIx::Class::Relationship::HasOne::might_have():
might_have/has_one must not be on columns with is_nullable set to true
(Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect
use of those relationship helpers instead of belongs_to. at
/home/koha/kohaclone/Koha/Schema/Result/Borrower.pm line 780
t/Context.t .. ok   
All tests successful.
Files=1, Tests=1,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.80 cusr  0.04
csys =  0.87 CPU)
Result: PASS

I also tested to see if DBIx tries to connect to the DB, by shutting down the
mysql instance, and it made no difference.

So you might want to get rid of the Borrower/cardnumber  thing above.

We can't have this spitting out junk everytime we use the context. Note: It
does so for perl Makefile.PL or any thing that uses C4::Context.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 459] No uninstall script

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #12435|0   |1
is obsolete||
 Status|NEW |In Discussion
   Assignee|m...@software.coop   |mtomp...@hotmail.com

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 12451
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12451action=edit
Revised partially tested, but still a bit buggy non-patch file

Fine, I'll take the bug. I haven't patch-i-fied this yet. I've only run this on
a packages installation. The koha zebra daemon removal part still needs some
work. But once I'm happy with my testing on packages, I'll work on testing it
on a git install. Then I'll go old-school with a tarball install.

I probably need to add logic to exclude the git clone directory from deletion.

Any other ideas or feedback? Feel free to test tweak and post a patch if you
want. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8793] Fix materialTypeCode/typeOf008 icons for NORMARC XSLT

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

Summary|Remove references to OPAC   |Fix
   |icons from NORMARC staff|materialTypeCode/typeOf008
   |XSLT|icons for NORMARC XSLT

--- Comment #1 from Magnus Enger mag...@enger.priv.no ---
Broadening the scope of this bug a bit, to cover more (closely related)
problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Zeno Tajoli taj...@cilea.it changed:

   What|Removed |Added

 CC||taj...@cilea.it

--- Comment #14 from Zeno Tajoli taj...@cilea.it ---
Errors on apply the patch:
error: patch failed: installer/data/mysql/sysprefs.sql:382
error: installer/data/mysql/sysprefs.sql: patch does not apply
error: patch failed: installer/data/mysql/updatedatabase.pl:5966
error: installer/data/mysql/updatedatabase.pl: patch does not apply

In fact the problem is trivial: those files (sysprefs.sql and
updatedatabase.pl)
are changing quite quickly those days

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #14)
 Errors on apply the patch:
 error: patch failed: installer/data/mysql/sysprefs.sql:382
 error: installer/data/mysql/sysprefs.sql: patch does not apply
 error: patch failed: installer/data/mysql/updatedatabase.pl:5966
 error: installer/data/mysql/updatedatabase.pl: patch does not apply
 
 In fact the problem is trivial: those files (sysprefs.sql and
 updatedatabase.pl)
 are changing quite quickly those days

If you use git am -3 you'll be able to resolve the conflict yourself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7243] Do not take rentals as fines

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #11943|0   |1
is obsolete||

--- Comment #14 from Marc Véron ve...@veron.ch ---
Created attachment 12452
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12452action=edit
bug_7243: Be selective when summing up charges for blocking issues

Added RentalsInNoissueCharges and ManInvlsInNoissueCharges sys prefs

Created C4::Members::cwGetMemberAccountBallance()
* A wrapper for GetMemberAccountRecords that gives info on non-issue and
  other charges
* Other charges are:
  'Res'
  'Rent' if RentalsInNoissueCharges is Mo
  authorised_values MANUAL_INV if ManInvlsInNoissueCharges is No

C4::Members::GetMemberAccountRecords() changes:
* Dropped input param $date, it is not used

Use split charges in C4::Circulation::CanBookBeIssued() and
C4::Members::patronflags(). That way only fines decide whether an item
can be issued, and not other non-fine charges

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7243] Do not take rentals as fines

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #12452|0   |1
is obsolete||

--- Comment #15 from Marc Véron ve...@veron.ch ---
Created attachment 12454
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12454action=edit
[SIGNED-OFF] bug_7243: Be selective when summing up charges for blocking issues

Added RentalsInNoissueCharges and ManInvlsInNoissueCharges sys prefs

Created C4::Members::cwGetMemberAccountBallance()
* A wrapper for GetMemberAccountRecords that gives info on non-issue and
  other charges
* Other charges are:
  'Res'
  'Rent' if RentalsInNoissueCharges is Mo
  authorised_values MANUAL_INV if ManInvlsInNoissueCharges is No

C4::Members::GetMemberAccountRecords() changes:
* Dropped input param $date, it is not used

Use split charges in C4::Circulation::CanBookBeIssued() and
C4::Members::patronflags(). That way only fines decide whether an item
can be issued, and not other non-fine charges

Signed-off-by: Marc Veron ve...@veron.ch

Rebased (updatedatabase.pl)

ManInvInNoissueCharges and RentalsInNoissueCharges ar both included by default
(= behaviour as before)

All variants tested: Both included, none included, manual invoice included,
rentals included.
Works fine, blocks/does not blok as appropirate, messages appear as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12442|0   |1
is obsolete||

--- Comment #26 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 12453
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12453action=edit
Added base class files for all tables in koha using the
DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context

Also added dependencies in required files.
[Update]: changed dependencies fron dbic to dbix
  moved generation shell script to a perl script wtih arguments in
misc/devel
To Test:

Install patch
Make sure you can still connect to Koha
you may optionally run the test script in comment 12
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798#c12
If you run this file you should get a DBIx dump of the borrowers table
Done!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7243] Do not take rentals as fines

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2601] Order fines by date and time

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #4 from Marc Véron ve...@veron.ch ---
Accountlines primary key was added by Bug 7671.

Is this bug still valid?

Marc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

2012-09-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #27 from wajasu matted-34...@mypacks.net ---
i found a way to squelch the validation warning. in C4/Context.pm i put
$ENV{'DBIC_DONT_VALIDATE_RELS'} = 1; # FIXME once the DBIx schema has its
schema adjusted we should remove this

If this is going out in whatever state its in, this will prevent us from seeing
the warning all over the place, but we should write a bug noting this to track
it as a possible outstanding issue.  But we will loose this other lrelationship
validations as well.  When we write tests, we might just write a test for the 
schema for us to see those validation tests.
See the source for reference.
/usr/share/perl5/DBIx/Class/Relationship/HasOne.pm

prove t/Context.t
t/Context.t .. ok   
All tests successful.
Files=1, Tests=1,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.69 cusr  0.05
csys =  0.78 CPU)
Result: PASS

I ran dbicdump on my debian VM and it matches what Elliot got.  ActionLogs.pm
I ran it on my archlinux hostOS and it generates ActionLog.pm
So maybe some transitive dependency for plural/stemming etc is newer on my, and
Colin's environments.  You might want to rename it to ActionLog to align with
future behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/