[Koha-bugs] [Bug 9278] Remove unused OPAC CSS file sanop.css
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9278 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9278] Remove unused OPAC CSS file sanop.css
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9278 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14062|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14065 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14065action=edit Bug 9278 - Remove unused OPAC CSS file sanop.css This patch removes an unused CSS file, sanop.css, included in both OPAC themes even though it is referenced by neither. To test, apply the patch and listen for the unhappy protestations of libraries whose OPACs now look different. If there are none, the patch works. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com According to Paul's answer (on the mailing list), I sign off this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't ork
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 --- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 14066 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14066action=edit proposed patch TEST PLAN 1) Click on Reports - Patrons to see the Patrons statistics page 2) Setup a request which should have result for both inactive and active patrons. For example, select Patron category as row and Patron gender as column. 3) Launch the request, then come back and select active in the Patron activity parameter. Launch the request again, the results should be different, displaying only active patrons. 4) Come back and select inactive in the Patron activity parameter. Launch the request. The results are empty ! After installing this patch you'll obtain stats for the inactive patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't ork
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9279] New: Problem with quick slip templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9279 Bug ID: 9279 Summary: Problem with quick slip templates Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: vfernan...@keep.pt Yesterday I was trying the using of quick slip templates in Koha 3.8.7. I've modified the template and then I've done one check out to one patron. Then I tried to print the quick slip, and two thing happened: - If I was in circulation tab of the patron, when printing the quick slip the template was used (printslip.pl was called) - If I was in details tab of the patron, when printing the quick slip the templates wasn't used (moremember.pl was called) Should be the template always be used besides being on circulation or details tab? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9279] Problem with quick slip templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9279 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Priority|P5 - low|P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11604|0 |1 is obsolete|| Attachment #11792|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14067 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14067action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - branchcode - budget New authorised value 'ORDRSTATUS' is created with following values: 0 = New 1 = Ordered 2 = Partial 3 = Complete 4 = Deleted New field aqorders.parent_ordernumber is added (which is mainly used by others enhancement). It allows to know the main(=parent) order for an order (if an order is partially received, Koha creates another order. But it is the same order. We want to know this information). To test: Search and check if results are consistent in histsearch.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Summary|Patron stats, patron|Patron stats, patron |activity : no active|activity : no active |doesn't ork |doesn't work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com --- Rebasing this patch is really a pain. It is signed off and the Bug 5786 is blocked in discussion. So I think we don't have to wait for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de --- 5786 has been on and off the -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #39 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Bug 5786 has been around since 2011 - it hurts me to see that this important development is stuck in discussion. But I was not trying to say that this has to wait, only pointing out a conflict that will arise at some point that needs to be addressed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #68 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Paul, could you take a look at Srdjan's comment please and try to find out why the 2 of you get different results while testing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9243] Bad delete order in sub index_records in rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835
--- Comment #31 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
1)
push @emails_to_use, $email if ($email ne '');
I also added line 497/498:
push @emails_to_use, $memberinfos-{$_}
if ($memberinfos-{$_} ne '');
2) It does work, but you're right, it's messy:
-$email = 1 if (@emails_to_use);
-if ( ( !$email || $nomail ) $PrintNoticesMaxLines $j
= $PrintNoticesMaxLines ) {
+if ( ( scalar(@emails_to_use) == 0 || $nomail )
$PrintNoticesMaxLines $j = $PrintNoticesMaxLines ) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #12336|0 |1 is obsolete|| --- Comment #32 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 14068 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14068action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez claire.hernan...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 --- Comment #24 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 14069 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14069action=edit Bug 8378: Fix overdue letter generation In overdue_notices.pl, letter template must not be passed to parse_letter because this sub modifies it, so the first overdue letter is ok but following letters have exactly the same content. This patch make a copy of the template before passing it to parse_letter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9243] Bad delete order in sub index_records in rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl ---
As far as I can see, this problem is already fixed in master. Your patch
introduces the following problem:
Can't use an undefined value as a HASH reference at ./rebuild_zebra.pl line
422.
This has to do with the uninitialized $records_deleted.
Please note however that the routine export_marc_records_from_list gets the
deleted records hash and skips these deleted records when creating the file for
the update step.
This is done in the following rather obscure code:
foreach my $record_number ( map { $_-{biblio_auth_number} }
grep { !$found{ $_-{biblio_auth_number} }++ }
@$entries ) {
I tested update and delete with and without your patch.
With your patch, the above error occurs.
Without your patch, the problem does not occur and the records are deleted from
zebra.
I suggest to close this report. Do you agree with the above explanation in
mind?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|In Discussion |Needs Signoff CC||julian.maur...@biblibre.com --- Comment #25 from Julian Maurice julian.maur...@biblibre.com --- Steps to reproduce the bug: 1. make 2 checkouts with 2 different borrowers of the same categorycode 2. make these checkouts become overdue update issues set date_due='-XX-XX XX:XX' where borrowernumber IN(X,Y) 3. run misc/cronjobs/overdue_notices.pl -n You should obtain the same letter twice. 4. Now apply the patch and re-run misc/cronjobs/overdue_notices.pl -n You should obtain 2 different letters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 --- Comment #26 from Julian Maurice julian.maur...@biblibre.com --- Note: this patch is for master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9243] Bad delete order in sub index_records in rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 --- Comment #3 from Christophe Croullebois christophe.croulleb...@biblibre.com --- Hello, oups, sorry done too fast. At the beginning it comes from a patch for 3.2 and it was just ask to me to reverse the two blocks. I rebase for master when I saw that the 2 blocks were in the same order also in master, I didn't look further... So you'r right M. de Rooy, yes please close. thx -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9243] Bad delete order in sub index_records in rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Blocks||8036 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8036] item type on purchase suggestion blank
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8036 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m Depends on||9223 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 --- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Julian, does this patch also address the fine syntax problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 --- Comment #28 from mathieu saby mathieu.s...@univ-rennes2.fr --- Hello Maybe your patch work, I did not check, but is it normal that C4::Letters::GetProcessedLetter changes the value of the template passed to it? If we keep this behavior, I fear it will cause other bugs somewhere else. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 --- Comment #29 from Julian Maurice julian.maur...@biblibre.com --- Hi Katrin, this patch is a follow-up for the original patch that fix the fine syntax problem. Does it answer your question? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi Kyle, Please correct some qa issues please: * C4/Reserves.pm FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (1309) The patch introduces a forbidden pattern: tabulation character (1276) The patch introduces a forbidden pattern: tabulation character (1308) The patch introduces a forbidden pattern: tabulation character (723) * opac/opac-modrequest.pl FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (43) * opac/opac-reserve.pl FAIL valid FAIL Global symbol $MAXIMUM_NUMBER_OF_RESERVES requires explicit package name opac/opac-reserve.pl had compilation errors. * reserve/request.pl FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (181) The patch introduces a forbidden pattern: tabulation character (241) The patch introduces a forbidden pattern: tabulation character (182) The patch introduces a forbidden pattern: tabulation character (146) The patch introduces a forbidden pattern: tabulation character (160) The error on opac-reserve.pl is blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #27 from Julian Maurice julian.maur...@biblibre.com --- I just tried to apply both patches on up-to-date 3.8.x branch in this order proposed patch to match 3.8.x Bug 8382 [Follow-up] It is not possible to cancel an order when receiving on a filtered page in parcel.pl and had no conflicts. Furthermore, it works :) Can you give it a try again Chris ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 --- Comment #30 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Yes, thank you :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] New: Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 Bug ID: 9280 Summary: Bad price calculation when filling a basket with staged records Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.s...@univ-rennes2.fr Koha does not manage the VAT properly when filling a basket with staged records. Let's take a book whose Recommended Retail Price excluding tax is 39 euros. On the vendor's website, I import the record for this book in iso2709 In the record (UNIMARC), the price is in 010$d after the ISBN. So, I found in my record 10$d39.00 EUR I stage this record in Koha with Stage Marc Records Tools. In Acquisition module, I create a vendor with: - List item price includes tax: Yes - Invoice item price includes tax: Yes - Discount: 9. % - Tax rate: 5.5% I create a new basket for this vendor. I fill this basket with my stage record. I think I should have for the command line in this basket : - RRP tax included : 39 euros - Ecost tax included : 39 euros - 3,51 euros = 35,49 euros - RRP tax excluded : 39*100/105.5 = 36,96 euros - Ecost tax excluded : 35,49*100/105.5 = 33,63 euros BUT instead I see the following values : - RRP tax included : 42.86 euros - Ecost tax included : 39 euros - RRP tax excluded : 40,63 - Ecost tax excluded : 36,97 So, Koha considered the 39 euros value in my record as a Ecost price. I dont think it is normal, as as chose List item price includes tax: Yes in vendor record. M. Saby Rennes 2 University -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5544] All Notices from Branch Email Address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Typo: From = From = -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #8 from mathieu saby mathieu.s...@univ-rennes2.fr --- Still a conflit : CONFLICT (content): Merge conflict in installer/data/mysql/en/optional/auth_val.sql Auto-merging installer/data/mysql/de-DE/optional/auth_val.sql CONFLICT (content): Merge conflict in installer/data/mysql/de-DE/optional/auth_val.sql Failed to merge in the changes. M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9281] New: Impossible to create an order from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9281 Bug ID: 9281 Summary: Impossible to create an order from a staged file Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com When you try to create an order from a staged file, you get a sql error: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed at /home/koha/src/C4/Members.pm line 559 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9281] Impossible to create an order from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9281 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9281] Impossible to create an order from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9281 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14070 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14070action=edit Bug 9281: FIX add an order from a staged file In GetMember the hash parameter contained 'C4::Members' = 'borrowernumber' XXX = undef Test plan: In the acquition module, try to add an order to a basket from a staged file. Without this patch, you get an error: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed at /home/koha/src/C4/Members.pm line 559 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14071 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14071action=edit Bug 9280: FIX price calculation adding an order from a staged file Test plan: Add an order from a staged file containing a price value (010$d for UNIMARC user). Check this patch with 2 different vendors (listprice=1 and listprice=0). Check the calculated price (depending discount and gstrate). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9282] New: authorities auto-completion in mainmainentry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 Bug ID: 9282 Summary: authorities auto-completion in mainmainentry Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: fridolyn.som...@biblibre.com CC: m.de.r...@rijksmuseum.nl In authorities popup search (auth_finder.pl), some search inputs have auto-completion : - Anywhere - Main entry - Main entry ($a only), alias mainmainentry For anywhere and main entry, auto-completion works well : select a term and launch search, you will find authorities. For mainmainentry, select a term and launch search, you will sometimes not find authorities. It is because auto-compete returns authorities headings, composed of $a and other subfields of heading field whereas search on mainmainentry will only look in $a. I propose that auto-completion of mainmainentry field return a list of the mainmainentry of found authorities. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Humm, it works here: $ git remote update $ git checkout -b BZ5336 origin/master $ git bz apply 5336 Bug 5336 - Acq history search Bug 5336:Order search (search and UI enhancements) Apply? [yn] y Applying: Bug 5336:Order search (search and UI enhancements) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #10 from mathieu saby mathieu.s...@univ-rennes2.fr --- Maybe my install is corrupted. I will test again later... M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9281] Impossible to create an order from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9281 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #2 from mathieu saby mathieu.s...@univ-rennes2.fr --- It failed : I have got negative ecost inc. prices (for vendor with listprice =1 ; didn't test for listprice=0) in record : 75 euros RRP tax inc. : 75.00 ecost inc. : -675.00 Total tax in. : -675.00 GST rate 5% GST : -32.14 M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7294] status in order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #12332|0 |1 is obsolete|| --- Comment #44 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 14072 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14072action=edit Rebased patch Bug 7294: Adds acquisition informations in marc record View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 14073 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14073action=edit Proposed patch C4::AuthoritiesMarc : add 'hemain' key in authorities search results containing mainmainentry ($a most of the time). This can also be usefull for other features. authorities/ysearch.pl : - use of JSON module to encode output (this is usefull if data contains syntax characters like a double quote) - returned list as no duplicates (case is ignored) - add 'catalogue' permission test (like auth_finder.pl) = no access for a OPAC user - if authentication fails, an empty page is returned, lighter than a 500 error page (like many other ajax scripts) - UTF8 encoding is directly done by to_json (like in getitem-ajax.pl). I think it is the best performance way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Yep, bad test just before pushing :-/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14074 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14074action=edit Bug 9280: Followup FIX price calculation adding an order from a staged file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 --- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 14075 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14075action=edit Proposed patch (follow-up 1) follow-up : Authority type is missing from auto-complete ajax call. So actually, auto-complete search in all authority types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7294] status in order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #14072|0 |1 is obsolete|| --- Comment #45 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 14076 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14076action=edit Transform $$ into $- Bug 7294: Adds acquisition informations in marc record View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- I found some references to these files: koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/prog/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/prog/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background: url(../../images/star-ratings.gif) top left no-repeat; koha-tmpl/opac-tmpl/prog/en/css/opac.css: background: url(../../images/star-ratings.gif) top left no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/opac.css:background-image: url(../../images/tag-small-disabled.png); koha-tmpl/opac-tmpl/ccsr/en/css/opac.css:background-image: url(../../images/tag-small.png); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9166] OPAC needs configuration file for datepicker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9166] OPAC needs configuration file for datepicker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14057|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14077 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14077action=edit Bug 9166 [Revised] OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Revision adds the configuration include to opac-user as well (required by the suspend holds feature). Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com the datepicker plugin works for opac-reserve and opac-user -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9265] Switch to HTML5 doctype in OPAC and staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #5 from mathieu saby mathieu.s...@univ-rennes2.fr --- I applied the 2 patches. Bug partially corrected : 1st vendor : List item price includes tax: Yes Invoice item price includes tax: Yes Discount: 10. % Tax rate: 5.0% = OK : = Stage record with 27 euros in 010$d = line in a basket : - RRP tax exc. : 25,71 - ecost tax exc. : 23,14 - RRP tax inc. : 27 - ecost tax inc. : 24,30 - Total tax exc. (EURO) : 23,14 - Total tax inc. (EURO) : 24,30 - GST % : 5% - GST : 1,16 Prices are correct : - (25,71 * 5 / 100) + 25,71 = 27 - 27 * 0.9 = 24,30 - 23,14 * 5 / 100 = 24,30 2d vendor : 1st vendor : List item price includes tax: No Invoice item price includes tax: Yes Discount: 10. % Tax rate: 5.0% = KO I have exactly the same values for 2d vendor, while I was waiting for RRP tax exc. = 27 euros M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14071|0 |1 is obsolete|| Attachment #14074|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14079 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14079action=edit Bug 9280: FIX price calculation adding an order from a staged file Test plan: Add an order from a staged file containing a price value (010$d for UNIMARC user). Check this patch with 2 different vendors (listprice=1 and listprice=0). Check the calculated price (depending discount and gstrate). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- I'm a little bit lost... I don't understand the behavior we want here. The Bug 7180 includes a complex calculation and rewrite a big part of this page but I don't know what we want for this current version. The patch does in *ALL* cases: rrp = 010$d (or similar) ecost = rrp * ( 1 - discount) This 2 values are stored in the DB and the values are calculated on the fly depending of the bookseller parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- I don't recall seeing anything unusual when I ran rebuild_zebra.pl (In reply to comment #5) I tried to apply my patch. With unimarc flavor, it seems to work : in advanced search in staff interface, Keyword index gives me less results as the new Any word (all indexes). Maybe it is broken for marc21... Kyle, did you notice some unusual warns when you rebuild zebra ? Mathieu Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #8 from mathieu saby mathieu.s...@univ-rennes2.fr --- Yes, it is tiresome... I found a way to explain what I mean : If you create a new order line from scratch (not from staged record), Koha ask for Vendor price, and calculates other prices. For me, 010$d is the equivalent of this Vendor price, and should be treated in the same way. And it is not currently the case. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #7 from mathieu saby mathieu.s...@univ-rennes2.fr --- And you tested on a Marc21 base I suppose? M. saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7294] status in order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294
Matthias Meusburger matthias.meusbur...@biblibre.com changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #46 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
* There are many $$x{Y} that should be written $x-{Y}
= Done.
* I think/fear that the aqorders.branchcode feature is a bad idea: how will it
work when syspref AcqCreateItem=ordering ? How will you deal, when you don't
have AcqCreadItem=ordering, with creation of items, will this value be used for
defining the branch ? How will you deal with cases where you order 3 items for
different branches ? The items table has some fields that are already related
to acquisition: items.booksellerid, items.price, items.replacementprice.
= I don't see the problem here, because the branchcode that is used is the one
in the aqorders table (added by this patch), so it doesn't matter which value
has AcqCreateItem syspref. The branchcode is asked when creating a new order
and that's it. Moreover, the values inserted in the MARC Record are here for
information, they're not reused afterwards.
* split the patch in 2, to separate branchcode feature from the link2marc
feature, that's 2 different things
= Same as before, branchcode is an aqorders field, just like the others. I
don't see how it is different and why it should be handled separately.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5709] Adding the ability to translate HTML5 placeholder text in an input field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5709 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- With the last patch, what is wrong ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #13944|0 |1 is obsolete|| --- Comment #12 from Owen Leonard oleon...@myacpl.org --- Created attachment 14080 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14080action=edit Bug 8108 [Follow-up, revised] Remove unused OPAC images This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revisions: - Rebased on current master - Ported some changes to CCSR theme - Removed unused CSS which referred to deleted images -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8039] Self Checkout/SIP: Allow authentication with userid and password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. I do not have an actual self-check machine, so I would be grateful if someone who does have one would test now that these patches have been pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #10 from mathieu saby mathieu.s...@univ-rennes2.fr --- you mean only with patch 14079 ? I did not test yet... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14080|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14081 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14081action=edit Bug 8108 [Follow-up, revised] Remove unused OPAC images This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revisions: - Rebased on current master - Ported some changes to CCSR theme - Removed unused CSS which referred to deleted images Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #45 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14082 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14082action=edit Picture of the problem An extra (and ugly) %] shows up on the OPAC in the holdings tab if I do not change any sysprefs at all after applying this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #30 from Jared Camins-Esakov jcam...@cpbibliography.com --- Marking as Failed QA until guidance is provided on how to test this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12620|0 |1 is obsolete|| --- Comment #25 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14083 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14083action=edit Bug 7710 - multiple holds per title Adds the ability to allow multiple holds on the same record for the same borrower. Adds new system preference MaxHoldsPerRecord, which controls how many holds one person can have on items for the same record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- That is correct. (In reply to comment #7) And you tested on a Marc21 base I suppose? M. saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 --- Comment #11 from mathieu saby mathieu.s...@univ-rennes2.fr --- It is OK with patch 14079, I have : -1d vendor : List item price includes tax: Yes Invoice item price includes tax: Yes Discount: 10. % Tax rate: 5.0% stage record with 010$d = 27 euros RRP tax exc. = 25.71 euros RRP tax incl. = 27 euros (wich is 25.71+ (25,71 * 5/100)) discount calculated correctly -2d vendor : List item price includes tax: No Invoice item price includes tax: Yes Discount: 10. % Tax rate: 5.0% stage record with 010$d = 27 euros RRP tax exc. = 27 euros RRP tax incl. = 28.35 (which is 27 + (27*5/100)) discount calculated correctly I sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Attachment #14079|0 |1 is obsolete|| --- Comment #12 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 14084 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14084action=edit Bug 9280: FIX price calculation adding an order from a staged file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #128 from Jared Camins-Esakov jcam...@cpbibliography.com --- We are getting very close, I think. There are four remaining problems: 1) Two of the unit tests fail: [...] not ok 7 # Failed test at t/db_dependent/Koha_borrower_modifications.t line 55. not ok 8 # Failed test at t/db_dependent/Koha_borrower_modifications.t line 56. [...] 2) The unit tests do not have labels that would indicate what they are testing. 3) The breadcrumb on /cgi-bin/koha/members/members-update.pl has an incorrect link for the Patrons section (/cgi-bin/koha/members-home.pl instead of /cgi-bin/koha/members/members-home.pl). 4) When I try to confirm a patron via e-mail, I get the following in my logs and the patron is not created: INSERT INTO borrowers SET borrowers.dateenrolled = ? , borrowers.userid = ? , borrowers.categorycode = ? , borrowers.dateexpiry = ? , borrowers.password = ? , borrowers.cardnumber = ? 2012-12-13,,PT,2021-03-13,4eTMRTxoZ2tV15HgDg4fXw,23529001223641 at /home/jcamins/kohaclone/C4/SQLHelper.pm line 182. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at /home/jcamins/kohaclone/C4/SQLHelper.pm line 184.DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at /home/jcamins/kohaclone/C4/SQLHelper.pm line 184. Not blocking this patch, but just a comment: I am slightly dubious about the wisdom of allowing the public to register users on the OPAC without giving staff the ability to review those registrations. However, if this meets the needs of the library that requested the feature, I have no objection to including it in Koha as-is. Those libraries concerned with security can simply disable the feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #13765|0 |1 is obsolete|| --- Comment #129 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14085 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14085action=edit Bug 7067 - OPAC Borrower Self Registration This development will add the ability for a new patron to register himself or herself. The self-registration will attempt to match this newly inputted data to any existing patrons and if any possible matches are found, ask if the patron is sure he or she doesn't already have an account at the library. A system preference may be set to prevent patron self-registration if the system detects the possibility that the person may already have an account. Once the patron has registered, passing a captcha (or similar bot-stopper), the patron will then be optionally verified a second time via email. At this point, the patron will be able to print a temporary library card (optional by system preference), and will be provided any details necessary to access electronic resources (this body of text would be a template in the slips and notices system). At the library's choice, this new patron would either be set to a temporary patron status (patron type set via system preference), or a fully-fledged patron (allow patron type to be determined by age and/or other attributes). Assuming the library uses temporary patron types for OPAC registrations, this patron will next enter a queue and would need to physically enter the library to verify himself and become a fully-fledged patron (most likely by bringing in physical proof of address, etc.). The librarian would look up the patron record and modify the patron type. If a temporary patron has not been verified within a certain time frame (defined by a system preference), the patron record will be deleted from the system via a cron job. For registered patrons, the system will allow each person to also update his or her personal data via the OPAC. When a patron updates his or her information, the changes will be entered into a queue to be verified by a librarian (preventing a patron from inputting obviously bogus data). The staff client home page will display the number of patron records with changes awaiting approval. A librarian would then be able to click through a list of modification requests, and approve or deny each (with approval and denial alerts being sent to the patron via the standard messaging system). NEW SYSTEM PREFERENCES * PatronSelfRegistration * PatronSelfRegistrationDetectDuplicates * PatronSelfRegistrationVerifyByEmail * PatronSelfRegistrationPrintTemporaryCard * PatronSelfRegistrationUseTemporaryStatus * PatronSelfRegistrationExpireTemporaryAccountsDelay NEW NOTICE * Verify by email notice NEW SLIP * Temporary card slip NEW CRON JOB * delete_expired_opac_registrations.pl - Deletes patrons that have not been upgraded from the temporary status within the specified delay * delete_unverified_opac_registrations.pl - Deletes the unverified patrons based on the length of time specified in the PatronSelfRegistrationExpireTemporaryAccountsDelay The patron will register from self_registration.pl, linked off opac-main.pl if enabled. The registration page will be translatable to other languages in the same way that existing templates are. Test Plan: 1) Enable PatronSelfRegistration 2) Set PatronSelfRegistrationExpireTemporaryAccountsDelay to a number of days 3) Create a self-registered borrower category 4) Set PatronSelfRegistrationUseTemporaryStatus 5) Set PatronSelfRegistrationVerifyByEmail to Don't require 6) Go to OPAC, log out if logged in. 7) You should see the Register here link below the login box 8) Attempt to register yourself 9) Verify you can log in with your temporary password. 10) Set PatronSelfRegistrationVerifyByEmail to Require 11) Attempt another self-registration 12) Check the messages table, you should see a new message with a verification link. 13) Copy and paste the link into a web browser to verify the registration 14) Log in with the given credentials to verify the account was created. Test Plan - Part 2 - Borrower Modifications 1) Log in to OPAC, go to my personal details tab. 2) Make some modifications to your details. 3) Repeat steps 1 and 2 for two more borrowers. 4) Log in to Koha intranet with a user that can modify borrowers. 5) At the bottom of mainpage.pl, you should see: Patrons requesting modifications: 3 6) Click the link 7) Approve one change, deny a different one, and ignore the third, then submit. 8) Check the records, you should see the changes take affect on the approved one, and no changes to the other two. You should also
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #13766|0 |1 is obsolete|| Attachment #13767|0 |1 is obsolete|| --- Comment #130 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14086 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14086action=edit Bug 7067 [Follow-up: templates] allow patron self registration via the opac - Adding simple style to register link on home page - Adding unique ids to new pages and to blocks containing registration links - Adding better page titles and breadcrumb links to some pages - Correcting bug which meant incorrect message showed on registration page when OPACPatronDetails preferences is turned off - Passing patron details to opac-memberentry.tt so that patron's name can be displayed in breadcrumbs - Improving display in staff client of patron record updates waiting to be approved. - Adding a sort by name to output of pending patron record updates - Adding updated JqueryUI library files to include expanded widget options. The changes in this patch require the addition of the jQueryUI Accordion widget. Other pending patches are seeking to add enough of the other remaining missing widgets that it seems time to go ahead and add the rest. Future submissions which add usage of these widgets will have to be careful to make changes to Koha's CSS where necessary. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Passed-QA-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #13768|0 |1 is obsolete|| --- Comment #131 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14087 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14087action=edit Bug 7067: Followup FIX QA fails Signed-off-by: Owen Leonard oleon...@myacpl.org Fixed minor conflict in C4/Installer/PerlDependencies.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #13769|0 |1 is obsolete|| --- Comment #132 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14088 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14088action=edit Bug 7067 Followup: FIX merge updatedatabase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #13984|0 |1 is obsolete|| Attachment #14001|0 |1 is obsolete|| --- Comment #133 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14089 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14089action=edit Bug 7067 QA Followup Adjusts calling conventions to use hashrefs and eliminate redundant procedural/OO mixed code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #134 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14090 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14090action=edit Bug 7067 QA Followup - Add descriptions to tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #14025|0 |1 is obsolete|| --- Comment #31 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14091 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14091action=edit Bug 8033: Change javascipt behavior to degrade nicely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #135 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14092 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14092action=edit Bug 7067 - QA Followup - Fix failing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #136 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14093 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14093action=edit Bug 7067 - Fix bad url in breadcrumbs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #14024|0 |1 is obsolete|| --- Comment #32 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14094 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14094action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. Click the finish button You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Chris Cormack chr...@catalyst.net.nz Added copyright to print slip for SCO Modified POD and copyright. Also perltidied http://bugs.koha-community.org/show_bug.cgi?id=8033 updated print slip option to show on the click of the finish button instead of the submit button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #14026|0 |1 is obsolete|| --- Comment #33 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14095 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14095action=edit Bug 8033 follow-up removing tabs in indentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #14091|0 |1 is obsolete|| --- Comment #34 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14096 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14096action=edit Bug 8033: Change javascipt behavior to degrade nicely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14096|0 |1 is obsolete|| --- Comment #35 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14097 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14097action=edit Bug 8033: Change javascipt behavior to degrade nicely Signed-off-by: Elliott Davis elli...@test.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14095|0 |1 is obsolete|| --- Comment #36 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14098 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14098action=edit Bug 8033 follow-up removing tabs in indentation Signed-off-by: Elliott Davis elli...@test.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14094|0 |1 is obsolete|| --- Comment #37 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14099 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14099action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. Click the finish button You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Chris Cormack chr...@catalyst.net.nz Added copyright to print slip for SCO Modified POD and copyright. Also perltidied http://bugs.koha-community.org/show_bug.cgi?id=8033 updated print slip option to show on the click of the finish button instead of the submit button Signed-off-by: Elliott Davis elli...@test.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14099|0 |1 is obsolete|| --- Comment #38 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14100 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14100action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. Click the finish button You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Chris Cormack chr...@catalyst.net.nz Added copyright to print slip for SCO Modified POD and copyright. Also perltidied http://bugs.koha-community.org/show_bug.cgi?id=8033 updated print slip option to show on the click of the finish button instead of the submit button Signed-off-by: Elliott Davis elli...@test.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14098|0 |1 is obsolete|| --- Comment #39 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14101 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14101action=edit Bug 8033 follow-up removing tabs in indentation Signed-off-by: Elliott Davis elli...@test.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14097|0 |1 is obsolete|| --- Comment #40 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14102 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14102action=edit Bug 8033: Change javascipt behavior to degrade nicely Signed-off-by: Elliott Davis elli...@test.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8877] MARC21 field 511 missing from XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8877 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #6 from Mirko Tietgen mi...@abunchofthings.net --- Setting this back to needing QA as I disagree with the reasons for failing it and Katrin seemed to possibly agree with my objections on IRC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
