[Koha-bugs] [Bug 9395] Problem with callnumber and standard number search in OPAC and Staff Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9395 --- Comment #3 from Vitor Fernandes vfernan...@keep.pt --- Hi Galen, For me the default behaviour should be searching with phr because it's the only way that I can obtain consistent results. But when I asked this on the IRC and after talking with some persons there (jcamins, magnuse, etc), the idea was to maintain the default behaviour and introduce system preferences to allow searches with phr. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2283] Poor use of Not Found redirect in response to corrupt MARC record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2283 --- Comment #2 from MJ Ray (software.coop) m...@software.coop --- I would expect manual corruption to work but I've not tested it recently. If you would like to: truncate contents of biblioitems.marcxml in mysql and then try to view the detail page again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8946] Wrong label and missing values in UNIMARC coded fields advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 --- Comment #10 from mathieu saby mathieu.s...@univ-rennes2.fr --- There is a typo in my patch. I am making a followup. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9281] Impossible to create an order from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9281 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #5) What am I missing? Hi Katrin, Yep I forgot 1 thing, on the Add orders from page, click on the Save button instead of the Add order link. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8946] Wrong label and missing values in UNIMARC coded fields advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 --- Comment #11 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 14620 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14620action=edit letter v between 2 option tag In HTML code generated for advanced search, a useless v letter is visible between 2 option tag. This patch suppress v letter is outside option markup (and cosmetic change : lowercase Adult in public types) To test : check HTML code generated by advanced search. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8946] Wrong label and missing values in UNIMARC coded fields advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #12 from Martin Renvoize martin.renvo...@ptfs-europe.com --- I imagine you'll need to submit that as a new bug with the new patch as the current patch has already been pushed.. It should get signed off and pushed very quickly though if it's a single character change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7830] return policy error in hold policy by item type after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7830
MJ Ray (software.coop) m...@software.coop changed:
What|Removed |Added
CC||m...@software.coop
--- Comment #2 from MJ Ray (software.coop) m...@software.coop ---
Just seen this on a 3.10 but might have been introduced when that catalogue
upgraded to 3.8 - I think they used holds very rarely.
The patch to bug #7144 set default NULL but the code doesn't seem to handle a
NULL value for that column and it's not mentioned in the perldoc
C4/Circulation.pm.
Also, there appears to be a typo in the patch
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7533action=diff on
bug #7144 - prefernce where it should be preference.
Also, the patch seemed to add to installer/data/mysql/atomicupdate but not
updatedatabase.pl too, which might be a problem but doesn't seem to be harming
my catalogue.
Is the best fix for a database update branch_item_rules set returnbranch=
(C4::Context-preference('HomeOrHoldingBranchReturn') || 'homebranch') where
returnbranch is NULL, or to handle NULL better in C4/Circulation, or to handle
it in callers of C4::Circulation?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8946] Wrong label and missing values in UNIMARC coded fields advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 --- Comment #13 from mathieu saby mathieu.s...@univ-rennes2.fr --- Thank you. The RM confirmed : Yes please. The way to set the status back to Needs signoff is to reset it to ASSIGNED first, then switch it to Needs signoff, but one of my new policies is that follow-ups must be done on new bugs once a patch has been pushed to master. Regards, Jared So I will make a new bug M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9402] New: useless letter v between 2 option tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9402 Bug ID: 9402 Summary: useless letter v between 2 option tags Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: mathieu.s...@univ-rennes2.fr Followup of BZ8946 In HTML code generated for advanced search, a useless v letter is visible between 2 option tags. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9402] useless letter v between 2 option tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9402 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Assignee|gmcha...@gmail.com |mathieu.saby@univ-rennes2.f ||r -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9402] useless letter v between 2 option tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9402 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9402] useless letter v between 2 option tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9402 --- Comment #1 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 14621 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14621action=edit [PATCH] Bug 9402: letter v between 2 option tags In HTML code generated for advanced search, a useless v letter is visible between 2 option tags. This patch suppress v letter is outside option markup (and cosmetic change : lowercase Adult in public types) To test : check HTML code generated by advanced search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9402] useless letter v between 2 option tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9402 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8946] Wrong label and missing values in UNIMARC coded fields advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8946 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Attachment #14620|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comments: The patch is clean and works well. But I have some remarks: - template_name = members/purchase-suggestions.tmpl could be .tt - in suggestion.pl, %hashlists is passed twice. - in suggestion.pl, $redirect could be eq to purcharse-suggestion with a new param borrowernumber=[%borrowernumber%] in order to open the possibility for an other script to use this redirection. - in purchase-suggestion.tt, some includes are useless: calendar.inc, tablesorter.js - The new tab is sometimes displayed on 2 lines and sometimes on 1 lines depending on which tab is enabled. I don't know how to fix that... - on the way, could you fix 4 withespaces: * suggestion/suggestion.pl FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (77) The patch introduces a forbidden pattern: withespace character (138) * koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (71) The patch introduces a forbidden pattern: withespace character (62) Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9403] New: Material type icons not showing for XSLT default view in intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9403 Bug ID: 9403 Summary: Material type icons not showing for XSLT default view in intranet Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de In the OPAC result list with XSLT set to default we show a little icon after 'Type' and before the description: Type: icon serial We should show the same icons in the intranet XSLT default result list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8401] Search term deleted from system preference content
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 Jorge de Cardenas jd...@smfpl.org changed: What|Removed |Added CC||jd...@smfpl.org --- Comment #1 from Jorge de Cardenas jd...@smfpl.org --- I can confirm this behavior and it can have some serious consequences. I was working with the Self Checkout and was editing the SCOUserCSS. I have several entries similar to #selfCheckOutHeader. To get back to the SCOUserCSS I would search for self. If I made any changes and saved, the word self would be dropped from any entry. Example: #selfCheckOutHeader would become #CheckOutHeader. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8363] Update an issuing rule
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8363 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED CC||jonathan.dru...@biblibre.co ||m Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- *** This bug has been marked as a duplicate of bug 4354 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- *** Bug 8363 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14622 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14622action=edit Bug 4354: Cannot edit existing issuing rules This patch adds javascript which pulls the values from the chosen row of data and populates the last row's form with that data. Some changes have been made to the markup to better accommodate this. Possibly missing is some kind of visual feedback to the user that the edit action is taking place in a different row from where they clicked. Comments are especially welcomed on this aspect of the interaction. The original author of this patch is Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9404] Search of global system preferences deletes css and js code on Save
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9404 --- Comment #1 from Fred P fred.pie...@smfpl.org --- Bug 8401 is related. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #8 from Paul Poulain paul.poul...@biblibre.com --- Kyle, ping !!! You haven't answered my last-august question, and this patch seems lost in limbos. Could you answer and try to have it exiting from in discussion ? thx (In reply to comment #5) QA Comment: This patch is highly sensible, because it changes Circulation behaviour. It replaces: SELECT COUNT(*) FROM issues JOIN items USING (itemnumber) WHERE borrowernumber = ? AND issues.branchcode = ? (or AND items.homebranch = ? or nothing, depending on sysprefs) by a simple SELECT COUNT(*) FROM issues WHERE borrowernumber = ? Digging into the code, I see that the comparison is made against GetBranchBorrowerCircRule, which retrieve data from branch_borrower_circ_rules Looking at admin/smart-rules.pl, I see that the description says: = Checkout limit by patron category for LIBRARY NAME For this library, you can specify the maximum number of loans that a patron of a given category can make, regardless of the item type. If the total amount loanable for a given patron category is left blank, no limit applies, except possibly for a limit you define for a specific item type. = I feel it's unclear. What does For this library mean exactly ? is it for items checked out from this library For patrons registered at this library ? The sub GetBranchBorrowerCircRule is called with $branch and $cat_borrower parameters $branch is filled depending on sysprefs by _GetCircControlBranch, that return a value depending on CircControl syspref the patch, if I understand it well, understand the smart-rule.pl description as: For patrons registered to this library, you can specify the maimum number of loans, all branches included So it discard the behaviour: You can specify the maximum number of loans that a patron can do from this library As a conclusion, I feel that this patch could unplease some libraries. Maybe more explanations are needed on smart-rules.pl. Is there something I misunderstood ? (Am I clear in my explanations -because it's quite tricky- ?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9404] Search of global system preferences deletes css and js code on Save
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9404 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Actually this is a duplicate of bug 8401. *** This bug has been marked as a duplicate of bug 8401 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8401] Search term deleted from system preference content
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added CC||fred.pie...@smfpl.org --- Comment #2 from Owen Leonard oleon...@myacpl.org --- *** Bug 9404 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3474] Handling of and report for expired or cancelled holds, display expiration dates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3474 MJ Ray (software.coop) m...@software.coop changed: What|Removed |Added CC||m...@software.coop Component|Hold requests |Reports Version|rel_3_0 |master --- Comment #1 from MJ Ray (software.coop) m...@software.coop --- There's a report for cancelled holds at http://wiki.koha-community.org/wiki/SQL_Reports_Library#Cancelled_Holds and there's now a expirationdate column in reserves and old_reserves, so I think a similar report for expired holds could be written. I think this is current and doesn't need any further code changes, so I'm moving this from rel_3_0 / Hold requests to master / Reports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4494] Staff client incorrectly reports no copies available to be placed on hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4494 MJ Ray (software.coop) m...@software.coop changed: What|Removed |Added Status|NEW |RESOLVED CC||m...@software.coop Resolution|--- |WORKSFORME --- Comment #1 from MJ Ray (software.coop) m...@software.coop --- I just tested this and Too Many Holds: Henry Acevedo has too many holds. now appears without No copies are available to be placed on hold so I think this has been fixed without being noted here yet. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #9 from Galen Charlton gmcha...@gmail.com --- Created attachment 14623 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14623action=edit Bug 9312: strict perl for picture-upload.pl Testing - this is a code-cleanup patch, so the purpose of testing is to ensure that patron image upload functionality still works. To test: - Turn on the patronimages system preference - Go to Tools | Upload patron images and import a suitable image for a test patron. - Bring up the test patron and verify that the image is attached. - From the patron details page, upload a replacement image. - Create a patron image ZIP file containing at least two images ( per the documentation of the patron image feature) and load it via the patron image import tool. - Verfiy that the test patrons now have images. - Verify that tools/picture-upload.pl didn't report any errors in the Apache error log. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #14255|0 |1 is obsolete|| Attachment #14256|0 |1 is obsolete|| Attachment #14623|0 |1 is obsolete|| --- Comment #10 from Galen Charlton gmcha...@gmail.com --- Created attachment 14624 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14624action=edit Bug 9312: strict perl for picture-upload.pl Testing - this is a code-cleanup patch, so the purpose of testing is to ensure that patron image upload functionality still works. To test: - Turn on the patronimages system preference - Go to Tools | Upload patron images and import a suitable image for a test patron. - Bring up the test patron and verify that the image is attached. - From the patron details page, upload a replacement image. - Create a patron image ZIP file containing at least two images ( per the documentation of the patron image feature) and load it via the patron image import tool. - Verfiy that the test patrons now have images. - Verify that tools/picture-upload.pl didn't report any errors in the Apache error log. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #12 from Galen Charlton gmcha...@gmail.com --- Created attachment 14626 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14626action=edit Bug 9312: fix a couple more uninitialized variable warnings Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #11 from Galen Charlton gmcha...@gmail.com --- Created attachment 14625 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14625action=edit Bug 9312: whitespace cleanup for picture-upload.pl Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #13 from Galen Charlton gmcha...@gmail.com --- Note that in the course of signing off I added a test plan, reworded a commit message, and added a followup patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9402] useless letter v between 2 option tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9402 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9402] useless letter v between 2 option tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9402 --- Comment #2 from Galen Charlton gmcha...@gmail.com --- Created attachment 14627 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14627action=edit Bug 9402: letter v between 2 option tags In HTML code generated for advanced search, a useless v letter is visible after dissertation or thesis (revised)/option. This patch suppress v letter is outside option markup (and cosmetic change : Adult - adult in public types) To test : check HTML code generated by advanced search. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9402] useless letter v between 2 option tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9402 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9405] New: Error in french PO for OPAC (3.10)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9405 Bug ID: 9405 Summary: Error in french PO for OPAC (3.10) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.s...@univ-rennes2.fr CC: frede...@tamil.fr There is an extra # in french PO for OPAC, l. 17721 # #: opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl:133 #, c-format msgid of contents page, msgstr de la table des matières, ./translate update fr-FR Use of uninitialized value $key in hash element at /usr/share/perl5/Locale/PO.pm line 466, IN line 17721. Use of uninitialized value in hash element at /usr/share/perl5/Locale/PO.pm line 449, IN line 17721. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9405] Error in french PO for OPAC (3.10)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9405 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8401] Search term deleted from system preference content
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|minor |critical --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I had it happen to me too which ended in rewriting checking lots of html code. Upping severity a bit, as this bug results in unintentional data loss. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8401] Search term deleted from system preference content
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401
--- Comment #5 from Fred P fred.pie...@smfpl.org ---
I believe the problem originates with this file:
File: jquery.highlight-3.js
Path: /home/koha/kohaclone/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins
Removal of this function appears to resolve the issue,
not sure about side-effects:
--
jQuery.fn.removeHighlight = function() {
return this.find(span.term).each(function() {
this.parentNode.firstChild.nodeName;
with (this.parentNode) {
replaceChild(this.firstChild, this);
normalize();
-
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8401] Search term deleted from system preference content
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 --- Comment #6 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #5) Removal of this function appears to resolve the issue, not sure about side-effects: Side-effects would be breaking the functionality of search term highlighting in all areas of the staff client which use the plugin. The solution is either to disable search term highlighting altogether on this page (perhaps the short-term solution) or to fix the scope of the highlighting so that it excludes textareas (something I'm not sure is possible). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9376] Problem with dateexpiry display in moremember.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 --- Comment #2 from Galen Charlton gmcha...@gmail.com --- Confirmed that this affect 3.10.x. It doesn't affect master, but only because of how the patch for bug 6261 reworks the member toolbar to use member/setstatus.pl rather than members/moremember.pl to renew the patron. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9376] Problem with dateexpiry display in moremember.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #14529|0 |1 is obsolete|| --- Comment #3 from Galen Charlton gmcha...@gmail.com --- Created attachment 14628 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14628action=edit Bug 9376: Problem with dateexpiry display in moremember.tt There is a problem that brokens the interface of moremmeber when displaying the date expiry when renewing a patron. In the first comment I said that the line that causes the error should be: span class=reregitryinfo[% dateexpiry %]/span but the correct way should be: strong class=reregitryinfo[% dateexpiry %]/strong This way the date expiry after renew a patron appears in bold. Test plan: - before applying the patch try to renew a patron and check that almost everything went bold - apply the patch - renew a patron and only the expiration date is bolder. - Note that the bug doesn't manifest in master because the patch for bug 6261 causes the invalid HTML to never be reached; it *does* affect 3.10.x and earlier. Sponsored-by: KEEP SOLUTIONS Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9376] Problem with dateexpiry display in moremember.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 --- Comment #4 from Galen Charlton gmcha...@gmail.com --- Created attachment 14629 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14629action=edit Bug 9376: extend HTML fix to moremember-brief.tt Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9376] Problem with dateexpiry display in moremember.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Galen Charlton gmcha...@gmail.com --- Note that I added a follow-up patch along with my signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9406] New: no confirmation displayed after renewing a patron from details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9406 Bug ID: 9406 Summary: no confirmation displayed after renewing a patron from details page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: gmcha...@gmail.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com As an apparent side-effect of the patch for bug 6261, after renewing a patron from the patron details page (as opposed to the checkout page), the Patron's account has been renewed until XXX message is no longer displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9406] no confirmation displayed after renewing a patron from details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9406 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Depends on||9376 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9376] Problem with dateexpiry display in moremember.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Blocks||9406 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8401] Search term deleted from system preference content
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401
--- Comment #7 from Fred P fred.pie...@smfpl.org ---
Instead of editing jquery plug-ins, which may be referenced offsite, a simple
edit to the Koha code fixes the problem. Needs testing, but I am not seeing any
issues. Notice this function only affects the preferences table:
File: preferences.js
Path: /home/koha/kohaclone/koha-tmpl/intranet-tmpl/prog/en/js/pages
if ( to_highlight ) {
var words = to_highlight.split( ' ' );
$( '.prefs-tab table' ).find( 'td, th' ).not( '.name-cell'
).each( function ( i, td ) {
$.each( words, function ( i, word ) { $( td ).highlight( word ) } );
- } ).find( 'option' ).removeHighlight();
}
Replace the second-to-last line:
+ } )
}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9406] no confirmation displayed after renewing a patron from details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9406 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9406] no confirmation displayed after renewing a patron from details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9406 --- Comment #1 from Galen Charlton gmcha...@gmail.com --- Created attachment 14630 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14630action=edit bug 9406: ensure confirmation of patron renewal is displayed When renewing a patron from the patron details page, ensure that the Patron's account has been renewed until XXX is actually displayed. This patch introduces a was_renewed CGI and template parameter to clarify the intent of the relevent template sections. To test: - Before applying the patch, renew a patron from the patron details page and verify that you don't see the renewal confirmation. - After applying the patch, renew the patron from the details page and verify that the Patron's account has been renewed until XXX message shows up. - Renew the patron from the checkout page and verify that the confirmation message shows up. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9406] no confirmation displayed after renewing a patron from details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9406 --- Comment #2 from Galen Charlton gmcha...@gmail.com --- Testers take note: this patch assumes that the patches for 9376 have been applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Sorry! The answer is For patrons registered at this library. You haven't answered my last-august question, and this patch seems lost in limbos. Could you answer and try to have it exiting from in discussion ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9274] Software error in bibtex export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9274 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton gmcha...@gmail.com --- I'm a little hesitant about the code duplication, but I agree that GetMarcAuthors isn't suitable (even with the crash put aside). However, the way that names are constructed isn't quite right for MARC21, as the 700$b is *not* the first name, it's numeration associated with the name (e.g., John Doe III), and consequently should not precede the contents of $a. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9274] Software error in bibtex export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9274 --- Comment #7 from Galen Charlton gmcha...@gmail.com --- Created attachment 14631 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14631action=edit Bug 9274: fix BibTex export to use GetMarcAuthors correctly This is a proposed patch that simply fixes the crash without changing behavior. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9274] Software error in bibtex export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9274 --- Comment #8 from Galen Charlton gmcha...@gmail.com --- I've attached a counter-patch that simply avoids the crash without changing behavior. If we decide to change how MARC is translated to BibTex, we may as well work on bug 6201 as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9274] Software error in bibtex export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9274 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9274] Software error in bibtex export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9274 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Blocks||6201 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Depends on||9274 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14632|0 |1 is obsolete|| --- Comment #73 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14633 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14633action=edit Bug 7804 - Add Koha Plugin System - Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8401] Search term deleted from system preference content
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 Fred P fred.pie...@smfpl.org changed: What|Removed |Added Priority|P5 - low|P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #74 from Kyle M Hall k...@bywatersolutions.com --- 1) Koha::Plugins cannot be used without a koha-conf.xml file that is configured to enable plugins. That's a problem! The check needs to be done at run-time rather than compile time. Fixed! 2) The unit test in t/Plugins.t is data dependent. It would be much better to mock the configuration data. Barring that, the test should be moved to t/db_dependent. Moved to db_dependent 3) The test adds '.' to @INC. Unfortunately, tests are not usually run from t/, so it always fails when I run prove t/. The solution is to get the directory component from __FILE__ Fixed! 4) The test fails spectacularly for me: Assuming you have all the required perl dependencies install, I'm stumped on this one. All the tests pass just fine for me. Do you have CAS enabled? It seems to be related to that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8516] Add a Street Address search option to the patrons search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8516 MJ Ray (software.coop) m...@software.coop changed: What|Removed |Added Blocks||9407 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9407] New: patrons search should match substrings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9407 Bug ID: 9407 Summary: patrons search should match substrings Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: http://intranet/cgi-bin/koha/members/member.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: m...@software.coop CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 8516 If a patron lives at 4345 Library Rd, a search on Street Address for Library should find it. However, it does not, but a search for 4345 Library does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9408] New: make test fails on master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9408
Bug ID: 9408
Summary: make test fails on master
Classification: Unclassified
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Installation and upgrade (command-line installer)
Assignee: gmcha...@gmail.com
Reporter: h...@davenport.net.nz
May be related partially to Bug 8848
hugh@hugh-desktop:~/code/koha (master)$ make test
PERL_DL_NONLAZY=1 KOHA_CONF=blib/KOHA_CONF_DIR/koha-conf.xml /usr/bin/perl
-MExtUtils::Command::MM -e test_harness(0, 'blib/PERL_MODULE_DIR',
'blib/arch') t/*.t
t/00-checkdatabase-version.t ok
t/00-deprecated.t ... ok
t/00-load.t . 1/? my variable $stylesheet masks
earlier declaration in same scope at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Record.pm line 313.
Subroutine main::logaction redefined at /usr/share/perl/5.14/Test/More.pm line
885.
Too late to run INIT block at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/hbyymmincr.pm line 41.
Subroutine main::GetContract redefined at /usr/share/perl/5.14/Test/More.pm
line 885.
Too late to run INIT block at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/External/BakerTaylor.pm line 42.
t/00-load.t . 100/? my variable $DEBUG masks earlier
declaration in same scope at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 43.
my variable $DEBUG masks earlier declaration in same scope at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 77.
t/00-load.t . ok
t/00-merge-conflict-markers.t ... ok
t/00-testcritic.t ... skipped: Author test. Set $ENV{TEST_QA}
to a true value to run
t/00-valid-xml.t ok
t/AuthoritiesMarc_MARC21.t .. ok
t/AuthoritiesMarc_UNIMARC.t . ok
t/Barcodes_annual.t . ok
t/Barcodes_EAN13.t .. ok
t/Barcodes_hbyymmincr.t . ok
t/Barcodes_incremental.t ok
t/Barcodes_PrinterConfig.t .. 1/6 Use of uninitialized value
$labelHeigth in division (/) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line
113.
Use of uninitialized value $marginBottom in addition (+) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line
113.
Use of uninitialized value $labelHeigth in multiplication (*) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line
115.
Use of uninitialized value $rows in numeric lt () at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line
117.
Use of uninitialized value $labelWidth in division (/) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 84.
Use of uninitialized value $marginLeft in addition (+) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 84.
Use of uninitialized value $labelWidth in multiplication (*) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 86.
Use of uninitialized value $columns in numeric lt () at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 88.
Use of uninitialized value $labelHeigth in division (/) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line
113.
Use of uninitialized value $marginBottom in addition (+) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line
113.
Use of uninitialized value $labelHeigth in multiplication (*) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line
115.
Use of uninitialized value $labelWidth in division (/) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 84.
Use of uninitialized value $marginLeft in addition (+) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 84.
Use of uninitialized value $labelWidth in multiplication (*) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 86.
Use of uninitialized value $rows in numeric le (=) at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line
193.
t/Barcodes_PrinterConfig.t .. ok
t/Barcodes_ValueBuilder.t ... my variable $DEBUG masks earlier
declaration in same scope at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 43.
my variable $DEBUG masks earlier declaration in same scope at
/home/hugh/code/koha/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 77.
t/Barcodes_ValueBuilder.t ... ok
t/Bookseller.t .. ok
t/Boolean.t . 1/13 The given value does not seem to be
interpretable as a Boolean value at t/Boolean.t line 20.
The given
[Koha-bugs] [Bug 9398] [ ? ] Link Lacks Context for All General Users (Accessibility) [Contexual Help]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9398 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Attachment #14611|0 |1 is obsolete|| --- Comment #2 from Liz Rea wizzy...@gmail.com --- Created attachment 14634 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14634action=edit bug 9398 - [ ? ] Link Lacks Context for All General Users (Accessibility) [Contexual Help] testing procedure: 1. see that [ ? ] has simply been changed to 'Help' Signed-off-by: Liz Rea l...@catalyst.net.nz I like this change, the context is improved even for sighted individuals, and it helps screen reader users a great deal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9398] [ ? ] Link Lacks Context for All General Users (Accessibility) [Contexual Help]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9398 Liz Rea (CatalystIT) l...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||l...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9408] make test fails on master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9408 --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- Hugh, Those tests fail because the calendar code is broken in master (and 3.10). There is a patch fixing the problem on bug 9211, but before I push it I need feedback on how to test the problem other than with the unit test. Regards, Jared -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14150|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14635 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14635action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9407] patrons search should match substrings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9407 --- Comment #1 from MJ Ray (software.coop) m...@software.coop --- Created attachment 14636 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14636action=edit Bug 9070: patrons search should match substrings If a patron lives at 4345 Library Rd, a search on Street Address for Library should find it. However, it does not, but a search for 4345 Library does. This patch adds a Search Type drop-down, defaulting to the current behaviour. To test: 1) Search for a patron based on a non-leading part of a field. 2) Should return no results. 3) Search again with Search Type of Contains. 4) Should return the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9407] patrons search should match substrings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9407 MJ Ray (software.coop) m...@software.coop changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9407] patrons search should match substrings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9407 MJ Ray (software.coop) m...@software.coop changed: What|Removed |Added Attachment #14636|0 |1 is obsolete|| --- Comment #2 from MJ Ray (software.coop) m...@software.coop --- Created attachment 14637 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14637action=edit Bug 9407: patrons search should match substrings If a patron lives at 4345 Library Rd, a search on Street Address for Library should find it. However, it does not, but a search for 4345 Library does. This patch adds a Search Type drop-down, defaulting to the current behaviour. To test: 1) Search for a patron based on a non-leading part of a field. 2) Should return no results. 3) Search again with Search Type of Contains. 4) Should return the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9151] Renewal notice according to patron alert preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 --- Comment #20 from Hugh Davenport h...@davenport.net.nz --- Created attachment 14638 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14638action=edit bug 9151 follow-up: fix sample notice SQL for en Fix two different errors that prevented sample notices from being loaded into a fresh English Koha database. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Hugh Davenport h...@davenport.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9151] Renewal notice according to patron alert preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9151] Renewal notice according to patron alert preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9151 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added Attachment #14477|0 |1 is obsolete|| Attachment #14638|0 |1 is obsolete|| --- Comment #21 from Hugh Davenport h...@davenport.net.nz --- Created attachment 14639 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14639action=edit bug 9151 follow-up: fix sample notice SQL for en Fix two different errors that prevented sample notices from being loaded into a fresh English Koha database. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Hugh Davenport h...@davenport.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14635|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14640 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14640action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #2 from Hugh Davenport h...@davenport.net.nz --- Created attachment 14641 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14641action=edit bug 9062 Fix format for discount rate for vendors On the vendor display and edit screens, the tax rate information was formatted to 1 decimal point, while the discount rate was not. This patch adds a format string to the discount information so that it is formatted in the same way. Signed-off-by: Hugh Davenport h...@davenport.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added CC||h...@davenport.net.nz Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9409] New: koha-create --request-db should be able to accept a dbhost option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409 Bug ID: 9409 Summary: koha-create --request-db should be able to accept a dbhost option Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcha...@gmail.com Reporter: ibeards...@gmail.com koha-create --request-db should be able to accept a dbhost option and write that to koha-conf.xml When installing koha via the debian packages with the database on a separate host, as per http://wiki.koha-community.org/wiki/Install_Koha_3.6_on_Debian_squeeze_using_a_separate_MySQL_server, it is suggested that you run .. koha-create --request-db mylibrary This creates a text file with the appropriate details to use to create the mysql database, it also writes the database name, user and password into the /etc/koha/sites/mylibrary/koha-conf.xml file. But this process leaves the hostname unpopulated, essentially defaulting to 'localhost'. That config option has to be manually entered for a remote database host. Ideally one should be able to use .. koha-create --request-db mylibrary --dbhost databaseserver koha-create should also return details on where to change the hostname of the database server (whether the --dbhost option is used or not). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #14641|0 |1 is obsolete|| --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 14642 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14642action=edit bug 9062 Fix format for discount rate for vendors On the vendor display and edit screens, the tax rate information was formatted to 1 decimal point, while the discount rate was not. This patch adds a format string to the discount information so that it is formatted in the same way. Signed-off-by: Hugh Davenport h...@davenport.net.nz Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #4 from Hugh Davenport h...@davenport.net.nz --- Actually, would this need changing for other languages? or is that done by translators? I only have an en directory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- That's done by the translation scripts, they build other directories from the .po files. So all good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9408] make test fails on master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9408 --- Comment #2 from Hugh Davenport h...@davenport.net.nz --- Ah right, sorry didn't find that bug in my searches :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #6 from Hugh Davenport h...@davenport.net.nz --- Created attachment 14643 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14643action=edit bug 9062 Fix spacing next to tax rate On the supplier view screen, there was a space after the discount and before the % sign, but there was none for the tax rate. This patch adds in a patch, so they look similar. Signed-off-by: Hugh Davenport h...@davenport.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #14643|0 |1 is obsolete|| --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 14644 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14644action=edit bug 9062 Fix spacing next to tax rate On the supplier view screen, there was a space after the discount and before the % sign, but there was none for the tax rate. This patch adds in a patch, so they look similar. Signed-off-by: Hugh Davenport h...@davenport.net.nz Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7274] Fix formatting of actual cost on order receive page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7274 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added CC||h...@davenport.net.nz --- Comment #1 from Hugh Davenport h...@davenport.net.nz --- Can't reproduce this sorry :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |h...@davenport.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9410] New: Formatting of the discount field when doing a new order from new empty record is not correct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Bug ID: 9410 Summary: Formatting of the discount field when doing a new order from new empty record is not correct Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: h...@davenport.net.nz Discount shows 4 decimal places, it should show 1 like other places that show discount rate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #1 from Hugh Davenport h...@davenport.net.nz --- Created attachment 14645 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14645action=edit bug 9410 Fix formatting of discount rate The formatting for discount doesn't limit the number of decimal points for the discount rate when creating a new order from an empty record. This patch fixes that by limiting it to 2dp Signed-off-by: Hugh Davenport h...@davenport.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |h...@davenport.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #8 from Hugh Davenport h...@davenport.net.nz --- Just wondering whether the number of decimal points for the discount feild should be 1 or 2, it is shown as 2 in some other places, but my patch puts it to 1 here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz --- Actually that is a good question ... 2 I think probably makes more sense. Any other opinions? It's for percentages right? 2dp makes sense to me for that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9062] Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #10 from Hugh Davenport h...@davenport.net.nz --- Yeh, and then most of the Tax percentages I've seen are just 1dp -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5060] Quantity change not updating total price
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5060 Hugh Davenport h...@davenport.net.nz changed: What|Removed |Added CC||h...@davenport.net.nz --- Comment #2 from Hugh Davenport h...@davenport.net.nz --- Hi Katrin, I can't seem to replicate this. I'm using the from a new (empty) record item. When I add or remove a new item, the quantity increases, and the total adjusts automatically. Cheers, Hugh -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
