[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 --- Comment #43 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #42) See bug 9256 for some unintended consequences of this bug. The needed followup for packages was already mentioned on October 18. Looks like it never made it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 --- Comment #44 from Magnus Enger mag...@enger.priv.no --- (In reply to comment #43) (In reply to comment #42) See bug 9256 for some unintended consequences of this bug. The needed followup for packages was already mentioned on October 18. Looks like it never made it? Yup. Attachment 12903 should never have made it into Koha without that followup for the packages. The need for a followup was first mentioned by Chris C. on July 1st, in comment 9. (BTW, I just upgraded a git-install to current master yesterday and that worked nicely after i ran through the upgrade process, even for NORMARC.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Depends on||9256 --- Comment #45 from Frédéric Demians frede...@tamil.fr --- (En réponse au commentaire 44) (In reply to comment #43) (In reply to comment #42) See bug 9256 for some unintended consequences of this bug. The needed followup for packages was already mentioned on October 18. Looks like it never made it? Yup. Attachment 12903 [details] should never have made it into Koha without that followup for the packages. The need for a followup was first mentioned by Chris C. on July 1st, in comment 9. (BTW, I just upgraded a git-install to current master yesterday and that worked nicely after i ran through the upgrade process, even for NORMARC.) Koha Z39.50 saying -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Blocks||3087 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 --- Comment #46 from Frédéric Demians frede...@tamil.fr --- Yup. Attachment 12903 [details] should never have made it into Koha without that followup for the packages. The need for a followup was first mentioned Koha Z39.50 server saying it returns MARC21 records when it returns UNIMARC or NORMARC is a bug. Of course, it can be decided that it's a marginal bug since it 'only' affects French UNIMARC Koha users exposing their catalog via Z39.50... And so let revert this patch. Otherwise, Debian packages have to be updated. I can help. But I don't use packages, and so would need Robin assistance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 --- Comment #47 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #46) Yup. Attachment 12903 [details] should never have made it into Koha without that followup for the packages. The need for a followup was first mentioned Koha Z39.50 server saying it returns MARC21 records when it returns UNIMARC or NORMARC is a bug. Of course, it can be decided that it's a marginal bug since it 'only' affects French UNIMARC Koha users exposing their catalog via Z39.50... And so let revert this patch. Otherwise, Debian packages have to be updated. I can help. But I don't use packages, and so would need Robin assistance. I am in favour of reverting this until it is fixed, if it is not fixed by 3.10.3 I will revert it out of 3.10.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5634] Ordering branches should be case independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9457 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Patch submitted on bug 9457 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9457] Ordering branches should be case independent (2)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9457 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=5634 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9462] Use DataTables on patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi Owen, The holdst is really small and does not extend to the width of the container (div id=holdst_wrapper). I don't know why, I did not find the difference with the issuest table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 --- Comment #49 from Frédéric Demians frede...@tamil.fr --- I am in favour of reverting this until it is fixed, if it is not fixed by 3.10.3 I will revert it out of 3.10.x I'm in favour of reverting Debian packages from Koha. It may just be me, but I don't use packages :-) Who exactly is affected by this bug? Neither my UNIMARC nor my MARC21 libraries are. Who will fix that? Since I don't have a clue how packages work, I can't do it alone. Nobody having interest in this, does it mean that I just have to wait, time passes, and see the reversion of this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 --- Comment #50 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #49) I am in favour of reverting this until it is fixed, if it is not fixed by 3.10.3 I will revert it out of 3.10.x I'm in favour of reverting Debian packages from Koha. It may just be me, but I don't use packages :-) It's just as well you are not release maintainer then isn't it :) Who exactly is affected by this bug? Neither my UNIMARC nor my MARC21 libraries are. Any library that uses the packages and does not use MARC21 will have a broken search, that is UNIMARC and NORMARC package users. This doesn't affect any of my libraries, but obviously thinking about only our libraries is a bad idea, and how we got into this mess in the first place Who will fix that? Since I don't have a clue how packages work, I can't do it alone. Nobody having interest in this, does it mean that I just have to wait, time passes, and see the reversion of this patch? I will work with Robin and Magnuse to try to undo this major regression with patches to make it so you can have more than one flavour of MARC on a server, and allow search to work with non MARC21 package installs also. I will also try to be more vocal next time so this doesn't happen again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 --- Comment #51 from Frédéric Demians frede...@tamil.fr --- Any library that uses the packages and does not use MARC21 will have a broken search, that is UNIMARC and NORMARC package users. This doesn't affect any of my libraries, but obviously thinking about only our libraries is a bad idea, and how we got into this mess in the first place You're judging on mere intent. In the first place, this mess occurs because the intricacy of standard installation and package installation is complex, and well known by few. Let's stay positive, and be assure my motives are not exempt of altruism... It is not from the benevolence of the butcher, the brewer, or the baker, that we expect our dinner, but from their regard to their own interest, as said Adam Smith. The question is to find out how to conciliate our own interest with Koha public good. I will work with Robin and Magnuse to try to undo this major regression with patches to make it so you can have more than one flavour of MARC on a server, and allow search to work with non MARC21 package installs also. I will also try to be more vocal next time so this doesn't happen again. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 --- Comment #52 from Chris Cormack ch...@bigballofwax.co.nz --- Adam Smith also said To feel much for others and little for ourselves; to restrain our selfishness and exercise our benevolent affections, constitute the perfection of human nature. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9479] New: The member notices page does not display dates in the syspref format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9479 Bug ID: 9479 Summary: The member notices page does not display dates in the syspref format Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In the member notices page, the time column is not displayed according the syspref format -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9480] New: Set barcode width and height configurable with system preferences in patron card creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9480 Bug ID: 9480 Summary: Set barcode width and height configurable with system preferences in patron card creator Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: vfernan...@keep.pt Problem: - barcode width scale is always set to 0.8 of the total width - barcode height scale is always set to 0.01 of total height - happens in 3.8.X, 3.10.X and master code Solution: - create a system preference to control width scale name BarcodeWidthScale (default: 0.8) - create a system preference to control height scale name BarcodeHeightScale (default: 0.01) - change Patroncard.pm to use the variables instead of the default values (if the sysprefs are empty uses the default values). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14796|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14810 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14810action=edit Bug 9463 - Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- I found an issue (not introduced with your patch) : the time column is not displayed in the syspref format. I opened a new bug 9479 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9480] Set barcode width and height configurable with system preferences in patron card creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9480 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Priority|P5 - low|P2 Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|gmcha...@gmail.com |vfernan...@keep.pt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9479] The member notices page does not display dates in the syspref format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9479 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14811 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14811action=edit Bug 9479: The member notices page does not display dates in the syspref format In order to let the KohaDates plugin display a datetime, this patch modify this plugin. Now it uses Koha::DateUtils instead of C4::Dates. Test plan: - check that the date format on the member notices page (members/notices.pl) is displayed according your syspref dateformat. - check that existing dates are always in the good format (without the hours) e.g. acqui/histsearch.pl, acqui/basket.pl, etc. - Modify your syspref and recheck the previous pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9479] The member notices page does not display dates in the syspref format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9479 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9479] The member notices page does not display dates in the syspref format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9479 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9464] Update DataTables configuration on patron statistics page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9464 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14797|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14813 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14813action=edit Bug 9464 - Update DataTables configuration on patron statistics page This page removes an unnecessary link to the old tablesorter plugin and changes the configuration details of the DataTables plugin so that an empty filter box doesn't appear as dot above and below the table (an empty div with a 1-pixel border). To test, open the patron statistics page for a patron who has entries to display. Sorting should work normally and no dots should be seen. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9464] Update DataTables configuration on patron statistics page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9464 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9462] Use DataTables on patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #2) The holdst is really small and does not extend to the width of the container I noticed this on the branch transfers page as well. If you have a sorted table in a hidden tab the table doesn't expand to the width one would expect. On the branch transfers page I ended up setting an explicit min-width on the table. When I tested this patch the problem wasn't as noticeable, but that was probably due to the data I had in the table. Setting an explicit width here too could be a solution. I would like to see a screenshot if that is possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 --- Comment #53 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #48) (In reply to comment #47) I am in favour of reverting this until it is fixed, if it is not fixed by 3.10.3 I will revert it out of 3.10.x I think Jared thought it was too late to revert it, because it would break things for people who already upgraded to 3.10.x. But I'll let him speak for himself, of course. Yeah, reverting it would break existing standard installs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7595] Add branchcode to accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12394|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14814 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14814action=edit [SIGNED-OFF] Bug 7595 - Add branchcode to accountlines Adds a branchcode column to the accountlines table. For payments, this inserts the branchcode of the library where the payment was recorded. For manual invoices, it insert the branchcode of the library where the manual invoice was created. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com I tested with creating manual invoices, and paying partial fines, entire fine lines, and writing off fines. All actions record the branch where the action took place properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7595] Add branchcode to accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12395|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14815 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14815action=edit Bug 7595 - Add branchcode to accountlines - Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7595] Add branchcode to accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9481] New: charge not showing fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Bug ID: 9481 Summary: charge not showing fines Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 14816 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14816action=edit $0 charges When looking at the patron record or the checkout screen the checkout summary is now showing 0 for all the Charges even if the item was overdue and has accrued fines. This column I think used to show the fine amount. I have confirmed in 3.8.5 and master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9481] charge not showing fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- Created attachment 14817 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14817action=edit fines for those titles -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7253] fast cataloging not always checking out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253 --- Comment #8 from Paul Poulain paul.poul...@biblibre.com --- Patch tested with a sandbox, by koha.aixmarseille koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9391] Issues on serial collection page no longer show status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9391 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9466] Use DataTables on saved reports page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi Owen, I found a bug in all the datatable patchs :-/ The iDisplayLength value equal 20 but this value is not in the aLengthMenu, so the selected value is 10. The default values of datatable is 10, 25, 50 and 100. We have 2 solutions: 1/ we defined the aLengthMenu with 10, 20, 50, 100, All 2/ the iDisplayLength has to be equal to 25 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9280] Bad price calculation when filling a basket with staged records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9280 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #16 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #14622|0 |1 is obsolete|| --- Comment #12 from Nicole C. Engard neng...@gmail.com --- Created attachment 14818 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14818action=edit [SIGNED-OFF] Bug 4354: Cannot edit existing issuing rules This patch adds javascript which pulls the values from the chosen row of data and populates the last row's form with that data. Some changes have been made to the markup to better accommodate this. Possibly missing is some kind of visual feedback to the user that the edit action is taking place in a different row from where they clicked. Comments are especially welcomed on this aspect of the interaction. The original author of this patch is Owen Leonard oleon...@myacpl.org Test Plan: * Edit an existing circulation rule * Delete a circulation rule * Create a new circulation rule * Create a new circulation rule that is a dup of an old one and make sure that it still overwrites the old rule like before Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests passed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9402] useless letter v between 2 option tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9402 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14818|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14819 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14819action=edit Bug 4354: Cannot edit existing issuing rules This patch adds javascript which pulls the values from the chosen row of data and populates the last row's form with that data. Some changes have been made to the markup to better accommodate this. Possibly missing is some kind of visual feedback to the user that the edit action is taking place in a different row from where they clicked. Comments are especially welcomed on this aspect of the interaction. The original author of this patch is Owen Leonard oleon...@myacpl.org Test Plan: * Edit an existing circulation rule * Delete a circulation rule * Create a new circulation rule * Create a new circulation rule that is a dup of an old one and make sure that it still overwrites the old rule like before Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests passed. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9380] branch not recording right on writeoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #14666|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard neng...@gmail.com --- Created attachment 14820 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14820action=edit [SIGNED-OFF] Bug 9380 - branch not recording right on writeoff Test Plan: 1) Write off fines as various branches 2) Observe the stats lines include the wrong branchcode 3) Apply patch 4) Repeate step 1 5) Observe the stats lines include the correct branchcode Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Also tested by changing branch and writing off again - all tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4266] encumbrance and expenditure not used in code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4266 --- Comment #6 from Nicole C. Engard neng...@gmail.com --- That's fine with me. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #34 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14821 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14821action=edit Bug 4354 - Followup - Add row highlighting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9482] New: set library redirects wrong on fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9482 Bug ID: 9482 Summary: set library redirects wrong on fines Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com I was on the Pay Fines page: cgi-bin/koha/members/pay.pl and went to change my library by clicking 'set library' in the top right. When I reset my library it redirected me back to cgi-bin/koha/members/pay.pl but it no longer had the patron's info on the screen. It should just redirect to circulation main or to the pay fines on the patron's record (where I was). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 --- Comment #15 from Nicole C. Engard neng...@gmail.com --- (In reply to comment #14) Created attachment 14821 [details] Bug 4354 - Followup - Add row highlighting Kyle, I don't see any different in FF on Mac. What am I looking for in the follow up? Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9211] days_between wrong behaviour
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 --- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com --- (In reply to comment #12) Could we get a test plan so I can test this in the interface and not just in the unit test? I haven't found through the code an usage example that leaded to having the dates swapped. I assume the days_between method is intended to work whether the dates are ordered or not just in case it is needed. In that case, this bug just makes the implementation match the documented API. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 --- Comment #6 from Vitor Fernandes vfernan...@keep.pt --- Created attachment 14822 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14822action=edit [SIGNED-OFF] Bug 9453: Update records acording to the new UNIMARCField100Language system preference Problems with perlcritic corrected. Script without parameters shows help. Signed-off-by: Vitor Fernandes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Attachment #14785|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9453] Update records acording to the new UNIMARCField100Language system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9211] days_between wrong behaviour
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9483] New: Use DataTables on batch patron modifications page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9483 Bug ID: 9483 Summary: Use DataTables on batch patron modifications page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/modborrowers.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org The batch patron modifications page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9210] Automatic carriage return are missing in print letters generated for holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #12 from Jared Camins-Esakov jcam...@cpbibliography.com --- Okay, the problem was that I was using sh when printoverdues.sh is actually a bash script. However, the patch results in a major regression. Instead of having a formatted hold notice with one line going off the edge of the paper, all the text is run together: http://kohadev.cpbibliography.com/holdnotices-2013-01-24.pdf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9208] overdue letters (pdf) are not correctly encoded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9208 --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- Could you please provide an example of when diacritics are not coded correctly? As far as I can tell, encoding is automatically correct before the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9483] Use DataTables on batch patron modifications page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9483 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9483] Use DataTables on batch patron modifications page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9483 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 14823 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14823action=edit Bug 9483 - Use DataTables on batch patron modifications page Replace the tablesorter plugin with the DataTables plugin on the batch patron modifications page. To test, submit multiple patron barcodes for batch modification (Tools - Batch patron modification). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14821|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14824 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14824action=edit Bug 4354 - Followup - Add row highlighting Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #15) (In reply to comment #14) Created attachment 14821 [details] Bug 4354 - Followup - Add row highlighting Kyle, I don't see any different in FF on Mac. What am I looking for in the follow up? Nicole Hi Nicole, It works here with FF, try to reload your page with ctrl-r, clean your cache, etc. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9483] Use DataTables on batch patron modifications page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9483 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9483] Use DataTables on batch patron modifications page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9483 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14823|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14825 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14825action=edit Bug 9483 - Use DataTables on batch patron modifications page Replace the tablesorter plugin with the DataTables plugin on the batch patron modifications page. To test, submit multiple patron barcodes for batch modification (Tools - Batch patron modification). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9484] New: userid not generated consistently (different editing pages)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9484 Bug ID: 9484 Summary: userid not generated consistently (different editing pages) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Patrons Assignee: adrien.sau...@biblibre.com Reporter: adrien.sau...@biblibre.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Different accesses to the memberentry.pl generate different behaviors when it comes to generate a new userid. When creating a new patron or modifying the full page of a patron, if the userid input zone is left empty, a userid like firstname.surname will be generated. But when accessing the editing page through the Details/Library Details tab, only a section of the editing page is displayed. The firstname and surname input boxes are not present, but the perl code assume that they are. In this case, if you empty the userid box, the perl script will try to generate a new id but firstname and surname will be empty. You end up with a simple dot as a login. When these input boxes are not present, the firstname and surname stored in the database should be used instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #36 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9484] userid not generated consistently (different editing pages)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9484 --- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 14826 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14826action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9484] userid not generated consistently (different editing pages)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9484 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Summary|Add ability to hide items |Add ability to hide |from purchase suggestions |itemtypes from purchase |forms |suggestions forms -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- I worded the title poorly. The idea is to limit the list of item types one can choose when making a purchase suggestion. Some libraries have some many item types that it would be overwhelming for a patron to choose the correct one from the list. The idea is to pare down the list to a more manageable size for the purpose of choosing an itemtype for a purchase suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4888] pre-set of field indicators value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #4270|0 |1 is obsolete|| --- Comment #21 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 14827 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14827action=edit Bug 4888 - pre-set of field indicators value Preload on database of the set of field indicators value as defined by http://www.loc.gov/marc/bibliographic/ecbdhome.html. New sql files in marc21/mandatory to create and populate the indicators tables with the sets of values for the Default framework/authtype. Each framework/authtype will be able to have its own copy to allow individual modification of indicators value. When editing the framework/authtype exists the possibility of cloning the indicators set from an existing framework/authtype populated with indicators. Modification of the intranet administration-Marc Frameworks/Authority MARC Framework to clone on creation from another framework and to delete set of indicators from a framework. Management (add/modify/delete) for indicators of the fields in the Framework Structure. Modification of the intranet cataloguing addbiblio / authorities authorities to enable a plugin to see the defined indicators value for a specific framework, and to check validity of indicators value. Two new system preferences: CheckValueIndicators for checking the value of the indicators when cataloguing a biblio record; DisplayPluginValueIndicators: to enable the plugin at addbiblio to see indicators value and to check too. Rebased to master 01/2013 Bug 4888 - rebase follow-up Fixing errors I made during rebase -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4888] pre-set of field indicators value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||mi...@abunchofthings.net --- Comment #22 from Mirko Tietgen mi...@abunchofthings.net --- I tried to resurrect this patch. I have not tested much yet, but I think there are some problems and it does not seem to give the option to add a default value for indicators automatically (or i have not found it yet). I don't think I will have time to work much on this, I wanted to put the rebased version up here anyway and invite you to test it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4888] pre-set of field indicators value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P5 - low -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4888] pre-set of field indicators value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #14827|0 |1 is obsolete|| --- Comment #23 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 14828 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14828action=edit Bug 4888 - pre-set of field indicators value Preload on database of the set of field indicators value as defined by http://www.loc.gov/marc/bibliographic/ecbdhome.html. New sql files in marc21/mandatory to create and populate the indicators tables with the sets of values for the Default framework/authtype. Each framework/authtype will be able to have its own copy to allow individual modification of indicators value. When editing the framework/authtype exists the possibility of cloning the indicators set from an existing framework/authtype populated with indicators. Modification of the intranet administration-Marc Frameworks/Authority MARC Framework to clone on creation from another framework and to delete set of indicators from a framework. Management (add/modify/delete) for indicators of the fields in the Framework Structure. Modification of the intranet cataloguing addbiblio / authorities authorities to enable a plugin to see the defined indicators value for a specific framework, and to check validity of indicators value. Two new system preferences: CheckValueIndicators for checking the value of the indicators when cataloguing a biblio record; DisplayPluginValueIndicators: to enable the plugin at addbiblio to see indicators value and to check too. Rebased to master 01/2013 Bug 4888 - rebase follow-up Fixing errors I made during rebase Bug 4888 follow-up: rebase errors 2 Another rebase error fixed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4354] Cannot edit existing issuing rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #14824|0 |1 is obsolete|| --- Comment #18 from Nicole C. Engard neng...@gmail.com --- Created attachment 14829 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14829action=edit Bug 4354 - Followup - Add row highlighting Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Test plan: * Click on a row to edit * Note that the row is highlighted in orange All tests pass -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4888] pre-set of field indicators value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 --- Comment #24 from Mirko Tietgen mi...@abunchofthings.net --- Looks like i b0rked the authorities part (authorities.tt) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4888] pre-set of field indicators value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #14828|0 |1 is obsolete|| --- Comment #25 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 14830 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14830action=edit Bug 4888 - pre-set of field indicators value Preload on database of the set of field indicators value as defined by http://www.loc.gov/marc/bibliographic/ecbdhome.html. New sql files in marc21/mandatory to create and populate the indicators tables with the sets of values for the Default framework/authtype. Each framework/authtype will be able to have its own copy to allow individual modification of indicators value. When editing the framework/authtype exists the possibility of cloning the indicators set from an existing framework/authtype populated with indicators. Modification of the intranet administration-Marc Frameworks/Authority MARC Framework to clone on creation from another framework and to delete set of indicators from a framework. Management (add/modify/delete) for indicators of the fields in the Framework Structure. Modification of the intranet cataloguing addbiblio / authorities authorities to enable a plugin to see the defined indicators value for a specific framework, and to check validity of indicators value. Two new system preferences: CheckValueIndicators for checking the value of the indicators when cataloguing a biblio record; DisplayPluginValueIndicators: to enable the plugin at addbiblio to see indicators value and to check too. Rebased to master 01/2013 Bug 4888 - rebase follow-up Fixing errors I made during rebase Bug 4888 follow-up: rebase errors 2 Another rebase error fixed Bug 4888 follow-up: fix authorities.tt Fixed an error in authorities.tt -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4888] pre-set of field indicators value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 --- Comment #26 from Mirko Tietgen mi...@abunchofthings.net --- Checking for the right values works in the pop-up window. Entering a wrong value directly into the Add MARC record view and pressinf 'Save' results not in a waring/message but the error Can't call method fields on an undefined value at /home/mirko/koha/C4/Biblio.pm line 2527. (checked in OPAC) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9485] New: Short cut to create new authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9485 Bug ID: 9485 Summary: Short cut to create new authorities Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: rafafer...@uol.com.br CC: m.de.r...@rijksmuseum.nl When we make a search for an authority to link it with a record and that authority is not found in authorities database, the system return Authority not found. I believe its useful to return this message, but also to show a pop up like Do you want to create a new authority? Y/N. Doing this will make cataloguing faster... Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] New: t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 Bug ID: 9486 Summary: t/Letters.t loads modules in wrong order Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Test Suite Assignee: jcam...@cpbibliography.com Reporter: jcam...@cpbibliography.com Because the unit test t/Letters.t loads C4::Letters before C4::Context, and C4::Letters is not even vaguely thread-safe, the test tends to fail. Usually. Moving the dbh mocking to before the use_ok('C4::Letters') test fixes the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14831 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14831action=edit Bug 9486: t/Letters.t loads modules in wrong order Because the unit test t/Letters.t loads C4::Letters before C4::Context, and C4::Letters is not even vaguely thread-safe, the test tends to fail. Usually. Moving the dbh mocking to before the use_ok('C4::Letters') test fixes the problem. To test: 1) Before applying patch, run `prove t/Letters.t` a few times. Note that it fails most of the time, if not all the time. 2) Apply patch. 3) Repeat step (1), noting that now it passes every time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12669|0 |1 is obsolete|| --- Comment #41 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14832 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14832action=edit [SIGNED-OFF] Bug 6413 Added ability to add a note when paying or writing off a fine Code will also respect notes when using the Writeoff All button but WILL NOT when using either the Pay Amount or Pay Selected buttons Fixed uri encoding of arguments Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #42 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14833 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14833action=edit Bug 6413 - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #43 from Kyle M Hall k...@bywatersolutions.com --- Is this what you were asking for? ^ (In reply to comment #40) (In reply to comment #39) Just a nudge - is anyone working on a new patch that addresses Paul's QA comments, by chance? seems no... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #9374|0 |1 is obsolete|| --- Comment #44 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14834 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14834action=edit Bug 6413 follow-up: fixing capital case tabs * switching from Payment Note to Payment note * replaced tabs by 4 spaces in lines just before and after this fix, for consistent indenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #45 from Kyle M Hall k...@bywatersolutions.com --- Followup is super trivial, switching to signed-off. QA can decide if another SO is necessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz --- Before 1..2 DBD::mysql::db do failed: Unknown or incorrect time zone: 'Pacific/Auckland' at C4/Context.pm line 825, DATA line 429. ok 1 - use C4::Letters; not ok 2 - HASH ref of ISBN is book # Failed test 'HASH ref of ISBN is book' # at t/Letters.t line 36. # got: undef # expected: 'book' # Looks like you failed 1 test of 2 After 1..2 Name DBI::errstr used only once: possible typo at t/Letters.t line 16. ok 1 - use C4::Letters; ok 2 - HASH ref of ISBN is boo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #14831|0 |1 is obsolete|| --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 14835 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14835action=edit Bug 9486: t/Letters.t loads modules in wrong order Because the unit test t/Letters.t loads C4::Letters before C4::Context, and C4::Letters is not even vaguely thread-safe, the test tends to fail. Usually. Moving the dbh mocking to before the use_ok('C4::Letters') test fixes the problem. To test: 1) Before applying patch, run `prove t/Letters.t` a few times. Note that it fails most of the time, if not all the time. 2) Apply patch. 3) Repeat step (1), noting that now it passes every time. Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9487] New: Allow items fields to be used in the HOLDPLACED notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9487 Bug ID: 9487 Summary: Allow items fields to be used in the HOLDPLACED notice Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com A number of libraries have asked why the HOLDPLACED notice allows you to choose item level fields but they are never filled in. There is no reason to disallow the use of items fields in the HOLDPLACED notice. For bib-level holds they will not be populated, but as long as the libraries know this, it does not seem like it would be an issue. It would probably be best to add a note about this in the manual. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9487] Allow items fields to be used in the HOLDPLACED notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9487 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14836 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14836action=edit Bug 9487 - Allow items fields to be used in the HOLDPLACED notice Test Plan: 1) Enable the syspref emailLibrarianWhenHoldIsPlaced 2) Modify the HOLDPLACED notice, add some item level fields 3) Place an item level hold 4) Check the email you recieve ( or just look at it from the db ) You should see the item level fields are new populated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4888] pre-set of field indicators value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #14830|0 |1 is obsolete|| --- Comment #27 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 14837 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14837action=edit Bug 4888 - pre-set of field indicators value Preload on database of the set of field indicators value as defined by http://www.loc.gov/marc/bibliographic/ecbdhome.html. New sql files in marc21/mandatory to create and populate the indicators tables with the sets of values for the Default framework/authtype. Each framework/authtype will be able to have its own copy to allow individual modification of indicators value. When editing the framework/authtype exists the possibility of cloning the indicators set from an existing framework/authtype populated with indicators. Modification of the intranet administration-Marc Frameworks/Authority MARC Framework to clone on creation from another framework and to delete set of indicators from a framework. Management (add/modify/delete) for indicators of the fields in the Framework Structure. Modification of the intranet cataloguing addbiblio / authorities authorities to enable a plugin to see the defined indicators value for a specific framework, and to check validity of indicators value. Two new system preferences: CheckValueIndicators for checking the value of the indicators when cataloguing a biblio record; DisplayPluginValueIndicators: to enable the plugin at addbiblio to see indicators value and to check too. Rebased to master 01/2013 Bug 4888 - rebase follow-up Fixing errors I made during rebase Bug 4888 follow-up: rebase errors 2 Another rebase error fixed Bug 4888 follow-up: fix authorities.tt Fixed an error in authorities.tt Bug 4888 follow-up fixed auth_tag_structure.tt -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9487] Allow items fields to be used in the HOLDPLACED notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9487 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14836|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14838 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14838action=edit Bug 9487 - Allow items fields to be used in the HOLDPLACED notice Test Plan: 1) Enable the syspref emailLibrarianWhenHoldIsPlaced 2) Modify the HOLDPLACED notice, add some item level fields 3) Place an item level hold 4) Check the email you recieve ( or just look at it from the db ) You should see the item level fields are new populated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9487] Allow items fields to be used in the HOLDPLACED notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9487 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #14835|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 14839 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14839action=edit [SIGNED-OFF] Bug 9486: t/Letters.t loads modules in wrong order Because the unit test t/Letters.t loads C4::Letters before C4::Context, and C4::Letters is not even vaguely thread-safe, the test tends to fail. Usually. Moving the dbh mocking to before the use_ok('C4::Letters') test fixes the problem. To test: 1) Before applying patch, run `prove t/Letters.t` a few times. Note that it fails most of the time, if not all the time. 2) Apply patch. 3) Repeat step (1), noting that now it passes every time. Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as advertised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9486] t/Letters.t loads modules in wrong order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9486 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #46 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14840 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14840action=edit Bug 6413 - QA Followup - Add notes for 'Pay selected' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #14474|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 14841 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14841action=edit [SIGNED-OFF] Bug 8292 - Clicking ignore on hold cancels transfer Clicking 'ignore' in the hold confirmation box does nothing but make the confirmation box disappear. No further actions are taken. The code to do the transfer is never executed, and the item sits at the holdingbranch library. If you're ignoring the hold, you want the checkin to proceed as if the hold had never popped up in the first place, and that means doing a return home if appropriate. To test, place a hold on an item for delivery to Library A. Check that item in at Library B. Click Ignore in the hold confirmation message. Before the patch, doing so would simply trigger JavaScript to hide the dialog. After the patch the form will be sumitted and the item will be transfered without fulfilling the hold. Signed-off-by: Owen Leonard oleon...@myacpl.org Added description and test plan to the best of my understanding of what this patch is trying to accomplish based on the bug report. The patch works if I'm correct in my test plan. Signed-off-by: Katrin Fischer katrin.fischer...@web.de All tests and QA script pass. Tests done: 1) Add an item hold on an item from library B for a patron from library A, pickup location is library A 2) Check in item at library A 3) Click 'ignore' a) AutomaticItemReturn is ON = Koha provides a link to print the transfer slip. b) AutomaticItemReturn is OFF = Koha provides 3 options: Confirm transfer and print slip, confirm transfer, don't confirm transfer. Without the patch the item was returned, but the transfer wasn't triggered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/