[Koha-bugs] [Bug 9466] Use DataTables on saved reports page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9466] Use DataTables on saved reports page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9466

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14856|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14878
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14878action=edit
Bug 9466 [Revised] Use DataTables on saved reports page

Replace the tablesorter plugin with the DataTables plugin on the
saved reports page.

To test, open the saved reports page (Reports  Use saved).
Confirm that table sorting works correctly.

Revision makes default result count (20) match options for number of
pagination entries (10,20,50,100,all).

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9437] Use DataTables on itemtypes administration page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9437

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14746|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14879
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14879action=edit
Bug 9437 - Use DataTables on itemtypes administration page

Replace the tablesorter plugin with the DataTables plugin on the
itemtypes administration page.

To test, open the itemtypes administration page (Administration
- Item types). Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Amended patch: Add the All entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9428] Use DataTables in Authority MARC frameworks page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14747|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14880
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14880action=edit
Bug 9428 - Use DataTables in Authority MARC frameworks page

Replace the tablesorter plugin with the DataTables plugin on the
Authority MARC frameworks page.

To test, open the Authority MARC frameworks page (Authority types -
MARC structure). Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Amended patch: Add the All entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9429] Use DataTables on Authorized Values page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9429

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14748|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14881
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14881action=edit
Bug 9429 - Use DataTables on Authorized Values page

Replace the tablesorter plugin with the DataTables plugin on the
Authorized Values page.

To test, open the Authorized Values page (Administration - Authorized
values). Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Amended patch: Add the All entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9430] Use DataTables on library transfer limits page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9430

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14749|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14882
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14882action=edit
Bug 9430 - Use DataTables on library transfer limits page

Replace the tablesorter plugin with the DataTables plugin on the
library transfer limits page.

Also made minor changes to check/uncheck all function to prevent page
from jumping on click, and removed unused function.

To test, open the library transfer limits page (Administration -
Library transfer limits). Confirm that table sorting works correctly for
all tables.

Test that the check all/uncheck all links still work correctly.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Amended patch: Add the All entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9435] Use DataTables on libraries and groups administration page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14750|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14883
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14883action=edit
Bug 9435 - Use DataTables on libraries and groups administration page

Replace the tablesorter plugin with the DataTables plugin on the
libraries and groups administration page.

To test, open the libraries and groups administration page (Administration
- Libraries and groups). Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Amended patch: Add the All entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9436] Use DataTables on cities administration page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9436

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14751|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14884
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14884action=edit
Bug 9436 - Use DataTables on cities administration page

Replace the tablesorter plugin with the DataTables plugin on the
cities administration page.

To test, open the cities administration page (Administration
- Cities and towns). Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Amended patch: Add the All entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9443] Use DataTables on MARC frameworks administration page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9443

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14769|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14885
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14885action=edit
Bug 9443 - Use DataTables on MARC frameworks administration page

Replace the tablesorter plugin with the DataTables plugin on the
MARC frameworks administration page.

To test, open the MARC frameworks dministration page (Administration -
MARC bibliographic framework - MARC structure). Confirm that table
sorting works correctly.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Amended patch: Add the All entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14810|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14886
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14886action=edit
Bug 9463 - Use DataTables on patron sent notices page

Replace the tablesorter plugin with the DataTables plugin on the
patron sent notices page.

This patch adds default sorting by time (descending).

To test, open the sent notices page for a patron who has multiple sent
notices. Confirm that table sorting works correctly.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

--- Comment #7 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Galen Charlton and Zeno Tajoli agreed with the patch.
So, Katrin, if it works, you can sign it off ;-)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Mathieu - I saw the mails on the mailing list, thank you for asking.
I will try to sign off, but maybe better if I do QA on it instead? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

--- Comment #9 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Ok, I will sign it off this afternoon, so you will be able to QA if you want.
M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #10 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
This patch will never show order notes.
I think that the change needs to be in
acqui/neworderempty.pl.

Something like
392:notes = $data-{'notes'} unless ( $ordernumber eq '' ),

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2972] Include patron ID in bounce email alerts

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2972

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |FIXED

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Patron search now allows to search by email address, also you can include the
needed information in the message body that shoull be attached to the bounce
email alert (I think). Tested on 3.10.1.

Please reopen or file a new bug if this is still a problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3150] Text of any email sent from Koha should be editable from web interface

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
The one nice thing about the emails being in the templates is, that they are
translatable. Maybe we could have an option to send cart/shelf list mails
depending on chosen templates?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3652] XSS vulnerabilities

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3652] XSS vulnerabilities

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|3.10|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3679] Specify from address when emailing a list or cart from opac

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think we could set the reply to address to the patron's email address.
Setting the 'from' to the patron's address is likely to cause problems with
some mail servers refusing the email (speaking out of experience).

I wonder if this has already been done on a separate bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3777] Field Sizes Inconsistent

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Not sure this is still something that is wanted - closing bug, please feel free
to reopen.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4990] reintegrate overdues email in overdue list

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4990

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|henridam...@koha-fr.org |koha-b...@lists.koha-commun
   ||ity.org
   Severity|normal  |enhancement

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Resetting assignee and setting bug to NEW. Feature didn't work since 3.0.x, so
probably can be considered an enhancement by now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9500] New: GetNormalizedISBN only ever checks the first populated ISBN field

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9500

Bug ID: 9500
   Summary: GetNormalizedISBN only ever checks the first populated
ISBN field
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com

If you take a look at C4::Koha::GetNormalizedISBN you will see code like this:

if ($marcflavour eq 'UNIMARC') {
@fields = $record-field('010');
foreach my $field (@fields) {
my $isbn = $field-subfield('a');
if ($isbn) {
return _isbn_cleanup($isbn);
} else {
return undef;
}
}
}

If I read this correctly, if we have say two ISBNs in a record, with the first
being invalid and the second being valid, GetNormalizedISBN will still return
undef because it never bothers to check the second isbn!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3777] Field Sizes Inconsistent

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

--- Comment #9 from Nicole C. Engard neng...@gmail.com ---
Yes, this is still wanted and needed - addresses can be more than 100
characters in length and we need to be consistent in this table about the size
of these fields regardless of it being the primary address or the alternate
address.

Nicole

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9264] Make getitems default sort to set by a preference instead of hard coded to homebranch.

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14006|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14887
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14887action=edit
Bug 9264 - Make getitems default sort to set by a preference instead of hard
coded to homebranch.

The sort order in GetItemsInfo has been switched from home branch to holding
branch and then back again at different points in time. Some libraries liked
it when it was by holding branch, rather than home branch.

This patch makes the choice of sorting by home or holding branch a system
preference.

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Test the sorting order for items with the preference set each way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9264] Make getitems default sort to set by a preference instead of hard coded to homebranch.

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9264

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5544] All Notices from Branch Email Address

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12164|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14888
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14888action=edit
Bug 5544 - All Notices from Branch Email Address

Right now overdues from from the branch, but the
others come from the admin email address - this
is a problem in multi-branch systems because they
have to come up with one email address that all
branches have access to.

C4::Letters::_send_message_by_email currently sets
the from address in the following order:
1) Address specified in message
2) Koha admin email address

The order will now be:
1) Address specified in message
2) Borrowers home library email address
3) Koha admin email address

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5544] All Notices from Branch Email Address

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9418] Some corrections and additions to about.tt

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14673|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9418] Some corrections and additions to about.tt

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14694|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9418] Some corrections and additions to about.tt

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9418] Some corrections and additions to about.tt

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9418

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14868|0   |1
is obsolete||

--- Comment #8 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14889
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14889action=edit
[SIGNED-OFF] Bug 9418: Some corrections and additions to about.tt

Test plan:

- Apply patch
- See if KEEP SOLUTIONS and C  P Bibliography Services
- Software Coop should be now software.coop

Bug 9418: Some corrections and additions to about.tt

Replaced  with amp; according codelines.

Sponsored-by: KEEP SOLUTIONS

Combined to patches into one.
Reorder C-entries as per sort order.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9493] confirmations for user holds in opac are not translatable

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9493

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9493] confirmations for user holds in opac are not translatable

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9493

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14862|0   |1
is obsolete||

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14890
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14890action=edit
[SIGNED-OFF] Bug 9493: confirmations for user holds in opac are not
translatable

In opac-user.tt, javascript for user holds confirmations (cancel, suspend,
resume) are not translatable.
This is because text is in onclick attribute, withtout javascript method for
translatable strings : _().

This patch moves those strings as variables into script tag and sets them
translatable.

Test plan :
- set a hold for a user
- Go to OPAC user page my summary
- click on Cancel
= you get a confirmation message
- click on Suspend all holds
= you get a confirmation message
- click on Resume all suspended holds
= you get a confirmation message
Test this is 'en' and another language.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

--- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14891
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14891action=edit
perl testing script

Back after some others tests.
I made a simulation with  simultaneous process.
This script gives an idea of the performance I got with 4 different
configurations.

The tests were executed on a Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz with 8g
of RAM.

4 cases:
1/ Branch master using CGI
2/ Branch master + Bug 8089 and Bug 9434 patches using CGI
3/ Branch master using Plack
4/ Branch master + Bug 8089 and Bug 9434 patches using Plack

For 10 simultaneous processes (admin/preferences.pl / catalogue/search.pl?q=d):
1/ 2.7s / 3.1s
2/ 3.0s / 3.4s
3/ 0.8s / 1.4s
4/ 1.1s / 1.7s

For 100 simultaneous processes (admin/preferences.pl /
catalogue/search.pl?q=d):
1/ 47.2s / 60.4s
2/ 30.0s / 58.2s
3/  8.0s / 13.2s
4/ 10.8s / 16.8s

These results are consistent with Jared's explanation.

Moreover, with the caching system and some simultaneous processes, this patch
could be useful.
But this script does not generate a real life test case...

I will sign off these patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13153|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14892
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14892action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl

Adds a column to indicate holds on recieved items, as well as adding
a new column for fund and showing the subtotals per fund above
the total subtotal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

--- Comment #48 from Owen Leonard oleon...@myacpl.org ---
Can someone provide a test plan for this? Can the last three patches be
squashed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14765|0   |1
is obsolete||

--- Comment #38 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14893
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14893action=edit
Bug 8089: Cache sysprefs with Koha::Cache::Object

This patch replaces the %sysprefs hash variable with a
Koha::Cache::Object-tied hash that allows the user to cache sysprefs
in memcached, fastmmap, or memory.

To test:
1) Enable the cache as described on bug 9434.
2) Try viewing some pages in the OPAC and staff client. If the syspref
   caching isn't working, you'll be redirected to the web installer
   (in the staff client) or be shown the maintenance page (in the OPAC).
3) Disable the cache by unsetting the CACHING_SYSTEM environment
   variable.
4) Try viewing some pages in the OPAC and staff client. If the syspref
   caching isn't working, you'll be redirected to the web installer
   (in the staff client) or be shown the maintenance page (in the OPAC).

Note that this will not improve performance. It does, however, eliminate
the problem of sysprefs not getting updated in all threads in
multi-threaded environments.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9434] Static variables used for caches are not Plack-friendly

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9434

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14786|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14894
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14894action=edit
Bug 9434: Introduce new tied cache system

At the moment we cache numerous pieces of information in module-level
variables which then do not get updated in other threads/processes when
they are changed by the user. This is a serious usability issue.

Examples of this include the way we treat sysprefs (there is now a
method to disable the syspref cache, but by default it is enabled),
notices, frameworks, field mappings, and koha-conf.xml, at least.

This patch sets the stage for eliminating this problem by making it
possible to convert module-level cache variables into variables that
are actually backed by whatever caching system may be configured. This
is done through a special Koha::Cache::Object class which can be tied
to the variables that are being used for caching and provided with a
constructor method/closure to allow the cache to be reloaded when it
expires. For example:

my $cache= Koha::Cache-new();
my $data = 'whatever';
my $variable = Koha::Cache-create_scalar(
{
'key' = 'whatever',
'timeout' = 2,
'constructor' = sub { return $data; },
}
);
print $$variable\n; # Prints whatever

The one change this necessitates for accessing the data is that the
variable must be dereferenced an additional time before use (i.e.
$$variable instead of $variable). There is no difference when the
variable tied is a hash (created with Koha::Cache-create_hash). This
is a small price to pay for Koha working in a multi-threaded, persistent
environment. This change will also make caching easier in general.

CHI was incompatible with the variable tying, so this patch also removes
the dependency on CHI, using instead Cache::Memcached::Fast,
Cache::FastMmap, and Cache::Memory, when they are available.

To test:
1) Apply patch.
2) Run unit test t/Cache.t (after setting the MEMCACHED_SERVERS and
   CACHING_SYSTEM environment variables). As no changes were made to
   the tests already in that file, this passing demonstrates there
   are no regressions.
3) With memcached caching enabled (you must set the MEMCACHED_SERVERS
   and CACHING_SYSTEM environment variables) and DEBUG turned on (i.e.
   the DEBUG environment variable set to 1), try running a report via
   the web service ([intranet]/cgi-bin/koha/svc/report?id=1 and check
   your web server logs to confirm that there are messages like
   get_from_cache for intranet:report:id:1 in them.
4) If the reports worked, sign off.

NOTE: Technically you could test this without needing memcached by
installing libcache-fastmmap-perl and setting CACHING_SYSTEM to
'fastmmap' instead of 'memcached'. You could also install libcache-perl
and set CACHING_SYSTEM to 'memory' but there would be little point as
the cached variables would go out of scope in between runs.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9434] Static variables used for caches are not Plack-friendly

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9434

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14891|perl testing script |[NOT APPLY] perl testing
description||script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

--- Comment #49 from Owen Leonard oleon...@myacpl.org ---
Also, is the title of this bug accurate with regard to what the patches are
for?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14834|0   |1
is obsolete||

--- Comment #50 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14895
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14895action=edit
[SIGNED-OFF] Bug 6413 follow-up: fixing capital case  tabs

* switching from Payment Note to Payment note
* replaced tabs by 4 spaces in lines just before and after this fix, for
consistent indenting

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14833|0   |1
is obsolete||
  Attachment #14846|0   |1
is obsolete||

--- Comment #51 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14896
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14896action=edit
Bug 6413 - QA Followup - Add notes for 'Pay selected'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3777] Field Sizes Inconsistent

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Maybe it would be easier to have separate bugs then for fields that need to be
increased in size?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3777] Field Sizes Inconsistent

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

--- Comment #11 from Nicole C. Engard neng...@gmail.com ---
Well originally I was just reporting the address fields.  


`address` mediumtext NOT NULL,
  `address2` text,
  `city` mediumtext NOT NULL,

`B_address` varchar(100) default NULL,
  `B_address2` text default NULL,
  `B_city` mediumtext,


`altcontactaddress1` varchar(255) default NULL,
  `altcontactaddress2` varchar(255) default NULL,
  `altcontactaddress3` varchar(255) default NULL,


So the others can be in a different bug report.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

--- Comment #52 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #49)
 Also, is the title of this bug accurate with regard to what the patches are
 for?

The middle one is from Paul, but I squashed my two together. Nicole mentioned
the lack of the note field in her initial comment, but it might be better to
change the title to something like Add note fields for fine payments.

Test plan:
1) Apply the patches
2) Create some test fees
3) Pick two or more to use for the 'Pay selected' option, add notes for each
4) Click 'pay selected'
5) The notes for each selected fee should be pulled into the new 'notes' text
field on paycollect.pl. Here you can modify the imported notes if you wish
before clicking Confirm
6) Confirm the note for the payment is now displayed on boraccount.pl for the
payment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

--- Comment #15 from Owen Leonard oleon...@myacpl.org ---
(In reply to comment #7)
 I wasn't clear - an item type makes sense to the user. And it should be
 there and it should work. The collections and shelving locations though make
 no sense to the OPAC user when making a suggestion. How does the patron know
 where you want to shelve the item?

Item type may or may not make sense to the user depending on how the library
uses it. In my library item type would make no sense, but collection code
would.

I think this latest version of the patch works well, but I agree that label
should change according to the selection. We shouldn't presume that the correct
term (item type, etc.) won't be understandable to the patron. Better to let
the library decide to customize it somehow.

I also like the idea of a don't show option.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9455] Embedded mysql quotes in sql string

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9455

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9496] rebuild_zebra.pl should handle invalid XML records better

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9496

Larry Baerveldt la...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14869|0   |1
is obsolete||

--- Comment #3 from Larry Baerveldt la...@bywatersolutions.com ---
Created attachment 14898
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14898action=edit
Signed off patch bug 9496

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Gaetan Boisson gaetan.bois...@biblibre.com changed:

   What|Removed |Added

 CC||gaetan.bois...@biblibre.com

--- Comment #15 from Gaetan Boisson gaetan.bois...@biblibre.com ---
Patch tested on an instance with a regular single branch LDAP : everything
working as expected, no regression!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7294] status in order

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

--- Comment #48 from Kyle M Hall k...@bywatersolutions.com ---
Ping! Matthias, are you going to write a followup for this? It looks like it
only failed QA due to new tab characters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9426] Add itemtype description template plugin

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9426

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
I get an error unless I change [% USE KohaAuthorisedValues %] (in the test
plan) to [% USE KohaItemType %]

Is that what it should be?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

--- Comment #53 from Owen Leonard oleon...@myacpl.org ---
I'm ready to sign off except for one small bug: The table columns are now out
of sync with the footer. Sub total and total due should be aligned with the
last column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14896|0   |1
is obsolete||

--- Comment #54 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14899
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14899action=edit
Bug 6413 - QA Followup - Add notes for 'Pay selected'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

--- Comment #55 from Kyle M Hall k...@bywatersolutions.com ---
Fixed!

(In reply to comment #53)
 I'm ready to sign off except for one small bug: The table columns are now
 out of sync with the footer. Sub total and total due should be aligned with
 the last column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7456] itypes with similar codes throw off search results

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7456

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com
   Severity|enhancement |normal

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---
I don't think this is an enhancement - seems more like a bug to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9075] Show material type and item type on staff detail (with xslt)

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075

--- Comment #9 from Owen Leonard oleon...@myacpl.org ---
If the goal is to show the item type on detail pages when item_level_itypes is
set to biblio, why not simply add that information to the part of the page
which displays biblio-level information? I don't like that this patch puts
itemtype information into the display of holdings. If item_level_itypes is set
to biblio then itemtype should not be displayed with item-specific data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9501] New: renew patron link next to expiration date

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9501

Bug ID: 9501
   Summary: renew patron link next to expiration date
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It would be nice if there were a little 'renew' link to the right of the
patron's expiration date on their details.  It's just one less click to renew
this way then having to click 'More' and then 'Renew'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14899|0   |1
is obsolete||

--- Comment #56 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14900
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14900action=edit
[SIGNED-OFF] Bug 6413 - QA Followup - Add notes for 'Pay selected'

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9380] branch not recording right on writeoff

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9380] branch not recording right on writeoff

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14820|0   |1
is obsolete||

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14901
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14901action=edit
[SIGNED-OFF] Bug 9380 - branch not recording right on writeoff

Test Plan:
1) Write off fines as various branches
2) Observe the stats lines include the wrong branchcode
3) Apply patch
4) Repeate step 1
5) Observe the stats lines include the correct branchcode

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

Also tested by changing branch and writing off again - all
tests pass.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9380] branch not recording right on writeoff

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Version|3.8 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14762|0   |1
is obsolete||

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14902
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14902action=edit
[SIGNED-OFF] Bug 9382 - updating permission labels

first, replicate:
go to More - permissions on any user. Notice that it says various things
privileges, flags, permissions they are interchangeable and inconsistent.
also note that some of the permissions are nonsensical and/or not descriptive
enough, or not using canonical terminology (borrowers instead of patrons, for
example)

To test:
interface consistency changes

- means turns into

- page title - privileges - permissions
- breadcrumbs - privileges - permissions
- headings - privileges - permissions
- set flags button - save

Permissions that have changed description:

- Catalogue changes to Required for staff login in bold (this was the
original impetus for this boatload of changes)
- reports
- editauthorities
- management
- serials
- updatecharges
- circulate
- parameters
- borrowers
- tools
- staffaccess
- edit_patrons (only on updatedb, not on new db)

- Read through and make sure there are no typos, and that the descriptions seem
to jive with what privileges the permission gives the user. Suggestions are, in
fact, welcome.

- If you are feeling ambitious, go ahead and create a new, clean database and
check the wording there as well - it should match what has been done in the db
update.

Signed-off-by: Owen Leonard oleon...@myacpl.org

Tested both with existing database and new database

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9456] Add callnumber column to the cart

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14780|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14903
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14903action=edit
Bug 9456 [Alternate] Add callnumber column to the cart - Followup - Sort by
callnumbers

This patch removes the sub-tables for callnumber/location, and simple
surrounds them with a span tag. Sorting is enabled on the 'Items' column
which uses a custom sorting routine to sort the callnumbers. If the sort
is ascending, each column will be sorted by the highest ordered callnumber
for that row. Likewise, if the sort is descending the table will be sorted
by the lowest valued callnumber for that row.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9456] Add callnumber column to the cart

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14903|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14904
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14904action=edit
Bug 9456 [Alternate] Add callnumber column to the cart - Followup - Sort by
callnumbers

This patch removes the sub-tables for callnumber/location, and simply
surrounds them with a span tag. Sorting is enabled on the 'Items' column
which uses a custom sorting routine to sort the callnumbers. If the sort
is ascending, each column will be sorted by the highest ordered callnumber
for that row. Likewise, if the sort is descending the table will be sorted
by the lowest valued callnumber for that row.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14691|0   |1
is obsolete||

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14905
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14905action=edit
Bug 9420 - Work on Bootstrap for Koha

YUI JS is deprecated as far as Koha is concerned, and jQueryUI menus
don't seem to be as robust as they should be. This makes Twitter
Bootstrap very attrative for its menus features as well as other
aspects.

This patch revises the staff client header menu to include features from
Bootstrap, including replacement of the YUI-driven More... menu with a
Bootstrap version, and a new user menu taken from Corey Fuimaono's
similar patch.

To test, be sure to clear your cache after applying the patch. Load any
page in the staff client and confirm that the menu at the top of the
screen looks correct and works as normal, including functionality of the
more menu. Confirm that the username/logged-in branch triggers a menu
with set library and log out options. Confirm that Cart operations
trigger the correct confirmation popup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9456] Add callnumber column to the cart

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Owen, I think you may find this followup to your patch more acceptable than my
original patch. This one looks more like my original patch, but the sorting is
actually done using the best suited callnumber for each given row ( by using
custom sorting filters for that table column ).

When sorting by Items in ascending fashion, the filter uses the highest valued
callnumber from each row for sorting. When sorting by Items descending, it uses
the lowest valued callnumber from each row.

Test plan:
1) Apply all the patches.
2) Create a record with two items, make one a very high callnumber ( e.g.
'0' ) and one a very low callnumber ( e.g. 'Z' ).
3) Add this record and a number of other records to the cart.
4) View the cart and sort the Items in both ascending and descending fashion.
5) You should see that the item you created always stays on top because it
contains both the highest valued and the lowest valued callnumbers in the list!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

--- Comment #3 from Liz Rea (CatalystIT) l...@catalyst.net.nz ---
Created attachment 14906
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14906action=edit
Bug 9420 - Work on Bootstrap for Koha

YUI JS is deprecated as far as Koha is concerned, and jQueryUI menus
don't seem to be as robust as they should be. This makes Twitter
Bootstrap very attrative for its menus features as well as other
aspects.

This patch revises the staff client header menu to include features from
Bootstrap, including replacement of the YUI-driven More... menu with a
Bootstrap version, and a new user menu taken from Corey Fuimaono's
similar patch.

To test, be sure to clear your cache after applying the patch. Load any
page in the staff client and confirm that the menu at the top of the
screen looks correct and works as normal, including functionality of the
more menu. Confirm that the username/logged-in branch triggers a menu
with set library and log out options. Confirm that Cart operations
trigger the correct confirmation popup.

Signed-off-by: Liz Rea l...@catalyst.net.nz

I am not sure I like the vertical bar between the username and the branch (it's
weird to a screen reader), but I do definitely like a lot about this, and it
can be refined.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Liz Rea (CatalystIT) l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Liz Rea (CatalystIT) l...@catalyst.net.nz changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #4 from Liz Rea (CatalystIT) l...@catalyst.net.nz ---
Corey -

Get in touch with me for how to get this patch and apply it to your development
environment, once you get that set up.

- Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7507] Audience Subtype limit on Advanced Search does not have all Audiences

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |dc...@prosentient.com.au

--- Comment #5 from David Cook dc...@prosentient.com.au ---
Created attachment 14907
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14907action=edit
Bug 7507 - Audience Subtype limit on OPAC Advanced Search does not have all
Audiences

Very simple template change. Just copied the code from the staff client so that
the OPAC advanced search drop-down menu shows the correct options for the
audience subtype limit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14202|0   |1
is obsolete||

--- Comment #13 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14908
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14908action=edit
Bug 7882 [fixed]

Rebased on latest master and fixed whitespace issues.  Also changed language
from Move Up to Move

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7883] save and continue editing

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED
 CC||elli...@bywatersolutions.co
   ||m
   Assignee|savitra.sir...@osslabs.biz  |elli...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7883] save and continue editing

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883

--- Comment #3 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14909
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14909action=edit
Added the ability to save and continue editing in cataloging.

This patch adds the ability for catalogers to save and continue editing when
adding new biblios.
This is helpful in the event of a power failure or perhaps in the event you
step away for a sandwich and your co-worker closes your tab to look at cats.

To Test:

Select an existing item or create a new item in cataloging using your favorite
framework.
Edit the item
From the save menu in the dropdown, select the new option of Save and continue
editing
If you are missing requited fields you should still be prompted to fill them in
before saving
Once all required fields are in place you should be allowed to save and should
be on the same page
(You're fresh bib record should also be saved)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7883] save and continue editing

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7883] save and continue editing

2013-01-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/