[Koha-bugs] [Bug 9338] 'Empty' patron search no longer returns all patrons

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9338

Gaetan Boisson gaetan.bois...@biblibre.com changed:

   What|Removed |Added

 CC||gaetan.bois...@biblibre.com

--- Comment #1 from Gaetan Boisson gaetan.bois...@biblibre.com ---
Problem confirmed in 3.10. Not critical but clearly a regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||elli...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14905|0   |1
is obsolete||
  Attachment #14906|0   |1
is obsolete||

--- Comment #5 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14910
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14910action=edit
[Passed QA] Bug 9420 - Work on Bootstrap for Koha

YUI JS is deprecated as far as Koha is concerned, and jQueryUI menus
don't seem to be as robust as they should be. This makes Twitter
Bootstrap very attrative for its menus features as well as other
aspects.

This patch revises the staff client header menu to include features from
Bootstrap, including replacement of the YUI-driven More... menu with a
Bootstrap version, and a new user menu taken from Corey Fuimaono's
similar patch.

To test, be sure to clear your cache after applying the patch. Load any
page in the staff client and confirm that the menu at the top of the
screen looks correct and works as normal, including functionality of the
more menu. Confirm that the username/logged-in branch triggers a menu
with set library and log out options. Confirm that Cart operations
trigger the correct confirmation popup.

Signed-off-by: Liz Rea l...@catalyst.net.nz

I am not sure I like the vertical bar between the username and the branch (it's
weird to a screen reader), but I do definitely like a lot about this, and it
can be refined.

Signed-off-by: Elliott Davis elli...@bywatersolions.com
Looks good to me.  Seems to introduce no new bugs.  Maintains styling
consistency for the most part.
Removes Crusty YUI code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14902|0   |1
is obsolete||

--- Comment #6 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14911
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14911action=edit
Bug 9382 - updating permission labels

first, replicate:
go to More - permissions on any user. Notice that it says various things
privileges, flags, permissions they are interchangeable and inconsistent.
also note that some of the permissions are nonsensical and/or not descriptive
enough, or not using canonical terminology (borrowers instead of patrons, for
example)

To test:
interface consistency changes

- means turns into

- page title - privileges - permissions
- breadcrumbs - privileges - permissions
- headings - privileges - permissions
- set flags button - save

Permissions that have changed description:

- Catalogue changes to Required for staff login in bold (this was the
original impetus for this boatload of changes)
- reports
- editauthorities
- management
- serials
- updatecharges
- circulate
- parameters
- borrowers
- tools
- staffaccess
- edit_patrons (only on updatedb, not on new db)

- Read through and make sure there are no typos, and that the descriptions seem
to jive with what privileges the permission gives the user. Suggestions are, in
fact, welcome.

- If you are feeling ambitious, go ahead and create a new, clean database and
check the wording there as well - it should match what has been done in the db
update.

Signed-off-by: Owen Leonard oleon...@myacpl.org

Tested both with existing database and new database

Signed-off-by: Elliott Davis elli...@bywatersolions.com
Tested with existing database.  Introduces no new mysql-isms.
Kudos for adding that syspref in bold, that got me when I first started with
Koha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||elli...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9494] Library of Congress Z39.50 target seed data outdated

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9494

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14866|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9494] Library of Congress Z39.50 target seed data outdated

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9494

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14867|0   |1
is obsolete||

--- Comment #6 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14912
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14912action=edit
[Passed QA] bug 9494: update default LOC z39.50 target settings

This patch updates the seed data from the target list at
http://www.loc.gov/z3950/lcserver.html#addr.

Comment: new target works. updated deleting and reloading
sample targets.

Signed-off-by: Galen Charlton g...@esilibrary.com
Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Signed-off-by: Elliott Davis elli...@bywatersolions.com
I agree with Galen that this may need to be incorproated as a follow-up for
current installations
Works fine for new installs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9494] Library of Congress Z39.50 target seed data outdated

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9494

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||elli...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9502] New: famfamfam: wrongly placed in package 3.8.8/9

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9502

Bug ID: 9502
   Summary: famfamfam: wrongly placed in package 3.8.8/9
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.8
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: vinod_librar...@rediffmail.com

Dear All,

The famfamfam directly is wrongly placed in ubuntu package installation as i
have installed version 3.8.8/9. Because of which the icon for item types does
not shows in search results when using show item image via system preference
and xslt style sheet. It should be inside the
/usr/share/koha/opac/htdocs/opac-tmpl/prog folder at present it is in
/usr/share/koha/opac/htdocs/opac-tmpl/lib/famfamfam

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684

Sunita sunitaba...@gmail.com changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
 CC||sunitaba...@gmail.com
Version|master  |3.8

--- Comment #1 from Sunita sunitaba...@gmail.com ---
I tried adding barcode in Global System Preferences - Acquisitions -
UniqueItemFields as barcode but this feature does not seem to work. Even same
accession number is provided to new book it does not give any error message and
it does not add that same number again but keeps that item as blank.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9503] New: Link from histsearch via invoicenumber results in error

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503

Bug ID: 9503
   Summary: Link from histsearch via invoicenumber results in
error
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com

The acq histsearch page displays invoice numbers and allows their selection to
retrieve shipments recorded against that invoice. Selection results in an
error:

Can't use an undefined value as an ARRAY reference at
/home/koha/kohaclone/acqui/parcel.pl line 160.


Cause of the error is that the the invoice id is passed as invoice whereas
parcel.pl expects invoiceid so that GetInvoiceDetails is incorrectly called and
returns undef rather than an invoice structure

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9503] Link from histsearch via invoicenumber results in error

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe.
   |ity.org |com

--- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 14913
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14913action=edit
Proposed patch

Testing: Without this patch applied selecting an invoicenumber from the
acqui/histsearch screen results in a system error. With it applied a listing of
related orders should be displayed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9161] Translate only specific files

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14914
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14914action=edit
Bug 9161: Followup: the -f param does not work correctly

Without this patch, the -f param (for the translate script) add the
modified line in the po file BUT comment all lines from others files.

This patch concat the generated file with the previous one and merge
them. This way produce a pretty po file with all our strings :)

+ Modification in LangInstaller.pm to fix a bug when the -f param was not
given.

Test plan:
1/ Update your po file :
cd misc/translator
perl translate update fr-FR
git commit -a -mTMP PO
2/ Modification on 2 files:
ie.
catalogue/advsearch.tt:32 h1Advanced search Foo/h1
catalogue/issuehistory.tt:38 thPatron Bar/th

3/ Update your po file with only the first file:
perl translate update fr-FR -f advsearch.tt

4/ Edit your po file and check that only the foo string is present (or
git diff).

5/ Update your po file with only the second file:
perl translate update fr-FR -f issuehistory

6/ Edit your po file and check that 2 strings are present (or git diff).

7/ Change the translation for these 2 strings and delete the fuzzy
lines.

8/ Install the first file for your language:
perl translate install fr-FR -f advsearch.tt

9/ Edit your translated file and verify the string is translated. Check
that the issuehistory.tt file is not changed.

10/ Same for issuehistory:
perl translate install fr-FR -f issuehistory

11/ stash your modification in your tt files (or reset --hard):
git stash

12/ Check in your po file that the 2 strings are commented (git diff).

13/ To finish, install all template files and check that they are
replaced correctly:
perl translate install fr-FR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9161] Translate only specific files

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

Stefano Bargioni bargi...@pusc.it changed:

   What|Removed |Added

 CC||bargi...@pusc.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

--- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Bootstrap is so cool that I am taking a break from my vacation to look at it!

I have only one objection: Bootstrap is under the themelanguage directory. I
think we are trying to move this sort of library outside of theme and language
directories. (unfortunately this will require a revised patch instead of a
follow-up)

Otherwise, looks great! (there is space missing between the menu bar and the
breadcrumbs on the advanced search page, but that could be dealt with later)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9431] Use DataTables on Patron Category Administration page

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9431] Use DataTables on Patron Category Administration page

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14721|0   |1
is obsolete||

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14915
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14915action=edit
Bug 9431 [Revised] Use DataTables on Patron Category Administration page

Replace the tablesorter plugin with the DataTables plugin on the
patron category administration page. Structural changes were made to the
table markup for validity and to deal with a DataTables bug which
prevents it from properly parsing a th with a colspan.

To test, open the Patron Category Administration page (Administration -
Patron types and categories). Confirm that table sorting works
correctly.

Revision adds a natural sort plugin to the main datatables
configuration JavaScript file to enable sorting of columns like those in
this table which include mixed numeric and text data. Allows correct
numeric sorting of data like 0 years, 1 years, 2 years, 18 years, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14910|0   |1
is obsolete||

--- Comment #7 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14916
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14916action=edit
Bug 9420 [Revised] Work on Bootstrap for Koha

YUI JS is deprecated as far as Koha is concerned, and jQueryUI menus
don't seem to be as robust as they should be. This makes Twitter
Bootstrap very attrative for its menus features as well as other
aspects.

This patch revises the staff client header menu to include features from
Bootstrap, including replacement of the YUI-driven More... menu with a
Bootstrap version, and a new user menu taken from Corey Fuimaono's
similar patch.

To test, be sure to clear your cache after applying the patch. Load any
page in the staff client and confirm that the menu at the top of the
screen looks correct and works as normal, including functionality of the
more menu. Confirm that the username/logged-in branch triggers a menu
with set library and log out options. Confirm that Cart operations
trigger the correct confirmation popup.

Revision moves the Bootstrap assets out of the prog template into
koha-tmpl/intranet-tmpl/lib.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9462] Use DataTables on patron detail page

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9462

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #14795|0   |1
is obsolete||

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14917
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14917action=edit
Bug 9462 [Revised] Use DataTables on patron detail page

Replace the tablesorter plugin with the DataTables plugin on the
patron detail page.

To test, open a patron detail page for a patron who has checkouts,
holds, and relatives' checkouts. Confirm that table sorting works
correctly for each of those three tables.

Revision adds some JavaScript designed to handle table-sizing for tables
which are hidden initally in tabs. DataTables has an approved method for
handling these cases:
http://www.datatables.net/examples/api/tabs_and_scrolling.html

This should prevent the table of existing holds from looking squeezed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7294] status in order

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #14076|0   |1
is obsolete||

--- Comment #49 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 14918
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14918action=edit
Bug 7294: Adds acquisition informations in marc record

View status 'in order' to the OPAC and staff interface. Specific
fields from aqorders can be mapped to marc fields (using ACQ bibliographic
framework):
aqorders.branchcode
aqorders.quantity
aqorders.listprice
aqorders.uncertainprice
aqorders.rrp
aqorders.ecost
aqorders.notes
aqorders.supplierreference
aqorders.ordernumber

This way, you can keep track on what is currently on order
at biblio level until you receive everything. Once all items have been
received, the marc field is deleted.

Please note that mapping the ordernumber is mandatory for this feature to work

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087

--- Comment #54 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #53)
 (In reply to comment #48)
  (In reply to comment #47)
   I am in favour of reverting this until it is fixed, if it is not fixed by
   3.10.3 I will revert it out of 3.10.x
  
  I think Jared thought it was too late to revert it, because it would break
  things for people who already upgraded to 3.10.x. But I'll let him speak for
  himself, of course.
 
 Yeah, reverting it would break existing standard installs.

From BibLibre POV (that is managing 70+ french libraries in UNIMARC), we don't
use the packages, so we didn't saw this problem  don't face it.
Reverting the patch will cause trouble to us though.

Once i've said that, I can't help with a patch to fix the problem, because I
know nothing about packaging. I fear it will be tricky, because it requires the
sysop to know which MARC flavour must be choosen, and that's not something well
known by common sysop, so we must carefully explain the possible choices...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7294] status in order

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #50 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Tabs and pods are now fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9450] Use DataTables in cataloging Z39.50 search results

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
(In reply to comment #2)
 I don't know why this table is not sort correctly.

I can't reproduce this problem. Is the problem only with that search, or with
any? Is the problem only with title sort?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9503] Link from histsearch via invoicenumber results in error

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9503] Link from histsearch via invoicenumber results in error

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #14913|0   |1
is obsolete||
  Attachment #14919|0   |1
is obsolete||

--- Comment #3 from Galen Charlton gmcha...@gmail.com ---
Created attachment 14920
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14920action=edit
Bug 9503 Correct name of parameter passed to parcel.pl

invoiceid was being passed as invoice causing GetInvoiceDetails
to silently fail and a system error downstream when
accessing the 'orders' element of the undefined invoice

Added an error message if GetInvoiceDetails called on undef

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9503] Link from histsearch via invoicenumber results in error

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 14919
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14919action=edit
Bug 9503 Correct name of parameter passed to parcel.pl

invoiceid was being passed as invoice causing GetInvoiceDetails
to silently fail and a system error downstream when
accessing the 'orders' element of the undefined invoice

Added an error message if GetInvoiceDetails called on undef

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3060] item number not on holds to pull report

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3060

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Hardware|PC  |All

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
This bug is still valid. I would say that the display of item-level information
in this report is problematic all around (library, call number, barcode, etc).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3548] Incorrect directory/file ownership on /var/run/lock/koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3548

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
I assume because of the age of this report that the issue is no longer valid.
Please re-open with new details if this is not so.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9504] New: URL escape in OPAC more searches

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9504

Bug ID: 9504
   Summary: URL escape in OPAC more searches
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: fridolyn.som...@biblibre.com

OPACSearchForTitleIn is a syspref used to add links as more searches in OPAC
record detail page.
The links can contain vars depending on record values like title, ISBN, ...
Thoses values must be URL-escaped because they can contain special characters
that will brake URL and/or HTML.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9426] Add itemtype description template plugin

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9426

--- Comment #5 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #4)
 I get an error unless I change [% USE KohaAuthorisedValues %] (in the test
 plan) to [% USE KohaItemType %]
 
 Is that what it should be?

Sorry, error in my test plan : 
- Add as first line : [% USE KohaAuthorisedValues %]
It is : 
- Add as first line : [% USE KohaItemType %]

Thanks for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9426] Add itemtype description template plugin

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9426

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #14702|0   |1
is obsolete||

--- Comment #6 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 14922
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14922action=edit
Proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5282] Guided reports itemtype limit not applying

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5282

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
This seems to be working in current master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8854] invoice filters don't all work

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8854] invoice filters don't all work

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

--- Comment #3 from Galen Charlton gmcha...@gmail.com ---
Created attachment 14923
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14923action=edit
bug 8854: fix some invoice search filters

Fix the supplier, shipment date, and library filters
on the invoice search.  An invoice's library is
(in parallel with order search) defined as the library
of the staff member that approved the basket.  Before this
patch, the code was referring to an aqorders.branchcode
column that doesn't exist.

This patch also fixes the current test cases for invoices
so that they pass.

Test plan:

[1] Create two invoices for different vendors.
[2] Do an invoice search and filter on shipment
date.  Verify that the expected invoice(s)
are returned.
[3] Do an invoice search and filter on branch
(of the staff member that approved the basket).
Verify that the expected invoice(s) are returned.
[4] Do an invoice search and filter on supplier.
Verify that the expected invoice(s) are returned.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8854] invoice filters don't all work

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #4 from Galen Charlton gmcha...@gmail.com ---
Note that the publication year search filter will work in UNIMARC but not
MARC21.  This is because the default UNIMARC frameworks map a tag to the
biblioitems.publicationyear column (which the date filter uses) but the default
MARC21 frameworks do not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9454] NewBasket does not use placeholders in sql

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9454] NewBasket does not use placeholders in sql

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #14776|0   |1
is obsolete||

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 14924
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14924action=edit
Bug 9454: Use placeholders when adding basket

Should always use placeholders when passing variables
to DBI; avoids unforeseen bugs and security issues.

Also:

- reformated the long lists of parameters to add CR
- moved the setting of defaults out of the call to ModBasket to
  clarify code
- Setting parameters to undef if they were not defined
  was unnecessary bloat and obscuration

Testing:
Patch should not change functional behaviour. To test check that
order baskets can still be correctly created.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9265] Switch to HTML5 doctype in OPAC and staff client

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9265] Switch to HTML5 doctype in OPAC and staff client

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14925|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9265] Switch to HTML5 doctype in OPAC and staff client

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #6 from Mason James m...@kohaaloha.com ---
(In reply to comment #5)
 Created attachment 14926 [details]
 Bug 9265 - Switch to HTML5 doctype in OPAC and staff client
 
 Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
 test on some intranet pages and I found no regression. (chromium and
 firefox).
 The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype
 
 Signed-off-by: Mason James m...@kohaaloha.com


passing QA on this patch

tested on firefox, chrome, opera, and safari browers - with no regressions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

--- Comment #8 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 14927
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14927action=edit
[SIGNED-OFF] Bug 9420 [Revised] Work on Bootstrap for Koha

YUI JS is deprecated as far as Koha is concerned, and jQueryUI menus
don't seem to be as robust as they should be. This makes Twitter
Bootstrap very attrative for its menus features as well as other
aspects.

This patch revises the staff client header menu to include features from
Bootstrap, including replacement of the YUI-driven More... menu with a
Bootstrap version, and a new user menu taken from Corey Fuimaono's
similar patch.

To test, be sure to clear your cache after applying the patch. Load any
page in the staff client and confirm that the menu at the top of the
screen looks correct and works as normal, including functionality of the
more menu. Confirm that the username/logged-in branch triggers a menu
with set library and log out options. Confirm that Cart operations
trigger the correct confirmation popup.

Revision moves the Bootstrap assets out of the prog template into
koha-tmpl/intranet-tmpl/lib.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Works great. No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #14916|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9257] Add groups to normal search pulldown

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Owen Leonard oleon...@myacpl.org ---
This seems to be working, but I noticed the update message in updatedatabase.pl
seems to be copy-paste from another patch.

I also still see JavaScript in the template. Is that still doing something? Can
it be removed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #14 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Work as described. Tags and subtags could be reordered.
But the result is a bit ugly, and there is too much indentation on subtags.
That's cosmetic.

The trouble I found is that can't collapse or expand tags.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

--- Comment #9 from Owen Leonard oleon...@myacpl.org ---
Created attachment 14928
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14928action=edit
Bug 9420 - Work on Bootstrap for Koha: Circ toolbar

This patch converts the toolbar include file used by Circ and
Patron pages to Bootstrap, replacing YUI button and menu code
with Bootstrap markup.

To test, view any page in circ/ or members/ which uses
members-toolbar.inc (circulation.pl, moremember.pl, etc).
Buttons and menus should look correct and work correctly.

This patch is preliminary. This patch does not include final
styling of the buttons, which lack icons to match the YUI
version. Some icons have been chosen from the default Bootstrap
set to demonstrate the functionality.

Comments welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9490] Show responsibility statement (245c) under title and move authors down in OPAC XSLT

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9490

Ann Murphy libr...@katikaticollege.school.nz changed:

   What|Removed |Added

 CC||libr...@katikaticollege.sch
   ||ool.nz

--- Comment #6 from Ann Murphy libr...@katikaticollege.school.nz ---
I should like the ability to chose between the Author field and the the 245c
field as it makes the record read better for students, so it will be Harry
Potter and the Deathly Hallows by J. K. Rowling rather than Harry Potter and
the Deathly Hallows by Rowling, J. K. — so much nicer to look at. To me the
100a field is just to search on.

 Before rebasing this to master, I hope to get some feedback from you. What
 do you think? Would such a change benefit a general library too? Would it
 need yet another syspref :) ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9420] Work on Bootstrap for Koha

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9420

--- Comment #10 from Liz Rea (CatalystIT) l...@catalyst.net.nz ---
I prefer the bootstrap icons. I would sign off on that - I think the styling is
fine.

:LR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2960] Cyrillic Z39-50 servers (bad encoding results)

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2960

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|NEW |In Discussion
 CC||m...@kohaaloha.com

--- Comment #1 from Mason James m...@kohaaloha.com ---
(In reply to comment #0)
  
  Reported by du...@library.lviv.ua 2009-02-13 08:08:14 
 
 Try to work with next servers:
 
 Also I see that encoding for second server = WINDOWS-1251
 
 
 Next I edit in Koha table 'z3950servers' (via phpmyadmin)
 field encoding 
 to
 WINDOWS-1251
 or
 KOI8-R
 
 On next try to serach in Koha via
 /cgi-bin/koha/cataloguing/z3950_search.pl
  - found this records (search for 'perl')
 
 but result in bad encoding (something like ISO-8859-1)
 


hmm, the example urls are now invalid, which makes troubleshooting this
difficult

perhaps attach a problem MARC record to this ticket...?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #13929|0   |1
is obsolete||

--- Comment #14 from Mason James m...@kohaaloha.com ---
Created attachment 14929
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14929action=edit
Bug 9116: Remove some useless tmp variables

Some variables are useless in C4::Items::PrepareItemrecordDisplay.

This patch removes its.

Test plan:
Syspref AcqCreateItem = receive an order and try to receive an order.
Check there is no regression.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14929|0   |1
is obsolete||

--- Comment #15 from Mason James m...@kohaaloha.com ---
Created attachment 14930
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14930action=edit
Bug 8369: Merge tables for circulation rules.

This patch adds 3 new tables:
 - circ_rules
 - borrower_circ_rules
 - item_circ_rules
It removes 6 tables:
 - default_borrower_circ_rules
 - default_branch_circ_rules
 - default_branch_item_rules
 - default_circ_rules
 - branch_borrower_circ_rules
 - branch_item_rules

The goal is to merge circulations rules into 3 tables instead of 6 without
add or remove features. Previous behaviours do not change.
The wildcard '*' character is a rule for the default values. Then it is
possible to merge 2 tables into one if we consider that the default value is
the value with a branchcode eq '*'.
I removed the foreign key constraint with branchcode and added 3 queries
in the C4::Branch::DelBranch routine in order to remove records about a
deleted branch.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #13930|0   |1
is obsolete||

--- Comment #16 from Mason James m...@kohaaloha.com ---
Created attachment 14931
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14931action=edit
Bug 8369: Followup: indent sql queries in admin/smart-rules.pl

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369

--- Comment #17 from Mason James m...@kohaaloha.com ---
(In reply to comment #16)
 Created attachment 14931 [details]
 Bug 8369: Followup: indent sql queries in admin/smart-rules.pl
 
 Signed-off-by: Kyle M Hall k...@bywatersolutions.com
 Signed-off-by: Mason James m...@kohaaloha.com

passing QA...

i've had a look at this, and had a bit of a circ test
it looks good to me

(applied to f8686e9 'Bug 9116: Remove some useless tmp var')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8108] Remove unused images from the OPAC

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8108] Remove unused images from the OPAC

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14081|0   |1
is obsolete||

--- Comment #14 from Mason James m...@kohaaloha.com ---
Created attachment 14932
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14932action=edit
Bug 8108 [Follow-up, revised] Remove unused OPAC images

This patch cleans up some loose ends:

- Star ratings images are now in one sprite. Removing
  separate star ratings images.
- Amazon ratings have been removed. Related image files
  are removed by this patch.
- The tag images associated with tag links on the search
  results page were not incorporated into the main sprite.
  Now they are.

Added: The Photoshop file from which the main sprite was
generated, in case that is helpful to others. Each layer
is named, and comments have been added to the CSS
referencing the layer names. The file is GIMP-compatible.

Revisions:
- Rebased on current master
- Ported some changes to CCSR theme
- Removed unused CSS which referred to deleted images

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8108] Remove unused images from the OPAC

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #15 from Mason James m...@kohaaloha.com ---
(In reply to comment #14)
 Created attachment 14932 [details]
 Bug 8108 [Follow-up, revised] Remove unused OPAC images
 
 Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
 Signed-off-by: Mason James m...@kohaaloha.com

testing 1 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp
var')

passing QA - awesome patch Owen :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9497] Make it easier to add to the the list of possible encodings for Z39.50 servers and add ISO 8859-1

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9497

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9497] Make it easier to add to the the list of possible encodings for Z39.50 servers and add ISO 8859-1

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9497

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14876|0   |1
is obsolete||

--- Comment #6 from Mason James m...@kohaaloha.com ---
Created attachment 14933
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14933action=edit
Bug 9497 - Make it easier to add new encodings for Z39.50 servers and add ISO
8859-1

This patch does three things:
- Makes admin/z3950servers.pl create one variable for encoding,
  not one variable for each encoding
- Makes the template create encoding options from a list
- Adds ISO 8859-1 to the list of available encodings
See the bug for a lengthier description

To test:
- Apply the patch
- Edit one Z39.50 server several times, choosing each available encoding in
turn
- Check that for each encoding, the correct encoding is shown both in the list
of
  Z39.50 servers and in the dropdown on the edit screen

Comment: Works as described, no errors.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9497] Make it easier to add to the the list of possible encodings for Z39.50 servers and add ISO 8859-1

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9497

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #7 from Mason James m...@kohaaloha.com ---
(In reply to comment #6)
 Created attachment 14933 [details]
 Bug 9497 - Make it easier to add new encodings for Z39.50 servers and add
 ISO 8859-1
 
 Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
 Signed-off-by: Mason James m...@kohaaloha.com

testing 1 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp
var')

passing QA, works well :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

--- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jared,

there is a little problem on updating the koha-conf.xml file for existing
installations. I have tested this with 2 different installations now and
updating the koha-conf.xml file to add the query parser line does not work for
me.

To reproduce:

1) Apply all patches
2) (Run database update)
3) Update koha-conf.xml:

perl Makefile.PL --prev-install-log ../koha-dev/misc/koha-install-log
make
make test
sudo make upgrade

It prompted me for dom and icu (which I thought I had already activated). It
completed successfully, but checking the generated file, the tag for the query
parser is missing.

Can you please take a look what's going wrong here? I will try to continue
testing with a new installation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14336|0   |1
is obsolete||

--- Comment #32 from Mason James m...@kohaaloha.com ---
Created attachment 14934
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14934action=edit
Bug 8942: Translation process breaks javascript

Signed-off-by: Owen Leonard oleon...@myacpl.org

I tested most scripts affected by this patch and visually verified
all changes. Functionality is unaffected.
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14337|0   |1
is obsolete||

--- Comment #33 from Mason James m...@kohaaloha.com ---
Created attachment 14935
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14935action=edit
Bug 8942: Translation process breaks javascript (followup 1)

Signed-off-by: Owen Leonard oleon...@myacpl.org

Tested all effected functions. No change in functionality.
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14338|0   |1
is obsolete||

--- Comment #34 from Mason James m...@kohaaloha.com ---
Created attachment 14936
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14936action=edit
Bug 8942: Translation process breaks javascript (followup 2)

Signed-off-by: Owen Leonard oleon...@myacpl.org

Tested all changes. Functionality is unchanged. Thanks for the taking
the extra effort to move alert strings into variables.
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #35 from Mason James m...@kohaaloha.com ---
(In reply to comment #34)
 Created attachment 14936 [details]
 Bug 8942: Translation process breaks javascript (followup 2)
 
 Signed-off-by: Owen Leonard oleon...@myacpl.org
 
 Tested all changes. Functionality is unchanged. Thanks for the taking
 the extra effort to move alert strings into variables.
 Signed-off-by: Mason James m...@kohaaloha.com

testing 3 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp
var')

passing QA, works well...

nice patch everyone :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

--- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I set up a new dev installation with Normarc and the conf file still doesn't
show anything related to the query parser:

Last lines of my koha-conf.xml file:
 zebra_bib_index_modedom/zebra_bib_index_mode
 zebra_auth_index_modedom/zebra_auth_index_mode
/config
/yazgfs

When I added the lines you gave me on IRC I was able to successfully test some
searches with the new query syntax, so I think this might be the only piece
missing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #13911|0   |1
is obsolete||

--- Comment #6 from Mason James m...@kohaaloha.com ---
Created attachment 14937
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14937action=edit
Bug 9174: Fix itemtype image display in OPAC lists

Prior to this patch, C4::VirtualShelves::Page did not make sure that
the itemtype images that it chose when displaying itemtype images for
biblio-level itemtypes were for the correct interface, so
even on the OPAC the Intranet icons were requested. On standard
installations, intranet-tmpl is not available to the OPAC.

To test:
1) Set noItemTypeImages to Show and item-level_items to biblio record
2) Create a list and add an item with the default item type (942$c in
   MARC21) set to something with an itemtype image associated with it.
3) View the list in the OPAC.
4) If you are an a standard install, the itemtype image will be a broken
   link. If on a dev install, you can confirm with Firebug or the like
   that the image is pulled from /intranet-tmpl.
5) Apply patch.
6) Run `prove t/db_dependent/Koha.t` to confirm that the behavior of the
   routine used to retrieve the image URL is correct. (Note that you
   must have an item type with the code 'BK')
7) Refresh the list, noting that the display is now correct/the image is
   pulled from opac-tmpl.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
It works as expected. All tests in Koha.t passed.
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14351|0   |1
is obsolete||

--- Comment #7 from Mason James m...@kohaaloha.com ---
Created attachment 14938
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14938action=edit
Bug 9174 follow-up: Eliminate warning and fix POD

Thanks to Marcel for spotting these issues.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC

2013-01-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #8 from Mason James m...@kohaaloha.com ---
(In reply to comment #7)
 Created attachment 14938 [details]
 Bug 9174 follow-up: Eliminate warning and fix POD
 
 Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
 Signed-off-by: Mason James m...@kohaaloha.com

testing 2 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp
var')

passing QA, works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/